@oh-my-pi/pi-coding-agent 3.20.1 → 3.24.0

package/src/core/tools/review.ts

@@ -19,13 +19,6 @@ const PRIORITY_LABELS: Record<number, string> = {
 	3: "P3",
 };
 
-const _PRIORITY_DESCRIPTIONS: Record<number, string> = {
-	0: "Drop everything to fix. Blocking release, operations, or major usage.",
-	1: "Urgent. Should be addressed in the next cycle.",
-	2: "Normal. To be fixed eventually.",
-	3: "Low. Nice to have.",
-};
-
 // report_finding schema
 const ReportFindingParams = Type.Object({
 	title: Type.String({
@@ -62,8 +55,6 @@ export const reportFindingTool: AgentTool<typeof ReportFindingParams, ReportFind
 	label: "Report Finding",
 	description: "Report a code review finding. Use this for each issue found. Call submit_review when done.",
 	parameters: ReportFindingParams,
-	hidden: true,
-
 	async execute(_toolCallId, params, _signal, _onUpdate, _ctx) {
 		const { title, body, priority, confidence, file_path, line_start, line_end } = params;
 		const location = `${file_path}:${line_start}${line_end !== line_start ? `-${line_end}` : ""}`;
@@ -72,7 +63,9 @@ export const reportFindingTool: AgentTool<typeof ReportFindingParams, ReportFind
 			content: [
 				{
 					type: "text",
-					text: `Finding recorded: ${PRIORITY_LABELS[priority]} ${title}\nLocation: ${location}\nConfidence: ${(confidence * 100).toFixed(0)}%`,
+					text: `Finding recorded: ${PRIORITY_LABELS[priority]} ${title}\nLocation: ${location}\nConfidence: ${(
+						confidence * 100
+					).toFixed(0)}%`,
 				},
 			],
 			details: { title, body, priority, confidence, file_path, line_start, line_end },
@@ -84,7 +77,10 @@ export const reportFindingTool: AgentTool<typeof ReportFindingParams, ReportFind
 		const color = args.priority === 0 ? "error" : args.priority === 1 ? "warning" : "muted";
 		const titleText = String(args.title).replace(/^\[P\d\]\s*/, "");
 		return new Text(
-			`${theme.fg("toolTitle", theme.bold("report_finding "))}${theme.fg(color, `[${priority}]`)} ${theme.fg("dim", titleText)}`,
+			`${theme.fg("toolTitle", theme.bold("report_finding "))}${theme.fg(color, `[${priority}]`)} ${theme.fg(
+				"dim",
+				titleText,
+			)}`,
 			0,
 			0,
 		);
@@ -99,7 +95,9 @@ export const reportFindingTool: AgentTool<typeof ReportFindingParams, ReportFind
 
 		const priority = PRIORITY_LABELS[details.priority] ?? "P?";
 		const color = details.priority === 0 ? "error" : details.priority === 1 ? "warning" : "muted";
-		const location = `${details.file_path}:${details.line_start}${details.line_end !== details.line_start ? `-${details.line_end}` : ""}`;
+		const location = `${details.file_path}:${details.line_start}${
+			details.line_end !== details.line_start ? `-${details.line_end}` : ""
+		}`;
 
 		return new Text(
 			`${theme.fg("success", theme.status.success)} ${theme.fg(color, `[${priority}]`)} ${theme.fg("dim", location)}`,
@@ -135,13 +133,16 @@ export const submitReviewTool: AgentTool<typeof SubmitReviewParams, SubmitReview
 	label: "Submit Review",
 	description: "Submit the final review verdict. Call this after all findings have been reported.",
 	parameters: SubmitReviewParams,
-	hidden: true,
 
 	async execute(_toolCallId, params, _signal, _onUpdate, _ctx) {
 		const { overall_correctness, explanation, confidence } = params;
 
 		let summary = `## Review Summary\n\n`;
-		summary += `**Verdict:** ${overall_correctness === "correct" ? `${theme.status.success} Patch is correct` : `${theme.status.error} Patch is incorrect`}\n`;
+		summary += `**Verdict:** ${
+			overall_correctness === "correct"
+				? `${theme.status.success} Patch is correct`
+				: `${theme.status.error} Patch is incorrect`
+		}\n`;
 		summary += `**Confidence:** ${(confidence * 100).toFixed(0)}%\n\n`;
 		summary += explanation;
 
@@ -155,7 +156,10 @@ export const submitReviewTool: AgentTool<typeof SubmitReviewParams, SubmitReview
 		const verdict = args.overall_correctness === "correct" ? "correct" : "incorrect";
 		const color = args.overall_correctness === "correct" ? "success" : "error";
 		return new Text(
-			`${theme.fg("toolTitle", theme.bold("submit_review "))}${theme.fg(color, verdict)} ${theme.fg("dim", `(${((args.confidence as number) * 100).toFixed(0)}%)`)}`,
+			`${theme.fg("toolTitle", theme.bold("submit_review "))}${theme.fg(color, verdict)} ${theme.fg(
+				"dim",
+				`(${((args.confidence as number) * 100).toFixed(0)}%)`,
+			)}`,
 			0,
 			0,
 		);
@@ -174,7 +178,10 @@ export const submitReviewTool: AgentTool<typeof SubmitReviewParams, SubmitReview
 
 		container.addChild(
 			new Text(
-				`${theme.fg(verdictColor, verdictIcon)} Patch is ${theme.fg(verdictColor, details.overall_correctness)} ${theme.fg("dim", `(${(details.confidence * 100).toFixed(0)}% confidence)`)}`,
+				`${theme.fg(verdictColor, verdictIcon)} Patch is ${theme.fg(
+					verdictColor,
+					details.overall_correctness,
+				)} ${theme.fg("dim", `(${(details.confidence * 100).toFixed(0)}% confidence)`)}`,
 				0,
 				0,
 			),
@@ -189,14 +196,6 @@ export const submitReviewTool: AgentTool<typeof SubmitReviewParams, SubmitReview
 	},
 };
 
-export function createReportFindingTool(): AgentTool<typeof ReportFindingParams, ReportFindingDetails, Theme> {
-	return reportFindingTool;
-}
-
-export function createSubmitReviewTool(): AgentTool<typeof SubmitReviewParams, SubmitReviewDetails, Theme> {
-	return submitReviewTool;
-}
-
 // Re-export types for external use
 export type { ReportFindingDetails, SubmitReviewDetails };
 
@@ -264,7 +263,9 @@ subprocessToolRegistry.register<SubmitReviewDetails>("submit_review", {
 		const verdictColor = data.overall_correctness === "correct" ? "success" : "error";
 		const verdictIcon = data.overall_correctness === "correct" ? theme.status.success : theme.status.error;
 		return new Text(
-			`${theme.fg(verdictColor, verdictIcon)} Review: ${theme.fg(verdictColor, data.overall_correctness)} (${(data.confidence * 100).toFixed(0)}%)`,
+			`${theme.fg(verdictColor, verdictIcon)} Review: ${theme.fg(verdictColor, data.overall_correctness)} (${(
+				data.confidence * 100
+			).toFixed(0)}%)`,
 			0,
 			0,
 		);

package/src/core/tools/rulebook.ts

@@ -9,6 +9,7 @@
 import type { AgentTool } from "@oh-my-pi/pi-agent-core";
 import { Type } from "@sinclair/typebox";
 import type { Rule } from "../../capability/rule";
+import type { ToolSession } from "./index";
 
 export interface RulebookToolDetails {
 	type: "rulebook";
@@ -23,9 +24,14 @@ const rulebookSchema = Type.Object({
 
 /**
  * Create a rulebook tool with access to discovered rules.
- * @param rules - Array of discovered rules (non-TTSR rules with descriptions)
+ * Returns null if no rules available.
  */
-export function createRulebookTool(rules: Rule[]): AgentTool<typeof rulebookSchema> {
+export function createRulebookTool(session: ToolSession): AgentTool<typeof rulebookSchema> | null {
+	const rules = session.rulebookRules;
+	if (!rules || rules.length === 0) {
+		return null;
+	}
+
 	// Build lookup map for O(1) access
 	const ruleMap = new Map<string, Rule>();
 	for (const rule of rules) {
@@ -37,7 +43,9 @@ export function createRulebookTool(rules: Rule[]): AgentTool<typeof rulebookSche
 	return {
 		name: "rulebook",
 		label: "Rulebook",
-		description: `Fetch the full content of a project rule by name. Use this when a rule listed in <available_rules> is relevant to your current task. Available: ${ruleNames.join(", ") || "(none)"}`,
+		description: `Fetch the full content of a project rule by name. Use this when a rule listed in <available_rules> is relevant to your current task. Available: ${
+			ruleNames.join(", ") || "(none)"
+		}`,
 		parameters: rulebookSchema,
 		execute: async (_toolCallId: string, { name }: { name: string }) => {
 			const rule = ruleMap.get(name);

package/src/core/tools/task/agents.ts

@@ -5,7 +5,6 @@
  */
 
 // Embed agent markdown files at build time
-import browserMd from "../../../prompts/browser.md" with { type: "text" };
 import exploreMd from "../../../prompts/explore.md" with { type: "text" };
 import planMd from "../../../prompts/plan.md" with { type: "text" };
 import reviewerMd from "../../../prompts/reviewer.md" with { type: "text" };
@@ -13,11 +12,37 @@ import taskMd from "../../../prompts/task.md" with { type: "text" };
 import type { AgentDefinition, AgentSource } from "./types";
 
 const EMBEDDED_AGENTS: { name: string; content: string }[] = [
-	{ name: "browser.md", content: browserMd },
 	{ name: "explore.md", content: exploreMd },
 	{ name: "plan.md", content: planMd },
 	{ name: "reviewer.md", content: reviewerMd },
-	{ name: "task.md", content: taskMd },
+	{
+		name: "task.md",
+		content: `---
+name: task
+description: General-purpose subagent with full capabilities for delegated multi-step tasks
+spawns: explore
+model: default
+---
+${taskMd}`,
+	},
+	{
+		name: "quick_task.md",
+		content: `---
+name: quick_task
+description: Quick task for fast execution
+model: pi/smol
+---
+${taskMd}`,
+	},
+	{
+		name: "deep_task.md",
+		content: `---
+name: deep_task
+description: Deep task for comprehensive reasoning
+model: pi/slow
+---
+${taskMd}`,
+	},
 ];
 
 /**
@@ -88,16 +113,12 @@ function parseAgent(fileName: string, content: string, source: AgentSource): Age
 		spawns = "*";
 	}
 
-	const recursive =
-		frontmatter.recursive === undefined ? false : frontmatter.recursive === "true" || frontmatter.recursive === "1";
-
 	return {
 		name: frontmatter.name,
 		description: frontmatter.description,
 		tools: tools && tools.length > 0 ? tools : undefined,
 		spawns,
 		model: frontmatter.model,
-		recursive,
 		systemPrompt: body,
 		source,
 		filePath: `embedded:${fileName}`,

package/src/core/tools/task/discovery.ts

@@ -126,18 +126,12 @@ function loadAgentsFromDir(dir: string, source: AgentSource): AgentDefinition[]
 			spawns = "*";
 		}
 
-		const recursive =
-			frontmatter.recursive === undefined
-				? undefined
-				: frontmatter.recursive === "true" || frontmatter.recursive === "1";
-
 		agents.push({
 			name: frontmatter.name,
 			description: frontmatter.description,
 			tools: tools && tools.length > 0 ? tools : undefined,
 			spawns,
 			model: frontmatter.model,
-			recursive,
 			systemPrompt: body,
 			source,
 			filePath,