@oh-my-pi/pi-coding-agent 3.14.0 → 3.15.0

package/src/core/settings-manager.ts

@@ -3,6 +3,7 @@ import { dirname, join } from "node:path";
 import { type Settings as SettingsItem, settingsCapability } from "../capability/settings";
 import { getAgentDir } from "../config";
 import { loadSync } from "../discovery";
+import type { SymbolPreset } from "../modes/interactive/theme/theme";
 
 export interface CompactionSettings {
 	enabled?: boolean; // default: true
@@ -68,6 +69,8 @@ export interface EditSettings {
 	fuzzyMatch?: boolean; // default: true (accept high-confidence fuzzy matches for whitespace/indentation)
 }
 
+export type { SymbolPreset };
+
 export interface TtsrSettings {
 	enabled?: boolean; // default: true
 	/** What to do with partial output when TTSR triggers: "keep" shows interrupted attempt, "discard" removes it */
@@ -78,6 +81,45 @@ export interface TtsrSettings {
 	repeatGap?: number; // default: 10
 }
 
+export type StatusLineSegmentId =
+	| "pi"
+	| "model"
+	| "path"
+	| "git"
+	| "subagents"
+	| "token_in"
+	| "token_out"
+	| "token_total"
+	| "cost"
+	| "context_pct"
+	| "context_total"
+	| "time_spent"
+	| "time"
+	| "session"
+	| "hostname"
+	| "cache_read"
+	| "cache_write";
+
+export type StatusLineSeparatorStyle = "powerline" | "powerline-thin" | "slash" | "pipe" | "block" | "none" | "ascii";
+
+export type StatusLinePreset = "default" | "minimal" | "compact" | "full" | "nerd" | "ascii" | "custom";
+
+export interface StatusLineSegmentOptions {
+	model?: { showThinkingLevel?: boolean };
+	path?: { abbreviate?: boolean; maxLength?: number; stripWorkPrefix?: boolean };
+	git?: { showBranch?: boolean; showStaged?: boolean; showUnstaged?: boolean; showUntracked?: boolean };
+	time?: { format?: "12h" | "24h"; showSeconds?: boolean };
+}
+
+export interface StatusLineSettings {
+	preset?: StatusLinePreset;
+	leftSegments?: StatusLineSegmentId[];
+	rightSegments?: StatusLineSegmentId[];
+	separator?: StatusLineSeparatorStyle;
+	segmentOptions?: StatusLineSegmentOptions;
+	showHookStatus?: boolean;
+}
+
 export interface Settings {
 	lastChangelogVersion?: string;
 	/** Model roles map: { default: "provider/modelId", small: "provider/modelId", ... } */
@@ -86,6 +128,7 @@ export interface Settings {
 	queueMode?: "all" | "one-at-a-time";
 	interruptMode?: "immediate" | "wait";
 	theme?: string;
+	symbolPreset?: SymbolPreset; // default: uses theme's preset or "unicode"
 	compaction?: CompactionSettings;
 	branchSummary?: BranchSummarySettings;
 	retry?: RetrySettings;
@@ -106,6 +149,7 @@ export interface Settings {
 	ttsr?: TtsrSettings;
 	disabledProviders?: string[]; // Discovery provider IDs that are disabled
 	disabledExtensions?: string[]; // Individual extension IDs that are disabled (e.g., "skill:commit")
+	statusLine?: StatusLineSettings; // Status line configuration
 }
 
 /** Deep merge settings: project/overrides take precedence, nested objects merge recursively */
@@ -298,6 +342,15 @@ export class SettingsManager {
 		this.save();
 	}
 
+	getSymbolPreset(): SymbolPreset | undefined {
+		return this.settings.symbolPreset;
+	}
+
+	setSymbolPreset(preset: SymbolPreset): void {
+		this.globalSettings.symbolPreset = preset;
+		this.save();
+	}
+
 	getDefaultThinkingLevel(): "off" | "minimal" | "low" | "medium" | "high" | "xhigh" | undefined {
 		return this.settings.defaultThinkingLevel;
 	}
@@ -683,4 +736,125 @@ export class SettingsManager {
 		this.globalSettings.ttsr.repeatGap = gap;
 		this.save();
 	}
+
+	// ═══════════════════════════════════════════════════════════════════════════
+	// Status Line Settings
+	// ═══════════════════════════════════════════════════════════════════════════
+
+	getStatusLineSettings(): StatusLineSettings {
+		return this.settings.statusLine ? { ...this.settings.statusLine } : {};
+	}
+
+	getStatusLinePreset(): StatusLinePreset {
+		return this.settings.statusLine?.preset ?? "default";
+	}
+
+	setStatusLinePreset(preset: StatusLinePreset): void {
+		if (!this.globalSettings.statusLine) {
+			this.globalSettings.statusLine = {};
+		}
+		if (preset !== "custom") {
+			delete this.globalSettings.statusLine.leftSegments;
+			delete this.globalSettings.statusLine.rightSegments;
+			delete this.globalSettings.statusLine.segmentOptions;
+		}
+		this.globalSettings.statusLine.preset = preset;
+		this.save();
+	}
+
+	getStatusLineSeparator(): StatusLineSeparatorStyle {
+		return this.settings.statusLine?.separator ?? "powerline-thin";
+	}
+
+	setStatusLineSeparator(separator: StatusLineSeparatorStyle): void {
+		if (!this.globalSettings.statusLine) {
+			this.globalSettings.statusLine = {};
+		}
+		this.globalSettings.statusLine.separator = separator;
+		this.save();
+	}
+
+	getStatusLineLeftSegments(): StatusLineSegmentId[] {
+		return [...(this.settings.statusLine?.leftSegments ?? [])];
+	}
+
+	setStatusLineLeftSegments(segments: StatusLineSegmentId[]): void {
+		if (!this.globalSettings.statusLine) {
+			this.globalSettings.statusLine = {};
+		}
+		this.globalSettings.statusLine.leftSegments = segments;
+		// Setting segments explicitly implies custom preset
+		if (this.globalSettings.statusLine.preset !== "custom") {
+			this.globalSettings.statusLine.preset = "custom";
+		}
+		this.save();
+	}
+
+	getStatusLineRightSegments(): StatusLineSegmentId[] {
+		return [...(this.settings.statusLine?.rightSegments ?? [])];
+	}
+
+	setStatusLineRightSegments(segments: StatusLineSegmentId[]): void {
+		if (!this.globalSettings.statusLine) {
+			this.globalSettings.statusLine = {};
+		}
+		this.globalSettings.statusLine.rightSegments = segments;
+		// Setting segments explicitly implies custom preset
+		if (this.globalSettings.statusLine.preset !== "custom") {
+			this.globalSettings.statusLine.preset = "custom";
+		}
+		this.save();
+	}
+
+	getStatusLineSegmentOptions(): StatusLineSegmentOptions {
+		return { ...this.settings.statusLine?.segmentOptions };
+	}
+
+	setStatusLineSegmentOption<K extends keyof StatusLineSegmentOptions>(
+		segment: K,
+		option: keyof NonNullable<StatusLineSegmentOptions[K]>,
+		value: boolean | number | string,
+	): void {
+		if (!this.globalSettings.statusLine) {
+			this.globalSettings.statusLine = {};
+		}
+		if (!this.globalSettings.statusLine.segmentOptions) {
+			this.globalSettings.statusLine.segmentOptions = {};
+		}
+		if (!this.globalSettings.statusLine.segmentOptions[segment]) {
+			this.globalSettings.statusLine.segmentOptions[segment] = {} as NonNullable<StatusLineSegmentOptions[K]>;
+		}
+		(this.globalSettings.statusLine.segmentOptions[segment] as Record<string, unknown>)[option as string] = value;
+		this.save();
+	}
+
+	clearStatusLineSegmentOption<K extends keyof StatusLineSegmentOptions>(
+		segment: K,
+		option: keyof NonNullable<StatusLineSegmentOptions[K]>,
+	): void {
+		const segmentOptions = this.globalSettings.statusLine?.segmentOptions;
+		if (!segmentOptions || !segmentOptions[segment]) {
+			return;
+		}
+		delete (segmentOptions[segment] as Record<string, unknown>)[option as string];
+		if (Object.keys(segmentOptions[segment] as Record<string, unknown>).length === 0) {
+			delete segmentOptions[segment];
+		}
+		if (Object.keys(segmentOptions).length === 0) {
+			delete this.globalSettings.statusLine?.segmentOptions;
+		}
+		this.save();
+	}
+
+	getStatusLineShowHookStatus(): boolean {
+		return this.settings.statusLine?.showHookStatus ?? true;
+	}
+
+	setStatusLineShowHookStatus(show: boolean): void {
+		if (!this.globalSettings.statusLine) {
+			this.globalSettings.statusLine = {};
+		}
+		this.globalSettings.statusLine.showHookStatus = show;
+		this.save();
+	}
 }

package/src/core/system-prompt.ts

@@ -9,6 +9,7 @@ import type { Rule } from "../capability/rule";
 import { systemPromptCapability } from "../capability/system-prompt";
 import { getDocsPath, getExamplesPath, getReadmePath } from "../config";
 import { type ContextFile, loadSync, type SystemPrompt as SystemPromptFile } from "../discovery/index";
+import systemPromptTemplate from "../prompts/system-prompt.md" with { type: "text" };
 import type { SkillsSettings } from "./settings-manager";
 import { formatSkillsForPrompt, loadSkills, type Skill } from "./skills";
 import type { ToolName } from "./tools/index";
@@ -390,20 +391,14 @@ export function buildSystemPrompt(options: BuildSystemPromptOptions = {}): strin
 	const guidelines = guidelinesList.map((g) => `- ${g}`).join("\n");
 
 	// Build the prompt with anti-bash rules prominently placed
-	let prompt = `You are an expert coding assistant. You help users with coding tasks by reading files, executing commands, editing code, and writing new files.
-
-Available tools:
-${toolsList}
-${antiBashSection ? `\n${antiBashSection}\n` : ""}
-Guidelines:
-${guidelines}
-
-Documentation:
-- Main documentation: ${readmePath}
-- Additional docs: ${docsPath}
-- Examples: ${examplesPath} (hooks, custom tools, SDK)
-- When asked to create: custom models/providers (README.md), hooks (docs/hooks.md, examples/hooks/), custom tools (docs/custom-tools.md, docs/tui.md, examples/custom-tools/), themes (docs/theme.md), skills (docs/skills.md)
-- Always read the doc, examples, AND follow .md cross-references before implementing`;
+	const antiBashBlock = antiBashSection ? `\n${antiBashSection}\n` : "";
+	let prompt = systemPromptTemplate
+		.replaceAll("{{toolsList}}", toolsList)
+		.replaceAll("{{antiBashSection}}", antiBashBlock)
+		.replaceAll("{{guidelines}}", guidelines)
+		.replaceAll("{{readmePath}}", readmePath)
+		.replaceAll("{{docsPath}}", docsPath)
+		.replaceAll("{{examplesPath}}", examplesPath);
 
 	if (appendSection) {
 		prompt += appendSection;

package/src/core/title-generator.ts

@@ -4,18 +4,12 @@
 
 import type { Model } from "@oh-my-pi/pi-ai";
 import { completeSimple } from "@oh-my-pi/pi-ai";
+import titleSystemPrompt from "../prompts/title-system.md" with { type: "text" };
 import { logger } from "./logger";
 import type { ModelRegistry } from "./model-registry";
 import { findSmolModel } from "./model-resolver";
 
-const TITLE_SYSTEM_PROMPT = `Generate a very short title (3-6 words) for a coding session based on the user's first message. The title should capture the main task or topic. Output ONLY the title, nothing else. No quotes, no punctuation at the end.
-
-Examples:
-- "Fix TypeScript compilation errors"
-- "Add user authentication"
-- "Refactor database queries"
-- "Debug payment webhook"
-- "Update React components"`;
+const TITLE_SYSTEM_PROMPT = titleSystemPrompt;
 
 const MAX_INPUT_CHARS = 2000;
 

package/src/core/tools/ask.ts

@@ -17,6 +17,8 @@
 
 import type { AgentTool, AgentToolContext, AgentToolUpdateCallback } from "@oh-my-pi/pi-agent-core";
 import { Type } from "@sinclair/typebox";
+import { theme } from "../../modes/interactive/theme/theme";
+import askDescription from "../../prompts/tools/ask.md" with { type: "text" };
 
 // =============================================================================
 // Types
@@ -53,36 +55,9 @@ export interface AskToolDetails {
 // =============================================================================
 
 const OTHER_OPTION = "Other (type your own)";
-const DONE_OPTION = "✓ Done selecting";
-
-const DESCRIPTION = `Use this tool when you need to ask the user questions during execution. This allows you to:
-1. Gather user preferences or requirements
-2. Clarify ambiguous instructions
-3. Get decisions on implementation choices as you work
-4. Offer choices to the user about what direction to take.
-
-Usage notes:
-- Users will always be able to select "Other" to provide custom text input
-- Use multi: true to allow multiple answers to be selected for a question
-- If you recommend a specific option, make that the first option in the list and add "(Recommended)" at the end of the label
-
-Example usage:
-
-<example>
-assistant: Let me ask which features you want to include.
-assistant: Uses the ask tool:
-{
-  "question": "Which features should I implement?",
-  "options": [
-    {"label": "Authentication"},
-    {"label": "API endpoints"},
-    {"label": "Database models"},
-    {"label": "Unit tests"},
-    {"label": "Documentation"}
-  ],
-  "multi": true
+function getDoneOptionLabel(): string {
+	return `${theme.status.success} Done selecting`;
 }
-</example>`;
 
 // =============================================================================
 // Tool Implementation
@@ -92,7 +67,7 @@ export function createAskTool(_cwd: string): AgentTool<typeof askSchema, AskTool
 	return {
 		name: "ask",
 		label: "Ask",
-		description: DESCRIPTION,
+		description: askDescription,
 		parameters: askSchema,
 
 		async execute(
@@ -104,6 +79,7 @@ export function createAskTool(_cwd: string): AgentTool<typeof askSchema, AskTool
 		) {
 			const { question, options, multi = false } = params;
 			const optionLabels = options.map((o) => o.label);
+			const doneLabel = getDoneOptionLabel();
 
 			// Headless fallback - return error if no UI available
 			if (!context?.hasUI || !context.ui) {
@@ -137,12 +113,12 @@ export function createAskTool(_cwd: string): AgentTool<typeof askSchema, AskTool
 
 					// Add "Done" option if any selected
 					if (selected.size > 0) {
-						opts.push(DONE_OPTION);
+						opts.push(doneLabel);
 					}
 
-					// Add all options with [X] or [ ] prefix
+					// Add all options with checkbox prefix
 					for (const opt of optionLabels) {
-						const checkbox = selected.has(opt) ? "[X]" : "[ ]";
+						const checkbox = selected.has(opt) ? theme.checkbox.checked : theme.checkbox.unchecked;
 						opts.push(`${checkbox} ${opt}`);
 					}
 
@@ -152,7 +128,7 @@ export function createAskTool(_cwd: string): AgentTool<typeof askSchema, AskTool
 					const prefix = selected.size > 0 ? `(${selected.size} selected) ` : "";
 					const choice = await ui.select(`${prefix}${question}`, opts);
 
-					if (choice === undefined || choice === DONE_OPTION) break;
+					if (choice === undefined || choice === doneLabel) break;
 
 					if (choice === OTHER_OPTION) {
 						const input = await ui.input("Enter your response:");
@@ -161,9 +137,15 @@ export function createAskTool(_cwd: string): AgentTool<typeof askSchema, AskTool
 					}
 
 					// Toggle selection - extract the actual option name
-					const optMatch = choice.match(/^\[.\] (.+)$/);
-					if (optMatch) {
-						const opt = optMatch[1];
+					const checkedPrefix = `${theme.checkbox.checked} `;
+					const uncheckedPrefix = `${theme.checkbox.unchecked} `;
+					let opt: string | undefined;
+					if (choice.startsWith(checkedPrefix)) {
+						opt = choice.slice(checkedPrefix.length);
+					} else if (choice.startsWith(uncheckedPrefix)) {
+						opt = choice.slice(uncheckedPrefix.length);
+					}
+					if (opt) {
 						if (selected.has(opt)) {
 							selected.delete(opt);
 						} else {

package/src/core/tools/bash.ts

@@ -1,5 +1,6 @@
 import type { AgentTool } from "@oh-my-pi/pi-agent-core";
 import { Type } from "@sinclair/typebox";
+import bashDescription from "../../prompts/tools/bash.md" with { type: "text" };
 import { executeBash } from "../bash-executor";
 import { DEFAULT_MAX_BYTES, formatSize, type TruncationResult, truncateTail } from "./truncate";
 
@@ -17,43 +18,7 @@ export function createBashTool(cwd: string): AgentTool<typeof bashSchema> {
 	return {
 		name: "bash",
 		label: "Bash",
-		description: `Executes a given bash command in a persistent shell session with optional timeout, ensuring proper handling and security measures.
-
-IMPORTANT: This tool is for terminal operations like git, npm, docker, etc. DO NOT use it for file operations (reading, writing, editing, searching, finding files) - use the specialized tools for this instead.
-
-Before executing the command, please follow these steps:
-
-1. Directory Verification:
-   - If the command will create new directories or files, first use \`ls\` to verify the parent directory exists and is the correct location
-   - For example, before running "mkdir foo/bar", first use \`ls foo\` to check that "foo" exists and is the intended parent directory
-
-2. Command Execution:
-   - Always quote file paths that contain spaces with double quotes (e.g., cd "path with spaces/file.txt")
-   - Examples of proper quoting:
-     - cd "/Users/name/My Documents" (correct)
-     - cd /Users/name/My Documents (incorrect - will fail)
-     - python "/path/with spaces/script.py" (correct)
-     - python /path/with spaces/script.py (incorrect - will fail)
-   - After ensuring proper quoting, execute the command.
-   - Capture the output of the command.
-
-Usage notes:
-  - The command argument is required.
-  - You can specify an optional timeout in seconds.
-  - It is very helpful if you write a clear, concise description of what this command does in 5-10 words.
-  - If the output exceeds 50KB characters, output will be truncated before being returned to you.
-  - Avoid using Bash with the \`find\`, \`grep\`, \`cat\`, \`head\`, \`tail\`, \`sed\`, \`awk\`, or \`echo\` commands, unless explicitly instructed or when these commands are truly necessary for the task. Instead, always prefer using the dedicated tools for these commands:
-    - File search: Use find (NOT find or ls)
-    - Content search: Use grep (NOT grep or rg)
-    - Read files: Use read (NOT cat/head/tail)
-    - Edit files: Use edit (NOT sed/awk)
-    - Write files: Use write (NOT echo >/cat <<EOF)
-    - Communication: Output text directly (NOT echo/printf)
-  - When issuing multiple commands:
-    - If the commands are independent and can run in parallel, make multiple bash tool calls in a single message. For example, if you need to run "git status" and "git diff", send a single message with two bash tool calls in parallel.
-    - If the commands depend on each other and must run sequentially, use a single bash call with '&&' to chain them together (e.g., \`git add . && git commit -m "message" && git push\`). For instance, if one operation must complete before another starts (like mkdir before cp, Write before Bash for git operations, or git add before git commit), run these operations sequentially instead.
-    - Use ';' only when you need to run commands sequentially but don't care if earlier commands fail
-    - DO NOT use newlines to separate commands (newlines are ok in quoted strings)`,
+		description: bashDescription,
 		parameters: bashSchema,
 		execute: async (
 			_toolCallId: string,

package/src/core/tools/edit.ts

@@ -1,5 +1,6 @@
 import type { AgentTool } from "@oh-my-pi/pi-agent-core";
 import { Type } from "@sinclair/typebox";
+import editDescription from "../../prompts/tools/edit.md" with { type: "text" };
 import {
 	DEFAULT_FUZZY_THRESHOLD,
 	detectLineEnding,
@@ -43,15 +44,7 @@ export function createEditTool(cwd: string, options: EditToolOptions = {}): Agen
 	return {
 		name: "edit",
 		label: "Edit",
-		description: `Performs string replacements in files with fuzzy whitespace matching. 
-
-Usage:
-- You must use your read tool at least once in the conversation before editing. This tool will error if you attempt an edit without reading the file. 
-- Fuzzy matching handles minor whitespace/indentation differences automatically - you don't need to match indentation exactly.
-- ALWAYS prefer editing existing files in the codebase. NEVER write new files unless explicitly required.
-- Only use emojis if the user explicitly requests it. Avoid adding emojis to files unless asked.
-- The edit will FAIL if old_string is not unique in the file. Either provide a larger string with more surrounding context to make it unique or use replace_all to change every instance of old_string. 
-- Use replace_all for replacing and renaming strings across the file. This parameter is useful if you want to rename a variable for instance.`,
+		description: editDescription,
 		parameters: editSchema,
 		execute: async (
 			_toolCallId: string,