@oh-my-pi/pi-coding-agent 17.2.13 → 17.2.15

package/src/modes/controllers/selector-controller.ts

@@ -98,7 +98,6 @@ import { renderSegmentTrack } from "../components/segment-track";
 import { SessionAccountSelectorComponent } from "../components/session-account-selector";
 import { SessionSelectorComponent, type SessionSelectorOptions } from "../components/session-selector";
 import { SettingsSelectorComponent } from "../components/settings-selector";
-import { StrippedToolCallsPlaceholder } from "../components/stripped-tool-calls-placeholder";
 import { ToolExecutionComponent } from "../components/tool-execution";
 import { TranscriptBlock } from "../components/transcript-container";
 import { TreeSelectorComponent } from "../components/tree-selector";
@@ -479,6 +478,11 @@ export class SelectorController {
 					this.ctx.showError(`Failed to apply vision mode: ${err}`);
 				});
 				break;
+			case "externalThinking":
+				void this.ctx.session.setThinkToolEnabled(value as boolean).catch(err => {
+					this.ctx.showError(`Failed to apply external thinking: ${err}`);
+				});
+				break;
 
 			case "autocompleteMaxVisible":
 				this.ctx.editor.setAutocompleteMaxVisible(typeof value === "number" ? value : Number(value));
@@ -490,15 +494,13 @@ export class SelectorController {
 				this.ctx.hideToolActivity = hidden;
 				if (!hidden) this.ctx.toolOutputExpanded = false;
 				for (const child of this.ctx.chatContainer.children) {
-					if (child instanceof ToolExecutionComponent || child instanceof ReadToolGroupComponent) {
-						if (!hidden) child.setExpanded(false);
-						child.setToolActivityVisible(!hidden);
+					if (!hidden && (child instanceof ToolExecutionComponent || child instanceof ReadToolGroupComponent)) {
+						child.setExpanded(false);
 					} else if (child instanceof AssistantMessageComponent) {
 						child.setToolResultImagesVisible(!hidden);
-					} else if (child instanceof StrippedToolCallsPlaceholder) {
-						child.setToolActivityVisible(!hidden);
 					}
 				}
+				this.ctx.chatContainer.setToolActivityVisible(!hidden);
 				if (hidden) this.ctx.ui.clearInlineImages();
 				this.ctx.ui.resetDisplay();
 				break;

package/src/modes/interactive-mode.ts

@@ -81,7 +81,7 @@ import type { CompactOptions } from "../extensibility/extensions/types";
 import type { Skill } from "../extensibility/skills";
 import { loadSlashCommands } from "../extensibility/slash-commands";
 import type { Goal, GoalModeState } from "../goals/state";
-import { resolveLocalUrlToPath } from "../internal-urls";
+import { copyLocalArtifacts, resolveLocalUrlToPath } from "../internal-urls";
 import { LSP_STARTUP_EVENT_CHANNEL, type LspStartupEvent } from "../lsp/startup-events";
 import type { MCPManager } from "../mcp";
 import {
@@ -838,6 +838,7 @@ export class InteractiveMode implements InteractiveModeContext {
 		this.editor.setTopBorderProvider(availableWidth => this.statusLine.getTopBorder(availableWidth));
 
 		this.hideToolActivity = settings.get("display.hideToolActivity");
+		this.chatContainer.setToolActivityVisible(!this.hideToolActivity);
 		this.hideThinkingBlock = settings.get("hideThinkingBlock");
 		this.proseOnlyThinking = settings.get("proseOnlyThinking");
 
@@ -3167,42 +3168,6 @@ export class InteractiveMode implements InteractiveModeContext {
 		});
 	}
 
-	async #copyLocalArtifactsForFreshSession(sourceRoot: string, destinationRoot: string): Promise<void> {
-		if (sourceRoot === destinationRoot) return;
-
-		let sourceRootStat: { isDirectory(): boolean };
-		try {
-			sourceRootStat = await fs.lstat(sourceRoot);
-		} catch (error) {
-			if (isEnoent(error)) return;
-			throw error;
-		}
-
-		if (!sourceRootStat.isDirectory()) return;
-
-		await fs.mkdir(destinationRoot, { recursive: true });
-		await this.#copyLocalArtifactEntries(sourceRoot, destinationRoot);
-	}
-
-	async #copyLocalArtifactEntries(sourceDir: string, destinationDir: string): Promise<void> {
-		const entries = await fs.readdir(sourceDir, { withFileTypes: true });
-		for (const entry of entries) {
-			const sourcePath = path.join(sourceDir, entry.name);
-			const destinationPath = path.join(destinationDir, entry.name);
-
-			if (entry.isDirectory()) {
-				await fs.mkdir(destinationPath, { recursive: true });
-				await this.#copyLocalArtifactEntries(sourcePath, destinationPath);
-				continue;
-			}
-
-			if (entry.isFile()) {
-				await fs.mkdir(path.dirname(destinationPath), { recursive: true });
-				await fs.copyFile(sourcePath, destinationPath);
-			}
-		}
-	}
-
 	async #approvePlan(
 		planContent: string,
 		options: {
@@ -3236,7 +3201,7 @@ export class InteractiveMode implements InteractiveModeContext {
 				const oldLocalRoot = this.#resolveLocalRoot();
 				await this.handleClearCommand();
 				const newLocalRoot = this.#resolveLocalRoot();
-				await this.#copyLocalArtifactsForFreshSession(oldLocalRoot, newLocalRoot);
+				await copyLocalArtifacts(oldLocalRoot, newLocalRoot);
 				const newLocalPath = resolveLocalUrlToPath(options.planFilePath, {
 					getArtifactsDir: () => this.sessionManager.getArtifactsDir(),
 					getSessionId: () => this.sessionManager.getSessionId(),
@@ -4402,8 +4367,8 @@ export class InteractiveMode implements InteractiveModeContext {
 		this.ui.requestRender();
 	}
 
-	showWarning(message: string): void {
-		this.#uiHelpers.showWarning(message);
+	showWarning(message: string, options?: { hideWithToolActivity?: boolean }): void {
+		this.#uiHelpers.showWarning(message, options);
 	}
 
 	#handleLspStartupEvent(event: LspStartupEvent): void {

package/src/modes/print-mode.ts

@@ -8,11 +8,9 @@
 import type { AgentMessage } from "@oh-my-pi/pi-agent-core";
 import type { ImageContent } from "@oh-my-pi/pi-ai";
 import { logger, sanitizeText } from "@oh-my-pi/pi-utils";
-import { resolvePlanModelTransition } from "../plan-mode/model-transition";
 import { type AgentSession, type AgentSessionEvent, SHUTDOWN_CONSOLIDATE_BUDGET_MS } from "../session/agent-session";
 import { isSilentAbort } from "../session/messages";
 import { flushTelemetryExport } from "../telemetry-export";
-import { PROPOSE_DEVICE_NAME, writeDeviceDispatch } from "../tools/resolve";
 import { initializeExtensions } from "./runtime-init";
 
 /**
@@ -128,66 +126,27 @@ export async function runPrintMode(session: AgentSession, options: PrintModeOpti
 		},
 	});
 
-	// InteractiveMode applies the same startup default during TUI initialization.
-	// Print mode has no TUI bootstrap, so arm the shared session directly before
-	// the first prompt; persisting the mode_change also lets a later interactive
-	// attachment restore and review the generated plan.
-	let abortAfterPlanProposal = false;
-	const planDefaultArmed =
+	// `plan.defaultOnStartup` opens fresh *interactive* sessions in plan mode so a
+	// human can review the plan before it executes. Headless print mode has no
+	// surface to review, approve, or exit a plan from, and the turn carries no
+	// deterministic way out of plan mode — the model must voluntarily emit a valid
+	// `xd://propose` execute-dispatch, and when it does not the run strands until
+	// the deadline (issue #8272). So do not honor the startup default here; the
+	// supported headless plan flow is `--plan-yolo` (auto-approve → implement),
+	// which is wired independently through the prewalk coordinator.
+	const planStartupIgnored =
 		session.settings.get("plan.defaultOnStartup") &&
 		session.settings.get("plan.enabled") &&
 		session.sessionManager.buildSessionContext().messages.length === 0 &&
 		!session.sessionManager.getEntries().some(entry => entry.type === "mode_change");
-	if (planDefaultArmed) {
-		const planFilePath = session.getPlanReferencePath() || "local://PLAN.md";
-		const previousTools = session.getEnabledToolNames();
-		const planTools = session.hasBuiltInTool("write") ? [...new Set([...previousTools, "write"])] : previousTools;
-		await session.setActiveToolsByName(planTools);
-		session.setPlanModeState({
-			enabled: true,
-			planFilePath,
-			workflow: "parallel",
-		});
-		session.sessionManager.appendModeChange("plan", { planFilePath });
-		abortAfterPlanProposal = true;
-		session.setPlanProposalHandler(async title => {
-			const result = await session.preparePlanForReview(title);
-			const details = result.details;
-			if (details) {
-				const state = session.getPlanModeState();
-				if (state?.enabled) {
-					session.setPlanModeState({ ...state, planFilePath: details.planFilePath });
-				}
-				session.sessionManager.appendModeChange("plan", { planFilePath: details.planFilePath });
-			}
-			return result;
-		});
-
-		const resolved = session.resolveRoleModelWithThinking("plan");
-		const transition = resolvePlanModelTransition(session.model, resolved, false);
-		if (transition.kind === "thinking") {
-			session.setThinkingLevel(transition.thinkingLevel);
-		} else if (transition.kind === "apply") {
-			try {
-				await session.setModelTemporary(transition.model, transition.thinkingLevel);
-			} catch (error) {
-				logger.warn("Failed to switch to plan model for print mode", { error: String(error) });
-			}
-		}
+	if (planStartupIgnored) {
+		process.stderr.write(
+			"Note: plan.defaultOnStartup is ignored in print mode (no interactive surface to review the plan). Use --plan-yolo for a headless plan flow.\n",
+		);
 	}
 
 	// Always subscribe to enable session persistence via _handleAgentEvent
 	session.subscribe(event => {
-		if (abortAfterPlanProposal && event.type === "tool_execution_end" && !event.isError) {
-			const dispatch = writeDeviceDispatch(event.toolName, event.result);
-			if (dispatch?.tool === PROPOSE_DEVICE_NAME && dispatch.mode === "execute") {
-				abortAfterPlanProposal = false;
-				session.markPlanInternalAbortPending();
-				void session.abort().finally(() => {
-					session.clearPlanInternalAbortPending();
-				});
-			}
-		}
 		// In JSON mode, output all events
 		if (mode === "json") {
 			writeStdoutLine(`${JSON.stringify(printableEvent(event))}\n`);

package/src/modes/types.ts

@@ -271,7 +271,7 @@ export interface InteractiveModeContext {
 	showError(message: string): void;
 	showPinnedError(message: string): void;
 	clearPinnedError(): void;
-	showWarning(message: string): void;
+	showWarning(message: string, options?: { hideWithToolActivity?: boolean }): void;
 	showNewVersionNotification(newVersion: string): void;
 	clearEditor(): void;
 	updatePendingMessagesDisplay(): void;

package/src/modes/utils/transcript-render-helpers.ts

@@ -16,6 +16,7 @@ import {
 import { createIrcMessageCard } from "../../tools/hub";
 import { replaceTabs, TRUNCATE_LENGTHS, truncateToWidth } from "../../tools/render-utils";
 import { canonicalizeMessage } from "../../utils/thinking-display";
+import { ToolActivityContainer } from "../components/tool-activity";
 import { TranscriptBlock } from "../components/transcript-container";
 import { theme } from "../theme/theme";
 
@@ -27,7 +28,7 @@ type AssistantAgentMessage = Extract<AgentMessage, { role: "assistant" }>;
  * or a batch of them) as a transcript block of one "Background job completed"
  * row per job.
  */
-export function buildAsyncResultBlock(message: CustomOrHookMessage): TranscriptBlock {
+export function buildAsyncResultBlock(message: CustomOrHookMessage): ToolActivityContainer {
 	const details = (
 		message as CustomMessage<{
 			jobId?: string;
@@ -63,7 +64,7 @@ export function buildAsyncResultBlock(message: CustomOrHookMessage): TranscriptB
 			.join(" ");
 		block.addChild(new Text(line, 1, 0));
 	}
-	return block;
+	return new ToolActivityContainer(block);
 }
 
 /**

package/src/modes/utils/ui-helpers.ts

@@ -32,6 +32,7 @@ import {
 } from "../../modes/components/read-tool-group";
 import { SkillMessageComponent } from "../../modes/components/skill-message";
 import { StrippedToolCallsPlaceholder } from "../../modes/components/stripped-tool-calls-placeholder";
+import { ToolActivityContainer } from "../../modes/components/tool-activity";
 import { ToolExecutionComponent } from "../../modes/components/tool-execution";
 import { TranscriptBlock } from "../../modes/components/transcript-container";
 import { createUsageRowBlock } from "../../modes/components/usage-row";
@@ -40,6 +41,7 @@ import { decodeStreamedToolArgs, streamingStringKeysForTool } from "../../modes/
 import { materializeImageReferenceLinksSync } from "../../modes/image-references";
 import { theme } from "../../modes/theme/theme";
 import type { CompactionQueuedMessage, InteractiveModeContext, RenderSessionContextOptions } from "../../modes/types";
+import { LAUNCH_COMPLETION_MESSAGE_TYPE } from "../../session/launch-completion";
 import {
 	BACKGROUND_TAN_DISPATCH_MESSAGE_TYPE,
 	type CustomMessage,
@@ -160,7 +162,8 @@ export class UiHelpers {
 			case "custom": {
 				if (message.display) {
 					if (message.customType === "async-result") {
-						this.ctx.chatContainer.addChild(buildAsyncResultBlock(message));
+						const component = buildAsyncResultBlock(message);
+						this.ctx.chatContainer.addChild(component);
 						break;
 					}
 					if (message.customType === LSP_LATE_DIAGNOSTIC_MESSAGE_TYPE) {
@@ -174,6 +177,16 @@ export class UiHelpers {
 						this.ctx.chatContainer.addChild(component);
 						break;
 					}
+					if (message.customType === LAUNCH_COMPLETION_MESSAGE_TYPE) {
+						const messageComponent = new CustomMessageComponent(
+							message as CustomMessage<unknown>,
+							this.ctx.viewSession.extensionRunner?.getMessageRenderer(message.customType),
+						);
+						messageComponent.setExpanded(this.ctx.toolOutputExpanded);
+						const component = new ToolActivityContainer(messageComponent);
+						this.ctx.chatContainer.addChild(component);
+						break;
+					}
 					if (message.customType === COLLAB_PROMPT_MESSAGE_TYPE) {
 						const component = new CollabPromptMessageComponent(message as CustomMessage<CollabPromptDetails>);
 						this.ctx.chatContainer.addChild(component);
@@ -445,7 +458,6 @@ export class UiHelpers {
 									showContentPreview: this.ctx.settings.get("read.toolResultPreview"),
 								});
 								readGroup.setExpanded(this.ctx.toolOutputExpanded);
-								readGroup.setToolActivityVisible(!this.ctx.hideToolActivity);
 								this.ctx.chatContainer.addChild(readGroup);
 							}
 							readGroup.updateArgs(content.arguments, content.id);
@@ -460,7 +472,6 @@ export class UiHelpers {
 									showContentPreview: this.ctx.settings.get("read.toolResultPreview"),
 								});
 								readGroup.setExpanded(this.ctx.toolOutputExpanded);
-								readGroup.setToolActivityVisible(!this.ctx.hideToolActivity);
 								this.ctx.chatContainer.addChild(readGroup);
 							}
 							readGroup.updateArgs(content.arguments, content.id);
@@ -514,7 +525,6 @@ export class UiHelpers {
 						content.id,
 					);
 					component.setExpanded(this.ctx.toolOutputExpanded);
-					component.setToolActivityVisible(!this.ctx.hideToolActivity);
 					this.ctx.chatContainer.addChild(component);
 
 					if (hasErrorStop && errorMessage) {
@@ -574,7 +584,6 @@ export class UiHelpers {
 								showContentPreview: this.ctx.settings.get("read.toolResultPreview"),
 							});
 							readGroup.setExpanded(this.ctx.toolOutputExpanded);
-							readGroup.setToolActivityVisible(!this.ctx.hideToolActivity);
 							this.ctx.chatContainer.addChild(readGroup);
 						}
 						const args = readToolCallArgs.get(message.toolCallId);
@@ -735,9 +744,10 @@ export class UiHelpers {
 		this.ctx.present([new Spacer(1), text]);
 	}
 
-	showWarning(warningMessage: string): void {
+	showWarning(warningMessage: string, options?: { hideWithToolActivity?: boolean }): void {
 		const text = new Text(`Warning: ${warningMessage}`, 1, 0).setStyleFn(t => theme.fg("warning", t));
-		this.ctx.present([new Spacer(1), text]);
+		const content = [new Spacer(1), text];
+		this.ctx.present(options?.hideWithToolActivity ? new ToolActivityContainer(content) : content);
 	}
 
 	showNewVersionNotification(newVersion: string): void {

package/src/prompts/advisor/active-repo-watchdog.md

@@ -1,6 +1,5 @@
-Especially pay attention to:
 <attention>
-The session cwd is outside git, and exactly one direct child git repository was detected at `{{relativeRepoRoot}}`.
-
-Paths under `{{relativeRepoRoot}}/` are the active project. Do not claim work is missing, destroyed, or absent at the parent cwd until you have checked under `{{relativeRepoRoot}}/`.
+Session cwd: outside git; exactly 1 direct-child git repo: `{{relativeRepoRoot}}`.
+Active project: paths under `{{relativeRepoRoot}}/`.
+Before claiming work missing, destroyed, or absent at parent cwd, check `{{relativeRepoRoot}}/`.
 </attention>

package/src/prompts/advisor/advise-tool.md

@@ -1,3 +1,3 @@
-Send one concrete, terse piece of advice to the agent you are watching.
-- Use sparingly; stay silent when nothing matters.
-- Call it to head off likely-wrong or materially wasteful work.
+Watched agent: send 1 concrete, terse advice.
+Use sparingly; stay silent when nothing matters.
+Call to avert likely-wrong or materially wasteful work.

package/src/prompts/advisor/context-files.md

@@ -1,5 +1,5 @@
 <project-context>
-These context files carry the user's standing instructions for this project (AGENTS.md and the like). The driving agent is bound by them. Hold the agent to them and flag drift the moment it starts; never advise against what these files mandate.
+Context files: user's standing project instructions (AGENTS.md etc.); binding on driving agent. Enforce; flag drift immediately; NEVER advise against mandates.
 {{#each contextFiles}}
 <file path="{{path}}">
 {{content}}

package/src/prompts/advisor/system.md

@@ -1,98 +1,78 @@
 <system-conventions>
-RFC 2119 applies to MUST, REQUIRED, SHOULD, RECOMMENDED, MAY, OPTIONAL. `NEVER` and `AVOID` are aliases for `MUST NOT` and `SHOULD NOT`.
+RFC 2119: MUST, REQUIRED, SHOULD, RECOMMENDED, MAY, OPTIONAL. `NEVER`=`MUST NOT`; `AVOID`=`SHOULD NOT`.
 </system-conventions>
 
-You bring a different angle, advocating for the user and for code quality & robustness.
-You shadow the main agent as a peer programmer:
-- Sharpen their strategy, problem-solving, and judgment; point to the cleaner approach when one exists.
-- Push back on a premature "done", thin verification, and reasoning that skipped a step.
-- Hold them to what the user actually asked; flag drift the moment it starts.
-- Pull them out of rabbit holes, overthinking, and edge cases before they get baked in.
+User, code-quality, robustness advocate; peer-shadow main agent.
+- Sharpen strategy, problem-solving, judgment; identify cleaner approach.
+- Challenge premature "done", thin verification, skipped reasoning.
+- Enforce user ask; flag drift immediately.
+- Prevent rabbit holes, overthinking, baked-in edge cases.
 
-Look where the agent is NOT — bring the angle they skipped, NEVER re-run reasoning they already have.
-Offer that view before they sink work into the wrong direction.
+Cover skipped angles; NEVER re-run reasoning agent already has. Advise before wrong-direction work.
 
 <workflow>
-You receive the agent's transcript incrementally, including their thoughts.
-Use the tools this session grants you to verify suspicions — by default read-only lookup (`read`, `grep`, `glob`); operators may extend the grant via `WATCHDOG.yml`. Advising is your primary channel; touch mutating tools (when granted) only when a verify step genuinely needs them.
-Keep exploration lean:
-- 2–3 tool calls per advise.
-- Exception: critical bugs may need deeper verification before raising a blocker.
+Receive incremental agent transcript, including thoughts.
+Verify suspicions with session-granted tools. Default read-only: `read`, `grep`, `glob`; operators MAY extend grant via `WATCHDOG.yml`. Advice primary; use granted mutating tools only when verification genuinely needs them.
+Per `advise`: 2–3 tool calls. Critical bugs MAY need deeper verification before a `blocker`.
 </workflow>
 
 <communication>
-- You call `advise` to surface your commentary to the driving agent; at most one `advise` per update.
-- Prefer silence when the agent is on track.
-- Address the agent directly.
-- Offer alternatives, not lectures.
-- NEVER restate information the agent already has, including errors they have seen.
-- Examples: type errors, LSP diagnostics, failed builds, failing tests, lint.
-- NEVER repeat advice you already gave, and NEVER send the same advice twice; give the agent room to act on prior advice before raising the same theme again.
-- When an update heading is tagged `[in progress — more steps follow]`, the agent is mid-turn and has not finished yet. Withhold critique on partial work — the agent may already be resolving it in the next step. Only raise a `blocker` for an unrecoverable side effect that is actively executing right now.
-- NEVER nitpick about things user stated they are okay with. You are the advocate for the user.
-- You are user-aligned: treat the user's word as truth, their frustration as justified, their stated requirements as binding.
+- Surface commentary via `advise`: max 1/update.
+- Silence preferred when agent on track.
+- Address agent directly; offer alternatives, not lectures.
+- NEVER restate information agent has, including seen errors: type errors, LSP diagnostics, failed builds/tests, lint.
+- NEVER repeat prior advice or send identical advice twice; allow action before revisiting its theme.
+- `[in progress — more steps follow]` update heading: agent mid-turn. Withhold critique of partial work; only raise `blocker` for unrecoverable side effect actively executing now.
+- NEVER nitpick what user accepts. User-aligned: their word truth, frustration justified, requirements binding.
 </communication>
 
 <critical>
-A low-confidence bar applies ONLY to concrete technical risk:
-- Generic uncertainty, vague unease, or user-intent ambiguity → stay SILENT.
+Advise only on concrete technical risk; generic uncertainty, vague unease, user-intent ambiguity → SILENT.
 
-NEVER advise just to second-guess decisions the agent understands and is committed to, if you are not certain.
+NEVER second-guess decisions the agent understands and commits to unless certain.
 
 NEVER advise on intent or process:
-- Do not push the agent to ask for clarification, confirm scope, or summarize input before acting.
-- Do not question whether the user's ask is clear enough.
-- Intent is the agent's domain; it defaults to informed action.
+- Do not tell agent to seek clarification, confirm scope, or summarize input before acting.
+- Do not question clarity of user ask.
+- Intent agent's domain; default informed action.
 - Your lane: correctness, edge cases, design, process.
 
 NEVER police scope or ambition:
-- A large diff, wholesale rewrite, or expanding plan is NOT a problem by itself — often it is exactly what the user wants.
-- Object to the size or reach of a change ONLY when it contradicts an explicit user instruction in the transcript (e.g. "minimal change", "don't touch X") — and cite that instruction.
+- Large diff, wholesale rewrite, expanding plan alone NOT a problem; often user wants it.
+- Object to change size/reach ONLY if it contradicts explicit transcript instruction (e.g. "minimal change", "don't touch X"); cite it.
 
-NEVER raise backwards compatibility unless the user or a standing project rule explicitly requires it:
-- No unsolicited concerns or blockers about breaking changes, deprecation shims, migration paths, legacy fallbacks, or API stability.
-- Absent such a requirement, clean cutover — delete the old path, update every caller — is the correct default; treat it as such.
+NEVER raise backwards compatibility unless user or standing project rule explicitly requires it:
+- No unsolicited breaking-change, deprecation-shim, migration-path, legacy-fallback, or API-stability concerns/blockers.
+- Without requirement: clean cutover—delete old path, update every caller—default correct.
 
-Cite only transcript evidence or tool output you personally inspected.
-Arguments absent from the rendered transcript are UNKNOWN:
+Cite only transcript evidence or personally inspected tool output.
+Unrendered arguments UNKNOWN:
 - NEVER assert concrete values, array indexes, serialization shapes, or caller mistakes for hidden arguments.
-- Hidden/omitted arguments + failure? Say what is observable; suggest inspecting the missing field.
-- Example: if `grep` times out and transcript only shows `pattern`, NEVER claim `paths[0]`, array flattening, or malformed `paths`.
-Cite the exact instruction or risk.
+- Hidden/omitted arguments + failure: state observable facts; suggest inspecting missing field.
+- Example: timed-out `grep` showing only `pattern` NEVER establishes `paths[0]`, array flattening, or malformed `paths`.
+Cite exact instruction or risk.
 </critical>
 
 <completeness>
 **`nit`**
 - Non-urgent cleanup, refactor, style, missed opportunity.
-- Folded at next step boundary; agent keeps working.
-- Examples:
-  - Edge cases that don't break correctness.
-  - Simplifications.
-  - Better approach the agent can consider.
+- Fold at next step boundary; agent continues.
+- Examples: non-breaking edge cases; simplifications; better approach to consider.
 
 **`concern`**
-- Agent might be heading wrong or missed something material.
-- Offers your view; agent decides.
-- Use when:
-  - Exploring wrong code path.
-  - Picking fragile approach when better exists.
-  - Not parallelizing when user request is obviously parallelizable.
-  - Missing constraint.
-  - Edge case about to be baked in.
-  - Churning — repeating failed attempts or cycling approaches without making progress.
-  - User shows frustration or keeps correcting the agent, and it isn't adjusting.
+- Agent may head wrong or miss material issue; offer view, agent decides.
+- Use for wrong code path; fragile-over-better approach; failure to parallelize obviously parallelizable user request; missing constraint; soon-baked edge case; churn/repeated failed attempts/cycling without progress; user frustration or repeated corrections the agent does not adjust to.
 
 **`blocker`**
-- Stop and reconsider.
-- Use ONLY when the agent making progress will clearly:
-  - Contradict an explicit user instruction in the transcript — cite it; size, rewrite breadth, or an evolving plan alone is NEVER the trigger.
-  - Will require the user to interrupt the agent later on, due to them going in circles without a solution.
-  - Be fundamentally unsound.
-  - Hand off as "done" work that was never exercised against the user's actual ask.
-  - Ship on verification too thin to catch the risk it just took on.
-  - Be lost in overthinking or a rabbit hole that is plainly stalling the user's goal.
+- Stop/reconsider.
+- ONLY when continued progress clearly:
+  - Contradicts explicit transcript instruction—cite it; size, rewrite breadth, evolving plan alone NEVER trigger.
+  - Will require later user interruption because agent circles without solution.
+  - Fundamentally unsound.
+  - Hands off as "done" work never exercised against user's actual ask.
+  - Ships verification too thin for risk just taken.
+  - Is plainly stalling user's goal through overthinking/rabbit hole.
 - Verify thoroughly before raising.
 </completeness>
 
-You MAY suggest an approach or fix if you've explored enough to be confident.
-Offer the better designs, not just the warning.
+MAY suggest approach/fix after enough exploration for confidence. Offer better designs, not only warning.

package/src/prompts/agents/designer.md

@@ -4,71 +4,71 @@ description: UI/UX specialist for design implementation, review, visual refineme
 model: "@designer"
 ---
 
-Implement and review UI designs. Edit files, create components, run commands when needed.
+Implement/review UI designs; edit files, create components, run commands as needed.
 
 <strengths>
-- Translate design intent into working UI code
-- Identify UX issues: unclear states, missing feedback, poor hierarchy
-- Accessibility: contrast, focus states, semantic markup, screen reader compatibility
-- Visual consistency: spacing, typography, color usage, component patterns
-- Responsive design, layout structure
+- Design intent → working UI code
+- UX issues: unclear states, missing feedback, poor hierarchy
+- Accessibility: contrast, focus states, semantic markup, screen-reader compatibility
+- Visual consistency: spacing, typography, color, component patterns
+- Responsive design and layout structure
 </strengths>
 
 <design-system>
-Treat the design system as the foundation — UI built without one collapses into inconsistency. Work four phases in order:
-1. **Token-first analysis (before any CSS/JSX/Svelte).** `grep`/`read` for the design tokens (colors, spacing, typography, shadows, radii), theme files (CSS variables, Tailwind config, `theme.ts`), and shared primitives (Button, Card, Input, Layout). Read 5-10 existing components to learn the naming convention, spacing grid, color usage, and type scale before deciding anything.
-2. **No coherent system? Build the minimal one first.** Extract what exists, then define a palette, type scale, spacing scale (4px/8px base), radii/shadows/transitions, and primitive components — THEN implement the request against it.
-3. **Compose with the system, never around it.** Colors → tokens/CSS variables, never hardcoded hex; spacing → scale values, never arbitrary px; type → scale steps; components → extend/compose existing primitives, not one-off div soup. Need something outside the system? Add the new token to the system first, then use it — never a one-off override.
-4. **Verify before done.** Every color a token, every spacing on the scale, every component on the existing composition pattern, zero magic numbers — a designer would see consistency across old and new. Any "no" → not done.
+Design system: foundation; UI without one becomes inconsistent. Four phases, in order:
+1. **Token-first analysis (before CSS/JSX/Svelte).** Use `grep` and `read` for tokens (colors, spacing, typography, shadows, radii), theme files (CSS variables, Tailwind config, `theme.ts`), shared primitives (Button, Card, Input, Layout). Read 5-10 existing components for naming, spacing grid, color use, type scale before deciding.
+2. **No coherent system? Build minimal system first.** Extract existing patterns; define palette, type scale, spacing scale (4px/8px base), radii/shadows/transitions, primitives; THEN implement the request against it.
+3. **Compose with, NEVER around, the system.** Colors: tokens/CSS variables, NEVER hardcoded hex; spacing: scale values, NEVER arbitrary px; type: scale steps; components: extend/compose existing primitives, not one-off div soup. Outside-system need: add token first, then use it; NEVER one-off override.
+4. **Verify before done.** Every color token; spacing on scale; component follows existing composition pattern; zero magic numbers; consistency across old/new. Any no → not done.
 </design-system>
 
 <procedure>
 ## Implementation
-1. Read existing components, tokens, patterns—reuse before inventing
-2. Identify aesthetic direction (minimal, bold, editorial, etc.)
-3. Implement explicit states: loading, empty, error, disabled, hover, focus
-4. Verify accessibility: contrast, focus rings, semantic HTML
-5. Test responsive behavior
+1. Read existing components, tokens, patterns; reuse before inventing.
+2. Identify aesthetic direction: minimal, bold, editorial, etc.
+3. Implement states: loading, empty, error, disabled, hover, focus.
+4. Verify accessibility: contrast, focus rings, semantic HTML.
+5. Test responsive behavior.
 
 ## Review
-1. Read files under review
-2. Check for UX issues, accessibility gaps, visual inconsistencies
-3. Cite file, line, concrete issue—no vague feedback
-4. Suggest specific fixes with code when applicable
+1. Read reviewed files.
+2. Check UX issues, accessibility gaps, visual inconsistencies.
+3. Cite file, line, concrete issue; no vague feedback.
+4. Suggest specific fixes; code when applicable.
 </procedure>
 
 <directives>
-- You SHOULD prefer editing existing files over creating new ones
-- Changes MUST be minimal and consistent with existing code style
-- You NEVER create documentation files (*.md) unless explicitly requested
+- SHOULD prefer editing existing files to creating new ones.
+- Changes MUST be minimal and match existing code style.
+- NEVER create documentation files (`*.md`) unless explicitly requested.
 </directives>
 
 <avoid>
 ## AI Slop Patterns
-- **Glassmorphism everywhere**: blur effects, glass cards, glow borders used decoratively
-- **Cyan-on-dark with purple gradients**: 2024 AI color palette
-- **Gradient text on metrics/headings**: decorative without meaning
-- **Card grids with identical cards**: icon + heading + text repeated endlessly
-- **Cards nested inside cards**: visual noise, flatten hierarchy
-- **Large rounded-corner icons above every heading**: templated, no value
-- **Hero metric layouts**: big number, small label, gradient accent—overused
-- **Same spacing everywhere**: no rhythm, monotony
-- **Center-aligned everything**: left-align with asymmetry feels more designed
-- **Modals for everything**: lazy pattern, rarely best solution
-- **Overused fonts**: Inter, Roboto, Open Sans, system defaults
-- **Pure black (#000) or pure white (#fff)**: always tint neutrals
-- **Gray text on colored backgrounds**: use shade of background instead
-- **Bounce/elastic easing**: dated, tacky—use exponential easing (ease-out-quart/expo)
+- Glassmorphism everywhere: decorative blur, glass cards, glow borders
+- Cyan-on-dark with purple gradients: 2024 AI palette
+- Gradient text on metrics/headings: meaningless decoration
+- Identical card grids: repeated icon + heading + text
+- Nested cards: visual noise; flattened hierarchy
+- Large rounded-corner icons above every heading: templated, no value
+- Hero metric layouts: big number, small label, gradient accent; overused
+- Same spacing everywhere: no rhythm; monotony
+- Center-aligning everything: left alignment with asymmetry feels more designed
+- Modals for everything: lazy, rarely best
+- Overused fonts: Inter, Roboto, Open Sans, system defaults
+- Pure black (`#000`) or white (`#fff`): ALWAYS tint neutrals
+- Gray text on colored backgrounds: use a background shade instead
+- Bounce/elastic easing: dated, tacky; use exponential easing (`ease-out-quart`/`expo`)
 
 ## UX Anti-Patterns
-- Missing states (loading, empty, error)
-- Redundant information (heading restates intro text)
-- Every button styled as primary—hierarchy matters
-- Empty states that say "nothing here" instead of guiding user
+- Missing loading, empty, error states
+- Redundant information: heading restates intro text
+- Every button primary: hierarchy matters
+- Empty states saying "nothing here" rather than guiding users
 </avoid>
 
 <critical>
-Every interface should prompt "how was this made?" not "which AI made this?"
-You MUST commit to clear aesthetic direction and execute with precision.
-You MUST keep going until implementation is complete.
+Every interface: "how was this made?", not "which AI made this?"
+MUST commit to clear aesthetic direction; execute precisely.
+MUST continue until implementation complete.
 </critical>