@oh-my-pi/pi-coding-agent 17.2.11 → 17.2.12

package/src/config/settings.ts

@@ -442,11 +442,15 @@ export class Settings {
 	}
 
 	/**
-	 * Create an isolated instance for testing.
-	 * Does not affect the global singleton.
+	 * Create an in-memory settings instance without affecting the global singleton.
+	 * A supplied storage handle remains shared for runtime data while setting overrides stay non-persistent.
 	 */
-	static isolated(overrides: Partial<Record<SettingPath, unknown>> = {}): Settings {
+	static isolated(
+		overrides: Partial<Record<SettingPath, unknown>> = {},
+		options: { storage?: AgentStorage | null } = {},
+	): Settings {
 		const instance = new Settings({ inMemory: true, overrides });
+		instance.#storage = options.storage ?? null;
 		instance.#rebuildMerged();
 		return instance;
 	}

package/src/debug/raw-sse-buffer.ts

@@ -335,6 +335,26 @@ export class RawSseDebugBuffer {
 		return body.length > 0 ? `${dropped}${body}` : dropped;
 	}
 
+	/**
+	 * Drop every retained record and reset accounting. Called from
+	 * {@link AgentSession} teardown so a disposed (e.g. parked subagent) session
+	 * stops pinning captured wire frames — each trimmed record holds a
+	 * `slice()` of its parent SSE frame, which under JSC keeps the whole
+	 * multi-MB frame alive. Notifies subscribers so a live debug viewer redraws
+	 * empty.
+	 */
+	clear(): void {
+		this.#records = [];
+		this.#recordChars = [];
+		this.#head = 0;
+		this.#totalChars = 0;
+		this.#droppedRecords = 0;
+		this.#droppedChars = 0;
+		this.#totalEvents = 0;
+		this.#lastUpdatedAt = undefined;
+		this.#emit();
+	}
+
 	#append(record: RawSseDebugRecord, chars: number): void {
 		this.#records.push(record);
 		this.#recordChars.push(chars);

package/src/discovery/agent-plugin-format.ts

@@ -74,13 +74,13 @@ export interface AgentPluginManifest {
  * - `invalid` — the document targets Agent Plugins but violates the closed schema
  *   fatally; the plugin must be rejected and none of its components loaded (spec §5.2).
  */
-export type AgentPluginManifestResult =
+type AgentPluginManifestResult =
 	| { status: "none" }
 	| { status: "valid"; manifest: AgentPluginManifest; warnings: string[] }
 	| { status: "invalid"; reason: string };
 
 /** Enforce the plugin `name` constraints from spec §5.5. */
-export function isValidAgentPluginName(name: string): boolean {
+function isValidAgentPluginName(name: string): boolean {
 	if (name.length < 1 || name.length > 64) return false;
 	if (!/^[a-z0-9](?:[a-z0-9.-]*[a-z0-9])?$/.test(name)) return false;
 	return !name.includes("--") && !name.includes("..");
@@ -240,14 +240,14 @@ export function parseAgentPluginManifest(raw: string): AgentPluginManifestResult
  * (spec §9.2). Single non-recursive pass; replacement text is never rescanned,
  * and no other placeholder or environment-variable expansion is performed.
  */
-export function expandAgentPluginPlaceholders(value: string, pluginRoot: string, pluginData: string): string {
+function expandAgentPluginPlaceholders(value: string, pluginRoot: string, pluginData: string): string {
 	return value.replace(/\$\{PLUGIN_(ROOT|DATA)\}/g, (_match, which: string) =>
 		which === "ROOT" ? pluginRoot : pluginData,
 	);
 }
 
 /** A validated `mcp.json` server entry, resolved to launch-ready values. */
-export interface AgentPluginMcpServer {
+interface AgentPluginMcpServer {
 	name: string;
 	transport: "stdio" | "http" | "sse";
 	/** Absolute path for `./`-relative commands; bare executable token otherwise. */
@@ -268,11 +268,11 @@ export interface AgentPluginMcpServer {
  * - `ok` — the document is valid; individually invalid server entries are
  *   skipped with a warning (spec §7.2.2 rule 3).
  */
-export type AgentPluginMcpResult =
+type AgentPluginMcpResult =
 	| { status: "disabled"; reason: string }
 	| { status: "ok"; servers: AgentPluginMcpServer[]; warnings: string[] };
 
-export interface AgentPluginMcpOptions {
+interface AgentPluginMcpOptions {
 	/** Filesystem-resolved plugin root. */
 	pluginRoot: string;
 	/** Client-managed persistent data directory for this plugin (spec §9.1). */
@@ -488,7 +488,7 @@ export async function parseAgentPluginMcp(raw: string, options: AgentPluginMcpOp
  * - `invalid` — the root claims Agent Plugins conformance but its manifest is
  *   fatally invalid; no component may be discovered or executed (spec §11.3).
  */
-export type AgentPluginRootStatus =
+type AgentPluginRootStatus =
 	| { kind: "none" }
 	| { kind: "standard"; manifest: AgentPluginManifest; warnings: string[]; realRoot: string }
 	| { kind: "invalid"; reason: string };

package/src/discovery/contained-path.ts

@@ -14,7 +14,7 @@ import * as fs from "node:fs";
 import * as path from "node:path";
 
 /** Lexical containment: `target` is `base` itself or a descendant of it. */
-export function isContained(base: string, target: string): boolean {
+function isContained(base: string, target: string): boolean {
 	const relative = path.relative(base, target);
 	return relative === "" || (!relative.startsWith("..") && !path.isAbsolute(relative));
 }
@@ -29,10 +29,7 @@ export async function realpathIfExists(p: string): Promise<string | null> {
 }
 
 /** Outcome of resolving a fixed package path without reading it. */
-export type ContainedPathResolution =
-	| { status: "missing" }
-	| { status: "outside" }
-	| { status: "ok"; realPath: string };
+type ContainedPathResolution = { status: "missing" } | { status: "outside" } | { status: "ok"; realPath: string };
 
 /**
  * Resolve a fixed package path WITHOUT reading it: symlinks and equivalent

package/src/edit/hashline/diff.ts

@@ -225,7 +225,11 @@ function applyPreviewEdits(args: {
 	// previews stay lenient — a mid-typed op transiently violating sequencing
 	// must not flash an error frame.
 	if (!options.streaming) validateClipboardSequence(resolved, clipboard);
-	const applyOptions = { clipboard, ...(options.streaming ? { onEmptyPaste: "drop" as const } : {}) };
+	const applyOptions = {
+		clipboard,
+		path: absolutePath,
+		...(options.streaming ? { onEmptyPaste: "drop" as const } : {}),
+	};
 	if (options.skipHashValidation || expected === undefined || liveMatches) {
 		return applyEdits(normalized, resolved, applyOptions);
 	}

package/src/eval/executor-base.ts

@@ -116,9 +116,13 @@ export async function waitForPromiseWithCancellation<T>(
 	promise: Promise<T>,
 	options: { signal?: AbortSignal; deadlineMs?: number },
 	cancelledErrorClass: CancelledErrorClass,
+	timedOutResolver?: (error: unknown, signal?: AbortSignal) => boolean,
 ): Promise<T> {
 	if (options.signal?.aborted) {
-		throw new cancelledErrorClass(isTimedOutCancellation(options.signal.reason, cancelledErrorClass, options.signal));
+		throw new cancelledErrorClass(
+			timedOutResolver?.(options.signal.reason, options.signal) ??
+				isTimedOutCancellation(options.signal.reason, cancelledErrorClass, options.signal),
+		);
 	}
 	const remainingMs = getRemainingTimeoutMs(options.deadlineMs);
 	if (remainingMs !== undefined && remainingMs <= 0) {
@@ -139,7 +143,8 @@ export async function waitForPromiseWithCancellation<T>(
 			finish(() =>
 				reject(
 					new cancelledErrorClass(
-						isTimedOutCancellation(options.signal?.reason, cancelledErrorClass, options.signal),
+						timedOutResolver?.(options.signal?.reason, options.signal) ??
+							isTimedOutCancellation(options.signal?.reason, cancelledErrorClass, options.signal),
 					),
 				),
 			);
@@ -276,9 +281,32 @@ interface ManagedKernelEnvOptions {
 	bridge?: { url: string; token: string };
 	localRoots?: Record<string, string>;
 }
+interface ManagedKernelEnvPolicy {
+	sparse?: boolean;
+}
 
-export function buildManagedKernelEnvPatch(options: ManagedKernelEnvOptions): Record<string, string | null> {
+export function buildManagedKernelEnvPatch(options: ManagedKernelEnvOptions): Record<string, string | null>;
+export function buildManagedKernelEnvPatch(
+	options: ManagedKernelEnvOptions,
+	policy: { sparse: true },
+): Record<string, string | undefined>;
+export function buildManagedKernelEnvPatch(
+	options: ManagedKernelEnvOptions,
+	policy?: ManagedKernelEnvPolicy,
+): KernelEnvPatch {
 	const localRoots = options.localRoots;
+	if (policy?.sparse) {
+		const patch: Record<string, string | undefined> = {};
+		if (options.sessionFile) patch.PI_SESSION_FILE = options.sessionFile;
+		if (options.artifactsDir) patch.PI_ARTIFACTS_DIR = options.artifactsDir;
+		if (options.bridge) {
+			patch.PI_TOOL_BRIDGE_URL = options.bridge.url;
+			patch.PI_TOOL_BRIDGE_TOKEN = options.bridge.token;
+			patch.PI_TOOL_BRIDGE_SESSION = options.bridgeSessionId ?? "";
+		}
+		if (localRoots) patch.PI_EVAL_LOCAL_ROOTS = JSON.stringify(localRoots);
+		return patch;
+	}
 	return {
 		PI_SESSION_FILE: options.sessionFile ?? null,
 		PI_ARTIFACTS_DIR: options.artifactsDir ?? null,
@@ -289,13 +317,18 @@ export function buildManagedKernelEnvPatch(options: ManagedKernelEnvOptions): Re
 	};
 }
 
-export function buildManagedKernelEnv(options: ManagedKernelEnvOptions): Record<string, string> | undefined {
-	const patch = buildManagedKernelEnvPatch(options);
+export function buildManagedKernelEnv(
+	options: ManagedKernelEnvOptions,
+	policy?: ManagedKernelEnvPolicy,
+): Record<string, string> | undefined {
+	const patch = policy?.sparse
+		? buildManagedKernelEnvPatch(options, { sparse: true })
+		: buildManagedKernelEnvPatch(options);
 	const env: Record<string, string> = {};
 	let hasKeys = false;
 	for (const key of MANAGED_KERNEL_ENV_KEYS) {
 		const value = patch[key];
-		if (value !== null) {
+		if (typeof value === "string") {
 			env[key] = value;
 			hasKeys = true;
 		}