@oh-my-pi/pi-coding-agent 17.1.2 → 17.1.3

package/dist/types/tools/auto-generated-guard.d.ts

@@ -1,11 +1,13 @@
+import { type Settings } from "../config/settings.js";
 /**
  * Check if a file is auto-generated by examining its content.
  * Throws ToolError if the file appears to be auto-generated.
  *
  * @param absolutePath - Absolute path to the file
  * @param displayPath - Path to show in error messages (relative or as provided)
+ * @param activeSettings - Session settings; falls back to global settings or the schema default
  */
-export declare function assertEditableFile(absolutePath: string, displayPath?: string): Promise<void>;
+export declare function assertEditableFile(absolutePath: string, displayPath?: string, activeSettings?: Settings): Promise<void>;
 /**
  * Check if file content is auto-generated.
  * Uses only the first CHECK_BYTE_COUNT characters of the content.
@@ -13,5 +15,6 @@ export declare function assertEditableFile(absolutePath: string, displayPath?: s
  *
  * @param content - File content to check (can be full content or prefix)
  * @param displayPath - Path to show in error messages
+ * @param activeSettings - Session settings; falls back to global settings or the schema default
  */
-export declare function assertEditableFileContent(content: string, displayPath: string): void;
+export declare function assertEditableFileContent(content: string, displayPath: string, activeSettings?: Settings): void;

package/dist/types/tools/memory-render.d.ts

@@ -13,10 +13,7 @@ import type { Component } from "@oh-my-pi/pi-tui";
 import type { RenderResultOptions } from "../extensibility/custom-tools/types.js";
 import type { Theme } from "../modes/theme/theme.js";
 interface RetainRenderArgs {
-    items?: Array<{
-        content?: string;
-        context?: string;
-    }>;
+    items?: unknown;
 }
 interface QueryRenderArgs {
     query?: string;

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "17.1.2",
+	"version": "17.1.3",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://omp.sh",
 	"author": "Can Boluk",
@@ -53,17 +53,17 @@
 		"@babel/parser": "^7.29.7",
 		"@babel/traverse": "^7.29.7",
 		"@mozilla/readability": "^0.6.0",
-		"@oh-my-pi/hashline": "17.1.2",
-		"@oh-my-pi/omp-stats": "17.1.2",
-		"@oh-my-pi/pi-agent-core": "17.1.2",
-		"@oh-my-pi/pi-ai": "17.1.2",
-		"@oh-my-pi/pi-catalog": "17.1.2",
-		"@oh-my-pi/pi-mnemopi": "17.1.2",
-		"@oh-my-pi/pi-natives": "17.1.2",
-		"@oh-my-pi/pi-tui": "17.1.2",
-		"@oh-my-pi/pi-utils": "17.1.2",
-		"@oh-my-pi/pi-wire": "17.1.2",
-		"@oh-my-pi/snapcompact": "17.1.2",
+		"@oh-my-pi/hashline": "17.1.3",
+		"@oh-my-pi/omp-stats": "17.1.3",
+		"@oh-my-pi/pi-agent-core": "17.1.3",
+		"@oh-my-pi/pi-ai": "17.1.3",
+		"@oh-my-pi/pi-catalog": "17.1.3",
+		"@oh-my-pi/pi-mnemopi": "17.1.3",
+		"@oh-my-pi/pi-natives": "17.1.3",
+		"@oh-my-pi/pi-tui": "17.1.3",
+		"@oh-my-pi/pi-utils": "17.1.3",
+		"@oh-my-pi/pi-wire": "17.1.3",
+		"@oh-my-pi/snapcompact": "17.1.3",
 		"@opentelemetry/api": "^1.9.1",
 		"@opentelemetry/api-logs": "^0.220.0",
 		"@opentelemetry/context-async-hooks": "^2.9.0",

package/src/edit/hashline/filesystem.ts

@@ -121,7 +121,7 @@ export class HashlineFilesystem extends Filesystem {
 			throw error;
 		}
 		// Refuse edits against generated files (lockfiles, models.json, …).
-		assertEditableFileContent(content, relativePath);
+		assertEditableFileContent(content, relativePath, this.session.settings);
 		return content;
 	}
 

package/src/edit/modes/patch.ts

@@ -1816,7 +1816,7 @@ export async function executePatchSingle(
 	const resolvedPath = resolvePlanPath(session, path);
 	const resolvedRename = rename ? resolvePlanPath(session, rename) : undefined;
 
-	await assertEditableFile(resolvedPath, path);
+	await assertEditableFile(resolvedPath, path, session.settings);
 
 	// Capture pre-edit content so we can verify the write actually hit disk.
 	// `LspFileSystem.writeFile` delegates to a writethrough callback that, in

package/src/prompts/tools/ast-edit.md

@@ -1,4 +1,4 @@
-Structural AST-aware rewrites via ast-grep. Use for codemods where text replace is unsafe. Narrow each call to one language.
+Structural AST-aware rewrites via ast-grep. Use for codemods where text replace is unsafe. Mixed-language paths are fine: each file is parsed in its own language, and a pattern only rewrites files it parses in.
 
 - Metavariables in `pat` (`$A`, `$$$ARGS`) substitute into `out`.
 - **Patterns match AST structure, not text.** `$NAME` = one node; `$_` = unbound; `$$$NAME` = zero-or-more.

package/src/session/stream-guards.ts

@@ -185,7 +185,7 @@ export class StreamingEditGuard {
 	#abortForAutoGeneratedPath(toolCall: ToolCall, filePath: string, resolvedPath: string): void {
 		if (this.#lastToolCallId === toolCall.id) return;
 		this.#lastToolCallId = toolCall.id;
-		void assertEditableFile(resolvedPath, filePath).catch(error => {
+		void assertEditableFile(resolvedPath, filePath, this.#host.settings).catch(error => {
 			if (!(error instanceof ToolError) || this.#lastToolCallId !== toolCall.id) return;
 			if (!this.#abortTriggered) {
 				this.#abortTriggered = true;

package/src/tools/auto-generated-guard.ts

@@ -7,7 +7,8 @@
 import * as path from "node:path";
 import { isEnoent, peekFile } from "@oh-my-pi/pi-utils";
 import { LRUCache } from "lru-cache/raw";
-import { settings } from "../config/settings";
+import { settings as globalSettings, isSettingsInitialized, type Settings } from "../config/settings";
+import { getDefault } from "../config/settings-schema";
 import { ToolError } from "./tool-errors";
 
 /**
@@ -283,15 +284,26 @@ async function getAutoGeneratedMarker(filePath: string): Promise<string | undefi
 	return marker;
 }
 
+function shouldBlockAutoGeneratedFiles(activeSettings?: Settings): boolean {
+	if (activeSettings) return activeSettings.get("edit.blockAutoGenerated");
+	if (isSettingsInitialized()) return globalSettings.get("edit.blockAutoGenerated");
+	return getDefault("edit.blockAutoGenerated");
+}
+
 /**
  * Check if a file is auto-generated by examining its content.
  * Throws ToolError if the file appears to be auto-generated.
  *
  * @param absolutePath - Absolute path to the file
  * @param displayPath - Path to show in error messages (relative or as provided)
+ * @param activeSettings - Session settings; falls back to global settings or the schema default
  */
-export async function assertEditableFile(absolutePath: string, displayPath?: string) {
-	if (!settings.get("edit.blockAutoGenerated")) {
+export async function assertEditableFile(
+	absolutePath: string,
+	displayPath?: string,
+	activeSettings?: Settings,
+): Promise<void> {
+	if (!shouldBlockAutoGeneratedFiles(activeSettings)) {
 		return;
 	}
 	const pathForDisplay = displayPath ?? absolutePath;
@@ -308,9 +320,10 @@ export async function assertEditableFile(absolutePath: string, displayPath?: str
  *
  * @param content - File content to check (can be full content or prefix)
  * @param displayPath - Path to show in error messages
+ * @param activeSettings - Session settings; falls back to global settings or the schema default
  */
-export function assertEditableFileContent(content: string, displayPath: string): void {
-	if (!settings.get("edit.blockAutoGenerated")) {
+export function assertEditableFileContent(content: string, displayPath: string, activeSettings?: Settings): void {
+	if (!shouldBlockAutoGeneratedFiles(activeSettings)) {
 		return;
 	}
 

package/src/tools/memory-render.ts

@@ -27,7 +27,7 @@ import {
 // from the active theme (`•` by default, a nerd-font dot under nerd themes).
 
 interface RetainRenderArgs {
-	items?: Array<{ content?: string; context?: string }>;
+	items?: unknown;
 }
 
 interface QueryRenderArgs {
@@ -35,7 +35,16 @@ interface QueryRenderArgs {
 }
 
 function retainContents(args: RetainRenderArgs | undefined): string[] {
-	return (args?.items ?? []).map(item => replaceTabs((item?.content ?? "").trim())).filter(line => line.length > 0);
+	const items = args?.items;
+	if (!Array.isArray(items)) return [];
+
+	const contents: string[] = [];
+	for (const item of items) {
+		if (!item || typeof item !== "object" || !("content" in item) || typeof item.content !== "string") continue;
+		const content = replaceTabs(item.content.trim());
+		if (content.length > 0) contents.push(content);
+	}
+	return contents;
 }
 
 function resultText(result: { content?: Array<{ type: string; text?: string }> }): string {

package/src/tools/render-utils.ts

@@ -13,7 +13,8 @@ import type { Component } from "@oh-my-pi/pi-tui";
 import { getKeybindings, replaceTabs, truncateToWidth } from "@oh-my-pi/pi-tui";
 import { pluralize } from "@oh-my-pi/pi-utils";
 import { formatKeyHints, type KeyId } from "../config/keybindings";
-import { settings } from "../config/settings";
+import { isSettingsInitialized, settings } from "../config/settings";
+import { getDefault } from "../config/settings-schema";
 import type { Theme } from "../modes/theme/theme";
 import { Hasher } from "../tui/utils";
 import { formatDimensionNote, type ResizedImage } from "../utils/image-resize";
@@ -27,8 +28,12 @@ export { replaceTabs, truncateToWidth, wrapTextWithAnsi } from "@oh-my-pi/pi-tui
 
 /** Resolve inline image dimension caps from settings and viewport. */
 export function resolveImageOptions(): { maxWidthCells: number; maxHeightCells?: number } {
-	const maxWidthCells = settings.get("tui.maxInlineImageColumns");
-	const rowSetting = Math.max(0, settings.get("tui.maxInlineImageRows"));
+	const activeSettings = isSettingsInitialized() ? settings : undefined;
+	const maxWidthCells = activeSettings?.get("tui.maxInlineImageColumns") ?? getDefault("tui.maxInlineImageColumns");
+	const rowSetting = Math.max(
+		0,
+		activeSettings?.get("tui.maxInlineImageRows") ?? getDefault("tui.maxInlineImageRows"),
+	);
 	const viewportRows = process.stdout.rows;
 	const viewportFraction = viewportRows ? Math.floor(viewportRows * 0.6) : 0;
 	let maxHeightCells: number | undefined;

package/src/tools/write.ts

@@ -1215,7 +1215,7 @@ export class WriteTool implements AgentTool<typeof writeSchema, WriteToolDetails
 
 			// Check if file exists and is auto-generated before overwriting
 			if (await fs.exists(absolutePath)) {
-				await assertEditableFile(absolutePath, path);
+				await assertEditableFile(absolutePath, path, this.session.settings);
 			}
 
 			const displayPath = formatPathRelativeToCwd(absolutePath, this.session.cwd);