@oh-my-pi/pi-coding-agent 17.0.9 → 17.1.0

package/src/modes/controllers/mcp-command-controller.ts

@@ -38,6 +38,7 @@ import {
 	getSmitheryApiKey,
 	getSmitheryLoginUrl,
 	pollSmitheryCliAuthSession,
+	type SmitheryCliPollResponse,
 	saveSmitheryApiKey,
 } from "../../mcp/smithery-auth";
 import { SmitheryConnectError } from "../../mcp/smithery-connect";
@@ -51,6 +52,7 @@ import type { MCPAuthChallenge, MCPAuthConfig, MCPServerConfig, MCPServerConnect
 import { shortenPath } from "../../tools/render-utils";
 import { urlHyperlinkAlways } from "../../tui";
 import { copyToClipboard } from "../../utils/clipboard";
+import { isTimeoutError } from "../../utils/fetch-timeout";
 import { openPath } from "../../utils/open";
 import { ChatBlock } from "../components/chat-block";
 import { MCPAddWizard } from "../components/mcp-add-wizard";
@@ -2121,7 +2123,14 @@ export class MCPCommandController {
 			if (Date.now() - startedAt >= timeoutMs) {
 				throw new Error("Smithery authorization timed out after 5 minutes.");
 			}
-			const response = await pollSmitheryCliAuthSession(sessionId, signal);
+			let response: SmitheryCliPollResponse;
+			try {
+				response = await pollSmitheryCliAuthSession(sessionId, signal);
+			} catch (error) {
+				// A single hung/slow poll aborts with TimeoutError; retry until the deadline.
+				if (isTimeoutError(error)) continue;
+				throw error;
+			}
 			if (response.status === "success" && response.apiKey) {
 				return response.apiKey;
 			}

package/src/modes/controllers/omfg-controller.ts

@@ -192,56 +192,60 @@ export class OmfgController {
 
 	async #saveCandidate(request: OmfgRequest, candidate: OmfgCandidate): Promise<SaveCandidateResult> {
 		if (this.#shouldStop(request)) return { kind: "aborted" };
-		request.component.setStatus("saving", "Choose where to save or amend the TTSR rule…");
-		const location = await this.ctx.showHookSelector("Save TTSR rule where?", [
-			PROJECT_OPTION,
-			GLOBAL_OPTION,
-			AMEND_OPTION,
-		]);
-		if (!this.#isActiveRequest(request)) return { kind: "aborted" };
-		if (!location) {
-			request.component.markAborted();
-			this.#closeActiveRequest({ abort: false });
-			return { kind: "aborted" };
-		}
 
-		if (location === AMEND_OPTION) {
-			request.component.setStatus("confirming", "Describe how to amend the rule…");
-			const amendment = await this.ctx.showHookInput(
-				"Amend TTSR rule",
-				"e.g. Make it specific to Ruby string eval in tool:write(*.rb)",
-			);
+		for (;;) {
+			request.component.setStatus("saving", "Choose where to save or amend the TTSR rule…");
+			const location = await this.ctx.showHookSelector("Save TTSR rule where?", [
+				PROJECT_OPTION,
+				GLOBAL_OPTION,
+				AMEND_OPTION,
+			]);
 			if (!this.#isActiveRequest(request)) return { kind: "aborted" };
-			const feedback = amendment?.trim();
-			if (!feedback) {
+			if (!location) {
 				request.component.markAborted();
 				this.#closeActiveRequest({ abort: false });
 				return { kind: "aborted" };
 			}
-			return { kind: "amend", feedback };
-		}
 
-		const target = this.#resolveTarget(location, candidate.rule.name);
-		if (await Bun.file(target.filePath).exists()) {
-			const shouldOverwrite = await this.ctx.showHookConfirm(
-				"Overwrite TTSR rule?",
-				`${shortenPath(target.filePath)} already exists. Overwrite it?`,
-			);
-			if (!this.#isActiveRequest(request)) return { kind: "aborted" };
-			if (!shouldOverwrite) {
-				request.component.markRejected();
-				return { kind: "rejected" };
+			if (location === AMEND_OPTION) {
+				request.component.setStatus("confirming", "Describe how to amend the rule…");
+				const amendment = await this.ctx.showHookInput(
+					"Amend TTSR rule",
+					"e.g. Make it specific to Ruby string eval in tool:write(*.rb)",
+				);
+				if (!this.#isActiveRequest(request)) return { kind: "aborted" };
+				const feedback = amendment?.trim();
+				if (!feedback) continue;
+				return { kind: "amend", feedback };
 			}
-		}
 
-		request.component.setStatus("saving", `Saving ${candidate.rule.name}…`);
-		await Bun.write(target.filePath, candidate.fileContent);
-		if (!this.#isActiveRequest(request)) return { kind: "aborted" };
+			const target = this.#resolveTarget(location, candidate.rule.name);
+			if (await Bun.file(target.filePath).exists()) {
+				const shouldOverwrite = await this.ctx.showHookConfirm(
+					"Overwrite TTSR rule?",
+					`${shortenPath(target.filePath)} already exists. Overwrite it?`,
+				);
+				if (!this.#isActiveRequest(request)) return { kind: "aborted" };
+				if (!shouldOverwrite) {
+					request.component.markRejected();
+					return { kind: "rejected" };
+				}
+			}
 
-		const savedRule = buildOmfgRuleForPath(candidate.rule.name, candidate.fileContent, target.filePath, target.level);
-		this.#registerLive(savedRule);
-		request.component.markSaved(shortenPath(target.filePath));
-		return { kind: "saved" };
+			request.component.setStatus("saving", `Saving ${candidate.rule.name}…`);
+			await Bun.write(target.filePath, candidate.fileContent);
+			if (!this.#isActiveRequest(request)) return { kind: "aborted" };
+
+			const savedRule = buildOmfgRuleForPath(
+				candidate.rule.name,
+				candidate.fileContent,
+				target.filePath,
+				target.level,
+			);
+			this.#registerLive(savedRule);
+			request.component.markSaved(shortenPath(target.filePath));
+			return { kind: "saved" };
+		}
 	}
 
 	#resolveTarget(location: string, ruleName: string): { filePath: string; level: OmfgRuleSourceLevel } {

package/src/modes/controllers/selector-controller.ts

@@ -57,12 +57,10 @@ import {
 	parseConfiguredThinkingLevel,
 } from "../../thinking";
 import {
-	isImageProviderPreference,
 	isSearchProviderId,
-	isSearchProviderPreference,
 	setExcludedSearchProviders,
-	setPreferredImageProvider,
-	setPreferredSearchProvider,
+	setImageProviderOrder,
+	setSearchProviderOrder,
 	type ToolSession,
 } from "../../tools";
 import { AskTool, type AskToolDetails, type AskToolInput } from "../../tools/ask";
@@ -439,6 +437,16 @@ export class SelectorController {
 					this.ctx.showError(`Failed to apply personality: ${err}`);
 				});
 				break;
+			case "tools.xdevDocs":
+				void this.ctx.session.refreshBaseSystemPrompt().catch(err => {
+					this.ctx.showError(`Failed to apply xd:// prompt docs setting: ${err}`);
+				});
+				break;
+			case "memory.backend":
+				void this.ctx.session.applyMemoryBackend().catch(err => {
+					this.ctx.showError(`Failed to apply memory backend: ${err}`);
+				});
+				break;
 
 			case "autocompleteMaxVisible":
 				this.ctx.editor.setAutocompleteMaxVisible(typeof value === "number" ? value : Number(value));
@@ -609,9 +617,9 @@ export class SelectorController {
 			}
 
 			// Provider settings - update runtime preferences
-			case "providers.webSearch":
-				if (typeof value === "string" && isSearchProviderPreference(value)) {
-					setPreferredSearchProvider(value);
+			case "providers.webSearchOrder":
+				if (Array.isArray(value)) {
+					setSearchProviderOrder(value.filter(isSearchProviderId));
 				}
 				break;
 			case "providers.webSearchExclude":
@@ -619,9 +627,9 @@ export class SelectorController {
 					setExcludedSearchProviders(value.filter(isSearchProviderId));
 				}
 				break;
-			case "providers.image":
-				if (isImageProviderPreference(value)) {
-					setPreferredImageProvider(value);
+			case "providers.imageOrder":
+				if (Array.isArray(value)) {
+					setImageProviderOrder(value.filter((entry): entry is string => typeof entry === "string"));
 				}
 				break;
 

package/src/modes/controllers/session-focus-controller.ts

@@ -12,6 +12,7 @@
 import { AgentLifecycleManager } from "../../registry/agent-lifecycle";
 import { AgentRegistry, MAIN_AGENT_ID, type RegistryEvent } from "../../registry/agent-registry";
 import type { AgentSession } from "../../session/agent-session";
+import { setTerminalTitleState } from "../../utils/title-generator";
 import type { InteractiveModeContext } from "../types";
 
 export class SessionFocusController {
@@ -104,8 +105,12 @@ export class SessionFocusController {
 		});
 		this.ctx.statusLine.setSession(target, this.#focusedAgentId);
 		this.ctx.renderInitialMessages({ clearTerminalHistory: true });
-		// Mid-turn attach: no agent_start will arrive; arm the loader/turn state manually.
+		// Sync the run-state title to the attached target: a streaming target has no
+		// agent_start incoming, so arm the loader/working title manually; an idle
+		// target would otherwise inherit the previous session's stuck spinner, so
+		// reset it to idle (agent_end teardown already ran via clearTransientSessionUi).
 		if (target.isStreaming) await this.ctx.eventController.handleEvent({ type: "agent_start" });
+		else setTerminalTitleState("idle");
 		this.ctx.updateEditorBorderColor();
 		this.ctx.ui.requestRender();
 	}