@oh-my-pi/pi-coding-agent 16.4.6 → 16.5.0

package/src/eval/__tests__/agent-bridge.test.ts

@@ -28,7 +28,7 @@ const taskAgent = {
 	systemPrompt: "Run the task.",
 	source: "bundled",
 	spawns: "*",
-	model: ["pi/task"],
+	model: ["@task"],
 } satisfies AgentDefinition;
 
 const reviewerAgent = {
@@ -36,7 +36,7 @@ const reviewerAgent = {
 	description: "Reviewer agent",
 	systemPrompt: "Review the task.",
 	source: "bundled",
-	model: ["pi/smol"],
+	model: ["@smol"],
 } satisfies AgentDefinition;
 
 interface SessionOptions {

package/src/eval/__tests__/completion-bridge.test.ts

@@ -193,7 +193,7 @@ describe("runEvalCompletion", () => {
 		expect(resolved).toEqual(["p/smol", "p/default", "p/slow"]);
 	});
 
-	it("prefers the session active model for the default tier, falling back to pi/default", async () => {
+	it("prefers the session active model for the default tier, falling back to @default", async () => {
 		const spy = vi.spyOn(ai, "completeSimple").mockResolvedValue(assistant({ text: "ok" }));
 		const session = makeSession({ available: [SMOL, DEFAULT, SLOW], activeModel: "p/slow" });
 

package/src/eval/completion-bridge.ts

@@ -37,9 +37,9 @@ const STRUCTURED_TOOL_NAME = "respond";
 type CompletionTier = "smol" | "default" | "slow";
 
 const TIER_TO_PATTERN: Record<CompletionTier, string> = {
-	smol: "pi/smol",
-	default: "pi/default",
-	slow: "pi/slow",
+	smol: "@smol",
+	default: "@default",
+	slow: "@slow",
 };
 
 const completionArgsSchema = type({
@@ -62,7 +62,7 @@ export interface EvalCompletionResult {
 
 /**
  * Resolve a tier to a concrete {@link Model}. `default` prefers the session's
- * active model and falls back to the `pi/default` role; `smol`/`slow` resolve
+ * active model and falls back to the `@default` role; `smol`/`slow` resolve
  * their respective role patterns. Returns `undefined` when nothing matches.
  */
 function resolveTierModel(tier: CompletionTier, session: ToolSession): Model<Api> | undefined {

package/src/eval/js/shared/rewrite-imports.ts

@@ -48,6 +48,15 @@ type BabelClassDeclaration = {
 };
 
 type BabelLexicalDecl = BabelVariableDeclaration | BabelClassDeclaration;
+type BabelFunctionDeclaration = {
+	type: "FunctionDeclaration";
+	start: number;
+	end: number;
+	id: { start: number; end: number; name: string } | null;
+};
+
+/** Top-level declarations whose bindings must survive the cell (demoted and/or published). */
+type BabelPublishableDecl = BabelLexicalDecl | BabelFunctionDeclaration;
 
 type BabelExpressionStatement = {
 	type: "ExpressionStatement";
@@ -322,7 +331,7 @@ function collectBindingNames(pattern: unknown, names: string[]): void {
 	}
 }
 
-function getLexicalBindingNames(node: BabelLexicalDecl): string[] {
+function getLexicalBindingNames(node: BabelPublishableDecl): string[] {
 	const names: string[] = [];
 	if (node.type === "VariableDeclaration") {
 		for (const declaration of node.declarations ?? []) collectBindingNames(declaration.id, names);
@@ -348,40 +357,49 @@ function appendGlobalBindingPublish(source: string, names: readonly string[]): s
  *   let { a, b } = obj;      -> var { a, b } = obj;
  *   class Foo extends Bar {} -> var Foo = class extends Bar {};
  *
- * When the source must run inside the async wrapper, demoted `var`s would normally become
- * function-scoped. In that mode we publish each top-level binding back to the wrapper's
- * lexical `this`, which is the worker global object.
+ * When the source must run inside the async wrapper (top-level `await`), demoted `var`s —
+ * and the user's own top-level `var` and `function` declarations — would be scoped to the
+ * wrapper function and die with the cell. In that mode we publish every top-level binding
+ * back to the wrapper's lexical `this`, which is the worker global object.
  *
- * Nested declarations (inside functions, blocks, classes) are left alone \u2014 they're
+ * Nested declarations (inside functions, blocks, classes) are left alone — they're
  * scoped to their enclosing function/block regardless of `var` vs `let`/`const`.
  */
 async function demoteTopLevelLexicals(code: string, options: { publishGlobals?: boolean } = {}): Promise<string> {
-	if (!/\b(?:const|let|class)\b/.test(code)) return code;
+	const publishGlobals = options.publishGlobals === true;
+	const fastPath = publishGlobals ? /\b(?:const|let|class|var|function)\b/ : /\b(?:const|let|class)\b/;
+	if (!fastPath.test(code)) return code;
 
 	const ast = await parseProgram(code);
 	if (!ast) {
 		return code;
 	}
 
-	const targets: BabelLexicalDecl[] = [];
+	const targets: Array<{ node: BabelPublishableDecl; demote: boolean }> = [];
 	for (const node of ast.program.body) {
 		if (node.type === "VariableDeclaration") {
 			const decl = node as unknown as BabelVariableDeclaration;
-			if (decl.kind === "const" || decl.kind === "let") targets.push(decl);
+			if (decl.kind === "const" || decl.kind === "let") targets.push({ node: decl, demote: true });
+			else if (publishGlobals) targets.push({ node: decl, demote: false });
 		} else if (node.type === "ClassDeclaration") {
 			const decl = node as unknown as BabelClassDeclaration;
-			if (decl.id) targets.push(decl);
+			if (decl.id) targets.push({ node: decl, demote: true });
+		} else if (publishGlobals && node.type === "FunctionDeclaration") {
+			const decl = node as unknown as BabelFunctionDeclaration;
+			if (decl.id) targets.push({ node: decl, demote: false });
 		}
 	}
 	if (targets.length === 0) return code;
 
-	targets.sort((a, b) => b.start - a.start);
+	targets.sort((a, b) => b.node.start - a.node.start);
 	let result = code;
-	for (const node of targets) {
+	for (const { node, demote } of targets) {
 		const segment = result.slice(node.start, node.end);
-		const bindingNames = options.publishGlobals ? getLexicalBindingNames(node) : [];
+		const bindingNames = publishGlobals ? getLexicalBindingNames(node) : [];
 		let replacement: string;
-		if (node.type === "VariableDeclaration") {
+		if (!demote) {
+			replacement = segment;
+		} else if (node.type === "VariableDeclaration") {
 			replacement = `var${segment.slice(node.kind.length)}`;
 		} else {
 			const id = node.id;

package/src/export/ttsr.ts

@@ -457,9 +457,6 @@ export class TtsrManager {
 				strictness: AstMatchStrictness.Smart,
 				limit: 1,
 			});
-			if (result.parseErrors && result.parseErrors.length > 0) {
-				logger.debug("TTSR ast match reported parse errors", { parseErrors: result.parseErrors });
-			}
 			return result.totalMatches > 0;
 		} catch (error) {
 			logger.warn("TTSR ast match failed, treating as no match", {

package/src/extensibility/extensions/model-api.ts

@@ -25,7 +25,7 @@ export function createExtensionModelQuery(
 	return {
 		list: () => modelRegistry.getAvailable(),
 		current: () => getModel(),
-		// resolveModelRoleValue expands a role alias (`pi/slow`) to its full configured
+		// resolveModelRoleValue expands a role alias (`@slow`) to its full configured
 		// priority list and tries each pattern — the same path core selection uses — so a
 		// fallback model lower in the list still resolves. Plain model strings pass through
 		// as a single pattern.

package/src/extensibility/extensions/types.ts

@@ -391,7 +391,7 @@ export interface ExtensionModelQuery {
 	/** The current session model, if one is set. */
 	current(): Model | undefined;
 	/**
-	 * Resolve a model string (`provider/id`, bare id) or role alias (`pi/slow`, a
+	 * Resolve a model string (`provider/id`, bare id) or role alias (`@slow`, a
 	 * configured role) to a Model, using the same settings-backed aliases and match
 	 * preferences as core selection. Thinking/routing suffixes are accepted and resolved
 	 * to the base model (pass effort separately). Returns undefined when nothing matches.

package/src/internal-urls/docs-index.ts

@@ -1,8 +1,8 @@
 /**
  * Harness documentation index for the `omp://` protocol.
  *
- * Compiled binaries and the prepacked npm bundle inline a compressed index from
- * `docs-index.generated.txt` (populated by `gen:docs` at build time). The format is two lines:
+ * Compiled binaries and the prepacked npm bundle inline a compressed index of the
+ * docs (injected via `process.env.PI_DOCS_EMBED` at build time). The format is two lines:
  *   1. a plain JSON array of the sorted doc file names, and
  *   2. a base64 gzip blob of the index-aligned doc bodies (`string[]`).
  * Listing/completion (`getDocFilenames`) parses only the small first line and
@@ -83,8 +83,8 @@ function getIndex(): DocsIndex {
 	const decoded = decodeDocsIndex(docsEmbed);
 	if (decoded === null) {
 		throw new Error(
-			"Malformed embedded docs index (docs-index.generated.txt): non-empty payload without a newline separator. " +
-				"Rebuild with `bun run gen:docs`.",
+			"Malformed embedded docs index: non-empty payload without a newline separator. " +
+				"Rebuild the binary or bundle.",
 		);
 	}
 	index = decoded;