@oh-my-pi/pi-coding-agent 16.3.13 → 16.3.14

package/dist/types/utils/thinking-display.d.ts

@@ -1,5 +1,10 @@
 import type { AgentMessage } from "@oh-my-pi/pi-agent-core";
 export declare function canonicalizeMessage(text: string | null | undefined): string;
+/**
+ * Thinking text prepared for display. Both modes drop empty `<!-- -->`
+ * sentinel lines outside code fences (see {@link isCommentNoise}); prose-only
+ * mode additionally elides fenced code down to a trailing ellipsis.
+ */
 export declare function formatThinkingForDisplay(text: string, proseOnly: boolean): string;
 /** Whether a formatted thinking block has non-placeholder content worth rendering. */
 export declare function hasDisplayableThinking(text: string | null | undefined, formattedText: string | null | undefined): boolean;

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "16.3.13",
+	"version": "16.3.14",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://omp.sh",
 	"author": "Can Boluk",
@@ -56,17 +56,17 @@
 		"@agentclientprotocol/sdk": "0.25.0",
 		"@babel/parser": "^7.29.7",
 		"@mozilla/readability": "^0.6.0",
-		"@oh-my-pi/hashline": "16.3.13",
-		"@oh-my-pi/omp-stats": "16.3.13",
-		"@oh-my-pi/pi-agent-core": "16.3.13",
-		"@oh-my-pi/pi-ai": "16.3.13",
-		"@oh-my-pi/pi-catalog": "16.3.13",
-		"@oh-my-pi/pi-mnemopi": "16.3.13",
-		"@oh-my-pi/pi-natives": "16.3.13",
-		"@oh-my-pi/pi-tui": "16.3.13",
-		"@oh-my-pi/pi-utils": "16.3.13",
-		"@oh-my-pi/pi-wire": "16.3.13",
-		"@oh-my-pi/snapcompact": "16.3.13",
+		"@oh-my-pi/hashline": "16.3.14",
+		"@oh-my-pi/omp-stats": "16.3.14",
+		"@oh-my-pi/pi-agent-core": "16.3.14",
+		"@oh-my-pi/pi-ai": "16.3.14",
+		"@oh-my-pi/pi-catalog": "16.3.14",
+		"@oh-my-pi/pi-mnemopi": "16.3.14",
+		"@oh-my-pi/pi-natives": "16.3.14",
+		"@oh-my-pi/pi-tui": "16.3.14",
+		"@oh-my-pi/pi-utils": "16.3.14",
+		"@oh-my-pi/pi-wire": "16.3.14",
+		"@oh-my-pi/snapcompact": "16.3.14",
 		"@opentelemetry/api": "^1.9.1",
 		"@opentelemetry/context-async-hooks": "^2.7.1",
 		"@opentelemetry/exporter-trace-otlp-proto": "^0.218.0",

package/src/modes/components/transcript-container.ts

@@ -40,6 +40,18 @@ interface FinalizableBlock {
 	 * commits until the block finalizes.
 	 */
 	getTranscriptBlockSettledRows?(): number;
+	/**
+	 * Whether the block is a displaceable snapshot (todo/poll card) kept
+	 * unfinalized only so a follow-up matching call can retract it. Paired
+	 * with {@link seal}: once any of its rows enters native scrollback the
+	 * container seals it — rows on the tape are immutable, so retraction is
+	 * no longer possible, and an unfinalized block would otherwise pin the
+	 * live-region seam open for the rest of the turn (every row committed
+	 * below it audit-exempt, mass-recommitted when it finally finalizes).
+	 */
+	isDisplaceableBlock?(): boolean;
+	/** Finalize a displaceable snapshot in place (settle animation, freeze bytes). */
+	seal?(): void;
 }
 
 function isBlockFinalized(child: Component): boolean {
@@ -60,6 +72,12 @@ function getBlockSettledRows(child: Component): number {
 	return Number.isFinite(value) ? Math.max(0, Math.trunc(value)) : 0;
 }
 
+/** Seal a displaceable snapshot whose rows entered native scrollback (see {@link FinalizableBlock.isDisplaceableBlock}). */
+function sealCommittedSnapshot(child: Component): void {
+	const block = child as Component & FinalizableBlock;
+	if (block.isDisplaceableBlock?.()) block.seal?.();
+}
+
 // A "plain blank" row is empty or whitespace-only with no ANSI bytes. It marks
 // separation padding (a `Spacer`, or a no-background `paddingY` row) as opposed
 // to a background-colored padding row, whose escape sequences contain `\S` and
@@ -275,6 +293,21 @@ export class TranscriptContainer
 
 		const count = this.children.length;
 
+		// Seal displaceable snapshots whose rows are already on the tape (per the
+		// previous frame's segments — the geometry the committed count was
+		// computed against): immutable history can no longer be retracted, and
+		// left unfinalized such a block would pin the live-region seam open below
+		// it. Runs before the live-block scan so the seam unpins in this same
+		// frame, and every frame so a block that BECAME displaceable after its
+		// pending-preview rows committed (late result on a scrolled-off call) is
+		// caught too.
+		for (let i = 0; i < count && i < this.#segments.length; i++) {
+			const previous = this.#segments[i]!;
+			if (previous.startRow >= this.#committedRows) break;
+			if (previous.rowCount === 0 || previous.component !== this.children[i]) continue;
+			sealCommittedSnapshot(previous.component);
+		}
+
 		// The commit boundary stops at the earliest still-mutating block. A
 		// block that has not finalized must gate it: out-of-band inserts
 		// (TTSR/todo cards) can append a finalized block *below* a tool that is

package/src/prompts/system/workflow-notice.md

@@ -51,20 +51,20 @@ Decompose first, then {{#if taskBatch}}batch the independent leaves{{else}}issue
 
 {{#if taskBatch}}
     task(
-      context: "# Goal\nReview the auth diff...\n# Constraints\nRead-only...\n# Contract\nReturn findings as severity/file/line/fix...",
+      context: "# Goal\nReview the auth diff…\n# Constraints\nRead-only…\n# Contract\nReturn findings as severity/file/line/fix…",
       tasks: [
-        { id: "AuthOwner", role: "Auth Storage Reviewer", assignment: "# Target\npackages/ai/src/auth-storage.ts\n# Change\nTrace credential selection...\n# Acceptance\nReturn confirmed findings only..." },
-        { id: "PromptOwner", role: "Prompt Contract Reviewer", assignment: "# Target\npackages/coding-agent/src/prompts/**\n# Change\nCheck active-tool guidance...\n# Acceptance\nReturn mismatches and exact prompt lines..." },
+        { id: "AuthOwner", role: "Auth Storage Reviewer", assignment: "# Target\npackages/ai/src/auth-storage.ts\n# Change\nTrace credential selection…\n# Acceptance\nReturn confirmed findings only…" },
+        { id: "PromptOwner", role: "Prompt Contract Reviewer", assignment: "# Target\npackages/coding-agent/src/prompts/**\n# Change\nCheck active-tool guidance…\n# Acceptance\nReturn mismatches and exact prompt lines…" },
       ]
     )
 {{else}}
     task(
       role: "Auth Storage Reviewer",
-      assignment: "# Target\npackages/ai/src/auth-storage.ts\n# Change\nReview the auth diff. Shared contract: read-only; return findings as severity/file/line/fix.\n# Acceptance\nReturn confirmed findings only..."
+      assignment: "# Target\npackages/ai/src/auth-storage.ts\n# Change\nReview the auth diff. Shared contract: read-only; return findings as severity/file/line/fix.\n# Acceptance\nReturn confirmed findings only…"
     )
     task(
       role: "Prompt Contract Reviewer",
-      assignment: "# Target\npackages/coding-agent/src/prompts/**\n# Change\nCheck active-tool guidance. Shared contract: read-only; return mismatches and exact prompt lines.\n# Acceptance\nReturn confirmed findings only..."
+      assignment: "# Target\npackages/coding-agent/src/prompts/**\n# Change\nCheck active-tool guidance. Shared contract: read-only; return mismatches and exact prompt lines.\n# Acceptance\nReturn confirmed findings only…"
     )
 {{/if}}
 

package/src/utils/thinking-display.ts

@@ -1,14 +1,16 @@
 import type { AgentMessage } from "@oh-my-pi/pi-agent-core";
 
-// Single-entry memo for the proseOnly formatting path. During a streaming tick
-// the same growing thinking text is formatted up to three times (reveal count,
-// reveal slice, component render); this collapses them to one computation. The
-// `proseOnly === false` branch is a passthrough and never consults the cache, so
-// the key can be the text alone. A single entry is enough for the common case of
-// one active thinking block and never regresses (a miss recomputes exactly as
-// before).
-let formatCacheKey = "";
-let formatCacheValue = "";
+// Single-slot-per-mode memo for formatThinkingForDisplay. During a streaming
+// tick the same growing thinking text is formatted up to three times (reveal
+// count, reveal slice, component render); this collapses them to one
+// computation. Prose and raw modes produce different output for the same text,
+// so each mode keeps its own slot. One entry per mode is enough for the common
+// case of one active thinking block and never regresses (a miss recomputes
+// exactly as before).
+let proseCacheKey = "";
+let proseCacheValue = "";
+let rawCacheKey = "";
+let rawCacheValue = "";
 
 export function canonicalizeMessage(text: string | null | undefined): string {
 	if (!text) return "";
@@ -22,9 +24,35 @@ export function canonicalizeMessage(text: string | null | undefined): string {
 	return "";
 }
 
+// gpt-5.x reasoning summaries pad every summary part with an empty HTML
+// comment (`**Headline**\n\n<!-- -->`), streamed as a `<!--` delta followed by
+// ` -->`. Comments with actual content are left untouched.
+const EMPTY_COMMENT_RE = /^<!--\s*-->$/;
+const OPEN_COMMENT_RE = /^<!--\s*$/;
+
+/**
+ * Whether `line` is reasoning-summary comment noise: an empty HTML comment,
+ * or its still-unterminated `<!--` prefix on the last line while streaming.
+ */
+function isCommentNoise(line: string, isLastLine: boolean): boolean {
+	const trimmed = line.trim();
+	return EMPTY_COMMENT_RE.test(trimmed) || (isLastLine && OPEN_COMMENT_RE.test(trimmed));
+}
+
+/**
+ * Thinking text prepared for display. Both modes drop empty `<!-- -->`
+ * sentinel lines outside code fences (see {@link isCommentNoise}); prose-only
+ * mode additionally elides fenced code down to a trailing ellipsis.
+ */
 export function formatThinkingForDisplay(text: string, proseOnly: boolean): string {
-	if (!proseOnly || !text) return text;
-	if (text === formatCacheKey) return formatCacheValue;
+	if (!text) return text;
+	const hasComment = text.includes("<!--");
+	if (proseOnly) {
+		if (text === proseCacheKey) return proseCacheValue;
+	} else {
+		if (!hasComment) return text;
+		if (text === rawCacheKey) return rawCacheValue;
+	}
 
 	const lines = text.split("\n");
 	const resultLines: string[] = [];
@@ -56,22 +84,31 @@ export function formatThinkingForDisplay(text: string, proseOnly: boolean): stri
 
 	for (let i = 0; i < lines.length; i++) {
 		const line = lines[i]!;
-		const open = FENCE.exec(line);
 
 		if (inFence) {
+			const close = FENCE.exec(line);
 			// A closing fence is the same char, at least as long, with nothing else on the line.
 			if (
-				open &&
-				open[2]![0] === fenceChar &&
-				open[2]!.length >= fenceLen &&
-				line.slice(open[1]!.length + open[2]!.length).trim() === ""
+				close &&
+				close[2]![0] === fenceChar &&
+				close[2]!.length >= fenceLen &&
+				line.slice(close[1]!.length + close[2]!.length).trim() === ""
 			) {
 				inFence = false;
 				fenceChar = "";
 				fenceLen = 0;
 			}
-			// We skip all internal lines of a code fence.
-		} else if (open) {
+			// Prose mode skips all fence lines; raw mode keeps them verbatim
+			// (comment markers inside fences are code, not noise).
+			if (!proseOnly) resultLines.push(line);
+			continue;
+		}
+
+		// Drop the whole line so `**Headline**\n\n<!-- -->` leaves no blank tail.
+		if (hasComment && isCommentNoise(line, i === lines.length - 1)) continue;
+
+		const open = FENCE.exec(line);
+		if (open) {
 			const marker = open[2]!;
 			const ch = marker[0]!;
 			// A backtick fence's info string may not contain a backtick.
@@ -79,18 +116,25 @@ export function formatThinkingForDisplay(text: string, proseOnly: boolean): stri
 				inFence = true;
 				fenceChar = ch;
 				fenceLen = marker.length;
-				appendEllipsis();
-			} else {
-				resultLines.push(line);
+				if (proseOnly) {
+					appendEllipsis();
+				} else {
+					resultLines.push(line);
+				}
+				continue;
 			}
-		} else {
-			resultLines.push(line);
 		}
+		resultLines.push(line);
 	}
 
 	const formatted = resultLines.join("\n");
-	formatCacheKey = text;
-	formatCacheValue = formatted;
+	if (proseOnly) {
+		proseCacheKey = text;
+		proseCacheValue = formatted;
+	} else {
+		rawCacheKey = text;
+		rawCacheValue = formatted;
+	}
 	return formatted;
 }
 
@@ -99,9 +143,11 @@ export function hasDisplayableThinking(
 	text: string | null | undefined,
 	formattedText: string | null | undefined,
 ): boolean {
-	if (!text) return false;
-	if (!formattedText) return false;
-	return formattedText.length > 0 && canonicalizeMessage(text).length > 0;
+	if (!text || !formattedText) return false;
+	// Visibility keys off the formatted text: a block whose raw text is only
+	// comment noise (`<!-- -->\n`) formats to whitespace and stays hidden. The
+	// raw canonicalize check still hides dot/ellipsis-only placeholder blocks.
+	return formattedText.trim().length > 0 && canonicalizeMessage(text).length > 0;
 }
 
 /** Whether an assistant message contains thinking content the TUI can reveal. */