@oh-my-pi/pi-coding-agent 16.2.9 → 16.2.11

package/dist/types/extensibility/skills.d.ts

@@ -64,4 +64,33 @@ export interface BuiltSkillPromptMessage {
     details: SkillPromptDetails;
 }
 export declare function getSkillSlashCommandName(skill: Pick<Skill, "name">): string;
+/**
+ * Parsed `/skill:<name>` invocation: either at the start of the draft (the
+ * traditional slash-command position) or as a `/skill:<name>` token embedded
+ * mid-prompt. For the mid-prompt form the surrounding prose is threaded
+ * through as `args` so the skill sees the full user request.
+ */
+export interface ParsedSkillInvocation {
+    /** Bare skill name without the leading `skill:` prefix. */
+    name: string;
+    /** User-supplied arguments (everything outside the `/skill:<name>` token). */
+    args: string;
+}
+/**
+ * Detect a `/skill:<name>` invocation in a user draft.
+ *
+ * Returns `undefined` when the text contains no skill token. Otherwise:
+ *   - Leading form (`/skill:foo bar baz`): name=`foo`, args=`bar baz`.
+ *   - Mid-prompt form (`fix the bug /skill:foo focus on auth`): name=`foo`,
+ *     args=`fix the bug focus on auth` — the surrounding prose collapsed
+ *     into a single args string.
+ *
+ * Mid-prompt detection is disabled when the draft itself starts with a
+ * different slash command (e.g. `/compact /skill:foo`) or a local-execution
+ * sigil — `!cmd` / `!!cmd` for the bash tool and `$ cmd` / `$$ cmd` for the
+ * python tool. Those handlers run after the skill-command dispatcher and
+ * their bodies routinely contain `/skill:<name>` references that are not
+ * meant as skill invocations.
+ */
+export declare function parseSkillInvocation(text: string): ParsedSkillInvocation | undefined;
 export declare function buildSkillPromptMessage(skill: Pick<Skill, "name" | "filePath">, args: string): Promise<BuiltSkillPromptMessage>;

package/dist/types/modes/components/todo-reminder.d.ts

@@ -1,7 +1,9 @@
 import { Container } from "@oh-my-pi/pi-tui";
 import type { TodoItem } from "../../tools/todo";
 /**
- * Component that renders a todo completion reminder notification.
+ * Component that renders a todo completion reminder notification, committed into
+ * the transcript like a TTSR notification so it stays anchored in history rather
+ * than floating above the editor.
  * Shows when the agent stops with incomplete todos.
  */
 export declare class TodoReminderComponent extends Container {

package/dist/types/modes/controllers/tool-args-reveal.d.ts

@@ -36,6 +36,11 @@ export declare class ToolArgsRevealController {
     setTarget(id: string, partialJson: string, target: ToolArgsRevealTarget): Record<string, unknown>;
     /** Attach the component future ticks push frames into. */
     bind(id: string, component: ToolArgsRevealComponent): void;
+    /** Migrate a live reveal entry from a placeholder key onto the real
+     *  tool-call id once the owned-dialect parser assigns it. No-op when no
+     *  entry exists under `from` (smoothing disabled, or the JSON already
+     *  closed and `finish` cleared it). */
+    rekey(from: string, to: string): void;
     /** Final arguments arrived (the JSON closed): drop the reveal so the
      *  caller's final-args render wins immediately, mirroring how assistant
      *  text snaps to the full message at message_end. */

package/dist/types/modes/interactive-mode.d.ts

@@ -83,7 +83,6 @@ export declare class InteractiveMode implements InteractiveModeContext {
     chatContainer: TranscriptContainer;
     pendingMessagesContainer: Container;
     statusContainer: Container;
-    todoReminderContainer: Container;
     todoContainer: Container;
     subagentContainer: Container;
     btwContainer: Container;

package/dist/types/modes/skill-command.d.ts

@@ -23,7 +23,7 @@ export interface BuiltSkillCommandPrompt {
     message: SkillPromptMessage;
     options: SkillPromptOptions;
 }
-/** Return true when `text` names a registered `/skill:<name>` command. */
+/** Return true when `text` invokes a registered `/skill:<name>` command. */
 export declare function isKnownSkillCommand(ctx: SkillCommandHost, text: string): boolean;
 /** Build the user-attributed custom message for a registered `/skill:<name>` command. */
 export declare function buildSkillCommandPrompt(ctx: SkillCommandHost, text: string, streamingBehavior: "steer" | "followUp", images?: ImageContent[]): Promise<BuiltSkillCommandPrompt | undefined>;

package/dist/types/modes/types.d.ts

@@ -81,7 +81,6 @@ export interface InteractiveModeContext {
     chatContainer: TranscriptContainer;
     pendingMessagesContainer: Container;
     statusContainer: Container;
-    todoReminderContainer: Container;
     todoContainer: Container;
     subagentContainer: Container;
     btwContainer: Container;

package/dist/types/stt/asr-client.d.ts

@@ -1,4 +1,4 @@
-import { type SpawnedSubprocess, type WorkerHandle } from "../subprocess/worker-client";
+import { type RefCountedWorkerHandle, type SpawnedSubprocess } from "../subprocess/worker-client";
 import type { SttProgressEvent, SttWorkerInbound, SttWorkerOutbound } from "./asr-protocol";
 import type { SttModelKey } from "./models";
 export interface SttTranscribeOptions {
@@ -9,6 +9,10 @@ export interface SttDownloadOptions {
     signal?: AbortSignal;
     onProgress?: (event: SttProgressEvent) => void;
 }
+export interface SttDownloadResult {
+    ok: boolean;
+    error?: string;
+}
 /** Live streaming session handle returned by {@link SttClient.startStream}. */
 export interface SttStreamHandle {
     /** Feed 16 kHz mono float samples as the recorder produces them. */
@@ -38,7 +42,7 @@ export declare const STT_WORKER_ARG = "__omp_worker_stt";
 export declare function createSttSubprocess(): SpawnedSubprocess<SttWorkerOutbound>;
 export declare class SttClient {
     #private;
-    constructor(spawnWorker?: () => WorkerHandle<SttWorkerInbound, SttWorkerOutbound>);
+    constructor(spawnWorker?: () => RefCountedWorkerHandle<SttWorkerInbound, SttWorkerOutbound>);
     onProgress(listener: (event: SttProgressEvent) => void): () => void;
     /**
      * Transcribe 16 kHz mono audio on the warm worker. Rejects with the worker
@@ -54,7 +58,7 @@ export declare class SttClient {
      * an aborted signal) tears the session down and resolves `stop()` with "".
      */
     startStream(modelKey: SttModelKey, options?: SttStreamOptions): SttStreamHandle;
-    downloadModel(modelKey: SttModelKey, options?: SttDownloadOptions): Promise<boolean>;
+    downloadModel(modelKey: SttModelKey, options?: SttDownloadOptions): Promise<SttDownloadResult>;
     terminate(): Promise<void>;
 }
 export declare const sttClient: SttClient;

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "16.2.9",
+	"version": "16.2.11",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://omp.sh",
 	"author": "Can Boluk",
@@ -32,7 +32,8 @@
 	},
 	"scripts": {
 		"build": "bun scripts/build-binary.ts",
-		"check": "biome check . && bun run check:types",
+		"check": "biome check . && bun run check:docs && bun run check:types",
+		"check:docs": "bun scripts/generate-docs-index.ts --check",
 		"check:types": "tsgo -p tsconfig.json --noEmit",
 		"lint": "biome lint .",
 		"test": "bun ../../scripts/ci-test-ts.ts coding-agent-heavy --full",
@@ -55,17 +56,17 @@
 		"@agentclientprotocol/sdk": "0.25.0",
 		"@babel/parser": "^7.29.7",
 		"@mozilla/readability": "^0.6.0",
-		"@oh-my-pi/hashline": "16.2.9",
-		"@oh-my-pi/omp-stats": "16.2.9",
-		"@oh-my-pi/pi-agent-core": "16.2.9",
-		"@oh-my-pi/pi-ai": "16.2.9",
-		"@oh-my-pi/pi-catalog": "16.2.9",
-		"@oh-my-pi/pi-mnemopi": "16.2.9",
-		"@oh-my-pi/pi-natives": "16.2.9",
-		"@oh-my-pi/pi-tui": "16.2.9",
-		"@oh-my-pi/pi-utils": "16.2.9",
-		"@oh-my-pi/pi-wire": "16.2.9",
-		"@oh-my-pi/snapcompact": "16.2.9",
+		"@oh-my-pi/hashline": "16.2.11",
+		"@oh-my-pi/omp-stats": "16.2.11",
+		"@oh-my-pi/pi-agent-core": "16.2.11",
+		"@oh-my-pi/pi-ai": "16.2.11",
+		"@oh-my-pi/pi-catalog": "16.2.11",
+		"@oh-my-pi/pi-mnemopi": "16.2.11",
+		"@oh-my-pi/pi-natives": "16.2.11",
+		"@oh-my-pi/pi-tui": "16.2.11",
+		"@oh-my-pi/pi-utils": "16.2.11",
+		"@oh-my-pi/pi-wire": "16.2.11",
+		"@oh-my-pi/snapcompact": "16.2.11",
 		"@opentelemetry/api": "^1.9.1",
 		"@opentelemetry/context-async-hooks": "^2.7.1",
 		"@opentelemetry/exporter-trace-otlp-proto": "^0.218.0",

package/scripts/bundle-dist.ts

@@ -3,6 +3,7 @@
 import * as fs from "node:fs/promises";
 import * as path from "node:path";
 import { isEnoent } from "@oh-my-pi/pi-utils";
+import { assertDocsIndexFresh, buildDocsIndexPayload } from "./generate-docs-index";
 
 const packageDir = path.join(import.meta.dir, "..");
 const outDir = path.join(packageDir, "dist");
@@ -72,13 +73,31 @@ async function cleanBundleOutputs(): Promise<void> {
 	);
 }
 
+async function assertDocsEmbedPopulated(): Promise<void> {
+	// bundle-dist runs from prepack (which calls `gen:docs` first) or directly.
+	// Direct invocations must fail — the tarball ships src/, and an empty embed
+	// would make src/internal-urls/docs-index.ts fall through to the missing
+	// repo `docs/` tree at runtime in published packages (codex review, PR #3941).
+	const embedPath = path.join(packageDir, "src/internal-urls/docs-index.generated.txt");
+	const embed = await Bun.file(embedPath).text();
+	if (embed.length === 0) {
+		throw new Error(
+			"docs-index embed is empty. Run `bun run gen:docs` before `bun run gen:bundle`, or use `bun pm pack` which runs the prepack chain.",
+		);
+	}
+	const expected = await buildDocsIndexPayload();
+	assertDocsIndexFresh(embed, expected);
+}
+
 async function main(): Promise<void> {
 	const start = Bun.nanoseconds();
 	await cleanBundleOutputs();
-	// The npm bundle ships no stats dashboard sources or prebuilt dist/client,
-	// so embed the dashboard archive the same way compiled binaries do
-	// (scripts/build-binary.ts). Reset afterwards to keep the checked-in
-	// placeholder empty.
+	await assertDocsEmbedPopulated();
+	// The npm bundle ships no stats dashboard sources, so embed the dashboard
+	// archive the same way compiled binaries do (scripts/build-binary.ts). Reset
+	// afterwards to keep the checked-in placeholder empty. The docs embed stays
+	// populated on disk — postpack owns its reset so `bun pm pack` can pack a
+	// tarball whose src copy is still valid for subpath imports.
 	await runCommand(["bun", "--cwd=../stats", "run", "gen:stats"]);
 	try {
 		await runCommand([

package/scripts/generate-docs-index.ts

@@ -1,56 +1,148 @@
 #!/usr/bin/env bun
 
 /**
- * Populate (or reset) the embedded harness documentation index for `omp://`.
+ * Populate, check, or reset the embedded harness documentation index for `omp://`.
  *
  * `--generate` writes `src/internal-urls/docs-index.generated.txt` as two lines:
  * a plain JSON array of the sorted `docs/**\/*.md` file names, then a base64
- * gzip blob of the index-aligned doc bodies (`string[]`). Keeping the filename
- * list out of the blob lets the loader list docs without inflating it.
- * Compiled binaries and the prepacked npm bundle inline this (~0.5MB) instead of
- * the ~1.6MB raw map; `--reset` restores the checked-in empty placeholder so the
+ * gzip blob of the index-aligned doc bodies (`string[]`). `--check` rebuilds
+ * that payload from the real docs corpus and compares it to the embed when
+ * present; the checked-in empty placeholder is accepted after verifying that a
+ * fresh generated payload round-trips. `--reset` restores the placeholder so the
  * dev tree reads `docs/` from disk. Mirrors the stats / model-catalog embeds.
  */
 
 import * as path from "node:path";
-import { gzipSync } from "node:zlib";
+import { gunzipSync, gzipSync } from "node:zlib";
 import { Glob } from "bun";
 
 const docsDir = path.resolve(import.meta.dir, "../../../docs");
 const outputPath = path.resolve(import.meta.dir, "../src/internal-urls/docs-index.generated.txt");
 const GENERATE_FLAG = "--generate";
 const RESET_FLAG = "--reset";
+const CHECK_FLAG = "--check";
+
+export interface DocsIndexPayload {
+	/** Sorted `docs/**\/*.md` file names plus index-aligned bodies and embed text. */
+	readonly files: readonly string[];
+	readonly bodies: readonly string[];
+	readonly payload: string;
+}
+
+export interface DecodedDocsIndexPayload {
+	/** Sorted `docs/**\/*.md` file names decoded from an embed payload. */
+	readonly files: readonly string[];
+	/** Index-aligned Markdown bodies decoded from an embed payload. */
+	readonly bodies: readonly string[];
+}
+
+function isStringArray(value: unknown): value is string[] {
+	return Array.isArray(value) && value.every(item => typeof item === "string");
+}
+
+/** Build the exact two-line `omp://` docs embed from the source `docs/**\/*.md` corpus. */
+export async function buildDocsIndexPayload(): Promise<DocsIndexPayload> {
+	const glob = new Glob("**/*.md");
+	const files: string[] = [];
+	for await (const relativePath of glob.scan(docsDir)) {
+		files.push(relativePath.split(path.sep).join("/"));
+	}
+	files.sort();
+
+	const bodies = await Promise.all(files.map(file => Bun.file(path.join(docsDir, file)).text()));
+	const bodiesB64 = Buffer.from(gzipSync(Buffer.from(JSON.stringify(bodies)), { level: 9 })).toString("base64");
+	return {
+		files,
+		bodies,
+		payload: `${JSON.stringify(files)}\n${bodiesB64}`,
+	};
+}
+
+/** Decode a populated docs embed payload into filenames and index-aligned Markdown bodies. */
+export function decodeDocsIndexPayload(embed: string): DecodedDocsIndexPayload | null {
+	const newline = embed.indexOf("\n");
+	if (newline === -1) return null;
+
+	const filenames: unknown = JSON.parse(embed.slice(0, newline));
+	if (!isStringArray(filenames)) {
+		throw new Error("Embedded docs index filename line is not a JSON string array.");
+	}
+
+	const inflated = gunzipSync(Buffer.from(embed.slice(newline + 1), "base64"));
+	const bodies: unknown = JSON.parse(inflated.toString("utf8"));
+	if (!isStringArray(bodies)) {
+		throw new Error("Embedded docs index body blob is not a JSON string array.");
+	}
+
+	return { files: filenames, bodies };
+}
+
+/**
+ * Assert that an embed payload is fresh against the current source docs payload.
+ * An empty placeholder is accepted by round-tripping the expected payload (the
+ * dev tree and post-build reset state both checked-in placeholders).
+ */
+export function assertDocsIndexFresh(embed: string, expected: DecodedDocsIndexPayload): void {
+	const source =
+		embed.length > 0
+			? embed
+			: `${JSON.stringify(expected.files)}\n${Buffer.from(gzipSync(Buffer.from(JSON.stringify(expected.bodies)), { level: 9 })).toString("base64")}`;
+	const decoded = decodeDocsIndexPayload(source);
+	if (decoded === null) {
+		throw new Error("Embedded docs index is malformed: missing newline separator.");
+	}
+	if (decoded.files.length !== expected.files.length) {
+		throw new Error(
+			`Embedded docs index has ${decoded.files.length} docs; source corpus has ${expected.files.length}.`,
+		);
+	}
+	if (decoded.bodies.length !== expected.bodies.length) {
+		throw new Error(
+			`Embedded docs index has ${decoded.bodies.length} bodies; source corpus has ${expected.bodies.length}.`,
+		);
+	}
+	for (let i = 0; i < expected.files.length; i++) {
+		if (decoded.files[i] !== expected.files[i]) {
+			throw new Error(
+				`Embedded docs index filename mismatch at ${i}: ${decoded.files[i] ?? "<missing>"} !== ${expected.files[i]}.`,
+			);
+		}
+		if (decoded.bodies[i] !== expected.bodies[i]) {
+			throw new Error(`Embedded docs index body mismatch for ${expected.files[i]}. Run \`bun run gen:docs\`.`);
+		}
+	}
+}
 
 async function main(): Promise<void> {
 	const rel = path.relative(process.cwd(), outputPath);
 
 	if (process.argv.includes(RESET_FLAG)) {
 		await Bun.write(outputPath, "");
-		console.log(`Reset ${rel}`);
+		process.stdout.write(`Reset ${rel}\n`);
 		return;
 	}
 
-	if (!process.argv.includes(GENERATE_FLAG)) {
-		console.log(`Skipping ${rel}; pass ${GENERATE_FLAG} to embed docs (the dev tree reads docs/ from disk)`);
+	if (process.argv.includes(CHECK_FLAG)) {
+		const current = await buildDocsIndexPayload();
+		const embed = await Bun.file(outputPath).text();
+		assertDocsIndexFresh(embed, current);
+		process.stdout.write(`Docs index fresh for ${current.files.length} docs (${rel})\n`);
 		return;
 	}
 
-	const glob = new Glob("**/*.md");
-	const files: string[] = [];
-	for await (const relativePath of glob.scan(docsDir)) {
-		files.push(relativePath.split(path.sep).join("/"));
+	if (!process.argv.includes(GENERATE_FLAG)) {
+		process.stdout.write(
+			`Skipping ${rel}; pass ${GENERATE_FLAG} to embed docs (the dev tree reads docs/ from disk)\n`,
+		);
+		return;
 	}
-	files.sort();
-
-	// Index-aligned bodies (Promise.all preserves order), kept separate from the
-	// filename list so the loader can list docs without inflating the blob.
-	const bodies = await Promise.all(files.map(file => Bun.file(path.join(docsDir, file)).text()));
 
-	const bodiesB64 = Buffer.from(gzipSync(Buffer.from(JSON.stringify(bodies)), { level: 9 })).toString("base64");
-	// Two lines: plain filename array, then the base64 gzip blob.
-	const payload = `${JSON.stringify(files)}\n${bodiesB64}`;
-	await Bun.write(outputPath, payload);
-	console.log(`Generated ${rel} (${files.length} docs, ${payload.length} bytes)`);
+	const current = await buildDocsIndexPayload();
+	assertDocsIndexFresh(current.payload, current);
+	await Bun.write(outputPath, current.payload);
+	process.stdout.write(`Generated ${rel} (${current.files.length} docs, ${current.payload.length} bytes)\n`);
 }
 
-await main();
+if (import.meta.main) {
+	await main();
+}

package/src/async/job-manager.ts

@@ -397,6 +397,27 @@ export class AsyncJobManager {
 		await Promise.all(Array.from(this.#jobs.values()).map(job => job.promise));
 	}
 
+	async #waitForAllUntil(deadline: number): Promise<boolean> {
+		const promises = Array.from(this.#jobs.values()).map(job => job.promise);
+		if (promises.length === 0) return true;
+		if (deadline === Number.POSITIVE_INFINITY) {
+			await Promise.all(promises);
+			return true;
+		}
+		const remainingMs = deadline - Date.now();
+		if (remainingMs <= 0) return false;
+
+		const timeout = Promise.withResolvers<"timeout">();
+		const timer = setTimeout(() => timeout.resolve("timeout"), remainingMs);
+		timer.unref();
+		try {
+			const result = await Promise.race([Promise.all(promises).then(() => "settled" as const), timeout.promise]);
+			return result === "settled";
+		} finally {
+			clearTimeout(timer);
+		}
+	}
+
 	async drainDeliveries(options?: { timeoutMs?: number; filter?: AsyncJobFilter }): Promise<boolean> {
 		const timeoutMs = options?.timeoutMs;
 		const filter = options?.filter;
@@ -445,8 +466,10 @@ export class AsyncJobManager {
 		this.#disposed = true;
 		this.#clearEvictionTimers();
 		this.cancelAll();
-		await this.waitForAll();
-		const drained = await this.drainDeliveries({ timeoutMs: options?.timeoutMs ?? 3_000 });
+		const timeoutMs = Math.max(options?.timeoutMs ?? 3_000, 0);
+		const deadline = Date.now() + timeoutMs;
+		const jobsSettled = await this.#waitForAllUntil(deadline);
+		const drained = await this.drainDeliveries({ timeoutMs: Math.max(deadline - Date.now(), 0) });
 		this.#clearEvictionTimers();
 		this.#jobs.clear();
 		this.#deliveries.length = 0;
@@ -454,7 +477,7 @@ export class AsyncJobManager {
 		this.#suppressedDeliveries.clear();
 		this.#watchedJobs.clear();
 		this.#pollEscalation.clear();
-		return drained;
+		return jobsSettled && drained;
 	}
 
 	#resolveJobId(preferredId?: string): string {
@@ -483,6 +506,7 @@ export class AsyncJobManager {
 	}
 
 	#scheduleEviction(jobId: string): void {
+		if (this.#disposed) return;
 		if (this.#retentionMs <= 0) {
 			this.#jobs.delete(jobId);
 			this.#suppressedDeliveries.delete(jobId);

package/src/cli/grep-cli.ts

@@ -150,7 +150,7 @@ ${chalk.bold("Options:")}
   --no-gitignore        Include files excluded by .gitignore
 
 ${chalk.bold("Environment:")}
-  PI_GREP_WORKERS=N    Set filesystem walker workers (default 4, 0 = auto)
+  PI_WALK_WORKERS=N    Set filesystem walker workers (default 4, 0 = auto)
 
 ${chalk.bold("Examples:")}
   ${APP_NAME} grep "import" src/