@oh-my-pi/pi-coding-agent 16.2.1 → 16.2.3

package/src/eval/js/shared/local-module-loader.ts

@@ -29,6 +29,7 @@ export class LocalModuleLoader {
 	#externalModules = new Map<string, Promise<vm.Module>>();
 	#requireCache = new Map<string, NodeJS.Require>();
 	#modulePaths = new WeakMap<vm.Module, string>();
+	#linkChain: Promise<void> = Promise.resolve();
 
 	constructor(sessionId: string) {
 		this.#context = vm.createContext(globalThis);
@@ -147,7 +148,17 @@ export class LocalModuleLoader {
 	async #linkAndEvaluate(entry: LocalModuleEntry, modulePath: string): Promise<void> {
 		const { module } = entry;
 		try {
-			if (module.status === "unlinked") await module.link(this.#linkResolve);
+			// Serialize the link phase across every graph root. Bun's node:vm linker
+			// segfaults (getImportedModule on a null record) when two link passes
+			// instantiate overlapping module instances concurrently — e.g.
+			// Promise.all([import("./a"), import("./b")]) over a graph that shares
+			// dependencies. Holding the lock for the whole module.link() (including its
+			// async resolver callbacks) guarantees the linker is never re-entered
+			// mid-instantiation. The lock is released before evaluate(), so a dynamic
+			// import during evaluation can re-acquire it without deadlock.
+			await this.#serializeLink(async () => {
+				if (module.status === "unlinked") await module.link(this.#linkResolve);
+			});
 			if (module.status === "linked") await module.evaluate();
 		} catch (error) {
 			this.#invalidateFailedLoad(modulePath);
@@ -159,6 +170,17 @@ export class LocalModuleLoader {
 		}
 	}
 
+	// Promise-chain mutex serializing node:vm link passes (see #linkAndEvaluate).
+	// #linkChain is kept non-rejecting so a failed link never wedges the queue.
+	#serializeLink<T>(run: () => Promise<T>): Promise<T> {
+		const result = this.#linkChain.then(run);
+		this.#linkChain = result.then(
+			() => undefined,
+			() => undefined,
+		);
+		return result;
+	}
+
 	// Shared static-link resolver for `module.link()`. node:vm passes the referencing
 	// module and reuses this one resolver for the entire graph, so the referrer path is
 	// recovered from `#modulePaths`. Local dependencies are constructed but NOT linked or

package/src/export/html/template.js

@@ -1236,7 +1236,7 @@
         let html = `
           <div class="header">
             <h1>Session: ${escapeHtml(header?.id || 'unknown')}</h1>
-            <div class="help-bar">Ctrl+T toggle thinking · Ctrl+O toggle tools</div>
+            <div class="help-bar">T toggle thinking · O toggle tools</div>
             <div class="header-info">
               <div class="info-item"><span class="info-label">Date:</span><span class="info-value">${header?.timestamp ? new Date(header.timestamp).toLocaleString() : 'unknown'}</span></div>
               <div class="info-item"><span class="info-label">Models:</span><span class="info-value">${globalStats.models.join(', ') || 'unknown'}</span></div>
@@ -1580,13 +1580,19 @@
           searchQuery = '';
           navigateTo(leafId, 'bottom');
         }
-        if (e.ctrlKey && e.key === 't') {
+        if (e.key === 't' || e.key === 'T' || e.key === 'o' || e.key === 'O') {
+          // Skip when typing in the sidebar search (or any other editable target)
+          // so the chord can't fire on a user's letter input. Avoid Ctrl/Cmd-based
+          // chords entirely — every major browser reserves Ctrl+T (new tab) and
+          // Ctrl+O (open file), so the shortcut would never reach the page.
+          const t = e.target;
+          const editable =
+            t && (t.tagName === 'INPUT' || t.tagName === 'TEXTAREA' || t.isContentEditable);
+          if (editable) return;
+          if (e.ctrlKey || e.metaKey || e.altKey) return;
           e.preventDefault();
-          toggleThinking();
-        }
-        if (e.ctrlKey && e.key === 'o') {
-          e.preventDefault();
-          toggleToolOutputs();
+          if (e.key === 't' || e.key === 'T') toggleThinking();
+          else toggleToolOutputs();
         }
       });
 

package/src/extensibility/custom-tools/types.ts

@@ -126,6 +126,7 @@ export type CustomToolSessionEvent =
 			maxAttempts: number;
 			delayMs: number;
 			errorMessage: string;
+			errorId?: number;
 	  }
 	| {
 			reason: "auto_retry_end";

package/src/extensibility/extensions/loader.ts

@@ -24,7 +24,7 @@ import { installLegacyPiSpecifierShim, loadLegacyPiModule } from "../plugins/leg
 import { getAllPluginExtensionPaths } from "../plugins/loader";
 import * as TypeBox from "../typebox";
 
-import { resolvePath } from "../utils";
+import { resolvePath, withExitGuard } from "../utils";
 import type {
 	AssistantThinkingRenderer,
 	Extension,
@@ -290,7 +290,7 @@ async function loadExtension(
 ): Promise<{ extension: Extension | null; error: string | null }> {
 	const resolvedPath = resolvePath(extensionPath, cwd);
 	try {
-		const module = (await loadLegacyPiModule(resolvedPath)) as LoadedExtensionModule;
+		const module = (await withExitGuard(() => loadLegacyPiModule(resolvedPath))) as LoadedExtensionModule;
 		const factory = getExtensionFactory(module);
 
 		if (typeof factory !== "function") {
@@ -302,7 +302,9 @@ async function loadExtension(
 
 		const extension = createExtension(extensionPath, resolvedPath);
 		const api = new ConcreteExtensionAPI(PiCodingAgent, extension, runtime, cwd, eventBus);
-		await factory(api);
+		await withExitGuard(async () => {
+			await factory(api);
+		});
 
 		return { extension, error: null };
 	} catch (err) {

package/src/extensibility/extensions/wrapper.ts

@@ -6,7 +6,7 @@ import type { ImageContent, Static, TextContent, TSchema } from "@oh-my-pi/pi-ai
 import type { Settings } from "../../config/settings";
 import type { Theme } from "../../modes/theme/theme";
 import { type ApprovalMode, formatApprovalPrompt, requiresApproval } from "../../tools/approval";
-import { normalizeToolEventInput } from "../tool-event-input";
+import { normalizeToolEventInput, resolveToolEventInput } from "../tool-event-input";
 import { applyToolProxy } from "../tool-proxy";
 import type { ExtensionRunner } from "./runner";
 import type { RegisteredTool, ToolCallEventResult } from "./types";
@@ -186,7 +186,10 @@ export class ExtensionToolWrapper<TParameters extends TSchema = TSchema, TDetail
 					type: "tool_call",
 					toolName: this.tool.name,
 					toolCallId,
-					input: normalizeToolEventInput(this.tool.name, params as Record<string, unknown>),
+					input: normalizeToolEventInput(
+						this.tool.name,
+						resolveToolEventInput(this.tool, params as Record<string, unknown>),
+					),
 				})) as ToolCallEventResult | undefined;
 
 				if (callResult?.block) {
@@ -221,7 +224,10 @@ export class ExtensionToolWrapper<TParameters extends TSchema = TSchema, TDetail
 				type: "tool_result",
 				toolName: this.tool.name,
 				toolCallId,
-				input: normalizeToolEventInput(this.tool.name, params as Record<string, unknown>),
+				input: normalizeToolEventInput(
+					this.tool.name,
+					resolveToolEventInput(this.tool, params as Record<string, unknown>),
+				),
 				content: result.content,
 				details: result.details,
 				isError: !!executionError,

package/src/extensibility/hooks/loader.ts

@@ -12,7 +12,7 @@ import { loadCapability } from "../../discovery";
 import * as PiCodingAgent from "../../index";
 import type { HookMessage } from "../../session/messages";
 import * as typebox from "../typebox";
-import { resolvePath } from "../utils";
+import { resolvePath, withExitGuard } from "../utils";
 import { execCommand } from "./runner";
 import type { ExecOptions, HookAPI, HookFactory, HookMessageRenderer, RegisteredCommand } from "./types";
 
@@ -149,7 +149,7 @@ async function loadHook(hookPath: string, cwd: string): Promise<{ hook: LoadedHo
 
 	try {
 		// Import the module using native Bun import
-		const module = await import(resolvedPath);
+		const module = await withExitGuard(() => import(resolvedPath));
 		const factory = module.default as HookFactory;
 
 		if (typeof factory !== "function") {
@@ -164,7 +164,7 @@ async function loadHook(hookPath: string, cwd: string): Promise<{ hook: LoadedHo
 		);
 
 		// Call factory to register handlers
-		factory(api);
+		await withExitGuard(async () => factory(api));
 
 		return {
 			hook: {

package/src/extensibility/hooks/tool-wrapper.ts

@@ -3,7 +3,7 @@
  */
 import type { AgentTool, AgentToolContext, AgentToolUpdateCallback } from "@oh-my-pi/pi-agent-core";
 import type { Static, TSchema } from "@oh-my-pi/pi-ai";
-import { normalizeToolEventInput } from "../tool-event-input";
+import { normalizeToolEventInput, resolveToolEventInput } from "../tool-event-input";
 import { applyToolProxy } from "../tool-proxy";
 import type { HookRunner } from "./runner";
 import type { ToolCallEventResult, ToolResultEventResult } from "./types";
@@ -47,7 +47,10 @@ export class HookToolWrapper<TParameters extends TSchema = TSchema, TDetails = u
 					type: "tool_call",
 					toolName: this.tool.name,
 					toolCallId,
-					input: normalizeToolEventInput(this.tool.name, params as Record<string, unknown>),
+					input: normalizeToolEventInput(
+						this.tool.name,
+						resolveToolEventInput(this.tool, params as Record<string, unknown>),
+					),
 				})) as ToolCallEventResult | undefined;
 
 				if (callResult?.block) {
@@ -73,7 +76,10 @@ export class HookToolWrapper<TParameters extends TSchema = TSchema, TDetails = u
 					type: "tool_result",
 					toolName: this.tool.name,
 					toolCallId,
-					input: normalizeToolEventInput(this.tool.name, params as Record<string, unknown>),
+					input: normalizeToolEventInput(
+						this.tool.name,
+						resolveToolEventInput(this.tool, params as Record<string, unknown>),
+					),
 					content: result.content,
 					details: result.details,
 					isError: false,
@@ -96,7 +102,10 @@ export class HookToolWrapper<TParameters extends TSchema = TSchema, TDetails = u
 					type: "tool_result",
 					toolName: this.tool.name,
 					toolCallId,
-					input: normalizeToolEventInput(this.tool.name, params as Record<string, unknown>),
+					input: normalizeToolEventInput(
+						this.tool.name,
+						resolveToolEventInput(this.tool, params as Record<string, unknown>),
+					),
 					content: [{ type: "text", text: err instanceof Error ? err.message : String(err) }],
 					details: undefined,
 					isError: true,

package/src/extensibility/plugins/legacy-pi-bundled-keys.ts

@@ -23,6 +23,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-agent-core/compaction/tool-protection",
 	"@oh-my-pi/pi-agent-core/compaction/utils",
 	"@oh-my-pi/pi-ai",
+	"@oh-my-pi/pi-ai/error",
 	"@oh-my-pi/pi-ai/auth-broker",
 	"@oh-my-pi/pi-ai/auth-gateway",
 	"@oh-my-pi/pi-ai/utils/harmony-leak",
@@ -56,6 +57,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-ai/providers/devin",
 	"@oh-my-pi/pi-ai/providers/error-message",
 	"@oh-my-pi/pi-ai/providers/github-copilot-headers",
+	"@oh-my-pi/pi-ai/providers/gitlab-duo-workflow",
 	"@oh-my-pi/pi-ai/providers/gitlab-duo",
 	"@oh-my-pi/pi-ai/providers/google-auth",
 	"@oh-my-pi/pi-ai/providers/google-gemini-cli",
@@ -94,6 +96,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-ai/usage/kimi",
 	"@oh-my-pi/pi-ai/usage/minimax-code",
 	"@oh-my-pi/pi-ai/usage/ollama",
+	"@oh-my-pi/pi-ai/usage/openai-codex-base-url",
 	"@oh-my-pi/pi-ai/usage/openai-codex-reset",
 	"@oh-my-pi/pi-ai/usage/openai-codex",
 	"@oh-my-pi/pi-ai/usage/opencode-go",
@@ -101,6 +104,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-ai/usage/zai",
 	"@oh-my-pi/pi-ai/utils/abort",
 	"@oh-my-pi/pi-ai/utils/anthropic-auth",
+	"@oh-my-pi/pi-ai/utils/block-symbols",
 	"@oh-my-pi/pi-ai/utils/deterministic-id",
 	"@oh-my-pi/pi-ai/utils/empty-completion-retry",
 	"@oh-my-pi/pi-ai/utils/event-stream",
@@ -110,7 +114,6 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-ai/utils/idle-iterator",
 	"@oh-my-pi/pi-ai/utils/openai-http",
 	"@oh-my-pi/pi-ai/utils/openrouter-headers",
-	"@oh-my-pi/pi-ai/utils/overflow",
 	"@oh-my-pi/pi-ai/utils/parse-bind",
 	"@oh-my-pi/pi-ai/utils/provider-response",
 	"@oh-my-pi/pi-ai/utils/proxy",
@@ -128,6 +131,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-ai/oauth/cursor",
 	"@oh-my-pi/pi-ai/oauth/devin",
 	"@oh-my-pi/pi-ai/oauth/github-copilot",
+	"@oh-my-pi/pi-ai/oauth/gitlab-duo-workflow",
 	"@oh-my-pi/pi-ai/oauth/gitlab-duo",
 	"@oh-my-pi/pi-ai/oauth/google-antigravity",
 	"@oh-my-pi/pi-ai/oauth/google-gemini-cli",
@@ -187,6 +191,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/eval",
 	"@oh-my-pi/pi-coding-agent/lsp",
 	"@oh-my-pi/pi-coding-agent/lsp/clients",
+	"@oh-my-pi/pi-coding-agent/markit",
 	"@oh-my-pi/pi-coding-agent/mcp",
 	"@oh-my-pi/pi-coding-agent/mcp/transports",
 	"@oh-my-pi/pi-coding-agent/memories",
@@ -481,6 +486,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/internal-urls/router",
 	"@oh-my-pi/pi-coding-agent/internal-urls/rule-protocol",
 	"@oh-my-pi/pi-coding-agent/internal-urls/skill-protocol",
+	"@oh-my-pi/pi-coding-agent/internal-urls/ssh-protocol",
 	"@oh-my-pi/pi-coding-agent/internal-urls/types",
 	"@oh-my-pi/pi-coding-agent/internal-urls/vault-protocol",
 	"@oh-my-pi/pi-coding-agent/eval/js/context-manager",
@@ -508,6 +514,8 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/lsp/clients/biome-client",
 	"@oh-my-pi/pi-coding-agent/lsp/clients/lsp-linter-client",
 	"@oh-my-pi/pi-coding-agent/lsp/clients/swiftlint-client",
+	"@oh-my-pi/pi-coding-agent/markit/registry",
+	"@oh-my-pi/pi-coding-agent/markit/types",
 	"@oh-my-pi/pi-coding-agent/mcp/client",
 	"@oh-my-pi/pi-coding-agent/mcp/config-writer",
 	"@oh-my-pi/pi-coding-agent/mcp/config",
@@ -554,6 +562,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/modes/orchestrate",
 	"@oh-my-pi/pi-coding-agent/modes/print-mode",
 	"@oh-my-pi/pi-coding-agent/modes/prompt-action-autocomplete",
+	"@oh-my-pi/pi-coding-agent/modes/running-subagent-badge",
 	"@oh-my-pi/pi-coding-agent/modes/runtime-init",
 	"@oh-my-pi/pi-coding-agent/modes/session-observer-registry",
 	"@oh-my-pi/pi-coding-agent/modes/setup-version",
@@ -603,6 +612,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/modes/components/mcp-add-wizard",
 	"@oh-my-pi/pi-coding-agent/modes/components/message-frame",
 	"@oh-my-pi/pi-coding-agent/modes/components/model-selector",
+	"@oh-my-pi/pi-coding-agent/modes/components/move-overlay",
 	"@oh-my-pi/pi-coding-agent/modes/components/oauth-selector",
 	"@oh-my-pi/pi-coding-agent/modes/components/omfg-panel",
 	"@oh-my-pi/pi-coding-agent/modes/components/overlay-box",
@@ -614,6 +624,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/modes/components/read-tool-group",
 	"@oh-my-pi/pi-coding-agent/modes/components/reset-usage-selector",
 	"@oh-my-pi/pi-coding-agent/modes/components/segment-track",
+	"@oh-my-pi/pi-coding-agent/modes/components/select-list-mouse-routing",
 	"@oh-my-pi/pi-coding-agent/modes/components/selector-helpers",
 	"@oh-my-pi/pi-coding-agent/modes/components/session-selector",
 	"@oh-my-pi/pi-coding-agent/modes/components/settings-defs",
@@ -714,12 +725,14 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/session/session-paths",
 	"@oh-my-pi/pi-coding-agent/session/session-persistence",
 	"@oh-my-pi/pi-coding-agent/session/session-storage",
+	"@oh-my-pi/pi-coding-agent/session/settings-stream-fn",
 	"@oh-my-pi/pi-coding-agent/session/shake-types",
 	"@oh-my-pi/pi-coding-agent/session/snapcompact-inline",
 	"@oh-my-pi/pi-coding-agent/session/snapcompact-savings-journal",
 	"@oh-my-pi/pi-coding-agent/session/sql-session-storage",
 	"@oh-my-pi/pi-coding-agent/session/streaming-output",
 	"@oh-my-pi/pi-coding-agent/session/tool-choice-queue",
+	"@oh-my-pi/pi-coding-agent/session/turn-persistence",
 	"@oh-my-pi/pi-coding-agent/session/unexpected-stop-classifier",
 	"@oh-my-pi/pi-coding-agent/session/yield-queue",
 	"@oh-my-pi/pi-coding-agent/slash-commands/acp-builtins",
@@ -729,6 +742,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/slash-commands/types",
 	"@oh-my-pi/pi-coding-agent/ssh/config-writer",
 	"@oh-my-pi/pi-coding-agent/ssh/connection-manager",
+	"@oh-my-pi/pi-coding-agent/ssh/file-transfer",
 	"@oh-my-pi/pi-coding-agent/ssh/ssh-executor",
 	"@oh-my-pi/pi-coding-agent/ssh/sshfs-mount",
 	"@oh-my-pi/pi-coding-agent/ssh/utils",
@@ -838,6 +852,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/tui/types",
 	"@oh-my-pi/pi-coding-agent/tui/utils",
 	"@oh-my-pi/pi-coding-agent/tui/width-aware-text",
+	"@oh-my-pi/pi-coding-agent/utils/active-repo-context",
 	"@oh-my-pi/pi-coding-agent/utils/block-context",
 	"@oh-my-pi/pi-coding-agent/utils/changelog",
 	"@oh-my-pi/pi-coding-agent/utils/clipboard",
@@ -856,9 +871,11 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/utils/ipc",
 	"@oh-my-pi/pi-coding-agent/utils/jj",
 	"@oh-my-pi/pi-coding-agent/utils/lang-from-path",
+	"@oh-my-pi/pi-coding-agent/utils/markit-cache",
 	"@oh-my-pi/pi-coding-agent/utils/markit",
 	"@oh-my-pi/pi-coding-agent/utils/mupdf-wasm-embed",
 	"@oh-my-pi/pi-coding-agent/utils/open",
+	"@oh-my-pi/pi-coding-agent/utils/prompt-path",
 	"@oh-my-pi/pi-coding-agent/utils/qrcode",
 	"@oh-my-pi/pi-coding-agent/utils/session-color",
 	"@oh-my-pi/pi-coding-agent/utils/shell-snapshot",