@oh-my-pi/pi-coding-agent 16.1.23 → 16.2.1

package/dist/types/utils/prompt-path.d.ts

@@ -0,0 +1 @@
+export declare function normalizePromptPath(value: string): string;

package/dist/types/web/search/providers/duckduckgo.d.ts

@@ -0,0 +1,14 @@
+import type { AuthStorage } from "@oh-my-pi/pi-ai";
+import type { SearchResponse } from "../../../web/search/types";
+import type { SearchParams } from "./base";
+import { SearchProvider } from "./base";
+/** Execute DuckDuckGo Instant Answer API search. */
+export declare function searchDuckDuckGo(params: SearchParams): Promise<SearchResponse>;
+/** Search provider for DuckDuckGo Instant Answer API. */
+export declare class DuckDuckGoProvider extends SearchProvider {
+    readonly id = "duckduckgo";
+    readonly label = "DuckDuckGo";
+    isAvailable(_authStorage: AuthStorage): boolean;
+    isExplicitlyAvailable(_authStorage: AuthStorage): boolean;
+    search(params: SearchParams): Promise<SearchResponse>;
+}

package/dist/types/web/search/providers/firecrawl.d.ts

@@ -0,0 +1,28 @@
+/**
+ * Firecrawl Web Search Provider
+ *
+ * Calls Firecrawl's search API and maps web results into the unified
+ * SearchResponse shape used by the web search tool.
+ */
+import { type AuthStorage, type FetchImpl } from "@oh-my-pi/pi-ai";
+import type { SearchResponse } from "../../../web/search/types";
+import type { SearchParams } from "./base";
+import { SearchProvider } from "./base";
+export interface FirecrawlSearchParams {
+    query: string;
+    num_results?: number;
+    recency?: SearchParams["recency"];
+    signal?: AbortSignal;
+    fetch?: FetchImpl;
+}
+/** Resolve Firecrawl API key through the shared auth storage pipeline. */
+export declare function findApiKey(authStorage: AuthStorage, sessionId?: string, signal?: AbortSignal): Promise<string | undefined>;
+/** Execute Firecrawl web search. */
+export declare function searchFirecrawl(params: SearchParams): Promise<SearchResponse>;
+/** Search provider for Firecrawl web search. */
+export declare class FirecrawlProvider extends SearchProvider {
+    readonly id = "firecrawl";
+    readonly label = "Firecrawl";
+    isAvailable(authStorage: AuthStorage): boolean;
+    search(params: SearchParams): Promise<SearchResponse>;
+}

package/dist/types/web/search/providers/tinyfish.d.ts

@@ -0,0 +1,29 @@
+/**
+ * TinyFish Web Search Provider
+ *
+ * Calls TinyFish's search API and maps results into the unified
+ * SearchResponse shape used by the web search tool.
+ */
+import { type AuthStorage, type FetchImpl } from "@oh-my-pi/pi-ai";
+import type { SearchResponse } from "../../../web/search/types";
+import type { SearchParams } from "./base";
+import { SearchProvider } from "./base";
+export interface TinyFishSearchParams {
+    query: string;
+    num_results?: number;
+    recency?: SearchParams["recency"];
+    page?: number;
+    signal?: AbortSignal;
+    fetch?: FetchImpl;
+}
+/** Resolve TinyFish API key through the shared auth storage pipeline. */
+export declare function findApiKey(authStorage: AuthStorage, sessionId?: string, signal?: AbortSignal): Promise<string | undefined>;
+/** Execute TinyFish web search. */
+export declare function searchTinyFish(params: SearchParams): Promise<SearchResponse>;
+/** Search provider for TinyFish web search. */
+export declare class TinyFishProvider extends SearchProvider {
+    readonly id = "tinyfish";
+    readonly label = "TinyFish";
+    isAvailable(authStorage: AuthStorage): boolean;
+    search(params: SearchParams): Promise<SearchResponse>;
+}

package/dist/types/web/search/providers/xai.d.ts

@@ -0,0 +1,13 @@
+import { type AuthStorage } from "@oh-my-pi/pi-ai";
+import type { SearchResponse } from "../../../web/search/types";
+import type { SearchParams } from "./base";
+import { SearchProvider } from "./base";
+/** Execute xAI Responses API web search. */
+export declare function searchXAI(params: SearchParams): Promise<SearchResponse>;
+/** Search provider for xAI web search. */
+export declare class XAIProvider extends SearchProvider {
+    readonly id = "xai";
+    readonly label = "xAI";
+    isAvailable(authStorage: AuthStorage): boolean;
+    search(params: SearchParams): Promise<SearchResponse>;
+}

package/dist/types/web/search/types.d.ts

@@ -23,6 +23,10 @@ export declare const SEARCH_PROVIDER_OPTIONS: readonly [{
     readonly value: "codex";
     readonly label: "OpenAI";
     readonly description: "OpenAI's native web_search (uses ChatGPT OAuth via /login openai-codex)";
+}, {
+    readonly value: "xai";
+    readonly label: "xAI";
+    readonly description: "Grok web search via xAI Responses API (requires XAI_API_KEY)";
 }, {
     readonly value: "zai";
     readonly label: "Z.AI";
@@ -31,6 +35,10 @@ export declare const SEARCH_PROVIDER_OPTIONS: readonly [{
     readonly value: "exa";
     readonly label: "Exa";
     readonly description: "Uses Exa API when EXA_API_KEY is set; falls back to Exa MCP";
+}, {
+    readonly value: "tinyfish";
+    readonly label: "TinyFish";
+    readonly description: "Requires TINYFISH_API_KEY";
 }, {
     readonly value: "jina";
     readonly label: "Jina";
@@ -43,6 +51,10 @@ export declare const SEARCH_PROVIDER_OPTIONS: readonly [{
     readonly value: "tavily";
     readonly label: "Tavily";
     readonly description: "Requires TAVILY_API_KEY";
+}, {
+    readonly value: "firecrawl";
+    readonly label: "Firecrawl";
+    readonly description: "Requires FIRECRAWL_API_KEY";
 }, {
     readonly value: "brave";
     readonly label: "Brave";
@@ -63,6 +75,10 @@ export declare const SEARCH_PROVIDER_OPTIONS: readonly [{
     readonly value: "searxng";
     readonly label: "SearXNG";
     readonly description: "Requires SEARXNG_ENDPOINT or searxng.endpoint";
+}, {
+    readonly value: "duckduckgo";
+    readonly label: "DuckDuckGo";
+    readonly description: "Uses DuckDuckGo Instant Answer API (no API key)";
 }];
 /** Supported web search providers (every option except `auto`). */
 export type SearchProviderId = Exclude<(typeof SEARCH_PROVIDER_OPTIONS)[number]["value"], "auto">;
@@ -88,7 +104,7 @@ export interface SearchSource {
     ageSeconds?: number;
     author?: string;
 }
-/** Citation with text reference (anthropic, perplexity) */
+/** Citation with text reference (LLM-mediated providers) */
 export interface SearchCitation {
     url: string;
     title: string;
@@ -106,7 +122,7 @@ export interface SearchUsage {
 /** Unified response across providers */
 export interface SearchResponse {
     provider: SearchProviderId | "none";
-    /** Synthesized answer text (anthropic, perplexity) */
+    /** Synthesized answer text (LLM-mediated providers) */
     answer?: string;
     /** Search result sources */
     sources: SearchSource[];

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "16.1.23",
+	"version": "16.2.1",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://omp.sh",
 	"author": "Can Boluk",
@@ -39,26 +39,33 @@
 		"fix": "biome check --write --unsafe . && bun run format-prompts",
 		"fmt": "biome format --write . && bun run format-prompts",
 		"format-prompts": "bun scripts/format-prompts.ts",
-		"generate-docs-index": "bun scripts/generate-docs-index.ts --generate",
-		"prepack": "bun scripts/generate-docs-index.ts --generate && bun --cwd=../collab-web run build:tool-views && bun scripts/bundle-dist.ts || ( bun scripts/generate-docs-index.ts --reset; exit 1 )",
-		"postpack": "bun scripts/generate-docs-index.ts --reset",
+		"gen:docs": "bun scripts/generate-docs-index.ts --generate",
+		"gen:docs:reset": "bun scripts/generate-docs-index.ts --reset",
+		"gen:tool-views": "bun --cwd=../collab-web run gen:tool-views",
+		"gen:bundle": "bun scripts/bundle-dist.ts",
+		"gen:mupdf": "bun scripts/embed-mupdf-wasm.ts --generate",
+		"gen:mupdf:reset": "bun scripts/embed-mupdf-wasm.ts --reset",
+		"gen:native": "bun --cwd=../natives run gen:native",
+		"gen:native:reset": "bun --cwd=../natives run gen:native:reset",
+		"prepack": "bun run gen:docs && bun run gen:tool-views && bun run gen:bundle || ( bun run gen:docs:reset; exit 1 )",
+		"postpack": "bun run gen:docs:reset",
 		"bench:guard": "bun scripts/bench-guard.ts"
 	},
 	"dependencies": {
 		"@agentclientprotocol/sdk": "0.25.0",
 		"@babel/parser": "^7.29.7",
 		"@mozilla/readability": "^0.6.0",
-		"@oh-my-pi/hashline": "16.1.23",
-		"@oh-my-pi/omp-stats": "16.1.23",
-		"@oh-my-pi/pi-agent-core": "16.1.23",
-		"@oh-my-pi/pi-ai": "16.1.23",
-		"@oh-my-pi/pi-catalog": "16.1.23",
-		"@oh-my-pi/pi-mnemopi": "16.1.23",
-		"@oh-my-pi/pi-natives": "16.1.23",
-		"@oh-my-pi/pi-tui": "16.1.23",
-		"@oh-my-pi/pi-utils": "16.1.23",
-		"@oh-my-pi/pi-wire": "16.1.23",
-		"@oh-my-pi/snapcompact": "16.1.23",
+		"@oh-my-pi/hashline": "16.2.1",
+		"@oh-my-pi/omp-stats": "16.2.1",
+		"@oh-my-pi/pi-agent-core": "16.2.1",
+		"@oh-my-pi/pi-ai": "16.2.1",
+		"@oh-my-pi/pi-catalog": "16.2.1",
+		"@oh-my-pi/pi-mnemopi": "16.2.1",
+		"@oh-my-pi/pi-natives": "16.2.1",
+		"@oh-my-pi/pi-tui": "16.2.1",
+		"@oh-my-pi/pi-utils": "16.2.1",
+		"@oh-my-pi/pi-wire": "16.2.1",
+		"@oh-my-pi/snapcompact": "16.2.1",
 		"@opentelemetry/api": "^1.9.1",
 		"@opentelemetry/context-async-hooks": "^2.7.1",
 		"@opentelemetry/exporter-trace-otlp-proto": "^0.218.0",
@@ -375,6 +382,14 @@
 			"types": "./dist/types/lsp/clients/*.d.ts",
 			"import": "./src/lsp/clients/*.ts"
 		},
+		"./markit": {
+			"types": "./dist/types/markit/index.d.ts",
+			"import": "./src/markit/index.ts"
+		},
+		"./markit/*": {
+			"types": "./dist/types/markit/*.d.ts",
+			"import": "./src/markit/*.ts"
+		},
 		"./mcp": {
 			"types": "./dist/types/mcp/index.d.ts",
 			"import": "./src/mcp/index.ts"

package/scripts/build-binary.ts

@@ -49,8 +49,8 @@ async function main(): Promise<void> {
 	// Generate inside the try so the finally always restores the empty checked-in
 	// placeholders (stats client archive, docs index) even on failure.
 	try {
-		await runCommand(["bun", "--cwd=../stats", "scripts/generate-client-bundle.ts", "--generate"]);
-		await runCommand(["bun", "scripts/generate-docs-index.ts", "--generate"]);
+		await runCommand(["bun", "--cwd=../stats", "run", "gen:stats"]);
+		await runCommand(["bun", "run", "gen:docs"]);
 		// `legacy-pi-bundled-registry.ts` static-imports
 		// `@oh-my-pi/pi-coding-agent/export/html` (one of pi-coding-agent's
 		// named subpath exports, see scripts/generate-legacy-pi-bundled-registry.ts),
@@ -61,14 +61,14 @@ async function main(): Promise<void> {
 		// resolving the missing generated bundle. Rebuilding the tool views
 		// here makes the compile self-contained and matches what `prepack`
 		// does for the npm bundle.
-		await runCommand(["bun", "--cwd=../collab-web", "run", "build:tool-views"]);
+		await runCommand(["bun", "--cwd=../collab-web", "run", "gen:tool-views"]);
 		await runCommand(
-			["bun", "--cwd=../natives", "run", "embed:native"],
+			["bun", "--cwd=../natives", "run", "gen:native"],
 			crossTarget
 				? { ...Bun.env, TARGET_PLATFORM: crossPlatform as string, TARGET_ARCH: crossArch as string }
 				: Bun.env,
 		);
-		await runCommand(["bun", "scripts/embed-mupdf-wasm.ts", "--generate"]);
+		await runCommand(["bun", "run", "gen:mupdf"]);
 		// Regenerate the bundled-pi registry + key set before the compile so any
 		// new pi-* subpath export added under `packages/*/package.json` is served
 		// from the host's in-process copy. Without this, `bun build --compile`
@@ -123,12 +123,12 @@ async function main(): Promise<void> {
 				await runCommand(["codesign", "--force", "--sign", "-", outputPath]);
 			}
 		} finally {
-			await runCommand(["bun", "scripts/embed-mupdf-wasm.ts", "--reset"]);
-			await runCommand(["bun", "--cwd=../natives", "run", "embed:native", "--reset"]);
+			await runCommand(["bun", "run", "gen:mupdf:reset"]);
+			await runCommand(["bun", "--cwd=../natives", "run", "gen:native:reset"]);
 		}
 	} finally {
-		await runCommand(["bun", "--cwd=../stats", "scripts/generate-client-bundle.ts", "--reset"]);
-		await runCommand(["bun", "scripts/generate-docs-index.ts", "--reset"]);
+		await runCommand(["bun", "--cwd=../stats", "run", "gen:stats:reset"]);
+		await runCommand(["bun", "run", "gen:docs:reset"]);
 	}
 }
 

package/scripts/bundle-dist.ts

@@ -79,7 +79,7 @@ async function main(): Promise<void> {
 	// so embed the dashboard archive the same way compiled binaries do
 	// (scripts/build-binary.ts). Reset afterwards to keep the checked-in
 	// placeholder empty.
-	await runCommand(["bun", "--cwd=../stats", "scripts/generate-client-bundle.ts", "--generate"]);
+	await runCommand(["bun", "--cwd=../stats", "run", "gen:stats"]);
 	try {
 		await runCommand([
 			"bun",
@@ -97,7 +97,7 @@ async function main(): Promise<void> {
 			"./src/cli.ts",
 		]);
 	} finally {
-		await runCommand(["bun", "--cwd=../stats", "scripts/generate-client-bundle.ts", "--reset"]);
+		await runCommand(["bun", "--cwd=../stats", "run", "gen:stats:reset"]);
 	}
 	await ensureShebang();
 	const stat = await fs.stat(cliPath);

package/src/advisor/__tests__/advisor.test.ts

@@ -3,6 +3,7 @@ import type { AgentMessage, AgentTelemetryConfig } from "@oh-my-pi/pi-agent-core
 import { type } from "arktype";
 import { createAdvisorMessageCard } from "../../modes/components/advisor-message";
 import { getThemeByName } from "../../modes/theme/theme";
+import advisorSystemPrompt from "../../prompts/advisor/system.md" with { type: "text" };
 import { SecretObfuscator } from "../../secrets/obfuscator";
 import { formatSessionHistoryMarkdown } from "../../session/session-history-format";
 import { YieldQueue } from "../../session/yield-queue";
@@ -15,12 +16,68 @@ import {
 	type AdvisorRuntimeHost,
 	deriveAdvisorTelemetry,
 	formatAdvisorBatchContent,
+	formatAdvisorContextPrompt,
 	isAdvisorInterruptImmuneTurnActive,
 	isInterruptingSeverity,
 	resolveAdvisorDeliveryChannel,
 } from "..";
 
 describe("advisor", () => {
+	describe("advisor system prompt", () => {
+		it("forbids concrete claims about tool arguments hidden from the advisor transcript", () => {
+			const messages = [
+				{
+					role: "assistant",
+					content: [
+						{
+							type: "toolCall",
+							id: "search-timeout",
+							name: "grep",
+							arguments: { pattern: "needle", paths: ["packages/coding-agent/src"] },
+						},
+					],
+					timestamp: 1,
+				},
+				{
+					role: "toolResult",
+					toolCallId: "search-timeout",
+					toolName: "grep",
+					content: [{ type: "text", text: "timed out after 30s" }],
+					isError: true,
+					timestamp: 2,
+				},
+			] as unknown as AgentMessage[];
+
+			const rendered = formatSessionHistoryMarkdown(messages);
+
+			expect(rendered).toContain("→ grep(needle @ packages/coding-agent/src) ⇒ error");
+			expect(rendered).not.toContain("paths[0]");
+			expect(advisorSystemPrompt).toContain("Arguments absent from the rendered transcript are UNKNOWN");
+			expect(advisorSystemPrompt).toContain("NEVER assert concrete values, array indexes");
+			expect(advisorSystemPrompt).toContain("NEVER claim `paths[0]`, array flattening, or malformed `paths`");
+		});
+	});
+
+	describe("formatAdvisorContextPrompt", () => {
+		it("renders project context files into a block with path and verbatim content", () => {
+			const rendered = formatAdvisorContextPrompt([
+				{
+					path: "/repo/AGENTS.md",
+					content: "Use `bun check`, never `tsc`.\nNo `any` unless absolutely necessary.",
+				},
+			]);
+			expect(rendered).toBeDefined();
+			expect(rendered).toContain('<file path="/repo/AGENTS.md">');
+			// Content is injected verbatim (noEscape) so backticks/markup survive for the model.
+			expect(rendered).toContain("Use `bun check`, never `tsc`.");
+			expect(rendered).toContain("No `any` unless absolutely necessary.");
+		});
+
+		it("returns undefined when there are no context files", () => {
+			expect(formatAdvisorContextPrompt([])).toBeUndefined();
+		});
+	});
+
 	describe("formatSessionHistoryMarkdown includeThinking", () => {
 		it("includes thinking text when includeThinking is true", () => {
 			const thinking = "I should check the edge case first.";
@@ -675,13 +732,13 @@ describe("advisor", () => {
 				} as AgentMessage,
 				{
 					role: "assistant",
-					content: [{ type: "toolCall", id: "b", name: "search", arguments: { pattern: "y" } }],
+					content: [{ type: "toolCall", id: "b", name: "grep", arguments: { pattern: "y" } }],
 					timestamp: 4,
 				} as unknown as AgentMessage,
 				{
 					role: "toolResult",
 					toolCallId: "b",
-					toolName: "search",
+					toolName: "grep",
 					content: [{ type: "text", text: "ok" }],
 					isError: false,
 					timestamp: 5,
@@ -1008,9 +1065,9 @@ describe("advisor", () => {
 
 	describe("read-only tool allowlist", () => {
 		it("selects only the investigation tools from a mixed toolset", () => {
-			const toolset = ["read", "edit", "search", "bash", "find", "write", "advise"];
+			const toolset = ["read", "edit", "grep", "bash", "glob", "write", "advise"];
 			const selected = toolset.filter(name => ADVISOR_READONLY_TOOL_NAMES.has(name));
-			expect(selected).toEqual(["read", "search", "find"]);
+			expect(selected).toEqual(["read", "grep", "glob"]);
 			expect(ADVISOR_READONLY_TOOL_NAMES.has("edit")).toBe(false);
 			expect(ADVISOR_READONLY_TOOL_NAMES.has("bash")).toBe(false);
 			expect(ADVISOR_READONLY_TOOL_NAMES.has("write")).toBe(false);

package/src/advisor/__tests__/emission-guard.test.ts

@@ -0,0 +1,147 @@
+import { describe, expect, it } from "bun:test";
+import { AdvisorEmissionGuard, normalizeAdvisorNote } from "../emission-guard";
+
+describe("normalizeAdvisorNote", () => {
+	it("collapses punctuation, casing, and surrounding whitespace into one canonical key", () => {
+		// The reporter's three top duplicates all key to the same canonical form
+		// regardless of trailing punctuation or casing — that's what makes the
+		// dedupe + suppression checks single-membership.
+		expect(normalizeAdvisorNote("Stop.")).toBe("stop");
+		expect(normalizeAdvisorNote("  STOP!  ")).toBe("stop");
+		expect(normalizeAdvisorNote("*Stop*")).toBe("stop");
+		expect(normalizeAdvisorNote("Done.")).toBe("done");
+		expect(normalizeAdvisorNote("No issue; continue.")).toBe("no issue continue");
+	});
+
+	it("returns empty string for whitespace-only input so callers can short-circuit", () => {
+		expect(normalizeAdvisorNote("")).toBe("");
+		expect(normalizeAdvisorNote("   ")).toBe("");
+		expect(normalizeAdvisorNote("...")).toBe("");
+	});
+
+	it("preserves internal letters/digits but folds non-alphanumeric runs to one space", () => {
+		expect(normalizeAdvisorNote("Refactor `auth-flow.ts`: drop legacy branch.")).toBe(
+			"refactor auth flow ts drop legacy branch",
+		);
+	});
+});
+
+describe("AdvisorEmissionGuard", () => {
+	it("drops the exact content-free filler the reporter observed flooding the chat", () => {
+		// Issue #3520: 114× "Stop.", 52× "No issue; continue.", 41× "Done." —
+		// none of these carry a concrete reason and they cannot be acted on, so
+		// the guard suppresses them regardless of severity.
+		const guard = new AdvisorEmissionGuard();
+		expect(guard.accept("Stop.")).toBe(false);
+		expect(guard.accept("Done.")).toBe(false);
+		expect(guard.accept("No issue; continue.")).toBe(false);
+		expect(guard.accept("LGTM")).toBe(false);
+		expect(guard.accept("No further watcher input needed.")).toBe(false);
+	});
+
+	it("dedupes by normalized text across the session, ignoring casing and trailing punctuation", () => {
+		const guard = new AdvisorEmissionGuard();
+		expect(guard.accept("Move retries into the queue, not the request path.")).toBe(true);
+		// Same advice with different casing and trailing punctuation must NOT
+		// land twice in the primary transcript.
+		expect(guard.accept("move retries into the queue, not the request path")).toBe(false);
+		expect(guard.accept("Move retries into the queue, not the request path!")).toBe(false);
+	});
+
+	it("rate-limits to one accepted advise per advisor update cycle", () => {
+		// The advisor system prompt says "at most one `advise` per update". Real
+		// models violate this; the guard enforces it at the boundary so the
+		// primary transcript never receives two advisories from one model cycle.
+		const guard = new AdvisorEmissionGuard();
+		expect(guard.accept("First concern: missing await in #handleRetry.")).toBe(true);
+		expect(guard.accept("Second concern: wrong env var name.")).toBe(false);
+		guard.beginUpdate();
+		// New cycle: budget reset.
+		expect(guard.accept("Second concern: wrong env var name.")).toBe(true);
+	});
+
+	it("does not let a suppressed call consume the per-update budget", () => {
+		// A noise call like "Stop." must never displace a real concern that
+		// follows in the same advisor model cycle.
+		const guard = new AdvisorEmissionGuard();
+		expect(guard.accept("Stop.")).toBe(false);
+		expect(guard.accept("Concrete: read race in #handleRetry.")).toBe(true);
+	});
+
+	it("does not let a deduped call consume the per-update budget", () => {
+		// A repeat of a prior session note is dropped, but the model can still
+		// follow it with a fresh concrete concern in the same cycle.
+		const guard = new AdvisorEmissionGuard();
+		expect(guard.accept("Concrete: read race in #handleRetry.")).toBe(true);
+		guard.beginUpdate();
+		expect(guard.accept("Concrete: read race in #handleRetry.")).toBe(false);
+		expect(guard.accept("New concern: cache eviction never fires.")).toBe(true);
+	});
+
+	it("reset clears dedupe and the per-update gate so a re-primed advisor can re-raise old issues", () => {
+		// Compaction / session-switch rewrites the primary transcript. The
+		// advisor is re-primed from scratch and may legitimately re-raise the
+		// same concerns — they're new context for a freshly-primed reviewer.
+		const guard = new AdvisorEmissionGuard();
+		expect(guard.accept("Race in #handleRetry.")).toBe(true);
+		expect(guard.accept("Race in #handleRetry.")).toBe(false);
+		guard.reset();
+		expect(guard.accept("Race in #handleRetry.")).toBe(true);
+	});
+
+	it("evicts oldest entries when dedupe history exceeds capacity", () => {
+		// Bounded so very long sessions cannot grow the dedupe state without
+		// bound. Pre-eviction unique notes are remembered; post-eviction the
+		// oldest one is forgotten and can resurface.
+		const guard = new AdvisorEmissionGuard({ capacity: 3 });
+		expect(guard.accept("first")).toBe(true);
+		guard.beginUpdate();
+		expect(guard.accept("second")).toBe(true);
+		guard.beginUpdate();
+		expect(guard.accept("third")).toBe(true);
+		guard.beginUpdate();
+		// "first" still in history.
+		expect(guard.accept("first")).toBe(false);
+		guard.beginUpdate();
+		// Fourth unique entry evicts "first".
+		expect(guard.accept("fourth")).toBe(true);
+		guard.beginUpdate();
+		expect(guard.accept("first")).toBe(true);
+	});
+
+	it("rejects empty / whitespace-only notes without consuming the budget", () => {
+		const guard = new AdvisorEmissionGuard();
+		expect(guard.accept("")).toBe(false);
+		expect(guard.accept("   ")).toBe(false);
+		expect(guard.accept("Concrete advice.")).toBe(true);
+	});
+
+	it("end-to-end: the reporter's 309-call spam log produces ≤1 accepted note across many updates", () => {
+		// Mimic the issue's distribution: 114× "Stop.", 52× "No issue; continue.",
+		// 41× "Done.", plus 102 copies of one concrete-but-repeated nit. Spread
+		// the calls across 50 advisor update cycles. Each cycle is allowed at
+		// most one accepted note, and identical-text repeats never escape the
+		// guard. After all calls, exactly the concrete nit has been accepted
+		// — and only once.
+		const guard = new AdvisorEmissionGuard();
+		const accepted: string[] = [];
+		const stream: string[] = [
+			...Array(114).fill("Stop."),
+			...Array(52).fill("No issue; continue."),
+			...Array(41).fill("Done."),
+			...Array(102).fill("Concrete-but-repeated nit: x"),
+		];
+		// Interleave across 50 update cycles.
+		const cycles = 50;
+		const perCycle = Math.ceil(stream.length / cycles);
+		for (let c = 0; c < cycles; c++) {
+			guard.beginUpdate();
+			for (let i = 0; i < perCycle; i++) {
+				const note = stream[c * perCycle + i];
+				if (note === undefined) break;
+				if (guard.accept(note)) accepted.push(note);
+			}
+		}
+		expect(accepted).toEqual(["Concrete-but-repeated nit: x"]);
+	});
+});

package/src/advisor/advise-tool.ts

@@ -137,7 +137,7 @@ export function deriveAdvisorTelemetry(
  * inspect the workspace before weighing in. Names match the primary session's
  * tool instances, which the advisor reuses.
  */
-export const ADVISOR_READONLY_TOOL_NAMES: ReadonlySet<string> = new Set(["read", "search", "find"]);
+export const ADVISOR_READONLY_TOOL_NAMES: ReadonlySet<string> = new Set(["read", "grep", "glob"]);
 
 function advisorNoteDedupeKey(note: string): string {
 	return note.trim().replace(/\s+/g, " ");