@oh-my-pi/pi-coding-agent 16.1.22 → 16.2.0

package/src/cli/gallery-cli.ts

@@ -138,14 +138,26 @@ export async function renderGalleryState(
 		return await fixture.renderState(state, width, expanded);
 	}
 
-	const tool = fakeToolFor(name, fixture);
+	// A non-customRendered fixture may borrow another tool's built-in renderer
+	// (e.g. `edit_delete` → `edit`): drive the component under that real tool
+	// name so the sample exercises the exact production branch, not the
+	// custom-tool one (which tints/pads non-framed result rows).
+	const componentName = fixture.customRendered ? name : (fixture.renderer ?? name);
+	const tool = fakeToolFor(componentName, fixture);
 	const streamingArgs = state === "streaming" ? (fixture.streamingArgs ?? fixture.args) : fixture.args;
 	// The component only calls `requestRender`/`requestComponentRender` (via
 	// its loader) during a static render; `imageBudget` is consulted solely
 	// when images render, which the gallery disables. A cast avoids
 	// constructing a real terminal.
 	const ui = { requestRender() {}, requestComponentRender() {} } as unknown as TUI;
-	const component = new ToolExecutionComponent(name, streamingArgs, { showImages: false }, tool, ui, getProjectDir());
+	const component = new ToolExecutionComponent(
+		componentName,
+		streamingArgs,
+		{ showImages: false },
+		tool,
+		ui,
+		getProjectDir(),
+	);
 	component.setExpanded(expanded);
 
 	if (state !== "streaming") {

package/src/cli/gallery-fixtures/edit.ts

@@ -62,6 +62,66 @@ export const editFixtures: Record<string, GalleryFixture> = {
 		},
 	},
 
+	edit_delete: {
+		label: "Delete",
+		// The registry has no `edit_delete` key, so `renderer: "edit"` routes this
+		// fixture through the real built-in edit renderer (see the harness in
+		// `gallery-cli`), keeping the sample identical to a production delete.
+		renderer: "edit",
+		streamingArgs: { file_path: "scripts/prune-changelogs.ts", op: "delete" },
+		args: { file_path: "scripts/prune-changelogs.ts", op: "delete" },
+		result: {
+			content: [{ type: "text", text: "Deleted scripts/prune-changelogs.ts" }],
+			details: {
+				op: "delete",
+				path: "scripts/prune-changelogs.ts",
+				diff: "",
+				oldText: "#!/usr/bin/env bun\n// obsolete changelog pruning helper\n",
+			},
+		},
+		errorResult: {
+			content: [{ type: "text", text: "Edit failed: scripts/prune-changelogs.ts not found" }],
+			isError: true,
+			details: {
+				op: "delete",
+				path: "scripts/prune-changelogs.ts",
+				diff: "",
+				errorText: "Cannot delete scripts/prune-changelogs.ts: the file does not exist.",
+			},
+		},
+	},
+
+	edit_move: {
+		label: "Move",
+		renderer: "edit",
+		streamingArgs: { file_path: "scripts/prune-changelogs.ts", rename: "scripts/archived/prune-changelogs.ts" },
+		args: { file_path: "scripts/prune-changelogs.ts", rename: "scripts/archived/prune-changelogs.ts" },
+		result: {
+			content: [{ type: "text", text: "Moved scripts/prune-changelogs.ts to scripts/archived/prune-changelogs.ts" }],
+			details: {
+				op: "update",
+				path: "scripts/archived/prune-changelogs.ts",
+				move: "scripts/archived/prune-changelogs.ts",
+				sourcePath: "scripts/prune-changelogs.ts",
+				diff: "",
+			},
+		},
+		errorResult: {
+			content: [
+				{ type: "text", text: "Edit failed: destination scripts/archived/prune-changelogs.ts already exists" },
+			],
+			isError: true,
+			details: {
+				op: "update",
+				path: "scripts/archived/prune-changelogs.ts",
+				move: "scripts/archived/prune-changelogs.ts",
+				sourcePath: "scripts/prune-changelogs.ts",
+				diff: "",
+				errorText: "MV destination scripts/archived/prune-changelogs.ts already exists.",
+			},
+		},
+	},
+
 	apply_patch: {
 		label: "Apply Patch",
 		editMode: "apply_patch",

package/src/cli/gallery-fixtures/fs.ts

@@ -1,17 +1,17 @@
 // biome-ignore-all lint/suspicious/noTemplateCurlyInString: sample source-code strings (read fixtures) intentionally contain literal ${...}.
-// Gallery fixtures for the filesystem tools (read, write, find).
+// Gallery fixtures for the filesystem tools (read, write, glob).
 import { ReadToolGroupComponent } from "../../modes/components/read-tool-group";
 import type { GalleryFixture, GalleryFixtureState, GalleryResult } from "./types";
 
 const readSnippet = [
-	"export const findToolRenderer = {",
+	"export const globToolRenderer = {",
 	"\tinline: true,",
-	"\trenderCall(args: FindRenderArgs, _options: RenderResultOptions, uiTheme: Theme): Component {",
+	"\trenderCall(args: GlobRenderArgs, _options: RenderResultOptions, uiTheme: Theme): Component {",
 	"\t\tconst meta: string[] = [];",
 	"\t\tif (args.limit !== undefined) meta.push(`limit:${args.limit}`);",
 	"",
 	"\t\tconst text = renderStatusLine(",
-	'\t\t\t{ icon: "pending", title: "Find", description: formatFindRenderPaths(args.paths) || "*", meta },',
+	'\t\t\t{ icon: "pending", title: "Glob", description: formatGlobRenderPaths(args.paths) || "*", meta },',
 	"\t\t\tuiTheme,",
 	"\t\t);",
 	"\t\treturn new Text(text, 0, 0);",
@@ -99,22 +99,22 @@ export const fsFixtures: Record<string, GalleryFixture> = {
 	read: {
 		label: "Read",
 		// Streaming: path still being typed, selector not yet appended.
-		streamingArgs: { path: "packages/coding-agent/src/tools/find" },
-		args: { path: "packages/coding-agent/src/tools/find.ts:437-448" },
+		streamingArgs: { path: "packages/coding-agent/src/tools/glob" },
+		args: { path: "packages/coding-agent/src/tools/glob.ts:437-448" },
 		result: {
 			content: [
 				{
 					type: "text",
 					text: [
-						"[packages/coding-agent/src/tools/find.ts#E48E]",
-						"437:export const findToolRenderer = {",
+						"[packages/coding-agent/src/tools/glob.ts#E48E]",
+						"437:export const globToolRenderer = {",
 						"438:\tinline: true,",
-						"439:\trenderCall(args: FindRenderArgs, _options: RenderResultOptions, uiTheme: Theme): Component {",
+						"439:\trenderCall(args: GlobRenderArgs, _options: RenderResultOptions, uiTheme: Theme): Component {",
 						"440:\t\tconst meta: string[] = [];",
 						"441:\t\tif (args.limit !== undefined) meta.push(`limit:${args.limit}`);",
 						"442:",
 						"443:\t\tconst text = renderStatusLine(",
-						'444:\t\t\t{ icon: "pending", title: "Find", description: formatFindRenderPaths(args.paths) || "*", meta },',
+						'444:\t\t\t{ icon: "pending", title: "Glob", description: formatGlobRenderPaths(args.paths) || "*", meta },',
 						"445:\t\t\tuiTheme,",
 						"446:\t\t);",
 						"447:\t\treturn new Text(text, 0, 0);",
@@ -124,7 +124,7 @@ export const fsFixtures: Record<string, GalleryFixture> = {
 			],
 			details: {
 				kind: "file",
-				resolvedPath: "/Users/dev/Projects/pi/packages/coding-agent/src/tools/find.ts",
+				resolvedPath: "/Users/dev/Projects/pi/packages/coding-agent/src/tools/glob.ts",
 				contentType: "text/typescript",
 				displayContent: { text: readSnippet, startLine: 437 },
 			},
@@ -134,7 +134,7 @@ export const fsFixtures: Record<string, GalleryFixture> = {
 			content: [
 				{
 					type: "text",
-					text: "Error: ENOENT: no such file or directory, open 'packages/coding-agent/src/tools/find.ts'",
+					text: "Error: ENOENT: no such file or directory, open 'packages/coding-agent/src/tools/glob.ts'",
 				},
 			],
 		},
@@ -179,8 +179,8 @@ export const fsFixtures: Record<string, GalleryFixture> = {
 		},
 	},
 
-	find: {
-		label: "Find",
+	glob: {
+		label: "Glob",
 		// Streaming: glob half-typed, no limit yet.
 		streamingArgs: { paths: ["packages/coding-agent/src/tools/*-render"] },
 		args: { paths: ["packages/coding-agent/src/**/*.test.ts"], limit: 50 },
@@ -191,7 +191,7 @@ export const fsFixtures: Record<string, GalleryFixture> = {
 					text: [
 						"packages/coding-agent/src/tools/read.test.ts",
 						"packages/coding-agent/src/tools/write.test.ts",
-						"packages/coding-agent/src/tools/find.test.ts",
+						"packages/coding-agent/src/tools/glob.test.ts",
 						"packages/coding-agent/src/cli/gallery-cli.test.ts",
 						"packages/coding-agent/src/edit/edit.test.ts",
 					].join("\n"),
@@ -205,7 +205,7 @@ export const fsFixtures: Record<string, GalleryFixture> = {
 				files: [
 					"packages/coding-agent/src/cli/gallery-cli.test.ts",
 					"packages/coding-agent/src/edit/edit.test.ts",
-					"packages/coding-agent/src/tools/find.test.ts",
+					"packages/coding-agent/src/tools/glob.test.ts",
 					"packages/coding-agent/src/tools/read.test.ts",
 					"packages/coding-agent/src/tools/write.test.ts",
 				],
@@ -213,7 +213,7 @@ export const fsFixtures: Record<string, GalleryFixture> = {
 		},
 		errorResult: {
 			isError: true,
-			content: [{ type: "text", text: "Find failed: invalid glob pattern '[unclosed'." }],
+			content: [{ type: "text", text: "Glob failed: invalid glob pattern '[unclosed'." }],
 			details: { error: "invalid glob pattern '[unclosed'" },
 		},
 	},

package/src/cli/gallery-fixtures/search.ts

@@ -1,9 +1,9 @@
-/** Gallery fixtures for the search tools (search, search_tool_bm25, ast_grep). */
+/** Gallery fixtures for the search tools (grep, search_tool_bm25, ast_grep). */
 import type { GalleryFixture } from "./types";
 
 export const searchFixtures: Record<string, GalleryFixture> = {
-	search: {
-		label: "Search",
+	grep: {
+		label: "Grep",
 		streamingArgs: {
 			pattern: "useState",
 		},
@@ -101,7 +101,7 @@ export const searchFixtures: Record<string, GalleryFixture> = {
 				limit: 5,
 				total_tools: 142,
 				activated_tools: ["docling_extract_tables", "docling_convert", "pdf_read_text"],
-				active_selected_tools: ["read", "search", "edit", "bash"],
+				active_selected_tools: ["read", "grep", "edit", "bash"],
 				tools: [
 					{
 						name: "docling_extract_tables",