@oh-my-pi/pi-coding-agent 16.1.22 → 16.1.23

package/src/cli-commands.ts

@@ -23,6 +23,7 @@ export const commands: CommandEntry[] = [
 	{ name: "__complete", load: () => import("./commands/complete").then(m => m.default) },
 	{ name: "config", load: () => import("./commands/config").then(m => m.default) },
 	{ name: "dry-balance", load: () => import("./commands/dry-balance").then(m => m.default) },
+	{ name: "gc", load: () => import("./commands/gc").then(m => m.default) },
 	{ name: "grep", load: () => import("./commands/grep").then(m => m.default) },
 	{ name: "gallery", load: () => import("./commands/gallery").then(m => m.default) },
 	{ name: "grievances", load: () => import("./commands/grievances").then(m => m.default) },

package/src/commands/gc.ts

@@ -0,0 +1,46 @@
+/**
+ * Run on-disk storage maintenance.
+ */
+import { Command, Flags } from "@oh-my-pi/pi-utils/cli";
+import { collectGcErrors, type GcCommandArgs, runGcCommand } from "../cli/gc-cli";
+
+export default class Gc extends Command {
+	static description = "Run storage garbage collection";
+
+	static flags = {
+		apply: Flags.boolean({ description: "Apply changes (default is dry-run)" }),
+		json: Flags.boolean({ description: "Output JSON" }),
+		"agent-dir": Flags.string({ description: "Agent directory to maintain" }),
+		blobs: Flags.boolean({ description: "Sweep unreferenced blobs" }),
+		archive: Flags.boolean({ description: "Archive cold sessions" }),
+		wal: Flags.boolean({ description: "Checkpoint history/model database WAL files" }),
+		"cold-archive-after-days": Flags.integer({ description: "Minimum session age before archiving" }),
+		"retain-newest-global": Flags.integer({ description: "Always keep this many newest sessions active" }),
+		"retain-newest-per-cwd": Flags.integer({ description: "Always keep this many newest sessions per cwd active" }),
+	};
+
+	async run(): Promise<void> {
+		const { flags } = await this.parse(Gc);
+		const cmd: GcCommandArgs = {
+			flags: {
+				apply: flags.apply,
+				json: flags.json,
+				agentDir: flags["agent-dir"],
+				blobs: flags.blobs,
+				archive: flags.archive,
+				wal: flags.wal,
+				coldArchiveAfterDays: flags["cold-archive-after-days"],
+				retainNewestGlobal: flags["retain-newest-global"],
+				retainNewestPerCwd: flags["retain-newest-per-cwd"],
+			},
+		};
+		const result = await runGcCommand(cmd);
+		const errors = collectGcErrors(result);
+		if (errors.length > 0) {
+			process.stderr.write(
+				`GC completed with ${errors.length} error${errors.length === 1 ? "" : "s"}:\n${errors.map(error => `- ${error}`).join("\n")}\n`,
+			);
+			process.exitCode = 1;
+		}
+	}
+}

package/src/config/settings-schema.ts

@@ -790,6 +790,17 @@ export const SETTINGS_SCHEMA = {
 		},
 	},
 
+	"tui.renderMermaid": {
+		type: "boolean",
+		default: true,
+		ui: {
+			tab: "appearance",
+			group: "Display",
+			label: "Render Mermaid Diagrams",
+			description: "Render Mermaid fenced code blocks as ASCII diagrams",
+		},
+	},
+
 	"tui.hyperlinks": {
 		type: "enum",
 		values: ["off", "auto", "always"] as const,
@@ -1700,6 +1711,17 @@ export const SETTINGS_SCHEMA = {
 		},
 	},
 
+	"compaction.midTurnEnabled": {
+		type: "boolean",
+		default: true,
+		ui: {
+			tab: "context",
+			group: "Compaction",
+			label: "Mid-Turn Compaction",
+			description: "Check thresholds at safe mid-turn tool-loop boundaries before the next provider request",
+		},
+	},
+
 	"compaction.strategy": {
 		type: "enum",
 		values: ["context-full", "handoff", "shake", "snapcompact", "off"] as const,
@@ -4630,6 +4652,18 @@ export const SETTINGS_SCHEMA = {
 		default: "unset" as const,
 	},
 
+	"gc.blobs": { type: "boolean", default: true },
+
+	"gc.archive": { type: "boolean", default: true },
+
+	"gc.wal": { type: "boolean", default: true },
+
+	"gc.coldArchiveAfterDays": { type: "number", default: 30 },
+
+	"gc.retainNewestGlobal": { type: "number", default: 20 },
+
+	"gc.retainNewestPerCwd": { type: "number", default: 10 },
+
 	"thinkingBudgets.minimal": { type: "number", default: 1024 },
 
 	"thinkingBudgets.low": { type: "number", default: 2048 },
@@ -4731,6 +4765,7 @@ export interface CompactionSettings {
 	thresholdTokens: number;
 	reserveTokens: number;
 	keepRecentTokens: number;
+	midTurnEnabled: boolean;
 	handoffSaveToDisk: boolean;
 	autoContinue: boolean;
 	remoteEnabled: boolean;
@@ -4875,6 +4910,15 @@ export interface CodexResetsSettings {
 	keepCredits: number;
 }
 
+export interface GcSettings {
+	blobs: boolean;
+	archive: boolean;
+	wal: boolean;
+	coldArchiveAfterDays: number;
+	retainNewestGlobal: number;
+	retainNewestPerCwd: number;
+}
+
 /** Map group prefix -> typed settings interface */
 export interface GroupTypeMap {
 	compaction: CompactionSettings;
@@ -4894,6 +4938,7 @@ export interface GroupTypeMap {
 	cycleOrder: string[];
 	shellMinimizer: ShellMinimizerSettings;
 	codexResets: CodexResetsSettings;
+	gc: GcSettings;
 }
 
 export type GroupPrefix = keyof GroupTypeMap;

package/src/config/settings.ts

@@ -61,6 +61,8 @@ export interface SettingsOptions {
 	agentDir?: string;
 	/** Don't persist to disk (for tests) */
 	inMemory?: boolean;
+	/** Read config sources without opening storage or writing migrations */
+	readOnly?: boolean;
 	/** Initial overrides */
 	overrides?: Partial<Record<SettingPath, unknown>>;
 	/** Extra config.yml-style overlays loaded after global/project settings */
@@ -136,11 +138,17 @@ function stringArrayFromUnknown(value: unknown): string[] {
 	return [];
 }
 
+function isRecord(value: unknown): value is Record<string, unknown> {
+	return !!value && typeof value === "object" && !Array.isArray(value);
+}
+
 function shallowStringRecord(value: unknown): Record<string, string> {
-	if (!value || typeof value !== "object" || Array.isArray(value)) return {};
+	if (!isRecord(value)) return {};
 
 	const result: Record<string, string> = {};
-	for (const [key, item] of Object.entries(value)) {
+	for (const key in value) {
+		if (!Object.hasOwn(value, key)) continue;
+		const item = value[key];
 		if (typeof item === "string") {
 			result[key] = item;
 		}
@@ -228,7 +236,7 @@ export class Settings {
 		this.#agentDir = path.normalize(options.agentDir ?? getAgentDir());
 		this.#configPath = options.inMemory ? null : path.join(this.#agentDir, "config.yml");
 		this.#configFiles = options.configFiles?.map(file => path.resolve(this.#cwd, expandTilde(file))) ?? [];
-		this.#persist = !options.inMemory;
+		this.#persist = !options.inMemory && options.readOnly !== true;
 
 		if (options.overrides) {
 			for (const [key, value] of Object.entries(options.overrides)) {
@@ -270,6 +278,23 @@ export class Settings {
 		);
 	}
 
+	/**
+	 * Load effective settings from config.yml and project providers without
+	 * opening agent.db, migrating legacy settings, or writing marker files.
+	 */
+	static loadReadOnly(options: SettingsOptions = {}): Promise<Settings> {
+		const instance = new Settings({ ...options, readOnly: true });
+		return instance.#loadReadOnly();
+	}
+
+	/**
+	 * Load a persisted settings instance without touching the global singleton.
+	 */
+	static loadIsolated(options: SettingsOptions = {}): Promise<Settings> {
+		const instance = new Settings(options);
+		return instance.#load();
+	}
+
 	/**
 	 * Create an isolated instance for testing.
 	 * Does not affect the global singleton.
@@ -481,10 +506,10 @@ export class Settings {
 	 */
 	getEditVariantForModel(model: string | undefined): EditMode | null {
 		if (!model) return null;
-		const variants = (this.#merged.edit as { modelVariants?: Record<string, string> })?.modelVariants;
-		if (!variants) return null;
+		const variants = shallowStringRecord(getByPath(this.#merged, ["edit", "modelVariants"]));
+		const modelLower = model.toLowerCase();
 		for (const pattern in variants) {
-			if (model.includes(pattern)) {
+			if (modelLower.includes(pattern.toLowerCase())) {
 				const value = normalizeEditMode(variants[pattern]);
 				if (value) {
 					return value;
@@ -583,6 +608,19 @@ export class Settings {
 		return this;
 	}
 
+	async #loadReadOnly(): Promise<Settings> {
+		const projectPromise = this.#loadProjectSettings();
+
+		if (this.#configPath) {
+			this.#global = await this.#loadYaml(this.#configPath);
+		}
+
+		this.#project = await projectPromise;
+		this.#configOverlay = await this.#loadConfigOverlays();
+		this.#rebuildMerged();
+		return this;
+	}
+
 	async #loadYaml(filePath: string): Promise<RawSettings> {
 		try {
 			const content = await Bun.file(filePath).text();

package/src/edit/hashline/filesystem.ts

@@ -25,7 +25,7 @@ import { routeWriteThroughBridge } from "../../tools/acp-bridge";
 import { assertEditableFileContent } from "../../tools/auto-generated-guard";
 import { invalidateFsScanAfterWrite } from "../../tools/fs-cache-invalidation";
 import { isInternalUrlPath } from "../../tools/path-utils";
-import { enforcePlanModeWrite, resolvePlanPath } from "../../tools/plan-mode-guard";
+import { enforcePlanModeWrite, resolvePlanPath, targetsLocalSandbox } from "../../tools/plan-mode-guard";
 import { canonicalSnapshotKey } from "../file-snapshot-store";
 import { readEditFileText, serializeEditFileText } from "../read-file";
 import type { LspBatchRequest } from "../renderer";
@@ -92,12 +92,17 @@ export class HashlineFilesystem extends Filesystem {
 		// Internal-URL authored targets (`local://`, `vault://`, …) are approved
 		// at the lower "read" privilege; never let one redirect onto a "write".
 		if (isInternalUrlPath(authoredPath)) return false;
-		// Recovery only fixes a mistyped working-tree path: confine the resolved
-		// target to the working tree (realpath-normalized). A plain-path "write"
-		// approval must not redirect into the artifact sandbox, the secret vault,
-		// or any out-of-tree file the user never named.
+		// Recovery rebinds a bare/mis-typed authored path onto the file its
+		// snapshot tag uniquely names. Confine the redirect to locations a plain
+		// "write" may legitimately target:
+		//  1. the working tree (the model dropped the directory), or
+		//  2. the session `local://` sandbox where plan/scratch artifacts live —
+		//     the snapshot tag proves the model wrote/read that exact file this
+		//     session, so a bare `plan.md#tag` should land on `local://plan.md`.
+		// The secret vault and any other out-of-tree path stay refused.
 		const root = canonicalSnapshotKey(this.session.cwd);
-		return resolvedPath === root || resolvedPath.startsWith(`${root}${path.sep}`);
+		if (resolvedPath === root || resolvedPath.startsWith(`${root}${path.sep}`)) return true;
+		return targetsLocalSandbox(this.session, resolvedPath);
 	}
 
 	async readText(relativePath: string): Promise<string> {

package/src/eval/__tests__/julia-prelude.test.ts

@@ -45,4 +45,22 @@ nothing
 		expect(result.output).toContain("META=alpha:true");
 		expect(result.output).toContain("MULTI=2:alpha:json");
 	}, 30_000);
+
+	it("surfaces the exception type and message in the error output, not just stack frames", async () => {
+		using tempDir = TempDir.createSync("@omp-eval-julia-error-");
+		const result = await executeJulia(`println("="^8)\nmissing_var_xyz + 1`, {
+			cwd: tempDir.path(),
+			sessionId: `julia-prelude-error:${crypto.randomUUID()}`,
+			kernelOwnerId: OWNER_ID,
+			reset: true,
+		});
+
+		// The rendered error must carry the actual exception, not only the
+		// runner-internal backtrace frames (regression: traceback-only output
+		// hid `ename`/`evalue`).
+		expect(result.output).toContain("UndefVarError");
+		expect(result.output).toContain("missing_var_xyz");
+		// Frames are still present alongside the message.
+		expect(result.output).toContain("top-level scope");
+	}, 30_000);
 });

package/src/eval/jl/runner.jl

@@ -522,7 +522,13 @@ function emit_error(rid, err, bt)
     end
     err_str = String(take!(io))
     
-    tb = String[]
+    # Seed the traceback with the rendered exception text so the array is a
+    # self-contained error display, matching the Python and Ruby runners. The
+    # host shows `traceback` verbatim when present and only falls back to
+    # `ename: evalue` when it is empty, so a frames-only traceback would hide
+    # the real error. Julia's `showerror` output already embeds the exception
+    # type for nearly every error and mirrors what the REPL prints after `ERROR: `.
+    tb = isempty(err_str) ? String[] : String[err_str]
     for frame in stacktrace(bt)
         file = string(frame.file)
         line = frame.line

package/src/extensibility/plugins/legacy-pi-bundled-keys.ts

@@ -249,6 +249,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/cli/flag-tables",
 	"@oh-my-pi/pi-coding-agent/cli/gallery-cli",
 	"@oh-my-pi/pi-coding-agent/cli/gallery-screenshot",
+	"@oh-my-pi/pi-coding-agent/cli/gc-cli",
 	"@oh-my-pi/pi-coding-agent/cli/grep-cli",
 	"@oh-my-pi/pi-coding-agent/cli/grievances-cli",
 	"@oh-my-pi/pi-coding-agent/cli/initial-message",
@@ -293,6 +294,7 @@ export const BUNDLED_PI_REGISTRY_KEYS: ReadonlySet<string> = new Set([
 	"@oh-my-pi/pi-coding-agent/commands/config",
 	"@oh-my-pi/pi-coding-agent/commands/dry-balance",
 	"@oh-my-pi/pi-coding-agent/commands/gallery",
+	"@oh-my-pi/pi-coding-agent/commands/gc",
 	"@oh-my-pi/pi-coding-agent/commands/grep",
 	"@oh-my-pi/pi-coding-agent/commands/grievances",
 	"@oh-my-pi/pi-coding-agent/commands/install",

package/src/extensibility/plugins/legacy-pi-bundled-registry.ts

@@ -223,6 +223,7 @@ import * as bundledPiCodingAgentCliGalleryFixturesShell from "@oh-my-pi/pi-codin
 import * as bundledPiCodingAgentCliGalleryFixturesTypes from "@oh-my-pi/pi-coding-agent/cli/gallery-fixtures/types";
 import * as bundledPiCodingAgentCliGalleryFixturesWeb from "@oh-my-pi/pi-coding-agent/cli/gallery-fixtures/web";
 import * as bundledPiCodingAgentCliGalleryScreenshot from "@oh-my-pi/pi-coding-agent/cli/gallery-screenshot";
+import * as bundledPiCodingAgentCliGcCli from "@oh-my-pi/pi-coding-agent/cli/gc-cli";
 import * as bundledPiCodingAgentCliGrepCli from "@oh-my-pi/pi-coding-agent/cli/grep-cli";
 import * as bundledPiCodingAgentCliGrievancesCli from "@oh-my-pi/pi-coding-agent/cli/grievances-cli";
 import * as bundledPiCodingAgentCliInitialMessage from "@oh-my-pi/pi-coding-agent/cli/initial-message";
@@ -255,6 +256,7 @@ import * as bundledPiCodingAgentCommandsCompletions from "@oh-my-pi/pi-coding-ag
 import * as bundledPiCodingAgentCommandsConfig from "@oh-my-pi/pi-coding-agent/commands/config";
 import * as bundledPiCodingAgentCommandsDryBalance from "@oh-my-pi/pi-coding-agent/commands/dry-balance";
 import * as bundledPiCodingAgentCommandsGallery from "@oh-my-pi/pi-coding-agent/commands/gallery";
+import * as bundledPiCodingAgentCommandsGc from "@oh-my-pi/pi-coding-agent/commands/gc";
 import * as bundledPiCodingAgentCommandsGrep from "@oh-my-pi/pi-coding-agent/commands/grep";
 import * as bundledPiCodingAgentCommandsGrievances from "@oh-my-pi/pi-coding-agent/commands/grievances";
 import * as bundledPiCodingAgentCommandsInstall from "@oh-my-pi/pi-coding-agent/commands/install";
@@ -1503,6 +1505,7 @@ export const BUNDLED_PI_REGISTRY: Readonly<Record<string, Readonly<Record<string
 	"@oh-my-pi/pi-coding-agent/cli/gallery-screenshot": bundledPiCodingAgentCliGalleryScreenshot as unknown as Readonly<
 		Record<string, unknown>
 	>,
+	"@oh-my-pi/pi-coding-agent/cli/gc-cli": bundledPiCodingAgentCliGcCli as unknown as Readonly<Record<string, unknown>>,
 	"@oh-my-pi/pi-coding-agent/cli/grep-cli": bundledPiCodingAgentCliGrepCli as unknown as Readonly<
 		Record<string, unknown>
 	>,
@@ -1625,6 +1628,9 @@ export const BUNDLED_PI_REGISTRY: Readonly<Record<string, Readonly<Record<string
 	"@oh-my-pi/pi-coding-agent/commands/gallery": bundledPiCodingAgentCommandsGallery as unknown as Readonly<
 		Record<string, unknown>
 	>,
+	"@oh-my-pi/pi-coding-agent/commands/gc": bundledPiCodingAgentCommandsGc as unknown as Readonly<
+		Record<string, unknown>
+	>,
 	"@oh-my-pi/pi-coding-agent/commands/grep": bundledPiCodingAgentCommandsGrep as unknown as Readonly<
 		Record<string, unknown>
 	>,