@oh-my-pi/pi-coding-agent 16.1.21 → 16.1.22

package/dist/types/mcp/transports/stdio.test.d.ts

@@ -0,0 +1 @@
+export {};

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "16.1.21",
+	"version": "16.1.22",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://omp.sh",
 	"author": "Can Boluk",
@@ -48,17 +48,17 @@
 		"@agentclientprotocol/sdk": "0.25.0",
 		"@babel/parser": "^7.29.7",
 		"@mozilla/readability": "^0.6.0",
-		"@oh-my-pi/hashline": "16.1.21",
-		"@oh-my-pi/omp-stats": "16.1.21",
-		"@oh-my-pi/pi-agent-core": "16.1.21",
-		"@oh-my-pi/pi-ai": "16.1.21",
-		"@oh-my-pi/pi-catalog": "16.1.21",
-		"@oh-my-pi/pi-mnemopi": "16.1.21",
-		"@oh-my-pi/pi-natives": "16.1.21",
-		"@oh-my-pi/pi-tui": "16.1.21",
-		"@oh-my-pi/pi-utils": "16.1.21",
-		"@oh-my-pi/pi-wire": "16.1.21",
-		"@oh-my-pi/snapcompact": "16.1.21",
+		"@oh-my-pi/hashline": "16.1.22",
+		"@oh-my-pi/omp-stats": "16.1.22",
+		"@oh-my-pi/pi-agent-core": "16.1.22",
+		"@oh-my-pi/pi-ai": "16.1.22",
+		"@oh-my-pi/pi-catalog": "16.1.22",
+		"@oh-my-pi/pi-mnemopi": "16.1.22",
+		"@oh-my-pi/pi-natives": "16.1.22",
+		"@oh-my-pi/pi-tui": "16.1.22",
+		"@oh-my-pi/pi-utils": "16.1.22",
+		"@oh-my-pi/pi-wire": "16.1.22",
+		"@oh-my-pi/snapcompact": "16.1.22",
 		"@opentelemetry/api": "^1.9.1",
 		"@opentelemetry/context-async-hooks": "^2.7.1",
 		"@opentelemetry/exporter-trace-otlp-proto": "^0.218.0",

package/src/mcp/oauth-discovery.ts

@@ -250,6 +250,45 @@ export function analyzeAuthError(error: Error, serverUrl?: string): AuthDetectio
 	};
 }
 
+/**
+ * Normalize an OAuth issuer URL for RFC 8414 §3.3 comparison: lowercase
+ * scheme/host (URL parser already does this), drop fragment/query, strip a
+ * trailing slash on the path. The path is otherwise case-sensitive.
+ */
+function normalizeIssuerUrl(value: string): string | undefined {
+	try {
+		const u = new URL(value);
+		const path = u.pathname.replace(/\/+$/, "");
+		return `${u.protocol}//${u.host}${path}`;
+	} catch {
+		return undefined;
+	}
+}
+
+/**
+ * RFC 8414 §3.3: an authorization-server metadata document's `issuer` MUST
+ * equal the URL the client used to construct the metadata URL. When a server
+ * hosts metadata for several issuers under one origin (Plane serves a root
+ * issuer `https://mcp.plane.so/` at `/.well-known/oauth-authorization-server`
+ * *and* a path-scoped issuer `https://mcp.plane.so/http` at the path-prefixed
+ * well-known URL), accepting the first hit silently routes the grant to the
+ * wrong `/authorize` endpoint and produces opaque `server_error` redirects.
+ *
+ * Returns true when the metadata is safe to use:
+ *   - the document has no `issuer` field (nonstandard / legacy servers — keep
+ *     today's permissive behavior), or
+ *   - the issuer matches `baseUrl` after trailing-slash normalization.
+ */
+function issuerMatchesBase(metadataIssuer: unknown, baseUrl: string): boolean {
+	if (typeof metadataIssuer !== "string" || !metadataIssuer.trim()) {
+		return true;
+	}
+	const normalizedIssuer = normalizeIssuerUrl(metadataIssuer);
+	const normalizedBase = normalizeIssuerUrl(baseUrl);
+	if (!normalizedIssuer || !normalizedBase) return true;
+	return normalizedIssuer === normalizedBase;
+}
+
 /**
  * Try to discover OAuth endpoints by querying the server's well-known endpoints.
  * This is a fallback when error responses don't include OAuth metadata.
@@ -389,7 +428,15 @@ export async function discoverOAuthEndpoints(
 
 					if (response.ok) {
 						const metadata = (await response.json()) as Record<string, unknown>;
-						const endpoints = findEndpoints(metadata);
+						// Authorization-server / OpenID Connect metadata documents carry an
+						// `issuer` field that MUST equal the queried base URL (RFC 8414 §3.3,
+						// OIDC Discovery §4.3). Protected-resource and nonstandard paths use a
+						// different schema, so the issuer check only gates the two official
+						// auth-server documents.
+						const requireIssuerMatch =
+							path === "/.well-known/oauth-authorization-server" || path === "/.well-known/openid-configuration";
+						const issuerOk = requireIssuerMatch ? issuerMatchesBase(metadata.issuer, baseUrl) : true;
+						const endpoints = issuerOk ? findEndpoints(metadata) : null;
 						if (endpoints) return endpoints;
 
 						if (path === "/.well-known/oauth-protected-resource") {

package/src/mcp/transports/stdio.test.ts

@@ -0,0 +1,28 @@
+import { describe, expect, it } from "bun:test";
+
+import { resolveStdioSpawnCommand } from "./stdio";
+
+describe("resolveStdioSpawnCommand", () => {
+	it("hides direct Windows executable MCP servers", async () => {
+		await expect(
+			resolveStdioSpawnCommand(
+				{ command: "server.exe", args: ["--stdio"] },
+				{ cwd: process.cwd(), env: {}, platform: "win32" },
+			),
+		).resolves.toEqual({
+			cmd: ["server.exe", "--stdio"],
+			windowsHide: true,
+		});
+	});
+
+	it("keeps off-Windows spawn options unchanged", async () => {
+		await expect(
+			resolveStdioSpawnCommand(
+				{ command: "server.exe", args: ["--stdio"] },
+				{ cwd: process.cwd(), env: {}, platform: "linux" },
+			),
+		).resolves.toEqual({
+			cmd: ["server.exe", "--stdio"],
+		});
+	});
+});

package/src/mcp/transports/stdio.ts

@@ -239,12 +239,15 @@ export async function resolveStdioSpawnCommand(
 	// Direct-spawn only when we resolved to a concrete file AND its extension
 	// is not a batch script. Everything else (resolved .cmd/.bat, or an
 	// unresolved extensionless command) goes through cmd.exe so PATHEXT runs.
+	// Every Windows stdio server launch hides its console window; otherwise
+	// direct .exe servers pop a visible cmd window while the MCP server lives.
+	const windowsHide = true;
 	const needsCmdExe = resolved === null || isWindowsBatchCommand(resolvedCommand);
-	if (!needsCmdExe) return { cmd: [resolvedCommand, ...args] };
+	if (!needsCmdExe) return { cmd: [resolvedCommand, ...args], windowsHide };
 
 	return {
 		cmd: [resolveComSpec(options.env), "/d", "/s", "/c", buildCmdExeCommand(resolvedCommand, args)],
-		windowsHide: true,
+		windowsHide,
 	};
 }