@oh-my-pi/pi-coding-agent 16.1.2 → 16.1.4

package/src/tui/hyperlink.ts

@@ -7,7 +7,7 @@
  */
 import * as url from "node:url";
 import { TERMINAL } from "@oh-my-pi/pi-tui";
-import { settings } from "../config/settings";
+import { isSettingsInitialized, settings } from "../config/settings";
 import {
 	LocalProtocolHandler,
 	memoryRootsFromRegistry,
@@ -45,8 +45,10 @@ function buildFileUri(filePath: string, opts?: { line?: number; col?: number }):
  * - `"off"`: never
  * - `"auto"`: when `process.stdout.isTTY`, `NO_COLOR` is unset, and the detected terminal reports hyperlink support
  * - `"always"`: unconditionally (useful for viewers that support OSC 8 without advertising it)
+ * Before settings initialization, returns false so early render paths stay plain text.
  */
 export function isHyperlinkEnabled(): boolean {
+	if (!isSettingsInitialized()) return false;
 	const mode = settings.get("tui.hyperlinks");
 	if (mode === "off") return false;
 	if (mode === "always") return true;
@@ -104,10 +106,11 @@ export function urlHyperlink(url: string, displayText: string): string {
  * Wrap `displayText` in an OSC 8 hyperlink pointing at an HTTP(S) URL,
  * bypassing terminal capability auto-detection. Used for auth prompts where
  * an inert "click" label blocks login on terminals whose capabilities are
- * not advertised. Still returns plain text when the user has explicitly
- * opted out via `tui.hyperlinks=off`.
+ * not advertised. Still returns plain text before settings initialization or
+ * when the user has explicitly opted out via `tui.hyperlinks=off`.
  */
 export function urlHyperlinkAlways(url: string, displayText: string): string {
+	if (!isSettingsInitialized()) return displayText;
 	if (settings.get("tui.hyperlinks") === "off") return displayText;
 	const normalized = url.match(/^www\./i) ? `https://${url}` : url;
 	try {

package/src/utils/image-loading.ts

@@ -13,9 +13,19 @@ export const SUPPORTED_INPUT_IMAGE_MIME_TYPES = SUPPORTED_IMAGE_MIME_TYPES;
  * with an opaque HTTP 400. Detect those models so the resize pipeline encodes
  * to PNG/JPEG instead — the automatic equivalent of `OMP_NO_WEBP=1`.
  */
-export function modelLacksWebpSupport(model: Pick<Model, "provider" | "api"> | undefined): boolean {
+export function modelLacksWebpSupport(
+	model: Pick<Model, "provider" | "api" | "imageInputDecoder"> | undefined,
+): boolean {
 	if (!model) return false;
-	return model.provider === "ollama" || model.provider === "ollama-cloud" || model.api === "ollama-chat";
+	return (
+		model.imageInputDecoder === "stb" ||
+		model.provider === "ollama" ||
+		model.provider === "ollama-cloud" ||
+		model.provider === "llama.cpp" ||
+		model.provider === "lm-studio" ||
+		model.provider === "local-server" ||
+		model.api === "ollama-chat"
+	);
 }
 
 /**

package/src/utils/ipc.ts

@@ -0,0 +1,38 @@
+import { logger } from "@oh-my-pi/pi-utils";
+
+/**
+ * Narrow a value to a thenable so a rejection handler can be attached.
+ *
+ * Mirrors the local helper in `mcp/transports/stdio.ts` (kept separate because
+ * that copy serves the FileSink stdin-write path and is battle-tested there).
+ * This shared copy is the home for the IPC `send()` sites.
+ */
+export function isThenable(value: unknown): value is PromiseLike<unknown> {
+	return (
+		value != null &&
+		(typeof value === "object" || typeof value === "function") &&
+		typeof (value as { then?: unknown }).then === "function"
+	);
+}
+
+/**
+ * Send a message to a Bun subprocess over IPC, neutralizing both the
+ * synchronous throw ("cannot be used after the process has exited") and any
+ * asynchronous rejection (EPIPE from a pipe that broke between exit being
+ * observed and the next `send()`). The dead worker is detected separately via
+ * `onExit`/`onError` and respawned or disabled by the owning client; an
+ * un-awaited EPIPE rejection must not escape as a fatal unhandled rejection
+ * that takes down the whole session. See issue #2997.
+ *
+ * `label` prefixes the debug log on synchronous failure (e.g. "tts").
+ */
+export function safeSend(proc: { send(message: unknown): unknown }, message: unknown, label: string): void {
+	try {
+		const result = proc.send(message);
+		if (isThenable(result)) result.then(undefined, () => {});
+	} catch (error) {
+		logger.debug(`${label}: send to subprocess failed`, {
+			error: error instanceof Error ? error.message : String(error),
+		});
+	}
+}

package/src/web/search/providers/perplexity-auth.ts

@@ -0,0 +1,133 @@
+import type { AuthStorage, OAuthAccess } from "@oh-my-pi/pi-ai";
+import { $env } from "@oh-my-pi/pi-utils";
+
+export const PERPLEXITY_CHAT_BASE_URL = "https://api.perplexity.ai";
+export const PERPLEXITY_RESPONSES_BASE_URL = "https://api.perplexity.ai/v1";
+export const OPENROUTER_BASE_URL = "https://openrouter.ai/api/v1";
+export const OAUTH_EXPIRY_BUFFER_MS = 5 * 60 * 1000;
+
+export interface ApiConfig {
+	type: "api_key";
+	apiKey: string;
+	provider: "perplexity" | "openrouter";
+	chatBaseUrl: string;
+	responsesBaseUrl: string;
+	modelPrefix: string;
+	useResponses: boolean;
+}
+
+export type PerplexityAuth =
+	| ApiConfig
+	| {
+			type: "oauth";
+			access: OAuthAccess;
+	  }
+	| {
+			type: "cookies";
+			cookies: string;
+	  }
+	| {
+			type: "anonymous";
+	  };
+
+export interface PerplexityAuthOptions {
+	signal?: AbortSignal;
+	forceRefresh?: boolean;
+}
+
+/** Detect API-key endpoints to try in priority order (Perplexity direct, then OpenRouter). */
+export async function getApiConfigs(
+	authStorage: AuthStorage,
+	sessionId: string | undefined,
+	options?: PerplexityAuthOptions,
+): Promise<ApiConfig[]> {
+	const useResponses = $env.PI_PERPLEXITY_RESPONSES === "1";
+	const configs: ApiConfig[] = [];
+
+	const perplexityKey = await authStorage.getApiKey("perplexity", sessionId, options);
+	if (perplexityKey) {
+		configs.push({
+			type: "api_key",
+			apiKey: perplexityKey,
+			provider: "perplexity",
+			chatBaseUrl: PERPLEXITY_CHAT_BASE_URL,
+			responsesBaseUrl: PERPLEXITY_RESPONSES_BASE_URL,
+			modelPrefix: "",
+			useResponses,
+		});
+	}
+
+	const openrouterKey = await authStorage.getApiKey("openrouter", sessionId, options);
+	if (openrouterKey) {
+		configs.push({
+			type: "api_key",
+			apiKey: openrouterKey,
+			provider: "openrouter",
+			chatBaseUrl: OPENROUTER_BASE_URL,
+			responsesBaseUrl: OPENROUTER_BASE_URL,
+			modelPrefix: "perplexity/",
+			useResponses,
+		});
+	}
+
+	return configs;
+}
+
+/**
+ * Decode a Perplexity JWT's `exp` claim, in ms. Returns `undefined` when the
+ * token has no `exp` (which is the common case — Perplexity sessions are
+ * server-side and effectively non-expiring from the client's POV).
+ */
+export function jwtExpiryMs(token: string): number | undefined {
+	const parts = token.split(".");
+	if (parts.length !== 3) return undefined;
+	const payload = parts[1];
+	if (!payload) return undefined;
+	try {
+		const decoded = JSON.parse(Buffer.from(payload, "base64url").toString("utf8")) as { exp?: unknown };
+		if (typeof decoded.exp !== "number" || !Number.isFinite(decoded.exp)) return undefined;
+		return decoded.exp * 1000;
+	} catch {
+		return undefined;
+	}
+}
+
+/** Collect all available auth methods to try in priority order */
+export async function getAvailableAuthMethods(
+	authStorage: AuthStorage,
+	sessionId: string | undefined,
+	options?: PerplexityAuthOptions,
+): Promise<PerplexityAuth[]> {
+	const methods: PerplexityAuth[] = [];
+
+	// 1. Cookies take precedence over OAuth as noted in comments/docs
+	const cookies = $env.PERPLEXITY_COOKIES?.trim();
+	if (cookies) {
+		methods.push({ type: "cookies", cookies });
+	}
+
+	// 2. Perplexity OAuth (session bearer)
+	try {
+		const access = await authStorage.getOAuthAccess("perplexity", sessionId, options);
+		const token = access?.accessToken;
+		if (access && token) {
+			const jwtExpiry = jwtExpiryMs(token);
+			if (jwtExpiry === undefined || jwtExpiry > Date.now() + OAUTH_EXPIRY_BUFFER_MS) {
+				methods.push({ type: "oauth", access });
+			}
+		}
+	} catch {
+		// ignored
+	}
+
+	// 3. API key configs (direct, then openrouter)
+	const apiConfigs = await getApiConfigs(authStorage, sessionId, options);
+	methods.push(...apiConfigs);
+
+	// 4. Fallback to Perplexity free (anonymous)
+	if (methods.length === 0) {
+		methods.push({ type: "anonymous" });
+	}
+
+	return methods;
+}

package/src/web/search/providers/perplexity.ts

@@ -14,7 +14,6 @@ import {
 	type AuthStorage,
 	type Context,
 	type FetchImpl,
-	type OAuthAccess,
 	type Usage,
 	withOAuthAccess,
 } from "@oh-my-pi/pi-ai";
@@ -34,36 +33,19 @@ import { SearchProviderError } from "../../../web/search/types";
 import { dateToAgeSeconds } from "../utils";
 import type { SearchParams } from "./base";
 import { SearchProvider } from "./base";
+import { type ApiConfig, getAvailableAuthMethods } from "./perplexity-auth";
 import { classifyProviderHttpError, withHardTimeout } from "./utils";
 
-const PERPLEXITY_CHAT_BASE_URL = "https://api.perplexity.ai";
-const PERPLEXITY_RESPONSES_BASE_URL = "https://api.perplexity.ai/v1";
-const OPENROUTER_BASE_URL = "https://openrouter.ai/api/v1";
 const PERPLEXITY_OAUTH_ASK_URL = "https://www.perplexity.ai/rest/sse/perplexity_ask";
 
 const DEFAULT_MAX_TOKENS = 8192;
 const DEFAULT_TEMPERATURE = 0.2;
 const DEFAULT_NUM_SEARCH_RESULTS = 20;
-const OAUTH_EXPIRY_BUFFER_MS = 5 * 60 * 1000;
 const OAUTH_API_VERSION = "2.18";
 const OAUTH_USER_AGENT = "Perplexity/641 CFNetwork/1568 Darwin/25.2.0";
 const ANONYMOUS_USER_AGENT =
 	"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/149.0.0.0 Safari/537.36";
 
-type PerplexityAuth =
-	| ApiConfig
-	| {
-			type: "oauth";
-			access: OAuthAccess;
-	  }
-	| {
-			type: "cookies";
-			cookies: string;
-	  }
-	| {
-			type: "anonymous";
-	  };
-
 interface PerplexityOAuthStreamMarkdownBlock {
 	answer?: string;
 	chunks?: string[];
@@ -289,111 +271,6 @@ export interface PerplexitySearchParams {
 	fetch?: FetchImpl;
 }
 
-interface ApiConfig {
-	type: "api_key";
-	apiKey: string;
-	provider: "perplexity" | "openrouter";
-	chatBaseUrl: string;
-	responsesBaseUrl: string;
-	modelPrefix: string;
-	useResponses: boolean;
-}
-
-/** Detect API-key endpoints to try in priority order (Perplexity direct, then OpenRouter). */
-async function getApiConfigs(
-	authStorage: AuthStorage,
-	sessionId: string | undefined,
-	signal: AbortSignal | undefined,
-): Promise<ApiConfig[]> {
-	const useResponses = $env.PI_PERPLEXITY_RESPONSES === "1";
-	const configs: ApiConfig[] = [];
-
-	const perplexityKey = await authStorage.getApiKey("perplexity", sessionId, { signal });
-	if (perplexityKey) {
-		configs.push({
-			type: "api_key",
-			apiKey: perplexityKey,
-			provider: "perplexity",
-			chatBaseUrl: PERPLEXITY_CHAT_BASE_URL,
-			responsesBaseUrl: PERPLEXITY_RESPONSES_BASE_URL,
-			modelPrefix: "",
-			useResponses,
-		});
-	}
-
-	const openrouterKey = await authStorage.getApiKey("openrouter", sessionId, { signal });
-	if (openrouterKey) {
-		configs.push({
-			type: "api_key",
-			apiKey: openrouterKey,
-			provider: "openrouter",
-			chatBaseUrl: OPENROUTER_BASE_URL,
-			responsesBaseUrl: OPENROUTER_BASE_URL,
-			modelPrefix: "perplexity/",
-			useResponses,
-		});
-	}
-
-	return configs;
-}
-
-/**
- * Decode a Perplexity JWT's `exp` claim, in ms. Returns `undefined` when the
- * token has no `exp` (which is the common case — Perplexity sessions are
- * server-side and effectively non-expiring from the client's POV).
- */
-function jwtExpiryMs(token: string): number | undefined {
-	const parts = token.split(".");
-	if (parts.length !== 3) return undefined;
-	const payload = parts[1];
-	if (!payload) return undefined;
-	try {
-		const decoded = JSON.parse(Buffer.from(payload, "base64url").toString("utf8")) as { exp?: unknown };
-		if (typeof decoded.exp !== "number" || !Number.isFinite(decoded.exp)) return undefined;
-		return decoded.exp * 1000;
-	} catch {
-		return undefined;
-	}
-}
-
-/** Collect all available auth methods to try in priority order */
-async function getAvailableAuthMethods(
-	authStorage: AuthStorage,
-	sessionId: string | undefined,
-	signal: AbortSignal | undefined,
-): Promise<PerplexityAuth[]> {
-	const methods: PerplexityAuth[] = [];
-
-	// 1. Perplexity OAuth & Cookies (same priority - highest)
-	try {
-		const access = await authStorage.getOAuthAccess("perplexity", sessionId, { signal });
-		const token = access?.accessToken;
-		if (access && token) {
-			const jwtExpiry = jwtExpiryMs(token);
-			if (jwtExpiry === undefined || jwtExpiry > Date.now() + OAUTH_EXPIRY_BUFFER_MS) {
-				methods.push({ type: "oauth", access });
-			}
-		}
-	} catch {
-		// ignored
-	}
-
-	const cookies = $env.PERPLEXITY_COOKIES?.trim();
-	if (cookies) {
-		methods.push({ type: "cookies", cookies });
-	}
-
-	const apiConfigs = await getApiConfigs(authStorage, sessionId, signal);
-	methods.push(...apiConfigs);
-
-	// 5. Fallback to Perplexity free (anonymous)
-	if (methods.length === 0) {
-		methods.push({ type: "anonymous" });
-	}
-
-	return methods;
-}
-
 interface PerplexityApiStreamMetadata {
 	id?: string;
 	model?: string;
@@ -904,7 +781,7 @@ export async function searchPerplexity(params: PerplexitySearchParams): Promise<
 		request.search_recency_filter = params.search_recency_filter;
 	}
 
-	const authMethods = await getAvailableAuthMethods(params.authStorage, params.sessionId, params.signal);
+	const authMethods = await getAvailableAuthMethods(params.authStorage, params.sessionId, { signal: params.signal });
 	let lastError: unknown;
 
 	for (const auth of authMethods) {