@oh-my-pi/pi-coding-agent 16.0.10 → 16.1.0

package/src/internal-urls/history-protocol.ts

@@ -40,9 +40,12 @@ export class HistoryProtocolHandler implements ProtocolHandler {
 	async resolve(url: InternalUrl): Promise<InternalResource> {
 		const agentId = url.rawHost || url.hostname;
 		const registry = AgentRegistry.global();
+		// Advisor transcripts are observability-only — surfaced in the Agent Hub, never
+		// in the agent-facing roster. Hide them from the index, lookup, and completions.
+		const visible = registry.list().filter(ref => ref.kind !== "advisor");
 
 		if (!agentId) {
-			const content = this.#renderIndex(registry.list());
+			const content = this.#renderIndex(visible);
 			return {
 				url: url.href,
 				content,
@@ -52,13 +55,14 @@ export class HistoryProtocolHandler implements ProtocolHandler {
 		}
 
 		let ref = registry.get(agentId);
+		if (ref?.kind === "advisor") ref = undefined;
 		if (!ref) {
 			// Case-insensitive fallback: agent ids are human-typed (e.g. AuthLoader).
 			const lower = agentId.toLowerCase();
-			ref = registry.list().find(candidate => candidate.id.toLowerCase() === lower);
+			ref = visible.find(candidate => candidate.id.toLowerCase() === lower);
 		}
 		if (!ref) {
-			const known = registry.list().map(candidate => candidate.id);
+			const known = visible.map(candidate => candidate.id);
 			const knownStr = known.length > 0 ? known.join(", ") : "none";
 			throw new Error(`Unknown agent: ${agentId}\nKnown agents: ${knownStr}\nList all with history://`);
 		}
@@ -105,6 +109,7 @@ export class HistoryProtocolHandler implements ProtocolHandler {
 	async complete(): Promise<UrlCompletion[]> {
 		return AgentRegistry.global()
 			.list()
+			.filter(ref => ref.kind !== "advisor")
 			.map(ref => ({
 				value: ref.id,
 				description: `${ref.status} · ${ref.kind}${ref.parentId ? ` · parent ${ref.parentId}` : ""}`,

package/src/irc/bus.ts

@@ -98,6 +98,14 @@ export class IrcBus {
 		if (!ref || ref.status === "aborted") {
 			return { to: message.to, outcome: "failed", error: `Unknown or terminated agent "${message.to}".` };
 		}
+		// Advisor refs are observability-only transcripts, never messageable peers.
+		if (ref.kind === "advisor") {
+			return {
+				to: message.to,
+				outcome: "failed",
+				error: `Agent "${message.to}" is a read-only advisor transcript and cannot be messaged.`,
+			};
+		}
 
 		let revived = false;
 		if (ref.status === "parked") {

package/src/lsp/index.ts

@@ -598,7 +598,7 @@ async function runWorkspaceDiagnostics(
 		// Limit output length
 		const lines = combined.split("\n");
 		if (lines.length > 50) {
-			return { output: `${lines.slice(0, 50).join("\n")}\n... and ${lines.length - 50} more lines`, projectType };
+			return { output: `${lines.slice(0, 50).join("\n")}\n[…${lines.length - 50}ln elided…]`, projectType };
 		}
 		return { output: combined, projectType };
 	} catch (e) {
@@ -2035,7 +2035,7 @@ export class LspTool implements AgentTool<typeof lspSchema, LspToolDetails, Them
 			const lines = limitedSymbols.map(s => formatSymbolInformation(s, this.session.cwd));
 			const truncationLine =
 				dedupedSymbols.length > WORKSPACE_SYMBOL_LIMIT
-					? `\n... ${dedupedSymbols.length - WORKSPACE_SYMBOL_LIMIT} additional symbol(s) omitted`
+					? `\n[…${dedupedSymbols.length - WORKSPACE_SYMBOL_LIMIT} symbols elided…]`
 					: "";
 			return {
 				content: [

package/src/lsp/render.ts

@@ -223,10 +223,10 @@ function renderHover(
 	const langLabel = lang ? theme.fg("mdCodeBlockBorder", ` ${lang}`) : "";
 
 	if (expanded) {
-		const h = theme.boxSharp.horizontal;
-		const v = theme.boxSharp.vertical;
-		const top = `${theme.boxSharp.topLeft}${h.repeat(3)}`;
-		const bottom = `${theme.boxSharp.bottomLeft}${h.repeat(3)}`;
+		const h = theme.boxRound.horizontal;
+		const v = theme.boxRound.vertical;
+		const top = `${theme.boxRound.topLeft}${h.repeat(3)}`;
+		const bottom = `${theme.boxRound.bottomLeft}${h.repeat(3)}`;
 		let output = `${icon}${langLabel}`;
 		if (beforeCode) {
 			for (const line of beforeCode.split("\n")) {
@@ -254,9 +254,9 @@ function renderHover(
 		const preview = truncateToWidth(beforeCode, TRUNCATE_LENGTHS.TITLE);
 		output += `\n ${theme.fg("dim", theme.tree.branch)} ${theme.fg("muted", preview)}`;
 	}
-	const h = theme.boxSharp.horizontal;
-	const v = theme.boxSharp.vertical;
-	const bottom = `${theme.boxSharp.bottomLeft}${h.repeat(3)}`;
+	const h = theme.boxRound.horizontal;
+	const v = theme.boxRound.vertical;
+	const bottom = `${theme.boxRound.bottomLeft}${h.repeat(3)}`;
 	output += `\n ${theme.fg("mdCodeBlockBorder", v)} ${firstCodeLine}`;
 
 	if (codeLines.length > 1) {

package/src/main.ts

@@ -133,9 +133,12 @@ const HOST_DEFAULTED_SETTING_PATHS: SettingPath[] = [
 	"memory.backend",
 	"memories.enabled",
 	// Advisor is interactive-session assistance. Protocol hosts opt in explicitly
-	// instead of inheriting a user's globally-enabled local preference.
+	// instead of inheriting a user's globally-enabled local preference, and when
+	// they do opt in they get the default tuning rather than the user's local tuning.
 	"advisor.enabled",
 	"advisor.subagents",
+	"advisor.syncBacklog",
+	"advisor.immuneTurns",
 ];
 
 const RPC_BACKGROUND_DEFAULTED_SETTING_PATHS: SettingPath[] = [

package/src/modes/acp/acp-agent.ts

@@ -68,10 +68,17 @@ import type { SessionInfo as StoredSessionInfo } from "../../session/session-lis
 import { SessionManager } from "../../session/session-manager";
 import { executeAcpBuiltinSlashCommand } from "../../slash-commands/acp-builtins";
 import { buildAvailableSlashCommands, toAcpAvailableCommands } from "../../slash-commands/available-commands";
+import { DEFAULT_STT_MODEL_KEY, STT_MODEL_OPTIONS } from "../../stt/models";
 import { AUTO_THINKING, parseConfiguredThinkingLevel } from "../../thinking";
 import { normalizeLocalScheme } from "../../tools/path-utils";
 import { runResolveInvocation } from "../../tools/resolve";
 import { ToolError } from "../../tools/tool-errors";
+import {
+	DEFAULT_TTS_LOCAL_MODEL_KEY,
+	DEFAULT_TTS_VOICE,
+	TTS_LOCAL_MODELS,
+	TTS_LOCAL_VOICE_OPTIONS,
+} from "../../tts/models";
 import { canonicalizeMessage } from "../../utils/thinking-display";
 import { createAcpClientBridge } from "./acp-client-bridge";
 import {
@@ -91,6 +98,7 @@ const MODEL_CONFIG_ID = "model";
 const THINKING_CONFIG_ID = "thinking";
 const THINKING_OFF = "off";
 const SESSION_PAGE_SIZE = 50;
+const SPEECH_MODELS_LIST_METHOD = "speech.models.list";
 /**
  * Delay between `session/new` (or `session/load` / `session/resume` /
  * `unstable_session/fork`) returning and the agent firing the first
@@ -195,6 +203,59 @@ type MCPSourceMap = {
 
 type CreateAcpSession = (cwd: string) => Promise<AgentSession>;
 
+type AcpSpeechOption = {
+	value: string;
+	label: string;
+	description?: string;
+};
+
+type AcpSpeechVoiceOption = {
+	value: string;
+	label: string;
+};
+
+type AcpSpeechTtsModelOption = AcpSpeechOption & {
+	voices: AcpSpeechVoiceOption[];
+};
+
+function buildAcpSpeechModelsCatalog(): Record<string, unknown> {
+	const voices = TTS_LOCAL_VOICE_OPTIONS.map(({ value, label }) => ({ value, label }));
+	return {
+		settings: {
+			speechToTextModel: "stt.modelName",
+			textToSpeechModel: "tts.localModel",
+			textToSpeechVoice: "tts.localVoice",
+			speechVoice: "speech.voice",
+		},
+		defaults: {
+			speechToTextModel: DEFAULT_STT_MODEL_KEY,
+			textToSpeechModel: DEFAULT_TTS_LOCAL_MODEL_KEY,
+			voice: DEFAULT_TTS_VOICE,
+		},
+		speechToText: {
+			setting: "stt.modelName",
+			defaultValue: DEFAULT_STT_MODEL_KEY,
+			models: STT_MODEL_OPTIONS.map(({ value, label, description }) => ({ value, label, description })),
+		},
+		textToSpeech: {
+			modelSetting: "tts.localModel",
+			voiceSetting: "tts.localVoice",
+			speechVoiceSetting: "speech.voice",
+			defaultModel: DEFAULT_TTS_LOCAL_MODEL_KEY,
+			defaultVoice: DEFAULT_TTS_VOICE,
+			models: TTS_LOCAL_MODELS.map(
+				({ key, label, description, voices: modelVoices }): AcpSpeechTtsModelOption => ({
+					value: key,
+					label,
+					description,
+					voices: modelVoices.map(({ id, label: voiceLabel }) => ({ value: id, label: voiceLabel })),
+				}),
+			),
+			voices,
+		},
+	};
+}
+
 /**
  * Bridge a single ExtensionUIContext call to the ACP `unstable_createElicitation`
  * surface. Skills/extensions ask for one value at a time (a chosen option, a
@@ -850,6 +911,8 @@ export class AcpAgent implements Agent {
 
 	async extMethod(method: string, params: { [key: string]: unknown }): Promise<{ [key: string]: unknown }> {
 		switch (method) {
+			case SPEECH_MODELS_LIST_METHOD:
+				return buildAcpSpeechModelsCatalog();
 			case "_omp/sessions/listAll": {
 				const limit = typeof params.limit === "number" ? Math.max(1, Math.min(5000, params.limit as number)) : 1000;
 				const sessions = await SessionManager.listAll();

package/src/modes/components/__tests__/skill-message.test.ts

@@ -0,0 +1,92 @@
+import { beforeAll, describe, expect, it } from "bun:test";
+import * as os from "node:os";
+import * as path from "node:path";
+import { Settings } from "../../../config/settings";
+import type { CustomMessage, SkillPromptDetails } from "../../../session/messages";
+import { getThemeByName, setThemeInstance, type Theme } from "../../theme/theme";
+import { SkillMessageComponent } from "../skill-message";
+
+// Drop SGR colors and OSC 8 hyperlink wrappers so assertions see the visible text only.
+const strip = (lines: readonly string[]): string =>
+	lines
+		.join("\n")
+		.replace(/\x1b\]8;[^\x1b\x07]*(?:\x07|\x1b\\)/g, "")
+		.replace(/\x1b\[[0-9;]*m/g, "");
+
+function makeMessage(
+	details: SkillPromptDetails,
+	content = "Use the atomic-commit workflow.",
+): CustomMessage<SkillPromptDetails> {
+	return { role: "custom", customType: "skill-prompt", content, display: true, details, timestamp: Date.now() };
+}
+
+describe("SkillMessageComponent", () => {
+	let uiTheme: Theme;
+
+	beforeAll(async () => {
+		await Settings.init({ inMemory: true });
+		const loaded = await getThemeByName("dark");
+		if (!loaded) throw new Error("theme unavailable");
+		uiTheme = loaded;
+		setThemeInstance(uiTheme);
+	});
+
+	const skillPath = path.join(os.homedir(), ".agent/skills/atomic-commit/SKILL.md");
+
+	it("renders a compact, outlined card instead of the archaic key:value dump", () => {
+		const component = new SkillMessageComponent(
+			makeMessage({ name: "atomic-commit", path: skillPath, lineCount: 88 }),
+		);
+		const text = strip(component.render(80));
+
+		// New look: an icon-tagged "skill" header with the name and a single meta line.
+		expect(text).toContain("skill");
+		expect(text).toContain("atomic-commit");
+		expect(text).toContain("88 lines");
+
+		// The card is drawn with an outline.
+		expect(text).toContain(uiTheme.boxRound.topLeft);
+		expect(text).toContain(uiTheme.boxRound.bottomRight);
+
+		// Path is home-shortened and never leaks the absolute home dir.
+		expect(text).toContain("~/.agent/skills/atomic-commit/SKILL.md");
+		expect(text).not.toContain(os.homedir());
+
+		// The old archaic framing is gone.
+		expect(text).not.toContain("[skill]");
+		expect(text).not.toContain("Skill:");
+		expect(text).not.toContain("Path:");
+		expect(text).not.toContain("Prompt:");
+	});
+
+	it("flattens multi-line args onto the single-line header", () => {
+		const component = new SkillMessageComponent(
+			makeMessage({ name: "atomic-commit", path: skillPath, lineCount: 88, args: "stage all\nthen split" }),
+		);
+		const text = strip(component.render(80));
+		// Whitespace (including the newline) collapsed to single spaces so the header can't break.
+		expect(text).toContain("stage all then split");
+		expect(text).not.toContain("stage all\nthen split");
+	});
+
+	it("uses a singular unit for a one-line prompt", () => {
+		const component = new SkillMessageComponent(makeMessage({ name: "tiny", path: skillPath, lineCount: 1 }));
+		const text = strip(component.render(80));
+		expect(text).toContain("1 line");
+		expect(text).not.toContain("1 lines");
+	});
+
+	it("reveals the prompt body under a calm subheader only when expanded", () => {
+		const details: SkillPromptDetails = { name: "atomic-commit", path: skillPath, lineCount: 88 };
+		const body = "Step one: stage hunks.";
+
+		const collapsed = new SkillMessageComponent(makeMessage(details, body));
+		expect(strip(collapsed.render(80))).not.toContain(body);
+
+		const expanded = new SkillMessageComponent(makeMessage(details, body));
+		expanded.setExpanded(true);
+		const text = strip(expanded.render(80));
+		expect(text).toContain("prompt");
+		expect(text).toContain(body);
+	});
+});

package/src/modes/components/agent-dashboard.ts

@@ -321,7 +321,7 @@ class TwoColumnBody implements Component {
 		const rightLines = this.rightPane.render(rightWidth);
 		const lineCount = this.maxHeight;
 		const out: string[] = [];
-		const separator = theme.fg("dim", ` ${theme.boxSharp.vertical} `);
+		const separator = theme.fg("dim", ` ${theme.boxRound.vertical} `);
 
 		for (let i = 0; i < lineCount; i++) {
 			const left = truncateToWidth(leftLines[i] ?? "", leftWidth);