@oh-my-pi/pi-coding-agent 15.9.1 → 15.9.5

package/src/utils/title-generator.ts

@@ -149,7 +149,10 @@ export async function generateSessionTitle(
 	// tiny title model can't reliably decline trivial input, so this happens
 	// deterministically before any model is invoked; the caller retries on the
 	// next user message while the session stays unnamed.
-	if (isLowSignalTitleInput(firstMessage)) return null;
+	if (isLowSignalTitleInput(firstMessage)) {
+		logger.debug("title-generator: skipped low-signal input", { sessionId, reason: "low-signal" });
+		return null;
+	}
 
 	const tinyModel = settings.get("providers.tinyModel");
 	if (tinyModel === ONLINE_TINY_TITLE_MODEL_KEY) {
@@ -159,7 +162,14 @@ export async function generateSessionTitle(
 	const onlineAbortController = new AbortController();
 	const localTitle = tinyTitleClient.generate(tinyModel, firstMessage).then(
 		title => title || null,
-		() => null,
+		err => {
+			logger.warn("title-generator: local model error", {
+				sessionId,
+				model: tinyModel,
+				error: err instanceof Error ? err.message : String(err),
+			});
+			return null;
+		},
 	);
 	const startOnline = (): Promise<string | null> =>
 		generateTitleOnline(
@@ -188,49 +198,48 @@ export async function generateTitleOnline(
 ): Promise<string | null> {
 	const model = getTitleModel(registry, settings, currentModel);
 	if (!model) {
-		logger.debug("title-generator: no title model found");
+		logger.warn("title-generator: no title model found", { sessionId, reason: "no-title-model" });
 		return null;
 	}
 
 	const userMessage = formatTitleUserMessage(firstMessage);
-
-	const apiKey = await registry.getApiKey(model, sessionId);
-	if (!apiKey) {
-		logger.debug("title-generator: no API key for smol model", {
-			provider: model.provider,
-			id: model.id,
-		});
-		return null;
-	}
-	// Resolve metadata after getApiKey so the session-sticky credential for this
-	// request is already recorded; metadataResolver can then return the correct
-	// account_uuid rather than the snapshot-at-call-site value.
-	const metadata = metadataResolver?.(model.provider);
-
-	// Title generation is a 3-6 word task, but some reasoning backends ignore
-	// disableReasoning. Keep the normal cheap budget for non-reasoning models
-	// while reserving enough output room for reasoning models to still emit
-	// the forced tool call after any unavoidable thinking tokens.
-	const maxTokens = model.reasoning ? Math.max(TITLE_MAX_TOKENS, REASONING_SAFE_MAX_TOKENS) : TITLE_MAX_TOKENS;
-	const request = {
-		model: `${model.provider}/${model.id}`,
-		systemPrompt: TITLE_SYSTEM_PROMPT,
-		userMessage,
-		maxTokens,
+	const modelName = `${model.provider}/${model.id}`;
+	const modelContext = {
+		sessionId,
+		provider: model.provider,
+		id: model.id,
+		model: modelName,
 	};
-	logger.debug("title-generator: request", request);
+	logger.debug("title-generator: start", modelContext);
 
 	try {
+		const apiKey = await registry.getApiKey(model, sessionId);
+		if (!apiKey) {
+			logger.warn("title-generator: no API key", { ...modelContext, reason: "missing-api-key" });
+			return null;
+		}
+		// Resolve metadata after getApiKey so the session-sticky credential for this
+		// request is already recorded; metadataResolver can then return the correct
+		// account_uuid rather than the snapshot-at-call-site value.
+		const metadata = metadataResolver?.(model.provider);
+
+		// Title generation is a 3-6 word task, but some reasoning backends ignore
+		// disableReasoning. Keep the normal cheap budget for non-reasoning models
+		// while reserving enough output room for reasoning models to still emit
+		// the forced tool call after any unavoidable thinking tokens.
+		const maxTokens = model.reasoning ? Math.max(TITLE_MAX_TOKENS, REASONING_SAFE_MAX_TOKENS) : TITLE_MAX_TOKENS;
+		logger.debug("title-generator: request", { ...modelContext, maxTokens });
+
 		const response = await completeSimple(
 			model,
 			{
-				systemPrompt: [request.systemPrompt],
-				messages: [{ role: "user", content: request.userMessage, timestamp: Date.now() }],
+				systemPrompt: [TITLE_SYSTEM_PROMPT],
+				messages: [{ role: "user", content: userMessage, timestamp: Date.now() }],
 				tools: [setTitleTool],
 			},
 			{
 				apiKey,
-				maxTokens: request.maxTokens,
+				maxTokens,
 				disableReasoning: true,
 				toolChoice: { type: "tool", name: SET_TITLE_TOOL_NAME },
 				metadata,
@@ -239,8 +248,9 @@ export async function generateTitleOnline(
 		);
 
 		if (response.stopReason === "error") {
-			logger.debug("title-generator: response error", {
-				model: request.model,
+			logger.warn("title-generator: response error", {
+				...modelContext,
+				reason: "provider-response-error",
 				stopReason: response.stopReason,
 				errorMessage: response.errorMessage,
 			});
@@ -249,8 +259,18 @@ export async function generateTitleOnline(
 
 		const title = normalizeGeneratedTitle(extractGeneratedTitle(response.content));
 
-		logger.debug("title-generator: response", {
-			model: request.model,
+		if (!title) {
+			logger.debug("title-generator: no title returned", {
+				...modelContext,
+				reason: "model-returned-none",
+				usage: response.usage,
+				stopReason: response.stopReason,
+			});
+			return null;
+		}
+
+		logger.debug("title-generator: success", {
+			...modelContext,
 			title,
 			usage: response.usage,
 			stopReason: response.stopReason,
@@ -258,8 +278,9 @@ export async function generateTitleOnline(
 
 		return title;
 	} catch (err) {
-		logger.debug("title-generator: error", {
-			model: request.model,
+		logger.warn("title-generator: error", {
+			...modelContext,
+			reason: "exception",
 			error: err instanceof Error ? err.message : String(err),
 		});
 		return null;

package/src/web/search/index.ts

@@ -278,8 +278,8 @@ export const webSearchCustomTool: CustomTool<typeof webSearchSchema, SearchRende
 		return renderSearchCall(args, options, theme);
 	},
 
-	renderResult(result, options: RenderResultOptions, theme: Theme) {
-		return renderSearchResult(result, options, theme);
+	renderResult(result, options: RenderResultOptions, theme: Theme, args) {
+		return renderSearchResult(result, options, theme, args);
 	},
 };
 

package/src/web/search/render.ts

@@ -5,9 +5,9 @@
  */
 
 import type { Component } from "@oh-my-pi/pi-tui";
-import { Text, visibleWidth, wrapTextWithAnsi } from "@oh-my-pi/pi-tui";
+import { Markdown, Text } from "@oh-my-pi/pi-tui";
 import type { RenderResultOptions } from "../../extensibility/custom-tools/types";
-import type { Theme } from "../../modes/theme/theme";
+import { getMarkdownTheme, type Theme } from "../../modes/theme/theme";
 import {
 	formatAge,
 	formatCount,
@@ -26,8 +26,6 @@ import { getSearchProviderLabel } from "./provider";
 import type { SearchResponse } from "./types";
 
 const MAX_COLLAPSED_ANSWER_LINES = PREVIEW_LIMITS.COLLAPSED_LINES;
-const MAX_EXPANDED_ANSWER_LINES = PREVIEW_LIMITS.EXPANDED_LINES;
-const MAX_ANSWER_LINE_LEN = TRUNCATE_LENGTHS.LINE;
 const MAX_SNIPPET_LINES = 2;
 const MAX_SNIPPET_LINE_LEN = TRUNCATE_LENGTHS.LINE;
 const MAX_COLLAPSED_ITEMS = PREVIEW_LIMITS.COLLAPSED_ITEMS;
@@ -75,7 +73,6 @@ export function renderSearchResult(
 	theme: Theme,
 	args?: {
 		query?: string;
-		allowLongAnswer?: boolean;
 		maxAnswerLines?: number;
 	},
 ): Component {
@@ -104,13 +101,6 @@ export function renderSearchResult(
 	// Get answer text
 	const answerText = typeof response.answer === "string" ? response.answer.trim() : "";
 	const contentText = answerText || rawText;
-	const answerLines = contentText
-		? contentText
-				.split("\n")
-				.filter(l => l.trim())
-				.map(l => l.trim())
-		: [];
-	const totalAnswerLines = answerLines.length;
 
 	const providerLabel = provider !== "none" ? getSearchProviderLabel(provider) : "None";
 	const queryPreview = args?.query
@@ -159,6 +149,7 @@ export function renderSearchResult(
 		metaLines.push(`${theme.fg("muted", "Queries:")} ${theme.fg("text", queryList.join("; "))}${suffix}`);
 	}
 
+	const answerMarkdown = contentText ? new Markdown(contentText, 0, 0, getMarkdownTheme()) : undefined;
 	const outputBlock = new CachedOutputBlock();
 
 	return {
@@ -166,14 +157,22 @@ export function renderSearchResult(
 			// Read mutable state at render time
 			const { expanded } = options;
 
-			// Expanded-dependent computations
-			const answerLimit = expanded ? MAX_EXPANDED_ANSWER_LINES : MAX_COLLAPSED_ANSWER_LINES;
-			const answerPreview = contentText
-				? args?.allowLongAnswer
-					? answerLines.slice(0, args.maxAnswerLines ?? answerLines.length)
-					: getPreviewLines(contentText, answerLimit, MAX_ANSWER_LINE_LEN)
-				: [];
-			const remainingAnswer = totalAnswerLines - answerPreview.length;
+			// Answer lines: full markdown when expanded, capped markdown preview when collapsed.
+			const answerWidth = Math.max(20, width - 3);
+			const renderedAnswer = answerMarkdown ? answerMarkdown.render(answerWidth) : [];
+			let answerLines: string[];
+			if (renderedAnswer.length === 0) {
+				answerLines = [theme.fg("muted", "No answer text returned")];
+			} else if (expanded) {
+				answerLines = renderedAnswer;
+			} else {
+				const collapsedCap = args?.maxAnswerLines ?? MAX_COLLAPSED_ANSWER_LINES;
+				answerLines = renderedAnswer.slice(0, collapsedCap);
+				const remaining = renderedAnswer.length - answerLines.length;
+				if (remaining > 0) {
+					answerLines.push(theme.fg("muted", formatMoreItems(remaining, "line")));
+				}
+			}
 
 			const sourceTree = renderTreeList(
 				{
@@ -217,37 +216,6 @@ export function renderSearchResult(
 				theme,
 			);
 
-			// Build answer section
-			const answerState = sourceCount > 0 ? "success" : "warning";
-			const borderColor: "warning" | "dim" = answerState === "warning" ? "warning" : "dim";
-			const border = (t: string) => theme.fg(borderColor, t);
-			const contentPrefix = border(`${theme.boxSharp.vertical} `);
-			const contentSuffix = border(theme.boxSharp.vertical);
-			const contentWidth = Math.max(0, width - visibleWidth(contentPrefix) - visibleWidth(contentSuffix));
-			const answerTreeLines = answerPreview.length > 0 ? answerPreview : ["No answer text returned"];
-			const answerTree = renderTreeList(
-				{
-					items: answerTreeLines,
-					expanded: true,
-					maxCollapsed: answerTreeLines.length,
-					itemType: "line",
-					renderItem: (line, context) => {
-						const coloredLine =
-							line === "No answer text returned" ? theme.fg("muted", line) : theme.fg("dim", line);
-						if (!args?.allowLongAnswer) {
-							return coloredLine;
-						}
-						const prefixWidth = visibleWidth(context.continuePrefix);
-						const wrapWidth = Math.max(10, contentWidth - prefixWidth);
-						return wrapTextWithAnsi(coloredLine, wrapWidth);
-					},
-				},
-				theme,
-			);
-			if (remainingAnswer > 0) {
-				answerTree.push(theme.fg("muted", formatMoreItems(remainingAnswer, "line")));
-			}
-
 			return outputBlock.render(
 				{
 					header,
@@ -262,7 +230,7 @@ export function renderSearchResult(
 							: []),
 						{
 							label: theme.fg("toolTitle", "Answer"),
-							lines: answerTree,
+							lines: answerLines,
 						},
 						{
 							label: theme.fg("toolTitle", "Sources"),