@oh-my-pi/pi-coding-agent 15.10.9 → 15.10.11

package/src/tools/eval-render.ts

@@ -455,7 +455,7 @@ function formatCellOutputLines(
 	previewLines: number,
 	theme: Theme,
 	width: number,
-): { lines: string[]; hiddenCount: number } {
+): { lines: readonly string[]; hiddenCount: number } {
 	if (!cell.output) {
 		return { lines: [], hiddenCount: 0 };
 	}
@@ -492,7 +492,7 @@ export const evalToolRenderer = {
 		let cached: { key: string; width: number; result: string[] } | undefined;
 
 		return markFramedBlockComponent({
-			render: (width: number): string[] => {
+			render: (width: number): readonly string[] => {
 				const key = `${options.expanded ? 1 : 0}|${cells.map(c => `${c.language}:${c.title ?? ""}:${c.code.length}`).join("|")}`;
 				if (cached && cached.key === key && cached.width === width) {
 					return cached.result;
@@ -573,7 +573,7 @@ export const evalToolRenderer = {
 			let cached: { key: string; width: number; result: string[] } | undefined;
 
 			return markFramedBlockComponent({
-				render: (width: number): string[] => {
+				render: (width: number): readonly string[] => {
 					const expanded = options.renderContext?.expanded ?? options.expanded;
 					const previewLines = options.renderContext?.previewLines ?? EVAL_DEFAULT_PREVIEW_LINES;
 					const key = `${expanded}|${previewLines}|${options.spinnerFrame}`;
@@ -697,12 +697,12 @@ export const evalToolRenderer = {
 		const textContent = `\n${styledOutput}`;
 
 		let cachedWidth: number | undefined;
-		let cachedLines: string[] | undefined;
+		let cachedLines: readonly string[] | undefined;
 		let cachedSkipped: number | undefined;
 		let cachedPreviewLines: number | undefined;
 
 		return {
-			render: (width: number): string[] => {
+			render: (width: number): readonly string[] => {
 				const previewLines = options.renderContext?.previewLines ?? EVAL_DEFAULT_PREVIEW_LINES;
 				if (cachedLines === undefined || cachedWidth !== width || cachedPreviewLines !== previewLines) {
 					const result = truncateToVisualLines(textContent, previewLines, width);

package/src/tools/eval.ts

@@ -358,8 +358,6 @@ export class EvalTool implements AgentTool<typeof evalSchema> {
 							session,
 							idleTimeoutMs,
 							reset: cell.reset,
-							artifactPath,
-							artifactId,
 							onChunk: chunk => {
 								outputSink!.push(chunk);
 							},

package/src/tools/fetch.ts

@@ -7,7 +7,6 @@ import type { FetchImpl, ImageContent, TextContent } from "@oh-my-pi/pi-ai";
 import { htmlToMarkdown } from "@oh-my-pi/pi-natives";
 import { type Component, Text } from "@oh-my-pi/pi-tui";
 import { $which, ptree, truncate } from "@oh-my-pi/pi-utils";
-import { parseHTML } from "linkedom";
 import { LRUCache } from "lru-cache/raw";
 import type { Settings } from "../config/settings";
 import { readEditableNotebookText } from "../edit/notebook";
@@ -23,7 +22,7 @@ import { ensureTool } from "../utils/tools-manager";
 import { extractWithParallel, findParallelApiKey, getParallelExtractContent } from "../web/parallel";
 import { specialHandlers } from "../web/scrapers";
 import type { RenderResult } from "../web/scrapers/types";
-import { finalizeOutput, loadPage, looksLikeHtml, MAX_OUTPUT_CHARS } from "../web/scrapers/types";
+import { finalizeOutput, loadPage, looksLikeHtml, MAX_BYTES, MAX_OUTPUT_CHARS } from "../web/scrapers/types";
 import { convertWithMarkit, fetchBinary } from "../web/scrapers/utils";
 import { type ArchiveFormat, listArchiveRoot, sniffArchiveFormat } from "./archive-reader";
 import { applyListLimit } from "./list-limit";
@@ -191,7 +190,7 @@ export interface ParsedReadUrlTarget {
 
 /** Recognize a single selector token (`raw` or one/many line ranges). */
 function isUrlSelectorToken(token: string): boolean {
-	if (token === "raw") return true;
+	if (token.toLowerCase() === "raw") return true;
 	try {
 		return parseLineRanges(token) !== null;
 	} catch {
@@ -213,7 +212,7 @@ export function parseReadUrlTarget(readPath: string): ParsedReadUrlTarget | null
 	let raw = false;
 	let ranges: readonly LineRange[] | undefined;
 	for (const sel of embedded?.sels ?? []) {
-		if (sel === "raw") {
+		if (sel.toLowerCase() === "raw") {
 			raw = true;
 			continue;
 		}
@@ -549,7 +548,8 @@ function cleanFeedText(text: string): string {
 /**
  * Parse RSS/Atom feed to markdown
  */
-function parseFeedToMarkdown(content: string, maxItems = 10): string {
+async function parseFeedToMarkdown(content: string, maxItems = 10): Promise<string> {
+	const { parseHTML } = await import("linkedom");
 	try {
 		const doc = parseHTML(content).document;
 
@@ -805,6 +805,21 @@ function isArchiveHint(mime: string, extensionHint: string): boolean {
 	return ARCHIVE_MIMES.has(mime) || ARCHIVE_EXTENSIONS.has(extensionHint);
 }
 
+/**
+ * Content types whose payload renderUrl always re-fetches via fetchBinary.
+ * Skipping the initial body read for them avoids downloading and
+ * string-decoding huge binaries (PDFs, archives, images) twice.
+ */
+function shouldSkipBodyDownload(contentType: string): boolean {
+	return (
+		CONVERTIBLE_MIMES.has(contentType) ||
+		NOTEBOOK_MIMES.has(contentType) ||
+		SQLITE_MIMES.has(contentType) ||
+		ARCHIVE_MIMES.has(contentType) ||
+		SUPPORTED_INLINE_IMAGE_MIME_TYPES.has(contentType)
+	);
+}
+
 function getArchiveFormatHint(mime: string, extensionHint: string): ArchiveFormat | undefined {
 	if (extensionHint === ".zip" || mime === "application/zip" || mime === "application/x-zip-compressed") {
 		return "zip";
@@ -901,6 +916,7 @@ async function tryRenderBinaryPayload(
 	mime: string,
 	extHint: string,
 	rawContent: string,
+	bodySkipped: boolean,
 	timeout: number,
 	signal: AbortSignal | undefined,
 	fetchedAt: string,
@@ -909,7 +925,7 @@ async function tryRenderBinaryPayload(
 	const hasNotebookHint = isNotebookHint(mime, extHint);
 	const hasSqliteHint = isSqliteHint(mime, extHint);
 	const hasArchiveHint = isArchiveHint(mime, extHint);
-	const rawLooksBinary = sampleLooksBinary(rawContent);
+	const rawLooksBinary = bodySkipped || sampleLooksBinary(rawContent);
 	if (!hasNotebookHint && !hasSqliteHint && !hasArchiveHint && !rawLooksBinary) {
 		return null;
 	}
@@ -1092,7 +1108,7 @@ async function renderUrl(
 	}
 
 	// Step 2: Fetch page
-	const response = await loadPage(url, { timeout, signal });
+	const response = await loadPage(url, { timeout, signal, skipBodyForContentType: shouldSkipBodyDownload });
 	if (signal?.aborted) {
 		throw new ToolAbortError();
 	}
@@ -1105,11 +1121,17 @@ async function renderUrl(
 			content: "",
 			fetchedAt,
 			truncated: false,
-			notes: [response.status ? `Failed to fetch URL (HTTP ${response.status})` : "Failed to fetch URL"],
+			notes: [
+				response.status ? `Failed to fetch URL (HTTP ${response.status})` : "Failed to fetch URL",
+				...(response.error ? [`Cause: ${response.error}`] : []),
+			],
 		};
 	}
 
 	const { finalUrl, content: rawContent } = response;
+	if (response.truncated) {
+		notes.push(`Response body exceeded ${formatBytes(MAX_BYTES)} and was cut mid-stream; content is incomplete`);
+	}
 	const mime = normalizeMime(response.contentType);
 	const extHint = getExtensionHint(finalUrl);
 
@@ -1276,6 +1298,7 @@ async function renderUrl(
 		mime,
 		extHint,
 		rawContent,
+		response.bodySkipped === true,
 		timeout,
 		signal,
 		fetchedAt,
@@ -1321,7 +1344,7 @@ async function renderUrl(
 	}
 
 	if (isFeed || (isXml && (rawContent.includes("<rss") || rawContent.includes("<feed")))) {
-		const parsed = parseFeedToMarkdown(rawContent);
+		const parsed = await parseFeedToMarkdown(rawContent);
 		const output = finalizeOutput(parsed);
 		return {
 			url,
@@ -1414,7 +1437,7 @@ async function renderUrl(
 			const altResult = await loadPage(resolved, { timeout, signal });
 			if (altResult.ok && altResult.content.trim().length > 200) {
 				notes.push(`Used feed alternate: ${resolved}`);
-				const parsed = parseFeedToMarkdown(altResult.content);
+				const parsed = await parseFeedToMarkdown(altResult.content);
 				const output = finalizeOutput(parsed);
 				return {
 					url,

package/src/tools/gh-cache-invalidation.ts

@@ -17,7 +17,7 @@
  * number, all auth_keys) because the upside of staleness elimination
  * dwarfs the cost of one cache miss.
  */
-import { invalidateAllForNumber } from "./github-cache";
+import { invalidateAllForNumber, invalidateAllForRepo } from "./github-cache";
 
 const PR_URL_PATTERN = /^https:\/\/github\.com\/([^/\s]+\/[^/\s]+)\/pull\/(\d+)(?:[/?#].*)?$/i;
 const ISSUE_URL_PATTERN = /^https:\/\/github\.com\/([^/\s]+\/[^/\s]+)\/issues\/(\d+)(?:[/?#].*)?$/i;
@@ -48,13 +48,60 @@ const MUTATING_PR_SUBCMDS: Record<string, true> = {
 	lock: true,
 	unlock: true,
 };
+
+/**
+ * Flags whose value is the next argv token (`--milestone 3`). The detector
+ * must skip those values so `gh pr edit --milestone 3 14` invalidates #14,
+ * not #3. Curated for the mutating issue/PR subcommands above; a few short
+ * flags are booleans for *some* subcommands (e.g. `-c` is `--comment` text
+ * for `pr close` but a boolean for `pr review`) — we bias toward value-taking
+ * because over-skipping at worst falls back to repo-wide invalidation, while
+ * under-skipping invalidates the wrong number.
+ */
+const VALUE_TAKING_FLAGS: ReadonlySet<string> = new Set([
+	"-m",
+	"--milestone",
+	"-t",
+	"--title",
+	"-b",
+	"--body",
+	"-F",
+	"--body-file",
+	"-a",
+	"--assignee",
+	"--add-assignee",
+	"--remove-assignee",
+	"-l",
+	"--label",
+	"--add-label",
+	"--remove-label",
+	"-p",
+	"--project",
+	"--add-project",
+	"--remove-project",
+	"--add-reviewer",
+	"--remove-reviewer",
+	"-B",
+	"--base",
+	"-c",
+	"--comment",
+	"-r",
+	"--reason",
+	"--branch",
+	"--subject",
+	"--match-head-commit",
+	"--author-email",
+]);
 /**
  * Walk a single shell command's token stream looking for a top-level
- * `gh (issue|pr) <subcmd> <id-or-url>` invocation and return the
- * invalidation key when one is found. Returns `null` for non-matching
- * commands so the caller can iterate cheaply.
+ * `gh (issue|pr) <subcmd> [<id-or-url>]` invocation and return the
+ * invalidation key when one is found. `number === undefined` means the
+ * subcommand mutates state but names no identifier (gh defaults to the
+ * current branch's PR), so the caller must fall back to repo-wide
+ * invalidation. Returns `null` for non-matching commands so the caller can
+ * iterate cheaply.
  */
-function detectGhMutation(tokens: readonly string[]): { number: number; repo?: string } | null {
+function detectGhMutation(tokens: readonly string[]): { number?: number; repo?: string } | null {
 	const ghIdx = tokens.indexOf("gh");
 	if (ghIdx === -1) return null;
 	const subject = tokens[ghIdx + 1];
@@ -82,7 +129,9 @@ function detectGhMutation(tokens: readonly string[]): { number: number; repo?: s
 	}
 	for (let i = ghIdx + 3; i < tokens.length; i++) {
 		const token = tokens[i];
-		if (token === "-R" || token === "--repo") {
+		if (token === "-R" || token === "--repo" || VALUE_TAKING_FLAGS.has(token)) {
+			// Skip the flag's value so it is never mistaken for the positional
+			// identifier (`--milestone 3 14` must invalidate #14, not #3).
 			i++;
 			continue;
 		}
@@ -100,7 +149,9 @@ function detectGhMutation(tokens: readonly string[]): { number: number; repo?: s
 			}
 		}
 	}
-	return null;
+	// Mutating subcommand with no identifier: gh operates on the current
+	// branch's PR, which we cannot resolve synchronously here.
+	return repo !== undefined ? { repo } : {};
 }
 
 /**
@@ -195,6 +246,10 @@ export function invalidateGithubCacheForBashCommand(command: string): void {
 	for (const segment of segments) {
 		const hit = detectGhMutation(segment);
 		if (!hit) continue;
-		invalidateAllForNumber(hit.number, hit.repo);
+		if (hit.number !== undefined) {
+			invalidateAllForNumber(hit.number, hit.repo);
+		} else {
+			invalidateAllForRepo(hit.repo);
+		}
 	}
 }

package/src/tools/gh-renderer.ts

@@ -163,7 +163,7 @@ function getJobStateVisual(
 ): { iconRaw: string; iconColor: ToolUIColor; textColor: ThemeColor } {
 	if (job.conclusion && SUCCESS_CONCLUSIONS.has(job.conclusion)) {
 		return {
-			iconRaw: theme.symbol("tool.gh"),
+			iconRaw: theme.status.success,
 			iconColor: "accent",
 			textColor: "success",
 		};