@oh-my-pi/pi-coding-agent 15.10.3 → 15.10.5

package/src/utils/block-context.ts

@@ -0,0 +1,312 @@
+import { enclosingBlockBoundaries } from "@oh-my-pi/pi-natives";
+import { logger } from "@oh-my-pi/pi-utils";
+
+const OPEN_TO_CLOSE: Record<string, string> = {
+	"(": ")",
+	"[": "]",
+	"{": "}",
+};
+
+const CLOSE_TO_OPEN: Record<string, string> = {
+	")": "(",
+	"]": "[",
+	"}": "{",
+};
+
+export interface LineSpan {
+	startLine: number;
+	endLine: number;
+}
+
+/** Where the source came from, so tree-sitter can pick a grammar. */
+export interface BlockContextSource {
+	path?: string;
+	lang?: string;
+}
+
+export type LineEntry = { kind: "line"; lineNumber: number; text: string; context: boolean } | { kind: "ellipsis" };
+
+interface StackEntry {
+	opener: string;
+	lineNumber: number;
+	text: string;
+	visible: boolean;
+}
+
+type ScannerMode = "code" | "single" | "double" | "template" | "blockComment";
+
+function normalizeLineSpans(spans: readonly LineSpan[], totalLines: number): LineSpan[] {
+	if (totalLines <= 0) return [];
+	const normalized: LineSpan[] = [];
+	for (const span of spans) {
+		const startLine = Math.max(1, Math.trunc(span.startLine));
+		const endLine = Math.min(totalLines, Math.trunc(span.endLine));
+		if (endLine < startLine) continue;
+		normalized.push({ startLine, endLine });
+	}
+	if (normalized.length <= 1) return normalized;
+	normalized.sort((left, right) => left.startLine - right.startLine || left.endLine - right.endLine);
+	const merged: LineSpan[] = [];
+	for (const span of normalized) {
+		const previous = merged[merged.length - 1];
+		if (previous && span.startLine <= previous.endLine + 1) {
+			previous.endLine = Math.max(previous.endLine, span.endLine);
+			continue;
+		}
+		merged.push({ ...span });
+	}
+	return merged;
+}
+
+function visibleLineNumbers(spans: readonly LineSpan[]): Set<number> {
+	const visible = new Set<number>();
+	for (const span of spans) {
+		for (let line = span.startLine; line <= span.endLine; line++) {
+			visible.add(line);
+		}
+	}
+	return visible;
+}
+
+function hasEveryLineVisible(visible: ReadonlySet<number>, totalLines: number): boolean {
+	return totalLines > 0 && visible.size >= totalLines;
+}
+
+/** Collapse a set of visible line numbers into sorted, merged inclusive spans. */
+function visibleSetToSpans(visible: ReadonlySet<number>): LineSpan[] {
+	const sorted = [...visible].sort((left, right) => left - right);
+	const spans: LineSpan[] = [];
+	for (const line of sorted) {
+		const previous = spans[spans.length - 1];
+		if (previous && line <= previous.endLine + 1) {
+			previous.endLine = line;
+			continue;
+		}
+		spans.push({ startLine: line, endLine: line });
+	}
+	return spans;
+}
+
+/**
+ * Tree-sitter-backed block boundaries. For each multi-line named node whose
+ * span crosses the visible window, the native side returns the boundary line
+ * outside that window (closer when the opener is shown, opener when the closer
+ * is shown). Returns `null` when the language is unrecognized or the source has
+ * a syntax error so the caller can fall back to a lexical bracket scan.
+ */
+function nativeBlockContext(
+	fullLines: readonly string[],
+	visible: ReadonlySet<number>,
+	source: BlockContextSource,
+): Map<number, string> | null {
+	if (!source.path && !source.lang) return null;
+	const ranges = visibleSetToSpans(visible);
+	if (ranges.length === 0) return new Map();
+	let boundaries: number[] | null;
+	try {
+		boundaries = enclosingBlockBoundaries({
+			code: fullLines.join("\n"),
+			path: source.path,
+			lang: source.lang,
+			ranges,
+		});
+	} catch (error) {
+		logger.debug("enclosingBlockBoundaries failed; using lexical bracket fallback", { error });
+		return null;
+	}
+	if (boundaries === null) return null;
+	const context = new Map<number, string>();
+	for (const lineNumber of boundaries) {
+		if (visible.has(lineNumber)) continue;
+		context.set(lineNumber, fullLines[lineNumber - 1] ?? "");
+	}
+	return context;
+}
+
+function findMatchingStackIndex(stack: readonly StackEntry[], opener: string): number {
+	for (let index = stack.length - 1; index >= 0; index--) {
+		if (stack[index].opener === opener) return index;
+	}
+	return -1;
+}
+
+function isHashCommentStart(line: string, index: number): boolean {
+	if (line[index] !== "#") return false;
+	for (let i = 0; i < index; i++) {
+		const ch = line[i];
+		if (ch !== " " && ch !== "\t") return false;
+	}
+	return true;
+}
+
+/**
+ * Lexical bracket-matching fallback for sources tree-sitter can't parse
+ * (unknown extensions, syntax errors). Pairs `()[]{}` while skipping strings
+ * and line/block comments, and reports the matching line when one endpoint is
+ * visible and the other is not.
+ */
+function lexicalBracketContext(fullLines: readonly string[], visible: ReadonlySet<number>): Map<number, string> {
+	const context = new Map<number, string>();
+	const stack: StackEntry[] = [];
+	let mode: ScannerMode = "code";
+	let escaped = false;
+
+	for (let lineIndex = 0; lineIndex < fullLines.length; lineIndex++) {
+		const lineNumber = lineIndex + 1;
+		const line = fullLines[lineIndex] ?? "";
+		const lineVisible = visible.has(lineNumber);
+		let index = 0;
+		while (index < line.length) {
+			const ch = line[index];
+			const next = index + 1 < line.length ? line[index + 1] : "";
+
+			if (mode === "blockComment") {
+				if (ch === "*" && next === "/") {
+					mode = "code";
+					index += 2;
+					continue;
+				}
+				index++;
+				continue;
+			}
+
+			if (mode === "single" || mode === "double" || mode === "template") {
+				if (escaped) {
+					escaped = false;
+					index++;
+					continue;
+				}
+				if (ch === "\\") {
+					escaped = true;
+					index++;
+					continue;
+				}
+				if (
+					(mode === "single" && ch === "'") ||
+					(mode === "double" && ch === '"') ||
+					(mode === "template" && ch === "`")
+				) {
+					mode = "code";
+				}
+				index++;
+				continue;
+			}
+
+			if (ch === "/" && next === "/") break;
+			if (ch === "/" && next === "*") {
+				mode = "blockComment";
+				index += 2;
+				continue;
+			}
+			if (isHashCommentStart(line, index)) break;
+			if (ch === "'") {
+				mode = "single";
+				escaped = false;
+				index++;
+				continue;
+			}
+			if (ch === '"') {
+				mode = "double";
+				escaped = false;
+				index++;
+				continue;
+			}
+			if (ch === "`") {
+				mode = "template";
+				escaped = false;
+				index++;
+				continue;
+			}
+
+			if (OPEN_TO_CLOSE[ch]) {
+				stack.push({ opener: ch, lineNumber, text: line, visible: lineVisible });
+				index++;
+				continue;
+			}
+
+			const opener = CLOSE_TO_OPEN[ch];
+			if (opener) {
+				const matchIndex = findMatchingStackIndex(stack, opener);
+				if (matchIndex !== -1) {
+					const [matched] = stack.splice(matchIndex);
+					if (matched) {
+						if (lineVisible && !matched.visible) context.set(matched.lineNumber, matched.text);
+						if (matched.visible && !lineVisible) context.set(lineNumber, line);
+					}
+				}
+			}
+
+			index++;
+		}
+
+		if (mode === "single" || mode === "double") {
+			mode = "code";
+			escaped = false;
+		}
+	}
+
+	for (const lineNumber of visible) context.delete(lineNumber);
+	return context;
+}
+
+/**
+ * Resolve the off-window boundary lines for a visible window: tree-sitter
+ * syntactic spans first (covers brace and indentation languages), falling back
+ * to a lexical bracket scan when the grammar is unavailable. Returns a map of
+ * `lineNumber → source text` for the lines to surface, never including a line
+ * already visible.
+ */
+export function findBlockContextLines(
+	fullLines: readonly string[],
+	visibleInput: ReadonlySet<number> | readonly number[],
+	source: BlockContextSource = {},
+): Map<number, string> {
+	const visible = visibleInput instanceof Set ? visibleInput : new Set(visibleInput);
+	if (visible.size === 0 || hasEveryLineVisible(visible, fullLines.length)) return new Map();
+	return nativeBlockContext(fullLines, visible, source) ?? lexicalBracketContext(fullLines, visible);
+}
+
+/**
+ * Build display entries for `visibleSpans` plus any off-window block-boundary
+ * lines, in source order, with `{ kind: "ellipsis" }` markers inserted across
+ * non-contiguous gaps. `options.lineText` lets callers substitute display text
+ * (e.g. column-truncated lines) for a given line number.
+ */
+export function buildLineEntriesWithBlockContext(
+	fullLines: readonly string[],
+	visibleSpans: readonly LineSpan[],
+	source: BlockContextSource = {},
+	options: {
+		lineText?: (lineNumber: number, sourceText: string, context: boolean) => string;
+	} = {},
+): LineEntry[] {
+	const spans = normalizeLineSpans(visibleSpans, fullLines.length);
+	const visible = visibleLineNumbers(spans);
+	const context = findBlockContextLines(fullLines, visible, source);
+	const allLines = new Set<number>(visible);
+	for (const lineNumber of context.keys()) allLines.add(lineNumber);
+
+	const sorted = [...allLines].sort((left, right) => left - right);
+	const entries: LineEntry[] = [];
+	let previousLine: number | undefined;
+	for (const lineNumber of sorted) {
+		if (previousLine !== undefined && lineNumber > previousLine + 1) {
+			entries.push({ kind: "ellipsis" });
+		}
+		const sourceText = fullLines[lineNumber - 1] ?? "";
+		const isContext = context.has(lineNumber);
+		entries.push({
+			kind: "line",
+			lineNumber,
+			text: options.lineText?.(lineNumber, sourceText, isContext) ?? sourceText,
+			context: isContext,
+		});
+		previousLine = lineNumber;
+	}
+
+	return entries;
+}
+
+export function lineEntriesToPlainText(entries: readonly LineEntry[], ellipsis = "…"): string {
+	return entries.map(entry => (entry.kind === "ellipsis" ? ellipsis : entry.text)).join("\n");
+}

package/src/utils/image-loading.ts

@@ -2,7 +2,7 @@ import * as fs from "node:fs/promises";
 import type { ImageContent } from "@oh-my-pi/pi-ai";
 import { formatBytes, readImageMetadata, SUPPORTED_IMAGE_MIME_TYPES } from "@oh-my-pi/pi-utils";
 import { resolveReadPath } from "../tools/path-utils";
-import { formatDimensionNote, resizeImage } from "./image-resize";
+import { formatDimensionNote, type ImageResizeOptions, resizeImage } from "./image-resize";
 
 export const MAX_IMAGE_INPUT_BYTES = 20 * 1024 * 1024;
 export const SUPPORTED_INPUT_IMAGE_MIME_TYPES = SUPPORTED_IMAGE_MIME_TYPES;
@@ -50,6 +50,36 @@ export async function ensureSupportedImageInput(image: ImageContent): Promise<Im
 	}
 }
 
+export interface NormalizeModelContextImagesOptions {
+	resize?: ImageResizeOptions;
+}
+
+/**
+ * Normalize image blocks before they enter agent/model context. This keeps
+ * provider request construction from having to resize an unbounded batch of
+ * large images on the streaming hot path. Images are processed sequentially on
+ * purpose: `resizeImage` may fan out multiple encoders for one image, so the
+ * outer image batch must stay bounded.
+ */
+export async function normalizeModelContextImages(
+	images: ImageContent[] | undefined,
+	options?: NormalizeModelContextImagesOptions,
+): Promise<ImageContent[] | undefined> {
+	if (!images || images.length === 0) return undefined;
+	const normalized: ImageContent[] = [];
+	for (const image of images) {
+		try {
+			const resized = await resizeImage(image, options?.resize);
+			normalized.push({ type: "image", data: resized.data, mimeType: resized.mimeType });
+		} catch {
+			// Preserve existing caller behavior for decode/resize failures: keep the
+			// user's image block rather than dropping it from the turn.
+			normalized.push(image);
+		}
+	}
+	return normalized;
+}
+
 export async function loadImageInput(options: LoadImageInputOptions): Promise<LoadedImageInput | null> {
 	const maxBytes = options.maxBytes ?? MAX_IMAGE_INPUT_BYTES;
 	const resolvedPath = options.resolvedPath ?? resolveReadPath(options.path, options.cwd);

package/src/utils/title-generator.ts

@@ -33,7 +33,7 @@ const setTitleTool: Tool = {
 			title: {
 				type: "string",
 				description:
-					'A concise 3-6 word title for the session, or exactly "none" when the message carries no concrete task yet (greeting, small talk, vague).',
+					'A concise, sentence-case 3-7 word title for the session (capitalize only the first word and proper nouns), or exactly "none" when the message carries no concrete task yet (greeting, small talk, vague).',
 			},
 		},
 		required: ["title"],
@@ -224,7 +224,7 @@ export async function generateTitleOnline(
 		// account_uuid rather than the snapshot-at-call-site value.
 		const metadata = metadataResolver?.(model.provider);
 
-		// Title generation is a 3-6 word task, but some reasoning backends ignore
+		// Title generation is a 3-7 word task, but some reasoning backends ignore
 		// disableReasoning. Keep the normal cheap budget for non-reasoning models
 		// while reserving enough output room for reasoning models to still emit
 		// the forced tool call after any unavoidable thinking tokens.

package/src/web/search/providers/codex.ts

@@ -8,7 +8,7 @@
  */
 import * as os from "node:os";
 import { type AuthStorage, getBundledModels } from "@oh-my-pi/pi-ai";
-import { decodeJwt } from "@oh-my-pi/pi-ai/utils/oauth/openai-codex";
+import { decodeJwt } from "@oh-my-pi/pi-ai/oauth/openai-codex";
 import { $env, readSseJson } from "@oh-my-pi/pi-utils";
 import packageJson from "../../../../package.json" with { type: "json" };
 import type { SearchResponse, SearchSource } from "../../../web/search/types";

package/src/web/search/render.ts

@@ -117,13 +117,21 @@ export function renderSearchResult(
 		: searchQueries[0]
 			? truncateToWidth(searchQueries[0], 80)
 			: undefined;
+	const success = sourceCount > 0;
 	const header = renderStatusLine(
-		{
-			icon: sourceCount > 0 ? "success" : "warning",
-			title: "Web Search",
-			description: providerLabel,
-			meta: [formatCount("source", sourceCount)],
-		},
+		success
+			? {
+					iconOverride: theme.styledSymbol("tool.webSearch", "accent"),
+					title: "Web Search",
+					description: providerLabel,
+					meta: [formatCount("source", sourceCount)],
+				}
+			: {
+					icon: "warning",
+					title: "Web Search",
+					description: providerLabel,
+					meta: [formatCount("source", sourceCount)],
+				},
 		theme,
 	);