@oh-my-pi/pi-coding-agent 14.5.14 → 14.6.0

package/src/utils/title-generator.ts

@@ -2,15 +2,13 @@
  * Generate session titles using a smol, fast model.
  */
 import * as path from "node:path";
-import type { ThinkingLevel } from "@oh-my-pi/pi-agent-core";
-import type { Api, Model } from "@oh-my-pi/pi-ai";
-import { completeSimple } from "@oh-my-pi/pi-ai";
+
+import { type Api, completeSimple, type Model } from "@oh-my-pi/pi-ai";
 import { logger, prompt } from "@oh-my-pi/pi-utils";
 import type { ModelRegistry } from "../config/model-registry";
 import { resolveRoleSelection } from "../config/model-resolver";
 import type { Settings } from "../config/settings";
 import titleSystemPrompt from "../prompts/system/title-system.md" with { type: "text" };
-import { toReasoningEffort } from "../thinking";
 
 const TITLE_SYSTEM_PROMPT = prompt.render(titleSystemPrompt);
 
@@ -19,22 +17,14 @@ const TERMINAL_TITLE_CONTROL_CHARS = /[\u0000-\u001f\u007f-\u009f]/g;
 
 const MAX_INPUT_CHARS = 2000;
 
-function getTitleModel(
-	registry: ModelRegistry,
-	settings: Settings,
-	currentModel?: Model<Api>,
-): { model: Model<Api>; thinkingLevel?: ThinkingLevel } | undefined {
+function getTitleModel(registry: ModelRegistry, settings: Settings, currentModel?: Model<Api>): Model<Api> | undefined {
 	const availableModels = registry.getAvailable();
 	if (availableModels.length === 0) return undefined;
 
-	const titleModel = resolveRoleSelection(["commit", "smol"], settings, availableModels, registry);
-	if (titleModel) {
-		return { model: titleModel.model, thinkingLevel: titleModel.thinkingLevel };
-	}
+	const titleModel = resolveRoleSelection(["commit", "smol"], settings, availableModels, registry)?.model;
+	if (titleModel) return titleModel;
 
-	if (currentModel) {
-		return { model: currentModel };
-	}
+	if (currentModel) return currentModel;
 
 	return undefined;
 }
@@ -44,7 +34,7 @@ function getTitleModel(
  *
  * @param firstMessage The first user message
  * @param registry Model registry
- * @param settings Settings used to resolve the smol role, including per-role thinking
+ * @param settings Settings used to resolve the smol role
  * @param sessionId Optional session id for sticky API key selection
  */
 export async function generateSessionTitle(
@@ -54,8 +44,8 @@ export async function generateSessionTitle(
 	sessionId?: string,
 	currentModel?: Model<Api>,
 ): Promise<string | null> {
-	const candidate = getTitleModel(registry, settings, currentModel);
-	if (!candidate) {
+	const model = getTitleModel(registry, settings, currentModel);
+	if (!model) {
 		logger.debug("title-generator: no title model found");
 		return null;
 	}
@@ -67,17 +57,20 @@ export async function generateSessionTitle(
 ${truncatedMessage}
 </user-message>`;
 
-	const apiKey = await registry.getApiKey(candidate.model, sessionId);
+	const apiKey = await registry.getApiKey(model, sessionId);
 	if (!apiKey) {
 		logger.debug("title-generator: no API key for smol model", {
-			provider: candidate.model.provider,
-			id: candidate.model.id,
+			provider: model.provider,
+			id: model.id,
 		});
 		return null;
 	}
 
+	// Title generation is a 3-6 word task; force reasoning off so reasoning models
+	// don't burn the entire output budget on internal thinking and return an empty
+	// string. With reasoning disabled, 30 tokens of output is plenty.
 	const request = {
-		model: `${candidate.model.provider}/${candidate.model.id}`,
+		model: `${model.provider}/${model.id}`,
 		systemPrompt: TITLE_SYSTEM_PROMPT,
 		userMessage,
 		maxTokens: 30,
@@ -86,7 +79,7 @@ ${truncatedMessage}
 
 	try {
 		const response = await completeSimple(
-			candidate.model,
+			model,
 			{
 				systemPrompt: request.systemPrompt,
 				messages: [{ role: "user", content: request.userMessage, timestamp: Date.now() }],
@@ -94,7 +87,7 @@ ${truncatedMessage}
 			{
 				apiKey,
 				maxTokens: 30,
-				reasoning: toReasoningEffort(candidate.thinkingLevel),
+				disableReasoning: true,
 			},
 		);
 
@@ -153,13 +146,8 @@ function getFallbackTerminalTitle(cwd: string | undefined): string | undefined {
 	return sanitizeTerminalTitlePart(baseName);
 }
 
-export function formatSessionTerminalTitle(
-	sessionName: string | undefined,
-	cwd?: string,
-	titleSource?: "auto" | "user" | undefined,
-): string {
-	const label =
-		sanitizeTerminalTitlePart(titleSource === "auto" ? undefined : sessionName) ?? getFallbackTerminalTitle(cwd);
+export function formatSessionTerminalTitle(sessionName: string | undefined, cwd?: string): string {
+	const label = sanitizeTerminalTitlePart(sessionName) ?? getFallbackTerminalTitle(cwd);
 	return label ? `${DEFAULT_TERMINAL_TITLE}: ${label}` : DEFAULT_TERMINAL_TITLE;
 }
 
@@ -170,12 +158,8 @@ export function setTerminalTitle(title: string): void {
 	process.stdout.write(`\x1b]0;${sanitizeTerminalTitlePart(title) ?? DEFAULT_TERMINAL_TITLE}\x07`);
 }
 
-export function setSessionTerminalTitle(
-	sessionName: string | undefined,
-	cwd?: string,
-	titleSource?: "auto" | "user" | undefined,
-): void {
-	setTerminalTitle(formatSessionTerminalTitle(sessionName, cwd, titleSource));
+export function setSessionTerminalTitle(sessionName: string | undefined, cwd?: string): void {
+	setTerminalTitle(formatSessionTerminalTitle(sessionName, cwd));
 }
 
 /**

package/src/autoresearch/apply-contract-to-state.ts

@@ -1,24 +0,0 @@
-import { inferMetricUnitFromName } from "./helpers";
-import type { AutoresearchContract, ExperimentState } from "./types";
-
-/**
- * Updates session fields from a validated `autoresearch.md` parse (same fields as `init_experiment`).
- * Does not touch `name`, `currentSegment`, `results`, `bestMetric`, `confidence`, or `maxExperiments`.
- */
-export function applyAutoresearchContractToExperimentState(
-	contract: AutoresearchContract,
-	state: ExperimentState,
-): void {
-	const benchmarkContract = contract.benchmark;
-	state.metricName = benchmarkContract.primaryMetric ?? state.metricName;
-	state.metricUnit = benchmarkContract.metricUnit;
-	state.bestDirection = benchmarkContract.direction ?? "lower";
-	state.secondaryMetrics = benchmarkContract.secondaryMetrics.map(name => ({
-		name,
-		unit: inferMetricUnitFromName(name),
-	}));
-	state.benchmarkCommand = benchmarkContract.command?.trim() ?? state.benchmarkCommand;
-	state.scopePaths = [...contract.scopePaths];
-	state.offLimits = [...contract.offLimits];
-	state.constraints = [...contract.constraints];
-}

package/src/autoresearch/contract.ts

@@ -1,288 +0,0 @@
-import * as fs from "node:fs";
-import * as path from "node:path";
-import type { AutoresearchBenchmarkContract, AutoresearchContract, MetricDirection } from "./types";
-
-export interface AutoresearchContractLoadResult {
-	contract: AutoresearchContract;
-	errors: string[];
-	path: string;
-}
-
-export interface AutoresearchScriptSnapshot {
-	benchmarkScript: string;
-	benchmarkScriptPath: string;
-	checksScript: string | null;
-	checksScriptPath: string;
-	errors: string[];
-}
-
-const HEADING_REGEX = /^##\s+(.+?)\s*$/;
-const LIST_ITEM_REGEX = /^\s*[-*]\s+(.*)$/;
-const KEY_VALUE_REGEX = /^\s*[-*]\s+([^:]+):\s*(.*)$/;
-
-export function readAutoresearchContract(workDir: string): AutoresearchContractLoadResult {
-	const contractPath = path.join(workDir, "autoresearch.md");
-	let content = "";
-	try {
-		content = fs.readFileSync(contractPath, "utf8");
-	} catch {
-		return {
-			contract: createEmptyAutoresearchContract(),
-			errors: [`${contractPath} does not exist. Create it before initializing autoresearch.`],
-			path: contractPath,
-		};
-	}
-
-	const contract = parseAutoresearchContract(content);
-	const errors = validateAutoresearchContract(contract);
-	return { contract, errors, path: contractPath };
-}
-
-export function parseAutoresearchContract(markdown: string): AutoresearchContract {
-	const sections = extractSections(markdown);
-	return {
-		benchmark: parseBenchmarkSection(sections.get("benchmark") ?? ""),
-		scopePaths: parseListSection(sections.get("files in scope") ?? "", normalizeContractPathSpec),
-		offLimits: parseListSection(sections.get("off limits") ?? "", normalizeContractPathSpec),
-		constraints: parseListSection(sections.get("constraints") ?? ""),
-	};
-}
-
-export function validateAutoresearchContract(contract: AutoresearchContract): string[] {
-	const errors: string[] = [];
-	if (!contract.benchmark.command) {
-		errors.push("Benchmark.command is required in autoresearch.md.");
-	}
-	if (!contract.benchmark.primaryMetric) {
-		errors.push("Benchmark.primary metric is required in autoresearch.md.");
-	}
-	if (!contract.benchmark.direction) {
-		errors.push("Benchmark.direction must be `lower` or `higher` in autoresearch.md.");
-	}
-	if (contract.scopePaths.length === 0) {
-		errors.push("Files in Scope must contain at least one path in autoresearch.md.");
-	}
-	for (const scopePath of contract.scopePaths) {
-		if (isUnsafeContractPathSpec(scopePath)) {
-			errors.push(`Files in Scope contains an invalid path: ${scopePath}`);
-		}
-	}
-	for (const offLimitsPath of contract.offLimits) {
-		if (isUnsafeContractPathSpec(offLimitsPath)) {
-			errors.push(`Off Limits contains an invalid path: ${offLimitsPath}`);
-		}
-	}
-	return errors;
-}
-
-export function loadAutoresearchScriptSnapshot(workDir: string): AutoresearchScriptSnapshot {
-	const benchmarkScriptPath = path.join(workDir, "autoresearch.sh");
-	const checksScriptPath = path.join(workDir, "autoresearch.checks.sh");
-	const errors: string[] = [];
-
-	let benchmarkScript = "";
-	try {
-		benchmarkScript = fs.readFileSync(benchmarkScriptPath, "utf8");
-	} catch {
-		errors.push(`${benchmarkScriptPath} does not exist. Create it before initializing autoresearch.`);
-	}
-
-	let checksScript: string | null = null;
-	try {
-		checksScript = fs.readFileSync(checksScriptPath, "utf8");
-	} catch {
-		checksScript = null;
-	}
-
-	return {
-		benchmarkScript,
-		benchmarkScriptPath,
-		checksScript,
-		checksScriptPath,
-		errors,
-	};
-}
-
-export function normalizeAutoresearchList(values: readonly string[]): string[] {
-	const normalized: string[] = [];
-	const seen = new Set<string>();
-	for (const value of values) {
-		const trimmed = value.trim();
-		if (trimmed.length === 0) continue;
-		if (seen.has(trimmed)) continue;
-		seen.add(trimmed);
-		normalized.push(trimmed);
-	}
-	return normalized;
-}
-
-export function normalizeContractPathSpec(value: string): string {
-	const normalized = path.posix.normalize(value.trim().replaceAll("\\", "/"));
-	if (normalized === "." || normalized === "./") return ".";
-	return normalized.replace(/^\.\/+/, "").replace(/\/+$/, "");
-}
-
-export function pathMatchesContractPath(pathValue: string, specValue: string): boolean {
-	const normalizedPath = normalizeContractPathSpec(pathValue);
-	const normalizedSpec = normalizeContractPathSpec(specValue);
-	if (normalizedSpec === ".") return true;
-	return normalizedPath === normalizedSpec || normalizedPath.startsWith(`${normalizedSpec}/`);
-}
-
-export function contractListsEqual(left: readonly string[], right: readonly string[]): boolean {
-	const normalizedLeft = normalizeAutoresearchList(left);
-	const normalizedRight = normalizeAutoresearchList(right);
-	if (normalizedLeft.length !== normalizedRight.length) return false;
-	return normalizedLeft.every((value, index) => value === normalizedRight[index]);
-}
-
-export function contractPathListsEqual(left: readonly string[], right: readonly string[]): boolean {
-	const normalizedLeft = normalizeContractPathList(left);
-	const normalizedRight = normalizeContractPathList(right);
-	if (normalizedLeft.length !== normalizedRight.length) return false;
-	return normalizedLeft.every((value, index) => value === normalizedRight[index]);
-}
-
-function createEmptyAutoresearchContract(): AutoresearchContract {
-	return {
-		benchmark: {
-			command: null,
-			primaryMetric: null,
-			metricUnit: "",
-			direction: null,
-			secondaryMetrics: [],
-		},
-		scopePaths: [],
-		offLimits: [],
-		constraints: [],
-	};
-}
-
-function normalizeContractPathList(values: readonly string[]): string[] {
-	return normalizeAutoresearchList(values.map(normalizeContractPathSpec)).sort((left, right) =>
-		left.localeCompare(right),
-	);
-}
-
-function extractSections(markdown: string): Map<string, string> {
-	const sections = new Map<string, string>();
-	const lines = markdown.split("\n");
-	let currentHeading: string | null = null;
-	let currentLines: string[] = [];
-
-	for (const line of lines) {
-		const headingMatch = line.match(HEADING_REGEX);
-		if (headingMatch) {
-			if (currentHeading) {
-				sections.set(currentHeading, currentLines.join("\n").trim());
-			}
-			currentHeading = headingMatch[1]?.trim().toLowerCase() ?? null;
-			currentLines = [];
-			continue;
-		}
-		if (currentHeading) {
-			currentLines.push(line);
-		}
-	}
-
-	if (currentHeading) {
-		sections.set(currentHeading, currentLines.join("\n").trim());
-	}
-	return sections;
-}
-
-function parseBenchmarkSection(section: string): AutoresearchBenchmarkContract {
-	const entries = new Map<string, string>();
-	const lines = section.split("\n");
-	for (let index = 0; index < lines.length; index += 1) {
-		const rawLine = lines[index] ?? "";
-		const match = rawLine.match(KEY_VALUE_REGEX);
-		if (!match) continue;
-		const key = normalizeKey(match[1] ?? "");
-		let value = (match[2] ?? "").trim();
-		if (key === "secondarymetrics") {
-			const nestedItems: string[] = [];
-			for (let nestedIndex = index + 1; nestedIndex < lines.length; nestedIndex += 1) {
-				const nestedLine = lines[nestedIndex] ?? "";
-				if (nestedLine.match(KEY_VALUE_REGEX)) break;
-				const nestedMatch = nestedLine.match(/^\s{2,}[-*]\s+(.*)$/);
-				if (!nestedMatch) {
-					if (nestedLine.trim().length > 0) break;
-					continue;
-				}
-				nestedItems.push((nestedMatch[1] ?? "").trim());
-				index = nestedIndex;
-			}
-			if (nestedItems.length > 0) {
-				value = [value, ...nestedItems].filter(Boolean).join(", ");
-			}
-		}
-		entries.set(key, value);
-	}
-
-	const direction = parseDirection(entries.get("direction"));
-	return {
-		command: readNullableEntry(entries.get("command")),
-		primaryMetric: readNullableEntry(entries.get("primarymetric")),
-		metricUnit: entries.get("metricunit")?.trim() ?? "",
-		direction,
-		secondaryMetrics: parseSecondaryMetrics(entries.get("secondarymetrics")),
-	};
-}
-
-function parseListSection(section: string, normalizeItem?: (value: string) => string): string[] {
-	const items: string[] = [];
-	let activeItem: string | null = null;
-	for (const rawLine of section.split("\n")) {
-		const line = rawLine.trimEnd();
-		if (line.trim().length === 0) continue;
-		const match = rawLine.match(LIST_ITEM_REGEX);
-		if (match) {
-			if (activeItem) items.push(activeItem);
-			activeItem = (match[1] ?? "").trim();
-			continue;
-		}
-		if (activeItem && /^\s{2,}\S/.test(rawLine)) {
-			activeItem = `${activeItem} ${line.trim()}`;
-			continue;
-		}
-		if (activeItem) {
-			items.push(activeItem);
-			activeItem = null;
-		}
-		items.push(line.trim());
-	}
-	if (activeItem) {
-		items.push(activeItem);
-	}
-	const normalizedItems = normalizeAutoresearchList(items);
-	return normalizeItem ? normalizedItems.map(normalizeItem) : normalizedItems;
-}
-
-function normalizeKey(value: string): string {
-	return value.toLowerCase().replace(/[^a-z0-9]+/g, "");
-}
-
-function parseDirection(value: string | undefined): MetricDirection | null {
-	if (value === "lower" || value === "higher") return value;
-	return null;
-}
-
-function readNullableEntry(value: string | undefined): string | null {
-	const trimmed = value?.trim() ?? "";
-	return trimmed.length > 0 ? trimmed : null;
-}
-
-function parseSecondaryMetrics(value: string | undefined): string[] {
-	if (!value) return [];
-	return normalizeAutoresearchList(
-		value
-			.split(",")
-			.map(entry => entry.trim())
-			.filter(Boolean),
-	);
-}
-
-function isUnsafeContractPathSpec(value: string): boolean {
-	return path.posix.isAbsolute(value) || value === ".." || value.startsWith("../");
-}

package/src/edit/modes/atom.lark

@@ -1,29 +0,0 @@
-%import common.LF
-
-start: file_section+
-
-file_section: file_header (line_change | whole_file_change)
-file_header: "---" filename LF
-
-filename: /(.+)/
-
-line_change: line* mutation_line line*
-line: insert_line | delete_line | set_block | move_line | blank
-mutation_line: insert_line | delete_line | set_block
-
-whole_file_change: blank* whole_file_line blank*
-whole_file_line: remove_file | move_file
-remove_file: "!rm" LF
-move_file: "!mv" WS destination LF
-destination: /(?:[^ \t\r\n]+|"[^"\r\n]+"|'[^'\r\n]+')/
-
-insert_line: "+" /(.*)/ LF
-delete_line: "-" (LID ".." LID | LID) LF
-set_line: (LID ".." LID | LID) WS? "=" /(.*)/ LF
-set_block: set_line continuation_line*
-continuation_line: "\\" /(.*)/ LF
-move_line: ("@" LID | "^" LID | "^" | "$") LF
-
-LID: /[1-9][0-9]*[a-z]{2}/
-WS: /[ \t]+/
-blank: LF