@oh-my-pi/pi-coding-agent 14.5.12 → 14.5.14

package/src/tools/browser.ts

@@ -4,18 +4,9 @@ import { prompt, untilAborted } from "@oh-my-pi/pi-utils";
 import { type Static, Type } from "@sinclair/typebox";
 import browserDescription from "../prompts/tools/browser.md" with { type: "text" };
 import type { ToolSession } from "../sdk";
-import {
-	acquireBrowser,
-	acquireTab,
-	type BrowserHandle,
-	type BrowserKind,
-	type BrowserKindTag,
-	dropHeadlessBrowsers,
-	getTab,
-	releaseAllTabs,
-	releaseTab,
-} from "./browser/registry";
-import { collectObservation, formatObservation, type Observation, runInTab, type ScreenshotResult } from "./browser/vm";
+import { acquireBrowser, type BrowserHandle, type BrowserKind, type BrowserKindTag } from "./browser/registry";
+import type { Observation, ScreenshotResult } from "./browser/tab-protocol";
+import { acquireTab, dropHeadlessTabs, getTab, releaseAllTabs, releaseTab, runInTab } from "./browser/tab-supervisor";
 import type { OutputMeta } from "./output-meta";
 import { resolveToCwd } from "./path-utils";
 import { ToolAbortError, ToolError, throwIfAborted } from "./tool-errors";
@@ -23,7 +14,7 @@ import { toolResult } from "./tool-result";
 import { clampTimeout } from "./tool-timeouts";
 
 export { extractReadableFromHtml, type ReadableFormat, type ReadableResult } from "./browser/readable";
-export type { Observation, ObservationEntry } from "./browser/vm";
+export type { Observation, ObservationEntry } from "./browser/tab-protocol";
 
 const DEFAULT_TAB_NAME = "main";
 
@@ -119,17 +110,19 @@ function resolveBrowserKind(params: BrowserParams, session: ToolSession): Browse
 export class BrowserTool implements AgentTool<typeof browserSchema, BrowserToolDetails> {
 	readonly name = "browser";
 	readonly label = "Browser";
-	readonly description: string;
 	readonly parameters = browserSchema;
 	readonly strict = true;
 
-	constructor(private readonly session: ToolSession) {
-		this.description = prompt.render(browserDescription, {});
+	constructor(private readonly session: ToolSession) {}
+	#description?: string;
+	get description(): string {
+		this.#description ??= prompt.render(browserDescription, {});
+		return this.#description;
 	}
 
 	/** Restart browser to apply mode changes (e.g. headless toggle). Drops only headless browsers. */
 	async restartForModeChange(): Promise<void> {
-		await dropHeadlessBrowsers();
+		await dropHeadlessTabs();
 	}
 
 	async execute(
@@ -216,10 +209,10 @@ export class BrowserTool implements AgentTool<typeof browserSchema, BrowserToolD
 			}),
 		);
 		const tab = result.tab;
-		const url = tab.page.url();
-		const title = (await untilAborted(signal, () => tab.page.title())) as string;
+		const url = tab.info.url;
+		const title = tab.info.title ?? "";
 		details.url = url;
-		details.viewport = tab.page.viewport() ?? undefined;
+		details.viewport = tab.info.viewport;
 		const verb = result.created ? "Opened" : "Reused";
 		const lines = [
 			`${verb} tab ${JSON.stringify(name)} on ${describeBrowser(browser)}`,
@@ -258,16 +251,12 @@ export class BrowserTool implements AgentTool<typeof browserSchema, BrowserToolD
 			throw new ToolError("Missing required parameter 'code' for action 'run'.");
 		}
 		const tab = getTab(name);
-		if (!tab) {
-			throw new ToolError(
-				`No tab named ${JSON.stringify(name)}. Call open first (e.g. action: 'open', name: '${name}').`,
-			);
+		if (tab) {
+			details.browser = tab.browser.kind.kind;
+			details.url = tab.info.url;
 		}
-		details.browser = tab.browser.kind.kind;
-		details.url = tab.page.url();
 
-		const { displays, returnValue, screenshots } = await runInTab({
-			tab,
+		const { displays, returnValue, screenshots } = await runInTab(name, {
 			code: params.code,
 			timeoutMs,
 			signal,
@@ -330,7 +319,3 @@ function stringifyReturnValue(value: unknown): string {
 		return String(value);
 	}
 }
-
-// Re-export collectObservation so external callers (e.g. tests) can use it without
-// reaching into the browser/ subdirectory.
-export { collectObservation, formatObservation };

package/src/tools/checkpoint.ts

@@ -52,7 +52,7 @@ export class CheckpointTool implements AgentTool<typeof checkpointSchema, Checkp
 	readonly description: string;
 	readonly parameters = checkpointSchema;
 	readonly strict = true;
-	readonly intent = (args: Partial<CheckpointParams>) => args.goal;
+	readonly intent = (args: Partial<CheckpointParams>) => (args.goal ? `checkpointing: ${args.goal}` : "checkpointing");
 
 	constructor(private readonly session: ToolSession) {
 		this.description = prompt.render(checkpointDescription);
@@ -95,7 +95,7 @@ export class RewindTool implements AgentTool<typeof rewindSchema, RewindToolDeta
 	readonly description: string;
 	readonly parameters = rewindSchema;
 	readonly strict = true;
-	readonly intent = (): string => "Rewinding to checkpoint";
+	readonly intent = (): string => "rewinding";
 
 	constructor(private readonly session: ToolSession) {
 		this.description = prompt.render(rewindDescription);