@oh-my-pi/pi-coding-agent 14.1.2 → 14.2.1

package/src/modes/print-mode.ts

@@ -7,6 +7,7 @@
  */
 import type { AssistantMessage, ImageContent } from "@oh-my-pi/pi-ai";
 import { sanitizeText } from "@oh-my-pi/pi-natives";
+import { runExtensionCompact, runExtensionSetModel } from "../extensibility/extensions/compact-handler";
 import type { AgentSession } from "../session/agent-session";
 
 /**
@@ -65,12 +66,7 @@ export async function runPrintMode(session: AgentSession, options: PrintModeOpti
 				getAllTools: () => session.getAllToolNames(),
 				setActiveTools: (toolNames: string[]) => session.setActiveToolsByName(toolNames),
 				getCommands: () => [],
-				setModel: async model => {
-					const key = await session.modelRegistry.getApiKey(model);
-					if (!key) return false;
-					await session.setModel(model);
-					return true;
-				},
+				setModel: model => runExtensionSetModel(session, model),
 				getThinkingLevel: () => session.thinkingLevel,
 				setThinkingLevel: level => session.setThinkingLevel(level),
 				getSessionName: () => session.sessionManager.getSessionName(),
@@ -87,14 +83,7 @@ export async function runPrintMode(session: AgentSession, options: PrintModeOpti
 				shutdown: () => {},
 				getContextUsage: () => session.getContextUsage(),
 				getSystemPrompt: () => session.systemPrompt,
-				compact: async instructionsOrOptions => {
-					const instructions = typeof instructionsOrOptions === "string" ? instructionsOrOptions : undefined;
-					const options =
-						instructionsOrOptions && typeof instructionsOrOptions === "object"
-							? instructionsOrOptions
-							: undefined;
-					await session.compact(instructions, options);
-				},
+				compact: instructionsOrOptions => runExtensionCompact(session, instructionsOrOptions),
 			},
 			// ExtensionCommandContextActions - commands invokable via prompt("/command")
 			{
@@ -122,14 +111,7 @@ export async function runPrintMode(session: AgentSession, options: PrintModeOpti
 				reload: async () => {
 					await session.reload();
 				},
-				compact: async instructionsOrOptions => {
-					const instructions = typeof instructionsOrOptions === "string" ? instructionsOrOptions : undefined;
-					const options =
-						instructionsOrOptions && typeof instructionsOrOptions === "object"
-							? instructionsOrOptions
-							: undefined;
-					await session.compact(instructions, options);
-				},
+				compact: instructionsOrOptions => runExtensionCompact(session, instructionsOrOptions),
 			},
 			// No UI context
 		);

package/src/modes/rpc/rpc-mode.ts

@@ -16,6 +16,7 @@ import type {
 	ExtensionUIDialogOptions,
 	ExtensionWidgetOptions,
 } from "../../extensibility/extensions";
+import { runExtensionCompact, runExtensionSetModel } from "../../extensibility/extensions/compact-handler";
 import { type Theme, theme } from "../../modes/theme/theme";
 import type { AgentSession } from "../../session/agent-session";
 import { isRpcHostToolResult, isRpcHostToolUpdate, RpcHostToolBridge } from "./host-tools";
@@ -66,6 +67,18 @@ function normalizeHostToolDefinitions(tools: RpcHostToolDefinition[]): RpcHostTo
 	});
 }
 
+function parseValueDialogResponse(
+	response: RpcExtensionUIResponse,
+	dialogOptions: ExtensionUIDialogOptions | undefined,
+): string | undefined {
+	if ("cancelled" in response && response.cancelled) {
+		if (response.timedOut) dialogOptions?.onTimeout?.();
+		return undefined;
+	}
+	if ("value" in response) return response.value;
+	return undefined;
+}
+
 function shouldEmitRpcTitles(): boolean {
 	const raw = $env.PI_RPC_EMIT_TITLE;
 	if (!raw) return false;
@@ -228,14 +241,7 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 				dialogOptions,
 				undefined,
 				{ method: "select", title, options, timeout: dialogOptions?.timeout },
-				response => {
-					if ("cancelled" in response && response.cancelled) {
-						if (response.timedOut) dialogOptions?.onTimeout?.();
-						return undefined;
-					}
-					if ("value" in response) return response.value;
-					return undefined;
-				},
+				response => parseValueDialogResponse(response, dialogOptions),
 			);
 		}
 
@@ -264,14 +270,7 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 				dialogOptions,
 				undefined,
 				{ method: "input", title, placeholder, timeout: dialogOptions?.timeout },
-				response => {
-					if ("cancelled" in response && response.cancelled) {
-						if (response.timedOut) dialogOptions?.onTimeout?.();
-						return undefined;
-					}
-					if ("value" in response) return response.value;
-					return undefined;
-				},
+				response => parseValueDialogResponse(response, dialogOptions),
 			);
 		}
 
@@ -432,12 +431,7 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 				getAllTools: () => session.getAllToolNames(),
 				setActiveTools: (toolNames: string[]) => session.setActiveToolsByName(toolNames),
 				getCommands: () => [],
-				setModel: async model => {
-					const key = await session.modelRegistry.getApiKey(model);
-					if (!key) return false;
-					await session.setModel(model);
-					return true;
-				},
+				setModel: model => runExtensionSetModel(session, model),
 				getThinkingLevel: () => session.thinkingLevel,
 				setThinkingLevel: level => session.setThinkingLevel(level),
 				getSessionName: () => session.sessionManager.getSessionName(),
@@ -456,14 +450,7 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 				},
 				getContextUsage: () => session.getContextUsage(),
 				getSystemPrompt: () => session.systemPrompt,
-				compact: async instructionsOrOptions => {
-					const instructions = typeof instructionsOrOptions === "string" ? instructionsOrOptions : undefined;
-					const options =
-						instructionsOrOptions && typeof instructionsOrOptions === "object"
-							? instructionsOrOptions
-							: undefined;
-					await session.compact(instructions, options);
-				},
+				compact: instructionsOrOptions => runExtensionCompact(session, instructionsOrOptions),
 			},
 			// ExtensionCommandContextActions - commands invokable via prompt("/command")
 			{
@@ -492,14 +479,7 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 				reload: async () => {
 					await session.reload();
 				},
-				compact: async instructionsOrOptions => {
-					const instructions = typeof instructionsOrOptions === "string" ? instructionsOrOptions : undefined;
-					const options =
-						instructionsOrOptions && typeof instructionsOrOptions === "object"
-							? instructionsOrOptions
-							: undefined;
-					await session.compact(instructions, options);
-				},
+				compact: instructionsOrOptions => runExtensionCompact(session, instructionsOrOptions),
 			},
 			new RpcExtensionUIContext(pendingExtensionRequests, output),
 		);

package/src/modes/shared.ts

@@ -5,9 +5,18 @@ import { theme } from "./theme/theme";
 // Text Sanitization
 // ═══════════════════════════════════════════════════════════════════════════
 
-/** Sanitize text for display in a single-line status. Strips C0/C1 control characters (including ANSI ESC), collapses whitespace, trims. */
+const ANSI_OSC_RE = /\x1b\][^\x07\x1b]*(?:\x07|\x1b\\)|\x9d[^\x07\x9c]*(?:\x07|\x9c)/g;
+const ANSI_STRING_RE = /\x1b(?:P|_|\^)[\s\S]*?\x1b\\|[\x90\x9e\x9f][\s\S]*?\x9c/g;
+const ANSI_CSI_RE = /\x1b\[[0-?]*[ -/]*[@-~]|\x9b[0-?]*[ -/]*[@-~]/g;
+const ANSI_SINGLE_RE = /\x1b[@-Z\\-_]/g;
+
+/** Sanitize text for display in a single-line status. Strips ANSI escape sequences, C0/C1 control characters, collapses whitespace, trims. */
 export function sanitizeStatusText(text: string): string {
 	return text
+		.replace(ANSI_OSC_RE, "")
+		.replace(ANSI_STRING_RE, "")
+		.replace(ANSI_CSI_RE, "")
+		.replace(ANSI_SINGLE_RE, "")
 		.replace(/[\u0000-\u001f\u007f-\u009f]/g, " ")
 		.replace(/ +/g, " ")
 		.trim();

package/src/modes/utils/ui-helpers.ts

@@ -257,7 +257,9 @@ export class UiHelpers {
 					if (content.name === "read") {
 						if (hasErrorStop && errorMessage) {
 							if (!readGroup) {
-								readGroup = new ReadToolGroupComponent();
+								readGroup = new ReadToolGroupComponent({
+									showContentPreview: this.ctx.settings.get("read.toolResultPreview"),
+								});
 								readGroup.setExpanded(this.ctx.toolOutputExpanded);
 								this.ctx.chatContainer.addChild(readGroup);
 							}
@@ -330,7 +332,9 @@ export class UiHelpers {
 					let component = this.ctx.pendingTools.get(message.toolCallId);
 					if (!component) {
 						if (!readGroup) {
-							readGroup = new ReadToolGroupComponent();
+							readGroup = new ReadToolGroupComponent({
+								showContentPreview: this.ctx.settings.get("read.toolResultPreview"),
+							});
 							readGroup.setExpanded(this.ctx.toolOutputExpanded);
 							this.ctx.chatContainer.addChild(readGroup);
 						}

package/src/plan-mode/approved-plan.ts

@@ -1,6 +1,7 @@
 import * as fs from "node:fs/promises";
 import { isEnoent } from "@oh-my-pi/pi-utils";
 import { resolveLocalUrlToPath } from "../internal-urls";
+import { normalizeLocalScheme } from "../tools/path-utils";
 
 interface RenameApprovedPlanFileOptions {
 	planFilePath: string;
@@ -10,8 +11,8 @@ interface RenameApprovedPlanFileOptions {
 }
 
 function assertLocalUrl(path: string, label: "source" | "destination"): void {
-	if (!path.startsWith("local://")) {
-		throw new Error(`Approved plan ${label} path must use local:// (received ${path}).`);
+	if (!path.startsWith("local:/") && !path.startsWith("local://")) {
+		throw new Error(`Approved plan ${label} path must use local: scheme with / or // (received ${path}).`);
 	}
 }
 
@@ -24,8 +25,8 @@ export async function renameApprovedPlanFile(options: RenameApprovedPlanFileOpti
 		getArtifactsDir: () => getArtifactsDir(),
 		getSessionId: () => getSessionId(),
 	};
-	const resolvedSource = resolveLocalUrlToPath(planFilePath, resolveOptions);
-	const resolvedDestination = resolveLocalUrlToPath(finalPlanFilePath, resolveOptions);
+	const resolvedSource = resolveLocalUrlToPath(normalizeLocalScheme(planFilePath), resolveOptions);
+	const resolvedDestination = resolveLocalUrlToPath(normalizeLocalScheme(finalPlanFilePath), resolveOptions);
 
 	if (resolvedSource === resolvedDestination) {
 		return;

package/src/prompts/system/subagent-system-prompt.md

@@ -1,9 +1,9 @@
 {{base}}
 
-{{SECTION_SEPERATOR "Acting as"}}
+{{SECTION_SEPARATOR "Acting as"}}
 {{agent}}
 
-{{SECTION_SEPERATOR "Job"}}
+{{SECTION_SEPARATOR "Job"}}
 You are operating on a delegated sub-task.
 {{#if worktree}}
 You are working in an isolated working tree at `{{worktree}}` for this sub-task.
@@ -14,7 +14,7 @@ You **MUST NOT** modify files outside this tree or in the original repository.
 If you need additional information, you can find your conversation with the user in {{contextFile}} (`tail` or `grep` relevant terms).
 {{/if}}
 
-{{SECTION_SEPERATOR "Closure"}}
+{{SECTION_SEPARATOR "Closure"}}
 No TODO tracking, no progress updates. Execute, call `submit_result`, done.
 
 When finished, you **MUST** call `submit_result` exactly once. This is like writing to a ticket, provide what is required, and close it.
@@ -28,7 +28,7 @@ Your result **MUST** match this TypeScript interface:
 ```
 {{/if}}
 
-{{SECTION_SEPERATOR "Giving Up"}}
+{{SECTION_SEPARATOR "Giving Up"}}
 Giving up is a last resort. If truly blocked, you **MUST** call `submit_result` exactly once with `result.error` describing what you tried and the exact blocker.
 You **MUST NOT** give up due to uncertainty, missing information obtainable via tools or repo context, or needing a design decision you can derive yourself.
 

package/src/prompts/system/subagent-user-prompt.md

@@ -1,11 +1,11 @@
 {{#if context}}
-{{SECTION_SEPERATOR "Background"}}
+{{SECTION_SEPARATOR "Background"}}
 <context>
 {{context}}
 </context>
 {{/if}}
 
-{{SECTION_SEPERATOR "Task"}}
+{{SECTION_SEPARATOR "Task"}}
 Your assignment is below. Your work begins now.
 <goal>
 {{assignment}}