@oh-my-pi/pi-coding-agent 14.0.2 → 14.0.3

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [14.0.3] - 2026-04-09
+
+### Fixed
+
+- Fixed cached Ollama discovery rows so upgraded installs switch to the OpenAI Responses transport instead of staying on the old completions transport
+
 ## [14.0.2] - 2026-04-09
 ### Added
 
@@ -258,6 +264,10 @@
 - `/autoresearch` toggles like `/plan` when empty; slash completion no longer suggests `off`/`clear` on an empty prefix after the command
 - Chunk-mode read/edit edge cases (zero-width gap replaces, stale batch diagnostics, grouped Go receivers, line-count headers, parse error locations)
 
+### Added
+
+- `/review` command now accepts inline args as custom instructions appended to the generated prompt for all structured review modes (PR-style, uncommitted, specific commit). When inline args are provided, option 4 (editor) is suppressed from the menu. The no-UI (Task tool) path forwards args as a focus hint.
+
 ## [13.19.0] - 2026-04-05
 
 ### Added
@@ -6890,4 +6900,4 @@ Initial public release.
 - Git branch display in footer
 - Message queueing during streaming responses
 - OAuth integration for Gmail and Google Calendar access
-- HTML export with syntax highlighting and collapsible sections
+- HTML export with syntax highlighting and collapsible sections

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "14.0.2",
+	"version": "14.0.3",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://github.com/can1357/oh-my-pi",
 	"author": "Can Boluk",
@@ -46,12 +46,12 @@
 	"dependencies": {
 		"@agentclientprotocol/sdk": "0.16.1",
 		"@mozilla/readability": "^0.6",
-		"@oh-my-pi/omp-stats": "14.0.2",
-		"@oh-my-pi/pi-agent-core": "14.0.2",
-		"@oh-my-pi/pi-ai": "14.0.2",
-		"@oh-my-pi/pi-natives": "14.0.2",
-		"@oh-my-pi/pi-tui": "14.0.2",
-		"@oh-my-pi/pi-utils": "14.0.2",
+		"@oh-my-pi/omp-stats": "14.0.3",
+		"@oh-my-pi/pi-agent-core": "14.0.3",
+		"@oh-my-pi/pi-ai": "14.0.3",
+		"@oh-my-pi/pi-natives": "14.0.3",
+		"@oh-my-pi/pi-tui": "14.0.3",
+		"@oh-my-pi/pi-utils": "14.0.3",
 		"@sinclair/typebox": "^0.34",
 		"@xterm/headless": "^6.0",
 		"ajv": "^8.18",

package/src/config/model-registry.ts

@@ -947,7 +947,10 @@ export class ModelRegistry {
 			}
 			const models = this.#applyProviderModelOverrides(
 				providerConfig.provider,
-				this.#applyProviderCompat(providerConfig.compat, cache.models),
+				this.#normalizeDiscoverableModels(
+					providerConfig,
+					this.#applyProviderCompat(providerConfig.compat, cache.models),
+				),
 			);
 			cachedModels.push(...models);
 			this.#providerDiscoveryStates.set(providerConfig.provider, {
@@ -967,11 +970,19 @@ export class ModelRegistry {
 		return models.map(model => ({ ...model, compat: mergeCompat(model.compat, compat) }));
 	}
 
+	#normalizeDiscoverableModels(providerConfig: DiscoveryProviderConfig, models: Model<Api>[]): Model<Api>[] {
+		if (providerConfig.provider !== "ollama" || providerConfig.api !== "openai-responses") {
+			return models;
+		}
+
+		return models.map(model => (model.api === "openai-completions" ? { ...model, api: "openai-responses" } : model));
+	}
+
 	#addImplicitDiscoverableProviders(configuredProviders: Set<string>): void {
 		if (!configuredProviders.has("ollama")) {
 			this.#discoverableProviders.push({
 				provider: "ollama",
-				api: "openai-completions",
+				api: "openai-responses",
 				baseUrl: Bun.env.OLLAMA_BASE_URL || "http://127.0.0.1:11434",
 				discovery: { type: "ollama" },
 				optional: true,
@@ -1203,7 +1214,10 @@ export class ModelRegistry {
 		}
 		return this.#applyProviderModelOverrides(
 			providerId,
-			this.#applyProviderCompat(providerConfig.compat, result.models),
+			this.#normalizeDiscoverableModels(
+				providerConfig,
+				this.#applyProviderCompat(providerConfig.compat, result.models),
+			),
 		);
 	}
 

package/src/edit/modes/chunk.ts

@@ -312,7 +312,7 @@ export const chunkToolEditSchema = Type.Object({
 			"Chunk selector. Format: 'path@region' for insertions, 'path#CRC@region' for replace. Omit @region to target the full chunk. Valid regions: head, body, tail, decl.",
 	}),
 	content: Type.String({
-		description: "New content. Use one leading space per indent level; do not include the chunk's base padding.",
+		description: "New content. Use \\t for indentation. Do NOT include the chunk's base padding.",
 	}),
 });
 export const chunkEditParamsSchema = Type.Object(

package/src/extensibility/custom-commands/bundled/review/index.ts

@@ -197,7 +197,7 @@ const MAX_FILES_FOR_INLINE_DIFF = 20; // Don't include diff if more files than t
 /**
  * Build the full review prompt with diff stats and distribution guidance.
  */
-function buildReviewPrompt(mode: string, stats: DiffStats, rawDiff: string): string {
+function buildReviewPrompt(mode: string, stats: DiffStats, rawDiff: string, additionalInstructions?: string): string {
 	const agentCount = getRecommendedAgentCount(stats);
 	const skipDiff = rawDiff.length > MAX_DIFF_CHARS || stats.files.length > MAX_FILES_FOR_INLINE_DIFF;
 	const totalLines = stats.totalAdded + stats.totalRemoved;
@@ -221,6 +221,7 @@ function buildReviewPrompt(mode: string, stats: DiffStats, rawDiff: string): str
 		skipDiff,
 		rawDiff: rawDiff.trim(),
 		linesPerFile,
+		additionalInstructions,
 	});
 }
 
@@ -230,17 +231,30 @@ export class ReviewCommand implements CustomCommand {
 
 	constructor(private api: CustomCommandAPI) {}
 
-	async execute(_args: string[], ctx: HookCommandContext): Promise<string | undefined> {
+	async execute(args: string[], ctx: HookCommandContext): Promise<string | undefined> {
 		if (!ctx.hasUI) {
-			return "Use the Task tool to run the 'reviewer' agent to review recent code changes.";
+			const base = "Use the Task tool to run the 'reviewer' agent to review recent code changes.";
+			return args.length > 0 ? `${base} Focus: ${args.join(" ")}` : base;
 		}
 
-		const mode = await ctx.ui.select("Review Mode", [
-			"1. Review against a base branch (PR Style)",
-			"2. Review uncommitted changes",
-			"3. Review a specific commit",
-			"4. Custom review instructions",
-		]);
+		// Inline args act as additional instructions appended to the generated prompt.
+		// When present, skip option 4 (editor) — the args already provide the instructions.
+		const extraInstructions = args.length > 0 ? args.join(" ") : undefined;
+
+		const menuItems = extraInstructions
+			? [
+					"1. Review against a base branch (PR Style)",
+					"2. Review uncommitted changes",
+					"3. Review a specific commit",
+				]
+			: [
+					"1. Review against a base branch (PR Style)",
+					"2. Review uncommitted changes",
+					"3. Review a specific commit",
+					"4. Custom review instructions",
+				];
+
+		const mode = await ctx.ui.select("Review Mode", menuItems);
 
 		if (!mode) return undefined;
 
@@ -282,6 +296,7 @@ export class ReviewCommand implements CustomCommand {
 					`Reviewing changes between \`${baseBranch}\` and \`${currentBranch}\` (PR-style)`,
 					stats,
 					diffText,
+					extraInstructions,
 				);
 			}
 
@@ -318,7 +333,12 @@ export class ReviewCommand implements CustomCommand {
 					return undefined;
 				}
 
-				return buildReviewPrompt("Reviewing uncommitted changes (staged + unstaged)", stats, combinedDiff);
+				return buildReviewPrompt(
+					"Reviewing uncommitted changes (staged + unstaged)",
+					stats,
+					combinedDiff,
+					extraInstructions,
+				);
 			}
 
 			case 3: {
@@ -354,7 +374,7 @@ export class ReviewCommand implements CustomCommand {
 					return undefined;
 				}
 
-				return buildReviewPrompt(`Reviewing commit \`${hash}\``, stats, diffText);
+				return buildReviewPrompt(`Reviewing commit \`${hash}\``, stats, diffText, extraInstructions);
 			}
 
 			case 4: {
@@ -374,11 +394,12 @@ export class ReviewCommand implements CustomCommand {
 				if (reviewDiff) {
 					const stats = parseDiff(reviewDiff);
 					// Even if all files filtered, include the custom instructions
-					return `${buildReviewPrompt(
+					return buildReviewPrompt(
 						`Custom review: ${instructions.split("\n")[0].slice(0, 60)}…`,
 						stats,
 						reviewDiff,
-					)}\n\n### Additional Instructions\n\n${instructions}`;
+						instructions,
+					);
 				}
 
 				// No diff available, just pass instructions

package/src/lsp/config.ts

@@ -197,6 +197,21 @@ const LOCAL_BIN_PATHS: Array<{ markers: string[]; binDir: string }> = [
 	{ markers: ["go.mod", "go.sum"], binDir: "bin" },
 ];
 
+const WINDOWS_LOCAL_EXECUTABLE_EXTENSIONS = [".exe", ".cmd", ".bat"] as const;
+
+function resolveLocalCommand(basePath: string): string | null {
+	if (fs.existsSync(basePath)) return basePath;
+	if (process.platform !== "win32") return null;
+
+	// Package managers write Windows launchers with executable suffixes in node_modules/.bin.
+	for (const extension of WINDOWS_LOCAL_EXECUTABLE_EXTENSIONS) {
+		const candidate = `${basePath}${extension}`;
+		if (fs.existsSync(candidate)) return candidate;
+	}
+
+	return null;
+}
+
 /**
  * Resolve a command to an executable path.
  * Checks project-local bin directories first, then falls back to $PATH.
@@ -210,8 +225,9 @@ export function resolveCommand(command: string, cwd: string): string | null {
 	for (const { markers, binDir } of LOCAL_BIN_PATHS) {
 		if (hasRootMarkers(cwd, markers)) {
 			const localPath = path.join(cwd, binDir, command);
-			if (fs.existsSync(localPath)) {
-				return localPath;
+			const resolvedLocalPath = resolveLocalCommand(localPath);
+			if (resolvedLocalPath) {
+				return resolvedLocalPath;
 			}
 		}
 	}

package/src/modes/components/session-observer-overlay.ts

@@ -43,6 +43,8 @@ export class SessionObserverOverlayComponent extends Container {
 	#observeKeys: KeyId[];
 	/** Cached parsed transcript per session file to avoid reparsing on every refresh */
 	#transcriptCache?: { path: string; bytesRead: number; entries: SessionMessageEntry[] };
+	/** Live stats text component, placed after transcript to avoid above-viewport diffs */
+	#statsText?: Text;
 
 	constructor(registry: SessionObserverRegistry, onDone: () => void, observeKeys: KeyId[]) {
 		super();
@@ -87,11 +89,13 @@ export class SessionObserverOverlayComponent extends Container {
 		this.#mode = "viewer";
 		this.children = [];
 		this.#viewerContainer = new Container();
+		this.#statsText = new Text("", 1, 0);
 		this.#refreshViewer();
 
 		this.addChild(new DynamicBorder());
 		this.addChild(this.#viewerContainer);
 		this.addChild(new Spacer(1));
+		this.addChild(this.#statsText);
 		this.addChild(new Text(theme.fg("dim", "Esc: back to picker  |  Ctrl+S: back to picker"), 1, 0));
 		this.addChild(new DynamicBorder());
 	}
@@ -133,16 +137,17 @@ export class SessionObserverOverlayComponent extends Container {
 		const session = sessions.find(s => s.id === this.#selectedSessionId);
 		if (!session) {
 			this.#viewerContainer.addChild(new Text(theme.fg("dim", "Session no longer available."), 1, 0));
+			this.#updateStats(undefined);
 			return;
 		}
 
 		this.#renderSessionHeader(session);
 		this.#renderSessionTranscript(session);
+		this.#updateStats(session);
 	}
 
 	#renderSessionHeader(session: ObservableSession): void {
 		const c = this.#viewerContainer;
-		const progress = session.progress;
 
 		// Header: label + status + [agent]
 		const statusColor = session.status === "active" ? "success" : session.status === "failed" ? "error" : "dim";
@@ -154,17 +159,6 @@ export class SessionObserverOverlayComponent extends Container {
 			c.addChild(new Text(theme.fg("muted", session.description), 1, 0));
 		}
 
-		// Stats from progress
-		if (progress) {
-			const stats: string[] = [];
-			if (progress.toolCount > 0) stats.push(`${formatNumber(progress.toolCount)} tools`);
-			if (progress.tokens > 0) stats.push(`${formatNumber(progress.tokens)} tokens`);
-			if (progress.durationMs > 0) stats.push(formatDuration(progress.durationMs));
-			if (stats.length > 0) {
-				c.addChild(new Text(theme.fg("dim", stats.join(theme.sep.dot)), 1, 0));
-			}
-		}
-
 		if (session.sessionFile) {
 			c.addChild(new Text(theme.fg("dim", `Session: ${shortenPath(session.sessionFile)}`), 1, 0));
 		}
@@ -172,6 +166,21 @@ export class SessionObserverOverlayComponent extends Container {
 		c.addChild(new DynamicBorder());
 	}
 
+	/** Update live stats in-place (below transcript, within viewport). */
+	#updateStats(session: ObservableSession | undefined): void {
+		if (!this.#statsText) return;
+		const progress = session?.progress;
+		if (!progress) {
+			this.#statsText.setText("");
+			return;
+		}
+		const stats: string[] = [];
+		if (progress.toolCount > 0) stats.push(`${formatNumber(progress.toolCount)} tools`);
+		if (progress.tokens > 0) stats.push(`${formatNumber(progress.tokens)} tokens`);
+		if (progress.durationMs > 0) stats.push(formatDuration(progress.durationMs));
+		this.#statsText.setText(stats.length > 0 ? theme.fg("dim", stats.join(theme.sep.dot)) : "");
+	}
+
 	/** Incrementally read and parse the session JSONL, caching already-parsed entries. */
 	#loadTranscript(sessionFile: string): SessionMessageEntry[] | null {
 		// Invalidate cache if session file changed (e.g. switched to different subagent)

package/src/prompts/review-request.md

@@ -62,3 +62,9 @@ _Full diff too large ({{len files}} files). Showing first ~{{linesPerFile}} line
 {{rawDiff}}
 </diff>
 {{/if}}
+
+{{#if additionalInstructions}}
+### Additional Instructions
+
+{{additionalInstructions}}
+{{/if}}

package/src/prompts/tools/chunk-edit.md

@@ -7,9 +7,9 @@ Edits files via syntax-aware chunks. Run `read(path="file.ts")` first. The edit
   - replacements: `chunk#CRC` or `chunk#CRC@region`
 - Without a `@region` it defaults to the entire chunk including leading trivia. Valid regions: `head`, `body`, `tail`, `decl`.
 - If the exact chunk path is unclear, run `read(path="file", sel="?")` and copy a selector from that listing.
-- Use a single leading space per indent level in `content`. Write content at indent-level 0 — the tool re-indents it to match the chunk's position in the file. For example, to replace `@body` of a method, write the body starting at column 0:
+- Use `\t` for indentation in `content`. Write content at indent-level 0 — the tool re-indents it to match the chunk's position in the file. For example, to replace `@body` of a method, write the body starting at column 0:
   ```
-  content: "if (x) {\n return true;\n}"
+  content: "if (x) {\n\treturn true;\n}"
   ```
   The tool adds the correct base indent automatically. Never manually pad with the chunk's own indentation.
 - `@region` only works on container chunks (classes, functions, impl blocks, sections). Do **not** use `@head`/`@body`/`@tail` on leaf chunks (enum variants, fields, single statements) — use the whole chunk instead.
@@ -19,6 +19,10 @@ Edits files via syntax-aware chunks. Run `read(path="file.ts")` first. The edit
 
 <critical>
 You **MUST** use the narrowest region that covers your change. Replacing without a region replaces the **entire chunk including leading comments, decorators, and attributes** — omitting them from `content` deletes them.
+
+**`replace` is total, not surgical.** The `content` you supply becomes the *complete* new content for the targeted region. Everything in the original region that you omit from `content` is deleted. Before replacing `@body` on any chunk, verify the chunk does not contain children you intend to keep. If a chunk spans hundreds of lines and your change touches only a few, target a specific child chunk — not the parent.
+
+**Group chunks (`stmts_*`, `imports_*`, `decls_*`) are containers.** They hold many sibling items (test functions, import statements, declarations). Replacing `@body` on a group chunk replaces **all** of its children. To edit one item inside a group, target that item's own chunk path. If no child chunk exists, use the specific child's chunk selector from `read` output — do not replace the parent group.
 </critical>
 
 <regions>
@@ -108,9 +112,9 @@ Given this `read` output for `example.ts`:
 ```
 
 **Replace a whole chunk** (rename a function):
-```
-{ "sel": "fn_createCounter#PQQY", "op": "replace", "content": "function makeCounter(start: number): Counter {\n const c = new Counter();\n c.value = start;\n return c;\n}\n" }
-```
+~~~json
+{ "sel": "fn_createCounter#PQQY", "op": "replace", "content": "function makeCounter(start: number): Counter {\n\tconst c = new Counter();\n\tc.value = start;\n\treturn c;\n}\n" }
+~~~
 Result — the entire chunk is rewritten:
 ```
 function makeCounter(start: number): Counter {
@@ -158,9 +162,9 @@ function createCounter(initial: number): Counter {
 ```
 
 **Insert after a chunk** (`after`):
-```
-{ "sel": "enum_Status", "op": "after", "content": "\nfunction isActive(s: Status): boolean {\n return s === Status.Active;\n}\n" }
-```
+~~~json
+{ "sel": "enum_Status", "op": "after", "content": "\nfunction isActive(s: Status): boolean {\n\treturn s === Status.Active;\n}\n" }
+~~~
 Result — a new function appears after the enum:
 ```
 enum Status {
@@ -189,9 +193,9 @@ class Counter {
 ```
 
 **Append inside a container** (`@body` + `append`):
-```
-{ "sel": "class_Counter@body", "op": "append", "content": "\nreset(): void {\n this.value = 0;\n}\n" }
-```
+~~~json
+{ "sel": "class_Counter@body", "op": "append", "content": "\nreset(): void {\n\tthis.value = 0;\n}\n" }
+~~~
 Result — a new method is added at the end of the class body, before the closing `}`:
 ```
   toString(): string {
@@ -210,10 +214,10 @@ Result — a new method is added at the end of the class body, before the closin
 ```
 Result — the method is removed from the class.
 - Indentation rules (important):
-  - Use one leading space for each indent level in canonical chunk-edit content. The tool expands those levels to the file's actual style (2-space, 4-space, tabs, etc.).
+  - Use `\t` for each indent level. The tool converts tabs to the file's actual style (2-space, 4-space, etc.).
   - Do NOT include the chunk's base indentation — only indent relative to the region's opening level.
   - For `@body` of a function: write at column 0, e.g. `"return x;\n"`. The tool adds the correct base indent.
   - For `@head`: write at the chunk's own depth. A class member's head uses `"/** doc */\nstart(): void {"`.
-  - For a top-level item: start at zero indent. Write `"function foo() {\n return 1;\n}\n"`.
+  - For a top-level item: start at zero indent. Write `"function foo() {\n\treturn 1;\n}\n"`.
   - The tool strips common leading indentation from your content as a safety net, so accidental over-indentation is corrected.
 </examples>