@oh-my-pi/pi-coding-agent 13.8.0 → 13.9.2

package/CHANGELOG.md

@@ -2,6 +2,58 @@
 
 ## [Unreleased]
 
+## [13.9.2] - 2026-03-05
+
+### Added
+
+- Support for Python code execution messages with output display and error handling
+- Support for mode change entries in session exports
+- Support for TTSR injection and session initialization entries in tree filtering
+
+### Changed
+
+- Updated label lookup to use `targetId` field instead of `parentId` for label references
+- Changed model change entry display to use `model` field instead of separate `provider` and `modelId` fields
+- Simplified model change rendering by removing OpenAI Codex bridge prompt display
+- Updated searchable text extraction to include Python code from `pythonExecution` messages
+
+### Removed
+
+- Removed `codexInjectionInfo` from session data destructuring
+- Removed OpenAI Codex-specific bridge prompt UI from model change entries
+
+### Fixed
+
+- Auto-corrected off-by-one range start errors in hashline edits that would duplicate preceding lines
+
+## [13.9.0] - 2026-03-05
+### Added
+
+- Added `read.defaultLimit` setting to configure default number of lines returned by read tool when no limit is specified (default: 300 lines)
+- Added preset options for read default limit (200, 300, 500, 1000, 5000 lines) in settings UI
+
+### Changed
+
+- Updated read tool prompt to distinguish between default limit and maximum limit per call
+- Moved `ThinkingLevel` type from `@oh-my-pi/pi-agent-core` to `@oh-my-pi/pi-ai` for centralized thinking level definitions
+- Replaced local thinking level validation with `parseThinkingLevel()` and `ALL_THINKING_LEVELS` from `@oh-my-pi/pi-ai`
+- Updated thinking level option providers to use `THINKING_MODE_DESCRIPTIONS` from `@oh-my-pi/pi-ai` for consistent descriptions
+- Renamed `RoleThinkingMode` type to `ThinkingMode` and changed default value from `'default'` to `'inherit'` for clarity
+- Replaced `formatThinkingEffortLabel()` utility with `formatThinking()` from `@oh-my-pi/pi-ai`
+- Renamed `extractExplicitThinkingLevel()` to `extractExplicitThinkingSelector()` in model resolver
+- Updated thinking level clamping to use `getAvailableThinkingLevel()` from `@oh-my-pi/pi-ai`
+
+### Removed
+
+- Removed `thinking-effort-label.ts` utility file (functionality moved to `@oh-my-pi/pi-ai`)
+- Removed local `VALID_THINKING_LEVELS` constant definitions across multiple files
+- Removed `isValidThinkingLevel()` function (replaced by `parseThinkingLevel()` from `@oh-my-pi/pi-ai`)
+- Removed `parseThinkingLevel()` helper from discovery module (now uses centralized version from `@oh-my-pi/pi-ai`)
+
+### Fixed
+
+- Fixed provider session state not being cleared when branching or navigating tree history, preventing resource leaks with codex provider sessions
+
 ## [13.8.0] - 2026-03-04
 ### Added
 

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "13.8.0",
+	"version": "13.9.2",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://github.com/can1357/oh-my-pi",
 	"author": "Can Boluk",
@@ -41,12 +41,12 @@
 	},
 	"dependencies": {
 		"@mozilla/readability": "^0.6",
-		"@oh-my-pi/omp-stats": "13.8.0",
-		"@oh-my-pi/pi-agent-core": "13.8.0",
-		"@oh-my-pi/pi-ai": "13.8.0",
-		"@oh-my-pi/pi-natives": "13.8.0",
-		"@oh-my-pi/pi-tui": "13.8.0",
-		"@oh-my-pi/pi-utils": "13.8.0",
+		"@oh-my-pi/omp-stats": "13.9.2",
+		"@oh-my-pi/pi-agent-core": "13.9.2",
+		"@oh-my-pi/pi-ai": "13.9.2",
+		"@oh-my-pi/pi-natives": "13.9.2",
+		"@oh-my-pi/pi-tui": "13.9.2",
+		"@oh-my-pi/pi-utils": "13.9.2",
 		"@sinclair/typebox": "^0.34",
 		"@xterm/headless": "^6.0",
 		"ajv": "^8.18",

package/src/capability/rule.ts

@@ -20,10 +20,6 @@ export interface RuleFrontmatter {
 	condition?: string | string[];
 	/** New key for TTSR stream scope. */
 	scope?: string | string[];
-	/** Legacy key accepted for backward compatibility with existing rules. */
-	ttsr_trigger?: string | string[];
-	/** Legacy camelCase key accepted for backward compatibility with existing rules. */
-	ttsrTrigger?: string | string[];
 	[key: string]: unknown;
 }
 

package/src/cli/agents-cli.ts

@@ -61,7 +61,7 @@ function toFrontmatter(agent: AgentDefinition): Record<string, unknown> {
 	if (agent.tools && agent.tools.length > 0) frontmatter.tools = agent.tools;
 	if (agent.spawns !== undefined) frontmatter.spawns = agent.spawns;
 	if (agent.model && agent.model.length > 0) frontmatter.model = agent.model;
-	if (agent.thinkingLevel) frontmatter["thinking-level"] = agent.thinkingLevel;
+	if (agent.thinkingLevel) frontmatter.thinkingLevel = agent.thinkingLevel;
 	if (agent.output !== undefined) frontmatter.output = agent.output;
 	if (agent.blocking) frontmatter.blocking = true;
 

package/src/cli/args.ts

@@ -1,7 +1,7 @@
 /**
  * CLI argument parsing and help display
  */
-import type { ThinkingLevel } from "@oh-my-pi/pi-agent-core";
+import { getAvailableThinkingLevels, parseThinkingLevel, type ThinkingLevel } from "@oh-my-pi/pi-ai";
 import { APP_NAME, CONFIG_DIR_NAME, logger } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 import { BUILTIN_TOOLS } from "../tools";
@@ -48,12 +48,6 @@ export interface Args {
 	unknownFlags: Map<string, boolean | string>;
 }
 
-const VALID_THINKING_LEVELS = ["off", "minimal", "low", "medium", "high", "xhigh"] as const;
-
-export function isValidThinkingLevel(level: string): level is ThinkingLevel {
-	return VALID_THINKING_LEVELS.includes(level as ThinkingLevel);
-}
-
 export function parseArgs(args: string[], extensionFlags?: Map<string, { type: "boolean" | "string" }>): Args {
 	const result: Args = {
 		messages: [],
@@ -127,13 +121,14 @@ export function parseArgs(args: string[], extensionFlags?: Map<string, { type: "
 			}
 			result.tools = validTools;
 		} else if (arg === "--thinking" && i + 1 < args.length) {
-			const level = args[++i];
-			if (isValidThinkingLevel(level)) {
-				result.thinking = level;
+			const rawThinking = args[++i];
+			const thinking = parseThinkingLevel(rawThinking);
+			if (thinking !== undefined) {
+				result.thinking = thinking;
 			} else {
 				logger.warn("Invalid thinking level passed to --thinking", {
-					level,
-					validThinkingLevels: [...VALID_THINKING_LEVELS],
+					level: rawThinking,
+					validThinkingLevels: getAvailableThinkingLevels(),
 				});
 			}
 		} else if (arg === "--print" || arg === "-p") {

package/src/commands/launch.ts

@@ -2,6 +2,7 @@
  * Root command for the coding agent CLI.
  */
 
+import { getAvailableThinkingLevels } from "@oh-my-pi/pi-ai";
 import { APP_NAME } from "@oh-my-pi/pi-utils";
 import { Args, Command, Flags } from "@oh-my-pi/pi-utils/cli";
 import { parseArgs } from "../cli/args";
@@ -85,8 +86,8 @@ export default class Index extends Command {
 			description: "Comma-separated list of tools to enable (default: all)",
 		}),
 		thinking: Flags.string({
-			description: "Set thinking level: off, minimal, low, medium, high, xhigh",
-			options: ["off", "minimal", "low", "medium", "high", "xhigh"],
+			description: `Set thinking level: ${getAvailableThinkingLevels().join(", ")}`,
+			options: getAvailableThinkingLevels(),
 		}),
 		hook: Flags.string({
 			description: "Load a hook/extension file (can be used multiple times)",

package/src/config/model-resolver.ts

@@ -1,10 +1,16 @@
 /**
  * Model resolution, scoping, and initial selection
  */
-import type { ThinkingLevel } from "@oh-my-pi/pi-agent-core";
-import { type Api, DEFAULT_MODEL_PER_PROVIDER, type KnownProvider, type Model, modelsAreEqual } from "@oh-my-pi/pi-ai";
+import {
+	type Api,
+	DEFAULT_MODEL_PER_PROVIDER,
+	type KnownProvider,
+	type Model,
+	modelsAreEqual,
+	parseThinkingLevel,
+	type ThinkingLevel,
+} from "@oh-my-pi/pi-ai";
 import chalk from "chalk";
-import { isValidThinkingLevel } from "../cli/args";
 import MODEL_PRIO from "../priority.json" with { type: "json" };
 import { fuzzyMatch } from "../utils/fuzzy";
 import { MODEL_ROLE_IDS, type ModelRegistry, type ModelRole } from "./model-registry";
@@ -34,8 +40,9 @@ export function parseModelString(
 	const colonIdx = id.lastIndexOf(":");
 	if (colonIdx !== -1) {
 		const suffix = id.slice(colonIdx + 1);
-		if (isValidThinkingLevel(suffix)) {
-			return { provider, id: id.slice(0, colonIdx), thinkingLevel: suffix };
+		const thinkingLevel = parseThinkingLevel(suffix);
+		if (thinkingLevel) {
+			return { provider, id: id.slice(0, colonIdx), thinkingLevel };
 		}
 	}
 	return { provider, id };
@@ -242,7 +249,7 @@ function parseModelPatternWithContext(
 	pattern: string,
 	availableModels: Model<Api>[],
 	context: ModelPreferenceContext,
-	options?: { allowInvalidThinkingLevelFallback?: boolean },
+	options?: { allowInvalidThinkingSelectorFallback?: boolean },
 ): ParsedModelResult {
 	// Try exact match first
 	const exactMatch = tryMatchModel(pattern, availableModels, context);
@@ -260,7 +267,8 @@ function parseModelPatternWithContext(
 	const prefix = pattern.substring(0, lastColonIndex);
 	const suffix = pattern.substring(lastColonIndex + 1);
 
-	if (isValidThinkingLevel(suffix)) {
+	const parsedThinkingLevel = parseThinkingLevel(suffix);
+	if (parsedThinkingLevel) {
 		// Valid thinking level - recurse on prefix and use this level
 		const result = parseModelPatternWithContext(prefix, availableModels, context, options);
 		if (result.model) {
@@ -268,7 +276,7 @@ function parseModelPatternWithContext(
 			const explicitThinkingLevel = !result.warning;
 			return {
 				model: result.model,
-				thinkingLevel: explicitThinkingLevel ? suffix : undefined,
+				thinkingLevel: explicitThinkingLevel ? parsedThinkingLevel : undefined,
 				warning: result.warning,
 				explicitThinkingLevel,
 			};
@@ -276,7 +284,7 @@ function parseModelPatternWithContext(
 		return result;
 	}
 
-	const allowFallback = options?.allowInvalidThinkingLevelFallback ?? true;
+	const allowFallback = options?.allowInvalidThinkingSelectorFallback ?? true;
 	if (!allowFallback) {
 		return { model: undefined, thinkingLevel: undefined, warning: undefined, explicitThinkingLevel: false };
 	}
@@ -298,7 +306,7 @@ export function parseModelPattern(
 	pattern: string,
 	availableModels: Model<Api>[],
 	preferences?: ModelMatchPreferences,
-	options?: { allowInvalidThinkingLevelFallback?: boolean },
+	options?: { allowInvalidThinkingSelectorFallback?: boolean },
 ): ParsedModelResult {
 	const context = buildPreferenceContext(availableModels, preferences);
 	return parseModelPatternWithContext(pattern, availableModels, context, options);
@@ -331,6 +339,74 @@ export function expandRoleAlias(value: string, settings?: Settings): string {
 	return settings?.getModelRole(role) ?? value;
 }
 
+/**
+ * Resolve a model role value into a concrete model and thinking metadata.
+ */
+export interface ResolvedModelRoleValue {
+	model: Model<Api> | undefined;
+	thinkingLevel?: ThinkingLevel;
+	explicitThinkingLevel: boolean;
+	warning: string | undefined;
+}
+
+export function resolveModelRoleValue(
+	roleValue: string | undefined,
+	availableModels: Model<Api>[],
+	options?: { settings?: Settings; matchPreferences?: ModelMatchPreferences },
+): ResolvedModelRoleValue {
+	if (!roleValue) {
+		return { model: undefined, thinkingLevel: undefined, explicitThinkingLevel: false, warning: undefined };
+	}
+
+	const normalized = roleValue.trim();
+	if (!normalized || normalized === DEFAULT_MODEL_ROLE) {
+		return { model: undefined, thinkingLevel: undefined, explicitThinkingLevel: false, warning: undefined };
+	}
+
+	const lastColonIndex = normalized.lastIndexOf(":");
+	const hasThinkingSuffix =
+		lastColonIndex > PREFIX_MODEL_ROLE.length && parseThinkingLevel(normalized.slice(lastColonIndex + 1));
+	const aliasCandidate = hasThinkingSuffix ? normalized.slice(0, lastColonIndex) : normalized;
+	const effectivePattern = expandRoleAlias(aliasCandidate, options?.settings);
+	const patternWithSuffix = hasThinkingSuffix
+		? `${effectivePattern}:${normalized.slice(lastColonIndex + 1)}`
+		: effectivePattern;
+	const { model, thinkingLevel, warning, explicitThinkingLevel } = parseModelPattern(
+		patternWithSuffix,
+		availableModels,
+		options?.matchPreferences,
+	);
+
+	return { model, thinkingLevel, explicitThinkingLevel, warning };
+}
+
+export function extractExplicitThinkingSelector(
+	value: string | undefined,
+	settings?: Settings,
+): ThinkingLevel | undefined {
+	if (!value) return undefined;
+	const normalized = value.trim();
+	if (!normalized || normalized === DEFAULT_MODEL_ROLE) return undefined;
+
+	const visited = new Set<string>();
+	let current = normalized;
+	while (!visited.has(current)) {
+		visited.add(current);
+		const lastColonIndex = current.lastIndexOf(":");
+		const hasThinkingSuffix =
+			lastColonIndex > PREFIX_MODEL_ROLE.length && parseThinkingLevel(current.slice(lastColonIndex + 1));
+		if (hasThinkingSuffix) {
+			return current.slice(lastColonIndex + 1) as ThinkingLevel;
+		}
+		const expanded = expandRoleAlias(current, settings).trim();
+		if (!expanded || expanded === current) break;
+		if (expanded === DEFAULT_MODEL_ROLE) return undefined;
+		current = expanded;
+	}
+
+	return undefined;
+}
+
 /**
  * Resolve a model identifier or pattern to a Model instance.
  */
@@ -341,7 +417,8 @@ export function resolveModelFromString(
 ): Model<Api> | undefined {
 	const parsed = parseModelString(value);
 	if (parsed) {
-		return available.find(model => model.provider === parsed.provider && model.id === parsed.id);
+		const exact = available.find(model => model.provider === parsed.provider && model.id === parsed.id);
+		if (exact) return exact;
 	}
 	return parseModelPattern(value, available, matchPreferences).model;
 }
@@ -373,25 +450,20 @@ export function resolveModelOverride(
 	modelPatterns: string[],
 	modelRegistry: ModelRegistry,
 	settings?: Settings,
-): { model?: Model<Api>; thinkingLevel?: ThinkingLevel } {
-	if (modelPatterns.length === 0) return {};
+): { model?: Model<Api>; thinkingLevel?: ThinkingLevel; explicitThinkingLevel: boolean } {
+	if (modelPatterns.length === 0) return { explicitThinkingLevel: false };
+	const availableModels = modelRegistry.getAvailable();
 	const matchPreferences = { usageOrder: settings?.getStorage()?.getModelUsageOrder() };
 	for (const pattern of modelPatterns) {
-		const normalized = pattern.trim();
-		if (!normalized || isDefaultModelAlias(normalized)) {
-			continue;
-		}
-		const effectivePattern = expandRoleAlias(pattern, settings);
-		const { model, thinkingLevel } = parseModelPattern(
-			effectivePattern,
-			modelRegistry.getAvailable(),
+		const { model, thinkingLevel, explicitThinkingLevel } = resolveModelRoleValue(pattern, availableModels, {
+			settings,
 			matchPreferences,
-		);
+		});
 		if (model) {
-			return { model, thinkingLevel: thinkingLevel !== "off" ? thinkingLevel : undefined };
+			return { model, thinkingLevel, explicitThinkingLevel };
 		}
 	}
-	return {};
+	return { explicitThinkingLevel: false };
 }
 
 /**
@@ -425,8 +497,9 @@ export async function resolveModelScope(
 
 			if (colonIdx !== -1) {
 				const suffix = pattern.substring(colonIdx + 1);
-				if (isValidThinkingLevel(suffix)) {
-					thinkingLevel = suffix;
+				const parsedThinkingLevel = parseThinkingLevel(suffix);
+				if (parsedThinkingLevel) {
+					thinkingLevel = parsedThinkingLevel;
 					explicitThinkingLevel = true;
 					globPattern = pattern.substring(0, colonIdx);
 				}
@@ -553,7 +626,7 @@ export function resolveCliModel(options: {
 
 	const candidates = provider ? availableModels.filter(model => model.provider === provider) : availableModels;
 	const { model, thinkingLevel, warning } = parseModelPattern(pattern, candidates, preferences, {
-		allowInvalidThinkingLevelFallback: false,
+		allowInvalidThinkingSelectorFallback: false,
 	});
 
 	if (!model) {
@@ -590,7 +663,7 @@ export async function findInitialModel(options: {
 	isContinuing: boolean;
 	defaultProvider?: string;
 	defaultModelId?: string;
-	defaultThinkingLevel?: ThinkingLevel;
+	defaultThinkingSelector?: ThinkingLevel;
 	modelRegistry: ModelRegistry;
 }): Promise<InitialModelResult> {
 	const {
@@ -600,7 +673,7 @@ export async function findInitialModel(options: {
 		isContinuing,
 		defaultProvider,
 		defaultModelId,
-		defaultThinkingLevel,
+		defaultThinkingSelector,
 		modelRegistry,
 	} = options;
 
@@ -620,10 +693,10 @@ export async function findInitialModel(options: {
 	// 2. Use first model from scoped models (skip if continuing/resuming)
 	if (scopedModels.length > 0 && !isContinuing) {
 		const scoped = scopedModels[0];
-		const scopedThinkingLevel = scoped.thinkingLevel ?? defaultThinkingLevel ?? "off";
+		const scopedThinkingSelector = scoped.thinkingLevel ?? defaultThinkingSelector ?? "off";
 		return {
 			model: scoped.model,
-			thinkingLevel: scopedThinkingLevel,
+			thinkingLevel: scopedThinkingSelector,
 			fallbackMessage: undefined,
 		};
 	}
@@ -633,8 +706,8 @@ export async function findInitialModel(options: {
 		const found = modelRegistry.find(defaultProvider, defaultModelId);
 		if (found) {
 			model = found;
-			if (defaultThinkingLevel) {
-				thinkingLevel = defaultThinkingLevel;
+			if (defaultThinkingSelector) {
+				thinkingLevel = defaultThinkingSelector;
 			}
 			return { model, thinkingLevel, fallbackMessage: undefined };
 		}

package/src/config/settings-schema.ts

@@ -1,4 +1,6 @@
-/**
+import { getAvailableThinkingLevels } from "@oh-my-pi/pi-ai";
+
+/** Unified settings schema - single source of truth for all settings.
  * Unified settings schema - single source of truth for all settings.
  *
  * Each setting is defined once here with:
@@ -190,7 +192,7 @@ export const SETTINGS_SCHEMA = {
 	},
 	defaultThinkingLevel: {
 		type: "enum",
-		values: ["off", "minimal", "low", "medium", "high", "xhigh"] as const,
+		values: getAvailableThinkingLevels(),
 		default: "high",
 		ui: {
 			tab: "agent",
@@ -283,6 +285,16 @@ export const SETTINGS_SCHEMA = {
 			description: "Include line hashes in read output for hashline edit mode (LINE#ID:content)",
 		},
 	},
+	"read.defaultLimit": {
+		type: "number",
+		default: 300,
+		ui: {
+			tab: "tools",
+			label: "Read default limit",
+			description: "Default number of lines returned when agent calls read without a limit",
+			submenu: true,
+		},
+	},
 	showHardwareCursor: {
 		type: "boolean",
 		default: true, // will be computed based on platform if undefined

package/src/config/settings.ts

@@ -318,21 +318,6 @@ export class Settings {
 		return result as unknown as GroupTypeMap[G];
 	}
 
-	/**
-	 * Get edit model variants (typed accessor for complex nested config).
-	 */
-	getEditModelVariants(): Record<string, EditMode | null> {
-		const variants = (this.#merged.edit as { modelVariants?: Record<string, string> })?.modelVariants ?? {};
-		const result: Record<string, EditMode | null> = {};
-		for (const pattern in variants) {
-			const value = normalizeEditMode(variants[pattern]);
-			if (value) {
-				result[pattern] = value;
-			}
-		}
-		return result;
-	}
-
 	/**
 	 * Get the edit variant for a specific model.
 	 * Returns "patch", "replace", "hashline", or null (use global default).
@@ -341,9 +326,8 @@ export class Settings {
 		if (!model) return null;
 		const variants = (this.#merged.edit as { modelVariants?: Record<string, string> })?.modelVariants;
 		if (!variants) return null;
-		const modelLower = model.toLowerCase();
 		for (const pattern in variants) {
-			if (modelLower.includes(pattern)) {
+			if (model.includes(pattern)) {
 				const value = normalizeEditMode(variants[pattern]);
 				if (value) {
 					return value;

package/src/discovery/helpers.ts

@@ -1,6 +1,7 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
-import type { ThinkingLevel } from "@oh-my-pi/pi-agent-core";
+import type { ThinkingLevel } from "@oh-my-pi/pi-ai";
+import { parseThinkingLevel } from "@oh-my-pi/pi-ai";
 import { FileType, glob } from "@oh-my-pi/pi-natives";
 import { CONFIG_DIR_NAME, tryParseJson } from "@oh-my-pi/pi-utils";
 import { readFile } from "../capability/fs";
@@ -9,8 +10,6 @@ import type { Skill, SkillFrontmatter } from "../capability/skill";
 import type { LoadContext, LoadResult, SourceMeta } from "../capability/types";
 import { parseFrontmatter } from "../utils/frontmatter";
 
-const VALID_THINKING_LEVELS: readonly string[] = ["off", "minimal", "low", "medium", "high", "xhigh"];
-
 /**
  * Standard paths for each config source.
  */
@@ -100,18 +99,6 @@ export function createSourceMeta(provider: string, filePath: string, level: "use
 	};
 }
 
-/**
- * Parse thinking level from frontmatter.
- * Supports keys: thinkingLevel, thinking-level, thinking
- */
-export function parseThinkingLevel(frontmatter: Record<string, unknown>): ThinkingLevel | undefined {
-	const raw = frontmatter.thinkingLevel ?? frontmatter["thinking-level"] ?? frontmatter.thinking;
-	if (typeof raw === "string" && VALID_THINKING_LEVELS.includes(raw)) {
-		return raw as ThinkingLevel;
-	}
-	return undefined;
-}
-
 export function parseBoolean(value: unknown): boolean | undefined {
 	if (typeof value === "boolean") return value;
 	if (typeof value === "string") {
@@ -247,10 +234,16 @@ export function parseAgentFields(frontmatter: Record<string, unknown>): ParsedAg
 	}
 
 	const output = frontmatter.output !== undefined ? frontmatter.output : undefined;
+	const rawThinkingLevel =
+		typeof frontmatter.thinkingLevel === "string"
+			? frontmatter.thinkingLevel
+			: typeof frontmatter.thinking === "string"
+				? frontmatter.thinking
+				: undefined;
+
+	const thinkingLevel = parseThinkingLevel(rawThinkingLevel);
 	const model = parseModelList(frontmatter.model);
-	const thinkingLevel = parseThinkingLevel(frontmatter);
 	const blocking = parseBoolean(frontmatter.blocking);
-
 	return { name, description, tools, spawns, model, output, thinkingLevel, blocking };
 }