@oh-my-pi/pi-coding-agent 13.4.0 → 13.4.1

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [13.4.1] - 2026-03-01
+
+### Fixed
+
+- Pending resolve reminders now trigger as soon as a preview action is queued, before the next assistant turn, with regression coverage in `agent-session-resolve-reminder` tests
+
 ## [13.4.0] - 2026-03-01
 
 ### Breaking Changes

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "13.4.0",
+	"version": "13.4.1",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://github.com/can1357/oh-my-pi",
 	"author": "Can Boluk",
@@ -41,12 +41,12 @@
 	},
 	"dependencies": {
 		"@mozilla/readability": "^0.6",
-		"@oh-my-pi/omp-stats": "13.4.0",
-		"@oh-my-pi/pi-agent-core": "13.4.0",
-		"@oh-my-pi/pi-ai": "13.4.0",
-		"@oh-my-pi/pi-natives": "13.4.0",
-		"@oh-my-pi/pi-tui": "13.4.0",
-		"@oh-my-pi/pi-utils": "13.4.0",
+		"@oh-my-pi/omp-stats": "13.4.1",
+		"@oh-my-pi/pi-agent-core": "13.4.1",
+		"@oh-my-pi/pi-ai": "13.4.1",
+		"@oh-my-pi/pi-natives": "13.4.1",
+		"@oh-my-pi/pi-tui": "13.4.1",
+		"@oh-my-pi/pi-utils": "13.4.1",
 		"@sinclair/typebox": "^0.34",
 		"@xterm/headless": "^6.0",
 		"ajv": "^8.18",

package/src/prompts/tools/ast-edit.md

@@ -4,22 +4,20 @@ Performs structural AST-aware rewrites via native ast-grep.
 - Use for codemods and structural rewrites where plain text replace is unsafe
 - Narrow scope with `path` before replacing (`path` accepts files, directories, or glob patterns)
 - Default to language-scoped rewrites in mixed repositories: set `lang` and keep `path` narrow
-- Always returns a preview; after reviewing, call `resolve` with `action: "apply"` or `action: "discard"`
 - Treat parse issues as a scoping signal: tighten `path`/`lang` before retrying
 - Metavariables captured in each rewrite pattern (`$A`, `$$$ARGS`) are substituted into that entry's rewrite template
 - Each matched rewrite is a 1:1 structural substitution; you cannot split one capture into multiple nodes or merge multiple captures into one node
 </instruction>
 
 <output>
-- Returns replacement summary, per-file replacement counts, and change previews
-- Reports whether changes were applied or only previewed
+- Returns replacement summary, per-file replacement counts, and change diffs
 - Includes parse issues when files cannot be processed
 </output>
 
 <examples>
-- Rename a call site across a directory, preview first:
+- Rename a call site across a directory:
   `{"ops":[{"pat":"oldApi($$$ARGS)","out":"newApi($$$ARGS)"}],"lang":"typescript","path":"src/"}`
-- Multi-op codemod preview before resolving:
+- Multi-op codemod:
   `{"ops":[{"pat":"require($A)","out":"import $A"},{"pat":"module.exports = $E","out":"export default $E"}],"lang":"javascript","path":"src/"}`
 - Swap two arguments using captures:
   `{"ops":[{"pat":"assertEqual($A, $B)","out":"assertEqual($B, $A)"}],"lang":"typescript","path":"tests/"}`
@@ -28,6 +26,5 @@ Performs structural AST-aware rewrites via native ast-grep.
 <critical>
 - `ops` **MUST** contain at least one concrete `{ pat, out }` entry
 - If the path pattern spans multiple languages, set `lang` explicitly for deterministic rewrites
-- Review preview output, then use the `resolve` tool to apply or discard (with a reason)
 - For one-off local text edits, prefer the Edit tool instead of AST edit
 </critical>

package/src/prompts/tools/hashline.md

@@ -43,6 +43,7 @@ Every edit has `op`, `pos`, and `lines`. Range replaces also have `end`. Both `p
 3. **Range end tag (inclusive):** `end` is inclusive and **MUST** point to the final line being replaced.
    - If `lines` includes a closing boundary token (`}`, `]`, `)`, `);`, `},`), `end` **MUST** include the original boundary line.
    - You **MUST NOT** set `end` to an interior line and then re-add the boundary token in `lines`; that duplicates the next surviving line.
+   - To remove a line while keeping its neighbors, **delete** it (`lines: null`). You **MUST NOT** replace it with the content of an adjacent line — that line still exists and will be duplicated.
 </rules>
 
 <recovery>

package/src/session/agent-session.ts

@@ -291,6 +291,7 @@ export class AgentSession {
 
 	// Event subscription state
 	#unsubscribeAgent?: () => void;
+	#unsubscribePendingActionPush?: () => void;
 	#eventListeners: AgentSessionEventListener[] = [];
 
 	/** Tracks pending steering messages for UI display. Removed when delivered. */
@@ -397,6 +398,21 @@ export class AgentSession {
 		this.#obfuscator = config.obfuscator;
 		this.agent.providerSessionState = this.#providerSessionState;
 		this.#pendingActionStore = config.pendingActionStore;
+		this.#unsubscribePendingActionPush = this.#pendingActionStore?.subscribePush(action => {
+			const reminderText = [
+				"<system-reminder>",
+				"This is a preview. Call the `resolve` tool to apply or discard these changes.",
+				"</system-reminder>",
+			].join("\n");
+			this.agent.steer({
+				role: "custom",
+				customType: "resolve-reminder",
+				content: reminderText,
+				display: false,
+				details: { toolName: action.sourceToolName },
+				timestamp: Date.now(),
+			});
+		});
 		this.#syncTodoPhasesFromBranch();
 
 		// Always subscribe to agent events for internal handling
@@ -688,22 +704,6 @@ export class AgentSession {
 						{ deliverAs: "nextTurn" },
 					);
 				}
-				if (!isError && this.#pendingActionStore?.hasPending) {
-					const reminderText = [
-						"<system-reminder>",
-						"This is a preview. Call the `resolve` tool to apply or discard these changes.",
-						"</system-reminder>",
-					].join("\n");
-					await this.sendCustomMessage(
-						{
-							customType: "resolve-reminder",
-							content: reminderText,
-							display: false,
-							details: { toolName },
-						},
-						{ deliverAs: "nextTurn" },
-					);
-				}
 			}
 		}
 
@@ -1443,6 +1443,8 @@ export class AgentSession {
 			state.close();
 		}
 		this.#providerSessionState.clear();
+		this.#unsubscribePendingActionPush?.();
+		this.#unsubscribePendingActionPush = undefined;
 		this.#disconnectFromAgent();
 		this.#eventListeners = [];
 	}

package/src/tools/pending-action.ts

@@ -10,9 +10,14 @@ export interface PendingAction {
 
 export class PendingActionStore {
 	#actions: PendingAction[] = [];
+	#pushListeners = new Set<(action: PendingAction, count: number) => void>();
 
 	push(action: PendingAction): void {
 		this.#actions.push(action);
+		const count = this.#actions.length;
+		for (const listener of this.#pushListeners) {
+			listener(action, count);
+		}
 	}
 
 	peek(): PendingAction | null {
@@ -23,10 +28,21 @@ export class PendingActionStore {
 		return this.#actions.pop() ?? null;
 	}
 
+	subscribePush(listener: (action: PendingAction, count: number) => void): () => void {
+		this.#pushListeners.add(listener);
+		return () => {
+			this.#pushListeners.delete(listener);
+		};
+	}
+
 	clear(): void {
 		this.#actions = [];
 	}
 
+	get count(): number {
+		return this.#actions.length;
+	}
+
 	get hasPending(): boolean {
 		return this.#actions.length > 0;
 	}