@oh-my-pi/pi-coding-agent 13.3.6 → 13.3.8

package/src/prompts/tools/ast-find.md

@@ -0,0 +1,20 @@
+Performs structural code search using AST matching via native ast-grep.
+
+<instruction>
+- Use this when syntax shape matters more than raw text (calls, declarations, specific language constructs)
+- Prefer a precise `path` scope to keep results targeted and deterministic (`path` accepts files, directories, or glob patterns)
+- `pattern` is required; `lang` is optional (`lang` is inferred per file extension when omitted)
+- Use `selector` only for contextual pattern mode; otherwise provide a direct pattern
+- Enable `include_meta` when metavariable captures are needed in output
+</instruction>
+
+<output>
+- Returns grouped matches with file path, byte range, and line/column ranges
+- Includes summary counts (`totalMatches`, `filesWithMatches`, `filesSearched`) and parse issues when present
+</output>
+
+<critical>
+- `pattern` is required
+- Set `lang` explicitly to constrain matching when path pattern spans mixed-language trees
+- If exploration is broad/open-ended across subsystems, use Task tool with explore subagent first
+</critical>

package/src/prompts/tools/ast-replace.md

@@ -0,0 +1,21 @@
+Performs structural AST-aware rewrites via native ast-grep.
+
+<instruction>
+- Use for codemods and structural rewrites where plain text replace is unsafe
+- Narrow scope with `path` before replacing (`path` accepts files, directories, or glob patterns)
+- `pattern` + `rewrite` are required; `lang` is optional only when all matched files resolve to a single language
+- Keep `dry_run` enabled unless explicit apply intent is clear
+- Use `max_files` and `max_replacements` as safety caps on broad rewrites
+</instruction>
+
+<output>
+- Returns replacement summary, per-file replacement counts, and change previews
+- Reports whether changes were applied or only previewed
+- Includes parse issues when files cannot be processed
+</output>
+
+<critical>
+- `pattern` + `rewrite` are required
+- If the path pattern spans multiple languages, set `lang` explicitly for deterministic rewrites
+- For one-off local text edits, prefer the Edit tool instead of AST replace
+</critical>

package/src/prompts/tools/bash.md

@@ -35,6 +35,8 @@ You **MUST** use specialized tools instead of bash for ALL file operations:
 |`ls dir/`|`read(path="dir/")`|
 |`cat <<'EOF' > file`|`write(path="file", content="...")`|
 |`sed -i 's/old/new/' file`|`edit(path="file", edits=[...])`|
+- If `ast_find` / `ast_replace` tools are available in the session, you **MUST** use them for structural code search/rewrites instead of bash `grep`/`sed`/`awk`/`perl` pipelines
+- Bash is for command execution, not syntax-aware code transformation; prefer `ast_find` for discovery and `ast_replace` for codemods
 - You **MUST NOT** use Bash for these operations like read, grep, find, edit, write, where specialized tools exist.
 - You **MUST NOT** use `2>&1` | `2>/dev/null` pattern, stdout and stderr are already merged.
 - You **MUST NOT** use `| head -n 50` or `| tail -n 100` pattern, use `head` and `tail` parameters instead.

package/src/prompts/tools/hashline.md

@@ -175,26 +175,44 @@ Good — include original `}` in the replaced range when replacement keeps `}`:
 Also apply the same rule to `);`, `],`, and `},` closers: if replacement includes the closer token, `end` must include the original closer line.
 </example>
 
-<example name="insert between siblings">
+<example name="insert between sibling declarations">
 ```ts
-{{hlinefull 44 "  \"build\": \"bun run compile\","}}
-{{hlinefull 45 "  \"test\": \"bun test\""}}
+{{hlinefull 44 "function x() {"}}
+{{hlinefull 45 "  runX();"}}
+{{hlinefull 46 "}"}}
+{{hlinefull 47 ""}}
+{{hlinefull 48 "function y() {"}}
+{{hlinefull 49 "  runY();"}}
+{{hlinefull 50 "}"}}
 ```
 ```
 {
   path: "…",
   edits: [{
     op: "prepend",
-    pos: "{{hlineref 45 "  \"test\": \"bun test\""}}",
-    lines: ["  \"lint\": \"biome check\","]
+    pos: "{{hlineref 48 "function y() {"}}",
+    lines: [
+      "function z() {",
+      "  runZ();",
+      "}",
+      ""
+    ]
   }]
 }
 ```
 Result:
 ```ts
-{{hlinefull 44 "  \"build\": \"bun run compile\","}}
-{{hlinefull 45 "  \"lint\": \"biome check\","}}
-{{hlinefull 46 "  \"test\": \"bun test\""}}
+{{hlinefull 44 "function x() {"}}
+{{hlinefull 45 "  runX();"}}
+{{hlinefull 46 "}"}}
+{{hlinefull 47 ""}}
+{{hlinefull 48 "function z() {"}}
+{{hlinefull 49 "  runZ();"}}
+{{hlinefull 50 "}"}}
+{{hlinefull 51 ""}}
+{{hlinefull 52 "function y() {"}}
+{{hlinefull 53 "  runY();"}}
+{{hlinefull 54 "}"}}
 ```
 </example>
 

package/src/prompts/tools/lsp.md

@@ -1,16 +1,33 @@
 Interacts with Language Server Protocol servers for code intelligence.
 
 <operations>
-- `definition`: Go to symbol definition → file path + position
-- `references`: Find all references → list of locations (file + position)
+- `diagnostics`: Get errors/warnings for file, glob, or entire workspace (no file)
+- `definition`: Go to symbol definition → file path + position + 3-line source context
+- `type_definition`: Go to symbol type definition → file path + position + 3-line source context
+- `implementation`: Find concrete implementations → file path + position + 3-line source context
+- `references`: Find references → locations with 3-line source context (first 50), remaining location-only
 - `hover`: Get type info and documentation → type signature + docs
-- `symbols`: List symbols in file, or search workspace (with query, no file) → names, kinds, locations
-- `rename`: Rename symbol across codebase → confirmation of changes
-- `diagnostics`: Get errors/warnings for file, or check entire project (no file) → list with severity + message
+- `symbols`: List symbols in file, or search workspace (with query, no file)
+- `rename`: Rename symbol across codebase → preview or apply edits
+- `code_actions`: List available quick-fixes/refactors/import actions; apply one when `apply: true` and `query` matches title or index
+- `status`: Show active language servers
 - `reload`: Restart the language server
 </operations>
 
+<parameters>
+- `file`: File path; for diagnostics it may be a glob pattern (e.g., `src/**/*.ts`)
+- `line`: 1-indexed line number for position-based actions
+- `symbol`: Substring on the target line used to resolve column automatically
+- `occurrence`: 1-indexed match index when `symbol` appears multiple times on the same line
+- `query`: Symbol search query, code-action kind filter (list mode), or code-action selector (apply mode)
+- `new_name`: Required for rename
+- `apply`: Apply edits for rename/code_actions (default true for rename, list mode for code_actions unless explicitly true)
+- `timeout`: Request timeout in seconds (clamped to 5-60, default 20)
+</parameters>
+
 <caution>
 - Requires running LSP server for target language
 - Some operations require file to be saved to disk
+- Diagnostics glob mode samples up to 20 files per request to avoid long-running stalls on broad patterns
+- When `symbol` is provided for position-based actions, missing symbols or out-of-bounds `occurrence` values return an explicit error instead of silently falling back
 </caution>

package/src/prompts/tools/task.md

@@ -12,7 +12,6 @@ Subagents lack your conversation history. Every decision, file content, and user
   - `.id`: CamelCase, max 32 chars
   - `.description`: UI display only — subagent never sees it
   - `.assignment`: Complete self-contained instructions. One-liners PROHIBITED; missing acceptance criteria = too vague.
-  - `.skills`: Skill names to preload
 - `context`: Shared background prepended to every assignment. Session-specific info only.
 - `schema`: JTD schema for expected output. Format lives here — **MUST NOT** be duplicated in assignments.
 - `tasks`: Tasks to execute in parallel.

package/src/sdk.ts

@@ -144,8 +144,6 @@ export interface CreateAgentSessionOptions {
 
 	/** Skills. Default: discovered from multiple locations */
 	skills?: Skill[];
-	/** Skills to inline into the system prompt instead of listing available skills. */
-	preloadedSkills?: Skill[];
 	/** Rules. Default: discovered from multiple locations */
 	rules?: Rule[];
 	/** Context files (AGENTS.md content). Default: discovered walking up from cwd */
@@ -1128,7 +1126,6 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		const defaultPrompt = await buildSystemPromptInternal({
 			cwd,
 			skills,
-			preloadedSkills: options.preloadedSkills,
 			contextFiles,
 			tools,
 			toolNames,
@@ -1147,7 +1144,6 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 			return await buildSystemPromptInternal({
 				cwd,
 				skills,
-				preloadedSkills: options.preloadedSkills,
 				contextFiles,
 				tools,
 				toolNames,
@@ -1299,7 +1295,17 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 			return key;
 		},
 		cursorExecHandlers,
-		transformToolCallArguments: obfuscator?.hasSecrets() ? args => obfuscator!.deobfuscateObject(args) : undefined,
+		transformToolCallArguments: (args, _toolName) => {
+			let result = args;
+			const maxTimeout = settings.get("tools.maxTimeout");
+			if (maxTimeout > 0 && typeof result.timeout === "number") {
+				result = { ...result, timeout: Math.min(result.timeout, maxTimeout) };
+			}
+			if (obfuscator?.hasSecrets()) {
+				result = obfuscator.deobfuscateObject(result);
+			}
+			return result;
+		},
 		intentTracing: !!intentField,
 	});
 	cursorEventEmitter = event => agent.emitExternalEvent(event);