@oh-my-pi/pi-coding-agent 13.3.5 → 13.3.6

package/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## [Unreleased]
 
+## [13.3.6] - 2026-02-26
+### Breaking Changes
+
+- Changed `submit_result` tool parameter structure from top-level `data` or `error` fields to nested `result` object containing either `result.data` or `result.error`
+
 ## [13.3.5] - 2026-02-26
 ### Added
 

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "13.3.5",
+	"version": "13.3.6",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://github.com/can1357/oh-my-pi",
 	"author": "Can Boluk",
@@ -41,12 +41,12 @@
 	},
 	"dependencies": {
 		"@mozilla/readability": "^0.6",
-		"@oh-my-pi/omp-stats": "13.3.5",
-		"@oh-my-pi/pi-agent-core": "13.3.5",
-		"@oh-my-pi/pi-ai": "13.3.5",
-		"@oh-my-pi/pi-natives": "13.3.5",
-		"@oh-my-pi/pi-tui": "13.3.5",
-		"@oh-my-pi/pi-utils": "13.3.5",
+		"@oh-my-pi/omp-stats": "13.3.6",
+		"@oh-my-pi/pi-agent-core": "13.3.6",
+		"@oh-my-pi/pi-ai": "13.3.6",
+		"@oh-my-pi/pi-natives": "13.3.6",
+		"@oh-my-pi/pi-tui": "13.3.6",
+		"@oh-my-pi/pi-utils": "13.3.6",
 		"@sinclair/typebox": "^0.34",
 		"@xterm/headless": "^6.0",
 		"ajv": "^8.18",

package/src/prompts/agents/reviewer.md

@@ -112,11 +112,11 @@ Each `report_finding` requires:
 - `file_path`: Absolute path
 - `line_start`, `line_end`: Range ≤10 lines, must overlap diff
 
-Final `submit_result` call (payload under `data`):
-- `data.overall_correctness`: "correct" (no bugs/blockers) or "incorrect"
-- `data.explanation`: Plain text, 1-3 sentences summarizing verdict. Don't repeat findings (captured via `report_finding`).
-- `data.confidence`: 0.0-1.0
-- `data.findings`: Optional; **MUST** omit (auto-populated from `report_finding`)
+Final `submit_result` call (payload under `result.data`):
+- `result.data.overall_correctness`: "correct" (no bugs/blockers) or "incorrect"
+- `result.data.explanation`: Plain text, 1-3 sentences summarizing verdict. Don't repeat findings (captured via `report_finding`).
+- `result.data.confidence`: 0.0-1.0
+- `result.data.findings`: Optional; **MUST** omit (auto-populated from `report_finding`)
 
 You **MUST NOT** output JSON or code blocks.
 

package/src/prompts/system/subagent-submit-reminder.md

@@ -2,8 +2,8 @@
 You stopped without calling submit_result. This is reminder {{retryCount}} of {{maxRetries}}.
 
 You **MUST** call submit_result as your only action now. Choose one:
-- If task is complete: call submit_result with your result in the `data` field
-- If task failed: call submit_result with an `error` field describing what happened
+- If task is complete: call submit_result with your result in `result.data`
+- If task failed: call submit_result with `result.error` describing what happened
 
 You **MUST NOT** give up if you can still complete the task through exploration (using available tools or repo context). If you submit an error, you **MUST** include what you tried and the exact blocker.
 

package/src/prompts/system/subagent-system-prompt.md

@@ -19,7 +19,7 @@ No TODO tracking, no progress updates. Execute, call `submit_result`, done.
 
 When finished, you **MUST** call `submit_result` exactly once. This is like writing to a ticket, provide what is required, and close it.
 
-This is your only way to return a result. You **MUST NOT** put JSON in plain text, and you **MUST NOT** substitute a text summary for the structured `data` parameter.
+This is your only way to return a result. You **MUST NOT** put JSON in plain text, and you **MUST NOT** substitute a text summary for the structured `result.data` parameter.
 
 {{#if outputSchema}}
 Your result **MUST** match this TypeScript interface:
@@ -29,7 +29,7 @@ Your result **MUST** match this TypeScript interface:
 {{/if}}
 
 {{SECTION_SEPERATOR "Giving Up"}}
-If you cannot complete the assignment, you **MUST** call `submit_result` exactly once with an `error` message describing what you tried and the exact blocker.
+If you cannot complete the assignment, you **MUST** call `submit_result` exactly once with `result.error` describing what you tried and the exact blocker.
 
 Giving up is a last resort.
 You **MUST NOT** give up due to uncertainty or missing information obtainable via tools or repo context.

package/src/tools/submit-result.ts

@@ -89,16 +89,20 @@ export class SubmitResultTool implements AgentTool<TSchema, SubmitResultDetails>
 					...(normalizedSchema as object),
 					description: `Structured output matching the schema:\n${schemaHint}`,
 				})
-			: Type.Object({}, { additionalProperties: true, description: "Structured JSON output (no schema specified)" });
-
-		this.parameters = Type.Union([
-			Type.Object({
-				data: dataSchema,
-			}),
-			Type.Object({
-				error: Type.String({ description: "Error message when the task cannot be completed" }),
-			}),
-		]);
+			: Type.Record(Type.String(), Type.Any(), { description: "Structured JSON output (no schema specified)" });
+
+		this.parameters = Type.Object(
+			{
+				result: Type.Union([
+					Type.Object({ data: dataSchema }, { description: "Successfully completed the task" }),
+					Type.Object({ error: Type.String({ description: "Error message when the task cannot be completed" }) }),
+				]),
+			},
+			{
+				additionalProperties: false,
+				description: "Submit either `data` for success or `error` for failure",
+			},
+		);
 	}
 
 	async execute(
@@ -109,10 +113,23 @@ export class SubmitResultTool implements AgentTool<TSchema, SubmitResultDetails>
 		_context?: AgentToolContext,
 	): Promise<AgentToolResult<SubmitResultDetails>> {
 		const raw = params as Record<string, unknown>;
-		const errorMessage = typeof raw.error === "string" ? raw.error : undefined;
-		const status = errorMessage !== undefined ? "aborted" : "success";
-		const data = raw.data;
+		const rawResult = raw.result;
+		if (!rawResult || typeof rawResult !== "object" || Array.isArray(rawResult)) {
+			throw new Error("result must be an object containing either data or error");
+		}
 
+		const resultRecord = rawResult as Record<string, unknown>;
+		const errorMessage = typeof resultRecord.error === "string" ? resultRecord.error : undefined;
+		const data = resultRecord.data;
+
+		if (errorMessage !== undefined && data !== undefined) {
+			throw new Error("result cannot contain both data and error");
+		}
+		if (errorMessage === undefined && data === undefined) {
+			throw new Error("result must contain either data or error");
+		}
+
+		const status = errorMessage !== undefined ? "aborted" : "success";
 		if (status === "success") {
 			if (data === undefined || data === null) {
 				throw new Error("data is required when submit_result indicates success");