@oh-my-pi/pi-coding-agent 13.3.0 → 13.3.2

package/CHANGELOG.md

@@ -2,6 +2,20 @@
 
 ## [Unreleased]
 
+## [13.3.1] - 2026-02-26
+
+### Added
+
+- Added `topP` setting to control nucleus sampling cutoff for model output diversity
+- Added `topK` setting to sample from top-K tokens for controlled generation
+- Added `minP` setting to enforce minimum probability threshold for token selection
+- Added `presencePenalty` setting to penalize introduction of already-present tokens
+- Added `repetitionPenalty` setting to penalize repeated tokens in model output
+
+### Fixed
+
+- Fixed skill discovery to continue loading project skills when user skills directory is missing
+
 ## [13.3.0] - 2026-02-26
 
 ### Breaking Changes

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "13.3.0",
+	"version": "13.3.2",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://github.com/can1357/oh-my-pi",
 	"author": "Can Boluk",
@@ -41,12 +41,12 @@
 	},
 	"dependencies": {
 		"@mozilla/readability": "^0.6",
-		"@oh-my-pi/omp-stats": "13.3.0",
-		"@oh-my-pi/pi-agent-core": "13.3.0",
-		"@oh-my-pi/pi-ai": "13.3.0",
-		"@oh-my-pi/pi-natives": "13.3.0",
-		"@oh-my-pi/pi-tui": "13.3.0",
-		"@oh-my-pi/pi-utils": "13.3.0",
+		"@oh-my-pi/omp-stats": "13.3.2",
+		"@oh-my-pi/pi-agent-core": "13.3.2",
+		"@oh-my-pi/pi-ai": "13.3.2",
+		"@oh-my-pi/pi-natives": "13.3.2",
+		"@oh-my-pi/pi-tui": "13.3.2",
+		"@oh-my-pi/pi-utils": "13.3.2",
 		"@sinclair/typebox": "^0.34",
 		"@xterm/headless": "^6.0",
 		"ajv": "^8.18",

package/src/cli/config-cli.ts

@@ -2,7 +2,7 @@
  * Config CLI command handlers.
  *
  * Handles `omp config <command>` subcommands for managing settings.
- * Uses settings-defs as the source of truth for available settings.
+ * Uses the settings schema as the source of truth for available settings.
  */
 
 import { APP_NAME, getAgentDir } from "@oh-my-pi/pi-utils";
@@ -11,12 +11,13 @@ import {
 	getDefault,
 	getEnumValues,
 	getType,
+	getUi,
 	type SettingPath,
 	Settings,
 	type SettingValue,
 	settings,
 } from "../config/settings";
-import { getAllSettingDefs, type SettingDef } from "../modes/components/settings-defs";
+import { SETTINGS_SCHEMA } from "../config/settings-schema";
 import { theme } from "../modes/theme/theme";
 
 // =============================================================================
@@ -38,21 +39,32 @@ export interface ConfigCommandArgs {
 // Setting Filtering
 // =============================================================================
 
+type CliSettingDef = {
+	path: SettingPath;
+	type: string;
+	description: string;
+	tab: string;
+};
+
+const ALL_SETTING_PATHS = Object.keys(SETTINGS_SCHEMA) as SettingPath[];
+
 /** Find setting definition by path */
-function findSettingDef(path: string): SettingDef | undefined {
-	return getAllSettingDefs().find(def => def.path === path);
+function findSettingDef(path: string): CliSettingDef | undefined {
+	if (!(path in SETTINGS_SCHEMA)) return undefined;
+	const key = path as SettingPath;
+	const ui = getUi(key);
+	return {
+		path: key,
+		type: getType(key),
+		description: ui?.description ?? "",
+		tab: ui?.tab ?? "internal",
+	};
 }
 
 /** Get available values for a setting */
-function getSettingValues(def: SettingDef): readonly string[] | undefined {
+function getSettingValues(def: CliSettingDef): readonly string[] | undefined {
 	if (def.type === "enum") {
-		return def.values;
-	}
-	if (def.type === "submenu") {
-		const options = def.options;
-		if (options.length > 0) {
-			return options.map(o => o.value);
-		}
+		return getEnumValues(def.path);
 	}
 	return undefined;
 }
@@ -125,7 +137,7 @@ function formatValue(value: unknown): string {
 	return chalk.yellow(String(value));
 }
 
-function getTypeDisplay(def: SettingDef): string {
+function getTypeDisplay(def: CliSettingDef): string {
 	if (def.type === "boolean") {
 		return "(boolean)";
 	}
@@ -199,13 +211,13 @@ export async function runConfigCommand(cmd: ConfigCommandArgs): Promise<void> {
 }
 
 function handleList(flags: { json?: boolean }): void {
-	const defs = getAllSettingDefs();
+	const defs = ALL_SETTING_PATHS.map(path => findSettingDef(path)).filter((def): def is CliSettingDef => !!def);
 
 	if (flags.json) {
 		const result: Record<string, { value: unknown; type: string; description: string }> = {};
 		for (const def of defs) {
 			result[def.path] = {
-				value: settings.get(def.path as SettingPath),
+				value: settings.get(def.path),
 				type: def.type,
 				description: def.description,
 			};
@@ -216,7 +228,7 @@ function handleList(flags: { json?: boolean }): void {
 
 	console.log(chalk.bold("Settings:\n"));
 
-	const groups: Record<string, SettingDef[]> = {};
+	const groups: Record<string, CliSettingDef[]> = {};
 	for (const def of defs) {
 		if (!groups[def.tab]) {
 			groups[def.tab] = [];
@@ -233,7 +245,7 @@ function handleList(flags: { json?: boolean }): void {
 	for (const group of sortedGroups) {
 		console.log(chalk.bold.blue(`[${group}]`));
 		for (const def of groups[group]) {
-			const value = settings.get(def.path as SettingPath);
+			const value = settings.get(def.path);
 			const valueStr = formatValue(value);
 			const typeStr = getTypeDisplay(def);
 			console.log(`  ${chalk.white(def.path)} = ${valueStr} ${chalk.dim(typeStr)}`);
@@ -256,7 +268,7 @@ function handleGet(key: string | undefined, flags: { json?: boolean }): void {
 		process.exit(1);
 	}
 
-	const value = settings.get(def.path as SettingPath);
+	const value = settings.get(def.path);
 
 	if (flags.json) {
 		console.log(JSON.stringify({ key: def.path, value, type: def.type, description: def.description }, null, 2));
@@ -281,13 +293,13 @@ async function handleSet(key: string | undefined, value: string | undefined, fla
 	}
 
 	try {
-		parseAndSetValue(def.path as SettingPath, value);
+		parseAndSetValue(def.path, value);
 	} catch (err) {
 		console.error(chalk.red(String(err)));
 		process.exit(1);
 	}
 
-	const newValue = settings.get(def.path as SettingPath);
+	const newValue = settings.get(def.path);
 
 	if (flags.json) {
 		console.log(JSON.stringify({ key: def.path, value: newValue }));

package/src/config/settings-schema.ts

@@ -197,16 +197,6 @@ export const SETTINGS_SCHEMA = {
 			submenu: true,
 		},
 	},
-	temperature: {
-		type: "number",
-		default: -1,
-		ui: {
-			tab: "agent",
-			label: "Temperature",
-			description: "Sampling temperature (0 = deterministic, 1 = creative, -1 = provider default)",
-			submenu: true,
-		},
-	},
 	hideThinkingBlock: {
 		type: "boolean",
 		default: false,
@@ -1048,6 +1038,66 @@ export const SETTINGS_SCHEMA = {
 	"statusLine.leftSegments": { type: "array", default: [] as StatusLineSegmentId[] },
 	"statusLine.rightSegments": { type: "array", default: [] as StatusLineSegmentId[] },
 	"statusLine.segmentOptions": { type: "record", default: {} as Record<string, unknown> },
+	temperature: {
+		type: "number",
+		default: -1,
+		ui: {
+			tab: "agent",
+			label: "Temperature",
+			description: "Sampling temperature (0 = deterministic, 1 = creative, -1 = provider default)",
+			submenu: true,
+		},
+	},
+	topP: {
+		type: "number",
+		default: -1,
+		ui: {
+			tab: "agent",
+			label: "Top P",
+			description: "Nucleus sampling cutoff (0-1, -1 = provider default)",
+			submenu: true,
+		},
+	},
+	topK: {
+		type: "number",
+		default: -1,
+		ui: {
+			tab: "agent",
+			label: "Top K",
+			description: "Sample from top-K tokens (-1 = provider default)",
+			submenu: true,
+		},
+	},
+	minP: {
+		type: "number",
+		default: -1,
+		ui: {
+			tab: "agent",
+			label: "Min P",
+			description: "Minimum probability threshold (0-1, -1 = provider default)",
+			submenu: true,
+		},
+	},
+	presencePenalty: {
+		type: "number",
+		default: -1,
+		ui: {
+			tab: "agent",
+			label: "Presence penalty",
+			description: "Penalty for introducing already-present tokens (-1 = provider default)",
+			submenu: true,
+		},
+	},
+	repetitionPenalty: {
+		type: "number",
+		default: -1,
+		ui: {
+			tab: "agent",
+			label: "Repetition penalty",
+			description: "Penalty for repeated tokens (-1 = provider default)",
+			submenu: true,
+		},
+	},
 } as const;
 
 // ═══════════════════════════════════════════════════════════════════════════

package/src/discovery/helpers.ts

@@ -284,8 +284,15 @@ export async function scanSkillsFromDir(
 	const warnings: string[] = [];
 	const { dir, level, providerId, requireDescription = false } = options;
 
-	const entries = await fs.promises.readdir(dir, { withFileTypes: true });
-
+	let entries: fs.Dirent[];
+	try {
+		entries = await fs.promises.readdir(dir, { withFileTypes: true });
+	} catch (error) {
+		if ((error as NodeJS.ErrnoException).code !== "ENOENT") {
+			warnings.push(`Failed to read skills directory: ${dir} (${String(error)})`);
+		}
+		return { items, warnings };
+	}
 	const loadSkill = async (skillPath: string) => {
 		try {
 			const content = await readFile(skillPath);

package/src/modes/components/settings-defs.ts

@@ -214,6 +214,42 @@ const OPTION_PROVIDERS: Partial<Record<SettingPath, OptionProvider>> = {
 		{ value: "0.7", label: "0.7", description: "Creative" },
 		{ value: "1", label: "1", description: "Maximum variety" },
 	],
+	topP: [
+		{ value: "-1", label: "Default", description: "Use provider default" },
+		{ value: "0.1", label: "0.1", description: "Very focused" },
+		{ value: "0.3", label: "0.3", description: "Focused" },
+		{ value: "0.5", label: "0.5", description: "Balanced" },
+		{ value: "0.9", label: "0.9", description: "Broad" },
+		{ value: "1", label: "1", description: "No nucleus filtering" },
+	],
+	topK: [
+		{ value: "-1", label: "Default", description: "Use provider default" },
+		{ value: "1", label: "1", description: "Greedy top token" },
+		{ value: "20", label: "20", description: "Focused" },
+		{ value: "40", label: "40", description: "Balanced" },
+		{ value: "100", label: "100", description: "Broad" },
+	],
+	minP: [
+		{ value: "-1", label: "Default", description: "Use provider default" },
+		{ value: "0.01", label: "0.01", description: "Very permissive" },
+		{ value: "0.05", label: "0.05", description: "Balanced" },
+		{ value: "0.1", label: "0.1", description: "Strict" },
+	],
+	presencePenalty: [
+		{ value: "-1", label: "Default", description: "Use provider default" },
+		{ value: "0", label: "0", description: "No penalty" },
+		{ value: "0.5", label: "0.5", description: "Mild novelty" },
+		{ value: "1", label: "1", description: "Encourage novelty" },
+		{ value: "2", label: "2", description: "Strong novelty" },
+	],
+	repetitionPenalty: [
+		{ value: "-1", label: "Default", description: "Use provider default" },
+		{ value: "0.8", label: "0.8", description: "Allow repetition" },
+		{ value: "1", label: "1", description: "No penalty" },
+		{ value: "1.1", label: "1.1", description: "Mild penalty" },
+		{ value: "1.2", label: "1.2", description: "Balanced" },
+		{ value: "1.5", label: "1.5", description: "Strong penalty" },
+	],
 	// Symbol preset
 	symbolPreset: [
 		{ value: "unicode", label: "Unicode", description: "Standard symbols (default)" },

package/src/modes/controllers/selector-controller.ts

@@ -288,6 +288,31 @@ export class SelectorController {
 				this.ctx.session.agent.temperature = temp >= 0 ? temp : undefined;
 				break;
 			}
+			case "topP": {
+				const topP = typeof value === "number" ? value : Number(value);
+				this.ctx.session.agent.topP = topP >= 0 ? topP : undefined;
+				break;
+			}
+			case "topK": {
+				const topK = typeof value === "number" ? value : Number(value);
+				this.ctx.session.agent.topK = topK >= 0 ? topK : undefined;
+				break;
+			}
+			case "minP": {
+				const minP = typeof value === "number" ? value : Number(value);
+				this.ctx.session.agent.minP = minP >= 0 ? minP : undefined;
+				break;
+			}
+			case "presencePenalty": {
+				const presencePenalty = typeof value === "number" ? value : Number(value);
+				this.ctx.session.agent.presencePenalty = presencePenalty >= 0 ? presencePenalty : undefined;
+				break;
+			}
+			case "repetitionPenalty": {
+				const repetitionPenalty = typeof value === "number" ? value : Number(value);
+				this.ctx.session.agent.repetitionPenalty = repetitionPenalty >= 0 ? repetitionPenalty : undefined;
+				break;
+			}
 			case "statusLinePreset":
 			case "statusLineSeparator":
 			case "statusLineShowHooks":

package/src/modes/theme/defaults/dark-poimandres.json

@@ -0,0 +1,138 @@
+{
+  "name": "dark-poimandres",
+  "vars": {
+    "poimandresBg": "#1b1e28",
+    "poimandresFocus": "#303340",
+    "poimandresGray": "#a6accd",
+    "poimandresDarkerGray": "#767c9d",
+    "poimandresBluishGray": "#506477",
+    "poimandresOffWhite": "#e4f0fb",
+    "poimandresBrightMint": "#5DE4c7",
+    "poimandresStrongTurquoise": "#00CED1",
+    "poimandresLowerMint": "#5fb3a1",
+    "poimandresLightBlue": "#ADD7FF",
+    "poimandresLowerBlue": "#89ddff",
+    "poimandresDesaturatedGreen": "#7AC6B6",
+    "poimandresHotRed": "#d0679d",
+    "poimandresPink": "#f087bd",
+    "poimandresBrightYellow": "#fffac2",
+    "poimandresBluishGrayBrighter": "#7390AA",
+    "poimandresSelection": "#717cb425",
+    "poimandresWhite": "#ffffff",
+    "poimandresBlack": "#000000",
+    "poimandresBg256": 235,
+    "poimandresFocus256": 238,
+    "poimandresGray256": 109,
+    "poimandresDarkerGray256": 103,
+    "poimandresBluishGray256": 66,
+    "poimandresBrightMint256": 86,
+    "poimandresStrongTurquoise256": 44,
+    "poimandresLowerMint256": 79,
+    "poimandresLightBlue256": 153,
+    "poimandresLowerBlue256": 117,
+    "poimandresDesaturatedGreen256": 79,
+    "poimandresHotRed256": 169,
+    "poimandresPink256": 211,
+    "poimandresBrightYellow256": 229,
+    "poimandresBluishGrayBrighter256": 110,
+    "poimandresSubtleBg": "#1b1e28",
+    "poimandresMediumBg": "#23273a",
+    "poimandresBrightBg": "#303340"
+  },
+  "colors": {
+    "accent": "poimandresStrongTurquoise",
+    "border": "poimandresBluishGray",
+    "borderAccent": "poimandresDarkerGray",
+    "borderMuted": "poimandresBluishGray",
+    "success": "poimandresStrongTurquoise",
+    "error": "poimandresHotRed",
+    "warning": "poimandresBrightYellow",
+    "muted": "poimandresDarkerGray",
+    "dim": "poimandresBluishGray",
+    "text": "poimandresGray",
+    "thinkingText": "poimandresDarkerGray",
+    "selectedBg": "poimandresSelection",
+    "userMessageBg": "poimandresFocus",
+    "userMessageText": "poimandresWhite",
+    "customMessageBg": "poimandresFocus",
+    "customMessageText": "poimandresWhite",
+    "customMessageLabel": "poimandresStrongTurquoise",
+    "toolPendingBg": "poimandresFocus",
+    "toolSuccessBg": "poimandresMediumBg",
+    "toolErrorBg": "poimandresFocus",
+    "toolTitle": "poimandresBrightMint",
+    "toolOutput": "poimandresDarkerGray",
+    "mdHeading": "poimandresBrightMint",
+    "mdLink": "poimandresDesaturatedGreen",
+    "mdLinkUrl": "poimandresStrongTurquoise",
+    "mdCode": "poimandresStrongTurquoise",
+    "mdCodeBlock": "poimandresGray",
+    "mdCodeBlockBorder": "poimandresBluishGray",
+    "mdQuote": "poimandresDarkerGray",
+    "mdQuoteBorder": "poimandresBluishGray",
+    "mdHr": "poimandresDarkerGray",
+    "mdListBullet": "poimandresBrightMint",
+    "toolDiffAdded": "poimandresStrongTurquoise",
+    "toolDiffRemoved": "poimandresHotRed",
+    "toolDiffContext": "poimandresDarkerGray",
+    "syntaxComment": "poimandresDarkerGray",
+    "syntaxKeyword": "poimandresDesaturatedGreen",
+    "syntaxFunction": "poimandresBrightMint",
+    "syntaxVariable": "poimandresStrongTurquoise",
+    "syntaxString": "poimandresStrongTurquoise",
+    "syntaxNumber": "poimandresPink",
+    "syntaxType": "poimandresStrongTurquoise",
+    "syntaxOperator": "poimandresDesaturatedGreen",
+    "syntaxPunctuation": "poimandresGray",
+    "thinkingOff": "poimandresBluishGray",
+    "thinkingMinimal": "poimandresDarkerGray",
+    "thinkingLow": "poimandresBrightMint",
+    "thinkingMedium": "poimandresStrongTurquoise",
+    "thinkingHigh": "poimandresPink",
+    "thinkingXhigh": "poimandresHotRed",
+    "bashMode": "poimandresDesaturatedGreen",
+    "pythonMode": "poimandresStrongTurquoise",
+    "statusLineBg": "poimandresFocus",
+    "statusLineSep": 66,
+    "statusLineModel": "poimandresBrightMint",
+    "statusLinePath": "poimandresGray",
+    "statusLineGitClean": "poimandresStrongTurquoise",
+    "statusLineGitDirty": "poimandresHotRed",
+    "statusLineContext": "poimandresDarkerGray",
+    "statusLineSpend": "poimandresLowerMint",
+    "statusLineStaged": 44,
+    "statusLineDirty": 169,
+    "statusLineUntracked": 229,
+    "statusLineOutput": "poimandresLowerBlue",
+    "statusLineCost": "poimandresPink",
+    "statusLineSubagents": "poimandresDesaturatedGreen"
+  },
+  "export": {
+    "pageBg": "poimandresBg",
+    "cardBg": "poimandresFocus",
+    "infoBg": "poimandresFocus"
+  },
+  "symbols": {
+    "preset": "nerd",
+    "overrides": {
+      "status.success": "●",
+      "status.error": "✖",
+      "status.warning": "◆",
+      "status.info": "○",
+      "status.pending": "◌",
+      "nav.cursor": "▸",
+      "nav.selected": "▴",
+      "thinking.minimal": "◌",
+      "thinking.low": "◍",
+      "thinking.medium": "◎",
+      "thinking.high": "◉",
+      "thinking.xhigh": "●",
+      "icon.model": "◇",
+      "icon.plan": "◈",
+      "icon.folder": "▸",
+      "icon.pi": "π",
+      "format.bullet": "◦",
+      "md.bullet": "◦"
+    }
+  }
+}

package/src/modes/theme/defaults/index.ts

@@ -27,6 +27,7 @@ import dark_nebula from "./dark-nebula.json" with { type: "json" };
 import dark_nord from "./dark-nord.json" with { type: "json" };
 import dark_ocean from "./dark-ocean.json" with { type: "json" };
 import dark_one from "./dark-one.json" with { type: "json" };
+import dark_poimandres from "./dark-poimandres.json" with { type: "json" };
 import dark_rainforest from "./dark-rainforest.json" with { type: "json" };
 import dark_reef from "./dark-reef.json" with { type: "json" };
 import dark_retro from "./dark-retro.json" with { type: "json" };
@@ -73,6 +74,7 @@ import light_one from "./light-one.json" with { type: "json" };
 import light_opal from "./light-opal.json" with { type: "json" };
 import light_orchard from "./light-orchard.json" with { type: "json" };
 import light_paper from "./light-paper.json" with { type: "json" };
+import light_poimandres from "./light-poimandres.json" with { type: "json" };
 import light_prism from "./light-prism.json" with { type: "json" };
 import light_retro from "./light-retro.json" with { type: "json" };
 import light_sand from "./light-sand.json" with { type: "json" };
@@ -125,6 +127,7 @@ export const defaultThemes = {
 	"dark-nord": dark_nord,
 	"dark-ocean": dark_ocean,
 	"dark-one": dark_one,
+	"dark-poimandres": dark_poimandres,
 	"dark-rainforest": dark_rainforest,
 	"dark-reef": dark_reef,
 	"dark-retro": dark_retro,
@@ -171,6 +174,7 @@ export const defaultThemes = {
 	"light-opal": light_opal,
 	"light-orchard": light_orchard,
 	"light-paper": light_paper,
+	"light-poimandres": light_poimandres,
 	"light-prism": light_prism,
 	"light-retro": light_retro,
 	"light-sand": light_sand,

package/src/modes/theme/defaults/light-poimandres.json

@@ -0,0 +1,138 @@
+{
+  "name": "light-poimandres",
+  "vars": {
+    "poimandresBg": "#e4f0fb",
+    "poimandresFocus": "#303340",
+    "poimandresGray": "#a6accd",
+    "poimandresDarkerGray": "#767c9d",
+    "poimandresBluishGray": "#506477",
+    "poimandresOffWhite": "#e4f0fb",
+    "poimandresBrightMint": "#5DE4c7",
+    "poimandresStrongTurquoise": "#00CED1",
+    "poimandresLowerMint": "#5fb3a1",
+    "poimandresLightBlue": "#ADD7FF",
+    "poimandresLowerBlue": "#89ddff",
+    "poimandresDesaturatedGreen": "#7AC6B6",
+    "poimandresHotRed": "#d0679d",
+    "poimandresPink": "#f087bd",
+    "poimandresBrightYellow": "#fffac2",
+    "poimandresBluishGrayBrighter": "#7390AA",
+    "poimandresSelection": "#717cb425",
+    "poimandresWhite": "#ffffff",
+    "poimandresBlack": "#000000",
+    "poimandresBg256": 235,
+    "poimandresFocus256": 238,
+    "poimandresGray256": 109,
+    "poimandresDarkerGray256": 103,
+    "poimandresBluishGray256": 66,
+    "poimandresBrightMint256": 86,
+    "poimandresStrongTurquoise256": 44,
+    "poimandresLowerMint256": 79,
+    "poimandresLightBlue256": 153,
+    "poimandresLowerBlue256": 117,
+    "poimandresDesaturatedGreen256": 79,
+    "poimandresHotRed256": 169,
+    "poimandresPink256": 211,
+    "poimandresBrightYellow256": 229,
+    "poimandresBluishGrayBrighter256": 110,
+    "poimandresSubtleBg": "#e4f0fb",
+    "poimandresMediumBg": "#d0d7e5",
+    "poimandresBrightBg": "#7390AA"
+  },
+  "colors": {
+    "accent": "poimandresStrongTurquoise",
+    "border": "poimandresDarkerGray",
+    "borderAccent": "poimandresBluishGray",
+    "borderMuted": "poimandresDarkerGray",
+    "success": "poimandresStrongTurquoise",
+    "error": "poimandresHotRed",
+    "warning": "poimandresBrightYellow",
+    "muted": "poimandresBluishGray",
+    "dim": "poimandresDarkerGray",
+    "text": "poimandresBluishGray",
+    "thinkingText": "poimandresBluishGray",
+    "selectedBg": "poimandresSelection",
+    "userMessageBg": "poimandresBluishGrayBrighter",
+    "userMessageText": "poimandresWhite",
+    "customMessageBg": "poimandresGray",
+    "customMessageText": "poimandresWhite",
+    "customMessageLabel": "poimandresStrongTurquoise",
+    "toolPendingBg": "poimandresBluishGrayBrighter",
+    "toolSuccessBg": "poimandresBluishGrayBrighter",
+    "toolErrorBg": "poimandresBluishGrayBrighter",
+    "toolTitle": "poimandresBrightMint",
+    "toolOutput": "poimandresBluishGray",
+    "mdHeading": "poimandresBrightMint",
+    "mdLink": "poimandresDesaturatedGreen",
+    "mdLinkUrl": "poimandresStrongTurquoise",
+    "mdCode": "poimandresStrongTurquoise",
+    "mdCodeBlock": "poimandresBluishGray",
+    "mdCodeBlockBorder": "poimandresGray",
+    "mdQuote": "poimandresDarkerGray",
+    "mdQuoteBorder": "poimandresBluishGray",
+    "mdHr": "poimandresDarkerGray",
+    "mdListBullet": "poimandresBrightMint",
+    "toolDiffAdded": "poimandresStrongTurquoise",
+    "toolDiffRemoved": "poimandresHotRed",
+    "toolDiffContext": "poimandresDarkerGray",
+    "syntaxComment": "poimandresDarkerGray",
+    "syntaxKeyword": "poimandresDesaturatedGreen",
+    "syntaxFunction": "poimandresBrightMint",
+    "syntaxVariable": "poimandresStrongTurquoise",
+    "syntaxString": "poimandresStrongTurquoise",
+    "syntaxNumber": "poimandresPink",
+    "syntaxType": "poimandresStrongTurquoise",
+    "syntaxOperator": "poimandresDesaturatedGreen",
+    "syntaxPunctuation": "poimandresBluishGray",
+    "thinkingOff": "poimandresDarkerGray",
+    "thinkingMinimal": "poimandresBluishGray",
+    "thinkingLow": "poimandresBrightMint",
+    "thinkingMedium": "poimandresStrongTurquoise",
+    "thinkingHigh": "poimandresPink",
+    "thinkingXhigh": "poimandresHotRed",
+    "bashMode": "poimandresDesaturatedGreen",
+    "pythonMode": "poimandresStrongTurquoise",
+    "statusLineBg": "poimandresBluishGrayBrighter",
+    "statusLineSep": 103,
+    "statusLineModel": "poimandresBrightMint",
+    "statusLinePath": "poimandresBluishGray",
+    "statusLineGitClean": "poimandresStrongTurquoise",
+    "statusLineGitDirty": "poimandresHotRed",
+    "statusLineContext": "poimandresBluishGray",
+    "statusLineSpend": "poimandresLowerMint",
+    "statusLineStaged": 44,
+    "statusLineDirty": 169,
+    "statusLineUntracked": 229,
+    "statusLineOutput": "poimandresLowerBlue",
+    "statusLineCost": "poimandresPink",
+    "statusLineSubagents": "poimandresDesaturatedGreen"
+  },
+  "export": {
+    "pageBg": "poimandresOffWhite",
+    "cardBg": "poimandresBluishGrayBrighter",
+    "infoBg": "poimandresFocus"
+  },
+  "symbols": {
+    "preset": "nerd",
+    "overrides": {
+      "status.success": "●",
+      "status.error": "✖",
+      "status.warning": "◆",
+      "status.info": "○",
+      "status.pending": "◌",
+      "nav.cursor": "▸",
+      "nav.selected": "▴",
+      "thinking.minimal": "◌",
+      "thinking.low": "◍",
+      "thinking.medium": "◎",
+      "thinking.high": "◉",
+      "thinking.xhigh": "●",
+      "icon.model": "◇",
+      "icon.plan": "◈",
+      "icon.folder": "▸",
+      "icon.pi": "π",
+      "format.bullet": "◦",
+      "md.bullet": "◦"
+    }
+  }
+}

package/src/patch/index.ts

@@ -104,8 +104,8 @@ const patchEditSchema = Type.Object({
 export type ReplaceParams = Static<typeof replaceEditSchema>;
 export type PatchParams = Static<typeof patchEditSchema>;
 
-/** Pattern matching hashline display format: `LINE#ID:CONTENT` */
-const HASHLINE_PREFIX_RE = /^\s*(?:>>>|>>)?\s*\d+#[0-9a-zA-Z]{1,16}:/;
+/** Pattern matching hashline display format prefixes: `LINE#ID:CONTENT` and `#ID:CONTENT` */
+const HASHLINE_PREFIX_RE = /^\s*(?:>>>|>>)?\s*(?:\d+\s*#\s*|#)\s*[0-9a-zA-Z]{1,16}:/;
 
 /** Pattern matching a unified-diff added-line `+` prefix (but not `++`). Does NOT match `-` to avoid corrupting Markdown list items. */
 const DIFF_PLUS_RE = /^[+](?![+])/;
@@ -118,8 +118,9 @@ const DIFF_PLUS_RE = /^[+](?![+])/;
  * output file. This strips them heuristically before application.
  */
 export function stripNewLinePrefixes(lines: string[]): string[] {
-	// Detect whether the *majority* of non-empty lines carry a prefix —
-	// if only one line out of many has a match it's likely real content.
+	// Hashline prefixes are highly specific to read output and should only be
+	// stripped when *every* non-empty line carries one.
+	// Diff '+' markers can be legitimate content less often, so keep majority mode.
 	let hashPrefixCount = 0;
 	let diffPlusCount = 0;
 	let nonEmpty = 0;
@@ -131,9 +132,8 @@ export function stripNewLinePrefixes(lines: string[]): string[] {
 	}
 	if (nonEmpty === 0) return lines;
 
-	const stripHash = hashPrefixCount > 0 && hashPrefixCount >= nonEmpty * 0.5;
+	const stripHash = hashPrefixCount > 0 && hashPrefixCount === nonEmpty;
 	const stripPlus = !stripHash && diffPlusCount > 0 && diffPlusCount >= nonEmpty * 0.5;
-
 	if (!stripHash && !stripPlus) return lines;
 
 	return lines.map(l => {
@@ -145,8 +145,7 @@ export function stripNewLinePrefixes(lines: string[]): string[] {
 
 export function hashlineParseText(edit: string[] | string | null): string[] {
 	if (edit === null) return [];
-	if (Array.isArray(edit)) return edit;
-	const lines = stripNewLinePrefixes(edit.split("\n"));
+	const lines = stripNewLinePrefixes(Array.isArray(edit) ? edit : edit.split("\n"));
 	if (lines.length === 0) return [];
 	if (lines[lines.length - 1].trim() === "") return lines.slice(0, -1);
 	return lines;

package/src/sdk.ts

@@ -1281,6 +1281,11 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		interruptMode: settings.get("interruptMode") ?? "immediate",
 		thinkingBudgets: settings.getGroup("thinkingBudgets"),
 		temperature: settings.get("temperature") >= 0 ? settings.get("temperature") : undefined,
+		topP: settings.get("topP") >= 0 ? settings.get("topP") : undefined,
+		topK: settings.get("topK") >= 0 ? settings.get("topK") : undefined,
+		minP: settings.get("minP") >= 0 ? settings.get("minP") : undefined,
+		presencePenalty: settings.get("presencePenalty") >= 0 ? settings.get("presencePenalty") : undefined,
+		repetitionPenalty: settings.get("repetitionPenalty") >= 0 ? settings.get("repetitionPenalty") : undefined,
 		kimiApiFormat: settings.get("providers.kimiApiFormat") ?? "anthropic",
 		preferWebsockets: preferOpenAICodexWebsockets,
 		getToolContext: tc => toolContextStore.getContext(tc),

package/src/task/render.ts

@@ -22,6 +22,7 @@ import {
 	type FindingPriority,
 	getPriorityInfo,
 	PRIORITY_LABELS,
+	parseReportFindingDetails,
 	type ReportFindingDetails,
 	type SubmitReviewDetails,
 } from "../tools/review";
@@ -68,6 +69,16 @@ function formatFindingSummary(findings: ReportFindingDetails[], theme: Theme): s
 	return `${theme.fg("dim", "Findings:")} ${parts.join(theme.sep.dot)}`;
 }
 
+function normalizeReportFindings(value: unknown): ReportFindingDetails[] {
+	if (!Array.isArray(value)) return [];
+	const findings: ReportFindingDetails[] = [];
+	for (const item of value) {
+		const finding = parseReportFindingDetails(item);
+		if (finding) findings.push(finding);
+	}
+	return findings;
+}
+
 function formatJsonScalar(value: unknown, _theme: Theme): string {
 	if (value === null) return "null";
 	if (typeof value === "string") {
@@ -569,13 +580,13 @@ function renderAgentProgress(
 		// For completed tasks, check for review verdict from submit_result tool
 		if (progress.status === "completed") {
 			const completeData = progress.extractedToolData.submit_result as Array<{ data: unknown }> | undefined;
-			const reportFindingData = progress.extractedToolData.report_finding as ReportFindingDetails[] | undefined;
+			const reportFindingData = normalizeReportFindings(progress.extractedToolData.report_finding);
 			const reviewData = completeData
 				?.map(c => c.data as SubmitReviewDetails)
 				.filter(d => d && typeof d === "object" && "overall_correctness" in d);
 			if (reviewData && reviewData.length > 0) {
 				const summary = reviewData[reviewData.length - 1];
-				const findings = reportFindingData ?? [];
+				const findings = reportFindingData;
 				lines.push(...renderReviewResult(summary, findings, continuePrefix, expanded, theme));
 				return lines; // Review result handles its own rendering
 			}
@@ -583,8 +594,9 @@ function renderAgentProgress(
 
 		for (const [toolName, dataArray] of Object.entries(progress.extractedToolData)) {
 			// Handle report_finding with tree formatting
-			if (toolName === "report_finding" && (dataArray as ReportFindingDetails[]).length > 0) {
-				const findings = dataArray as ReportFindingDetails[];
+			if (toolName === "report_finding") {
+				const findings = normalizeReportFindings(dataArray);
+				if (findings.length === 0) continue;
 				lines.push(`${continuePrefix}${formatFindingSummary(findings, theme)}`);
 				lines.push(...renderFindings(findings, continuePrefix, expanded, theme));
 				continue;
@@ -693,7 +705,7 @@ function renderFindings(
 
 		const { color } = getPriorityInfo(finding.priority);
 		const titleText = finding.title?.replace(/^\[P\d\]\s*/, "") ?? "Untitled";
-		const loc = `${path.basename(finding.file_path)}:${finding.line_start}`;
+		const loc = `${path.basename(finding.file_path || "<unknown>")}:${finding.line_start}`;
 
 		lines.push(
 			`${continuePrefix}${findingPrefix} ${theme.fg(color, `[${finding.priority}]`)} ${titleText} ${theme.fg("dim", loc)}`,
@@ -773,7 +785,7 @@ function renderAgentResult(result: SingleResult, isLast: boolean, expanded: bool
 
 	// Check for review result (submit_result with review schema + report_finding)
 	const completeData = result.extractedToolData?.submit_result as Array<{ data: unknown }> | undefined;
-	const reportFindingData = result.extractedToolData?.report_finding as ReportFindingDetails[] | undefined;
+	const reportFindingData = normalizeReportFindings(result.extractedToolData?.report_finding);
 
 	// Extract review verdict from submit_result tool's data field if it matches SubmitReviewDetails
 	const reviewData = completeData
@@ -784,11 +796,11 @@ function renderAgentResult(result: SingleResult, isLast: boolean, expanded: bool
 	if (submitReviewData && submitReviewData.length > 0) {
 		// Use combined review renderer
 		const summary = submitReviewData[submitReviewData.length - 1];
-		const findings = reportFindingData ?? [];
+		const findings = reportFindingData;
 		lines.push(...renderReviewResult(summary, findings, continuePrefix, expanded, theme));
 		return lines;
 	}
-	if (reportFindingData && reportFindingData.length > 0) {
+	if (reportFindingData.length > 0) {
 		const hasCompleteData = completeData && completeData.length > 0;
 		const message = hasCompleteData
 			? "Review verdict missing expected fields"

package/src/tools/review.ts

@@ -13,6 +13,7 @@ import type { AgentTool } from "@oh-my-pi/pi-agent-core";
 import { StringEnum } from "@oh-my-pi/pi-ai";
 import type { Component } from "@oh-my-pi/pi-tui";
 import { Container, Text } from "@oh-my-pi/pi-tui";
+import { isRecord } from "@oh-my-pi/pi-utils";
 import { Type } from "@sinclair/typebox";
 import type { Theme, ThemeColor } from "../modes/theme/theme";
 import { subprocessToolRegistry } from "../task/subprocess-tool-registry";
@@ -82,6 +83,51 @@ interface ReportFindingDetails {
 	line_end: number;
 }
 
+function isFindingPriority(value: unknown): value is FindingPriority {
+	return value === "P0" || value === "P1" || value === "P2" || value === "P3";
+}
+
+export function parseReportFindingDetails(value: unknown): ReportFindingDetails | undefined {
+	if (!isRecord(value)) return undefined;
+
+	const title = typeof value.title === "string" ? value.title : undefined;
+	const body = typeof value.body === "string" ? value.body : undefined;
+	const priority = isFindingPriority(value.priority) ? value.priority : undefined;
+	const confidence =
+		typeof value.confidence === "number" &&
+		Number.isFinite(value.confidence) &&
+		value.confidence >= 0 &&
+		value.confidence <= 1
+			? value.confidence
+			: undefined;
+	const filePath = typeof value.file_path === "string" && value.file_path.length > 0 ? value.file_path : undefined;
+	const lineStart =
+		typeof value.line_start === "number" && Number.isFinite(value.line_start) ? value.line_start : undefined;
+	const lineEnd = typeof value.line_end === "number" && Number.isFinite(value.line_end) ? value.line_end : undefined;
+
+	if (
+		title === undefined ||
+		body === undefined ||
+		priority === undefined ||
+		confidence === undefined ||
+		filePath === undefined ||
+		lineStart === undefined ||
+		lineEnd === undefined
+	) {
+		return undefined;
+	}
+
+	return {
+		title,
+		body,
+		priority,
+		confidence,
+		file_path: filePath,
+		line_start: lineStart,
+		line_end: lineEnd,
+	};
+}
+
 export const reportFindingTool: AgentTool<typeof ReportFindingParams, ReportFindingDetails, Theme> = {
 	name: "report_finding",
 	label: "Report Finding",
@@ -152,7 +198,10 @@ export type { ReportFindingDetails };
 
 // Register report_finding handler
 subprocessToolRegistry.register<ReportFindingDetails>("report_finding", {
-	extractData: event => event.result?.details as ReportFindingDetails | undefined,
+	extractData: event => {
+		if (event.isError) return undefined;
+		return parseReportFindingDetails(event.result?.details);
+	},
 
 	renderInline: (data, theme) => {
 		const { label, icon, color } = getPriorityDisplay(data.priority, theme);