@oh-my-pi/pi-coding-agent 13.12.3 → 13.12.4

package/CHANGELOG.md

@@ -2,6 +2,16 @@
 
 ## [Unreleased]
 
+## [13.12.4] - 2026-03-15
+### Added
+
+- Exposed `settings` instance in `CustomToolContext` for session-specific configuration access
+
+### Changed
+
+- Improved artifact spill configuration to use session settings with schema defaults as fallback
+- Refactored type annotations for better type safety in tool result handling
+
 ## [13.12.2] - 2026-03-15
 
 ### Added

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "13.12.3",
+	"version": "13.12.4",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://github.com/can1357/oh-my-pi",
 	"author": "Can Boluk",
@@ -41,12 +41,12 @@
 	},
 	"dependencies": {
 		"@mozilla/readability": "^0.6",
-		"@oh-my-pi/omp-stats": "13.12.3",
-		"@oh-my-pi/pi-agent-core": "13.12.3",
-		"@oh-my-pi/pi-ai": "13.12.3",
-		"@oh-my-pi/pi-natives": "13.12.3",
-		"@oh-my-pi/pi-tui": "13.12.3",
-		"@oh-my-pi/pi-utils": "13.12.3",
+		"@oh-my-pi/omp-stats": "13.12.4",
+		"@oh-my-pi/pi-agent-core": "13.12.4",
+		"@oh-my-pi/pi-ai": "13.12.4",
+		"@oh-my-pi/pi-natives": "13.12.4",
+		"@oh-my-pi/pi-tui": "13.12.4",
+		"@oh-my-pi/pi-utils": "13.12.4",
 		"@sinclair/typebox": "^0.34",
 		"@xterm/headless": "^6.0",
 		"ajv": "^8.18",

package/src/extensibility/custom-tools/types.ts

@@ -10,6 +10,7 @@ import type { Component } from "@oh-my-pi/pi-tui";
 import type { Static, TSchema } from "@sinclair/typebox";
 import type { Rule } from "../../capability/rule";
 import type { ModelRegistry } from "../../config/model-registry";
+import type { Settings } from "../../config/settings";
 import type { ExecOptions, ExecResult } from "../../exec/exec";
 import type { HookUIContext } from "../../extensibility/hooks/types";
 import type { Theme } from "../../modes/theme/theme";
@@ -76,6 +77,8 @@ export interface CustomToolContext {
 	hasQueuedMessages(): boolean;
 	/** Abort the current agent operation (fire-and-forget, does not wait) */
 	abort(): void;
+	/** Settings instance for the current session. Prefer over the global singleton. */
+	settings?: Settings;
 }
 
 /** Session event passed to onSession callback */

package/src/sdk.ts

@@ -79,7 +79,7 @@ import {
 	loadProjectContextFiles as loadContextFilesInternal,
 } from "./system-prompt";
 import { AgentOutputManager } from "./task/output-manager";
-import { resolveThinkingLevelForModel, toReasoningEffort } from "./thinking";
+import { parseThinkingLevel, resolveThinkingLevelForModel, toReasoningEffort } from "./thinking";
 import {
 	BashTool,
 	BUILTIN_TOOLS,
@@ -626,7 +626,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 	if (!options.modelRegistry) {
 		modelRegistry.refreshInBackground();
 	}
-	const skillsSettings = settings.getGroup("skills") as SkillsSettings;
+	const skillsSettings = settings.getGroup("skills");
 	const disabledExtensionIds = settings.get("disabledExtensions") ?? [];
 	const discoveredSkillsPromise =
 		options.skills === undefined
@@ -711,7 +711,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 
 	// If session has data and includes a thinking entry, restore it
 	if (thinkingLevel === undefined && hasExistingSession && hasThinkingEntry) {
-		thinkingLevel = existingSession.thinkingLevel as ThinkingLevel | undefined;
+		thinkingLevel = parseThinkingLevel(existingSession.thinkingLevel);
 	}
 
 	if (thinkingLevel === undefined && !hasExplicitModel && !hasThinkingEntry && defaultRoleSpec.explicitThinkingLevel) {
@@ -935,7 +935,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 				// Always filter Exa - we have native integration
 				filterExa: true,
 				// Filter browser MCP servers when builtin browser tool is active
-				filterBrowser: (settings.get("browser.enabled") as boolean) ?? false,
+				filterBrowser: settings.get("browser.enabled") ?? false,
 				cacheStorage: settings.getStorage(),
 				authStorage,
 			}),
@@ -1005,10 +1005,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		extensionsResult = options.preloadedExtensions;
 	} else {
 		// Merge CLI extension paths with settings extension paths
-		const configuredPaths = [
-			...(options.additionalExtensionPaths ?? []),
-			...((settings.get("extensions") as string[]) ?? []),
-		];
+		const configuredPaths = [...(options.additionalExtensionPaths ?? []), ...(settings.get("extensions") ?? [])];
 		const disabledExtensionIds = settings.get("disabledExtensions") ?? [];
 		extensionsResult = await logger.timeAsync(
 			"discoverAndLoadExtensions",
@@ -1118,11 +1115,12 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		abort: () => {
 			session.abort();
 		},
+		settings,
 	});
 	const toolContextStore = new ToolContextStore(getSessionContext);
 
 	const registeredTools = extensionRunner?.getAllRegisteredTools() ?? [];
-	let wrappedExtensionTools: AgentTool[];
+	let wrappedExtensionTools: Tool[];
 
 	if (extensionRunner) {
 		// With extension runner: convert CustomTools to ToolDefinitions and wrap all together
@@ -1144,16 +1142,17 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 			isIdle: () => !session?.isStreaming,
 			hasQueuedMessages: () => (session?.queuedMessageCount ?? 0) > 0,
 			abort: () => session?.abort(),
+			settings,
 		});
 		wrappedExtensionTools = (options.customTools ?? [])
 			.filter(isCustomTool)
-			.map(tool => CustomToolAdapter.wrap(tool, customToolContext) as AgentTool);
+			.map(tool => CustomToolAdapter.wrap(tool, customToolContext));
 	}
 
 	// All built-in tools are active (conditional tools like git/ask return null from factory if disabled)
-	const toolRegistry = new Map<string, AgentTool>();
+	const toolRegistry = new Map<string, Tool>();
 	for (const tool of builtinTools) {
-		toolRegistry.set(tool.name, tool as AgentTool);
+		toolRegistry.set(tool.name, tool);
 	}
 	for (const tool of wrappedExtensionTools) {
 		toolRegistry.set(tool.name, tool);
@@ -1173,7 +1172,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 	} else if (!toolRegistry.has("resolve")) {
 		const resolveTool = await logger.timeAsync("createTools:resolve:session", HIDDEN_TOOLS.resolve, toolSession);
 		if (resolveTool) {
-			toolRegistry.set(resolveTool.name, wrapToolWithMetaNotice(resolveTool) as AgentTool);
+			toolRegistry.set(resolveTool.name, wrapToolWithMetaNotice(resolveTool));
 		}
 	}
 
@@ -1218,7 +1217,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 			tools,
 			toolNames,
 			rules: rulebookRules,
-			skillsSettings: settings.getGroup("skills") as SkillsSettings,
+			skillsSettings: settings.getGroup("skills"),
 			appendSystemPrompt: appendPrompt,
 			repeatToolDescriptions,
 			eagerTasks,
@@ -1236,7 +1235,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 				tools,
 				toolNames,
 				rules: rulebookRules,
-				skillsSettings: settings.getGroup("skills") as SkillsSettings,
+				skillsSettings: settings.getGroup("skills"),
 				customPrompt: options.systemPrompt,
 				appendSystemPrompt: appendPrompt,
 				repeatToolDescriptions,
@@ -1297,17 +1296,12 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 					if (hasImages) {
 						const filteredContent = content
 							.map(c => (c.type === "image" ? { type: "text" as const, text: "Image reading is disabled." } : c))
-							.filter(
-								(c, i, arr) =>
-									// Dedupe consecutive "Image reading is disabled." texts
-									!(
-										c.type === "text" &&
-										c.text === "Image reading is disabled." &&
-										i > 0 &&
-										arr[i - 1].type === "text" &&
-										(arr[i - 1] as { type: "text"; text: string }).text === "Image reading is disabled."
-									),
-							);
+							.filter((c, i, arr) => {
+								// Dedupe consecutive "Image reading is disabled." texts
+								if (!(c.type === "text" && c.text === "Image reading is disabled." && i > 0)) return true;
+								const prev = arr[i - 1];
+								return !(prev.type === "text" && prev.text === "Image reading is disabled.");
+							});
 						return { ...msg, content: filteredContent };
 					}
 				}
@@ -1439,7 +1433,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		customCommands: customCommandsResult.commands,
 		skills,
 		skillWarnings,
-		skillsSettings: settings.getGroup("skills") as Required<SkillsSettings>,
+		skillsSettings: settings.getGroup("skills"),
 		modelRegistry,
 		toolRegistry,
 		transformContext,
@@ -1514,7 +1508,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		mcpManager.setOnResourcesChanged((serverName, uri) => {
 			logger.debug("MCP resources changed", { path: `mcp:${serverName}`, uri });
 			if (!settings.get("mcp.notifications")) return;
-			const debounceMs = (settings.get("mcp.notificationDebounceMs") as number) ?? 500;
+			const debounceMs = settings.get("mcp.notificationDebounceMs");
 			const key = `${serverName}:${uri}`;
 			const existing = notificationDebounceTimers.get(key);
 			if (existing) clearTimeout(existing);

package/src/session/agent-session.ts

@@ -191,7 +191,7 @@ export interface AgentSessionConfig {
 	skillWarnings?: SkillWarning[];
 	/** Custom commands (TypeScript slash commands) */
 	customCommands?: LoadedCustomCommand[];
-	skillsSettings?: Required<SkillsSettings>;
+	skillsSettings?: SkillsSettings;
 	/** Model registry for API key resolution and model discovery */
 	modelRegistry: ModelRegistry;
 	/** Tool registry for LSP and settings */
@@ -383,7 +383,7 @@ export class AgentSession {
 	/** MCP prompt commands (updated dynamically when prompts are loaded) */
 	#mcpPromptCommands: LoadedCustomCommand[] = [];
 
-	#skillsSettings: Required<SkillsSettings> | undefined;
+	#skillsSettings: SkillsSettings | undefined;
 
 	// Model registry for API key resolution
 	#modelRegistry: ModelRegistry;
@@ -2518,7 +2518,7 @@ export class AgentSession {
 		return undefined;
 	}
 
-	get skillsSettings(): Required<SkillsSettings> | undefined {
+	get skillsSettings(): SkillsSettings | undefined {
 		return this.#skillsSettings;
 	}
 

package/src/tools/output-meta.ts

@@ -12,7 +12,7 @@ import type {
 	AgentToolUpdateCallback,
 } from "@oh-my-pi/pi-agent-core";
 import type { ImageContent, TextContent } from "@oh-my-pi/pi-ai";
-import { settings } from "../config/settings";
+import { getDefault, type Settings } from "../config/settings";
 import { formatGroupedDiagnosticMessages } from "../lsp/utils";
 import type { Theme } from "../modes/theme/theme";
 import { type OutputSummary, type TruncationResult, truncateTail } from "../session/streaming-output";
@@ -415,16 +415,17 @@ export function formatStyledTruncationWarning(meta: OutputMeta | undefined, them
  * Append output notice to tool result content if meta is present.
  */
 function appendOutputNotice(
-	content: Array<{ type: string; text?: string }>,
+	content: (TextContent | ImageContent)[],
 	meta: OutputMeta | undefined,
-): Array<{ type: string; text?: string }> {
+): (TextContent | ImageContent)[] {
 	const notice = formatOutputNotice(meta);
 	if (!notice) return content;
 
 	const result = [...content];
 	for (let i = result.length - 1; i >= 0; i--) {
-		if (result[i].type === "text" && result[i].text != null) {
-			result[i] = { ...result[i], text: result[i].text + notice };
+		const item = result[i];
+		if (item.type === "text") {
+			result[i] = { ...item, text: item.text + notice };
 			return result;
 		}
 	}
@@ -439,19 +440,16 @@ const kUnwrappedExecute = Symbol("OutputMeta.UnwrappedExecute");
 // Centralized artifact spill for large tool results
 // =============================================================================
 
-/** Artifact spill threshold — tool output above this size is saved as an artifact. */
-function getArtifactSpillThreshold(): number {
-	return settings.get("tools.artifactSpillThreshold") * 1024;
-}
-
-/** When spilling, keep this many bytes of tail in the result sent to the LLM. */
-function getArtifactTailBytes(): number {
-	return settings.get("tools.artifactTailBytes") * 1024;
-}
-
-/** When spilling, keep at most this many lines of tail. */
-function getArtifactTailLines(): number {
-	return settings.get("tools.artifactTailLines");
+/** Resolved artifact spill config sourced from the session settings (or schema defaults). */
+function getSpillConfig(s: Settings | undefined) {
+	const get = <P extends "tools.artifactSpillThreshold" | "tools.artifactTailBytes" | "tools.artifactTailLines">(
+		path: P,
+	) => s?.get(path) ?? getDefault(path);
+	return {
+		threshold: get("tools.artifactSpillThreshold") * 1024,
+		tailBytes: get("tools.artifactTailBytes") * 1024,
+		tailLines: get("tools.artifactTailLines"),
+	};
 }
 
 /**
@@ -467,9 +465,10 @@ async function spillLargeResultToArtifact(
 ): Promise<AgentToolResult> {
 	const sessionManager = context?.sessionManager;
 	if (!sessionManager) return result;
+	const { threshold, tailBytes, tailLines } = getSpillConfig(context?.settings);
 
 	// Skip if tool already saved an artifact
-	const existingMeta = (result.details as { meta?: OutputMeta } | undefined)?.meta;
+	const existingMeta: OutputMeta | undefined = result.details?.meta;
 	if (existingMeta?.truncation?.artifactId) return result;
 
 	// Measure total text content
@@ -483,7 +482,7 @@ async function spillLargeResultToArtifact(
 
 	const fullText = textParts.length === 1 ? textParts[0] : textParts.join("\n");
 	const totalBytes = Buffer.byteLength(fullText, "utf-8");
-	if (totalBytes <= getArtifactSpillThreshold()) return result;
+	if (totalBytes <= threshold) return result;
 
 	// Save full output as artifact
 	const artifactId = await sessionManager.saveArtifact(fullText, toolName);
@@ -491,8 +490,8 @@ async function spillLargeResultToArtifact(
 
 	// Truncate to tail
 	const truncated = truncateTail(fullText, {
-		maxBytes: getArtifactTailBytes(),
-		maxLines: getArtifactTailLines(),
+		maxBytes: tailBytes,
+		maxLines: tailLines,
 	});
 
 	// Replace text blocks with single tail-truncated block, keep images
@@ -515,7 +514,7 @@ async function spillLargeResultToArtifact(
 		totalBytes: truncated.totalBytes,
 		outputLines,
 		outputBytes,
-		maxBytes: getArtifactTailBytes(),
+		maxBytes: tailBytes,
 		shownRange: { start: shownStart, end: truncated.totalLines },
 		artifactId,
 	};
@@ -547,11 +546,11 @@ async function wrappedExecute(
 		result = await spillLargeResultToArtifact(result, this.name, context);
 
 		// Append notices from meta
-		const meta = (result.details as { meta?: OutputMeta } | undefined)?.meta;
+		const meta: OutputMeta | undefined = result.details?.meta;
 		if (meta) {
 			return {
 				...result,
-				content: appendOutputNotice(result.content, meta) as (TextContent | ImageContent)[],
+				content: appendOutputNotice(result.content, meta),
 			};
 		}
 		return result;