@oh-my-pi/pi-coding-agent 13.1.2 → 13.2.1

package/CHANGELOG.md

@@ -2,6 +2,37 @@
 
 ## [Unreleased]
 
+## [13.2.1] - 2026-02-24
+
+### Fixed
+- Fixed changelog tools to enforce category-specific arrays and reuse the shared category list for generation
+- Non-interactive environment variables (pager, editor, prompt suppression) were not applied to non-PTY bash execution, causing commands to potentially block on pagers or prompts
+
+### Changed
+
+- Extracted non-interactive environment config from `bash-interactive.ts` into shared `non-interactive-env.ts` module, applied consistently to all bash execution paths
+
+## [13.2.0] - 2026-02-23
+### Breaking Changes
+
+- Made `description` field required in CustomTool interface
+
+### Changed
+
+- Reorganized imports from `@oh-my-pi/pi-utils/dirs` to consolidate with main `@oh-my-pi/pi-utils` exports for cleaner dependency management
+- Renamed `loadSkillsFromDir` to `scanSkillsFromDir` with updated interface for improved clarity on skill discovery behavior
+- Moved `tryParseJson` utility from local scrapers module to `@oh-my-pi/pi-utils` for centralized JSON parsing
+- Simplified patch module exports by consolidating type re-exports with `export * from './types'`
+- Removed `emitCustomToolSessionEvent` method from AgentSession for streamlined session lifecycle management
+- Changed skill discovery from recursive to non-recursive (one level deep only) for improved performance and clarity
+- Simplified skill loading logic by removing recursive directory traversal and consolidating ignore rule handling
+
+### Removed
+
+- Removed `parseJSON` helper function from discovery module (replaced by `tryParseJson` from pi-utils)
+- Removed backwards compatibility comment from `AskToolDetails.question` field
+- Removed unused SSH resource cleanup functions `closeAllConnections` and `unmountAll` from session imports
+
 ## [13.1.2] - 2026-02-23
 ### Breaking Changes
 

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "13.1.2",
+	"version": "13.2.1",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://github.com/can1357/oh-my-pi",
 	"author": "Can Boluk",
@@ -41,12 +41,12 @@
 	},
 	"dependencies": {
 		"@mozilla/readability": "^0.6",
-		"@oh-my-pi/omp-stats": "13.1.2",
-		"@oh-my-pi/pi-agent-core": "13.1.2",
-		"@oh-my-pi/pi-ai": "13.1.2",
-		"@oh-my-pi/pi-natives": "13.1.2",
-		"@oh-my-pi/pi-tui": "13.1.2",
-		"@oh-my-pi/pi-utils": "13.1.2",
+		"@oh-my-pi/omp-stats": "13.2.1",
+		"@oh-my-pi/pi-agent-core": "13.2.1",
+		"@oh-my-pi/pi-ai": "13.2.1",
+		"@oh-my-pi/pi-natives": "13.2.1",
+		"@oh-my-pi/pi-tui": "13.2.1",
+		"@oh-my-pi/pi-utils": "13.2.1",
 		"@sinclair/typebox": "^0.34",
 		"@xterm/headless": "^6.0",
 		"ajv": "^8.18",

package/scripts/format-prompts.ts

@@ -11,6 +11,7 @@
  * 6. Collapse 2+ blank lines to single blank line
  * 7. Trim trailing whitespace (preserve indentation)
  * 8. No trailing newline at EOF
+ * 9. Bold RFC 2119 keywords (MUST, SHOULD, MAY, etc.) in prompt content
  */
 import { Glob } from "bun";
 
@@ -37,6 +38,23 @@ const TABLE_ROW = /^\|.*\|$/;
 // Table separator (|---|---|)
 const TABLE_SEP = /^\|[-:\s|]+\|$/;
 
+/** RFC 2119 keywords used in prompts. */
+const RFC2119_KEYWORDS = /\b(?:MUST NOT|SHOULD NOT|SHALL NOT|RECOMMENDED|REQUIRED|OPTIONAL|SHOULD|SHALL|MUST|MAY)\b/g;
+
+function boldRfc2119Keywords(line: string): string {
+	return line.replace(RFC2119_KEYWORDS, (match, offset, source) => {
+		const isAlreadyBold =
+			source[offset - 2] === "*" &&
+			source[offset - 1] === "*" &&
+			source[offset + match.length] === "*" &&
+			source[offset + match.length + 1] === "*";
+		if (isAlreadyBold) {
+			return match;
+		}
+		return `**${match}**`;
+	});
+}
+
 /** Compact a table row by trimming cell padding */
 function compactTableRow(line: string): string {
 	// Split by |, trim each cell, rejoin
@@ -62,12 +80,6 @@ function compactTableSep(line: string): string {
 }
 
 function formatPrompt(content: string): string {
-	// Replace common ascii ellipsis and arrow patterns with their unicode equivalents
-	content = content
-		.replace(/\.{3}/g, "…")
-		.replace(/->/g, "→")
-		.replace(/<-/g, "←")
-		.replace(/<->/g, "↔");
 	const lines = content.split("\n");
 	const result: string[] = [];
 	let inCodeBlock = false;
@@ -75,9 +87,9 @@ function formatPrompt(content: string): string {
 	const topLevelTags: string[] = [];
 
 	for (let i = 0; i < lines.length; i++) {
-		let line = lines[i];
+		let line = lines[i].trimEnd();
 
-		const trimmed = line.trim();
+		const trimmed = line.trimStart();
 
 		// Track code blocks - don't modify inside them
 		if (CODE_FENCE.test(trimmed)) {
@@ -91,9 +103,18 @@ function formatPrompt(content: string): string {
 			continue;
 		}
 
+		// Replace common ascii ellipsis and arrow patterns with their unicode equivalents
+		line = line
+			.replace(/\.{3}/g, "…")
+			.replace(/->/g, "→")
+			.replace(/<-/g, "←")
+			.replace(/<->/g, "↔")
+			.replace(/!=/g, "≠")
+			.replace(/<=/g, "≤")
+			.replace(/>=/g, "≥");
+			
 		// Track top-level XML opening tags for depth-aware indent stripping
-		const isOpeningXml =
-			OPENING_XML.test(trimmed) && !trimmed.endsWith("/>");
+		const isOpeningXml = OPENING_XML.test(trimmed) && !trimmed.endsWith("/>");
 		if (isOpeningXml && line.length === trimmed.length) {
 			// Opening tag at column 0 — track as top-level
 			const match = OPENING_XML.exec(trimmed);
@@ -104,10 +125,7 @@ function formatPrompt(content: string): string {
 		const closingMatch = CLOSING_XML.exec(trimmed);
 		if (closingMatch) {
 			const tagName = closingMatch[1];
-			if (
-				topLevelTags.length > 0 &&
-				topLevelTags[topLevelTags.length - 1] === tagName
-			) {
+			if (topLevelTags.length > 0 && topLevelTags[topLevelTags.length - 1] === tagName) {
 				// Closing tag matches a top-level opener — strip indent
 				line = trimmed;
 				topLevelTags.pop();
@@ -126,6 +144,7 @@ function formatPrompt(content: string): string {
 			// Trim trailing whitespace (preserve leading for non-closing-tags)
 			line = line.trimEnd();
 		}
+		line = boldRfc2119Keywords(line);
 
 		const isBlank = trimmed === "";
 

package/src/async/job-manager.ts

@@ -47,6 +47,7 @@ export interface AsyncJobRegisterOptions {
 export class AsyncJobManager {
 	readonly #jobs = new Map<string, AsyncJob>();
 	readonly #deliveries: AsyncJobDelivery[] = [];
+	readonly #suppressedDeliveries = new Set<string>();
 	readonly #evictionTimers = new Map<string, NodeJS.Timeout>();
 	readonly #onJobComplete: AsyncJobManagerOptions["onJobComplete"];
 	readonly #maxRunningJobs: number;
@@ -81,6 +82,7 @@ export class AsyncJobManager {
 		}
 
 		const id = this.#resolveJobId(options?.id);
+		this.#suppressedDeliveries.delete(id);
 		const abortController = new AbortController();
 		const startTime = Date.now();
 
@@ -182,6 +184,23 @@ export class AsyncJobManager {
 		return this.#deliveries.length > 0;
 	}
 
+	acknowledgeDeliveries(jobIds: string[]): number {
+		const uniqueJobIds = Array.from(new Set(jobIds.map(id => id.trim()).filter(id => id.length > 0)));
+		if (uniqueJobIds.length === 0) return 0;
+
+		for (const jobId of uniqueJobIds) {
+			this.#suppressedDeliveries.add(jobId);
+		}
+
+		const before = this.#deliveries.length;
+		this.#deliveries.splice(
+			0,
+			this.#deliveries.length,
+			...this.#deliveries.filter(delivery => !this.#suppressedDeliveries.has(delivery.jobId)),
+		);
+		return before - this.#deliveries.length;
+	}
+
 	cancelAll(): void {
 		for (const job of this.getRunningJobs()) {
 			job.status = "cancelled";
@@ -234,6 +253,7 @@ export class AsyncJobManager {
 		this.#clearEvictionTimers();
 		this.#jobs.clear();
 		this.#deliveries.length = 0;
+		this.#suppressedDeliveries.clear();
 		return drained;
 	}
 
@@ -257,6 +277,7 @@ export class AsyncJobManager {
 	#scheduleEviction(jobId: string): void {
 		if (this.#retentionMs <= 0) {
 			this.#jobs.delete(jobId);
+			this.#suppressedDeliveries.delete(jobId);
 			return;
 		}
 		const existing = this.#evictionTimers.get(jobId);
@@ -266,6 +287,7 @@ export class AsyncJobManager {
 		const timer = setTimeout(() => {
 			this.#evictionTimers.delete(jobId);
 			this.#jobs.delete(jobId);
+			this.#suppressedDeliveries.delete(jobId);
 		}, this.#retentionMs);
 		timer.unref();
 		this.#evictionTimers.set(jobId, timer);
@@ -278,7 +300,14 @@ export class AsyncJobManager {
 		this.#evictionTimers.clear();
 	}
 
+	#isDeliverySuppressed(jobId: string): boolean {
+		return this.#suppressedDeliveries.has(jobId);
+	}
+
 	#enqueueDelivery(jobId: string, text: string): void {
+		if (this.#isDeliverySuppressed(jobId)) {
+			return;
+		}
 		this.#deliveries.push({
 			jobId,
 			text,
@@ -308,10 +337,21 @@ export class AsyncJobManager {
 	async #runDeliveryLoop(): Promise<void> {
 		while (this.#deliveries.length > 0) {
 			const delivery = this.#deliveries[0];
+			if (this.#isDeliverySuppressed(delivery.jobId)) {
+				this.#deliveries.shift();
+				continue;
+			}
 			const waitMs = delivery.nextAttemptAt - Date.now();
 			if (waitMs > 0) {
 				await Bun.sleep(waitMs);
 			}
+			if (this.#deliveries[0] !== delivery) {
+				continue;
+			}
+			if (this.#isDeliverySuppressed(delivery.jobId)) {
+				this.#deliveries.shift();
+				continue;
+			}
 
 			try {
 				await this.#onJobComplete(delivery.jobId, delivery.text, this.#jobs.get(delivery.jobId));
@@ -321,7 +361,9 @@ export class AsyncJobManager {
 				delivery.lastError = error instanceof Error ? error.message : String(error);
 				delivery.nextAttemptAt = Date.now() + this.#getRetryDelay(delivery.attempt);
 				this.#deliveries.shift();
-				this.#deliveries.push(delivery);
+				if (!this.#isDeliverySuppressed(delivery.jobId)) {
+					this.#deliveries.push(delivery);
+				}
 				logger.warn("Async job completion delivery failed", {
 					jobId: delivery.jobId,
 					attempt: delivery.attempt,

package/src/capability/index.ts

@@ -8,8 +8,7 @@
  */
 import * as os from "node:os";
 import * as path from "node:path";
-import { logger } from "@oh-my-pi/pi-utils";
-import { getProjectDir } from "@oh-my-pi/pi-utils/dirs";
+import { getProjectDir, logger } from "@oh-my-pi/pi-utils";
 
 import type { Settings } from "../config/settings";
 import { clearCache as clearFsCache, cacheStats as fsCacheStats, invalidate as invalidateFs } from "./fs";

package/src/capability/tool.ts

@@ -15,7 +15,7 @@ export interface CustomTool {
 	/** Absolute path to tool definition file */
 	path: string;
 	/** Tool description */
-	description?: string;
+	description: string;
 	/** Tool implementation (script path or inline) */
 	implementation?: string;
 	/** Source level */

package/src/cli/args.ts

@@ -2,8 +2,7 @@
  * CLI argument parsing and help display
  */
 import type { ThinkingLevel } from "@oh-my-pi/pi-agent-core";
-import { logger } from "@oh-my-pi/pi-utils";
-import { APP_NAME, CONFIG_DIR_NAME } from "@oh-my-pi/pi-utils/dirs";
+import { APP_NAME, CONFIG_DIR_NAME, logger } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 import { BUILTIN_TOOLS } from "../tools";
 

package/src/cli/config-cli.ts

@@ -5,7 +5,7 @@
  * Uses settings-defs as the source of truth for available settings.
  */
 
-import { APP_NAME, getAgentDir } from "@oh-my-pi/pi-utils/dirs";
+import { APP_NAME, getAgentDir } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 import {
 	getDefault,

package/src/cli/file-processor.ts

@@ -4,8 +4,7 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 import type { ImageContent } from "@oh-my-pi/pi-ai";
-import { isEnoent } from "@oh-my-pi/pi-utils";
-import { getProjectDir } from "@oh-my-pi/pi-utils/dirs";
+import { getProjectDir, isEnoent } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 import { resolveReadPath } from "../tools/path-utils";
 import { formatBytes } from "../tools/render-utils";

package/src/cli/grep-cli.ts

@@ -5,7 +5,7 @@
  */
 import * as path from "node:path";
 import { grep } from "@oh-my-pi/pi-natives";
-import { APP_NAME } from "@oh-my-pi/pi-utils/dirs";
+import { APP_NAME } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 
 export interface GrepCommandArgs {

package/src/cli/jupyter-cli.ts

@@ -4,7 +4,7 @@
  * Handles `omp jupyter` subcommand for managing the shared Python gateway.
  */
 
-import { APP_NAME } from "@oh-my-pi/pi-utils/dirs";
+import { APP_NAME } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 import { getGatewayStatus, shutdownSharedGateway } from "../ipy/gateway-coordinator";
 

package/src/cli/plugin-cli.ts

@@ -4,7 +4,7 @@
  * Handles `omp plugin <command>` subcommands for plugin lifecycle management.
  */
 
-import { APP_NAME } from "@oh-my-pi/pi-utils/dirs";
+import { APP_NAME } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 import { PluginManager, parseSettingValue, validateSetting } from "../extensibility/plugins";
 import { theme } from "../modes/theme/theme";

package/src/cli/setup-cli.ts

@@ -4,7 +4,7 @@
  * Handles `omp setup <component>` to install dependencies for optional features.
  */
 import * as path from "node:path";
-import { APP_NAME, getPythonEnvDir } from "@oh-my-pi/pi-utils/dirs";
+import { APP_NAME, getPythonEnvDir } from "@oh-my-pi/pi-utils";
 import { $ } from "bun";
 import chalk from "chalk";
 import { theme } from "../modes/theme/theme";

package/src/cli/shell-cli.ts

@@ -6,7 +6,7 @@
 import * as path from "node:path";
 import { createInterface } from "node:readline/promises";
 import { Shell } from "@oh-my-pi/pi-natives";
-import { APP_NAME, getProjectDir } from "@oh-my-pi/pi-utils/dirs";
+import { APP_NAME, getProjectDir } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 import { Settings } from "../config/settings";
 import { getOrCreateSnapshot } from "../utils/shell-snapshot";

package/src/cli/ssh-cli.ts

@@ -4,7 +4,7 @@
  * Handles `omp ssh <command>` subcommands for SSH host configuration management.
  */
 
-import { getSSHConfigPath } from "@oh-my-pi/pi-utils/dirs";
+import { getSSHConfigPath } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 import { addSSHHost, readSSHConfigFile, removeSSHHost, type SSHHostConfig } from "../ssh/config-writer";
 

package/src/cli/stats-cli.ts

@@ -4,8 +4,7 @@
  * Handles `omp stats` subcommand for viewing AI usage statistics.
  */
 
-import { formatDuration, formatNumber, formatPercent } from "@oh-my-pi/pi-utils";
-import { APP_NAME } from "@oh-my-pi/pi-utils/dirs";
+import { APP_NAME, formatDuration, formatNumber, formatPercent } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 import { openPath } from "../utils/open";
 

package/src/cli/update-cli.ts

@@ -7,8 +7,7 @@
 import { execSync, spawnSync } from "node:child_process";
 import * as fs from "node:fs";
 import { pipeline } from "node:stream/promises";
-import { isEnoent } from "@oh-my-pi/pi-utils";
-import { APP_NAME, VERSION } from "@oh-my-pi/pi-utils/dirs";
+import { APP_NAME, isEnoent, VERSION } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 import { theme } from "../modes/theme/theme";
 

package/src/cli/web-search-cli.ts

@@ -4,7 +4,7 @@
  * Handles `omp q`/`omp web-search` subcommands for testing web search providers.
  */
 
-import { APP_NAME } from "@oh-my-pi/pi-utils/dirs";
+import { APP_NAME } from "@oh-my-pi/pi-utils";
 import chalk from "chalk";
 import { initTheme, theme } from "../modes/theme/theme";
 import { runSearchQuery, type SearchParams } from "../web/search/index";

package/src/cli.ts

@@ -1,10 +1,10 @@
 #!/usr/bin/env bun
+import { APP_NAME, VERSION } from "@oh-my-pi/pi-utils";
 /**
  * CLI entry point — registers all commands explicitly and delegates to the
  * lightweight CLI runner from pi-utils.
  */
 import { type CommandEntry, run } from "@oh-my-pi/pi-utils/cli";
-import { APP_NAME, VERSION } from "@oh-my-pi/pi-utils/dirs";
 
 // Detect known Bun errata that cause TUI crashes (e.g. Bun.stringWidth mishandling OSC sequences).
 if (Bun.stringWidth("\x1b[0m\x1b]8;;\x07") !== 0) {

package/src/commands/launch.ts

@@ -1,8 +1,9 @@
 /**
  * Root command for the coding agent CLI.
  */
+
+import { APP_NAME } from "@oh-my-pi/pi-utils";
 import { Args, Command, Flags } from "@oh-my-pi/pi-utils/cli";
-import { APP_NAME } from "@oh-my-pi/pi-utils/dirs";
 import { parseArgs } from "../cli/args";
 import { runRootCommand } from "../main";
 

package/src/commit/agentic/agent.ts

@@ -1,3 +1,4 @@
+import { INTENT_FIELD } from "@oh-my-pi/pi-agent-core";
 import type { Api, Model } from "@oh-my-pi/pi-ai";
 import { Markdown } from "@oh-my-pi/pi-tui";
 import chalk from "chalk";
@@ -245,7 +246,7 @@ function formatToolArgs(args?: Record<string, unknown>): string[] {
 		}
 	};
 	for (const [key, value] of Object.entries(args)) {
-		if (key === "agent__intent") continue;
+		if (key === INTENT_FIELD) continue;
 		visit(value, key);
 	}
 	return lines;

package/src/commit/agentic/index.ts

@@ -1,7 +1,6 @@
 import * as path from "node:path";
 import { createInterface } from "node:readline/promises";
-import { $env, isEnoent } from "@oh-my-pi/pi-utils";
-import { getProjectDir } from "@oh-my-pi/pi-utils/dirs";
+import { $env, getProjectDir, isEnoent } from "@oh-my-pi/pi-utils";
 import { applyChangelogProposals } from "../../commit/changelog";
 import { detectChangelogBoundaries } from "../../commit/changelog/detect";
 import { parseUnreleasedSection } from "../../commit/changelog/parse";

package/src/commit/agentic/prompts/system.md

@@ -13,11 +13,11 @@ Workflow rules:
 6. Do not use read.
 
 Commit requirements:
-- Summary line: past-tense verb, <= 72 chars, no trailing period.
+- Summary line: past-tense verb, ≤ 72 chars, no trailing period.
 - Avoid filler words: comprehensive, various, several, improved, enhanced, better.
 - Avoid meta phrases: "this commit", "this change", "updated code", "modified files".
 - Scope: lowercase, max two segments; only letters, digits, hyphens, underscores.
-- Detail lines optional (0-6). Each sentence ending in period, <= 120 chars.
+- Detail lines optional (0-6). Each sentence ending in period, ≤ 120 chars.
 
 Conventional commit types:
 {{types_description}}
@@ -34,5 +34,5 @@ Tool guidance:
 
 ## Changelog Requirements
 
-If changelog targets provided, you MUST call `propose_changelog` before finishing.
+If changelog targets provided, you **MUST** call `propose_changelog` before finishing.
 If you propose split commit plan, include changelog target files in relevant commit changes.

package/src/commit/agentic/tools/propose-changelog.ts

@@ -1,16 +1,25 @@
-import { Type } from "@sinclair/typebox";
+import { type TSchema, Type } from "@sinclair/typebox";
 import type { CommitAgentState } from "../../../commit/agentic/state";
-import type { ChangelogCategory } from "../../../commit/types";
+import { CHANGELOG_CATEGORIES, type ChangelogCategory } from "../../../commit/types";
 import type { CustomTool } from "../../../extensibility/custom-tools/types";
 
+const changelogEntryProperties = CHANGELOG_CATEGORIES.reduce<Record<ChangelogCategory, TSchema>>(
+	(acc, category) => {
+		acc[category] = Type.Optional(Type.Array(Type.String()));
+		return acc;
+	},
+	{} as Record<ChangelogCategory, TSchema>,
+);
+
+const changelogEntriesSchema = Type.Object(changelogEntryProperties);
+const changelogDeletionsSchema = Type.Object(changelogEntryProperties, {
+	description: "Entries to remove from existing changelog sections (case-insensitive match)",
+});
+
 const changelogEntrySchema = Type.Object({
 	path: Type.String(),
-	entries: Type.Record(Type.String(), Type.Array(Type.String())),
-	deletions: Type.Optional(
-		Type.Record(Type.String(), Type.Array(Type.String()), {
-			description: "Entries to remove from existing changelog sections (case-insensitive match)",
-		}),
-	),
+	entries: changelogEntriesSchema,
+	deletions: Type.Optional(changelogDeletionsSchema),
 });
 
 const proposeChangelogSchema = Type.Object({
@@ -23,15 +32,7 @@ interface ChangelogResponse {
 	warnings: string[];
 }
 
-const allowedCategories = new Set<ChangelogCategory>([
-	"Breaking Changes",
-	"Added",
-	"Changed",
-	"Deprecated",
-	"Removed",
-	"Fixed",
-	"Security",
-]);
+const allowedCategories = new Set<ChangelogCategory>(CHANGELOG_CATEGORIES);
 
 export function createProposeChangelogTool(
 	state: CommitAgentState,
@@ -50,11 +51,16 @@ export function createProposeChangelogTool(
 
 			const normalized = params.entries.map(entry => {
 				const cleaned: Record<string, string[]> = {};
-				for (const [category, values] of Object.entries(entry.entries ?? {})) {
+				const entries = entry.entries as Record<string, string[]>;
+				for (const [category, values] of Object.entries(entries)) {
 					if (!allowedCategories.has(category as ChangelogCategory)) {
 						errors.push(`Unknown changelog category for ${entry.path}: ${category}`);
 						continue;
 					}
+					if (!Array.isArray(values)) {
+						errors.push(`Invalid changelog entries for ${entry.path}: ${category}`);
+						continue;
+					}
 					const items = values.map(value => value.trim().replace(/\.$/, "")).filter(value => value.length > 0);
 					if (items.length > 0) {
 						cleaned[category] = Array.from(new Set(items));
@@ -64,11 +70,16 @@ export function createProposeChangelogTool(
 				let cleanedDeletions: Record<string, string[]> | undefined;
 				if (entry.deletions) {
 					cleanedDeletions = {};
-					for (const [category, values] of Object.entries(entry.deletions)) {
+					const deletions = entry.deletions as Record<string, string[]>;
+					for (const [category, values] of Object.entries(deletions)) {
 						if (!allowedCategories.has(category as ChangelogCategory)) {
 							errors.push(`Unknown deletion category for ${entry.path}: ${category}`);
 							continue;
 						}
+						if (!Array.isArray(values)) {
+							errors.push(`Invalid deletion entries for ${entry.path}: ${category}`);
+							continue;
+						}
 						const items = values.map(value => value.trim()).filter(value => value.length > 0);
 						if (items.length > 0) {
 							cleanedDeletions[category] = Array.from(new Set(items));

package/src/commit/changelog/generate.ts

@@ -1,17 +1,27 @@
 import type { Api, AssistantMessage, Model } from "@oh-my-pi/pi-ai";
 import { completeSimple, validateToolCall } from "@oh-my-pi/pi-ai";
-import { Type } from "@sinclair/typebox";
+import { type TSchema, Type } from "@sinclair/typebox";
 import changelogSystemPrompt from "../../commit/prompts/changelog-system.md" with { type: "text" };
 import changelogUserPrompt from "../../commit/prompts/changelog-user.md" with { type: "text" };
-import type { ChangelogGenerationResult } from "../../commit/types";
+import { CHANGELOG_CATEGORIES, type ChangelogCategory, type ChangelogGenerationResult } from "../../commit/types";
 import { renderPromptTemplate } from "../../config/prompt-templates";
 import { extractTextContent, extractToolCall, parseJsonPayload } from "../utils";
 
-const ChangelogTool = {
+const changelogEntryProperties = CHANGELOG_CATEGORIES.reduce<Record<ChangelogCategory, TSchema>>(
+	(acc, category) => {
+		acc[category] = Type.Optional(Type.Array(Type.String()));
+		return acc;
+	},
+	{} as Record<ChangelogCategory, TSchema>,
+);
+
+const changelogEntriesSchema = Type.Object(changelogEntryProperties);
+
+export const changelogTool = {
 	name: "create_changelog_entries",
 	description: "Generate changelog entries grouped by Keep a Changelog categories.",
 	parameters: Type.Object({
-		entries: Type.Record(Type.String(), Type.Array(Type.String())),
+		entries: changelogEntriesSchema,
 	}),
 };
 
@@ -46,7 +56,7 @@ export async function generateChangelogEntries({
 		{
 			systemPrompt: renderPromptTemplate(changelogSystemPrompt),
 			messages: [{ role: "user", content: prompt, timestamp: Date.now() }],
-			tools: [ChangelogTool],
+			tools: [changelogTool],
 		},
 		{ apiKey, maxTokens: 1200 },
 	);
@@ -58,7 +68,7 @@ export async function generateChangelogEntries({
 function parseChangelogResponse(message: AssistantMessage): ChangelogGenerationResult {
 	const toolCall = extractToolCall(message, "create_changelog_entries");
 	if (toolCall) {
-		const parsed = validateToolCall([ChangelogTool], toolCall) as ChangelogGenerationResult;
+		const parsed = validateToolCall([changelogTool], toolCall) as ChangelogGenerationResult;
 		return { entries: parsed.entries ?? {} };
 	}
 

package/src/commit/changelog/index.ts

@@ -2,11 +2,12 @@ import * as path from "node:path";
 import type { Api, Model } from "@oh-my-pi/pi-ai";
 import { logger } from "@oh-my-pi/pi-utils";
 import type { ControlledGit } from "../../commit/git";
+import { CHANGELOG_CATEGORIES } from "../../commit/types";
 import { detectChangelogBoundaries } from "./detect";
 import { generateChangelogEntries } from "./generate";
 import { parseUnreleasedSection } from "./parse";
 
-const CHANGELOG_SECTIONS = ["Breaking Changes", "Added", "Changed", "Deprecated", "Removed", "Fixed", "Security"];
+const CHANGELOG_SECTIONS = CHANGELOG_CATEGORIES;
 
 const DEFAULT_MAX_DIFF_CHARS = 120_000;
 

package/src/commit/pipeline.ts

@@ -1,7 +1,6 @@
 import * as path from "node:path";
 import type { Api, Model } from "@oh-my-pi/pi-ai";
-import { logger } from "@oh-my-pi/pi-utils";
-import { getProjectDir } from "@oh-my-pi/pi-utils/dirs";
+import { getProjectDir, logger } from "@oh-my-pi/pi-utils";
 import { ModelRegistry } from "../config/model-registry";
 import { renderPromptTemplate } from "../config/prompt-templates";
 import { Settings } from "../config/settings";