@oh-my-pi/pi-coding-agent 13.0.2 → 13.1.1

package/src/tools/bash-skill-urls.ts

@@ -1,5 +1,7 @@
+import * as fs from "node:fs/promises";
 import * as path from "node:path";
 import type { Skill } from "../extensibility/skills";
+import { type LocalProtocolOptions, resolveLocalUrlToPath } from "../internal-urls";
 import { validateRelativePath } from "../internal-urls/skill-protocol";
 import type { InternalResource } from "../internal-urls/types";
 import { ToolError } from "./tool-errors";
@@ -9,9 +11,9 @@ const SKILL_URL_PATTERN = /'skill:\/\/[^'\s")`\\]+'|"skill:\/\/[^"\s')`\\]+"|ski
 
 /** Regex to find supported internal URL tokens in command text. */
 const INTERNAL_URL_PATTERN =
-	/'(?:skill|agent|artifact|plan|memory|rule):\/\/[^'\s")`\\]+'|"(?:skill|agent|artifact|plan|memory|rule):\/\/[^"\s')`\\]+"|(?:skill|agent|artifact|plan|memory|rule):\/\/[^\s'")`\\]+/g;
+	/'(?:skill|agent|artifact|plan|memory|rule|local):\/\/[^'\s")`\\]+'|"(?:skill|agent|artifact|plan|memory|rule|local):\/\/[^"\s')`\\]+"|(?:skill|agent|artifact|plan|memory|rule|local):\/\/[^\s'")`\\]+/g;
 
-const SUPPORTED_INTERNAL_SCHEMES = ["skill", "agent", "artifact", "plan", "memory", "rule"] as const;
+const SUPPORTED_INTERNAL_SCHEMES = ["skill", "agent", "artifact", "plan", "memory", "rule", "local"] as const;
 
 type SupportedInternalScheme = (typeof SUPPORTED_INTERNAL_SCHEMES)[number];
 
@@ -24,6 +26,8 @@ export interface InternalUrlExpansionOptions {
 	skills: readonly Skill[];
 	noEscape?: boolean;
 	internalRouter?: InternalUrlResolver;
+	localOptions?: LocalProtocolOptions;
+	ensureLocalParentDirs?: boolean;
 }
 
 /**
@@ -102,6 +106,8 @@ async function resolveInternalUrlToPath(
 	url: string,
 	skills: readonly Skill[],
 	internalRouter?: InternalUrlResolver,
+	localOptions?: LocalProtocolOptions,
+	ensureLocalParentDirs?: boolean,
 ): Promise<string> {
 	const scheme = extractScheme(url);
 	if (!scheme) {
@@ -112,6 +118,19 @@ async function resolveInternalUrlToPath(
 		return resolveSkillUrlToPath(url, skills);
 	}
 
+	if (scheme === "local") {
+		if (!localOptions) {
+			throw new ToolError(
+				"Cannot resolve local:// URL in bash command: local protocol options are unavailable for this session.",
+			);
+		}
+		const resolvedLocalPath = resolveLocalUrlToPath(url, localOptions);
+		if (ensureLocalParentDirs) {
+			await fs.mkdir(path.dirname(resolvedLocalPath), { recursive: true });
+		}
+		return resolvedLocalPath;
+	}
+
 	if (!internalRouter || !internalRouter.canHandle(url)) {
 		throw new ToolError(
 			`Cannot resolve ${scheme}:// URL in bash command: ${url}\n` +
@@ -169,7 +188,13 @@ export async function expandInternalUrls(command: string, options: InternalUrlEx
 		if (index === undefined) continue;
 
 		const url = unquoteToken(token);
-		const resolvedPath = await resolveInternalUrlToPath(url, options.skills, options.internalRouter);
+		const resolvedPath = await resolveInternalUrlToPath(
+			url,
+			options.skills,
+			options.internalRouter,
+			options.localOptions,
+			options.ensureLocalParentDirs,
+		);
 		const replacement = options.noEscape ? resolvedPath : shellEscape(resolvedPath);
 		expanded = `${expanded.slice(0, index)}${replacement}${expanded.slice(index + token.length)}`;
 	}

package/src/tools/bash.ts

@@ -173,8 +173,12 @@ export class BashTool implements AgentTool<BashToolSchema, BashToolDetails> {
 		const internalUrlOptions: InternalUrlExpansionOptions = {
 			skills: this.session.skills ?? [],
 			internalRouter: this.session.internalRouter,
+			localOptions: {
+				getArtifactsDir: this.session.getArtifactsDir,
+				getSessionId: this.session.getSessionId,
+			},
 		};
-		command = await expandInternalUrls(command, internalUrlOptions);
+		command = await expandInternalUrls(command, { ...internalUrlOptions, ensureLocalParentDirs: true });
 
 		// Resolve protocol URLs (skill://, agent://, etc.) in extracted cwd.
 		if (cwd?.includes("://")) {

package/src/tools/browser.ts

@@ -380,7 +380,7 @@ const browserSchema = Type.Object({
 		Type.Object({
 			width: Type.Number({ description: "Viewport width in pixels" }),
 			height: Type.Number({ description: "Viewport height in pixels" }),
-			deviceScaleFactor: Type.Optional(Type.Number({ description: "Device scale factor" })),
+			device_scale_factor: Type.Optional(Type.Number({ description: "Device scale factor" })),
 		}),
 	),
 	delta_x: Type.Optional(Type.Number({ description: "Scroll delta X (scroll)" })),
@@ -515,7 +515,14 @@ export class BrowserTool implements AgentTool<typeof browserSchema, BrowserToolD
 	async #resetBrowser(params?: BrowserParams): Promise<Page> {
 		await this.#closeBrowser();
 		this.#currentHeadless = this.session.settings.get("browser.headless");
-		const initialViewport = params?.viewport ?? DEFAULT_VIEWPORT;
+		const vp = params?.viewport;
+		const initialViewport = vp
+			? {
+					width: vp.width,
+					height: vp.height,
+					deviceScaleFactor: vp.device_scale_factor ?? DEFAULT_VIEWPORT.deviceScaleFactor,
+				}
+			: DEFAULT_VIEWPORT;
 		const puppeteer = await loadPuppeteer();
 		this.#browser = await puppeteer.launch({
 			headless: this.#currentHeadless,
@@ -556,8 +563,15 @@ export class BrowserTool implements AgentTool<typeof browserSchema, BrowserToolD
 	}
 
 	async #applyViewport(page: Page, viewport?: BrowserParams["viewport"]): Promise<void> {
-		const target = viewport ?? DEFAULT_VIEWPORT;
-		await page.setViewport(target);
+		if (!viewport) {
+			await page.setViewport(DEFAULT_VIEWPORT);
+			return;
+		}
+		await page.setViewport({
+			width: viewport.width,
+			height: viewport.height,
+			deviceScaleFactor: viewport.device_scale_factor ?? DEFAULT_VIEWPORT.deviceScaleFactor,
+		});
 	}
 
 	async #clearElementCache(): Promise<void> {

package/src/tools/index.ts

@@ -15,6 +15,7 @@ import type { AgentOutputManager } from "../task/output-manager";
 import type { EventBus } from "../utils/event-bus";
 import { SearchTool } from "../web/search";
 import { AskTool } from "./ask";
+import { AwaitTool } from "./await-tool";
 import { BashTool } from "./bash";
 import { BrowserTool } from "./browser";
 import { CalculatorTool } from "./calculator";
@@ -25,7 +26,6 @@ import { FindTool } from "./find";
 import { GrepTool } from "./grep";
 import { NotebookTool } from "./notebook";
 import { wrapToolWithMetaNotice } from "./output-meta";
-import { PollJobsTool } from "./poll-jobs";
 import { PythonTool } from "./python";
 import { ReadTool } from "./read";
 import { reportFindingTool } from "./review";
@@ -54,6 +54,7 @@ export * from "../session/streaming-output";
 export { BUNDLED_AGENTS, TaskTool } from "../task";
 export * from "../web/search";
 export { AskTool, type AskToolDetails } from "./ask";
+export { AwaitTool, type AwaitToolDetails } from "./await-tool";
 export { BashTool, type BashToolDetails, type BashToolInput, type BashToolOptions } from "./bash";
 export { BrowserTool, type BrowserToolDetails } from "./browser";
 export { CalculatorTool, type CalculatorToolDetails } from "./calculator";
@@ -64,7 +65,6 @@ export { type FindOperations, FindTool, type FindToolDetails, type FindToolInput
 export { setPreferredImageProvider } from "./gemini-image";
 export { GrepTool, type GrepToolDetails, type GrepToolInput } from "./grep";
 export { NotebookTool, type NotebookToolDetails } from "./notebook";
-export { PollJobsTool, type PollJobsToolDetails } from "./poll-jobs";
 export { PythonTool, type PythonToolDetails, type PythonToolOptions } from "./python";
 export { ReadTool, type ReadToolDetails, type ReadToolInput } from "./read";
 export { reportFindingTool, type SubmitReviewDetails } from "./review";
@@ -169,7 +169,7 @@ export const BUILTIN_TOOLS: Record<string, ToolFactory> = {
 	browser: s => new BrowserTool(s),
 	task: TaskTool.create,
 	cancel_job: CancelJobTool.createIf,
-	poll_jobs: PollJobsTool.createIf,
+	await: AwaitTool.createIf,
 	todo_write: s => new TodoWriteTool(s),
 	fetch: s => new FetchTool(s),
 	web_search: s => new SearchTool(s),

package/src/tools/notebook.ts

@@ -63,7 +63,7 @@ export class NotebookTool implements AgentTool<typeof notebookSchema, NotebookTo
 	readonly name = "notebook";
 	readonly label = "Notebook";
 	readonly description =
-		"Completely replaces the contents of a specific cell in a Jupyter notebook (.ipynb file) with new source. Jupyter notebooks are interactive documents that combine code, text, and visualizations, commonly used for data analysis and scientific computing. The notebook_path parameter must be an absolute path, not a relative path. The cell_number is 0-indexed. Use edit_mode=insert to add a new cell at the index specified by cell_number. Use edit_mode=delete to delete the cell at the index specified by cell_number.";
+		"Edit, insert, or delete cells in Jupyter notebooks (.ipynb). cell_index is 0-based. Paths must be absolute.";
 	readonly parameters = notebookSchema;
 	readonly strict = true;
 	readonly concurrency = "exclusive";