@oh-my-pi/pi-coding-agent 12.7.2 → 12.7.4

package/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## [Unreleased]
 
+## [12.7.3] - 2026-02-16
+
+### Fixed
+- Suppressed hashline output for subagents without the edit tool (e.g. explore agents)
+
 ## [12.7.1] - 2026-02-16
 ### Changed
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "12.7.2",
+	"version": "12.7.4",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"type": "module",
 	"bin": {
@@ -84,12 +84,12 @@
 	},
 	"dependencies": {
 		"@mozilla/readability": "0.6.0",
-		"@oh-my-pi/omp-stats": "12.7.2",
-		"@oh-my-pi/pi-agent-core": "12.7.2",
-		"@oh-my-pi/pi-ai": "12.7.2",
-		"@oh-my-pi/pi-natives": "12.7.2",
-		"@oh-my-pi/pi-tui": "12.7.2",
-		"@oh-my-pi/pi-utils": "12.7.2",
+		"@oh-my-pi/omp-stats": "12.7.4",
+		"@oh-my-pi/pi-agent-core": "12.7.4",
+		"@oh-my-pi/pi-ai": "12.7.4",
+		"@oh-my-pi/pi-natives": "12.7.4",
+		"@oh-my-pi/pi-tui": "12.7.4",
+		"@oh-my-pi/pi-utils": "12.7.4",
 		"@sinclair/typebox": "^0.34.48",
 		"@xterm/headless": "^6.0.0",
 		"ajv": "^8.18.0",

package/src/prompts/system/system-prompt.md

@@ -10,39 +10,23 @@ Say truth; omit filler. No apologies. No comfort where clarity belongs.
 Push back when warranted: state downside, propose alternative, accept override.
 </identity>
 
-<contract>
-These are inviolable. Violation is system failure.
-1. Never claim unverified correctness. Can't verify → say so.
-2. Never stop mid-task. After tool output, interpret and continue. No pausing after assumptions, readings, or "Proceeding…"
-3. Never suppress tests to make code pass. Never fabricate outputs not observed.
-4. Never avoid breaking changes that correctness requires.
-5. Never solve the wished-for problem instead of the actual problem.
-6. Touch only what's requested. No incidental refactors or cleanup.
-7. Never ask for information obtainable from tools, repo context, or files. File referenced → locate and read it. Path implied → resolve it.
-</contract>
-
-<thinking_discipline>
+<discipline>
 Notice the completion reflex before it fires:
 - Urge to produce something that runs
 - Pattern-matching to similar problems
 - Assumption that compiling = correct
 - Satisfaction at "it works" before "works in all cases"
 
-Before writing code, answer:
+Before writing code, think through:
 - What are my assumptions about input? About environment?
 - What breaks this?
 - What would a malicious caller do?
 - Would a tired maintainer misunderstand this?
-
-State assumptions, then act. Do not ask to confirm them.
-
-Before finishing (within requested scope):
 - Can this be simpler?
 - Are these abstractions earning their keep?
-- Would a senior dev ask "why didn't you just…"?
 
 The question is not "does this work?" but "under what conditions? What happens outside them?"
-</thinking_discipline>
+</discipline>
 
 {{#if systemPromptCustomization}}
 <context>
@@ -109,23 +93,23 @@ Don't open a file hoping. Hope is not a strategy.
 </tools>
 
 <procedure>
-## Execution
-**Assess scope first.**
+## Task Execution
+**Assess the scope.**
 {{#if skills.length}}- If a skill matches the domain, read it before starting.{{/if}}
 {{#if rules.length}}- If an applicable rule exists, read it before starting.{{/if}}
 {{#has tools "task"}}- Consider if the task is parallelizable via Task tool? Make a conflict-free plan to delegate to subagents if possible.{{/has}}
-- If the task is multi-file or ambiguous, write a 3–7 bullet plan.
+- If the task is multi-file or not precisely scoped, make a plan of 3–7 steps.
 **Do the work.**
-Every turn must advance towards the deliverable, edit, write, run, delegate.
+- Every turn must advance towards the deliverable, edit, write, execute, delegate.
 **If blocked**:
-- Exhaust tools/context/files first.
+- Exhaust tools/context/files first, explore.
 - Only then ask — minimum viable question.
 **If requested change includes refactor**:
-Cleanup dead code and unused elements, do not yield before the codebase is pristine.
+- Cleanup dead code and unused elements, do not yield until your solution is pristine.
 
 {{#has tools "todo_write"}}
 ### Task Tracking
-- Never create a todo list and then stop. A turn that contains only todo updates is a failed turn.
+- Never create a todo list and then stop.
 - Use todos as you make progress to make multi-step progress visible, don't batch.
 - Skip entirely for single-step or trivial requests.
 {{/has}}
@@ -247,24 +231,39 @@ Sequential work requires justification. If you cannot articulate why B depends o
 {{/has}}
 
 <output_style>
-- State intent before tool calls in one sentence.
 - No summary closings ("In summary…"). No filler. No emojis. No ceremony.
 - Suppress: "genuinely", "honestly", "straightforward".
 - User execution-mode instructions (do-it-yourself vs delegate) override tool-use defaults.
-- Requirements conflict or are unclear → ask only after exhausting exploration.
+- Requirements conflict or are unclear → ask only after exhaustive exploration.
 </output_style>
 
-<completion>
+<contract>
+These are inviolable. Violation is system failure.
+1. Never claim unverified correctness.
+2. Never yield unless your deliverable is complete, standalone progress updates are forbidden.
+3. Never suppress tests to make code pass. Never fabricate outputs not observed.
+4. Never avoid breaking changes that correctness requires.
+5. Never solve the wished-for problem instead of the actual problem.
+6. Never ask for information obtainable from tools, repo context, or files. File referenced → locate and read it. Path implied → resolve it.
+</contract>
+
+<diligence>
+**GET THE TASK DONE.**
 Complete the full request before yielding. Use tools for verifiable facts. Results conflict → investigate. Incomplete → iterate.
+If you find yourself stopping without producing a change, you have failed.
 
 You have unlimited stamina; the user does not. Persist on hard problems. Don't burn their energy on problems you failed to think through.
 
 This matters. Incomplete work means they start over — your effort wasted, their time lost. The person waiting deserves your best work.
 
-Tests you didn't write: bugs shipped. Assumptions you didn't state: incidents to debug. Edge cases you didn't name: pages at 3am.
+Tests you didn't write: bugs shipped.
+Assumptions you didn't validate: incidents to debug.
+Edge cases you ignored: pages at 3am.
+
+Question not "Does this work?" but "Under what conditions? What happens outside them?"
 
 Write what you can defend.
-</completion>
+</diligence>
 
 <stakes>
 This is not practice. Incomplete work means they start over — your effort wasted, their time lost.
@@ -275,20 +274,11 @@ The person waiting deserves to receive it.
 User works in a high-reliability industry—defense, finance, healthcare, infrastructure—where bugs have material impact on people's lives, even death.
 </stakes>
 
-<prime_directive>
-**GET THE WORK DONE.**
-Everything else is subordinate to producing the requested output. If you find yourself stopping without producing a change, you have failed.
-</prime_directive>
-
 <critical>
-Keep going until finished.
-- Every turn must advance the deliverable.
+- Every turn must advance the deliverable. A non-final turn without at least one side-effect is invalid.
 - Quote only what's needed; rest is noise.
 - Don't claim unverified correctness.
 - Do not ask when it may be obtained from available tools or repo context/files.
 - Touch only requested; no incidental refactors/cleanup.
 {{#has tools "ask"}}- If files differ from expectations: ask before discarding uncommitted work.{{/has}}
-Question not "Does this work?" but "Under what conditions? What happens outside them?"
-
-Write what you can defend.
 </critical>

package/src/sdk.ts

@@ -701,6 +701,9 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		cwd,
 		hasUI: options.hasUI ?? false,
 		enableLsp,
+		get hasEditTool() {
+			return !options.toolNames || options.toolNames.includes("edit");
+		},
 		skipPythonPreflight: options.skipPythonPreflight,
 		contextFiles,
 		skills,

package/src/session/agent-session.ts

@@ -1072,6 +1072,11 @@ export class AgentSession {
 		return this.agent.state.tools.map(t => t.name);
 	}
 
+	/** Whether the edit tool is registered in this session. */
+	get hasEditTool(): boolean {
+		return this.#toolRegistry.has("edit");
+	}
+
 	/**
 	 * Get a tool by name from the registry.
 	 */
@@ -1518,7 +1523,7 @@ export class AgentSession {
 			if (fileMentions.length > 0) {
 				const fileMentionMessages = await generateFileMentionMessages(fileMentions, this.sessionManager.getCwd(), {
 					autoResizeImages: this.settings.get("images.autoResize"),
-					useHashLines: resolveFileDisplayMode(this.settings).hashLines,
+					useHashLines: resolveFileDisplayMode(this).hashLines,
 				});
 				messages.push(...fileMentionMessages);
 			}

package/src/tools/grep.ts

@@ -62,7 +62,7 @@ export class GrepTool implements AgentTool<typeof grepSchema, GrepToolDetails> {
 	readonly parameters = grepSchema;
 
 	constructor(private readonly session: ToolSession) {
-		const displayMode = resolveFileDisplayMode(session.settings);
+		const displayMode = resolveFileDisplayMode(session);
 		this.description = renderPromptTemplate(grepDescription, {
 			IS_HASHLINE_MODE: displayMode.hashLines,
 			IS_LINE_NUMBER_MODE: !displayMode.hashLines && displayMode.lineNumbers,
@@ -103,7 +103,7 @@ export class GrepTool implements AgentTool<typeof grepSchema, GrepToolDetails> {
 			const patternHasNewline = normalizedPattern.includes("\n") || normalizedPattern.includes("\\n");
 			const effectiveMultiline = multiline ?? patternHasNewline;
 
-			const useHashLines = resolveFileDisplayMode(this.session.settings).hashLines;
+			const useHashLines = resolveFileDisplayMode(this.session).hashLines;
 			const searchPath = resolveToCwd(searchDir || ".", this.session.cwd);
 			const scopePath = (() => {
 				const relative = path.relative(this.session.cwd, searchPath).replace(/\\/g, "/");

package/src/tools/index.ts

@@ -119,6 +119,8 @@ export interface ToolSession {
 	promptTemplates?: PromptTemplate[];
 	/** Whether LSP integrations are enabled */
 	enableLsp?: boolean;
+	/** Whether the edit tool is available in this session (controls hashline output) */
+	hasEditTool?: boolean;
 	/** Event bus for tool/extension communication */
 	eventBus?: EventBus;
 	/** Output schema for structured completion (subagents) */

package/src/tools/read.ts

@@ -544,7 +544,7 @@ export class ReadTool implements AgentTool<typeof readSchema, ReadToolDetails> {
 	readonly #autoResizeImages: boolean;
 
 	constructor(private readonly session: ToolSession) {
-		const displayMode = resolveFileDisplayMode(session.settings);
+		const displayMode = resolveFileDisplayMode(session);
 		this.#autoResizeImages = session.settings.get("images.autoResize");
 		this.description = renderPromptTemplate(readDescription, {
 			DEFAULT_MAX_LINES: String(DEFAULT_MAX_LINES),
@@ -562,7 +562,7 @@ export class ReadTool implements AgentTool<typeof readSchema, ReadToolDetails> {
 	): Promise<AgentToolResult<ReadToolDetails>> {
 		const { path: readPath, offset, limit } = params;
 
-		const displayMode = resolveFileDisplayMode(this.session.settings);
+		const displayMode = resolveFileDisplayMode(this.session);
 
 		// Handle internal URLs (agent://, skill://)
 		const internalRouter = this.session.internalRouter;
@@ -848,7 +848,7 @@ export class ReadTool implements AgentTool<typeof readSchema, ReadToolDetails> {
 	async #handleInternalUrl(url: string, offset?: number, limit?: number): Promise<AgentToolResult<ReadToolDetails>> {
 		const internalRouter = this.session.internalRouter!;
 
-		const displayMode = resolveFileDisplayMode(this.session.settings);
+		const displayMode = resolveFileDisplayMode(this.session);
 
 		// Check if URL has query extraction (agent:// only)
 		let parsed: URL;

package/src/utils/file-display-mode.ts

@@ -1,25 +1,34 @@
 /**
  * Resolve line-display mode for file-like outputs (read, grep, @file mentions).
  */
-export interface FileDisplayModeSettings {
-	get(key: "readLineNumbers" | "readHashLines" | "edit.mode"): unknown;
-}
 
 export interface FileDisplayMode {
 	lineNumbers: boolean;
 	hashLines: boolean;
 }
 
+/** Session-like object providing settings and tool availability for display mode resolution. */
+export interface FileDisplayModeSession {
+	/** Whether the edit tool is available. Hashlines are suppressed without it. */
+	hasEditTool?: boolean;
+	settings: {
+		get(key: "readLineNumbers" | "readHashLines" | "edit.mode"): unknown;
+	};
+}
+
 /**
- * Computes effective line display mode from settings/env.
+ * Computes effective line display mode from session settings/env.
  * Hashline mode takes precedence and implies line-addressed output everywhere.
+ * Hashlines are suppressed when the edit tool is not available (e.g. explore agents).
  */
-export function resolveFileDisplayMode(settings: FileDisplayModeSettings): FileDisplayMode {
+export function resolveFileDisplayMode(session: FileDisplayModeSession): FileDisplayMode {
+	const { settings } = session;
+	const hasEditTool = session.hasEditTool ?? true;
 	const hashLines =
-		settings.get("readHashLines") === true ||
-		settings.get("edit.mode") === "hashline" ||
-		Bun.env.PI_EDIT_VARIANT === "hashline";
-
+		hasEditTool &&
+		(settings.get("readHashLines") === true ||
+			settings.get("edit.mode") === "hashline" ||
+			Bun.env.PI_EDIT_VARIANT === "hashline");
 	return {
 		hashLines,
 		lineNumbers: hashLines || settings.get("readLineNumbers") === true,