@oh-my-pi/pi-coding-agent 11.8.2 → 11.8.3

package/src/modes/components/oauth-selector.ts

@@ -8,14 +8,14 @@ import { DynamicBorder } from "./dynamic-border";
  * Component that renders an OAuth provider selector
  */
 export class OAuthSelectorComponent extends Container {
-	private listContainer: Container;
-	private allProviders: OAuthProviderInfo[] = [];
-	private selectedIndex: number = 0;
-	private mode: "login" | "logout";
-	private authStorage: AuthStorage;
-	private onSelectCallback: (providerId: string) => void;
-	private onCancelCallback: () => void;
-	private statusMessage: string | undefined;
+	#listContainer: Container;
+	#allProviders: OAuthProviderInfo[] = [];
+	#selectedIndex: number = 0;
+	#mode: "login" | "logout";
+	#authStorage: AuthStorage;
+	#onSelectCallback: (providerId: string) => void;
+	#onCancelCallback: () => void;
+	#statusMessage: string | undefined;
 
 	constructor(
 		mode: "login" | "logout",
@@ -25,13 +25,13 @@ export class OAuthSelectorComponent extends Container {
 	) {
 		super();
 
-		this.mode = mode;
-		this.authStorage = authStorage;
-		this.onSelectCallback = onSelect;
-		this.onCancelCallback = onCancel;
+		this.#mode = mode;
+		this.#authStorage = authStorage;
+		this.#onSelectCallback = onSelect;
+		this.#onCancelCallback = onCancel;
 
 		// Load all OAuth providers
-		this.loadProviders();
+		this.#loadProviders();
 
 		// Add top border
 		this.addChild(new DynamicBorder());
@@ -43,8 +43,8 @@ export class OAuthSelectorComponent extends Container {
 		this.addChild(new Spacer(1));
 
 		// Create list container
-		this.listContainer = new Container();
-		this.addChild(this.listContainer);
+		this.#listContainer = new Container();
+		this.addChild(this.#listContainer);
 
 		this.addChild(new Spacer(1));
 
@@ -52,25 +52,25 @@ export class OAuthSelectorComponent extends Container {
 		this.addChild(new DynamicBorder());
 
 		// Initial render
-		this.updateList();
+		this.#updateList();
 	}
 
-	private loadProviders(): void {
-		this.allProviders = getOAuthProviders();
+	#loadProviders(): void {
+		this.#allProviders = getOAuthProviders();
 	}
 
-	private updateList(): void {
-		this.listContainer.clear();
+	#updateList(): void {
+		this.#listContainer.clear();
 
-		for (let i = 0; i < this.allProviders.length; i++) {
-			const provider = this.allProviders[i];
+		for (let i = 0; i < this.#allProviders.length; i++) {
+			const provider = this.#allProviders[i];
 			if (!provider) continue;
 
-			const isSelected = i === this.selectedIndex;
+			const isSelected = i === this.#selectedIndex;
 			const isAvailable = provider.available;
 
 			// Check if user is logged in for this provider
-			const isLoggedIn = this.authStorage.hasOAuth(provider.id);
+			const isLoggedIn = this.#authStorage.hasOAuth(provider.id);
 			const statusIndicator = isLoggedIn ? theme.fg("success", ` ${theme.status.success} logged in`) : "";
 
 			let line = "";
@@ -83,53 +83,53 @@ export class OAuthSelectorComponent extends Container {
 				line = text + statusIndicator;
 			}
 
-			this.listContainer.addChild(new TruncatedText(line, 0, 0));
+			this.#listContainer.addChild(new TruncatedText(line, 0, 0));
 		}
 
 		// Show "no providers" if empty
-		if (this.allProviders.length === 0) {
+		if (this.#allProviders.length === 0) {
 			const message =
-				this.mode === "login" ? "No OAuth providers available" : "No OAuth providers logged in. Use /login first.";
-			this.listContainer.addChild(new TruncatedText(theme.fg("muted", `  ${message}`), 0, 0));
+				this.#mode === "login" ? "No OAuth providers available" : "No OAuth providers logged in. Use /login first.";
+			this.#listContainer.addChild(new TruncatedText(theme.fg("muted", `  ${message}`), 0, 0));
 		}
 
-		if (this.statusMessage) {
-			this.listContainer.addChild(new Spacer(1));
-			this.listContainer.addChild(new TruncatedText(theme.fg("warning", `  ${this.statusMessage}`), 0, 0));
+		if (this.#statusMessage) {
+			this.#listContainer.addChild(new Spacer(1));
+			this.#listContainer.addChild(new TruncatedText(theme.fg("warning", `  ${this.#statusMessage}`), 0, 0));
 		}
 	}
 
 	handleInput(keyData: string): void {
 		// Up arrow
 		if (matchesKey(keyData, "up")) {
-			if (this.allProviders.length > 0) {
-				this.selectedIndex = this.selectedIndex === 0 ? this.allProviders.length - 1 : this.selectedIndex - 1;
+			if (this.#allProviders.length > 0) {
+				this.#selectedIndex = this.#selectedIndex === 0 ? this.#allProviders.length - 1 : this.#selectedIndex - 1;
 			}
-			this.statusMessage = undefined;
-			this.updateList();
+			this.#statusMessage = undefined;
+			this.#updateList();
 		}
 		// Down arrow
 		else if (matchesKey(keyData, "down")) {
-			if (this.allProviders.length > 0) {
-				this.selectedIndex = this.selectedIndex === this.allProviders.length - 1 ? 0 : this.selectedIndex + 1;
+			if (this.#allProviders.length > 0) {
+				this.#selectedIndex = this.#selectedIndex === this.#allProviders.length - 1 ? 0 : this.#selectedIndex + 1;
 			}
-			this.statusMessage = undefined;
-			this.updateList();
+			this.#statusMessage = undefined;
+			this.#updateList();
 		}
 		// Enter
 		else if (matchesKey(keyData, "enter") || matchesKey(keyData, "return") || keyData === "\n") {
-			const selectedProvider = this.allProviders[this.selectedIndex];
+			const selectedProvider = this.#allProviders[this.#selectedIndex];
 			if (selectedProvider?.available) {
-				this.statusMessage = undefined;
-				this.onSelectCallback(selectedProvider.id);
+				this.#statusMessage = undefined;
+				this.#onSelectCallback(selectedProvider.id);
 			} else if (selectedProvider) {
-				this.statusMessage = "Provider unavailable in this environment.";
-				this.updateList();
+				this.#statusMessage = "Provider unavailable in this environment.";
+				this.#updateList();
 			}
 		}
 		// Escape or Ctrl+C
 		else if (matchesKey(keyData, "escape") || matchesKey(keyData, "esc") || matchesKey(keyData, "ctrl+c")) {
-			this.onCancelCallback();
+			this.#onCancelCallback();
 		}
 	}
 }

package/src/modes/components/plugin-settings.ts

@@ -36,7 +36,7 @@ export interface PluginListCallbacks {
  * Selecting a plugin opens its detail view.
  */
 export class PluginListComponent extends Container {
-	private readonly selectList: SelectList;
+	readonly #selectList: SelectList;
 
 	constructor(
 		private readonly plugins: InstalledPlugin[],
@@ -57,8 +57,8 @@ export class PluginListComponent extends Container {
 			this.addChild(new DynamicBorder());
 
 			// Create empty list that just handles escape
-			this.selectList = new SelectList([], 1, getSelectListTheme());
-			this.selectList.onCancel = callbacks.onCancel;
+			this.#selectList = new SelectList([], 1, getSelectListTheme());
+			this.#selectList.onCancel = callbacks.onCancel;
 			return;
 		}
 
@@ -81,25 +81,25 @@ export class PluginListComponent extends Container {
 			};
 		});
 
-		this.selectList = new SelectList(items, Math.min(items.length, 8), getSelectListTheme());
+		this.#selectList = new SelectList(items, Math.min(items.length, 8), getSelectListTheme());
 
-		this.selectList.onSelect = item => {
+		this.#selectList.onSelect = item => {
 			const plugin = this.plugins.find(p => p.name === item.value);
 			if (plugin) {
 				callbacks.onPluginSelect(plugin);
 			}
 		};
 
-		this.selectList.onCancel = callbacks.onCancel;
+		this.#selectList.onCancel = callbacks.onCancel;
 
-		this.addChild(this.selectList);
+		this.addChild(this.#selectList);
 		this.addChild(new Spacer(1));
 		this.addChild(new Text(theme.fg("dim", "  Enter to configure · Esc to go back"), 0, 0));
 		this.addChild(new DynamicBorder());
 	}
 
 	handleInput(data: string): void {
-		this.selectList.handleInput(data);
+		this.#selectList.handleInput(data);
 	}
 }
 
@@ -121,7 +121,7 @@ export interface PluginDetailCallbacks {
  * - Config settings
  */
 export class PluginDetailComponent extends Container {
-	private settingsList!: SettingsList;
+	#settingsList!: SettingsList;
 
 	constructor(
 		private plugin: InstalledPlugin,
@@ -130,10 +130,10 @@ export class PluginDetailComponent extends Container {
 	) {
 		super();
 
-		void this.rebuild();
+		void this.#rebuild();
 	}
 
-	private async rebuild(): Promise<void> {
+	async #rebuild(): Promise<void> {
 		this.clear();
 
 		const plugin = this.plugin;
@@ -239,7 +239,7 @@ export class PluginDetailComponent extends Container {
 			}
 		}
 
-		this.settingsList = new SettingsList(
+		this.#settingsList = new SettingsList(
 			items,
 			Math.min(items.length, 10),
 			getSettingsListTheme(),
@@ -269,15 +269,15 @@ export class PluginDetailComponent extends Container {
 			this.callbacks.onBack,
 		);
 
-		this.addChild(this.settingsList);
+		this.addChild(this.#settingsList);
 		this.addChild(new Spacer(1));
 		this.addChild(new Text(theme.fg("dim", "  Enter to edit · Esc to go back"), 0, 0));
 		this.addChild(new DynamicBorder());
 	}
 
 	handleInput(data: string): void {
-		if (!this.settingsList) return;
-		this.settingsList.handleInput(data);
+		if (!this.#settingsList) return;
+		this.#settingsList.handleInput(data);
 	}
 }
 
@@ -289,7 +289,7 @@ export class PluginDetailComponent extends Container {
  * Submenu for enum config values.
  */
 class ConfigEnumSubmenu extends Container {
-	private selectList: SelectList;
+	#selectList: SelectList;
 
 	constructor(
 		key: string,
@@ -309,23 +309,23 @@ class ConfigEnumSubmenu extends Container {
 		this.addChild(new Spacer(1));
 
 		const items: SelectItem[] = values.map(v => ({ value: v, label: v }));
-		this.selectList = new SelectList(items, Math.min(items.length, 8), getSelectListTheme());
+		this.#selectList = new SelectList(items, Math.min(items.length, 8), getSelectListTheme());
 
 		const currentIndex = values.indexOf(currentValue);
 		if (currentIndex !== -1) {
-			this.selectList.setSelectedIndex(currentIndex);
+			this.#selectList.setSelectedIndex(currentIndex);
 		}
 
-		this.selectList.onSelect = item => onSelect(item.value);
-		this.selectList.onCancel = onCancel;
+		this.#selectList.onSelect = item => onSelect(item.value);
+		this.#selectList.onCancel = onCancel;
 
-		this.addChild(this.selectList);
+		this.addChild(this.#selectList);
 		this.addChild(new Spacer(1));
 		this.addChild(new Text(theme.fg("dim", "  Enter to select · Esc to cancel"), 0, 0));
 	}
 
 	handleInput(data: string): void {
-		this.selectList.handleInput(data);
+		this.#selectList.handleInput(data);
 	}
 }
 
@@ -333,7 +333,7 @@ class ConfigEnumSubmenu extends Container {
  * Submenu for string/number config values with text input.
  */
 class ConfigInputSubmenu extends Container {
-	private input: Input;
+	#input: Input;
 
 	constructor(
 		key: string,
@@ -364,12 +364,12 @@ class ConfigInputSubmenu extends Container {
 		this.addChild(new Spacer(1));
 
 		// Input field
-		this.input = new Input();
+		this.#input = new Input();
 		if (!schema.secret && currentValue) {
-			this.input.setValue(currentValue);
+			this.#input.setValue(currentValue);
 		}
 
-		this.input.onSubmit = value => {
+		this.#input.onSubmit = value => {
 			if (value.trim()) {
 				this.onSubmit(value);
 			} else {
@@ -377,7 +377,7 @@ class ConfigInputSubmenu extends Container {
 			}
 		};
 
-		this.addChild(this.input);
+		this.addChild(this.#input);
 		this.addChild(new Spacer(1));
 		this.addChild(new Text(theme.fg("dim", "  Enter to save · Esc to cancel"), 0, 0));
 	}
@@ -387,7 +387,7 @@ class ConfigInputSubmenu extends Container {
 			this.onCancel();
 			return;
 		}
-		this.input.handleInput(data);
+		this.#input.handleInput(data);
 	}
 }
 
@@ -410,68 +410,68 @@ interface InputHandler {
  * Manages navigation between plugin list and plugin detail views.
  */
 export class PluginSettingsComponent extends Container {
-	private manager: PluginManager;
-	private viewComponent: (Container & InputHandler) | null = null;
+	#manager: PluginManager;
+	#viewComponent: (Container & InputHandler) | null = null;
 	// biome-ignore lint/correctness/noUnusedPrivateClassMembers: state tracking for view management
-	private currentView: "list" | "detail" = "list";
+	#currentView: "list" | "detail" = "list";
 	// biome-ignore lint/correctness/noUnusedPrivateClassMembers: state tracking for view management
-	private currentPlugin: InstalledPlugin | null = null;
+	#currentPlugin: InstalledPlugin | null = null;
 
 	constructor(
 		cwd: string,
 		private readonly callbacks: PluginSettingsCallbacks,
 	) {
 		super();
-		this.manager = new PluginManager(cwd);
-		this.showPluginList();
+		this.#manager = new PluginManager(cwd);
+		this.#showPluginList();
 	}
 
-	private async showPluginList(): Promise<void> {
-		this.currentView = "list";
-		this.currentPlugin = null;
+	async #showPluginList(): Promise<void> {
+		this.#currentView = "list";
+		this.#currentPlugin = null;
 		this.clear();
 
-		const plugins = await this.manager.list();
+		const plugins = await this.#manager.list();
 
-		this.viewComponent = new PluginListComponent(plugins, {
-			onPluginSelect: plugin => this.showPluginDetail(plugin),
+		this.#viewComponent = new PluginListComponent(plugins, {
+			onPluginSelect: plugin => this.#showPluginDetail(plugin),
 			onCancel: () => this.callbacks.onClose(),
 		});
 
-		this.addChild(this.viewComponent);
+		this.addChild(this.#viewComponent);
 	}
 
-	private showPluginDetail(plugin: InstalledPlugin): void {
-		this.currentView = "detail";
-		this.currentPlugin = plugin;
+	#showPluginDetail(plugin: InstalledPlugin): void {
+		this.#currentView = "detail";
+		this.#currentPlugin = plugin;
 		this.clear();
 
-		this.viewComponent = new PluginDetailComponent(plugin, this.manager, {
+		this.#viewComponent = new PluginDetailComponent(plugin, this.#manager, {
 			onEnabledChange: async enabled => {
-				await this.manager.setEnabled(plugin.name, enabled);
+				await this.#manager.setEnabled(plugin.name, enabled);
 				this.callbacks.onPluginChanged();
 			},
 			onFeatureChange: async (feature, enabled) => {
-				const current = new Set((await this.manager.getEnabledFeatures(plugin.name)) ?? []);
+				const current = new Set((await this.#manager.getEnabledFeatures(plugin.name)) ?? []);
 				if (enabled) {
 					current.add(feature);
 				} else {
 					current.delete(feature);
 				}
-				await this.manager.setEnabledFeatures(plugin.name, [...current]);
+				await this.#manager.setEnabledFeatures(plugin.name, [...current]);
 				this.callbacks.onPluginChanged();
 			},
 			onConfigChange: async (key, value) => {
-				await this.manager.setPluginSetting(plugin.name, key, value);
+				await this.#manager.setPluginSetting(plugin.name, key, value);
 				this.callbacks.onPluginChanged();
 			},
-			onBack: () => this.showPluginList(),
+			onBack: () => this.#showPluginList(),
 		});
 
-		this.addChild(this.viewComponent);
+		this.addChild(this.#viewComponent);
 	}
 
 	handleInput(data: string): void {
-		this.viewComponent?.handleInput(data);
+		this.#viewComponent?.handleInput(data);
 	}
 }

package/src/modes/components/python-execution.ts

@@ -12,15 +12,15 @@ import { truncateToVisualLines } from "./visual-truncate";
 const PREVIEW_LINES = 20;
 
 export class PythonExecutionComponent extends Container {
-	private outputLines: string[] = [];
-	private status: "running" | "complete" | "cancelled" | "error" = "running";
-	private exitCode: number | undefined = undefined;
-	private loader: Loader;
-	private truncation?: TruncationMeta;
-	private expanded = false;
-	private contentContainer: Container;
-
-	private formatHeader(colorKey: "dim" | "pythonMode"): Text {
+	#outputLines: string[] = [];
+	#status: "running" | "complete" | "cancelled" | "error" = "running";
+	#exitCode: number | undefined = undefined;
+	#loader: Loader;
+	#truncation?: TruncationMeta;
+	#expanded = false;
+	#contentContainer: Container;
+
+	#formatHeader(colorKey: "dim" | "pythonMode"): Text {
 		const prompt = theme.fg(colorKey, theme.bold(">>>"));
 		const continuation = theme.fg(colorKey, "    ");
 		const codeLines = highlightCode(this.code, "python");
@@ -43,44 +43,44 @@ export class PythonExecutionComponent extends Container {
 		this.addChild(new Spacer(1));
 		this.addChild(new DynamicBorder(borderColor));
 
-		this.contentContainer = new Container();
-		this.addChild(this.contentContainer);
-		this.contentContainer.addChild(this.formatHeader(colorKey));
+		this.#contentContainer = new Container();
+		this.addChild(this.#contentContainer);
+		this.#contentContainer.addChild(this.#formatHeader(colorKey));
 
-		this.loader = new Loader(
+		this.#loader = new Loader(
 			ui,
 			spinner => theme.fg(colorKey, spinner),
 			text => theme.fg("muted", text),
 			`Running… (esc to cancel)`,
 			getSymbolTheme().spinnerFrames,
 		);
-		this.contentContainer.addChild(this.loader);
+		this.#contentContainer.addChild(this.#loader);
 
 		this.addChild(new DynamicBorder(borderColor));
 	}
 
 	setExpanded(expanded: boolean): void {
-		this.expanded = expanded;
-		this.updateDisplay();
+		this.#expanded = expanded;
+		this.#updateDisplay();
 	}
 
 	override invalidate(): void {
 		super.invalidate();
-		this.updateDisplay();
+		this.#updateDisplay();
 	}
 
 	appendOutput(chunk: string): void {
-		const clean = this.normalizeOutput(chunk);
+		const clean = this.#normalizeOutput(chunk);
 
 		const newLines = clean.split("\n");
-		if (this.outputLines.length > 0 && newLines.length > 0) {
-			this.outputLines[this.outputLines.length - 1] += newLines[0];
-			this.outputLines.push(...newLines.slice(1));
+		if (this.#outputLines.length > 0 && newLines.length > 0) {
+			this.#outputLines[this.#outputLines.length - 1] += newLines[0];
+			this.#outputLines.push(...newLines.slice(1));
 		} else {
-			this.outputLines.push(...newLines);
+			this.#outputLines.push(...newLines);
 		}
 
-		this.updateDisplay();
+		this.#updateDisplay();
 	}
 
 	setComplete(
@@ -88,39 +88,39 @@ export class PythonExecutionComponent extends Container {
 		cancelled: boolean,
 		options?: { output?: string; truncation?: TruncationMeta },
 	): void {
-		this.exitCode = exitCode;
-		this.status = cancelled
+		this.#exitCode = exitCode;
+		this.#status = cancelled
 			? "cancelled"
 			: exitCode !== 0 && exitCode !== undefined && exitCode !== null
 				? "error"
 				: "complete";
-		this.truncation = options?.truncation;
+		this.#truncation = options?.truncation;
 		if (options?.output !== undefined) {
-			this.setOutput(options.output);
+			this.#setOutput(options.output);
 		}
 
-		this.loader.stop();
-		this.updateDisplay();
+		this.#loader.stop();
+		this.#updateDisplay();
 	}
 
-	private updateDisplay(): void {
-		const availableLines = this.outputLines;
+	#updateDisplay(): void {
+		const availableLines = this.#outputLines;
 		const previewLogicalLines = availableLines.slice(-PREVIEW_LINES);
 		const hiddenLineCount = availableLines.length - previewLogicalLines.length;
 
-		this.contentContainer.clear();
+		this.#contentContainer.clear();
 
 		const colorKey = this.excludeFromContext ? "dim" : "pythonMode";
-		this.contentContainer.addChild(this.formatHeader(colorKey));
+		this.#contentContainer.addChild(this.#formatHeader(colorKey));
 
 		if (availableLines.length > 0) {
-			if (this.expanded) {
+			if (this.#expanded) {
 				const displayText = availableLines.map(line => theme.fg("muted", line)).join("\n");
-				this.contentContainer.addChild(new Text(`\n${displayText}`, 1, 0));
+				this.#contentContainer.addChild(new Text(`\n${displayText}`, 1, 0));
 			} else {
 				const styledOutput = previewLogicalLines.map(line => theme.fg("muted", line)).join("\n");
 				const previewText = `\n${styledOutput}`;
-				this.contentContainer.addChild({
+				this.#contentContainer.addChild({
 					render: (width: number) => {
 						const { visualLines } = truncateToVisualLines(previewText, PREVIEW_LINES, width, 1);
 						return visualLines;
@@ -130,8 +130,8 @@ export class PythonExecutionComponent extends Container {
 			}
 		}
 
-		if (this.status === "running") {
-			this.contentContainer.addChild(this.loader);
+		if (this.#status === "running") {
+			this.#contentContainer.addChild(this.#loader);
 		} else {
 			const statusParts: string[] = [];
 
@@ -139,46 +139,46 @@ export class PythonExecutionComponent extends Container {
 				statusParts.push(theme.fg("dim", `… ${hiddenLineCount} more lines (ctrl+o to expand)`));
 			}
 
-			if (this.status === "cancelled") {
+			if (this.#status === "cancelled") {
 				statusParts.push(theme.fg("warning", "(cancelled)"));
-			} else if (this.status === "error") {
-				statusParts.push(theme.fg("error", `(exit ${this.exitCode})`));
+			} else if (this.#status === "error") {
+				statusParts.push(theme.fg("error", `(exit ${this.#exitCode})`));
 			}
 
-			if (this.truncation) {
+			if (this.#truncation) {
 				const warnings: string[] = [];
-				if (this.truncation.artifactId) {
-					warnings.push(`Full output: artifact://${this.truncation.artifactId}`);
+				if (this.#truncation.artifactId) {
+					warnings.push(`Full output: artifact://${this.#truncation.artifactId}`);
 				}
-				if (this.truncation.truncatedBy === "lines") {
+				if (this.#truncation.truncatedBy === "lines") {
 					warnings.push(
-						`Truncated: showing ${this.truncation.outputLines} of ${this.truncation.totalLines} lines`,
+						`Truncated: showing ${this.#truncation.outputLines} of ${this.#truncation.totalLines} lines`,
 					);
 				} else {
 					warnings.push(
-						`Truncated: ${this.truncation.outputLines} lines shown (${formatSize(this.truncation.outputBytes)} limit)`,
+						`Truncated: ${this.#truncation.outputLines} lines shown (${formatSize(this.#truncation.outputBytes)} limit)`,
 					);
 				}
 				statusParts.push(theme.fg("warning", warnings.join(". ")));
 			}
 
 			if (statusParts.length > 0) {
-				this.contentContainer.addChild(new Text(`\n${statusParts.join("\n")}`, 1, 0));
+				this.#contentContainer.addChild(new Text(`\n${statusParts.join("\n")}`, 1, 0));
 			}
 		}
 	}
 
-	private normalizeOutput(text: string): string {
+	#normalizeOutput(text: string): string {
 		return Bun.stripANSI(text).replace(/\r\n/g, "\n").replace(/\r/g, "\n");
 	}
 
-	private setOutput(output: string): void {
-		const clean = this.normalizeOutput(output);
-		this.outputLines = clean ? clean.split("\n") : [];
+	#setOutput(output: string): void {
+		const clean = this.#normalizeOutput(output);
+		this.#outputLines = clean ? clean.split("\n") : [];
 	}
 
 	getOutput(): string {
-		return this.outputLines.join("\n");
+		return this.#outputLines.join("\n");
 	}
 
 	getCode(): string {