@oh-my-pi/pi-coding-agent 11.2.3 → 11.4.0

package/src/utils/tools-manager.ts

@@ -269,6 +269,12 @@ async function installPythonPackage(pkg: string, signal?: AbortSignal): Promise<
 	return false;
 }
 
+// Termux package names for tools
+const TERMUX_PACKAGES: Partial<Record<ToolName, string>> = {
+	sd: "sd",
+	sg: "ast-grep",
+};
+
 // Ensure a tool is available, downloading if necessary
 // Returns the path to the tool, or null if unavailable
 type EnsureToolOptions = {
@@ -284,13 +290,23 @@ export async function ensureTool(tool: ToolName, silentOrOptions?: EnsureToolOpt
 		return existingPath;
 	}
 
+	// On Android/Termux, Linux binaries don't work due to Bionic libc incompatibility.
+	// Users must install via pkg.
+	if (os.platform() === "android") {
+		const pkgName = TERMUX_PACKAGES[tool] ?? tool;
+		if (!silent) {
+			logger.warn(`${TOOLS[tool]?.name ?? tool} not found. Install with: pkg install ${pkgName}`);
+		}
+		return undefined;
+	}
+
 	// Handle Python tools
 	const pythonConfig = PYTHON_TOOLS[tool];
 	if (pythonConfig) {
 		if (!silent) {
 			logger.debug(`${pythonConfig.name} not found. Installing via uv/pip...`);
 		}
-		notify?.(`Installing ${pythonConfig.name}...`);
+		notify?.(`Installing ${pythonConfig.name}…`);
 		const success = await installPythonPackage(pythonConfig.package, signal);
 		if (success) {
 			// Re-check for the command after installation
@@ -315,7 +331,7 @@ export async function ensureTool(tool: ToolName, silentOrOptions?: EnsureToolOpt
 	if (!silent) {
 		logger.debug(`${config.name} not found. Downloading...`);
 	}
-	notify?.(`Downloading ${config.name}...`);
+	notify?.(`Downloading ${config.name}…`);
 
 	try {
 		const path = await downloadTool(tool, signal);

package/src/web/scrapers/osv.ts

@@ -145,8 +145,11 @@ export const handleOsv: SpecialHandler = async (
 				if (affected.versions?.length) {
 					const versions =
 						affected.versions.length > 10
-							? `${affected.versions.slice(0, 10).join(", ")}... (${affected.versions.length} total)`
+							? `${affected.versions.slice(0, 10).join(", ")}… (${affected.versions.length} total)`
 							: affected.versions.join(", ");
+					affected.versions.length > 10
+						? `${affected.versions.slice(0, 10).join(", ")}… (${affected.versions.length} total)`
+						: affected.versions.join(", ");
 					md += `- **Versions:** ${versions}\n`;
 				}
 

package/src/web/scrapers/youtube.ts

@@ -287,7 +287,7 @@ export const handleYouTube: SpecialHandler = async (
 
 	if (description) {
 		// Truncate long descriptions
-		const descPreview = description.length > 1000 ? `${description.slice(0, 1000)}...` : description;
+		const descPreview = description.length > 1000 ? `${description.slice(0, 1000)}…` : description;
 		md += `---\n\n## Description\n\n${descPreview}\n\n`;
 	}
 

package/src/web/search/index.ts

@@ -79,7 +79,7 @@ function formatProviderError(error: unknown, provider: SearchProvider): string {
 /** Truncate text for tool output */
 function truncateText(text: string, maxLen: number): string {
 	if (text.length <= maxLen) return text;
-	return `${text.slice(0, Math.max(0, maxLen - 3))}...`;
+	return `${text.slice(0, Math.max(0, maxLen - 1))}…`;
 }
 
 function formatCount(label: string, count: number): string {

package/src/web/search/render.ts

@@ -21,7 +21,8 @@ import {
 	TRUNCATE_LENGTHS,
 	truncateToWidth,
 } from "../../tools/render-utils";
-import { renderOutputBlock, renderStatusLine, renderTreeList } from "../../tui";
+import { renderStatusLine, renderTreeList } from "../../tui";
+import { CachedOutputBlock } from "../../tui/output-block";
 import type { SearchResponse } from "./types";
 
 const MAX_COLLAPSED_ANSWER_LINES = PREVIEW_LIMITS.COLLAPSED_LINES;
@@ -79,7 +80,6 @@ export function renderSearchResult(
 		maxAnswerLines?: number;
 	},
 ): Component {
-	const { expanded } = options;
 	const details = result.details;
 
 	// Handle error case
@@ -90,7 +90,7 @@ export function renderSearchResult(
 	const rawText = result.content?.find(block => block.type === "text")?.text?.trim() ?? "";
 	const response = details?.response;
 	if (!response) {
-		return renderFallbackText(rawText, expanded, theme);
+		return renderFallbackText(rawText, options.expanded, theme);
 	}
 
 	const sources = Array.isArray(response.sources) ? response.sources : [];
@@ -112,12 +112,6 @@ export function renderSearchResult(
 				.map(l => l.trim())
 		: [];
 	const totalAnswerLines = answerLines.length;
-	const answerLimit = expanded ? MAX_EXPANDED_ANSWER_LINES : MAX_COLLAPSED_ANSWER_LINES;
-	const answerPreview = contentText
-		? args?.allowLongAnswer
-			? answerLines.slice(0, args.maxAnswerLines ?? answerLines.length)
-			: getPreviewLines(contentText, answerLimit, MAX_ANSWER_LINE_LEN)
-		: [];
 
 	const providerLabel = provider !== "none" ? getSearchProvider(provider).label : "None";
 	const queryPreview = args?.query
@@ -135,46 +129,6 @@ export function renderSearchResult(
 		theme,
 	);
 
-	const remainingAnswer = totalAnswerLines - answerPreview.length;
-
-	const sourceTree = renderTreeList(
-		{
-			items: sources,
-			expanded,
-			maxCollapsed: MAX_COLLAPSED_ITEMS,
-			itemType: "source",
-			renderItem: src => {
-				const titleText =
-					typeof src.title === "string" && src.title.trim()
-						? src.title
-						: typeof src.url === "string" && src.url.trim()
-							? src.url
-							: "Untitled";
-				const title = truncateToWidth(titleText, 70);
-				const url = typeof src.url === "string" ? src.url : "";
-				const domain = url ? getDomain(url) : "";
-				const age = formatAge(src.ageSeconds) || (typeof src.publishedDate === "string" ? src.publishedDate : "");
-				const metaParts: string[] = [];
-				if (domain) metaParts.push(theme.fg("dim", `(${domain})`));
-				if (typeof src.author === "string" && src.author.trim()) metaParts.push(theme.fg("muted", src.author));
-				if (age) metaParts.push(theme.fg("muted", age));
-				const metaSep = theme.fg("dim", theme.sep.dot);
-				const metaSuffix = metaParts.length > 0 ? ` ${metaParts.join(metaSep)}` : "";
-				const lines: string[] = [`${theme.fg("accent", title)}${metaSuffix}`];
-				const snippetText = typeof src.snippet === "string" ? src.snippet : "";
-				if (snippetText.trim()) {
-					const snippetLines = getPreviewLines(snippetText, MAX_SNIPPET_LINES, MAX_SNIPPET_LINE_LEN);
-					for (const snippetLine of snippetLines) {
-						lines.push(theme.fg("muted", `${theme.format.dash} ${snippetLine}`));
-					}
-				}
-				if (url) lines.push(theme.fg("mdLinkUrl", url));
-				return lines;
-			},
-		},
-		theme,
-	);
-
 	const metaLines: string[] = [];
 	metaLines.push(`${theme.fg("muted", "Provider:")} ${theme.fg("text", providerLabel)}`);
 	if (response.model) metaLines.push(`${theme.fg("muted", "Model:")} ${theme.fg("text", response.model)}`);
@@ -202,9 +156,94 @@ export function renderSearchResult(
 		metaLines.push(`${theme.fg("muted", "Queries:")} ${theme.fg("text", queryList.join("; "))}${suffix}`);
 	}
 
+	const outputBlock = new CachedOutputBlock();
+
 	return {
-		render: (width: number) =>
-			renderOutputBlock(
+		render(width: number): string[] {
+			// Read mutable state at render time
+			const { expanded } = options;
+
+			// Expanded-dependent computations
+			const answerLimit = expanded ? MAX_EXPANDED_ANSWER_LINES : MAX_COLLAPSED_ANSWER_LINES;
+			const answerPreview = contentText
+				? args?.allowLongAnswer
+					? answerLines.slice(0, args.maxAnswerLines ?? answerLines.length)
+					: getPreviewLines(contentText, answerLimit, MAX_ANSWER_LINE_LEN)
+				: [];
+			const remainingAnswer = totalAnswerLines - answerPreview.length;
+
+			const sourceTree = renderTreeList(
+				{
+					items: sources,
+					expanded,
+					maxCollapsed: MAX_COLLAPSED_ITEMS,
+					itemType: "source",
+					renderItem: src => {
+						const titleText =
+							typeof src.title === "string" && src.title.trim()
+								? src.title
+								: typeof src.url === "string" && src.url.trim()
+									? src.url
+									: "Untitled";
+						const title = truncateToWidth(titleText, 70);
+						const url = typeof src.url === "string" ? src.url : "";
+						const domain = url ? getDomain(url) : "";
+						const age =
+							formatAge(src.ageSeconds) || (typeof src.publishedDate === "string" ? src.publishedDate : "");
+						const metaParts: string[] = [];
+						if (domain) metaParts.push(theme.fg("dim", `(${domain})`));
+						if (typeof src.author === "string" && src.author.trim())
+							metaParts.push(theme.fg("muted", src.author));
+						if (age) metaParts.push(theme.fg("muted", age));
+						const metaSep = theme.fg("dim", theme.sep.dot);
+						const metaSuffix = metaParts.length > 0 ? ` ${metaParts.join(metaSep)}` : "";
+						const srcLines: string[] = [`${theme.fg("accent", title)}${metaSuffix}`];
+						const snippetText = typeof src.snippet === "string" ? src.snippet : "";
+						if (snippetText.trim()) {
+							const snippetLines = getPreviewLines(snippetText, MAX_SNIPPET_LINES, MAX_SNIPPET_LINE_LEN);
+							for (const snippetLine of snippetLines) {
+								srcLines.push(theme.fg("muted", `${theme.format.dash} ${snippetLine}`));
+							}
+						}
+						if (url) srcLines.push(theme.fg("mdLinkUrl", url));
+						return srcLines;
+					},
+				},
+				theme,
+			);
+
+			// Build answer section
+			const answerState = sourceCount > 0 ? "success" : "warning";
+			const borderColor: "warning" | "dim" = answerState === "warning" ? "warning" : "dim";
+			const border = (t: string) => theme.fg(borderColor, t);
+			const contentPrefix = border(`${theme.boxSharp.vertical} `);
+			const contentSuffix = border(theme.boxSharp.vertical);
+			const contentWidth = Math.max(0, width - visibleWidth(contentPrefix) - visibleWidth(contentSuffix));
+			const answerTreeLines = answerPreview.length > 0 ? answerPreview : ["No answer text returned"];
+			const answerTree = renderTreeList(
+				{
+					items: answerTreeLines,
+					expanded: true,
+					maxCollapsed: answerTreeLines.length,
+					itemType: "line",
+					renderItem: (line, context) => {
+						const coloredLine =
+							line === "No answer text returned" ? theme.fg("muted", line) : theme.fg("dim", line);
+						if (!args?.allowLongAnswer) {
+							return coloredLine;
+						}
+						const prefixWidth = visibleWidth(context.continuePrefix);
+						const wrapWidth = Math.max(10, contentWidth - prefixWidth);
+						return wrapTextWithAnsi(coloredLine, wrapWidth);
+					},
+				},
+				theme,
+			);
+			if (remainingAnswer > 0) {
+				answerTree.push(theme.fg("muted", formatMoreItems(remainingAnswer, "line")));
+			}
+
+			return outputBlock.render(
 				{
 					header,
 					state: sourceCount > 0 ? "success" : "warning",
@@ -218,43 +257,7 @@ export function renderSearchResult(
 							: []),
 						{
 							label: theme.fg("toolTitle", "Answer"),
-							lines: (() => {
-								const state = sourceCount > 0 ? "success" : "warning";
-								const borderColor: "warning" | "dim" = state === "warning" ? "warning" : "dim";
-								const border = (text: string) => theme.fg(borderColor, text);
-								const contentPrefix = border(`${theme.boxSharp.vertical} `);
-								const contentSuffix = border(theme.boxSharp.vertical);
-								const contentWidth = Math.max(
-									0,
-									width - visibleWidth(contentPrefix) - visibleWidth(contentSuffix),
-								);
-								const answerTreeLines = answerPreview.length > 0 ? answerPreview : ["No answer text returned"];
-								const answerTree = renderTreeList(
-									{
-										items: answerTreeLines,
-										expanded: true,
-										maxCollapsed: answerTreeLines.length,
-										itemType: "line",
-										renderItem: (line, context) => {
-											const coloredLine =
-												line === "No answer text returned"
-													? theme.fg("muted", line)
-													: theme.fg("dim", line);
-											if (!args?.allowLongAnswer) {
-												return coloredLine;
-											}
-											const prefixWidth = visibleWidth(context.continuePrefix);
-											const wrapWidth = Math.max(10, contentWidth - prefixWidth);
-											return wrapTextWithAnsi(coloredLine, wrapWidth);
-										},
-									},
-									theme,
-								);
-								if (remainingAnswer > 0) {
-									answerTree.push(theme.fg("muted", formatMoreItems(remainingAnswer, "line")));
-								}
-								return answerTree;
-							})(),
+							lines: answerTree,
 						},
 						{
 							label: theme.fg("toolTitle", "Sources"),
@@ -265,8 +268,11 @@ export function renderSearchResult(
 					width,
 				},
 				theme,
-			),
-		invalidate: () => {},
+			);
+		},
+		invalidate() {
+			outputBlock.invalidate();
+		},
 	};
 }