@oh-my-pi/pi-coding-agent 11.2.3 → 11.3.0

package/src/task/render.ts

@@ -24,7 +24,7 @@ import {
 	type ReportFindingDetails,
 	type SubmitReviewDetails,
 } from "../tools/review";
-import { renderStatusLine } from "../tui";
+import { Ellipsis, Hasher, type RenderCache, renderStatusLine } from "../tui";
 import { subprocessToolRegistry } from "./subprocess-tool-registry";
 import type { AgentProgress, SingleResult, TaskParams, TaskToolDetails } from "./types";
 
@@ -382,7 +382,13 @@ function formatScalarInline(value: unknown, maxLen: number, _theme: Theme): stri
 	if (value === undefined) return "undefined";
 	if (typeof value === "boolean") return String(value);
 	if (typeof value === "number") return String(value);
-	if (typeof value === "string") return `"${truncateToWidth(value, maxLen)}"`;
+	if (typeof value === "string") {
+		const firstLine = value.split("\n")[0].trim();
+		if (firstLine.length === 0) return `"" (${value.split("\n").length} lines)`;
+		const preview = truncateToWidth(firstLine, maxLen);
+		if (value.includes("\n")) return `"${preview}…" (${value.split("\n").length} lines)`;
+		return `"${preview}"`;
+	}
 	if (Array.isArray(value)) return `[${value.length} items]`;
 	if (typeof value === "object") {
 		const keys = Object.keys(value);
@@ -845,74 +851,90 @@ export function renderResult(
 	options: RenderResultOptions,
 	theme: Theme,
 ): Component {
-	const { expanded, isPartial, spinnerFrame } = options;
 	const fallbackText = result.content.find(c => c.type === "text")?.text ?? "";
 	const details = result.details;
 
 	if (!details) {
-		// Fallback to simple text
 		const text = result.content.find(c => c.type === "text")?.text || "";
 		return new Text(theme.fg("dim", truncateToWidth(text, 100)), 0, 0);
 	}
 
-	const lines: string[] = [];
-
-	if (isPartial && details.progress) {
-		// Streaming progress view
-		details.progress.forEach((progress, i) => {
-			const isLast = i === details.progress!.length - 1;
-			lines.push(...renderAgentProgress(progress, isLast, expanded, theme, spinnerFrame));
-		});
-	} else if (details.results.length > 0) {
-		// Final results view
-		details.results.forEach((res, i) => {
-			const isLast = i === details.results.length - 1;
-			lines.push(...renderAgentResult(res, isLast, expanded, theme));
-		});
-
-		// Summary line
-		const abortedCount = details.results.filter(r => r.aborted).length;
-		const successCount = details.results.filter(r => !r.aborted && r.exitCode === 0).length;
-		const failCount = details.results.length - successCount - abortedCount;
-		let summary = `${theme.fg("dim", "Total:")} `;
-		if (abortedCount > 0) {
-			summary += theme.fg("error", `${abortedCount} aborted`);
-			if (successCount > 0 || failCount > 0) summary += theme.sep.dot;
-		}
-		if (successCount > 0) {
-			summary += theme.fg("success", `${successCount} succeeded`);
-			if (failCount > 0) summary += theme.sep.dot;
-		}
-		if (failCount > 0) {
-			summary += theme.fg("error", `${failCount} failed`);
-		}
-		summary += `${theme.sep.dot}${theme.fg("dim", formatDuration(details.totalDurationMs))}`;
-		lines.push(summary);
-
-		// Artifacts suppressed from user view - available via session file
-	}
+	let cached: RenderCache | undefined;
+
+	return {
+		render(width) {
+			const { expanded, isPartial, spinnerFrame } = options;
+			const key = new Hasher()
+				.bool(expanded)
+				.bool(isPartial)
+				.u32(spinnerFrame ?? 0)
+				.u32(width)
+				.digest();
+			if (cached?.key === key) return cached.lines;
+
+			const lines: string[] = [];
+
+			if (isPartial && details.progress) {
+				details.progress.forEach((progress, i) => {
+					const isLast = i === details.progress!.length - 1;
+					lines.push(...renderAgentProgress(progress, isLast, expanded, theme, spinnerFrame));
+				});
+			} else if (details.results.length > 0) {
+				details.results.forEach((res, i) => {
+					const isLast = i === details.results.length - 1;
+					lines.push(...renderAgentResult(res, isLast, expanded, theme));
+				});
+
+				const abortedCount = details.results.filter(r => r.aborted).length;
+				const successCount = details.results.filter(r => !r.aborted && r.exitCode === 0).length;
+				const failCount = details.results.length - successCount - abortedCount;
+				let summary = `${theme.fg("dim", "Total:")} `;
+				if (abortedCount > 0) {
+					summary += theme.fg("error", `${abortedCount} aborted`);
+					if (successCount > 0 || failCount > 0) summary += theme.sep.dot;
+				}
+				if (successCount > 0) {
+					summary += theme.fg("success", `${successCount} succeeded`);
+					if (failCount > 0) summary += theme.sep.dot;
+				}
+				if (failCount > 0) {
+					summary += theme.fg("error", `${failCount} failed`);
+				}
+				summary += `${theme.sep.dot}${theme.fg("dim", formatDuration(details.totalDurationMs))}`;
+				lines.push(summary);
+			}
 
-	if (lines.length === 0) {
-		const text = fallbackText.trim() ? fallbackText : "No results";
-		return new Text(theme.fg("dim", truncateToWidth(text, 140)), 0, 0);
-	}
+			if (lines.length === 0) {
+				const text = fallbackText.trim() ? fallbackText : "No results";
+				const result = [theme.fg("dim", truncateToWidth(text, width))];
+				cached = { key, lines: result };
+				return result;
+			}
 
-	if (fallbackText.trim()) {
-		const summaryLines = fallbackText.split("\n");
-		const markerIndex = summaryLines.findIndex(
-			line => line.includes("<system-notification>") || line.startsWith("Applied patches:"),
-		);
-		if (markerIndex >= 0) {
-			const extra = summaryLines.slice(markerIndex);
-			for (const line of extra) {
-				if (!line.trim()) continue;
-				lines.push(theme.fg("dim", line));
+			if (fallbackText.trim()) {
+				const summaryLines = fallbackText.split("\n");
+				const markerIndex = summaryLines.findIndex(
+					line => line.includes("<system-notification>") || line.startsWith("Applied patches:"),
+				);
+				if (markerIndex >= 0) {
+					const extra = summaryLines.slice(markerIndex);
+					for (const line of extra) {
+						if (!line.trim()) continue;
+						lines.push(theme.fg("dim", line));
+					}
+				}
 			}
-		}
-	}
 
-	const indented = lines.map(line => (line.length > 0 ? `   ${line}` : ""));
-	return new Text(indented.join("\n"), 0, 0);
+			const indented = lines.map(line =>
+				line.length > 0 ? truncateToWidth(`   ${line}`, width, Ellipsis.Omit) : "",
+			);
+			cached = { key, lines: indented };
+			return indented;
+		},
+		invalidate() {
+			cached = undefined;
+		},
+	};
 }
 
 function isTaskToolDetails(value: unknown): value is TaskToolDetails {

package/src/tools/ask.ts

@@ -446,7 +446,7 @@ export const askToolRenderer = {
 
 	renderResult(
 		result: { content: Array<{ type: string; text?: string }>; details?: AskToolDetails },
-		_opts: RenderResultOptions,
+		_options: RenderResultOptions,
 		uiTheme: Theme,
 	): Component {
 		const { details } = result;
@@ -454,7 +454,13 @@ export const askToolRenderer = {
 			const txt = result.content[0];
 			const fallback = txt?.type === "text" && txt.text ? txt.text : "";
 			const header = renderStatusLine({ icon: "warning", title: "Ask" }, uiTheme);
-			return new Text([header, uiTheme.fg("dim", fallback)].join("\n"), 0, 0);
+			const renderedLines = [header, uiTheme.fg("dim", fallback)];
+			return {
+				render() {
+					return renderedLines;
+				},
+				invalidate() {},
+			};
 		}
 
 		// Multi-part results
@@ -506,13 +512,24 @@ export const askToolRenderer = {
 				}
 			}
 
-			return new Text(lines.join("\n"), 0, 0);
+			return {
+				render() {
+					return lines;
+				},
+				invalidate() {},
+			};
 		}
 
 		// Single question result
 		if (!details.question) {
 			const txt = result.content[0];
-			return new Text(txt?.type === "text" && txt.text ? txt.text : "", 0, 0);
+			const renderedLines = txt?.type === "text" && txt.text ? txt.text.split("\n") : [""];
+			return {
+				render() {
+					return renderedLines;
+				},
+				invalidate() {},
+			};
 		}
 
 		const hasSelection = details.customInput || (details.selectedOptions && details.selectedOptions.length > 0);
@@ -535,6 +552,12 @@ export const askToolRenderer = {
 			text += `\n ${uiTheme.fg("dim", uiTheme.tree.last)} ${uiTheme.styledSymbol("status.warning", "warning")} ${uiTheme.fg("warning", "Cancelled")}`;
 		}
 
-		return new Text(text, 0, 0);
+		const renderedLines = text.split("\n");
+		return {
+			render() {
+				return renderedLines;
+			},
+			invalidate() {},
+		};
 	},
 };

package/src/tools/bash.ts

@@ -2,14 +2,15 @@ import * as path from "node:path";
 import type { AgentTool, AgentToolContext, AgentToolResult, AgentToolUpdateCallback } from "@oh-my-pi/pi-agent-core";
 import type { Component } from "@oh-my-pi/pi-tui";
 import { Text } from "@oh-my-pi/pi-tui";
-import { Type } from "@sinclair/typebox";
+import { type Static, Type } from "@sinclair/typebox";
 import { renderPromptTemplate } from "../config/prompt-templates";
 import { type BashExecutorOptions, executeBash } from "../exec/bash-executor";
 import type { RenderResultOptions } from "../extensibility/custom-tools/types";
 import { truncateToVisualLines } from "../modes/components/visual-truncate";
 import type { Theme } from "../modes/theme/theme";
 import bashDescription from "../prompts/tools/bash.md" with { type: "text" };
-import { renderOutputBlock, renderStatusLine } from "../tui";
+import { renderStatusLine } from "../tui";
+import { CachedOutputBlock } from "../tui/output-block";
 import type { ToolSession } from ".";
 import { checkBashInterception } from "./bash-interceptor";
 import { applyHeadTail, normalizeBashCommand } from "./bash-normalize";
@@ -31,6 +32,8 @@ const bashSchema = Type.Object({
 	tail: Type.Optional(Type.Number({ description: "Return only last N lines of output" })),
 });
 
+export type BashToolInput = Static<typeof bashSchema>;
+
 export interface BashToolDetails {
 	meta?: OutputMeta;
 }
@@ -221,46 +224,49 @@ export const bashToolRenderer = {
 		const cmdText = args ? formatBashCommand(args, uiTheme) : undefined;
 		const isError = result.isError === true;
 		const header = renderStatusLine({ icon: isError ? "error" : "success", title: "Bash" }, uiTheme);
-		const { renderContext } = options;
 		const details = result.details;
-		const expanded = renderContext?.expanded ?? options.expanded;
-		const previewLines = renderContext?.previewLines ?? BASH_DEFAULT_PREVIEW_LINES;
-
-		// Get output from context (preferred) or fall back to result content
-		const output = renderContext?.output ?? result.content?.find(c => c.type === "text")?.text ?? "";
-		const displayOutput = output.trimEnd();
-		const showingFullOutput = expanded && renderContext?.isFullOutput === true;
-
-		// Build truncation warning lines (static, doesn't depend on width)
 		const truncation = details?.meta?.truncation;
-		const timeoutSeconds = renderContext?.timeout;
-		const timeoutLine =
-			typeof timeoutSeconds === "number"
-				? uiTheme.fg(
-						"dim",
-						`${uiTheme.format.bracketLeft}Timeout: ${timeoutSeconds}s${uiTheme.format.bracketRight}`,
-					)
-				: undefined;
-		let warningLine: string | undefined;
-		if (truncation && !showingFullOutput) {
-			const warnings: string[] = [];
-			if (truncation?.artifactId) {
-				warnings.push(`Full output: artifact://${truncation.artifactId}`);
-			}
-			if (truncation.truncatedBy === "lines") {
-				warnings.push(`Truncated: showing ${truncation.outputLines} of ${truncation.totalLines} lines`);
-			} else {
-				warnings.push(
-					`Truncated: ${truncation.outputLines} lines shown (${formatBytes(truncation.outputBytes)} limit)`,
-				);
-			}
-			if (warnings.length > 0) {
-				warningLine = uiTheme.fg("warning", wrapBrackets(warnings.join(". "), uiTheme));
-			}
-		}
+		const outputBlock = new CachedOutputBlock();
 
 		return {
 			render: (width: number): string[] => {
+				// REACTIVE: read mutable options at render time
+				const { renderContext } = options;
+				const expanded = renderContext?.expanded ?? options.expanded;
+				const previewLines = renderContext?.previewLines ?? BASH_DEFAULT_PREVIEW_LINES;
+
+				// Get output from context (preferred) or fall back to result content
+				const output = renderContext?.output ?? result.content?.find(c => c.type === "text")?.text ?? "";
+				const displayOutput = output.trimEnd();
+				const showingFullOutput = expanded && renderContext?.isFullOutput === true;
+
+				// Build truncation warning
+				const timeoutSeconds = renderContext?.timeout;
+				const timeoutLine =
+					typeof timeoutSeconds === "number"
+						? uiTheme.fg(
+								"dim",
+								`${uiTheme.format.bracketLeft}Timeout: ${timeoutSeconds}s${uiTheme.format.bracketRight}`,
+							)
+						: undefined;
+				let warningLine: string | undefined;
+				if (truncation && !showingFullOutput) {
+					const warnings: string[] = [];
+					if (truncation?.artifactId) {
+						warnings.push(`Full output: artifact://${truncation.artifactId}`);
+					}
+					if (truncation.truncatedBy === "lines") {
+						warnings.push(`Truncated: showing ${truncation.outputLines} of ${truncation.totalLines} lines`);
+					} else {
+						warnings.push(
+							`Truncated: ${truncation.outputLines} lines shown (${formatBytes(truncation.outputBytes)} limit)`,
+						);
+					}
+					if (warnings.length > 0) {
+						warningLine = uiTheme.fg("warning", wrapBrackets(warnings.join(". "), uiTheme));
+					}
+				}
+
 				const outputLines: string[] = [];
 				const hasOutput = displayOutput.trim().length > 0;
 				if (hasOutput) {
@@ -287,7 +293,7 @@ export const bashToolRenderer = {
 				if (timeoutLine) outputLines.push(timeoutLine);
 				if (warningLine) outputLines.push(warningLine);
 
-				return renderOutputBlock(
+				return outputBlock.render(
 					{
 						header,
 						state: isError ? "error" : "success",
@@ -300,7 +306,9 @@ export const bashToolRenderer = {
 					uiTheme,
 				);
 			},
-			invalidate: () => {},
+			invalidate: () => {
+				outputBlock.invalidate();
+			},
 		};
 	},
 	mergeCallAndResult: true,