@oh-my-pi/pi-coding-agent 11.2.2 → 11.2.3

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "11.2.2",
+	"version": "11.2.3",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"type": "module",
 	"ompConfig": {
@@ -87,15 +87,15 @@
 		"test": "bun test"
 	},
 	"dependencies": {
-		"@oclif/core": "^4.5.6",
-		"@oclif/plugin-autocomplete": "^3.2.23",
+		"@oclif/core": "^4.8.0",
+		"@oclif/plugin-autocomplete": "^3.2.40",
 		"@mozilla/readability": "0.6.0",
-		"@oh-my-pi/omp-stats": "11.2.2",
-		"@oh-my-pi/pi-agent-core": "11.2.2",
-		"@oh-my-pi/pi-ai": "11.2.2",
-		"@oh-my-pi/pi-natives": "11.2.2",
-		"@oh-my-pi/pi-tui": "11.2.2",
-		"@oh-my-pi/pi-utils": "11.2.2",
+		"@oh-my-pi/omp-stats": "11.2.3",
+		"@oh-my-pi/pi-agent-core": "11.2.3",
+		"@oh-my-pi/pi-ai": "11.2.3",
+		"@oh-my-pi/pi-natives": "11.2.3",
+		"@oh-my-pi/pi-tui": "11.2.3",
+		"@oh-my-pi/pi-utils": "11.2.3",
 		"@sinclair/typebox": "^0.34.48",
 		"ajv": "^8.17.1",
 		"chalk": "^5.6.2",
@@ -107,7 +107,7 @@
 		"jsdom": "28.0.0",
 		"marked": "^17.0.1",
 		"node-html-parser": "^7.0.2",
-		"puppeteer": "^24.36.1",
+		"puppeteer": "^24.37.1",
 		"smol-toml": "^1.6.0",
 		"zod": "^4.3.6"
 	},

package/src/mcp/transports/stdio.ts

@@ -4,6 +4,8 @@
  * Implements JSON-RPC 2.0 over subprocess stdin/stdout.
  * Messages are newline-delimited JSON.
  */
+
+import { readLines } from "@oh-my-pi/pi-utils";
 import { type Subprocess, spawn } from "bun";
 import type { JsonRpcResponse, MCPStdioServerConfig, MCPTransport } from "../../mcp/types";
 
@@ -25,7 +27,6 @@ export class StdioTransport implements MCPTransport {
 			reject: (error: Error) => void;
 		}
 	>();
-	private buffer = "";
 	private _connected = false;
 	private readLoop: Promise<void> | null = null;
 
@@ -72,23 +73,21 @@ export class StdioTransport implements MCPTransport {
 	private async startReadLoop(): Promise<void> {
 		if (!this.process?.stdout) return;
 
-		const reader = this.process.stdout.getReader();
 		const decoder = new TextDecoder();
-
 		try {
-			while (this._connected) {
-				const { done, value } = await reader.read();
-				if (done) break;
-
-				this.buffer += decoder.decode(value, { stream: true });
-				this.processBuffer();
+			for await (const line of readLines(this.process.stdout)) {
+				if (!this._connected) break;
+				try {
+					this.handleMessage(JSON.parse(decoder.decode(line)) as JsonRpcResponse);
+				} catch {
+					// Skip malformed lines
+				}
 			}
 		} catch (error) {
 			if (this._connected) {
 				this.onError?.(error instanceof Error ? error : new Error(String(error)));
 			}
 		} finally {
-			reader.releaseLock();
 			this.handleClose();
 		}
 	}
@@ -117,29 +116,6 @@ export class StdioTransport implements MCPTransport {
 		}
 	}
 
-	private processBuffer(): void {
-		while (this.buffer.length > 0) {
-			const result = Bun.JSONL.parseChunk(this.buffer);
-			for (const message of result.values) {
-				this.handleMessage(message as JsonRpcResponse);
-			}
-
-			if (result.error) {
-				const nextNewline = this.buffer.indexOf("\n", result.read);
-				if (nextNewline === -1) {
-					this.buffer = "";
-					break;
-				}
-				this.buffer = this.buffer.slice(nextNewline + 1);
-				continue;
-			}
-
-			if (result.read === 0) break;
-			this.buffer = this.buffer.slice(result.read);
-			if (result.done) break;
-		}
-	}
-
 	private handleMessage(message: JsonRpcResponse): void {
 		// Check if it's a response (has id)
 		if ("id" in message && message.id !== null) {

package/src/modes/rpc/rpc-client.ts

@@ -5,7 +5,7 @@
  */
 import type { AgentEvent, AgentMessage, ThinkingLevel } from "@oh-my-pi/pi-agent-core";
 import type { ImageContent } from "@oh-my-pi/pi-ai";
-import { createTextLineSplitter, ptree } from "@oh-my-pi/pi-utils";
+import { ptree, readJsonl } from "@oh-my-pi/pi-utils";
 import type { BashResult } from "../../exec/bash-executor";
 import type { SessionStats } from "../../session/agent-session";
 import type { CompactionResult } from "../../session/compaction";
@@ -83,11 +83,11 @@ function isAgentEvent(value: unknown): value is AgentEvent {
 
 export class RpcClient {
 	private process: ptree.ChildProcess | null = null;
-	private lineReader: ReadableStream<string> | null = null;
 	private eventListeners: RpcEventListener[] = [];
 	private pendingRequests: Map<string, { resolve: (response: RpcResponse) => void; reject: (error: Error) => void }> =
 		new Map();
 	private requestId = 0;
+	private abortController = new AbortController();
 
 	constructor(private options: RpcClientOptions = {}) {}
 
@@ -119,19 +119,12 @@ export class RpcClient {
 		});
 
 		// Process lines in background
-		const lines = this.process.stdout.pipeThrough(createTextLineSplitter(true));
-		this.lineReader = lines;
+		const lines = readJsonl(this.process.stdout, this.abortController.signal);
 		void (async () => {
-			try {
-				for await (const line of lines) {
-					this.handleLine(line);
-				}
-			} catch {
-				// Stream closed
-			} finally {
-				lines.cancel();
+			for await (const line of lines) {
+				this.handleLine(line);
 			}
-		})();
+		})().catch(() => {});
 
 		// Wait a moment for process to initialize
 		await Bun.sleep(100);
@@ -154,11 +147,9 @@ export class RpcClient {
 	stop() {
 		if (!this.process) return;
 
-		this.lineReader?.cancel();
 		this.process.kill();
-
+		this.abortController.abort();
 		this.process = null;
-		this.lineReader = null;
 		this.pendingRequests.clear();
 	}
 
@@ -461,29 +452,23 @@ export class RpcClient {
 	// Internal
 	// =========================================================================
 
-	private handleLine(line: string): void {
-		const result = Bun.JSONL.parseChunk(line);
-		if (result.error) return;
-
-		for (const data of result.values) {
-			// Check if it's a response to a pending request
-			if (isRpcResponse(data)) {
-				const id = data.id;
-				if (id && this.pendingRequests.has(id)) {
-					const pending = this.pendingRequests.get(id)!;
-					this.pendingRequests.delete(id);
-					pending.resolve(data);
-					return;
-				}
-				continue;
+	private handleLine(data: unknown): void {
+		// Check if it's a response to a pending request
+		if (isRpcResponse(data)) {
+			const id = data.id;
+			if (id && this.pendingRequests.has(id)) {
+				const pending = this.pendingRequests.get(id)!;
+				this.pendingRequests.delete(id);
+				pending.resolve(data);
+				return;
 			}
+		}
 
-			if (!isAgentEvent(data)) continue;
+		if (!isAgentEvent(data)) return;
 
-			// Otherwise it's an event
-			for (const listener of this.eventListeners) {
-				listener(data);
-			}
+		// Otherwise it's an event
+		for (const listener of this.eventListeners) {
+			listener(data);
 		}
 	}
 

package/src/modes/rpc/rpc-mode.ts

@@ -10,7 +10,7 @@
  * - Events: AgentSessionEvent objects streamed as they occur
  * - Extension UI: Extension UI requests are emitted, client responds with extension_ui_response
  */
-import { createTextLineSplitter, Snowflake } from "@oh-my-pi/pi-utils";
+import { readJsonl, Snowflake } from "@oh-my-pi/pi-utils";
 import type { ExtensionUIContext, ExtensionUIDialogOptions } from "../../extensibility/extensions";
 import { type Theme, theme } from "../../modes/theme/theme";
 import type { AgentSession } from "../../session/agent-session";
@@ -633,37 +633,27 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 	}
 
 	// Listen for JSON input using Bun's stdin
-	for await (const line of Bun.stdin.stream().pipeThrough(createTextLineSplitter())) {
-		if (!line.trim()) continue;
-
-		const result = Bun.JSONL.parseChunk(`${line}\n`);
-		if (result.error) {
-			output(error(undefined, "parse", `Failed to parse command: ${result.error.message}`));
-			continue;
-		}
-
-		for (const parsed of result.values) {
-			try {
-				// Handle extension UI responses
-				if ((parsed as RpcExtensionUIResponse).type === "extension_ui_response") {
-					const response = parsed as RpcExtensionUIResponse;
-					const pending = pendingExtensionRequests.get(response.id);
-					if (pending) {
-						pending.resolve(response);
-					}
-					continue;
+	for await (const parsed of readJsonl(Bun.stdin.stream())) {
+		try {
+			// Handle extension UI responses
+			if ((parsed as RpcExtensionUIResponse).type === "extension_ui_response") {
+				const response = parsed as RpcExtensionUIResponse;
+				const pending = pendingExtensionRequests.get(response.id);
+				if (pending) {
+					pending.resolve(response);
 				}
+				continue;
+			}
 
-				// Handle regular commands
-				const command = parsed as RpcCommand;
-				const response = await handleCommand(command);
-				output(response);
+			// Handle regular commands
+			const command = parsed as RpcCommand;
+			const response = await handleCommand(command);
+			output(response);
 
-				// Check for deferred shutdown request (idle between commands)
-				await checkShutdownRequested();
-			} catch (e: any) {
-				output(error(undefined, "parse", `Failed to parse command: ${e.message}`));
-			}
+			// Check for deferred shutdown request (idle between commands)
+			await checkShutdownRequested();
+		} catch (e: any) {
+			output(error(undefined, "parse", `Failed to parse command: ${e.message}`));
 		}
 	}
 

package/src/session/session-manager.ts

@@ -1,7 +1,7 @@
 import * as path from "node:path";
 import type { AgentMessage } from "@oh-my-pi/pi-agent-core";
 import type { ImageContent, Message, TextContent, Usage } from "@oh-my-pi/pi-ai";
-import { isEnoent, logger, Snowflake } from "@oh-my-pi/pi-utils";
+import { isEnoent, logger, parseJsonlLenient, Snowflake } from "@oh-my-pi/pi-utils";
 import { getAgentDir as getDefaultAgentDir } from "../config";
 import { resizeImage } from "../utils/image-resize";
 import {
@@ -279,32 +279,6 @@ function migrateToCurrentVersion(entries: FileEntry[]): boolean {
 	return true;
 }
 
-function parseJsonlEntries<T>(buffer: string): T[] {
-	let entries: T[] | undefined;
-
-	while (buffer.length > 0) {
-		const { values, error, read, done } = Bun.JSONL.parseChunk(buffer);
-		if (values.length > 0) {
-			const ext = values as T[];
-			if (!entries) {
-				entries = ext;
-			} else {
-				entries.push(...ext);
-			}
-		}
-		if (error) {
-			const nextNewline = buffer.indexOf("\n", read);
-			if (nextNewline === -1) break;
-			buffer = buffer.substring(nextNewline + 1);
-			continue;
-		}
-		if (read === 0) break;
-		buffer = buffer.substring(read);
-		if (done) break;
-	}
-	return entries ?? [];
-}
-
 /** Exported for testing */
 export function migrateSessionEntries(entries: FileEntry[]): void {
 	migrateToCurrentVersion(entries);
@@ -312,7 +286,7 @@ export function migrateSessionEntries(entries: FileEntry[]): void {
 
 /** Exported for compaction.test.ts */
 export function parseSessionEntries(content: string): FileEntry[] {
-	return parseJsonlEntries<FileEntry>(content);
+	return parseJsonlLenient<FileEntry>(content);
 }
 
 export function getLatestCompactionEntry(entries: SessionEntry[]): CompactionEntry | null {
@@ -485,7 +459,7 @@ export async function loadEntriesFromFile(
 		if (isEnoent(err)) return [];
 		throw err;
 	}
-	const entries = parseJsonlEntries<FileEntry>(content);
+	const entries = parseJsonlLenient<FileEntry>(content);
 
 	// Validate session header
 	if (entries.length === 0) return entries;
@@ -587,7 +561,7 @@ async function getSortedSessions(sessionDir: string, storage: SessionStorage): P
 			files.map(async (path: string) => {
 				try {
 					const content = await storage.readTextPrefix(path, 4096);
-					const entries = parseJsonlEntries<Record<string, unknown>>(content);
+					const entries = parseJsonlLenient<Record<string, unknown>>(content);
 					if (entries.length === 0) return;
 					const header = entries[0] as Record<string, unknown>;
 					if (header.type !== "session" || typeof header.id !== "string") return;
@@ -915,7 +889,7 @@ async function collectSessionsFromFiles(files: string[], storage: SessionStorage
 		files.map(async file => {
 			try {
 				const content = await storage.readText(file);
-				const entries = parseJsonlEntries<Record<string, unknown>>(content);
+				const entries = parseJsonlLenient<Record<string, unknown>>(content);
 				if (entries.length === 0) return;
 
 				// Check first entry for valid session header

package/src/session/session-storage.ts

@@ -169,7 +169,7 @@ export class FileSessionStorage implements SessionStorage {
 	async readTextPrefix(path: string, maxBytes: number): Promise<string> {
 		const handle = await fs.promises.open(path, "r");
 		try {
-			const buffer = Buffer.alloc(maxBytes);
+			const buffer = Buffer.allocUnsafe(maxBytes);
 			const { bytesRead } = await handle.read(buffer, 0, maxBytes, 0);
 			return buffer.subarray(0, bytesRead).toString("utf-8");
 		} finally {

package/src/tools/read.ts

@@ -43,7 +43,7 @@ function isRemoteMountPath(absolutePath: string): boolean {
 	return absolutePath.startsWith(REMOTE_MOUNT_PREFIX);
 }
 
-const READ_CHUNK_SIZE = 64 * 1024;
+const READ_CHUNK_SIZE = 8 * 1024;
 
 async function streamLinesFromFile(
 	filePath: string,

package/src/utils/mime.ts

@@ -8,7 +8,7 @@ const FILE_TYPE_SNIFF_BYTES = 4100;
 export async function detectSupportedImageMimeTypeFromFile(filePath: string): Promise<string | null> {
 	const fileHandle = await fs.open(filePath, "r");
 	try {
-		const buffer = Buffer.alloc(FILE_TYPE_SNIFF_BYTES);
+		const buffer = Buffer.allocUnsafe(FILE_TYPE_SNIFF_BYTES);
 		const { bytesRead } = await fileHandle.read(buffer, 0, FILE_TYPE_SNIFF_BYTES, 0);
 		if (bytesRead === 0) {
 			return null;

package/src/web/scrapers/utils.ts

@@ -68,9 +68,11 @@ export async function convertWithMarkitdown(
 	}
 }
 
+const kEmptyBuffer = Buffer.alloc(0);
+
 export async function fetchBinary(url: string, timeout: number, userSignal?: AbortSignal): Promise<BinaryFetchResult> {
 	if (userSignal?.aborted) {
-		return { buffer: Buffer.alloc(0), contentType: "", ok: false, error: "aborted" };
+		return { buffer: kEmptyBuffer, contentType: "", ok: false, error: "aborted" };
 	}
 
 	const signal = ptree.combineSignals(userSignal, timeout * 1000);
@@ -89,7 +91,7 @@ export async function fetchBinary(url: string, timeout: number, userSignal?: Abo
 
 		if (!response.ok) {
 			return {
-				buffer: Buffer.alloc(0),
+				buffer: kEmptyBuffer,
 				contentType,
 				contentDisposition,
 				ok: false,
@@ -103,7 +105,7 @@ export async function fetchBinary(url: string, timeout: number, userSignal?: Abo
 			const size = Number.parseInt(contentLength, 10);
 			if (Number.isFinite(size) && size > MAX_BYTES) {
 				return {
-					buffer: Buffer.alloc(0),
+					buffer: kEmptyBuffer,
 					contentType,
 					contentDisposition,
 					ok: false,
@@ -116,7 +118,7 @@ export async function fetchBinary(url: string, timeout: number, userSignal?: Abo
 		const buffer = Buffer.from(await response.arrayBuffer());
 		if (buffer.length > MAX_BYTES) {
 			return {
-				buffer: Buffer.alloc(0),
+				buffer: kEmptyBuffer,
 				contentType,
 				contentDisposition,
 				ok: false,
@@ -128,10 +130,10 @@ export async function fetchBinary(url: string, timeout: number, userSignal?: Abo
 		return { buffer, contentType, contentDisposition, ok: true, status: response.status };
 	} catch (err) {
 		if (signal?.aborted) {
-			return { buffer: Buffer.alloc(0), contentType: "", ok: false, error: "aborted" };
+			return { buffer: kEmptyBuffer, contentType: "", ok: false, error: "aborted" };
 		}
 		return {
-			buffer: Buffer.alloc(0),
+			buffer: kEmptyBuffer,
 			contentType: "",
 			ok: false,
 			error: `request failed: ${String(err)}`,