@oh-my-pi/pi-coding-agent 10.2.2 → 10.2.3

package/src/lsp/render.ts

@@ -33,7 +33,6 @@ import type { LspParams, LspToolDetails } from "./types";
 export function renderCall(args: LspParams, theme: Theme): Text {
 	const actionLabel = (args.action ?? "request").replace(/_/g, " ");
 	const queryPreview = args.query ? truncateToWidth(args.query, TRUNCATE_LENGTHS.SHORT) : undefined;
-	const replacementPreview = args.replacement ? truncateToWidth(args.replacement, TRUNCATE_LENGTHS.SHORT) : undefined;
 
 	let target: string | undefined;
 	let hasFileTarget = false;
@@ -67,17 +66,10 @@ export function renderCall(args: LspParams, theme: Theme): Text {
 	const meta: string[] = [];
 	if (queryPreview && target) meta.push(`query:${queryPreview}`);
 	if (args.new_name) meta.push(`new:${args.new_name}`);
-	if (replacementPreview) meta.push(`replace:${replacementPreview}`);
-	if (args.kind) meta.push(`kind:${args.kind}`);
 	if (args.apply !== undefined) meta.push(`apply:${args.apply ? "true" : "false"}`);
-	if (args.action_index !== undefined) meta.push(`action:${args.action_index}`);
 	if (args.include_declaration !== undefined) {
 		meta.push(`include_decl:${args.include_declaration ? "true" : "false"}`);
 	}
-	if (args.end_line !== undefined && args.line === undefined) {
-		const endCol = args.end_character !== undefined ? `:${args.end_character}` : "";
-		meta.push(`end:${args.end_line}${endCol}`);
-	}
 
 	const descriptionParts = [actionLabel];
 	if (target) {
@@ -178,10 +170,7 @@ export function renderResult(
 	}
 	if (request?.query) requestLines.push(theme.fg("dim", `query: ${request.query}`));
 	if (request?.new_name) requestLines.push(theme.fg("dim", `new name: ${request.new_name}`));
-	if (request?.replacement) requestLines.push(theme.fg("dim", `replacement: ${request.replacement}`));
-	if (request?.kind) requestLines.push(theme.fg("dim", `kind: ${request.kind}`));
 	if (request?.apply !== undefined) requestLines.push(theme.fg("dim", `apply: ${request.apply ? "true" : "false"}`));
-	if (request?.action_index !== undefined) requestLines.push(theme.fg("dim", `action: ${request.action_index}`));
 	if (request?.include_declaration !== undefined) {
 		requestLines.push(theme.fg("dim", `include declaration: ${request.include_declaration ? "true" : "false"}`));
 	}

package/src/lsp/types.ts

@@ -7,31 +7,9 @@ import { type Static, Type } from "@sinclair/typebox";
 // =============================================================================
 
 export const lspSchema = Type.Object({
-	action: StringEnum(
-		[
-			// Standard LSP operations
-			"diagnostics",
-			"workspace_diagnostics",
-			"references",
-			"definition",
-			"hover",
-			"symbols",
-			"workspace_symbols",
-			"rename",
-			"actions",
-			"incoming_calls",
-			"outgoing_calls",
-			"status",
-			// Rust-analyzer specific operations
-			"flycheck",
-			"expand_macro",
-			"ssr",
-			"runnables",
-			"related_tests",
-			"reload_workspace",
-		],
-		{ description: "LSP operation" },
-	),
+	action: StringEnum(["diagnostics", "definition", "references", "hover", "symbols", "rename", "status", "reload"], {
+		description: "LSP operation",
+	}),
 	files: Type.Optional(Type.Array(Type.String({ description: "File path" }))),
 	file: Type.Optional(Type.String({ description: "File path" })),
 	line: Type.Optional(Type.Number({ description: "Line number (1-indexed)" })),
@@ -40,10 +18,7 @@ export const lspSchema = Type.Object({
 	end_character: Type.Optional(Type.Number({ description: "End column for range (1-indexed)" })),
 	query: Type.Optional(Type.String({ description: "Search query or SSR pattern" })),
 	new_name: Type.Optional(Type.String({ description: "New name for rename" })),
-	replacement: Type.Optional(Type.String({ description: "Replacement text for SSR" })),
-	kind: Type.Optional(Type.String({ description: "Action kind: quickfix, refactor, source" })),
 	apply: Type.Optional(Type.Boolean({ description: "Apply edits (default: true)" })),
-	action_index: Type.Optional(Type.Number({ description: "Index of action to apply" })),
 	include_declaration: Type.Optional(Type.Boolean({ description: "Include declaration in refs (default: true)" })),
 });
 
@@ -414,65 +389,6 @@ export interface LspClient {
 	lastActivity: number;
 }
 
-// =============================================================================
-// Call Hierarchy Types
-// =============================================================================
-
-export interface CallHierarchyItem {
-	name: string;
-	kind: SymbolKind;
-	tags?: number[];
-	detail?: string;
-	uri: string;
-	range: Range;
-	selectionRange: Range;
-	data?: unknown;
-}
-
-export interface CallHierarchyIncomingCall {
-	from: CallHierarchyItem;
-	fromRanges: Range[];
-}
-
-export interface CallHierarchyOutgoingCall {
-	to: CallHierarchyItem;
-	fromRanges: Range[];
-}
-
-// =============================================================================
-// Rust-analyzer Specific Types
-// =============================================================================
-
-export interface ExpandMacroResult {
-	name: string;
-	expansion: string;
-}
-
-export interface Runnable {
-	label: string;
-	kind: string;
-	args?: {
-		workspaceRoot?: string;
-		cargoArgs?: string[];
-		cargoExtraArgs?: string[];
-		executableArgs?: string[];
-	};
-	location?: {
-		targetUri: string;
-		targetRange?: Range;
-		targetSelectionRange?: Range;
-	};
-}
-
-export interface RelatedTest {
-	runnable?: {
-		label: string;
-		kind: string;
-		args?: Runnable["args"];
-		location?: Runnable["location"];
-	};
-}
-
 // =============================================================================
 // JSON-RPC Protocol Types
 // =============================================================================

package/src/modes/components/settings-defs.ts

@@ -13,6 +13,7 @@ import {
 	getPathsForTab,
 	getType,
 	getUi,
+	SETTING_TABS,
 	type SettingPath,
 	type SettingTab,
 } from "../../config/settings-schema";
@@ -73,7 +74,7 @@ const OPTION_PROVIDERS: Partial<Record<SettingPath, OptionProvider>> = {
 		{ value: "10", label: "10 retries" },
 	],
 	// Todo max reminders
-	"todoCompletion.maxReminders": () => [
+	"todo.reminders.max": () => [
 		{ value: "1", label: "1 reminder" },
 		{ value: "2", label: "2 reminders" },
 		{ value: "3", label: "3 reminders" },
@@ -227,7 +228,7 @@ export function getAllSettingDefs(): SettingDef[] {
 	if (cachedDefs) return cachedDefs;
 
 	const defs: SettingDef[] = [];
-	for (const tab of ["behavior", "tools", "bash", "display", "ttsr", "status", "lsp", "exa"] as SettingTab[]) {
+	for (const tab of [...SETTING_TABS, "status"] as SettingTab[]) {
 		for (const path of getPathsForTab(tab)) {
 			const def = pathToSettingDef(path);
 			if (def) defs.push(def);

package/src/modes/components/settings-selector.ts

@@ -19,6 +19,7 @@ import type {
 	StatusLineSegmentId,
 	StatusLineSeparatorStyle,
 } from "../../config/settings-schema";
+import { SETTING_TABS, TAB_METADATA } from "../../config/settings-schema";
 import { getSelectListTheme, getSettingsListTheme, theme } from "../../modes/theme/theme";
 import { DynamicBorder } from "./dynamic-border";
 import { PluginSettingsComponent } from "./plugin-settings";
@@ -116,17 +117,16 @@ class SelectSubmenu extends Container {
 	}
 }
 
-const SETTINGS_TABS: Tab[] = [
-	{ id: "behavior", label: "Behavior" },
-	{ id: "tools", label: "Tools" },
-	{ id: "bash", label: "Bash" },
-	{ id: "display", label: "Display" },
-	{ id: "ttsr", label: "TTSR" },
-	{ id: "status", label: "Status" },
-	{ id: "lsp", label: "LSP" },
-	{ id: "exa", label: "Exa" },
-	{ id: "plugins", label: "Plugins" },
-];
+function getSettingsTabs(): Tab[] {
+	return [
+		...SETTING_TABS.map(id => {
+			const meta = TAB_METADATA[id];
+			const icon = theme.symbol(meta.icon as Parameters<typeof theme.symbol>[0]);
+			return { id, label: `${icon} ${meta.label}` };
+		}),
+		{ id: "plugins", label: `${theme.icon.package} Plugins` },
+	];
+}
 
 /**
  * Dynamic context for settings that need runtime data.
@@ -177,7 +177,7 @@ export class SettingsSelectorComponent extends Container {
 	private pluginComponent: PluginSettingsComponent | null = null;
 	private statusPreviewContainer: Container | null = null;
 	private statusPreviewText: Text | null = null;
-	private currentTabId: SettingTab | "plugins" = "behavior";
+	private currentTabId: SettingTab | "plugins" = "display";
 
 	private context: SettingsRuntimeContext;
 	private callbacks: SettingsCallbacks;
@@ -192,7 +192,7 @@ export class SettingsSelectorComponent extends Container {
 		this.addChild(new DynamicBorder());
 
 		// Tab bar
-		this.tabBar = new TabBar("Settings", SETTINGS_TABS, getTabBarTheme());
+		this.tabBar = new TabBar("Settings", getSettingsTabs(), getTabBarTheme());
 		this.tabBar.onTabChange = () => {
 			this.switchToTab(this.tabBar.getActiveTab().id as SettingTab | "plugins");
 		};
@@ -202,7 +202,7 @@ export class SettingsSelectorComponent extends Container {
 		this.addChild(new Spacer(1));
 
 		// Initialize with first tab
-		this.switchToTab("behavior");
+		this.switchToTab("display");
 
 		// Add bottom border
 		this.addChild(new DynamicBorder());

package/src/modes/theme/theme.ts

@@ -168,7 +168,18 @@ export type SymbolKey =
 	| "lang.image"
 	| "lang.pdf"
 	| "lang.archive"
-	| "lang.binary";
+	| "lang.binary"
+	// Settings tab icons
+	| "tab.display"
+	| "tab.agent"
+	| "tab.input"
+	| "tab.tools"
+	| "tab.config"
+	| "tab.services"
+	| "tab.bash"
+	| "tab.lsp"
+	| "tab.ttsr"
+	| "tab.status";
 
 type SymbolMap = Record<SymbolKey, string>;
 
@@ -408,6 +419,17 @@ const UNICODE_SYMBOLS: SymbolMap = {
 	"lang.pdf": "❖ pdf",
 	"lang.archive": "❖ zip",
 	"lang.binary": "❖ bin",
+	// Settings tab icons
+	"tab.display": "🎨",
+	"tab.agent": "🤖",
+	"tab.input": "⌨",
+	"tab.tools": "🔧",
+	"tab.config": "⚙",
+	"tab.services": "🌐",
+	"tab.bash": "💻",
+	"tab.lsp": "📝",
+	"tab.ttsr": "⏱",
+	"tab.status": "📊",
 };
 
 const NERD_SYMBOLS: SymbolMap = {
@@ -646,6 +668,17 @@ const NERD_SYMBOLS: SymbolMap = {
 	"lang.pdf": "\u{F0226}",
 	"lang.archive": "\u{F187}",
 	"lang.binary": "\u{F019A}",
+	// Settings tab icons
+	"tab.display": "󰃣",
+	"tab.agent": "󰚩",
+	"tab.input": "󰌌",
+	"tab.tools": "󰠭",
+	"tab.config": "󰒓",
+	"tab.services": "󰖟",
+	"tab.bash": "",
+	"tab.lsp": "󰌌",
+	"tab.ttsr": "󱎫",
+	"tab.status": "󰄪",
 };
 
 const ASCII_SYMBOLS: SymbolMap = {
@@ -790,6 +823,17 @@ const ASCII_SYMBOLS: SymbolMap = {
 	"lang.pdf": "pdf",
 	"lang.archive": "zip",
 	"lang.binary": "bin",
+	// Settings tab icons
+	"tab.display": "[D]",
+	"tab.agent": "[A]",
+	"tab.input": "[I]",
+	"tab.tools": "[T]",
+	"tab.config": "[C]",
+	"tab.services": "[S]",
+	"tab.bash": "[B]",
+	"tab.lsp": "[L]",
+	"tab.ttsr": "[R]",
+	"tab.status": "[=]",
 };
 
 const SYMBOL_PRESETS: Record<SymbolPreset, SymbolMap> = {

package/src/prompts/agents/designer.md

@@ -1,75 +1,71 @@
 ---
 name: designer
-description: UI/UX specialist for design implementation, review, and visual refinement
+description: UI/UX specialist for design implementation, review, visual refinement
 spawns: explore
 model: google-gemini-cli/gemini-3-pro, gemini-3-pro, gemini-3, pi/default
 ---
 
-<role>Senior design engineer with 10+ years shipping production interfaces. You implement UI, conduct design reviews, and refine components. Your work is distinctive—never generic.</role>
+<role>Senior design engineer with 10+ years shipping production interfaces. Implements UI, conducts design reviews, refines components.</role>
 
 <critical>
-You CAN and SHOULD make file edits, create components, and run commands. This is your primary function.
-Before implementing: identify the aesthetic direction, existing patterns, and design tokens in use.
+You CAN and SHOULD make file edits, create components, run commands.
 </critical>
 
 <strengths>
-- Translating design intent into working UI code
-- Identifying UX issues: unclear states, missing feedback, poor hierarchy
+- Translate design intent into working UI code
+- Identify UX issues: unclear states, missing feedback, poor hierarchy
 - Accessibility: contrast, focus states, semantic markup, screen reader compatibility
 - Visual consistency: spacing, typography, color usage, component patterns
-- Responsive design and layout structure
+- Responsive design, layout structure
 </strengths>
 
 <procedure>
 ## Implementation
-1. Read existing components, tokens, and patterns—reuse before inventing
-2. Identify the aesthetic direction (minimal, bold, editorial, etc.)
-3. Implement with explicit states: loading, empty, error, disabled, hover, focus
+1. Read existing components, tokens, patterns—reuse before inventing
+2. Identify aesthetic direction (minimal, bold, editorial, etc.)
+3. Implement explicit states: loading, empty, error, disabled, hover, focus
 4. Verify accessibility: contrast, focus rings, semantic HTML
 5. Test responsive behavior
 
 ## Review
-1. Read the files under review
+1. Read files under review
 2. Check for UX issues, accessibility gaps, visual inconsistencies
-3. Cite file, line, and concrete issue—no vague feedback
+3. Cite file, line, concrete issue—no vague feedback
 4. Suggest specific fixes with code when applicable
 </procedure>
 
 <directives>
-- Prefer edits to existing files over creating new ones
+- Prefer editing existing files over creating new ones
 - Keep changes minimal and consistent with existing code style
 - NEVER create documentation files (*.md) unless explicitly requested
-- Be concise. No filler or ceremony.
-- Follow the main agent's instructions.
 </directives>
 
 <avoid>
 ## AI Slop Patterns
-These are fingerprints of generic AI-generated interfaces. Avoid them:
 - **Glassmorphism everywhere**: blur effects, glass cards, glow borders used decoratively
-- **Cyan-on-dark with purple gradients**: the 2024 AI color palette
+- **Cyan-on-dark with purple gradients**: 2024 AI color palette
 - **Gradient text on metrics/headings**: decorative without meaning
-- **Card grids with identical cards**: icon + heading + text, repeated endlessly
-- **Cards nested inside cards**: visual noise, flatten the hierarchy
-- **Large rounded-corner icons above every heading**: templated, adds no value
+- **Card grids with identical cards**: icon + heading + text repeated endlessly
+- **Cards nested inside cards**: visual noise, flatten hierarchy
+- **Large rounded-corner icons above every heading**: templated, no value
 - **Hero metric layouts**: big number, small label, gradient accent—overused
-- **Same spacing everywhere**: no rhythm, monotonous
+- **Same spacing everywhere**: no rhythm, monotony
 - **Center-aligned everything**: left-align with asymmetry feels more designed
-- **Modals for everything**: lazy pattern, rarely the best solution
+- **Modals for everything**: lazy pattern, rarely best solution
 - **Overused fonts**: Inter, Roboto, Open Sans, system defaults
 - **Pure black (#000) or pure white (#fff)**: always tint neutrals
-- **Gray text on colored backgrounds**: use a shade of the background instead
+- **Gray text on colored backgrounds**: use shade of background instead
 - **Bounce/elastic easing**: dated, tacky—use exponential easing (ease-out-quart/expo)
 
 ## UX Anti-Patterns
 - Missing states (loading, empty, error)
 - Redundant information (heading restates intro text)
 - Every button styled as primary—hierarchy matters
-- Empty states that just say "nothing here" instead of guiding the user
+- Empty states that say "nothing here" instead of guiding user
 </avoid>
 
 <critical>
-Every interface should make someone ask "how was this made?" not "which AI made this?"
-Commit to a clear aesthetic direction and execute with precision.
-Keep going until the implementation is complete. This matters.
+Every interface should prompt "how was this made?" not "which AI made this?"
+Commit to clear aesthetic direction; execute with precision.
+Keep going until implementation complete.
 </critical>

package/src/prompts/agents/explore.md

@@ -1,13 +1,13 @@
 ---
 name: explore
-description: Fast read-only codebase scout that returns compressed context for handoff
+description: Fast read-only codebase scout returning compressed context for handoff
 tools: read, grep, find, ls, bash
 model: pi/smol, haiku, flash, mini
 output:
   properties:
     query:
       metadata:
-        description: One-line summary of what was searched
+        description: One-line search summary
       type: string
     files:
       metadata:
@@ -16,7 +16,7 @@ output:
         properties:
           path:
             metadata:
-              description: Absolute path to the file
+              description: Absolute path to file
             type: string
           line_start:
             metadata:
@@ -28,28 +28,28 @@ output:
             type: number
           description:
             metadata:
-              description: What this section contains
+              description: Section contents
             type: string
     code:
       metadata:
-        description: Critical types, interfaces, or functions extracted verbatim
+        description: Critical types/interfaces/functions extracted verbatim
       elements:
         properties:
           path:
             metadata:
-              description: Absolute path to the source file
+              description: Absolute path to source file
             type: string
           line_start:
             metadata:
-              description: First line of excerpt (1-indexed)
+              description: Excerpt first line (1-indexed)
             type: number
           line_end:
             metadata:
-              description: Last line of excerpt (1-indexed)
+              description: Excerpt last line (1-indexed)
             type: number
           language:
             metadata:
-              description: Language identifier for syntax highlighting
+              description: Language id for syntax highlighting
             type: string
           content:
             metadata:
@@ -57,11 +57,11 @@ output:
             type: string
     architecture:
       metadata:
-        description: Brief explanation of how the pieces connect
+        description: Brief explanation of how pieces connect
       type: string
     start_here:
       metadata:
-        description: Recommended entry point for the receiving agent
+        description: Recommended entry point for receiving agent
       properties:
         path:
           metadata:
@@ -69,41 +69,31 @@ output:
           type: string
         reason:
           metadata:
-            description: Why this file is the best starting point
+            description: Why this file best starting point
           type: string
 ---
 
-<role>File search specialist and codebase scout. Quickly investigate a codebase and return structured findings that another agent can use without re-reading everything.</role>
+<role>File search specialist and codebase scout. Quickly investigate codebase, return structured findings another agent can use without re-reading everything.</role>
 
 <critical>
-This is a READ-ONLY exploration task. You are STRICTLY PROHIBITED from:
-- Creating or modifying files (no Write, Edit, touch, rm, mv, cp)
-- Creating temporary files anywhere, including /tmp
-- Using redirect operators (>, >>, |) or heredocs to write files
-- Running commands that change system state (git add, git commit, npm install, pip install)
-
-Your role is EXCLUSIVELY to search and analyze existing code.
+READ-ONLY. STRICTLY PROHIBITED from:
+- Creating/modifying files (no Write/Edit/touch/rm/mv/cp)
+- Creating temporary files anywhere (incl /tmp)
+- Using redirects (>, >>, |) or heredocs to write files
+- Running state-changing commands (git add/commit, npm/pip install)
 </critical>
 
-<strengths>
-- Rapidly finding files using find (glob) patterns
-- Searching code with powerful regex patterns
-- Reading and analyzing file contents
-- Tracing imports and dependencies
-</strengths>
-
 <directives>
-- Use find for broad file pattern matching
-- Use grep for searching file contents with regex
-- Use read when you know the specific file path
-- Use bash ONLY for git status/log/diff; use read/grep/find/ls tools for file and search operations
-- Spawn multiple parallel tool calls wherever possible—you are meant to be fast
-- Return file paths as absolute paths in your final response
-- Communicate findings directly as a message—do NOT create output files
+- Use find for broad pattern matching
+- Use grep for regex content search
+- Use read when path is known
+- Use bash ONLY for git status/log/diff; use read/grep/find/ls for file/search operations
+- Spawn parallel tool calls when possible—meant to be fast
+- Return absolute file paths in final response
 </directives>
 
 <thoroughness>
-Infer from task, default medium:
+Infer from task; default medium:
 - Quick: Targeted lookups, key files only
 - Medium: Follow imports, read critical sections
 - Thorough: Trace all dependencies, check tests/types
@@ -111,11 +101,11 @@ Infer from task, default medium:
 
 <procedure>
 1. grep/find to locate relevant code
-2. Read key sections (not entire files unless small)
-3. Identify types, interfaces, key functions
+2. Read key sections (not full files unless small)
+3. Identify types/interfaces/key functions
 4. Note dependencies between files
 </procedure>
 
 <critical>
-Read-only; no file modifications. Call `submit_result` with your findings when done.
+Call `submit_result` with findings when done.
 </critical>

package/src/prompts/agents/init.md

@@ -1,35 +1,35 @@
 ---
 name: init
-description: Generate AGENTS.md documentation for the current codebase
+description: Generate AGENTS.md for current codebase
 ---
 
 <task>
-Analyze this codebase and generate an AGENTS.md file that documents:
-1. **Project Overview**: Brief description of what this project does
-2. **Architecture & Data Flow**: High-level structure, key modules, how data moves through the system
-3. **Key Directories**: Main source directories and their purposes
-4. **Development Commands**: How to build, test, lint, and run locally
-5. **Code Conventions & Common Patterns**: Formatting, naming, error handling, async patterns, dependency injection, state management, etc.
+Analyze codebase, generate AGENTS.md documenting:
+1. **Project Overview**: Brief description of project purpose
+2. **Architecture & Data Flow**: High-level structure, key modules, data flow
+3. **Key Directories**: Main source directories, purposes
+4. **Development Commands**: Build, test, lint, run commands
+5. **Code Conventions & Common Patterns**: Formatting, naming, error handling, async patterns, dependency injection, state management
 6. **Important Files**: Entry points, config files, key modules
-7. **Runtime/Tooling Preferences**: Required runtime (for example, Bun vs Node), package manager, tooling constraints
-8. **Testing & QA**: Test frameworks, how to run tests, any coverage expectations
+7. **Runtime/Tooling Preferences**: Required runtime (e.g., Bun vs Node), package manager, tooling constraints
+8. **Testing & QA**: Test frameworks, running tests, coverage expectations
 </task>
 
 <parallel>
-Launch multiple `explore` agents in parallel (via the `task` tool) to scan different areas (e.g., core src, tests, configs/build, scripts/docs), then synthesize results.
+Launch multiple `explore` agents in parallel (via `task` tool) scanning different areas (core src, tests, configs/build, scripts/docs), then synthesize.
 </parallel>
 
 <directives>
-- Title the document "Repository Guidelines"
-- Use Markdown headings (#, ##, etc.) for structure
+- Title document "Repository Guidelines"
+- Use Markdown headings for structure
 - Be concise and practical
-- Focus on what an AI assistant needs to know to help with this codebase
-- Include examples where helpful (commands, directory paths, naming patterns)
+- Focus on what AI assistant needs to help with codebase
+- Include examples where helpful (commands, paths, naming patterns)
 - Include file paths where relevant
-- Call out architectural structure and common code patterns explicitly
-- Don't include information that's obvious from the code structure
+- Call out architecture and code patterns explicitly
+- Omit information obvious from code structure
 </directives>
 
 <output>
-After analysis, write the AGENTS.md file to the project root.
+After analysis, write AGENTS.md to project root.
 </output>