@oh-my-pi/pi-coding-agent 1.340.0 → 2.0.1337

package/src/core/tools/exa/render.ts

@@ -6,10 +6,10 @@
 
 import type { Component } from "@oh-my-pi/pi-tui";
 import { Text } from "@oh-my-pi/pi-tui";
-import type { Theme } from "../../../modes/interactive/theme/theme.js";
-import type { RenderResultOptions } from "../../custom-tools/types.js";
-import { logViewError } from "./logger.js";
-import type { ExaRenderDetails } from "./types.js";
+import type { Theme } from "../../../modes/interactive/theme/theme";
+import type { RenderResultOptions } from "../../custom-tools/types";
+import { logger } from "../../logger";
+import type { ExaRenderDetails } from "./types";
 
 // Tree formatting constants
 const TREE_MID = "├─";
@@ -51,7 +51,7 @@ export function renderExaResult(
 
 	// Handle error case
 	if (details?.error) {
-		logViewError("Exa render error", { error: details.error, toolName: details.toolName });
+		logger.error("Exa render error", { error: details.error, toolName: details.toolName });
 		return new Text(theme.fg("error", `Error: ${details.error}`), 0, 0);
 	}
 

package/src/core/tools/exa/researcher.ts

@@ -5,9 +5,9 @@
  */
 
 import { Type } from "@sinclair/typebox";
-import type { CustomTool } from "../../custom-tools/types.js";
-import { callExaTool, findApiKey } from "./mcp-client.js";
-import type { ExaRenderDetails } from "./types.js";
+import type { CustomTool } from "../../custom-tools/types";
+import { callExaTool, findApiKey } from "./mcp-client";
+import type { ExaRenderDetails } from "./types";
 
 const researcherStartTool: CustomTool<any, ExaRenderDetails> = {
 	name: "exa_researcher_start",

package/src/core/tools/exa/search.ts

@@ -5,8 +5,8 @@
  */
 
 import { Type } from "@sinclair/typebox";
-import type { CustomTool } from "../../custom-tools/types.js";
-import type { ExaRenderDetails } from "./types.js";
+import type { CustomTool } from "../../custom-tools/types";
+import type { ExaRenderDetails } from "./types";
 
 /** exa_search - Basic neural/keyword search */
 const exaSearchTool: CustomTool<any, ExaRenderDetails> = {
@@ -91,7 +91,7 @@ Parameters:
 					details: { error: "EXA_API_KEY not found", toolName: "exa_search" },
 				};
 			}
-			const response = await callExaTool("web_search", params, apiKey);
+			const response = await callExaTool("web_search_exa", params, apiKey);
 
 			if (isSearchResponse(response)) {
 				const formatted = formatSearchResults(response);
@@ -187,7 +187,8 @@ Similar parameters to exa_search, optimized for research depth.`,
 					details: { error: "EXA_API_KEY not found", toolName: "exa_search_deep" },
 				};
 			}
-			const response = await callExaTool("deep_search_exa", params, apiKey);
+			const args = { ...params, type: "deep" };
+			const response = await callExaTool("web_search_exa", args, apiKey);
 
 			if (isSearchResponse(response)) {
 				const formatted = formatSearchResults(response);
@@ -305,7 +306,7 @@ Parameters:
 					details: { error: "EXA_API_KEY not found", toolName: "exa_crawl" },
 				};
 			}
-			const response = await callExaTool("crawling_exa", params, apiKey);
+			const response = await callExaTool("crawling", params, apiKey);
 
 			if (isSearchResponse(response)) {
 				const formatted = formatSearchResults(response);

package/src/core/tools/exa/types.ts

@@ -23,7 +23,7 @@ export interface MCPToolWrapperConfig {
 	name: string;
 	/** Display label for UI */
 	label: string;
-	/** MCP tool name to call (e.g., "web_search") */
+	/** MCP tool name to call (e.g., "web_search_exa") */
 	mcpToolName: string;
 	/** Whether this is a websets tool (uses different MCP endpoint) */
 	isWebsetsTool?: boolean;
@@ -121,14 +121,13 @@ export interface WebsetEnrichment {
 /** Tool name mappings: MCP name -> our tool name */
 export const EXA_TOOL_MAPPINGS = {
 	// Search tools
-	web_search: "exa_search",
-	deep_search_exa: "exa_search_deep",
+	web_search_exa: "exa_search",
 	get_code_context_exa: "exa_search_code",
-	crawling_exa: "exa_crawl",
+	crawling: "exa_crawl",
 	// LinkedIn
-	linkedin_search_exa: "exa_linkedin",
+	linkedin_search: "exa_linkedin",
 	// Company
-	company_research_exa: "exa_company",
+	company_research: "exa_company",
 	// Researcher
 	deep_researcher_start: "exa_researcher_start",
 	deep_researcher_check: "exa_researcher_poll",

package/src/core/tools/exa/websets.ts

@@ -5,9 +5,9 @@
  */
 
 import { Type } from "@sinclair/typebox";
-import type { CustomTool } from "../../custom-tools/types.js";
-import { callWebsetsTool, findApiKey } from "./mcp-client.js";
-import type { ExaRenderDetails } from "./types.js";
+import type { CustomTool } from "../../custom-tools/types";
+import { callWebsetsTool, findApiKey } from "./mcp-client";
+import type { ExaRenderDetails } from "./types";
 
 /** Helper to create a websets tool with proper execute signature */
 function createWebsetTool(

package/src/core/tools/find.ts

@@ -3,9 +3,9 @@ import path from "node:path";
 import type { AgentTool } from "@oh-my-pi/pi-agent-core";
 import { Type } from "@sinclair/typebox";
 import { globSync } from "glob";
-import { ensureTool } from "../../utils/tools-manager.js";
-import { resolveToCwd } from "./path-utils.js";
-import { DEFAULT_MAX_BYTES, formatSize, type TruncationResult, truncateHead } from "./truncate.js";
+import { ensureTool } from "../../utils/tools-manager";
+import { resolveToCwd } from "./path-utils";
+import { DEFAULT_MAX_BYTES, formatSize, type TruncationResult, truncateHead } from "./truncate";
 
 const findSchema = Type.Object({
 	pattern: Type.String({

package/src/core/tools/grep.ts

@@ -3,8 +3,8 @@ import nodePath from "node:path";
 import type { AgentTool } from "@oh-my-pi/pi-agent-core";
 import { Type } from "@sinclair/typebox";
 import type { Subprocess } from "bun";
-import { ensureTool } from "../../utils/tools-manager.js";
-import { resolveToCwd } from "./path-utils.js";
+import { ensureTool } from "../../utils/tools-manager";
+import { resolveToCwd } from "./path-utils";
 import {
 	DEFAULT_MAX_BYTES,
 	formatSize,
@@ -12,7 +12,7 @@ import {
 	type TruncationResult,
 	truncateHead,
 	truncateLine,
-} from "./truncate.js";
+} from "./truncate";
 
 const grepSchema = Type.Object({
 	pattern: Type.String({ description: "Search pattern (regex or literal string)" }),
@@ -68,10 +68,11 @@ export function createGrepTool(cwd: string): AgentTool<typeof grepSchema> {
 
 Usage:
 - ALWAYS use grep for search tasks. NEVER invoke \`grep\` or \`rg\` as a bash command. The grep tool has been optimized for correct permissions and access.
+- Searches recursively by default - no need for -r flag
 - Supports full regex syntax (e.g., "log.*Error", "function\\s+\\w+")
-- Filter files with glob parameter (e.g., "*.js", "**/*.tsx") or type parameter (e.g., "js", "py", "rust")
+- Filter files with glob parameter (e.g., "*.ts", "**/*.spec.ts") or type parameter (e.g., "ts", "py", "rust") - equivalent to grep's --include
 - Output modes: "content" shows matching lines, "files_with_matches" shows only file paths (default), "count" shows match counts
-- Use task tool for open-ended searches requiring multiple rounds
+- Pagination: Use headLimit to limit results (like \`| head -N\`), offset to skip first N results
 - Pattern syntax: Uses ripgrep (not grep) - literal braces need escaping (use \`interface\\{\\}\` to find \`interface{}\` in Go code)
 - Multiline matching: By default patterns match within single lines only. For cross-line patterns like \`struct \\{[\\s\\S]*?field\`, use \`multiline: true\``,
 		parameters: grepSchema,

package/src/core/tools/index.ts

@@ -1,18 +1,32 @@
-export { type AskToolDetails, askTool, createAskTool } from "./ask.js";
-export { type BashToolDetails, bashTool, createBashTool } from "./bash.js";
-export { createEditTool, editTool } from "./edit.js";
+export { type AskToolDetails, askTool, createAskTool } from "./ask";
+export { type BashToolDetails, bashTool, createBashTool } from "./bash";
+export { createEditTool, type EditToolOptions, editTool } from "./edit";
 // Exa MCP tools (22 tools)
-export { exaTools } from "./exa/index.js";
-export type { ExaRenderDetails, ExaSearchResponse, ExaSearchResult } from "./exa/types.js";
-export { createFindTool, type FindToolDetails, findTool } from "./find.js";
-export { createGrepTool, type GrepToolDetails, grepTool } from "./grep.js";
-export { createLsTool, type LsToolDetails, lsTool } from "./ls.js";
-export { createLspTool, type LspToolDetails, lspTool } from "./lsp/index.js";
-export { createNotebookTool, type NotebookToolDetails, notebookTool } from "./notebook.js";
-export { createReadTool, type ReadToolDetails, readTool } from "./read.js";
-export { BUNDLED_AGENTS, createTaskTool, taskTool } from "./task/index.js";
-export type { TruncationResult } from "./truncate.js";
-export { createWebFetchTool, type WebFetchToolDetails, webFetchCustomTool, webFetchTool } from "./web-fetch.js";
+export { exaTools } from "./exa/index";
+export type { ExaRenderDetails, ExaSearchResponse, ExaSearchResult } from "./exa/types";
+export { createFindTool, type FindToolDetails, findTool } from "./find";
+export { createGrepTool, type GrepToolDetails, grepTool } from "./grep";
+export { createLsTool, type LsToolDetails, lsTool } from "./ls";
+export {
+	createLspTool,
+	type FileDiagnosticsResult,
+	type FileFormatResult,
+	formatFile,
+	getDiagnosticsForFile,
+	getLspStatus,
+	type LspServerStatus,
+	type LspToolDetails,
+	type LspWarmupResult,
+	lspTool,
+	warmupLspServers,
+} from "./lsp/index";
+export { createNotebookTool, type NotebookToolDetails, notebookTool } from "./notebook";
+export { createOutputTool, type OutputToolDetails, outputTool } from "./output";
+export { createReadTool, type ReadToolDetails, readTool } from "./read";
+export { createReportFindingTool, createSubmitReviewTool, reportFindingTool, submitReviewTool } from "./review";
+export { BUNDLED_AGENTS, createTaskTool, taskTool } from "./task/index";
+export type { TruncationResult } from "./truncate";
+export { createWebFetchTool, type WebFetchToolDetails, webFetchCustomTool, webFetchTool } from "./web-fetch";
 export {
 	companyWebSearchTools,
 	createWebSearchTool,
@@ -30,24 +44,26 @@ export {
 	webSearchDeepTool,
 	webSearchLinkedinTool,
 	webSearchTool,
-} from "./web-search/index.js";
-export { createWriteTool, writeTool } from "./write.js";
+} from "./web-search/index";
+export { createWriteTool, type WriteToolDetails, type WriteToolOptions, writeTool } from "./write";
 
 import type { AgentTool } from "@oh-my-pi/pi-agent-core";
-import { askTool, createAskTool } from "./ask.js";
-import { bashTool, createBashTool } from "./bash.js";
-import { checkBashInterception, checkSimpleLsInterception } from "./bash-interceptor.js";
-import { createEditTool, editTool } from "./edit.js";
-import { createFindTool, findTool } from "./find.js";
-import { createGrepTool, grepTool } from "./grep.js";
-import { createLsTool, lsTool } from "./ls.js";
-import { createLspTool, lspTool } from "./lsp/index.js";
-import { createNotebookTool, notebookTool } from "./notebook.js";
-import { createReadTool, readTool } from "./read.js";
-import { createTaskTool, taskTool } from "./task/index.js";
-import { createWebFetchTool, webFetchTool } from "./web-fetch.js";
-import { createWebSearchTool, webSearchTool } from "./web-search/index.js";
-import { createWriteTool, writeTool } from "./write.js";
+import { askTool, createAskTool } from "./ask";
+import { bashTool, createBashTool } from "./bash";
+import { checkBashInterception, checkSimpleLsInterception } from "./bash-interceptor";
+import { createEditTool, editTool } from "./edit";
+import { createFindTool, findTool } from "./find";
+import { createGrepTool, grepTool } from "./grep";
+import { createLsTool, lsTool } from "./ls";
+import { createLspTool, formatFile, getDiagnosticsForFile, lspTool } from "./lsp/index";
+import { createNotebookTool, notebookTool } from "./notebook";
+import { createOutputTool, outputTool } from "./output";
+import { createReadTool, readTool } from "./read";
+import { createReportFindingTool, createSubmitReviewTool, reportFindingTool, submitReviewTool } from "./review";
+import { createTaskTool, taskTool } from "./task/index";
+import { createWebFetchTool, webFetchTool } from "./web-fetch";
+import { createWebSearchTool, webSearchTool } from "./web-search/index";
+import { createWriteTool, writeTool } from "./write";
 
 /** Tool type (AgentTool from pi-ai) */
 export type Tool = AgentTool<any, any, any>;
@@ -57,24 +73,60 @@ export interface SessionContext {
 	getSessionFile: () => string | null;
 }
 
+/** Options for creating coding tools */
+export interface CodingToolsOptions {
+	/** Whether to fetch LSP diagnostics after write tool writes files (default: true) */
+	lspDiagnosticsOnWrite?: boolean;
+	/** Whether to fetch LSP diagnostics after edit tool edits files (default: false) */
+	lspDiagnosticsOnEdit?: boolean;
+	/** Whether to format files using LSP after write tool writes (default: true) */
+	lspFormatOnWrite?: boolean;
+	/** Whether to accept high-confidence fuzzy matches in edit tool (default: true) */
+	editFuzzyMatch?: boolean;
+	/** Set of tool names available to the agent (for cross-tool awareness) */
+	availableTools?: Set<string>;
+}
+
 // Factory function type
-type ToolFactory = (cwd: string, sessionContext?: SessionContext) => Tool;
+type ToolFactory = (cwd: string, sessionContext?: SessionContext, options?: CodingToolsOptions) => Tool;
 
 // Tool definitions: static tools and their factory functions
 const toolDefs: Record<string, { tool: Tool; create: ToolFactory }> = {
 	ask: { tool: askTool, create: createAskTool },
 	read: { tool: readTool, create: createReadTool },
 	bash: { tool: bashTool, create: createBashTool },
-	edit: { tool: editTool, create: createEditTool },
-	write: { tool: writeTool, create: createWriteTool },
+	edit: {
+		tool: editTool,
+		create: (cwd, _ctx, options) => {
+			const enableDiagnostics = options?.lspDiagnosticsOnEdit ?? false;
+			return createEditTool(cwd, {
+				fuzzyMatch: options?.editFuzzyMatch ?? true,
+				getDiagnostics: enableDiagnostics ? (absolutePath) => getDiagnosticsForFile(absolutePath, cwd) : undefined,
+			});
+		},
+	},
+	write: {
+		tool: writeTool,
+		create: (cwd, _ctx, options) => {
+			const enableFormat = options?.lspFormatOnWrite ?? true;
+			const enableDiagnostics = options?.lspDiagnosticsOnWrite ?? true;
+			return createWriteTool(cwd, {
+				formatOnWrite: enableFormat ? (absolutePath) => formatFile(absolutePath, cwd) : undefined,
+				getDiagnostics: enableDiagnostics ? (absolutePath) => getDiagnosticsForFile(absolutePath, cwd) : undefined,
+			});
+		},
+	},
 	grep: { tool: grepTool, create: createGrepTool },
 	find: { tool: findTool, create: createFindTool },
 	ls: { tool: lsTool, create: createLsTool },
 	lsp: { tool: lspTool, create: createLspTool },
 	notebook: { tool: notebookTool, create: createNotebookTool },
-	task: { tool: taskTool, create: (cwd, ctx) => createTaskTool(cwd, ctx) },
+	output: { tool: outputTool, create: (cwd, ctx) => createOutputTool(cwd, ctx) },
+	task: { tool: taskTool, create: (cwd, ctx, opts) => createTaskTool(cwd, ctx, opts) },
 	web_fetch: { tool: webFetchTool, create: createWebFetchTool },
 	web_search: { tool: webSearchTool, create: createWebSearchTool },
+	report_finding: { tool: reportFindingTool, create: createReportFindingTool },
+	submit_review: { tool: submitReviewTool, create: createSubmitReviewTool },
 };
 
 export type ToolName = keyof typeof toolDefs;
@@ -93,6 +145,7 @@ const baseCodingToolNames: ToolName[] = [
 	"ls",
 	"lsp",
 	"notebook",
+	"output",
 	"task",
 	"web_fetch",
 	"web_search",
@@ -116,10 +169,17 @@ export const allTools = Object.fromEntries(Object.entries(toolDefs).map(([name,
  * @param cwd - Working directory for tools
  * @param hasUI - Whether UI is available (includes ask tool if true)
  * @param sessionContext - Optional session context for tools that need it
+ * @param options - Options for tool configuration
  */
-export function createCodingTools(cwd: string, hasUI = false, sessionContext?: SessionContext): Tool[] {
+export function createCodingTools(
+	cwd: string,
+	hasUI = false,
+	sessionContext?: SessionContext,
+	options?: CodingToolsOptions,
+): Tool[] {
 	const names = hasUI ? [...baseCodingToolNames, ...uiToolNames] : baseCodingToolNames;
-	return names.map((name) => toolDefs[name].create(cwd, sessionContext));
+	const optionsWithTools = { ...options, availableTools: new Set(names) };
+	return names.map((name) => toolDefs[name].create(cwd, sessionContext, optionsWithTools));
 }
 
 /**
@@ -127,20 +187,34 @@ export function createCodingTools(cwd: string, hasUI = false, sessionContext?: S
  * @param cwd - Working directory for tools
  * @param hasUI - Whether UI is available (includes ask tool if true)
  * @param sessionContext - Optional session context for tools that need it
+ * @param options - Options for tool configuration
  */
-export function createReadOnlyTools(cwd: string, hasUI = false, sessionContext?: SessionContext): Tool[] {
+export function createReadOnlyTools(
+	cwd: string,
+	hasUI = false,
+	sessionContext?: SessionContext,
+	options?: CodingToolsOptions,
+): Tool[] {
 	const names = hasUI ? [...baseReadOnlyToolNames, ...uiToolNames] : baseReadOnlyToolNames;
-	return names.map((name) => toolDefs[name].create(cwd, sessionContext));
+	const optionsWithTools = { ...options, availableTools: new Set(names) };
+	return names.map((name) => toolDefs[name].create(cwd, sessionContext, optionsWithTools));
 }
 
 /**
  * Create all tools configured for a specific working directory.
  * @param cwd - Working directory for tools
  * @param sessionContext - Optional session context for tools that need it
+ * @param options - Options for tool configuration
  */
-export function createAllTools(cwd: string, sessionContext?: SessionContext): Record<ToolName, Tool> {
+export function createAllTools(
+	cwd: string,
+	sessionContext?: SessionContext,
+	options?: CodingToolsOptions,
+): Record<ToolName, Tool> {
+	const names = Object.keys(toolDefs);
+	const optionsWithTools = { ...options, availableTools: new Set(names) };
 	return Object.fromEntries(
-		Object.entries(toolDefs).map(([name, def]) => [name, def.create(cwd, sessionContext)]),
+		Object.entries(toolDefs).map(([name, def]) => [name, def.create(cwd, sessionContext, optionsWithTools)]),
 	) as Record<ToolName, Tool>;
 }
 

package/src/core/tools/ls.ts

@@ -1,9 +1,9 @@
+import { existsSync, readdirSync, statSync } from "node:fs";
+import nodePath from "node:path";
 import type { AgentTool } from "@oh-my-pi/pi-agent-core";
 import { Type } from "@sinclair/typebox";
-import { existsSync, readdirSync, statSync } from "fs";
-import nodePath from "path";
-import { resolveToCwd } from "./path-utils.js";
-import { DEFAULT_MAX_BYTES, formatSize, type TruncationResult, truncateHead } from "./truncate.js";
+import { resolveToCwd } from "./path-utils";
+import { DEFAULT_MAX_BYTES, formatSize, type TruncationResult, truncateHead } from "./truncate";
 
 const lsSchema = Type.Object({
 	path: Type.Optional(Type.String({ description: "Directory to list (default: current directory)" })),