@oh-my-pi/pi-agent-core 18.4.9 → 18.4.11

package/CHANGELOG.md

@@ -2,6 +2,19 @@
 
 ## [Unreleased]
 
+## [18.4.11] - 2026-10-02
+
+### Fixed
+
+- Fixed lenient argument validation for tools such as `yield`: malformed tool-call JSON is now reported to the model instead of causing the tool to run with empty arguments.
+
+## [18.4.10] - 2026-10-02
+
+### Fixed
+
+- `streamProxy` no longer finalizes a cut-off tool-call argument buffer into an executable auto-closed preview; such a call gets the parse-error arguments, so the tool is not run and the model receives the parse error ([#13868](https://github.com/can1357/oh-my-pi/pull/13868) by [@alphastorm](https://github.com/alphastorm))
+- OpenAI remote compaction no longer sends stored native tool calls whose names are blank, longer than 128 characters, or contain whitespace or control characters. The outputs that answer those calls are dropped as well ([#13985](https://github.com/can1357/oh-my-pi/pull/13985) by [@Xytronix](https://github.com/Xytronix)).
+
 ## [18.4.6] - 2026-10-01
 
 ### Added

package/dist/types/types.d.ts

@@ -1007,7 +1007,7 @@ export interface AgentTool<TParameters extends TSchema = TSchema, TDetails = any
      * before ordinary dispatch commits its result.
      */
     speculation?: ToolSpeculationPolicy;
-    /** If true, argument validation errors are non-fatal: raw args are passed to execute() instead of returning an error to the LLM. */
+    /** If true, schema validation errors are non-fatal: raw args are passed to execute() instead of returning an error to the LLM. Malformed argument JSON still returns the parse error. */
     lenientArgValidation?: boolean;
     /**
      * Whether the agent loop may abort this tool mid-execution — or skip it

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-agent-core",
-	"version": "18.4.9",
+	"version": "18.4.11",
 	"description": "General-purpose agent with transport abstraction, state management, and attachment support",
 	"homepage": "https://omp.sh",
 	"author": {
@@ -38,16 +38,16 @@
 		"fmt": "oxfmt --no-error-on-unmatched-pattern 'src/**/*.{ts,tsx}' '{test,bench,examples,scripts}/**/*.ts' '*.ts'"
 	},
 	"dependencies": {
-		"@oh-my-pi/pi-ai": "18.4.9",
-		"@oh-my-pi/pi-catalog": "18.4.9",
-		"@oh-my-pi/pi-natives": "18.4.9",
-		"@oh-my-pi/pi-utils": "18.4.9",
-		"@oh-my-pi/pi-wire": "18.4.9",
-		"@oh-my-pi/snapcompact": "18.4.9",
+		"@oh-my-pi/pi-ai": "18.4.11",
+		"@oh-my-pi/pi-catalog": "18.4.11",
+		"@oh-my-pi/pi-natives": "18.4.11",
+		"@oh-my-pi/pi-utils": "18.4.11",
+		"@oh-my-pi/pi-wire": "18.4.11",
+		"@oh-my-pi/snapcompact": "18.4.11",
 		"@opentelemetry/api": "^1.9.1"
 	},
 	"devDependencies": {
-		"@oh-my-pi/omptype": "18.4.9",
+		"@oh-my-pi/omptype": "18.4.11",
 		"@opentelemetry/context-async-hooks": "^2.9.0",
 		"@opentelemetry/sdk-trace-base": "^2.9.0",
 		"@types/bun": "^1.3.14"

package/src/agent-loop.ts

@@ -2907,13 +2907,14 @@ async function prepareToolCallDispatch(
 				}
 				return validateToolArguments(tool, { ...toolCall, arguments: args });
 			} catch (validationError) {
-				if (tool?.lenientArgValidation) {
+				// Lenience covers schema mismatches; a parse failure has no args to hand over.
+				const parseFailed = "__parseError" in args;
+				if (tool?.lenientArgValidation && !parseFailed) {
 					const fallback = { ...args };
-					delete fallback.__parseError;
 					delete fallback.__rawJson;
 					return fallback;
 				}
-				entry.args = "__parseError" in args ? { __parseError: args.__parseError } : args;
+				entry.args = parseFailed ? { __parseError: args.__parseError } : args;
 				entry.validationErrorMessage =
 					validationError instanceof Error ? validationError.message : String(validationError);
 				return undefined;

package/src/compaction/openai.ts

@@ -36,6 +36,7 @@ import type {
 	ProviderSessionState,
 } from "@oh-my-pi/pi-ai/types";
 import {
+	dropMalformedOpenAIResponsesToolCalls,
 	getOpenAIResponsesHistoryItems,
 	getOpenAIResponsesHistoryPayload,
 	normalizeResponsesToolCallId,
@@ -537,7 +538,10 @@ export function buildOpenAiNativeHistory(
 						}
 					}
 				}
-				const historyItems = adaptComputerHistoryForCompaction(rawHistoryItems, model.supportsComputerUse === true);
+				const historyItems = adaptComputerHistoryForCompaction(
+					dropMalformedOpenAIResponsesToolCalls(rawHistoryItems),
+					model.supportsComputerUse === true,
+				);
 				input.push(...historyItems);
 				addOpenAiCallIds(historyItems, knownCallIds, customCallIds, computerCallIds);
 				msgIndex++;
@@ -589,7 +593,7 @@ export function buildOpenAiNativeHistory(
 					}
 				}
 				const historyItems = adaptComputerHistoryForCompaction(
-					providerPayload.items,
+					dropMalformedOpenAIResponsesToolCalls(providerPayload.items),
 					model.supportsComputerUse === true,
 				);
 				if (providerPayload.dt) {

package/src/proxy.ts

@@ -20,7 +20,8 @@ import {
 	type StreamingPartialJsonCarrier,
 	setStreamingPartialJson,
 } from "@oh-my-pi/pi-ai/utils/block-symbols";
-import { parseStreamingJson, parseStreamingJsonThrottled, readSseJson } from "@oh-my-pi/pi-utils";
+import { parseToolCallArguments } from "@oh-my-pi/pi-ai/utils/tool-call-arguments";
+import { parseStreamingJsonThrottled, readSseJson } from "@oh-my-pi/pi-utils";
 
 // Event stream adapter for proxy SSE events
 export class ProxyMessageEventStream extends EventStream<AssistantMessageEvent, AssistantMessage> {
@@ -378,7 +379,7 @@ function processProxyEvent(
 				// throttle may have skipped trailing deltas, so the last
 				// parsed arguments can lag the accumulated buffer.
 				const acc = partialJsonByIndex.get(proxyEvent.contentIndex);
-				if (acc !== undefined && acc.length > 0) content.arguments = parseStreamingJson(acc) || {};
+				if (acc !== undefined && acc.length > 0) content.arguments = parseToolCallArguments(acc) || {};
 				partialJsonByIndex.delete(proxyEvent.contentIndex);
 				parsedLenByIndex.delete(proxyEvent.contentIndex);
 				clearStreamingPartialJson(content);
@@ -427,6 +428,6 @@ function finalizeBufferedArguments(partial: AssistantMessage, partialJsonByIndex
 	for (const [index, acc] of partialJsonByIndex) {
 		if (acc.length === 0) continue;
 		const content = partial.content[index];
-		if (content?.type === "toolCall") content.arguments = parseStreamingJson(acc) || {};
+		if (content?.type === "toolCall") content.arguments = parseToolCallArguments(acc) || {};
 	}
 }

package/src/speculative-execution.ts

@@ -714,12 +714,12 @@ export class SpeculativeOperationCoordinator {
 		try {
 			validatedArgs = validateToolArguments(tool, toolCall);
 		} catch {
-			if (!tool.lenientArgValidation) {
+			// Lenience covers schema mismatches; a parse failure has no args to hand over.
+			if (!tool.lenientArgValidation || "__parseError" in toolCall.arguments) {
 				this.ineligible(toolCall, "tool arguments are not valid", source, parentToolCallId);
 				return undefined;
 			}
-			validatedArgs = { ...(toolCall.arguments as Record<string, unknown>) };
-			delete validatedArgs.__parseError;
+			validatedArgs = { ...toolCall.arguments };
 			delete validatedArgs.__rawJson;
 		}
 		let executionArgs: Record<string, unknown>;

package/src/types.ts

@@ -1143,7 +1143,7 @@ export interface AgentTool<
 	 * before ordinary dispatch commits its result.
 	 */
 	speculation?: ToolSpeculationPolicy;
-	/** If true, argument validation errors are non-fatal: raw args are passed to execute() instead of returning an error to the LLM. */
+	/** If true, schema validation errors are non-fatal: raw args are passed to execute() instead of returning an error to the LLM. Malformed argument JSON still returns the parse error. */
 	lenientArgValidation?: boolean;
 	/**
 	 * Whether the agent loop may abort this tool mid-execution — or skip it