@oh-my-pi/omp-stats 18.3.5 → 18.4.0

package/src/client/routes/ErrorsRoute.tsx

@@ -1,118 +1,421 @@
-import { useMemo } from "react";
+import { ArrowUpRight, X } from "lucide-react";
+import { useMemo, useState } from "react";
 import { getRecentErrors } from "../api";
-import { formatInteger, formatMessageCost, formatRelativeTime } from "../data/formatters";
-import { useResource } from "../data/useResource";
+import { BarList } from "../charts";
+import { modelKey } from "../data/colors";
+import {
+	formatCompact,
+	formatFolder,
+	formatInteger,
+	formatMessageCost,
+	formatRelativeTime,
+	formatTimestamp,
+} from "../data/formatters";
+import { useQuery } from "../data/query";
+import { rangeMeta } from "../data/range";
+import { type ErrorGroupView, errorSignature, groupErrorsBySignature } from "../data/view-models";
 import type { MessageStats, TimeRange } from "../types";
-import { AsyncBoundary, DataTable, Panel, StatusPill } from "../ui";
+import {
+	Card,
+	type Column,
+	EmptyState,
+	LabelCell,
+	MeterCell,
+	PageHeader,
+	QueryView,
+	SearchInput,
+	Skeleton,
+	Stat,
+	StatGrid,
+	Table,
+	TableSkeleton,
+} from "../ui";
+import "./errors.css";
 
 export interface ErrorsRouteProps {
 	active: boolean;
 	range: TimeRange;
-	refreshTrigger: number;
 	onRequestClick: (id: number) => void;
 }
 
-export function ErrorsRoute({ active, range, refreshTrigger, onRequestClick }: ErrorsRouteProps) {
-	const {
-		data: recentErrors,
-		error,
-		loading,
-	} = useResource(["recent-errors-dense", range, refreshTrigger], signal => getRecentErrors(range, 50, signal), {
-		pollMs: 30000,
-		enabled: active,
-	});
-
-	const columns = useMemo(
-		() => [
-			{
-				key: "model",
-				header: "Model",
-				render: (item: MessageStats) => (
-					<div>
-						<div className="stats-font-medium stats-text-primary">{item.model}</div>
-						<div className="stats-text-xs stats-text-muted">{item.provider}</div>
-					</div>
-				),
-			},
-			{
-				key: "timestamp",
-				header: "Time",
-				render: (item: MessageStats) => formatRelativeTime(item.timestamp),
-			},
-			{
-				key: "errorMessage",
-				header: "Error Message",
-				render: (item: MessageStats) => (
-					<div
-						className="stats-text-xs stats-text-danger stats-truncate stats-max-w-md stats-font-mono"
-						title={item.errorMessage || ""}
+/** How many of the newest failures to load; "Load more" steps through these. */
+const LOAD_STEPS = [50, 200, 1_000] as const;
+
+export function ErrorsRoute({ active, range, onRequestClick }: ErrorsRouteProps) {
+	const [step, setStep] = useState(0);
+	const limit = LOAD_STEPS[step];
+	const errors = useQuery(["errors", range, limit], () => getRecentErrors(range, limit), { enabled: active });
+	const [selectedSignature, setSelectedSignature] = useState<string | null>(null);
+	const [selectedModel, setSelectedModel] = useState<string | null>(null);
+	const [search, setSearch] = useState("");
+	const meta = rangeMeta(range);
+
+	const view = useMemo(() => {
+		const rows = (errors.data ?? []).map(row => ({ row, signature: errorSignature(row.errorMessage) }));
+		const groups = groupErrorsBySignature(errors.data ?? []);
+		const byModel = new Map<string, { model: string; provider: string; count: number }>();
+		for (const { row } of rows) {
+			const key = modelKey(row.model, row.provider);
+			const entry = byModel.get(key);
+			if (entry) entry.count++;
+			else byModel.set(key, { model: row.model, provider: row.provider, count: 1 });
+		}
+		const models = [...byModel.entries()]
+			.map(([key, entry]) => ({ key, ...entry }))
+			.sort((a, b) => b.count - a.count || a.model.localeCompare(b.model));
+		const newest = rows.reduce<MessageStats | null>(
+			(best, { row }) => (!best || row.timestamp > best.timestamp ? row : best),
+			null,
+		);
+		return { rows, groups, models, newest };
+	}, [errors.data]);
+
+	// Selections that no longer exist in this range's data are ignored.
+	const signature = view.groups.some(g => g.signature === selectedSignature) ? selectedSignature : null;
+	const model = view.models.some(m => m.key === selectedModel) ? selectedModel : null;
+
+	const filtered = useMemo(() => {
+		const needle = search.trim().toLowerCase();
+		return view.rows
+			.filter(
+				entry =>
+					(signature === null || entry.signature === signature) &&
+					(model === null || modelKey(entry.row.model, entry.row.provider) === model) &&
+					(needle === "" ||
+						entry.row.model.toLowerCase().includes(needle) ||
+						entry.row.provider.toLowerCase().includes(needle) ||
+						entry.row.folder.toLowerCase().includes(needle) ||
+						(entry.row.errorMessage ?? "").toLowerCase().includes(needle)),
+			)
+			.map(entry => entry.row);
+	}, [view.rows, signature, model, search]);
+
+	const loaded = errors.data?.length ?? 0;
+	// The server applies the range; fewer rows than the limit means we have them all.
+	const complete = !errors.stale && loaded < limit;
+	const nextStep = step + 1 < LOAD_STEPS.length ? LOAD_STEPS[step + 1] : null;
+	const footer =
+		errors.data !== null && !complete ? (
+			<>
+				<span>
+					Showing the latest {formatInteger(loaded)} failures in {meta.windowLabel}; older ones are not loaded.
+				</span>
+				{nextStep !== null && (
+					<button
+						type="button"
+						className="btn"
+						data-size="sm"
+						disabled={errors.refreshing}
+						onClick={() => setStep(step + 1)}
 					>
-						{item.errorMessage || "Unknown error"}
+						{errors.refreshing && errors.stale ? "Loading…" : `Load latest ${formatInteger(nextStep)}`}
+					</button>
+				)}
+			</>
+		) : undefined;
+
+	const maxGroup = view.groups[0]?.count ?? 0;
+	const groupColumns = useMemo(() => buildGroupColumns(maxGroup), [maxGroup]);
+	const selectedModelInfo = view.models.find(m => m.key === model);
+
+	return (
+		<div className="page">
+			<PageHeader
+				title="Errors"
+				description={`Failed model requests in ${meta.windowLabel}, grouped by error signature. Open a failure for its full payload.`}
+			/>
+
+			<QueryView query={errors} skeleton={<Skeleton height={96} style={{ borderRadius: 12 }} />}>
+				{() => (
+					<div data-stale={errors.stale}>
+						<StatGrid min={170}>
+							<Stat
+								label="Failures"
+								value={formatInteger(loaded)}
+								hint={complete ? `in ${meta.windowLabel}` : `latest ${formatInteger(loaded)} loaded`}
+							/>
+							<Stat
+								label="Signatures"
+								title="Distinct error messages after normalizing ids and numbers"
+								value={formatInteger(view.groups.length)}
+								hint={view.groups[0] ? `top: ${formatInteger(view.groups[0].count)} failures` : undefined}
+							/>
+							<Stat
+								label="Affected models"
+								value={formatInteger(view.models.length)}
+								hint={view.models[0]?.model}
+							/>
+							<Stat
+								label="Last failure"
+								value={view.newest ? formatRelativeTime(view.newest.timestamp) : "–"}
+								hint={view.newest ? formatTimestamp(view.newest.timestamp) : `none in ${meta.windowLabel}`}
+							/>
+						</StatGrid>
 					</div>
-				),
-			},
-			{
-				key: "tokens",
-				header: "Tokens",
-				numeric: true,
-				render: (item: MessageStats) => formatInteger(item.usage.totalTokens),
-			},
-			{
-				key: "cost",
-				header: "API-equivalent estimate",
-				numeric: true,
-				render: (item: MessageStats) => formatMessageCost(item, 4),
-			},
-		],
-		[],
-	);
+				)}
+			</QueryView>
 
-	const renderMobileCard = (item: MessageStats, onClick?: () => void) => (
-		<div className="stats-mobile-card stats-border-danger" onClick={onClick}>
-			<div className="stats-mobile-card-header">
-				<div>
-					<div className="stats-font-semibold stats-text-primary">{item.model}</div>
-					<div className="stats-text-xs stats-text-muted">{item.provider}</div>
-				</div>
-				<StatusPill variant="danger">Failed</StatusPill>
-			</div>
-			<div className="stats-mobile-card-grid">
-				<div>
-					<div className="stats-mobile-card-label">Time</div>
-					<div className="stats-mobile-card-value">{formatRelativeTime(item.timestamp)}</div>
-				</div>
-				<div>
-					<div className="stats-mobile-card-label">API-equivalent estimate</div>
-					<div className="stats-mobile-card-value">{formatMessageCost(item, 4)}</div>
-				</div>
-				<div>
-					<div className="stats-mobile-card-label">Tokens</div>
-					<div className="stats-mobile-card-value">{formatInteger(item.usage.totalTokens)}</div>
-				</div>
+			<div className="grid grid-main-side">
+				<Card
+					index={1}
+					title="Error signatures"
+					description="Same message with ids and counters normalized. Select one to filter the failures below."
+					flush
+					stale={errors.stale}
+				>
+					<QueryView
+						query={errors}
+						skeleton={<TableSkeleton rows={8} />}
+						isEmpty={rows => rows.length === 0}
+						empty={
+							<EmptyState
+								title={`No failures in ${meta.windowLabel}`}
+								hint="Every request succeeded or was aborted."
+							/>
+						}
+					>
+						{() => (
+							<Table
+								rows={view.groups}
+								rowKey={group => group.signature}
+								columns={groupColumns}
+								onRowClick={group =>
+									setSelectedSignature(signature === group.signature ? null : group.signature)
+								}
+								selectedKey={signature}
+								expanded={group =>
+									group.signature === signature ? (
+										<SignatureDetail group={group} onRequestClick={onRequestClick} />
+									) : null
+								}
+								limit={12}
+							/>
+						)}
+					</QueryView>
+				</Card>
+
+				<Card
+					index={2}
+					title="By model"
+					description="Failures per model. Select one to filter."
+					stale={errors.stale}
+				>
+					<QueryView
+						query={errors}
+						skeleton={<Skeleton height={180} />}
+						isEmpty={rows => rows.length === 0}
+						empty={<EmptyState title="No affected models" />}
+					>
+						{() => (
+							<BarList
+								items={view.models.slice(0, 12).map(m => ({
+									key: m.key,
+									label: (
+										<span className="row" style={{ gap: 6, minWidth: 0 }}>
+											<span className="mono truncate">{m.model}</span>
+											<span className="dim truncate">{m.provider}</span>
+										</span>
+									),
+									value: m.count,
+									color: m.key === model ? "var(--bad)" : "color-mix(in srgb, var(--bad) 45%, transparent)",
+								}))}
+								onSelect={key => setSelectedModel(model === key ? null : key)}
+							/>
+						)}
+					</QueryView>
+				</Card>
 			</div>
-			{item.errorMessage && <div className="stats-mobile-card-error mt-2 stats-font-mono">{item.errorMessage}</div>}
+
+			<Card
+				index={3}
+				title="Failures"
+				description={
+					errors.data === null
+						? "Loading failures…"
+						: `${formatInteger(filtered.length)} of ${formatInteger(loaded)} failures, newest first`
+				}
+				actions={
+					<>
+						{signature !== null && (
+							<button
+								type="button"
+								className="btn errors-filter"
+								data-size="sm"
+								onClick={() => setSelectedSignature(null)}
+								title={signature}
+							>
+								<span className="mono truncate">{signature}</span>
+								<X size={12} />
+							</button>
+						)}
+						{selectedModelInfo && (
+							<button
+								type="button"
+								className="btn errors-filter"
+								data-size="sm"
+								onClick={() => setSelectedModel(null)}
+							>
+								<span className="mono truncate">{selectedModelInfo.model}</span>
+								<X size={12} />
+							</button>
+						)}
+						<SearchInput value={search} onChange={setSearch} placeholder="Message, model or project" />
+					</>
+				}
+				flush
+				stale={errors.stale}
+				footer={footer}
+			>
+				<QueryView
+					query={errors}
+					skeleton={<TableSkeleton rows={10} />}
+					isEmpty={rows => rows.length === 0}
+					empty={<EmptyState title={`No failures in ${meta.windowLabel}`} />}
+				>
+					{() => (
+						<Table
+							rows={filtered}
+							rowKey={row => row.id ?? `${row.sessionFile}:${row.entryId}`}
+							onRowClick={row => row.id !== undefined && onRequestClick(row.id)}
+							columns={FAILURE_COLUMNS}
+							initialSort={{ key: "time", dir: "desc" }}
+							limit={50}
+							dense
+							empty={<EmptyState title="No failures match" hint="Clear the search or the selected filters." />}
+						/>
+					)}
+				</QueryView>
+			</Card>
 		</div>
 	);
+}
 
+function buildGroupColumns(maxCount: number): Column<ErrorGroupView>[] {
+	return [
+		{
+			key: "signature",
+			header: "Signature",
+			wrap: true,
+			sort: group => group.signature,
+			render: group => (
+				<span className="errors-signature" title={group.latest.errorMessage ?? undefined}>
+					{group.signature}
+				</span>
+			),
+		},
+		{
+			key: "models",
+			header: "Models",
+			sort: group => group.models.length,
+			render: group => (
+				<LabelCell
+					primary={<span className="mono">{group.models[0]?.model}</span>}
+					secondary={group.models.length > 1 ? `+${group.models.length - 1} more` : group.models[0]?.provider}
+				/>
+			),
+		},
+		{
+			key: "last",
+			header: "Last seen",
+			sort: group => group.lastSeen,
+			render: group => (
+				<span className="muted" title={formatTimestamp(group.lastSeen)}>
+					{formatRelativeTime(group.lastSeen)}
+				</span>
+			),
+		},
+		{
+			key: "count",
+			header: "Failures",
+			align: "right",
+			width: 120,
+			sort: group => group.count,
+			render: group => (
+				<MeterCell value={group.count} max={maxCount} display={formatInteger(group.count)} color="var(--bad)" />
+			),
+		},
+	];
+}
+
+function SignatureDetail({ group, onRequestClick }: { group: ErrorGroupView; onRequestClick: (id: number) => void }) {
+	const latestId = group.latest.id;
 	return (
-		<div className="stats-route-container">
-			<Panel title="Recent Errors" subtitle="Up to 50 most recent failed requests in the stats database">
-				<AsyncBoundary
-					loading={loading}
-					error={error}
-					data={recentErrors}
-					emptyText="No recent failures in the local stats database"
-				>
-					<DataTable
-						columns={columns}
-						data={recentErrors || []}
-						keyExtractor={item => item.id || `${item.sessionFile}-${item.entryId}`}
-						onRowClick={item => item.id && onRequestClick(item.id)}
-						renderMobileCard={renderMobileCard}
-						emptyText="No recent failures in the local stats database"
-					/>
-				</AsyncBoundary>
-			</Panel>
+		<div className="errors-detail">
+			<pre className="code-block errors-detail-message">{group.latest.errorMessage ?? "Unknown error"}</pre>
+			<div className="errors-detail-meta">
+				<span className="muted">
+					{formatInteger(group.count)} failures · first {formatTimestamp(group.firstSeen)} · last{" "}
+					{formatTimestamp(group.lastSeen)}
+				</span>
+				{latestId !== undefined && (
+					<button type="button" className="btn" data-size="sm" onClick={() => onRequestClick(latestId)}>
+						Open latest <ArrowUpRight size={13} />
+					</button>
+				)}
+			</div>
+			<div className="errors-detail-models">
+				{group.models.map(m => (
+					<span key={modelKey(m.model, m.provider)} className="badge" data-mono="true">
+						{m.model} <span className="dim">{m.provider}</span>{" "}
+						<span className="num">{formatCompact(m.count)}</span>
+					</span>
+				))}
+			</div>
 		</div>
 	);
 }
+
+const FAILURE_COLUMNS: readonly Column<MessageStats>[] = [
+	{
+		key: "time",
+		header: "When",
+		width: 120,
+		sort: row => row.timestamp,
+		render: row => (
+			<span className="muted" title={formatTimestamp(row.timestamp)}>
+				{formatRelativeTime(row.timestamp)}
+			</span>
+		),
+	},
+	{
+		key: "model",
+		header: "Model",
+		sort: row => row.model,
+		render: row => <LabelCell primary={<span className="mono">{row.model}</span>} secondary={row.provider} />,
+	},
+	{
+		key: "error",
+		header: "Error",
+		sort: row => row.errorMessage ?? "",
+		render: row => (
+			<span className="errors-message" title={row.errorMessage ?? undefined}>
+				{row.errorMessage ?? "Unknown error"}
+			</span>
+		),
+	},
+	{
+		key: "project",
+		header: "Project",
+		sort: row => row.folder,
+		render: row => (
+			<span className="mono muted" title={row.folder}>
+				{formatFolder(row.folder)}
+			</span>
+		),
+	},
+	{
+		key: "tokens",
+		header: "Tokens",
+		align: "right",
+		sort: row => row.usage.totalTokens,
+		render: row => <span className="num">{formatInteger(row.usage.totalTokens)}</span>,
+	},
+	{
+		key: "cost",
+		header: "Cost",
+		title: "API-equivalent estimate",
+		align: "right",
+		sort: row => row.usage.cost.total,
+		render: row => <span className="num">{formatMessageCost(row, 4)}</span>,
+	},
+];