@oh-my-pi/cli 0.1.0 → 0.3.0

package/CHECK.md

@@ -1,352 +0,0 @@
-# Implementation Review Checklist
-
-Review the oh-my-pi implementation against these requirements. For each item, verify it works correctly and check the listed edge cases.
-
----
-
-## 1. Install Command (`omp install`)
-
-### Core functionality
-- [ ] `omp install pkg-name` installs from npm
-- [ ] `omp install pkg@version` respects version specifier
-- [ ] `omp install @scope/pkg` handles scoped packages
-- [ ] `omp install ./path` copies local directory
-- [ ] `omp install ~/path` expands home directory
-- [ ] `omp install` (no args) installs from plugins.json
-- [ ] Creates symlinks for each `omp.install` entry
-
-### Edge cases
-- [ ] Package not found on npm → clear error message
-- [ ] Invalid version specifier → graceful failure
-- [ ] Local path doesn't exist → error before any changes
-- [ ] `omp.install` has missing source file → skip with warning, continue others
-- [ ] Circular dependencies between plugins → handled without infinite loop
-- [ ] Nested dependencies with omp field → all get symlinked
-- [ ] Package has no `omp` field → installs but no symlinks (warning?)
-- [ ] Network failure mid-install → rollback partial install
-- [ ] Disk full → appropriate error
-- [ ] Symlink target directory doesn't exist → creates parent dirs
-- [ ] `omp install` with empty plugins.json → helpful message
-
-### Flags
-- [ ] `--global` installs to ~/.pi/plugins/
-- [ ] `--save` adds to plugins.json
-- [ ] `--save-dev` adds to devDependencies
-- [ ] `--force` overwrites conflicts without prompting
-- [ ] `--json` outputs JSON format
-
----
-
-## 2. Conflict Detection
-
-### Core functionality
-- [ ] Detects when two plugins install to same destination
-- [ ] Interactive prompt offers choices: plugin1, plugin2, abort
-- [ ] User can select which plugin wins
-- [ ] Abort rolls back the install
-
-### Edge cases
-- [ ] Three+ plugins with same destination → all listed
-- [ ] Conflict with already-installed plugin → prompt before npm install
-- [ ] Conflict within same plugin's install array (duplicate dest) → error
-- [ ] `--force` skips all prompts → overwrites
-- [ ] Non-interactive terminal (CI) → fail or use --force
-
----
-
-## 3. Uninstall Command (`omp uninstall`)
-
-### Core functionality
-- [ ] `omp uninstall pkg` removes package
-- [ ] Removes all symlinks from `omp.install`
-- [ ] Removes from package.json/plugins.json
-
-### Edge cases
-- [ ] Plugin not installed → clear error
-- [ ] Symlink already deleted manually → graceful (ENOENT ignored)
-- [ ] Symlink replaced by real file → remove anyway or warn?
-- [ ] Plugin has dependencies that other plugins also use → don't break them
-- [ ] Partial uninstall (some symlinks fail) → report what failed
-
----
-
-## 4. Update Command (`omp update`)
-
-### Core functionality
-- [ ] `omp update` updates all plugins
-- [ ] `omp update pkg` updates specific plugin
-- [ ] Respects semver ranges from plugins.json
-- [ ] Re-creates symlinks after update
-
-### Edge cases
-- [ ] Package already at latest → no-op with message
-- [ ] Major version available but range is `^` → doesn't update
-- [ ] Package removed from npm → error handling
-- [ ] Update changes `omp.install` entries → old symlinks removed, new created
-- [ ] Linked (dev) plugins → skipped with message
-
----
-
-## 5. List Command (`omp list`)
-
-### Core functionality
-- [ ] Shows all installed plugins
-- [ ] Shows version for each
-- [ ] Shows (linked) badge for dev plugins
-
-### Edge cases
-- [ ] No plugins installed → helpful message
-- [ ] Plugin in plugins.json but not in node_modules → show as broken
-- [ ] Corrupt package.json → graceful error
-- [ ] `--json` output is valid JSON
-
----
-
-## 6. Link Command (`omp link`)
-
-### Core functionality
-- [ ] `omp link ./path` creates symlink to source directory
-- [ ] Marks as linked in manifest
-- [ ] Creates symlinks from `omp.install`
-
-### Edge cases
-- [ ] Path doesn't exist → error
-- [ ] Path has no package.json → uses directory name, creates minimal
-- [ ] Path has omp.json (legacy) → converts to package.json format
-- [ ] Already linked → re-link or error?
-- [ ] `-n, --name` overrides plugin name
-- [ ] Linked plugin updated externally → symlinks still work
-
----
-
-## 7. Init Command (`omp init`)
-
-### Core functionality
-- [ ] Creates `.pi/plugins.json` in current directory
-- [ ] Correct initial structure: `{ "plugins": {}, "disabled": [] }`
-
-### Edge cases
-- [ ] File already exists → error unless `--force`
-- [ ] `.pi/` directory doesn't exist → creates it
-- [ ] No write permission → clear error
-
----
-
-## 8. Search Command (`omp search`)
-
-### Core functionality
-- [ ] `omp search query` searches npm for `keywords:omp-plugin`
-- [ ] Shows name, version, description
-
-### Edge cases
-- [ ] No results → helpful message
-- [ ] npm registry unavailable → timeout with error
-- [ ] Very long description → truncated
-- [ ] `--limit` respected
-- [ ] Special characters in query → properly escaped
-
----
-
-## 9. Info Command (`omp info`)
-
-### Core functionality
-- [ ] `omp info pkg` shows package details
-- [ ] Shows: name, version, description, dependencies, omp.install entries
-
-### Edge cases
-- [ ] Package not found → clear error
-- [ ] Package exists but no omp field → show warning
-- [ ] `--versions` shows available versions
-- [ ] `--json` valid JSON output
-
----
-
-## 10. Outdated Command (`omp outdated`)
-
-### Core functionality
-- [ ] Lists plugins with newer versions available
-- [ ] Shows current, wanted, latest columns
-
-### Edge cases
-- [ ] All up to date → "All plugins up to date"
-- [ ] npm outdated returns exit code 1 → still parses output
-- [ ] Plugin not on npm anymore → shown as error row
-- [ ] Linked plugins → excluded from check
-
----
-
-## 11. Doctor Command (`omp doctor`)
-
-### Core functionality
-- [ ] Checks for broken symlinks
-- [ ] Checks for conflicts
-- [ ] Reports missing dependencies
-
-### Edge cases
-- [ ] No issues → "All good"
-- [ ] Symlink target deleted → reported as broken
-- [ ] Symlink replaced by real file → reported
-- [ ] `--fix` repairs broken symlinks
-- [ ] `--fix` can't fix conflict → reports
-
----
-
-## 12. Create Command (`omp create`)
-
-### Core functionality
-- [ ] `omp create my-plugin` scaffolds new plugin
-- [ ] Creates package.json with omp field
-- [ ] Creates directory structure
-
-### Edge cases
-- [ ] Directory already exists → error
-- [ ] Invalid plugin name (spaces, special chars) → normalized or error
-- [ ] `--description` sets description
-- [ ] `--author` sets author
-
----
-
-## 13. Why Command (`omp why`)
-
-### Core functionality
-- [ ] `omp why agent/themes/dark.json` shows which plugin installed it
-- [ ] Shows plugin name and source path
-
-### Edge cases
-- [ ] File not installed by any plugin → "Not installed by omp"
-- [ ] File is manually created (not symlink) → detect and report
-- [ ] Relative vs absolute path → both work
-- [ ] File doesn't exist → appropriate error
-
----
-
-## 14. Enable/Disable Commands
-
-### Core functionality
-- [ ] `omp disable pkg` removes symlinks, keeps in node_modules
-- [ ] `omp enable pkg` restores symlinks
-- [ ] Disabled list persisted
-
-### Edge cases
-- [ ] Disable already-disabled → no-op or error
-- [ ] Enable not-disabled → no-op
-- [ ] Enable not-installed → error
-- [ ] Symlinks manually restored → enable detects and handles
-
----
-
-## 15. Project-Local vs Global
-
-### Core functionality
-- [ ] Default is global (~/.pi/)
-- [ ] With `.pi/plugins.json` in cwd, uses project-local
-- [ ] `--global` forces global even with local config
-- [ ] Symlinks go to correct location per scope
-
-### Edge cases
-- [ ] Nested projects (parent and child have .pi/) → uses closest
-- [ ] Project-local install then run from parent dir → correct behavior
-- [ ] Same plugin installed globally and locally → local takes precedence?
-
----
-
-## 16. Migration (`omp migrate`)
-
-### Core functionality
-- [ ] Detects legacy manifest.json
-- [ ] Converts to package.json format
-- [ ] Preserves all plugin info
-- [ ] Re-creates symlinks
-
-### Edge cases
-- [ ] No legacy manifest → "Nothing to migrate"
-- [ ] Partial migration (some plugins fail) → reports
-- [ ] Legacy plugin source gone → reports but continues
-- [ ] Backup of manifest.json created
-
----
-
-## 17. Lock File
-
-### Core functionality
-- [ ] package-lock.json generated for global
-- [ ] plugins-lock.json generated for project-local
-- [ ] Reproducible installs with lock file
-
-### Edge cases
-- [ ] Lock file corrupt → regenerate with warning
-- [ ] Lock file deleted → works but warns about reproducibility
-
----
-
-## 18. Symlinks Module
-
-### Core functionality
-- [ ] Creates symlinks correctly
-- [ ] Removes symlinks on uninstall
-- [ ] Validates symlink health
-
-### Edge cases
-- [ ] **BUG CHECK: Project-local uses correct base path (.pi/ not ~/.pi/)**
-- [ ] Destination is a directory → symlink whole directory
-- [ ] Destination is a file → symlink file
-- [ ] Parent directories created recursively
-- [ ] Windows compatibility (if applicable) → use junctions or requires admin
-
----
-
-## 19. npm Module
-
-### Core functionality
-- [ ] npm install works with prefix
-- [ ] npm info fetches package data
-- [ ] npm search returns results
-- [ ] npm outdated parsed correctly
-
-### Edge cases
-- [ ] npm not installed → clear error
-- [ ] npm version too old → check and warn
-- [ ] Private registry → respects .npmrc
-- [ ] Scoped package with private registry → works
-
----
-
-## 20. General Edge Cases
-
-### Error handling
-- [ ] All commands have try/catch at top level
-- [ ] Errors include actionable messages
-- [ ] Stack traces hidden unless DEBUG
-
-### Permissions
-- [ ] No sudo required for ~/.pi
-- [ ] Handles permission denied gracefully
-- [ ] Doesn't follow symlinks outside allowed paths (security)
-
-### Concurrency
-- [ ] Two `omp install` at once → lock file prevents corruption
-- [ ] Interrupted install → recoverable state
-
-### Unicode/i18n
-- [ ] Plugin names with unicode → handled
-- [ ] Paths with spaces → quoted correctly
-- [ ] Paths with unicode → work on all platforms
-
----
-
-## Verification Steps
-
-For each section above:
-1. Read the relevant source file
-2. Trace the code path for the happy case
-3. Check each edge case is handled
-4. Note any missing error handling
-5. Run the command if possible to verify
-
-Report findings as:
-```
-## [Command Name]
-✓ Working: [list of working features]
-✗ Missing: [list of unimplemented features]
-⚠ Issues: [list of bugs or edge cases not handled]
-```

package/dist/migrate.d.ts

@@ -1,9 +0,0 @@
-/**
- * Check for and prompt migration if legacy manifest exists
- */
-export declare function checkMigration(auto?: boolean): Promise<boolean>;
-/**
- * Migrate from legacy manifest.json to npm-native format
- */
-export declare function migrateToNpm(): Promise<boolean>;
-//# sourceMappingURL=migrate.d.ts.map

package/dist/migrate.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"migrate.d.ts","sourceRoot":"","sources":["../src/migrate.ts"],"names":[],"mappings":"AAgCA;;GAEG;AACH,wBAAsB,cAAc,CAAC,IAAI,UAAQ,GAAG,OAAO,CAAC,OAAO,CAAC,CAkBnE;AAED;;GAEG;AACH,wBAAsB,YAAY,IAAI,OAAO,CAAC,OAAO,CAAC,CA2DrD"}

package/src/migrate.ts

@@ -1,181 +0,0 @@
-import { existsSync } from "node:fs";
-import { mkdir, readFile, rename, rm, symlink, writeFile } from "node:fs/promises";
-import { basename, join } from "node:path";
-import { createInterface } from "node:readline";
-import chalk from "chalk";
-import {
-	hasLegacyManifest,
-	type LegacyPluginInfo,
-	loadLegacyManifest,
-	type PluginPackageJson,
-	type PluginsJson,
-	savePluginsJson,
-} from "./manifest.js";
-import { LEGACY_MANIFEST_PATH, NODE_MODULES_DIR, PLUGINS_DIR } from "./paths.js";
-
-/**
- * Prompt user for migration
- */
-async function promptMigration(): Promise<boolean> {
-	const rl = createInterface({
-		input: process.stdin,
-		output: process.stdout,
-	});
-
-	return new Promise((resolve) => {
-		rl.question(chalk.yellow("Migrate to npm-native format? [y/N] "), (answer) => {
-			rl.close();
-			resolve(answer.toLowerCase() === "y" || answer.toLowerCase() === "yes");
-		});
-	});
-}
-
-/**
- * Check for and prompt migration if legacy manifest exists
- */
-export async function checkMigration(auto = false): Promise<boolean> {
-	if (!hasLegacyManifest()) {
-		return false;
-	}
-
-	console.log(chalk.yellow("\n⚠ Legacy manifest.json detected"));
-	console.log(chalk.dim("  oh-my-pi has been updated to use npm-native plugin management."));
-	console.log();
-
-	if (!auto) {
-		const shouldMigrate = await promptMigration();
-		if (!shouldMigrate) {
-			console.log(chalk.dim("  Migration skipped. Use 'omp migrate' to migrate later."));
-			return false;
-		}
-	}
-
-	return await migrateToNpm();
-}
-
-/**
- * Migrate from legacy manifest.json to npm-native format
- */
-export async function migrateToNpm(): Promise<boolean> {
-	console.log(chalk.blue("\nMigrating to npm-native format..."));
-
-	try {
-		const legacyManifest = await loadLegacyManifest();
-		const plugins = Object.entries(legacyManifest.plugins);
-
-		if (plugins.length === 0) {
-			console.log(chalk.dim("  No plugins to migrate"));
-			await archiveLegacyManifest();
-			return true;
-		}
-
-		// Create node_modules directory
-		await mkdir(NODE_MODULES_DIR, { recursive: true });
-
-		const newPluginsJson: PluginsJson = { plugins: {} };
-		const migrated: string[] = [];
-		const failed: string[] = [];
-
-		for (const [name, info] of plugins) {
-			try {
-				console.log(chalk.dim(`  Migrating ${name}...`));
-				await migratePlugin(name, info);
-
-				// Determine version specifier for plugins.json
-				if (info.type === "npm" && info.package) {
-					newPluginsJson.plugins[info.package] = info.version ? `^${info.version}` : "latest";
-				} else if (info.type === "local" && info.path) {
-					newPluginsJson.plugins[name] = `file:${info.path}`;
-				} else if (info.type === "github" && info.repo) {
-					// GitHub plugins become local after clone
-					newPluginsJson.plugins[name] = `file:${join(NODE_MODULES_DIR, name)}`;
-				}
-
-				migrated.push(name);
-			} catch (err) {
-				console.log(chalk.yellow(`    ⚠ Failed to migrate ${name}: ${(err as Error).message}`));
-				failed.push(name);
-			}
-		}
-
-		// Save new plugins.json
-		await savePluginsJson(newPluginsJson, true);
-
-		// Archive legacy manifest
-		await archiveLegacyManifest();
-
-		console.log();
-		console.log(chalk.green(`✓ Migrated ${migrated.length} plugin(s)`));
-		if (failed.length > 0) {
-			console.log(chalk.yellow(`⚠ Failed to migrate ${failed.length} plugin(s): ${failed.join(", ")}`));
-		}
-
-		return true;
-	} catch (err) {
-		console.log(chalk.red(`Error during migration: ${(err as Error).message}`));
-		return false;
-	}
-}
-
-/**
- * Migrate a single plugin to the new structure
- */
-async function migratePlugin(name: string, info: LegacyPluginInfo): Promise<void> {
-	const oldPluginDir = join(PLUGINS_DIR, name);
-	const newPluginDir = join(NODE_MODULES_DIR, name);
-
-	if (!existsSync(oldPluginDir)) {
-		throw new Error(`Plugin directory not found: ${oldPluginDir}`);
-	}
-
-	// For linked plugins, create symlink in node_modules
-	if (info.linked && info.path) {
-		await mkdir(NODE_MODULES_DIR, { recursive: true });
-		if (existsSync(newPluginDir)) {
-			await rm(newPluginDir, { force: true, recursive: true });
-		}
-		await symlink(info.path, newPluginDir);
-		// Remove old symlink
-		await rm(oldPluginDir, { force: true });
-		return;
-	}
-
-	// For regular plugins, move to node_modules
-	if (existsSync(newPluginDir)) {
-		await rm(newPluginDir, { force: true, recursive: true });
-	}
-
-	// Rename/move the directory
-	await rename(oldPluginDir, newPluginDir);
-
-	// Create package.json if it doesn't exist (convert from omp.json)
-	const pkgJsonPath = join(newPluginDir, "package.json");
-	const ompJsonPath = join(newPluginDir, "omp.json");
-
-	if (!existsSync(pkgJsonPath) && existsSync(ompJsonPath)) {
-		const ompJson = JSON.parse(await readFile(ompJsonPath, "utf-8"));
-		const pkgJson: PluginPackageJson = {
-			name: ompJson.name || name,
-			version: ompJson.version || info.version || "0.0.0",
-			description: ompJson.description,
-			keywords: ["omp-plugin"],
-			omp: {
-				install: ompJson.install,
-			},
-		};
-		await writeFile(pkgJsonPath, JSON.stringify(pkgJson, null, 2));
-	}
-}
-
-/**
- * Archive the legacy manifest.json
- */
-async function archiveLegacyManifest(): Promise<void> {
-	if (!existsSync(LEGACY_MANIFEST_PATH)) {
-		return;
-	}
-
-	const archivePath = join(PLUGINS_DIR, `manifest.json.bak.${Date.now()}`);
-	await rename(LEGACY_MANIFEST_PATH, archivePath);
-	console.log(chalk.dim(`  Archived old manifest to ${basename(archivePath)}`));
-}