@ogygie/studio 0.5.0 → 0.5.2

package/src/server/service.test.ts

@@ -1,305 +0,0 @@
-/**
- * @intent Proves the behaviors described in specs/ogygie-studio.spec.md at the
- * service level, over the in-memory SpecStorage (no fs, no network). Each
- * Given/When/Then block of the spec = one identically named test; the
- * serialization round-trip tests are the gate-style mutation checks (a
- * frontmatter the studio writes must be re-readable by the parser the CI uses).
- */
-import { describe, expect, it } from "vitest";
-import { parseSpecFrontmatter, SpecFrontmatterSchema } from "@ogygie/core/spec";
-import { createMemorySpecStorage } from "./storage/memory-adapter.js";
-import {
-  createSpec,
-  getManifest,
-  getSpec,
-  listSpecSummaries,
-  saveSpec,
-  serializeSpecFrontmatter,
-  splitSpecFile,
-} from "./service.js";
-
-const SECTION_BODIES: Record<string, string> = {
-  "# @intent": "Le pourquoi de la feature.",
-  "# Comportements": "- ÉTANT DONNÉ x QUAND y ALORS z",
-  "# Contrats de données": "- SomethingInputSchema: { champ: type }",
-  "# États UI": "- vide / chargement / nominal / erreur",
-  "# Non-objectifs": "Rien d'autre.",
-  "# Budget": "- P95 API < 100 ms",
-};
-
-/** Builds a canonical spec file; `omitSections` drops mandatory sections. */
-function specFile(options: {
-  id: string;
-  status?: string;
-  priority?: string;
-  omitSections?: string[];
-}): string {
-  const omitted = new Set(options.omitSections ?? []);
-  const sections = Object.entries(SECTION_BODIES)
-    .filter(([title]) => !omitted.has(title))
-    .map(([title, body]) => `${title}\n${body}`)
-    .join("\n\n");
-  return [
-    "---",
-    `id: ${options.id}`,
-    `status: ${options.status ?? "draft"}`,
-    "depends_on: []",
-    `priority: ${options.priority ?? "P1"}`,
-    "refs: []",
-    "---",
-    "",
-    sections,
-    "",
-  ].join("\n");
-}
-
-const TEMPLATE = specFile({ id: "nom-de-la-feature" });
-
-const VALID_MANIFEST = JSON.stringify({
-  version: 1,
-  product: { name: "starter", description: "Squelette de produit Ogygie pour les tests." },
-  apps: [{ name: "api", path: "apps/api", type: "api", entryPoint: "apps/api/src/server.ts" }],
-  features: [],
-  conventions: { agentsMd: "AGENTS.md", failuresMd: "FAILURES.md", specsFolder: "specs/" },
-});
-
-function benchWith(files: Record<string, string>) {
-  const storage = createMemorySpecStorage({
-    "specs/_TEMPLATE.spec.md": TEMPLATE,
-    "ogygie.manifest.json": VALID_MANIFEST,
-    ...files,
-  });
-  return { storage, deps: { storage } };
-}
-
-describe("ogygie-studio — service", () => {
-  it("ÉTANT DONNÉ un repo Ogygie valide QUAND le studio charge le dossier specs/ ALORS chaque spec est résumée avec le statut lu depuis son frontmatter", async () => {
-    const { deps } = benchWith({
-      "specs/alpha.spec.md": specFile({ id: "alpha", status: "draft" }),
-      "specs/beta.spec.md": specFile({ id: "beta", status: "validated" }),
-      "specs/gamma.spec.md": specFile({ id: "gamma", status: "implemented" }),
-    });
-    const summaries = await listSpecSummaries(deps);
-    expect(summaries).toHaveLength(3);
-    expect(summaries).toEqual(
-      expect.arrayContaining([
-        expect.objectContaining({ id: "alpha", status: "draft" }),
-        expect.objectContaining({ id: "beta", status: "validated" }),
-        expect.objectContaining({ id: "gamma", status: "implemented" }),
-      ]),
-    );
-    const alpha = summaries.find((summary) => summary.id === "alpha");
-    expect(alpha).toMatchObject({
-      filePath: "specs/alpha.spec.md",
-      presentSections: [
-        "# @intent",
-        "# Comportements",
-        "# Contrats de données",
-        "# États UI",
-        "# Non-objectifs",
-        "# Budget",
-      ],
-    });
-  });
-
-  it("ÉTANT DONNÉ une spec dont le frontmatter viole SpecFrontmatterSchema QUAND le studio charge le dossier specs/ ALORS elle apparaît en carte d'erreur SPEC_FRONTMATTER_INVALID et n'est jamais réparée", async () => {
-    const broken = "---\nid: broken\nstatus: nonsense\ndepends_on: []\npriority: P1\n---\n\n# @intent\nx\n";
-    const { deps, storage } = benchWith({ "specs/broken.spec.md": broken });
-    const summaries = await listSpecSummaries(deps);
-    expect(summaries).toHaveLength(1);
-    expect(summaries[0]).toMatchObject({
-      id: "broken",
-      filePath: "specs/broken.spec.md",
-      error: expect.objectContaining({
-        code: "SPEC_FRONTMATTER_INVALID",
-        file: "specs/broken.spec.md",
-      }),
-    });
-    // Never silently repaired: the file is byte-identical and nothing was written.
-    expect(storage.files.get("specs/broken.spec.md")).toBe(broken);
-    expect(storage.messages).toEqual([]);
-  });
-
-  it("ÉTANT DONNÉ une spec en draft QUAND on modifie le frontmatter et sauvegarde ALORS le fichier est réécrit conforme au schéma et les sections markdown sont préservées à l'octet près", async () => {
-    const original = specFile({ id: "alpha", status: "draft", priority: "P1" });
-    const { deps, storage } = benchWith({ "specs/alpha.spec.md": original });
-    const before = await getSpec(deps, "alpha");
-
-    await saveSpec(deps, "alpha", {
-      frontmatter: { ...before.frontmatter, priority: "P0" },
-    });
-
-    const written = storage.files.get("specs/alpha.spec.md");
-    expect(written).toBeDefined();
-    const split = splitSpecFile(written ?? "");
-    expect(split?.body).toBe(before.body); // byte-exact markdown
-    const reparsed = SpecFrontmatterSchema.parse(
-      parseSpecFrontmatter(split?.frontmatterText ?? "").value,
-    );
-    expect(reparsed.priority).toBe("P0");
-    expect(reparsed.status).toBe("draft");
-    expect(storage.messages).toEqual(["spec: save alpha"]);
-  });
-
-  it("ÉTANT DONNÉ une spec en draft dont les 6 sections obligatoires sont présentes QUAND on valide ALORS status passe à validated via SpecStorage.write avec le message \"spec: validate <id>\"", async () => {
-    const { deps, storage } = benchWith({
-      "specs/alpha.spec.md": specFile({ id: "alpha", status: "draft" }),
-    });
-    const before = await getSpec(deps, "alpha");
-
-    const summary = await saveSpec(deps, "alpha", {
-      frontmatter: { ...before.frontmatter, status: "validated" },
-    });
-
-    expect(summary.status).toBe("validated");
-    expect(storage.messages).toEqual(["spec: validate alpha"]);
-    const after = await getSpec(deps, "alpha");
-    expect(after.frontmatter.status).toBe("validated");
-  });
-
-  it("ÉTANT DONNÉ une spec en draft dont une section obligatoire manque QUAND on tente « Valider » ALORS OgygieError SPEC_SECTION_MISSING liste les sections absentes et le statut ne change pas", async () => {
-    const original = specFile({ id: "alpha", status: "draft", omitSections: ["# Budget"] });
-    const { deps, storage } = benchWith({ "specs/alpha.spec.md": original });
-    const before = await getSpec(deps, "alpha");
-
-    await expect(
-      saveSpec(deps, "alpha", {
-        frontmatter: { ...before.frontmatter, status: "validated" },
-      }),
-    ).rejects.toMatchObject({
-      httpStatus: 409,
-      error: expect.objectContaining({
-        code: "SPEC_SECTION_MISSING",
-        details: { missingSections: ["# Budget"] },
-      }),
-    });
-    expect(storage.files.get("specs/alpha.spec.md")).toBe(original);
-    expect(storage.messages).toEqual([]);
-  });
-
-  it("ÉTANT DONNÉ une spec quelconque QUAND on tente de forcer status: implemented depuis le studio ALORS OgygieError STUDIO_TRANSITION_FORBIDDEN", async () => {
-    const { deps } = benchWith({
-      "specs/alpha.spec.md": specFile({ id: "alpha", status: "validated" }),
-    });
-    const before = await getSpec(deps, "alpha");
-
-    await expect(
-      saveSpec(deps, "alpha", {
-        frontmatter: { ...before.frontmatter, status: "implemented" },
-      }),
-    ).rejects.toMatchObject({
-      httpStatus: 409,
-      error: expect.objectContaining({ code: "STUDIO_TRANSITION_FORBIDDEN" }),
-    });
-  });
-
-  it("ÉTANT DONNÉ une spec validated QUAND on tente de la repasser en draft depuis le studio ALORS OgygieError STUDIO_TRANSITION_FORBIDDEN (le studio ne fait que draft → validated)", async () => {
-    const { deps } = benchWith({
-      "specs/alpha.spec.md": specFile({ id: "alpha", status: "validated" }),
-    });
-    const before = await getSpec(deps, "alpha");
-
-    await expect(
-      saveSpec(deps, "alpha", {
-        frontmatter: { ...before.frontmatter, status: "draft" },
-      }),
-    ).rejects.toMatchObject({
-      error: expect.objectContaining({ code: "STUDIO_TRANSITION_FORBIDDEN" }),
-    });
-  });
-
-  it("ÉTANT DONNÉ le board affiché QUAND on crée une nouvelle spec ALORS specs/<id>.spec.md naît de _TEMPLATE.spec.md avec status: draft", async () => {
-    const { deps, storage } = benchWith({});
-
-    const summary = await createSpec(deps, "ma-feature");
-
-    expect(summary).toMatchObject({ id: "ma-feature", status: "draft" });
-    const written = storage.files.get("specs/ma-feature.spec.md") ?? "";
-    expect(written).toContain("id: ma-feature");
-    expect(written).toContain("status: draft");
-    expect(storage.messages).toEqual(["spec: create ma-feature"]);
-  });
-
-  it("ÉTANT DONNÉ une spec existante QUAND on tente de créer le même id ALORS SPEC_ALREADY_EXISTS et rien n'est écrasé", async () => {
-    const original = specFile({ id: "alpha", status: "validated" });
-    const { deps, storage } = benchWith({ "specs/alpha.spec.md": original });
-
-    await expect(createSpec(deps, "alpha")).rejects.toMatchObject({
-      httpStatus: 409,
-      error: expect.objectContaining({ code: "SPEC_ALREADY_EXISTS" }),
-    });
-    expect(storage.files.get("specs/alpha.spec.md")).toBe(original);
-  });
-
-  it("ÉTANT DONNÉ le manifeste du repo QUAND on ouvre la vue manifeste ALORS son contenu parsé est retourné (lecture seule : aucune écriture n'existe dans le service)", async () => {
-    const { deps } = benchWith({});
-    const manifest = await getManifest(deps);
-    expect(manifest.product.name).toBe("starter");
-    expect(manifest.apps[0]?.type).toBe("api");
-  });
-
-  it("ÉTANT DONNÉ un manifeste invalide QUAND on ouvre la vue manifeste ALORS OgygieError MANIFEST_INVALID (jamais un contenu réparé)", async () => {
-    const { deps, storage } = benchWith({});
-    storage.files.set("ogygie.manifest.json", JSON.stringify({ version: 2 }));
-
-    await expect(getManifest(deps)).rejects.toMatchObject({
-      httpStatus: 422,
-      error: expect.objectContaining({ code: "MANIFEST_INVALID" }),
-    });
-  });
-
-  it("ÉTANT DONNÉ une spec inconnue QUAND on la lit ALORS SPEC_NOT_FOUND", async () => {
-    const { deps } = benchWith({});
-    await expect(getSpec(deps, "fantome")).rejects.toMatchObject({
-      httpStatus: 404,
-      error: expect.objectContaining({ code: "SPEC_NOT_FOUND" }),
-    });
-  });
-});
-
-describe("ogygie-studio — sérialisation du frontmatter (round-trip, style mutation)", () => {
-  const base = {
-    id: "alpha",
-    status: "draft",
-    depends_on: ["beta", "gamma"],
-    priority: "P2",
-    refs: ["specs/OGYGIE-STUDIO-ARCHI.md", "modele §4.2, alinéa b"],
-    deferred: ["X_CODE (résumé) blockedBy:beta"],
-  } as const;
-
-  it("ÉTANT DONNÉ un frontmatter valide (virgule dans une ref, deferred non vide) QUAND on le sérialise ALORS parseSpecFrontmatter le relit à l'identique", () => {
-    const frontmatter = SpecFrontmatterSchema.parse(base);
-    const serialized = serializeSpecFrontmatter(frontmatter, "specs/alpha.spec.md");
-    const reparsed = parseSpecFrontmatter(serialized);
-    expect(reparsed.problems).toEqual([]);
-    expect(SpecFrontmatterSchema.parse(reparsed.value)).toEqual(frontmatter);
-  });
-
-  it("ÉTANT DONNÉ une ref contenant un guillemet double QUAND on sérialise ALORS elle est écrite entre quotes simples et relue à l'identique", () => {
-    const frontmatter = SpecFrontmatterSchema.parse({
-      ...base,
-      refs: ['la section "Budget" du modèle'],
-      deferred: [],
-    });
-    const serialized = serializeSpecFrontmatter(frontmatter, "specs/alpha.spec.md");
-    const reparsed = parseSpecFrontmatter(serialized);
-    expect(reparsed.problems).toEqual([]);
-    expect(SpecFrontmatterSchema.parse(reparsed.value).refs).toEqual(frontmatter.refs);
-  });
-
-  it("ÉTANT DONNÉ une ref mêlant les deux types de guillemets QUAND on sérialise ALORS SPEC_FRONTMATTER_UNSERIALIZABLE — jamais un fichier que le gate refuserait", () => {
-    const frontmatter = SpecFrontmatterSchema.parse({
-      ...base,
-      refs: [`mélange "double" et 'simple'`],
-      deferred: [],
-    });
-    try {
-      serializeSpecFrontmatter(frontmatter, "specs/alpha.spec.md");
-      expect.unreachable("serialization should have refused the element");
-    } catch (thrown) {
-      expect(thrown).toMatchObject({
-        error: expect.objectContaining({ code: "SPEC_FRONTMATTER_UNSERIALIZABLE" }),
-      });
-    }
-  });
-});