@ogygie/cli 0.9.0 → 0.10.0

package/dist/cli.js

@@ -15587,6 +15587,18 @@ var governedChecksumsByVersion = {
     "CLAUDE.md": "785ee8d90e368806d8cf0b4d84a15f29d1dc961168bda86cf1a6c60a923c8c9b",
     "tsconfig.base.json": "0f8919e9ed8bbc88e0308fa2fa91471dabb18d1df721bd78c04076597eba89a2"
   },
+  "0.10.0": {
+    ".github/workflows/ogygie-gates.yml": "48c40efe9fe66dd0f9c3b94287026d80eae9afd6782b5833fdf8846d8662babf",
+    "AGENTS.md": "e44f635c0b203a0040098425f217c5a29c47e57280a3545b60d640aea0d59a70",
+    "CLAUDE.md": "785ee8d90e368806d8cf0b4d84a15f29d1dc961168bda86cf1a6c60a923c8c9b",
+    "scripts/lint-interdits.ts": "d859e132b7020942a5211f5419b10045170dee6afba3f50ca5642570a5c4a683",
+    "scripts/ogygie-design-brief.ts": "aba1585717b30808dd0bc8930a37a1ad2d83ee6869f969dbd06ca595e37a4a89",
+    "scripts/ogygie-impact.ts": "825a47a51e940b2d8473714a417b4a75bad4eede35e3f4b34258bf6e181e98f4",
+    "scripts/verify-contracts.ts": "725cae269e78ecdaa1923553c3097d8d96277824b5bd79a9a40284c6246036b7",
+    "scripts/verify-manifest.ts": "1adca9edee11e54ccaf0511012411516c52c68a32f686ca320c7e437afb22c7c",
+    "scripts/verify-specs.ts": "ccf09c04155e5e88fa9acd4a5db33c2c79e85923b2d92e8e866fe9cbc4cdf342",
+    "tsconfig.base.json": "0f8919e9ed8bbc88e0308fa2fa91471dabb18d1df721bd78c04076597eba89a2"
+  },
   "0.2.0": {
     ".github/workflows/ogygie-gates.yml": "48c40efe9fe66dd0f9c3b94287026d80eae9afd6782b5833fdf8846d8662babf",
     "AGENTS.md": "ca73ab619d8c55fac11858d815bf5fbab6537ecebe7ae4123cbdeb3e3e36bf1a",
@@ -15664,6 +15676,18 @@ var governedChecksumsByVersion = {
     "scripts/verify-manifest.ts": "1adca9edee11e54ccaf0511012411516c52c68a32f686ca320c7e437afb22c7c",
     "scripts/verify-specs.ts": "ccf09c04155e5e88fa9acd4a5db33c2c79e85923b2d92e8e866fe9cbc4cdf342",
     "tsconfig.base.json": "0f8919e9ed8bbc88e0308fa2fa91471dabb18d1df721bd78c04076597eba89a2"
+  },
+  "0.9.0": {
+    ".github/workflows/ogygie-gates.yml": "48c40efe9fe66dd0f9c3b94287026d80eae9afd6782b5833fdf8846d8662babf",
+    "AGENTS.md": "e44f635c0b203a0040098425f217c5a29c47e57280a3545b60d640aea0d59a70",
+    "CLAUDE.md": "785ee8d90e368806d8cf0b4d84a15f29d1dc961168bda86cf1a6c60a923c8c9b",
+    "scripts/lint-interdits.ts": "d859e132b7020942a5211f5419b10045170dee6afba3f50ca5642570a5c4a683",
+    "scripts/ogygie-design-brief.ts": "aba1585717b30808dd0bc8930a37a1ad2d83ee6869f969dbd06ca595e37a4a89",
+    "scripts/ogygie-impact.ts": "0dd3ff8cdd57e6cff0dfec1c669fce53fde9ae43f0784ed114771c83d1f8b357",
+    "scripts/verify-contracts.ts": "725cae269e78ecdaa1923553c3097d8d96277824b5bd79a9a40284c6246036b7",
+    "scripts/verify-manifest.ts": "1adca9edee11e54ccaf0511012411516c52c68a32f686ca320c7e437afb22c7c",
+    "scripts/verify-specs.ts": "ccf09c04155e5e88fa9acd4a5db33c2c79e85923b2d92e8e866fe9cbc4cdf342",
+    "tsconfig.base.json": "0f8919e9ed8bbc88e0308fa2fa91471dabb18d1df721bd78c04076597eba89a2"
   }
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ogygie/cli",
-  "version": "0.9.0",
+  "version": "0.10.0",
   "description": "Ogygie framework CLI: deterministic scaffolding (init), governed-file upgrades (upgrade) and lockstep verification (check) for Ogygie products.",
   "license": "MIT",
   "type": "module",
@@ -22,7 +22,7 @@
     "tsx": "^4.20.0",
     "typescript": "^5.8.0",
     "zod": "^4.0.0",
-    "@ogygie/core": "0.9.0"
+    "@ogygie/core": "0.10.0"
   },
   "scripts": {
     "typecheck": "tsc -p tsconfig.json",

package/templates/project/scripts/ogygie-impact.ts

@@ -1,255 +1,33 @@
 /**
- * @intent Session tool `pnpm ogygie:impact <feature>` (specs/ogygie-impact.spec.md,
- * DECISIONS.md D21): prints the blast radius of a change to a delivered
- * feature — who depends on it (declared AND actually imported symbols), its
- * routes, its owned tables and any outside reader of them, plus the exact
- * test command to keep every dependent green. Same family as verify-*:
- * fs + textual import analysis, no new dependency, findings as OgygieError.
+ * @intent Session tool `pnpm ogygie:impact <target>` (spec
+ * impact-analyzer-core): prints the blast radius of a change to delivered
+ * code — who depends on it, which symbols they use, its routes, the tables it
+ * owns and any outside reader of them, the tests to re-run, and WHAT THE
+ * ANALYSIS COULD NOT SEE (D12).
  *
- * Output contract (spec §États UI reconciled with §Comportements): default
- * prints the JSON report THEN the human summary; `--json` prints the JSON
- * report only. Exit 0 when findings are empty, 1 otherwise.
+ * The judgement lives in `@ogygie/core/impact`, where it is tested against an
+ * in-memory repo and callable by other tools; this script is its collecting
+ * half — read the manifest, open the repo, print. Everything it used to
+ * decide by itself (which app carries which feature, what counts as an
+ * import) now comes from the map and from the core.
  *
- * Deliberate scope choices:
- * - Depth 1 only (direct dependents) — spec §Non-objectifs.
- * - The owned-tables scan ignores *.test.ts files: populating ANOTHER feature's
- *   table as a fixture is the canonical bench pattern ("the socle feature owns
- *   that model" — see any service.test.ts); flagging it would make every run
- *   red and the tool useless. Production code referencing a foreign table
- *   remains a potential violation and IS flagged.
+ * Output contract: default prints the JSON report THEN the human summary;
+ * `--json` prints the JSON only. Exit 0 when findings are empty, 1 otherwise.
  */
-import { existsSync, readFileSync, readdirSync, statSync } from "node:fs";
+import { readFileSync } from "node:fs";
 import { join } from "node:path";
-import { z } from "zod";
+import { analyzeImpact, type ImpactReport } from "@ogygie/core/impact";
 import { OgygieManifestSchema } from "@ogygie/core/manifest";
-import { dbTableNamesOf } from "@ogygie/core/shared-tables";
-import { OgygieErrorSchema, ogygieError, type OgygieError } from "@ogygie/core/errors";
+import { createFilesystemRepoAdapter } from "@ogygie/core/repo-adapter";
+import { OgygieFailure, ogygieError } from "@ogygie/core/errors";
 
 const ROOT = new URL("..", import.meta.url).pathname;
 const MANIFEST_PATH = "ogygie.manifest.json";
 
-// ---------------------------------------------------------------- contract
-/** In @ogygie/core once the pattern proves generic (spec §Contrats, D10 rule 3). */
-export const ImpactReportSchema = z.object({
-  feature: z.string(),
-  dependents: z.array(
-    z.object({
-      name: z.string(),
-      importedSymbols: z.array(z.string()),
-      viaIndexOnly: z.boolean(),
-    }),
-  ),
-  routes: z.array(
-    z.object({ method: z.string(), path: z.string(), description: z.string() }),
-  ),
-  ownedTables: z.array(z.string()),
-  tableReadersOutsideOwner: z.array(
-    z.object({ table: z.string(), feature: z.string(), file: z.string() }),
-  ),
-  findings: z.array(OgygieErrorSchema),
-  testCommand: z.string(),
-});
-export type ImpactReport = z.infer<typeof ImpactReportSchema>;
-
-// ---------------------------------------------------------------- helpers
-function walkTsFiles(dir: string): string[] {
-  const files: string[] = [];
-  for (const entry of readdirSync(dir)) {
-    const fullPath = join(dir, entry);
-    if (statSync(fullPath).isDirectory()) files.push(...walkTsFiles(fullPath));
-    else if (entry.endsWith(".ts") || entry.endsWith(".tsx")) files.push(fullPath);
-  }
-  return files;
-}
-
-/** Named/default/namespace symbols of one import clause ("type" stripped). */
-function symbolsOfImportClause(clause: string): string[] {
-  const symbols: string[] = [];
-  const braces = /\{([^}]*)\}/.exec(clause);
-  if (braces?.[1] !== undefined) {
-    for (const rawEntry of braces[1].split(",")) {
-      const name = rawEntry.trim().replace(/^type\s+/, "").split(/\s+as\s+/)[0]?.trim();
-      if (name !== undefined && name !== "") symbols.push(name);
-    }
-  }
-  const outsideBraces = clause.replace(/\{[^}]*\}/, "").replace(/^type\s+/, "").trim();
-  if (/\*\s*as\s+/.test(outsideBraces)) symbols.push("*");
-  else if (outsideBraces.replace(/,/g, "").trim() !== "") symbols.push("default");
-  return symbols;
-}
-
-// ---------------------------------------------------------------- report
-export function buildImpactReport(featureName: string): ImpactReport {
-  const manifest = OgygieManifestSchema.parse(
-    JSON.parse(readFileSync(join(ROOT, MANIFEST_PATH), "utf8")),
-  );
-  const apiApp = manifest.apps.find((app) => app.type === "api");
-  if (apiApp === undefined) {
-    throw new Error("no app of type api in the manifest");
-  }
-  const target = manifest.features.find((feature) => feature.name === featureName);
-  if (target === undefined) {
-    const failure = ogygieError({
-      code: "IMPACT_UNKNOWN_FEATURE",
-      message: `Feature "${featureName}" is unknown to the manifest. Valid features: ${manifest.features.map((feature) => feature.name).join(", ")}.`,
-      file: MANIFEST_PATH,
-      cause: `no features[] entry has name="${featureName}"`,
-      suggestedFix: "Pick one of the valid feature names listed in the message.",
-    });
-    console.error(JSON.stringify(failure, null, 2));
-    console.error("\nogygie:impact — feature inconnue.");
-    process.exit(1);
-  }
-
-  const findings: OgygieError[] = [];
-  const targetDirName = target.folder.split("/").pop() ?? target.folder;
-
-  // (a)+(b) dependents: declared in the manifest AND/OR actually importing.
-  const importersByFeature = new Map<
-    string,
-    { importedSymbols: Set<string>; viaIndexOnly: boolean }
-  >();
-  for (const feature of manifest.features) {
-    if (feature.name === target.name) continue;
-    const featureDir = join(ROOT, apiApp.path, feature.folder);
-    if (!existsSync(featureDir)) continue;
-    for (const filePath of walkTsFiles(featureDir)) {
-      const content = readFileSync(filePath, "utf8");
-      const relativeFile = filePath.slice(ROOT.length);
-      for (const match of content.matchAll(
-        /import\s+([^'"]+?)\s+from\s+"([^"]+)"/g,
-      )) {
-        const clause = match[1];
-        const source = match[2];
-        if (clause === undefined || source === undefined) continue;
-        const sibling = new RegExp(`^\\.\\./${targetDirName}/(.+)$`).exec(source);
-        if (sibling === null || sibling[1] === undefined) continue;
-        const entry = importersByFeature.get(feature.name) ?? {
-          importedSymbols: new Set<string>(),
-          viaIndexOnly: true,
-        };
-        for (const symbol of symbolsOfImportClause(clause)) {
-          entry.importedSymbols.add(symbol);
-        }
-        if (sibling[1] !== "index.js") {
-          entry.viaIndexOnly = false;
-          findings.push(
-            ogygieError({
-              code: "FEATURE_BOUNDARY_VIOLATION",
-              message: `Feature "${feature.name}" imports an internal file of "${target.name}" instead of its index.ts.`,
-              file: relativeFile,
-              cause: `import from "${source}" bypasses ${targetDirName}/index.ts`,
-              suggestedFix: `Export the needed symbols from ${targetDirName}/index.ts and import them from "../${targetDirName}/index.js".`,
-            }),
-          );
-        }
-        importersByFeature.set(feature.name, entry);
-      }
-    }
-  }
-
-  const declaredDependents = manifest.features.filter((feature) =>
-    feature.dependsOn.includes(target.name),
-  );
-  for (const declared of declaredDependents) {
-    if (!importersByFeature.has(declared.name)) {
-      findings.push(
-        ogygieError({
-          code: "MANIFEST_DEPENDENCY_STALE",
-          message: `Feature "${declared.name}" declares dependsOn "${target.name}" but never imports it.`,
-          file: `${MANIFEST_PATH}#features.${declared.name}`,
-          cause: `dependsOn contains "${target.name}", no import of ../${targetDirName}/ found in its code`,
-          suggestedFix:
-            "Remove the stale dependsOn entry, or make the dependency real through the feature's index.ts.",
-        }),
-      );
-    }
-  }
-  for (const importerName of importersByFeature.keys()) {
-    if (!declaredDependents.some((declared) => declared.name === importerName)) {
-      findings.push(
-        ogygieError({
-          code: "MANIFEST_DEPENDENCY_UNDECLARED",
-          message: `Feature "${importerName}" imports "${target.name}" but does not declare it in dependsOn.`,
-          file: `${MANIFEST_PATH}#features.${importerName}`,
-          cause: `imports of ../${targetDirName}/ found in its code, "${target.name}" absent from its dependsOn`,
-          suggestedFix: `Add "${target.name}" to the dependsOn of "${importerName}" — the manifest must never lie by omission.`,
-        }),
-      );
-    }
-  }
-
-  const dependentNames = [
-    ...new Set([
-      ...declaredDependents.map((feature) => feature.name),
-      ...importersByFeature.keys(),
-    ]),
-  ].sort();
-  const dependents = dependentNames.map((name) => {
-    const imports = importersByFeature.get(name);
-    return {
-      name,
-      importedSymbols: [...(imports?.importedSymbols ?? [])].sort(),
-      viaIndexOnly: imports?.viaIndexOnly ?? true,
-    };
-  });
-
-  // (d) owned tables referenced by another feature's PRODUCTION code.
-  const tableReadersOutsideOwner: ImpactReport["tableReadersOutsideOwner"] = [];
-  for (const feature of manifest.features) {
-    if (feature.name === target.name) continue;
-    const featureDir = join(ROOT, apiApp.path, feature.folder);
-    if (!existsSync(featureDir)) continue;
-    for (const filePath of walkTsFiles(featureDir)) {
-      if (filePath.endsWith(".test.ts") || filePath.endsWith(".test.tsx")) continue;
-      const content = readFileSync(filePath, "utf8");
-      const relativeFile = filePath.slice(ROOT.length);
-      for (const table of dbTableNamesOf(target)) {
-        if (!content.includes(`"${table}"`)) continue;
-        tableReadersOutsideOwner.push({
-          table,
-          feature: feature.name,
-          file: relativeFile,
-        });
-        findings.push(
-          ogygieError({
-            code: "TABLE_REFERENCED_OUTSIDE_OWNER",
-            message: `Table "${table}" is owned by "${target.name}" but referenced by production code of "${feature.name}".`,
-            file: relativeFile,
-            cause: `"${table}" found in a non-test file outside its owner feature`,
-            suggestedFix: `Go through the public contracts of ${targetDirName}/index.ts instead of touching the table — one table = one owner.`,
-          }),
-        );
-      }
-    }
-  }
-
-  const dependentDirNames = dependentNames.map((name) => {
-    const feature = manifest.features.find((candidate) => candidate.name === name);
-    return feature?.folder.split("/").pop() ?? name;
-  });
-  const testCommand = ["pnpm test --", `features/${targetDirName}`, ...dependentDirNames.map((dirName) => `features/${dirName}`)].join(" ");
-
-  return ImpactReportSchema.parse({
-    feature: target.name,
-    dependents,
-    routes: target.routes.map((route) => ({
-      method: route.method,
-      path: route.path,
-      description: route.description,
-    })),
-    ownedTables: dbTableNamesOf(target),
-    tableReadersOutsideOwner,
-    findings,
-    testCommand,
-  });
-}
-
-// ---------------------------------------------------------------- CLI
 function printSummary(report: ImpactReport): void {
-  console.log(`\n── ogygie:impact ${report.feature} ──`);
+  console.log(`\n── ogygie:impact ${report.target.name} (${report.target.kind}) ──`);
   if (report.dependents.length === 0) {
-    console.log("Dépendants : aucun.");
+    console.log("Dépendants : aucun DANS CE PÉRIMÈTRE.");
   } else {
     console.log(`Dépendants (${report.dependents.length}) :`);
     for (const dependent of report.dependents) {
@@ -258,7 +36,7 @@ function printSummary(report: ImpactReport): void {
           ? `importe { ${dependent.importedSymbols.join(", ")} }`
           : "n'importe aucun symbole";
       const boundary = dependent.viaIndexOnly ? "via index.ts uniquement" : "⚠ contourne index.ts";
-      console.log(`  • ${dependent.name} — ${symbols} — ${boundary}`);
+      console.log(`  • ${dependent.name} (${dependent.kind}) — ${symbols} — ${boundary}`);
     }
   }
   const routes = report.routes.map((route) => `${route.method} ${route.path}`).join(" · ");
@@ -266,36 +44,67 @@ function printSummary(report: ImpactReport): void {
   console.log(
     `Tables possédées : ${report.ownedTables.length === 0 ? "aucune" : report.ownedTables.join(", ")}`,
   );
-  if (report.tableReadersOutsideOwner.length > 0) {
-    for (const reader of report.tableReadersOutsideOwner) {
-      console.log(`  ⚠ "${reader.table}" référencée par ${reader.feature} (${reader.file})`);
-    }
+  for (const reader of report.tableReadersOutsideOwner) {
+    console.log(`  ⚠ "${reader.table}" référencée par ${reader.feature} (${reader.file})`);
   }
   console.log(
     report.findings.length === 0
       ? "Findings : aucun."
       : `Findings : ${report.findings.length} (détail dans le JSON ci-dessus).`,
   );
-  console.log(`Tests à relancer : ${report.testCommand}\n`);
+  console.log(`Tests à relancer : ${report.testCommand}`);
+  // Always printed, ESPECIALLY when nothing was found: "no dependents" and
+  // "I did not look there" read the same without it (D12).
+  console.log(`\nPérimètre — dossiers scannés : ${report.scope.scannedFolders.length}`);
+  console.log(`Hors de portée de cette analyse :`);
+  for (const limit of report.scope.outOfReach) console.log(`  · ${limit}`);
+  console.log("");
 }
 
 const cliArguments = process.argv.slice(2);
 const jsonOnly = cliArguments.includes("--json");
-const featureArgument = cliArguments.find((argument) => !argument.startsWith("--"));
-
-if (featureArgument === undefined) {
-  const failure = ogygieError({
-    code: "IMPACT_UNKNOWN_FEATURE",
-    message: "No feature name given. Usage: pnpm ogygie:impact <feature> [--json].",
-    file: null,
-    cause: "process.argv carries no non-flag argument",
-    suggestedFix: "Pass a feature name from ogygie.manifest.json, e.g. `pnpm ogygie:impact orders`.",
-  });
-  console.error(JSON.stringify(failure, null, 2));
+const targetArgument = cliArguments.find((argument) => !argument.startsWith("--"));
+
+function fail(error: unknown): never {
+  const payload =
+    error instanceof OgygieFailure
+      ? error.error
+      : ogygieError({
+          code: "IMPACT_FAILED",
+          message: "The impact analysis could not run.",
+          file: MANIFEST_PATH,
+          cause: error instanceof Error ? error.message : String(error),
+          suggestedFix: "Run `pnpm ogygie:verify-manifest` — the analysis reads the map first.",
+        });
+  console.error(JSON.stringify(payload, null, 2));
   process.exit(1);
 }
 
-const report = buildImpactReport(featureArgument);
-console.log(JSON.stringify(report, null, 2));
-if (!jsonOnly) printSummary(report);
-process.exit(report.findings.length === 0 ? 0 : 1);
+if (targetArgument === undefined) {
+  fail(
+    new OgygieFailure(
+      ogygieError({
+        code: "IMPACT_UNKNOWN_FEATURE",
+        message: "No target given. Usage: pnpm ogygie:impact <feature|package> [--json].",
+        file: null,
+        cause: "process.argv carries no non-flag argument",
+        suggestedFix: "Pass a name declared in ogygie.manifest.json.",
+      }),
+    ),
+  );
+}
+
+try {
+  const manifest = OgygieManifestSchema.parse(
+    JSON.parse(readFileSync(join(ROOT, MANIFEST_PATH), "utf8")),
+  );
+  const report = await analyzeImpact(
+    { manifest, adapter: createFilesystemRepoAdapter(ROOT) },
+    targetArgument,
+  );
+  console.log(JSON.stringify(report, null, 2));
+  if (!jsonOnly) printSummary(report);
+  process.exit(report.findings.length === 0 ? 0 : 1);
+} catch (thrown) {
+  fail(thrown);
+}