@officexapp/vidfarm-devcli 0.21.55 → 0.21.57

package/dist/src/services/composition-lint.js

@@ -5,6 +5,7 @@
 // composition vocabulary (data-vf-* proxies, transition holds, caption spans).
 import { parseHTML } from "linkedom";
 import { CAPTION_ANIMATIONS, KEN_BURNS_PRESETS, TRANSITION_OUT_PRESETS, TRANSITION_PRESETS } from "../hyperframes/composition.js";
+import { ENGINE_GLOBALS_FIX, findEngineOwnedGlobalAssignments, usesTimelineLibraryWithoutRegistry } from "../lib/engine-globals.js";
 const OVERLAP_EPSILON = 0.011;
 function parseNumberAttr(value) {
     if (typeof value !== "string" || !value.trim()) {
@@ -175,6 +176,21 @@ export function lintCompositionHtml(html) {
             }
         }
     }
+    // ── Engine-owned globals ────────────────────────────────────────────────────
+    // The highest-value check in this file. A composition that assigns
+    // window.__player (or window.__hf) still renders, still exits 0, and still
+    // writes a correct-length MP4 — in which nothing moves. Nothing downstream
+    // catches it, so it has to be an ERROR here. See lib/engine-globals.ts.
+    for (const hit of findEngineOwnedGlobalAssignments(trimmed)) {
+        push("error", "engine_owned_global_assigned", `Line ${hit.line} assigns window.${hit.global} — the HyperFrames engine owns that global. ` +
+            "Assigning it destroys the frame-capture bridge: the render still succeeds and writes a video in which NOTHING MOVES. " +
+            ENGINE_GLOBALS_FIX, hit.snippet);
+    }
+    if (usesTimelineLibraryWithoutRegistry(trimmed)) {
+        push("warning", "missing_timeline_registry", 'Composition builds a GSAP/anime timeline but never registers one on window.__timelines. ' +
+            'The engine drives motion by SEEKING a registered paused timeline — without it the render is a still image. ' +
+            'Add: window.__timelines = window.__timelines || {}; window.__timelines["<data-composition-id>"] = tl;');
+    }
     const scripts = document.querySelectorAll("script");
     if (scripts.length > 0) {
         push("warning", "scripts_stripped_on_save", `Composition contains ${scripts.length} <script> tag(s). Scripts survive local serve/disk renders, but every cloud/web editor save strips them (stored-XSS defense) — script-driven animation will be lost there. Prefer the declarative preset vocabulary (data-kenburns, data-transition, data-caption-animation) for compositions that round-trip through the web editor.`);