@office-iss/react-native-win32 0.75.2 → 0.76.0-preview.2

package/src/private/specs/modules/NativeLinkingManager.js

@@ -14,7 +14,7 @@ import * as TurboModuleRegistry from '../../../../Libraries/TurboModule/TurboMod
 
 export interface Spec extends TurboModule {
   // Common interface
-  +getInitialURL: () => Promise<string>;
+  +getInitialURL: () => Promise<?string>;
   +canOpenURL: (url: string) => Promise<boolean>;
   +openURL: (url: string) => Promise<void>;
   +openSettings: () => Promise<void>;

package/src/private/specs/modules/NativePlatformConstantsWin.js

@@ -12,6 +12,13 @@ import type {TurboModule} from '../../../../Libraries/TurboModule/RCTExport';
 
 import * as TurboModuleRegistry from '../../../../Libraries/TurboModule/TurboModuleRegistry';
 
+export type ReactNativeVersionAndroid = {|
+  major: number,
+  minor: number,
+  patch: number,
+  prerelease: ?string,
+|};
+
 export type PlatformConstantsWin32 = {|
   isTesting: boolean,
   isDisableAnimations?: boolean,

package/src/private/specs/modules/NativeSampleTurboModule.js

@@ -12,7 +12,10 @@ import type {
   RootTag,
   TurboModule,
 } from '../../../../Libraries/TurboModule/RCTExport';
-import type {UnsafeObject} from '../../../../Libraries/Types/CodegenTypes';
+import type {
+  EventEmitter,
+  UnsafeObject,
+} from '../../../../Libraries/Types/CodegenTypes';
 
 import * as TurboModuleRegistry from '../../../../Libraries/TurboModule/TurboModuleRegistry';
 
@@ -21,7 +24,17 @@ export enum EnumInt {
   B = 42,
 }
 
+export type ObjectStruct = {
+  a: number,
+  b: string,
+  c?: ?string,
+};
+
 export interface Spec extends TurboModule {
+  +onPress: EventEmitter<void>;
+  +onClick: EventEmitter<string>;
+  +onChange: EventEmitter<ObjectStruct>;
+  +onSubmit: EventEmitter<ObjectStruct[]>;
   // Exported methods.
   +getConstants: () => {|
     const1: boolean,

package/src/private/webapis/dom/nodes/ReadOnlyNode.js

@@ -304,8 +304,10 @@ function setInstanceHandle(
 export function getShadowNode(node: ReadOnlyNode): ?ShadowNode {
   // Lazy import Fabric here to avoid DOM Node APIs classes from having side-effects.
   // With a static import we can't use these classes for Paper-only variants.
-  const ReactFabric = require('../../../../../Libraries/Renderer/shims/ReactFabric');
-  return ReactFabric.getNodeFromInternalInstanceHandle(getInstanceHandle(node));
+  const RendererProxy = require('../../../../../Libraries/ReactNative/RendererProxy');
+  return RendererProxy.getNodeFromInternalInstanceHandle(
+    getInstanceHandle(node),
+  );
 }
 
 export function getChildNodes(
@@ -349,9 +351,9 @@ export function getPublicInstanceFromInternalInstanceHandle(
 ): ?ReadOnlyNode {
   // Lazy import Fabric here to avoid DOM Node APIs classes from having side-effects.
   // With a static import we can't use these classes for Paper-only variants.
-  const ReactFabric = require('../../../../../Libraries/Renderer/shims/ReactFabric');
+  const RendererProxy = require('../../../../../Libraries/ReactNative/RendererProxy');
   const mixedPublicInstance =
-    ReactFabric.getPublicInstanceFromInternalInstanceHandle(instanceHandle);
+    RendererProxy.getPublicInstanceFromInternalInstanceHandle(instanceHandle);
   // $FlowExpectedError[incompatible-return] React defines public instances as "mixed" because it can't access the definition from React Native.
   return mixedPublicInstance;
 }

package/{Libraries/IntersectionObserver → src/private/webapis/intersectionobserver}/IntersectionObserver.js

@@ -13,7 +13,7 @@
 import type IntersectionObserverEntry from './IntersectionObserverEntry';
 import type {IntersectionObserverId} from './IntersectionObserverManager';
 
-import ReactNativeElement from '../../src/private/webapis/dom/nodes/ReactNativeElement';
+import ReactNativeElement from '../dom/nodes/ReactNativeElement';
 import * as IntersectionObserverManager from './IntersectionObserverManager';
 
 export type IntersectionObserverCallback = (
@@ -141,12 +141,14 @@ export default class IntersectionObserver {
       return;
     }
 
-    IntersectionObserverManager.observe({
+    const didStartObserving = IntersectionObserverManager.observe({
       intersectionObserverId: this._getOrCreateIntersectionObserverId(),
       target,
     });
 
-    this._observationTargets.add(target);
+    if (didStartObserving) {
+      this._observationTargets.add(target);
+    }
   }
 
   /**

package/{Libraries/IntersectionObserver → src/private/webapis/intersectionobserver}/IntersectionObserverEntry.js

@@ -10,10 +10,10 @@
 
 // flowlint unsafe-getters-setters:off
 
-import type ReactNativeElement from '../../src/private/webapis/dom/nodes/ReactNativeElement';
-import type {NativeIntersectionObserverEntry} from './NativeIntersectionObserver';
+import type ReactNativeElement from '../dom/nodes/ReactNativeElement';
+import type {NativeIntersectionObserverEntry} from './specs/NativeIntersectionObserver';
 
-import DOMRectReadOnly from '../../src/private/webapis/dom/geometry/DOMRectReadOnly';
+import DOMRectReadOnly from '../dom/geometry/DOMRectReadOnly';
 
 /**
  * The [`IntersectionObserverEntry`](https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserverEntry)

package/{Libraries/IntersectionObserver → src/private/webapis/intersectionobserver}/IntersectionObserverManager.js

@@ -18,20 +18,17 @@
  * the notifications together.
  */
 
-import type ReactNativeElement from '../../src/private/webapis/dom/nodes/ReactNativeElement';
+import type ReactNativeElement from '../dom/nodes/ReactNativeElement';
 import type IntersectionObserver, {
   IntersectionObserverCallback,
 } from './IntersectionObserver';
 import type IntersectionObserverEntry from './IntersectionObserverEntry';
 
-import {
-  getInstanceHandle,
-  getShadowNode,
-} from '../../src/private/webapis/dom/nodes/ReadOnlyNode';
-import * as Systrace from '../Performance/Systrace';
-import warnOnce from '../Utilities/warnOnce';
+import * as Systrace from '../../../../Libraries/Performance/Systrace';
+import warnOnce from '../../../../Libraries/Utilities/warnOnce';
+import {getInstanceHandle, getShadowNode} from '../dom/nodes/ReadOnlyNode';
 import {createIntersectionObserverEntry} from './IntersectionObserverEntry';
-import NativeIntersectionObserver from './NativeIntersectionObserver';
+import NativeIntersectionObserver from './specs/NativeIntersectionObserver';
 
 export type IntersectionObserverId = number;
 
@@ -119,10 +116,10 @@ export function observe({
 }: {
   intersectionObserverId: IntersectionObserverId,
   target: ReactNativeElement,
-}): void {
+}): boolean {
   if (NativeIntersectionObserver == null) {
     warnNoNativeIntersectionObserver();
-    return;
+    return false;
   }
 
   const registeredObserver = registeredIntersectionObservers.get(
@@ -132,15 +129,13 @@ export function observe({
     console.error(
       `IntersectionObserverManager: could not start observing target because IntersectionObserver with ID ${intersectionObserverId} was not registered.`,
     );
-    return;
+    return false;
   }
 
   const targetShadowNode = getShadowNode(target);
   if (targetShadowNode == null) {
-    console.error(
-      'IntersectionObserverManager: could not find reference to host node from target',
-    );
-    return;
+    // The target is disconnected. We can't observe it anymore.
+    return false;
   }
 
   const instanceHandle = getInstanceHandle(target);
@@ -148,7 +143,7 @@ export function observe({
     console.error(
       'IntersectionObserverManager: could not find reference to instance handle from target',
     );
-    return;
+    return false;
   }
 
   // Store the mapping between the instance handle and the target so we can
@@ -163,11 +158,13 @@ export function observe({
     isConnected = true;
   }
 
-  return NativeIntersectionObserver.observe({
+  NativeIntersectionObserver.observe({
     intersectionObserverId,
     targetShadowNode,
     thresholds: registeredObserver.observer.thresholds,
   });
+
+  return true;
 }
 
 export function unobserve(

package/src/private/{specs/modules → webapis/intersectionobserver/specs}/NativeIntersectionObserver.js

@@ -8,9 +8,9 @@
  * @format
  */
 
-import type {TurboModule} from '../../../../Libraries/TurboModule/RCTExport';
+import type {TurboModule} from '../../../../../Libraries/TurboModule/RCTExport';
 
-import * as TurboModuleRegistry from '../../../../Libraries/TurboModule/TurboModuleRegistry';
+import * as TurboModuleRegistry from '../../../../../Libraries/TurboModule/TurboModuleRegistry';
 
 export type NativeIntersectionObserverEntry = {
   intersectionObserverId: number,

package/{Libraries/IntersectionObserver → src/private/webapis/intersectionobserver/specs}/__mocks__/NativeIntersectionObserver.js

@@ -8,16 +8,16 @@
  * @format
  */
 
-import type ReactNativeElement from '../../../src/private/webapis/dom/nodes/ReactNativeElement';
-import type IntersectionObserver from '../IntersectionObserver';
+import type ReactNativeElement from '../../../dom/nodes/ReactNativeElement';
+import type IntersectionObserver from '../../IntersectionObserver';
 import type {
   NativeIntersectionObserverEntry,
   NativeIntersectionObserverObserveOptions,
   Spec,
 } from '../NativeIntersectionObserver';
 
-import {getShadowNode} from '../../../src/private/webapis/dom/nodes/ReadOnlyNode';
-import {getFabricUIManager} from '../../ReactNative/__mocks__/FabricUIManager';
+import {getFabricUIManager} from '../../../../../../Libraries/ReactNative/__mocks__/FabricUIManager';
+import {getShadowNode} from '../../../dom/nodes/ReadOnlyNode';
 import invariant from 'invariant';
 import nullthrows from 'nullthrows';
 

package/{Libraries/MutationObserver → src/private/webapis/mutationobserver}/MutationObserver.js

@@ -13,7 +13,7 @@
 import type {MutationObserverId} from './MutationObserverManager';
 import type MutationRecord from './MutationRecord';
 
-import ReactNativeElement from '../../src/private/webapis/dom/nodes/ReactNativeElement';
+import ReactNativeElement from '../dom/nodes/ReactNativeElement';
 import * as MutationObserverManager from './MutationObserverManager';
 
 export type MutationObserverCallback = (
@@ -121,13 +121,15 @@ export default class MutationObserver {
       MutationObserverManager.unobserve(mutationObserverId, target);
     }
 
-    MutationObserverManager.observe({
+    const didStartObserving = MutationObserverManager.observe({
       mutationObserverId,
       target,
       subtree: Boolean(options?.subtree),
     });
 
-    this._observationTargets.add(target);
+    if (didStartObserving) {
+      this._observationTargets.add(target);
+    }
   }
 
   _unobserve(target: ReactNativeElement): void {

package/{Libraries/MutationObserver → src/private/webapis/mutationobserver}/MutationObserverManager.js

@@ -18,20 +18,20 @@
  * the notifications together.
  */
 
-import type ReactNativeElement from '../../src/private/webapis/dom/nodes/ReactNativeElement';
+import type ReactNativeElement from '../dom/nodes/ReactNativeElement';
 import type MutationObserver, {
   MutationObserverCallback,
 } from './MutationObserver';
 import type MutationRecord from './MutationRecord';
 
+import * as Systrace from '../../../../Libraries/Performance/Systrace';
+import warnOnce from '../../../../Libraries/Utilities/warnOnce';
 import {
   getPublicInstanceFromInternalInstanceHandle,
   getShadowNode,
-} from '../../src/private/webapis/dom/nodes/ReadOnlyNode';
-import * as Systrace from '../Performance/Systrace';
-import warnOnce from '../Utilities/warnOnce';
+} from '../dom/nodes/ReadOnlyNode';
 import {createMutationRecord} from './MutationRecord';
-import NativeMutationObserver from './NativeMutationObserver';
+import NativeMutationObserver from './specs/NativeMutationObserver';
 
 export type MutationObserverId = number;
 
@@ -43,6 +43,13 @@ const registeredMutationObservers: Map<
   $ReadOnly<{observer: MutationObserver, callback: MutationObserverCallback}>,
 > = new Map();
 
+// The mapping between ReactNativeElement and their corresponding shadow node
+// needs to be kept here because React removes the link when unmounting.
+const targetToShadowNodeMap: WeakMap<
+  ReactNativeElement,
+  ReturnType<typeof getShadowNode>,
+> = new WeakMap();
+
 /**
  * Registers the given mutation observer and returns a unique ID for it,
  * which is required to start observing targets.
@@ -85,10 +92,10 @@ export function observe({
   mutationObserverId: MutationObserverId,
   target: ReactNativeElement,
   subtree: boolean,
-}): void {
+}): boolean {
   if (NativeMutationObserver == null) {
     warnNoNativeMutationObserver();
-    return;
+    return false;
   }
 
   const registeredObserver =
@@ -97,17 +104,17 @@ export function observe({
     console.error(
       `MutationObserverManager: could not start observing target because MutationObserver with ID ${mutationObserverId} was not registered.`,
     );
-    return;
+    return false;
   }
 
   const targetShadowNode = getShadowNode(target);
   if (targetShadowNode == null) {
-    console.error(
-      'MutationObserverManager: could not find reference to host node from target',
-    );
-    return;
+    // The target is disconnected. We can't observe it anymore.
+    return false;
   }
 
+  targetToShadowNodeMap.set(target, targetShadowNode);
+
   if (!isConnected) {
     NativeMutationObserver.connect(
       notifyMutationObservers,
@@ -121,11 +128,13 @@ export function observe({
     isConnected = true;
   }
 
-  return NativeMutationObserver.observe({
+  NativeMutationObserver.observe({
     mutationObserverId,
     targetShadowNode,
     subtree,
   });
+
+  return true;
 }
 
 export function unobserve(
@@ -146,10 +155,10 @@ export function unobserve(
     return;
   }
 
-  const targetShadowNode = getShadowNode(target);
+  const targetShadowNode = targetToShadowNodeMap.get(target);
   if (targetShadowNode == null) {
     console.error(
-      'MutationObserverManager: could not find reference to host node from target',
+      'MutationObserverManager: could not find registration data for target',
     );
     return;
   }

package/{Libraries/MutationObserver → src/private/webapis/mutationobserver}/MutationRecord.js

@@ -10,13 +10,11 @@
 
 // flowlint unsafe-getters-setters:off
 
-import type ReactNativeElement from '../../src/private/webapis/dom/nodes/ReactNativeElement';
-import type ReadOnlyNode from '../../src/private/webapis/dom/nodes/ReadOnlyNode';
-import type {NativeMutationRecord} from './NativeMutationObserver';
+import type ReactNativeElement from '../dom/nodes/ReactNativeElement';
+import type ReadOnlyNode from '../dom/nodes/ReadOnlyNode';
+import type {NativeMutationRecord} from './specs/NativeMutationObserver';
 
-import NodeList, {
-  createNodeList,
-} from '../../src/private/webapis/dom/oldstylecollections/NodeList';
+import NodeList, {createNodeList} from '../dom/oldstylecollections/NodeList';
 
 export type MutationType = 'attributes' | 'characterData' | 'childList';
 

package/src/private/{specs/modules → webapis/mutationobserver/specs}/NativeMutationObserver.js

@@ -8,9 +8,9 @@
  * @format
  */
 
-import type {TurboModule} from '../../../../Libraries/TurboModule/RCTExport';
+import type {TurboModule} from '../../../../../Libraries/TurboModule/RCTExport';
 
-import * as TurboModuleRegistry from '../../../../Libraries/TurboModule/TurboModuleRegistry';
+import * as TurboModuleRegistry from '../../../../../Libraries/TurboModule/TurboModuleRegistry';
 
 export type MutationObserverId = number;
 

package/{Libraries/MutationObserver → src/private/webapis/mutationobserver/specs}/__mocks__/NativeMutationObserver.js

@@ -15,12 +15,12 @@
  * JavaScript as an integration test using only public APIs.
  */
 
-import type {NodeSet} from '../../ReactNative/FabricUIManager';
-import type {RootTag} from '../../ReactNative/RootTag';
+import type {NodeSet} from '../../../../../../Libraries/ReactNative/FabricUIManager';
+import type {RootTag} from '../../../../../../Libraries/ReactNative/RootTag';
 import type {
   InternalInstanceHandle,
   Node,
-} from '../../Renderer/shims/ReactNativeTypes';
+} from '../../../../../../Libraries/Renderer/shims/ReactNativeTypes';
 import type {
   MutationObserverId,
   NativeMutationObserverObserveOptions,
@@ -28,14 +28,14 @@ import type {
   Spec,
 } from '../NativeMutationObserver';
 
-import ReadOnlyNode from '../../../src/private/webapis/dom/nodes/ReadOnlyNode';
 import {
   type NodeMock,
   type UIManagerCommitHook,
   fromNode,
   getFabricUIManager,
   getNodeInChildSet,
-} from '../../ReactNative/__mocks__/FabricUIManager';
+} from '../../../../../../Libraries/ReactNative/__mocks__/FabricUIManager';
+import ReadOnlyNode from '../../../dom/nodes/ReadOnlyNode';
 import invariant from 'invariant';
 import nullthrows from 'nullthrows';
 

package/src/private/webapis/performance/{EventCounts.js → EventTiming.js}

@@ -4,13 +4,75 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow strict
  * @format
+ * @flow strict
  */
 
+// flowlint unsafe-getters-setters:off
+
+import type {
+  DOMHighResTimeStamp,
+  PerformanceEntryJSON,
+} from './PerformanceEntry';
+
+import {PerformanceEntry} from './PerformanceEntry';
 import {warnNoNativePerformanceObserver} from './PerformanceObserver';
 import NativePerformanceObserver from './specs/NativePerformanceObserver';
 
+export type PerformanceEventTimingJSON = {
+  ...PerformanceEntryJSON,
+  processingStart: DOMHighResTimeStamp,
+  processingEnd: DOMHighResTimeStamp,
+  interactionId: number,
+  ...
+};
+
+export class PerformanceEventTiming extends PerformanceEntry {
+  #processingStart: DOMHighResTimeStamp;
+  #processingEnd: DOMHighResTimeStamp;
+  #interactionId: number;
+
+  constructor(init: {
+    name: string,
+    startTime?: DOMHighResTimeStamp,
+    duration?: DOMHighResTimeStamp,
+    processingStart?: DOMHighResTimeStamp,
+    processingEnd?: DOMHighResTimeStamp,
+    interactionId?: number,
+  }) {
+    super({
+      name: init.name,
+      entryType: 'event',
+      startTime: init.startTime ?? 0,
+      duration: init.duration ?? 0,
+    });
+    this.#processingStart = init.processingStart ?? 0;
+    this.#processingEnd = init.processingEnd ?? 0;
+    this.#interactionId = init.interactionId ?? 0;
+  }
+
+  get processingStart(): DOMHighResTimeStamp {
+    return this.#processingStart;
+  }
+
+  get processingEnd(): DOMHighResTimeStamp {
+    return this.#processingEnd;
+  }
+
+  get interactionId(): number {
+    return this.#interactionId;
+  }
+
+  toJSON(): PerformanceEventTimingJSON {
+    return {
+      ...super.toJSON(),
+      processingStart: this.#processingStart,
+      processingEnd: this.#processingEnd,
+      interactionId: this.#interactionId,
+    };
+  }
+}
+
 type EventCountsForEachCallbackType =
   | (() => void)
   | ((value: number) => void)
@@ -41,13 +103,13 @@ function getCachedEventCounts(): Map<string, number> {
   });
   return cachedEventCounts ?? new Map();
 }
+
 /**
  * Implementation of the EventCounts Web Performance API
  * corresponding to the standard in
  * https://www.w3.org/TR/event-timing/#eventcounts
  */
-export default class EventCounts {
-  // flowlint unsafe-getters-setters:off
+export class EventCounts {
   get size(): number {
     return getCachedEventCounts().size;
   }

package/src/private/webapis/performance/LongTasks.js

@@ -0,0 +1,39 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ * @flow strict
+ */
+
+// flowlint unsafe-getters-setters:off
+
+import type {PerformanceEntryJSON} from './PerformanceEntry';
+
+import {PerformanceEntry} from './PerformanceEntry';
+
+export type PerformanceLongTaskTimingJSON = {
+  ...PerformanceEntryJSON,
+  attribution: $ReadOnlyArray<TaskAttributionTiming>,
+  ...
+};
+
+export class TaskAttributionTiming extends PerformanceEntry {}
+
+const EMPTY_ATTRIBUTION: $ReadOnlyArray<TaskAttributionTiming> =
+  Object.preventExtensions([]);
+
+export class PerformanceLongTaskTiming extends PerformanceEntry {
+  get attribution(): $ReadOnlyArray<TaskAttributionTiming> {
+    return EMPTY_ATTRIBUTION;
+  }
+
+  toJSON(): PerformanceLongTaskTimingJSON {
+    return {
+      ...super.toJSON(),
+      attribution: this.attribution,
+    };
+  }
+}

package/src/private/webapis/performance/Performance.js

@@ -10,15 +10,15 @@
 
 // flowlint unsafe-getters-setters:off
 
-import type {HighResTimeStamp, PerformanceEntryType} from './PerformanceEntry';
-import type {PerformanceEntryList} from './PerformanceObserver';
 import type {
-  PerformanceMarkOptions,
-  PerformanceMeasureOptions,
-} from './UserTiming';
+  DOMHighResTimeStamp,
+  PerformanceEntryType,
+} from './PerformanceEntry';
+import type {PerformanceEntryList} from './PerformanceObserver';
+import type {DetailType, PerformanceMarkOptions} from './UserTiming';
 
 import warnOnce from '../../../../Libraries/Utilities/warnOnce';
-import EventCounts from './EventCounts';
+import {EventCounts} from './EventTiming';
 import MemoryInfo from './MemoryInfo';
 import {ALWAYS_LOGGED_ENTRY_TYPES} from './PerformanceEntry';
 import {warnNoNativePerformanceObserver} from './PerformanceObserver';
@@ -37,7 +37,7 @@ declare var global: {
   +nativePerformanceNow?: ?() => number,
 };
 
-const getCurrentTimeStamp: () => HighResTimeStamp =
+const getCurrentTimeStamp: () => DOMHighResTimeStamp =
   NativePerformance?.now ?? global.nativePerformanceNow ?? (() => Date.now());
 
 // We want some of the performance entry types to be always logged,
@@ -58,6 +58,13 @@ function warnNoNativePerformance() {
   );
 }
 
+export type PerformanceMeasureOptions = {
+  detail?: DetailType,
+  start?: DOMHighResTimeStamp,
+  duration?: DOMHighResTimeStamp,
+  end?: DOMHighResTimeStamp,
+};
+
 /**
  * Partial implementation of the Performance interface for RN,
  * corresponding to the standard in
@@ -195,7 +202,13 @@ export default class Performance {
       duration = options.duration ?? duration;
     }
 
-    const measure = new PerformanceMeasure(measureName, options);
+    const measure = new PerformanceMeasure(measureName, {
+      // FIXME(T196011255): this is incorrect, as we're only assigning the
+      // start/end if they're specified as a number, but not if they're
+      // specified as previous mark names.
+      startTime,
+      duration,
+    });
 
     if (NativePerformance?.measure) {
       NativePerformance.measure(
@@ -229,7 +242,7 @@ export default class Performance {
    * Returns a double, measured in milliseconds.
    * https://developer.mozilla.org/en-US/docs/Web/API/Performance/now
    */
-  now(): HighResTimeStamp {
+  now(): DOMHighResTimeStamp {
     return getCurrentTimeStamp();
   }