@office-ai/aioncli-core 0.26.0 → 0.30.1

package/dist/src/tools/glob.test.js

@@ -6,6 +6,7 @@
 import { GlobTool, sortFileEntries } from './glob.js';
 import { partListUnionToString } from '../core/geminiRequest.js';
 import path from 'node:path';
+import { isSubpath } from '../utils/paths.js';
 import fs from 'node:fs/promises';
 import os from 'node:os';
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
@@ -14,29 +15,47 @@ import { createMockWorkspaceContext } from '../test-utils/mockWorkspaceContext.j
 import { ToolErrorType } from './tool-error.js';
 import * as glob from 'glob';
 import { createMockMessageBus } from '../test-utils/mock-message-bus.js';
+import { DEFAULT_FILE_FILTERING_OPTIONS, GEMINI_IGNORE_FILE_NAME, } from '../config/constants.js';
 vi.mock('glob', { spy: true });
 describe('GlobTool', () => {
     let tempRootDir; // This will be the rootDirectory for the GlobTool instance
     let globTool;
     const abortSignal = new AbortController().signal;
-    // Mock config for testing
-    const mockConfig = {
-        getFileService: () => new FileDiscoveryService(tempRootDir),
-        getFileFilteringRespectGitIgnore: () => true,
-        getFileFilteringOptions: () => ({
-            respectGitIgnore: true,
-            respectGeminiIgnore: true,
-        }),
-        getTargetDir: () => tempRootDir,
-        getWorkspaceContext: () => createMockWorkspaceContext(tempRootDir),
-        getFileExclusions: () => ({
-            getGlobExcludes: () => [],
-        }),
-    };
+    let mockConfig;
     beforeEach(async () => {
         // Create a unique root directory for each test run
         tempRootDir = await fs.mkdtemp(path.join(os.tmpdir(), 'glob-tool-root-'));
         await fs.writeFile(path.join(tempRootDir, '.git'), ''); // Fake git repo
+        const rootDir = tempRootDir;
+        const workspaceContext = createMockWorkspaceContext(rootDir);
+        const fileDiscovery = new FileDiscoveryService(rootDir);
+        const mockStorage = {
+            getProjectTempDir: vi.fn().mockReturnValue('/tmp/project'),
+        };
+        mockConfig = {
+            getTargetDir: () => rootDir,
+            getWorkspaceContext: () => workspaceContext,
+            getFileService: () => fileDiscovery,
+            getFileFilteringOptions: () => DEFAULT_FILE_FILTERING_OPTIONS,
+            getFileExclusions: () => ({ getGlobExcludes: () => [] }),
+            storage: mockStorage,
+            isPathAllowed(absolutePath) {
+                const workspaceContext = this.getWorkspaceContext();
+                if (workspaceContext.isPathWithinWorkspace(absolutePath)) {
+                    return true;
+                }
+                const projectTempDir = this.storage.getProjectTempDir();
+                return isSubpath(path.resolve(projectTempDir), absolutePath);
+            },
+            validatePathAccess(absolutePath) {
+                if (this.isPathAllowed(absolutePath)) {
+                    return null;
+                }
+                const workspaceDirs = this.getWorkspaceContext().getDirectories();
+                const projectTempDir = this.storage.getProjectTempDir();
+                return `Path not in workspace: Attempted path "${absolutePath}" resolves outside the allowed workspace directories: ${workspaceDirs.join(', ')} or the project temp directory: ${projectTempDir}`;
+            },
+        };
         globTool = new GlobTool(mockConfig, createMockMessageBus());
         // Create some test files and directories within this root
         // Top-level files
@@ -58,6 +77,7 @@ describe('GlobTool', () => {
     afterEach(async () => {
         // Clean up the temporary root directory
         await fs.rm(tempRootDir, { recursive: true, force: true });
+        vi.resetAllMocks();
     });
     describe('execute', () => {
         it('should find files matching a simple pattern in the root', async () => {
@@ -68,7 +88,7 @@ describe('GlobTool', () => {
             expect(result.llmContent).toContain(path.join(tempRootDir, 'fileA.txt'));
             expect(result.llmContent).toContain(path.join(tempRootDir, 'FileB.TXT'));
             expect(result.returnDisplay).toBe('Found 2 matching file(s)');
-        });
+        }, 30000);
         it('should find files case-sensitively when case_sensitive is true', async () => {
             const params = { pattern: '*.txt', case_sensitive: true };
             const invocation = globTool.build(params);
@@ -76,15 +96,14 @@ describe('GlobTool', () => {
             expect(result.llmContent).toContain('Found 1 file(s)');
             expect(result.llmContent).toContain(path.join(tempRootDir, 'fileA.txt'));
             expect(result.llmContent).not.toContain(path.join(tempRootDir, 'FileB.TXT'));
-        });
+        }, 30000);
         it('should find files case-insensitively by default (pattern: *.TXT)', async () => {
             const params = { pattern: '*.TXT' };
             const invocation = globTool.build(params);
             const result = await invocation.execute(abortSignal);
-            expect(result.llmContent).toContain('Found 2 file(s)');
-            expect(result.llmContent).toContain(path.join(tempRootDir, 'fileA.txt'));
-            expect(result.llmContent).toContain(path.join(tempRootDir, 'FileB.TXT'));
-        });
+            expect(result.llmContent).toContain('fileA.txt');
+            expect(result.llmContent).toContain('FileB.TXT');
+        }, 30000);
         it('should find files case-insensitively when case_sensitive is false (pattern: *.TXT)', async () => {
             const params = {
                 pattern: '*.TXT',
@@ -95,7 +114,7 @@ describe('GlobTool', () => {
             expect(result.llmContent).toContain('Found 2 file(s)');
             expect(result.llmContent).toContain(path.join(tempRootDir, 'fileA.txt'));
             expect(result.llmContent).toContain(path.join(tempRootDir, 'FileB.TXT'));
-        });
+        }, 30000);
         it('should find files using a pattern that includes a subdirectory', async () => {
             const params = { pattern: 'sub/*.md' };
             const invocation = globTool.build(params);
@@ -103,7 +122,7 @@ describe('GlobTool', () => {
             expect(result.llmContent).toContain('Found 2 file(s)');
             expect(result.llmContent).toContain(path.join(tempRootDir, 'sub', 'fileC.md'));
             expect(result.llmContent).toContain(path.join(tempRootDir, 'sub', 'FileD.MD'));
-        });
+        }, 30000);
         it('should find files in a specified relative path (relative to rootDir)', async () => {
             const params = { pattern: '*.md', dir_path: 'sub' };
             const invocation = globTool.build(params);
@@ -111,21 +130,21 @@ describe('GlobTool', () => {
             expect(result.llmContent).toContain('Found 2 file(s)');
             expect(result.llmContent).toContain(path.join(tempRootDir, 'sub', 'fileC.md'));
             expect(result.llmContent).toContain(path.join(tempRootDir, 'sub', 'FileD.MD'));
-        });
+        }, 30000);
         it('should find files using a deep globstar pattern (e.g., **/*.log)', async () => {
             const params = { pattern: '**/*.log' };
             const invocation = globTool.build(params);
             const result = await invocation.execute(abortSignal);
             expect(result.llmContent).toContain('Found 1 file(s)');
             expect(result.llmContent).toContain(path.join(tempRootDir, 'sub', 'deep', 'fileE.log'));
-        });
+        }, 30000);
         it('should return "No files found" message when pattern matches nothing', async () => {
             const params = { pattern: '*.nonexistent' };
             const invocation = globTool.build(params);
             const result = await invocation.execute(abortSignal);
             expect(result.llmContent).toContain('No files found matching pattern "*.nonexistent"');
             expect(result.returnDisplay).toBe('No files found');
-        });
+        }, 30000);
         it('should find files with special characters in the name', async () => {
             await fs.writeFile(path.join(tempRootDir, 'file[1].txt'), 'content');
             const params = { pattern: 'file[1].txt' };
@@ -133,7 +152,7 @@ describe('GlobTool', () => {
             const result = await invocation.execute(abortSignal);
             expect(result.llmContent).toContain('Found 1 file(s)');
             expect(result.llmContent).toContain(path.join(tempRootDir, 'file[1].txt'));
-        });
+        }, 30000);
         it('should find files with special characters like [] and () in the path', async () => {
             const filePath = path.join(tempRootDir, 'src/app/[test]/(dashboard)/testing/components/code.tsx');
             await fs.mkdir(path.dirname(filePath), { recursive: true });
@@ -145,290 +164,210 @@ describe('GlobTool', () => {
             const result = await invocation.execute(abortSignal);
             expect(result.llmContent).toContain('Found 1 file(s)');
             expect(result.llmContent).toContain(filePath);
-        });
+        }, 30000);
         it('should correctly sort files by modification time (newest first)', async () => {
             const params = { pattern: '*.sortme' };
             const invocation = globTool.build(params);
             const result = await invocation.execute(abortSignal);
             const llmContent = partListUnionToString(result.llmContent);
-            expect(llmContent).toContain('Found 2 file(s)');
-            // Ensure llmContent is a string for TypeScript type checking
-            expect(typeof llmContent).toBe('string');
-            const filesListed = llmContent
-                .trim()
-                .split(/\r?\n/)
-                .slice(1)
-                .map((line) => line.trim())
-                .filter(Boolean);
-            expect(filesListed).toHaveLength(2);
-            expect(path.resolve(filesListed[0])).toBe(path.resolve(tempRootDir, 'newer.sortme'));
-            expect(path.resolve(filesListed[1])).toBe(path.resolve(tempRootDir, 'older.sortme'));
-        });
+            const newerIndex = llmContent.indexOf('newer.sortme');
+            const olderIndex = llmContent.indexOf('older.sortme');
+            expect(newerIndex).toBeLessThan(olderIndex);
+        }, 30000);
         it('should return a PATH_NOT_IN_WORKSPACE error if path is outside workspace', async () => {
-            // Bypassing validation to test execute method directly
-            vi.spyOn(globTool, 'validateToolParams').mockReturnValue(null);
-            const params = { pattern: '*.txt', dir_path: '/etc' };
-            const invocation = globTool.build(params);
-            const result = await invocation.execute(abortSignal);
-            expect(result.error?.type).toBe(ToolErrorType.PATH_NOT_IN_WORKSPACE);
-            expect(result.returnDisplay).toBe('Path is not within workspace');
+            const params = { pattern: '*', dir_path: '/etc' };
+            expect(() => globTool.build(params)).toThrow(/Path not in workspace/);
         });
         it('should return a GLOB_EXECUTION_ERROR on glob failure', async () => {
             vi.mocked(glob.glob).mockRejectedValue(new Error('Glob failed'));
-            const params = { pattern: '*.txt' };
+            const params = { pattern: '*' };
             const invocation = globTool.build(params);
             const result = await invocation.execute(abortSignal);
             expect(result.error?.type).toBe(ToolErrorType.GLOB_EXECUTION_ERROR);
-            expect(result.llmContent).toContain('Error during glob search operation: Glob failed');
-            // Reset glob.
-            vi.mocked(glob.glob).mockReset();
-        });
+        }, 30000);
     });
     describe('validateToolParams', () => {
-        it.each([
-            {
-                name: 'should return null for valid parameters (pattern only)',
-                params: { pattern: '*.js' },
-                expected: null,
-            },
-            {
-                name: 'should return null for valid parameters (pattern and dir_path)',
-                params: { pattern: '*.js', dir_path: 'sub' },
-                expected: null,
-            },
-            {
-                name: 'should return null for valid parameters (pattern, dir_path, and case_sensitive)',
-                params: { pattern: '*.js', dir_path: 'sub', case_sensitive: true },
-                expected: null,
-            },
-            {
-                name: 'should return error if pattern is missing (schema validation)',
-                params: { dir_path: '.' },
-                expected: `params must have required property 'pattern'`,
-            },
-            {
-                name: 'should return error if pattern is an empty string',
-                params: { pattern: '' },
-                expected: "The 'pattern' parameter cannot be empty.",
-            },
-            {
-                name: 'should return error if pattern is only whitespace',
-                params: { pattern: '   ' },
-                expected: "The 'pattern' parameter cannot be empty.",
-            },
-            {
-                name: 'should return error if dir_path is not a string (schema validation)',
-                params: { pattern: '*.ts', dir_path: 123 },
-                expected: 'params/dir_path must be string',
-            },
-            {
-                name: 'should return error if case_sensitive is not a boolean (schema validation)',
-                params: { pattern: '*.ts', case_sensitive: 'true' },
-                expected: 'params/case_sensitive must be boolean',
-            },
-            {
-                name: "should return error if search path resolves outside the tool's root directory",
-                params: {
-                    pattern: '*.txt',
-                    dir_path: '../../../../../../../../../../tmp',
-                },
-                expected: 'resolves outside the allowed workspace directories',
-            },
-            {
-                name: 'should return error if specified search path does not exist',
-                params: { pattern: '*.txt', dir_path: 'nonexistent_subdir' },
-                expected: 'Search path does not exist',
-            },
-            {
-                name: 'should return error if specified search path is a file, not a directory',
-                params: { pattern: '*.txt', dir_path: 'fileA.txt' },
-                expected: 'Search path is not a directory',
-            },
-        ])('$name', ({ params, expected }) => {
-            // @ts-expect-error - We're intentionally creating invalid params for testing
-            const result = globTool.validateToolParams(params);
-            if (expected === null) {
-                expect(result).toBeNull();
-            }
-            else {
-                expect(result).toContain(expected);
-            }
+        it('should return null for valid parameters', () => {
+            const params = { pattern: '*.txt' };
+            expect(globTool.validateToolParams(params)).toBeNull();
+        });
+        it('should return null for valid parameters with dir_path', () => {
+            const params = { pattern: '*.txt', dir_path: 'sub' };
+            expect(globTool.validateToolParams(params)).toBeNull();
+        });
+        it('should return null for valid parameters with absolute dir_path within workspace', async () => {
+            const params = {
+                pattern: '*.txt',
+                dir_path: tempRootDir,
+            };
+            expect(globTool.validateToolParams(params)).toBeNull();
+        });
+        it('should return error if pattern is missing', () => {
+            const params = {};
+            expect(globTool.validateToolParams(params)).toContain("params must have required property 'pattern'");
+        });
+        it('should return error if pattern is an empty string', () => {
+            const params = { pattern: '' };
+            expect(globTool.validateToolParams(params)).toContain("The 'pattern' parameter cannot be empty");
+        });
+        it('should return error if pattern is only whitespace', () => {
+            const params = { pattern: '   ' };
+            expect(globTool.validateToolParams(params)).toContain("The 'pattern' parameter cannot be empty");
+        });
+        it('should return error if dir_path is not a string', () => {
+            const params = {
+                pattern: '*',
+                dir_path: 123,
+            };
+            expect(globTool.validateToolParams(params)).toContain('params/dir_path must be string');
+        });
+        it('should return error if case_sensitive is not a boolean', () => {
+            const params = {
+                pattern: '*',
+                case_sensitive: 'true',
+            };
+            expect(globTool.validateToolParams(params)).toContain('params/case_sensitive must be boolean');
+        });
+        it('should return error if search path resolves outside workspace', () => {
+            const params = { pattern: '*', dir_path: '../' };
+            expect(globTool.validateToolParams(params)).toContain('resolves outside the allowed workspace directories');
+        });
+        it('should return error if specified search path does not exist', () => {
+            const params = {
+                pattern: '*',
+                dir_path: 'non-existent',
+            };
+            expect(globTool.validateToolParams(params)).toContain('Search path does not exist');
+        });
+        it('should return error if specified search path is not a directory', async () => {
+            await fs.writeFile(path.join(tempRootDir, 'not-a-dir'), 'content');
+            const params = { pattern: '*', dir_path: 'not-a-dir' };
+            expect(globTool.validateToolParams(params)).toContain('Search path is not a directory');
         });
     });
     describe('workspace boundary validation', () => {
         it('should validate search paths are within workspace boundaries', () => {
-            const validPath = { pattern: '*.ts', dir_path: 'sub' };
-            const invalidPath = { pattern: '*.ts', dir_path: '../..' };
-            expect(globTool.validateToolParams(validPath)).toBeNull();
-            expect(globTool.validateToolParams(invalidPath)).toContain('resolves outside the allowed workspace directories');
+            expect(globTool.validateToolParams({ pattern: '*' })).toBeNull();
+            expect(globTool.validateToolParams({ pattern: '*', dir_path: '.' })).toBeNull();
+            expect(globTool.validateToolParams({ pattern: '*', dir_path: tempRootDir })).toBeNull();
+            expect(globTool.validateToolParams({ pattern: '*', dir_path: '..' })).toContain('resolves outside the allowed workspace directories');
+            expect(globTool.validateToolParams({ pattern: '*', dir_path: '/' })).toContain('resolves outside the allowed workspace directories');
         });
         it('should provide clear error messages when path is outside workspace', () => {
-            const invalidPath = { pattern: '*.ts', dir_path: '/etc' };
-            const error = globTool.validateToolParams(invalidPath);
-            expect(error).toContain('resolves outside the allowed workspace directories');
-            expect(error).toContain(tempRootDir);
+            const result = globTool.validateToolParams({
+                pattern: '*',
+                dir_path: '/tmp/outside',
+            });
+            expect(result).toContain('resolves outside the allowed workspace directories');
         });
         it('should work with paths in workspace subdirectories', async () => {
-            const params = { pattern: '*.md', dir_path: 'sub' };
-            const invocation = globTool.build(params);
-            const result = await invocation.execute(abortSignal);
-            expect(result.llmContent).toContain('Found 2 file(s)');
-            expect(result.llmContent).toContain('fileC.md');
-            expect(result.llmContent).toContain('FileD.MD');
+            const subDir = path.join(tempRootDir, 'allowed-sub');
+            await fs.mkdir(subDir);
+            expect(globTool.validateToolParams({ pattern: '*', dir_path: 'allowed-sub' })).toBeNull();
         });
     });
     describe('ignore file handling', () => {
-        it.each([
-            {
-                name: 'should respect .gitignore files by default',
-                ignoreFile: { name: '.gitignore', content: '*.ignored.txt' },
-                filesToCreate: ['a.ignored.txt', 'b.notignored.txt'],
-                globToolParams: { pattern: '*.txt' },
-                expectedCountMessage: 'Found 3 file(s)',
-                notExpectedToContain: ['a.ignored.txt'],
-            },
-            {
-                name: 'should respect .geminiignore files by default',
-                ignoreFile: { name: '.geminiignore', content: '*.geminiignored.txt' },
-                filesToCreate: ['a.geminiignored.txt', 'b.notignored.txt'],
-                globToolParams: { pattern: '*.txt' },
-                expectedCountMessage: 'Found 3 file(s)',
-                notExpectedToContain: ['a.geminiignored.txt'],
-            },
-            {
-                name: 'should not respect .gitignore when respect_git_ignore is false',
-                ignoreFile: { name: '.gitignore', content: '*.ignored.txt' },
-                filesToCreate: ['a.ignored.txt'],
-                globToolParams: { pattern: '*.txt', respect_git_ignore: false },
-                expectedCountMessage: 'Found 3 file(s)',
-                expectedToContain: ['a.ignored.txt'],
-            },
-            {
-                name: 'should not respect .geminiignore when respect_gemini_ignore is false',
-                ignoreFile: { name: '.geminiignore', content: '*.geminiignored.txt' },
-                filesToCreate: ['a.geminiignored.txt'],
-                globToolParams: { pattern: '*.txt', respect_gemini_ignore: false },
-                expectedCountMessage: 'Found 3 file(s)',
-                expectedToContain: ['a.geminiignored.txt'],
-            },
-        ])('$name', async ({ ignoreFile, filesToCreate, globToolParams, expectedCountMessage, expectedToContain, notExpectedToContain, }) => {
-            await fs.writeFile(path.join(tempRootDir, ignoreFile.name), ignoreFile.content);
-            for (const file of filesToCreate) {
-                await fs.writeFile(path.join(tempRootDir, file), 'content');
-            }
-            const invocation = globTool.build(globToolParams);
+        it('should respect .gitignore files by default', async () => {
+            await fs.writeFile(path.join(tempRootDir, '.gitignore'), 'ignored_test.txt');
+            await fs.writeFile(path.join(tempRootDir, 'ignored_test.txt'), 'content');
+            await fs.writeFile(path.join(tempRootDir, 'visible_test.txt'), 'content');
+            const params = { pattern: '*_test.txt' };
+            const invocation = globTool.build(params);
             const result = await invocation.execute(abortSignal);
-            expect(result.llmContent).toContain(expectedCountMessage);
-            if (expectedToContain) {
-                for (const file of expectedToContain) {
-                    expect(result.llmContent).toContain(file);
-                }
-            }
-            if (notExpectedToContain) {
-                for (const file of notExpectedToContain) {
-                    expect(result.llmContent).not.toContain(file);
-                }
-            }
-        });
+            expect(result.llmContent).toContain('Found 1 file(s)');
+            expect(result.llmContent).toContain('visible_test.txt');
+            expect(result.llmContent).not.toContain('ignored_test.txt');
+        }, 30000);
+        it('should respect .geminiignore files by default', async () => {
+            await fs.writeFile(path.join(tempRootDir, GEMINI_IGNORE_FILE_NAME), 'gemini-ignored_test.txt');
+            await fs.writeFile(path.join(tempRootDir, 'gemini-ignored_test.txt'), 'content');
+            await fs.writeFile(path.join(tempRootDir, 'visible_test.txt'), 'content');
+            const params = { pattern: 'visible_test.txt' };
+            const invocation = globTool.build(params);
+            const result = await invocation.execute(abortSignal);
+            expect(result.llmContent).toContain('Found 1 file(s)');
+            expect(result.llmContent).toContain('visible_test.txt');
+            expect(result.llmContent).not.toContain('gemini-ignored_test.txt');
+        }, 30000);
+        it('should not respect .gitignore when respect_git_ignore is false', async () => {
+            await fs.writeFile(path.join(tempRootDir, '.gitignore'), 'ignored_test.txt');
+            await fs.writeFile(path.join(tempRootDir, 'ignored_test.txt'), 'content');
+            const params = {
+                pattern: 'ignored_test.txt',
+                respect_git_ignore: false,
+            };
+            const invocation = globTool.build(params);
+            const result = await invocation.execute(abortSignal);
+            expect(result.llmContent).toContain('Found 1 file(s)');
+            expect(result.llmContent).toContain('ignored_test.txt');
+        }, 30000);
+        it('should not respect .geminiignore when respect_gemini_ignore is false', async () => {
+            await fs.writeFile(path.join(tempRootDir, GEMINI_IGNORE_FILE_NAME), 'gemini-ignored_test.txt');
+            await fs.writeFile(path.join(tempRootDir, 'gemini-ignored_test.txt'), 'content');
+            const params = {
+                pattern: 'gemini-ignored_test.txt',
+                respect_gemini_ignore: false,
+            };
+            const invocation = globTool.build(params);
+            const result = await invocation.execute(abortSignal);
+            expect(result.llmContent).toContain('Found 1 file(s)');
+            expect(result.llmContent).toContain('gemini-ignored_test.txt');
+        }, 30000);
     });
 });
 describe('sortFileEntries', () => {
-    const nowTimestamp = new Date('2024-01-15T12:00:00.000Z').getTime();
-    const oneDayInMs = 24 * 60 * 60 * 1000;
-    const createFileEntry = (fullpath, mtimeDate) => ({
-        fullpath: () => fullpath,
-        mtimeMs: mtimeDate.getTime(),
+    const now = 1000000;
+    const threshold = 10000;
+    it('should sort a mix of recent and older files correctly', () => {
+        const entries = [
+            { fullpath: () => 'older-b.txt', mtimeMs: now - 20000 },
+            { fullpath: () => 'recent-b.txt', mtimeMs: now - 1000 },
+            { fullpath: () => 'recent-a.txt', mtimeMs: now - 500 },
+            { fullpath: () => 'older-a.txt', mtimeMs: now - 30000 },
+        ];
+        const sorted = sortFileEntries(entries, now, threshold);
+        expect(sorted.map((e) => e.fullpath())).toEqual([
+            'recent-a.txt', // Recent, newest first
+            'recent-b.txt',
+            'older-a.txt', // Older, alphabetical
+            'older-b.txt',
+        ]);
+    });
+    it('should sort only recent files by mtime descending', () => {
+        const entries = [
+            { fullpath: () => 'a.txt', mtimeMs: now - 2000 },
+            { fullpath: () => 'b.txt', mtimeMs: now - 1000 },
+        ];
+        const sorted = sortFileEntries(entries, now, threshold);
+        expect(sorted.map((e) => e.fullpath())).toEqual(['b.txt', 'a.txt']);
+    });
+    it('should sort only older files alphabetically', () => {
+        const entries = [
+            { fullpath: () => 'b.txt', mtimeMs: now - 20000 },
+            { fullpath: () => 'a.txt', mtimeMs: now - 30000 },
+        ];
+        const sorted = sortFileEntries(entries, now, threshold);
+        expect(sorted.map((e) => e.fullpath())).toEqual(['a.txt', 'b.txt']);
+    });
+    it('should handle an empty array', () => {
+        expect(sortFileEntries([], now, threshold)).toEqual([]);
+    });
+    it('should correctly sort files when mtimeMs is missing', () => {
+        const entries = [
+            { fullpath: () => 'b.txt' },
+            { fullpath: () => 'a.txt' },
+        ];
+        const sorted = sortFileEntries(entries, now, threshold);
+        expect(sorted.map((e) => e.fullpath())).toEqual(['a.txt', 'b.txt']);
     });
-    const testCases = [
-        {
-            name: 'should sort a mix of recent and older files correctly',
-            entries: [
-                {
-                    name: 'older_zebra.txt',
-                    mtime: new Date(nowTimestamp - (oneDayInMs + 2 * 60 * 60 * 1000)),
-                },
-                {
-                    name: 'recent_alpha.txt',
-                    mtime: new Date(nowTimestamp - 1 * 60 * 60 * 1000),
-                },
-                {
-                    name: 'older_apple.txt',
-                    mtime: new Date(nowTimestamp - (oneDayInMs + 1 * 60 * 60 * 1000)),
-                },
-                {
-                    name: 'recent_beta.txt',
-                    mtime: new Date(nowTimestamp - 2 * 60 * 60 * 1000),
-                },
-                {
-                    name: 'older_banana.txt',
-                    mtime: new Date(nowTimestamp - (oneDayInMs + 1 * 60 * 60 * 1000)),
-                },
-            ],
-            expected: [
-                'recent_alpha.txt',
-                'recent_beta.txt',
-                'older_apple.txt',
-                'older_banana.txt',
-                'older_zebra.txt',
-            ],
-        },
-        {
-            name: 'should sort only recent files by mtime descending',
-            entries: [
-                { name: 'c.txt', mtime: new Date(nowTimestamp - 2000) },
-                { name: 'a.txt', mtime: new Date(nowTimestamp - 3000) },
-                { name: 'b.txt', mtime: new Date(nowTimestamp - 1000) },
-            ],
-            expected: ['b.txt', 'c.txt', 'a.txt'],
-        },
-        {
-            name: 'should sort only older files alphabetically by path',
-            entries: [
-                { name: 'zebra.txt', mtime: new Date(nowTimestamp - 2 * oneDayInMs) },
-                { name: 'apple.txt', mtime: new Date(nowTimestamp - 2 * oneDayInMs) },
-                { name: 'banana.txt', mtime: new Date(nowTimestamp - 2 * oneDayInMs) },
-            ],
-            expected: ['apple.txt', 'banana.txt', 'zebra.txt'],
-        },
-        {
-            name: 'should handle an empty array',
-            entries: [],
-            expected: [],
-        },
-        {
-            name: 'should correctly sort files when mtimes are identical for recent files',
-            entries: [
-                { name: 'b.txt', mtime: new Date(nowTimestamp - 1000) },
-                { name: 'a.txt', mtime: new Date(nowTimestamp - 1000) },
-            ],
-            expectedUnordered: ['a.txt', 'b.txt'],
-        },
-        {
-            name: 'should use recencyThresholdMs parameter correctly',
-            recencyThresholdMs: 1000,
-            entries: [
-                { name: 'older_file.txt', mtime: new Date(nowTimestamp - 1001) },
-                { name: 'recent_file.txt', mtime: new Date(nowTimestamp - 999) },
-            ],
-            expected: ['recent_file.txt', 'older_file.txt'],
-        },
-    ];
-    it.each(testCases)('$name', ({ entries, expected, expectedUnordered, recencyThresholdMs }) => {
-        const globPaths = entries.map((e) => createFileEntry(e.name, e.mtime));
-        const sorted = sortFileEntries(globPaths, nowTimestamp, recencyThresholdMs ?? oneDayInMs);
-        const sortedPaths = sorted.map((e) => e.fullpath());
-        if (expected) {
-            expect(sortedPaths).toEqual(expected);
-        }
-        else if (expectedUnordered) {
-            expect(sortedPaths).toHaveLength(expectedUnordered.length);
-            for (const path of expectedUnordered) {
-                expect(sortedPaths).toContain(path);
-            }
-        }
-        else {
-            throw new Error('Test case must have expected or expectedUnordered');
-        }
+    it('should use recencyThresholdMs parameter', () => {
+        const customThreshold = 5000;
+        const entries = [
+            { fullpath: () => 'old.txt', mtimeMs: now - 8000 },
+            { fullpath: () => 'new.txt', mtimeMs: now - 3000 },
+        ];
+        const sorted = sortFileEntries(entries, now, customThreshold);
+        expect(sorted.map((e) => e.fullpath())).toEqual(['new.txt', 'old.txt']);
     });
 });
 //# sourceMappingURL=glob.test.js.map