@odoo/owl 2.5.0 → 2.5.3

package/dist/owl.cjs.js

@@ -1629,6 +1629,13 @@ function makeRootFiber(node) {
             fibersInError.delete(current);
             fibersInError.delete(root);
             current.appliedToDom = false;
+            if (current instanceof RootFiber) {
+                // it is possible that this fiber is a fiber that crashed while being
+                // mounted, so the mounted list is possibly corrupted. We restore it to
+                // its normal initial state (which is empty list or a list with a mount
+                // fiber.
+                current.mounted = current instanceof MountFiber ? [current] : [];
+            }
         }
         return current;
     }
@@ -1745,6 +1752,7 @@ class RootFiber extends Fiber {
         const node = this.node;
         this.locked = true;
         let current = undefined;
+        let mountedFibers = this.mounted;
         try {
             // Step 1: calling all willPatch lifecycle hooks
             for (current of this.willPatch) {
@@ -1764,7 +1772,6 @@ class RootFiber extends Fiber {
             node._patch();
             this.locked = false;
             // Step 4: calling all mounted lifecycle hooks
-            let mountedFibers = this.mounted;
             while ((current = mountedFibers.pop())) {
                 current = current;
                 if (current.appliedToDom) {
@@ -1785,6 +1792,15 @@ class RootFiber extends Fiber {
             }
         }
         catch (e) {
+            // if mountedFibers is not empty, this means that a crash occured while
+            // calling the mounted hooks of some component. So, there may still be
+            // some component that have been mounted, but for which the mounted hooks
+            // have not been called. Here, we remove the willUnmount hooks for these
+            // specific component to prevent a worse situation (willUnmount being
+            // called even though mounted has not been called)
+            for (let fiber of mountedFibers) {
+                fiber.node.willUnmount = [];
+            }
             this.locked = false;
             node.app.handleError({ fiber: current || this, error: e });
         }
@@ -4632,7 +4648,7 @@ class CodeGenerator {
                 case "translate":
                     break;
                 default:
-                    throw new OwlError("Invalid prop suffix");
+                    throw new OwlError(`Invalid prop suffix: ${suffix}`);
             }
         }
         name = /^[a-z_]+$/i.test(name) ? name : `'${name}'`;
@@ -4938,10 +4954,10 @@ function parseTCustom(node, ctx) {
                 throw new OwlError(`Custom directive "${directiveName}" is not defined`);
             }
             const value = node.getAttribute(attr);
-            const modifier = attr.split(".").length > 1 ? attr.split(".")[1] : undefined;
+            const modifiers = attr.split(".").slice(1);
             node.removeAttribute(attr);
             try {
-                customDirective(node, value, modifier);
+                customDirective(node, value, modifiers);
             }
             catch (error) {
                 throw new OwlError(`Custom directive "${directiveName}" throw the following error: ${error}`);
@@ -5608,7 +5624,7 @@ function compile(template, options = {
 }
 
 // do not modify manually. This file is generated by the release script.
-const version = "2.5.0";
+const version = "2.5.3";
 
 // -----------------------------------------------------------------------------
 //  Scheduler
@@ -6121,6 +6137,6 @@ exports.whenReady = whenReady;
 exports.xml = xml;
 
 
-__info__.date = '2024-11-25T09:30:45.930Z';
-__info__.hash = '6b24864';
+__info__.date = '2025-01-10T10:10:53.709Z';
+__info__.hash = 'b31fa81';
 __info__.url = 'https://github.com/odoo/owl';

package/dist/owl.es.js

@@ -1625,6 +1625,13 @@ function makeRootFiber(node) {
             fibersInError.delete(current);
             fibersInError.delete(root);
             current.appliedToDom = false;
+            if (current instanceof RootFiber) {
+                // it is possible that this fiber is a fiber that crashed while being
+                // mounted, so the mounted list is possibly corrupted. We restore it to
+                // its normal initial state (which is empty list or a list with a mount
+                // fiber.
+                current.mounted = current instanceof MountFiber ? [current] : [];
+            }
         }
         return current;
     }
@@ -1741,6 +1748,7 @@ class RootFiber extends Fiber {
         const node = this.node;
         this.locked = true;
         let current = undefined;
+        let mountedFibers = this.mounted;
         try {
             // Step 1: calling all willPatch lifecycle hooks
             for (current of this.willPatch) {
@@ -1760,7 +1768,6 @@ class RootFiber extends Fiber {
             node._patch();
             this.locked = false;
             // Step 4: calling all mounted lifecycle hooks
-            let mountedFibers = this.mounted;
             while ((current = mountedFibers.pop())) {
                 current = current;
                 if (current.appliedToDom) {
@@ -1781,6 +1788,15 @@ class RootFiber extends Fiber {
             }
         }
         catch (e) {
+            // if mountedFibers is not empty, this means that a crash occured while
+            // calling the mounted hooks of some component. So, there may still be
+            // some component that have been mounted, but for which the mounted hooks
+            // have not been called. Here, we remove the willUnmount hooks for these
+            // specific component to prevent a worse situation (willUnmount being
+            // called even though mounted has not been called)
+            for (let fiber of mountedFibers) {
+                fiber.node.willUnmount = [];
+            }
             this.locked = false;
             node.app.handleError({ fiber: current || this, error: e });
         }
@@ -4628,7 +4644,7 @@ class CodeGenerator {
                 case "translate":
                     break;
                 default:
-                    throw new OwlError("Invalid prop suffix");
+                    throw new OwlError(`Invalid prop suffix: ${suffix}`);
             }
         }
         name = /^[a-z_]+$/i.test(name) ? name : `'${name}'`;
@@ -4934,10 +4950,10 @@ function parseTCustom(node, ctx) {
                 throw new OwlError(`Custom directive "${directiveName}" is not defined`);
             }
             const value = node.getAttribute(attr);
-            const modifier = attr.split(".").length > 1 ? attr.split(".")[1] : undefined;
+            const modifiers = attr.split(".").slice(1);
             node.removeAttribute(attr);
             try {
-                customDirective(node, value, modifier);
+                customDirective(node, value, modifiers);
             }
             catch (error) {
                 throw new OwlError(`Custom directive "${directiveName}" throw the following error: ${error}`);
@@ -5604,7 +5620,7 @@ function compile(template, options = {
 }
 
 // do not modify manually. This file is generated by the release script.
-const version = "2.5.0";
+const version = "2.5.3";
 
 // -----------------------------------------------------------------------------
 //  Scheduler
@@ -6082,6 +6098,6 @@ TemplateSet.prototype._compileTemplate = function _compileTemplate(name, templat
 export { App, Component, EventBus, OwlError, __info__, batched, blockDom, loadFile, markRaw, markup, mount, onError, onMounted, onPatched, onRendered, onWillDestroy, onWillPatch, onWillRender, onWillStart, onWillUnmount, onWillUpdateProps, reactive, status, toRaw, useChildSubEnv, useComponent, useEffect, useEnv, useExternalListener, useRef, useState, useSubEnv, validate, validateType, whenReady, xml };
 
 
-__info__.date = '2024-11-25T09:30:45.930Z';
-__info__.hash = '6b24864';
+__info__.date = '2025-01-10T10:10:53.709Z';
+__info__.hash = 'b31fa81';
 __info__.url = 'https://github.com/odoo/owl';

package/dist/owl.iife.js

@@ -1628,6 +1628,13 @@
                 fibersInError.delete(current);
                 fibersInError.delete(root);
                 current.appliedToDom = false;
+                if (current instanceof RootFiber) {
+                    // it is possible that this fiber is a fiber that crashed while being
+                    // mounted, so the mounted list is possibly corrupted. We restore it to
+                    // its normal initial state (which is empty list or a list with a mount
+                    // fiber.
+                    current.mounted = current instanceof MountFiber ? [current] : [];
+                }
             }
             return current;
         }
@@ -1744,6 +1751,7 @@
             const node = this.node;
             this.locked = true;
             let current = undefined;
+            let mountedFibers = this.mounted;
             try {
                 // Step 1: calling all willPatch lifecycle hooks
                 for (current of this.willPatch) {
@@ -1763,7 +1771,6 @@
                 node._patch();
                 this.locked = false;
                 // Step 4: calling all mounted lifecycle hooks
-                let mountedFibers = this.mounted;
                 while ((current = mountedFibers.pop())) {
                     current = current;
                     if (current.appliedToDom) {
@@ -1784,6 +1791,15 @@
                 }
             }
             catch (e) {
+                // if mountedFibers is not empty, this means that a crash occured while
+                // calling the mounted hooks of some component. So, there may still be
+                // some component that have been mounted, but for which the mounted hooks
+                // have not been called. Here, we remove the willUnmount hooks for these
+                // specific component to prevent a worse situation (willUnmount being
+                // called even though mounted has not been called)
+                for (let fiber of mountedFibers) {
+                    fiber.node.willUnmount = [];
+                }
                 this.locked = false;
                 node.app.handleError({ fiber: current || this, error: e });
             }
@@ -4631,7 +4647,7 @@
                     case "translate":
                         break;
                     default:
-                        throw new OwlError("Invalid prop suffix");
+                        throw new OwlError(`Invalid prop suffix: ${suffix}`);
                 }
             }
             name = /^[a-z_]+$/i.test(name) ? name : `'${name}'`;
@@ -4937,10 +4953,10 @@
                     throw new OwlError(`Custom directive "${directiveName}" is not defined`);
                 }
                 const value = node.getAttribute(attr);
-                const modifier = attr.split(".").length > 1 ? attr.split(".")[1] : undefined;
+                const modifiers = attr.split(".").slice(1);
                 node.removeAttribute(attr);
                 try {
-                    customDirective(node, value, modifier);
+                    customDirective(node, value, modifiers);
                 }
                 catch (error) {
                     throw new OwlError(`Custom directive "${directiveName}" throw the following error: ${error}`);
@@ -5607,7 +5623,7 @@
     }
 
     // do not modify manually. This file is generated by the release script.
-    const version = "2.5.0";
+    const version = "2.5.3";
 
     // -----------------------------------------------------------------------------
     //  Scheduler
@@ -6122,8 +6138,8 @@ See https://github.com/odoo/owl/blob/${hash}/doc/reference/app.md#configuration
     Object.defineProperty(exports, '__esModule', { value: true });
 
 
-    __info__.date = '2024-11-25T09:30:45.930Z';
-    __info__.hash = '6b24864';
+    __info__.date = '2025-01-10T10:10:53.709Z';
+    __info__.hash = 'b31fa81';
     __info__.url = 'https://github.com/odoo/owl';