@odoo/o-spreadsheet 18.4.2 → 18.4.3

package/dist/o-spreadsheet.cjs.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 18.4.2
- * @date 2025-07-11T11:11:12.642Z
- * @hash 29b6458
+ * @version 18.4.3
+ * @date 2025-07-28T13:39:06.036Z
+ * @hash 4b596d7
  */
 
 'use strict';
@@ -19035,13 +19035,19 @@ const COLUMN = {
         if (isEvaluationError(cellReference?.value)) {
             return cellReference;
         }
-        const column = cellReference === undefined
-            ? this.__originCellPosition?.col
-            : toZone(cellReference.value).left;
-        if (column === undefined) {
-            return new EvaluationError(_t("In this context, the function [[FUNCTION_NAME]] needs to have a cell or range in parameter."));
+        if (cellReference === undefined) {
+            if (this.__originCellPosition?.col === undefined) {
+                return new EvaluationError(_t("In this context, the function [[FUNCTION_NAME]] needs to have a cell or range in parameter."));
+            }
+            return this.__originCellPosition.col + 1;
+        }
+        const zone = this.getters.getRangeFromSheetXC(this.getters.getActiveSheetId(), cellReference.value).zone;
+        if (zone.left === zone.right) {
+            return zone.left + 1;
         }
-        return column + 1;
+        return generateMatrix(zone.right - zone.left + 1, 1, (col, row) => ({
+            value: zone.left + col + 1,
+        }));
     },
     isExported: true,
 };
@@ -19272,13 +19278,19 @@ const ROW = {
         if (isEvaluationError(cellReference?.value)) {
             return cellReference;
         }
-        const row = cellReference === undefined
-            ? this.__originCellPosition?.row
-            : toZone(cellReference.value).top;
-        if (row === undefined) {
-            return new EvaluationError(_t("In this context, the function [[FUNCTION_NAME]] needs to have a cell or range in parameter."));
+        if (cellReference === undefined) {
+            if (this.__originCellPosition?.row === undefined) {
+                return new EvaluationError(_t("In this context, the function [[FUNCTION_NAME]] needs to have a cell or range in parameter."));
+            }
+            return this.__originCellPosition.row + 1;
+        }
+        const zone = this.getters.getRangeFromSheetXC(this.getters.getActiveSheetId(), cellReference.value).zone;
+        if (zone.top === zone.bottom) {
+            return zone.top + 1;
         }
-        return row + 1;
+        return generateMatrix(1, zone.bottom - zone.top + 1, (col, row) => ({
+            value: zone.top + row + 1,
+        }));
     },
     isExported: true,
 };
@@ -32608,6 +32620,9 @@ class AbstractComposerStore extends SpreadsheetStore {
     get isAutoCompleteDisplayed() {
         return !!this.autoComplete.provider;
     }
+    get canBeToggled() {
+        return this.autoComplete.provider?.canBeToggled ?? true;
+    }
     cycleReferences() {
         const locale = this.getters.getLocale();
         const updated = cycleFixedReference(this.composerSelection, this._currentContent, locale);
@@ -33137,6 +33152,7 @@ class AbstractComposerStore extends SpreadsheetStore {
                     proposals,
                     selectProposal: provider.selectProposal,
                     autoSelectFirstProposal: provider.autoSelectFirstProposal ?? false,
+                    canBeToggled: provider.canBeToggled,
                 };
             }
             if (exactMatch && this._currentContent !== this.initialContent) {
@@ -33159,6 +33175,7 @@ class AbstractComposerStore extends SpreadsheetStore {
                     proposals,
                     selectProposal: provider.selectProposal,
                     autoSelectFirstProposal: provider.autoSelectFirstProposal ?? false,
+                    canBeToggled: provider.canBeToggled,
                 };
             }
         }
@@ -33729,9 +33746,13 @@ class Composer extends owl.Component {
         }
     }
     closeAssistant() {
+        if (!this.props.composerStore.canBeToggled)
+            return;
         this.assistant.forcedClosed = true;
     }
     openAssistant() {
+        if (!this.props.composerStore.canBeToggled)
+            return;
         this.assistant.forcedClosed = false;
     }
     onWheel(event) {
@@ -33921,7 +33942,7 @@ class Composer extends owl.Component {
         return [...new Set(argsToFocus)];
     }
     autoComplete(value) {
-        if (!value || this.assistant.forcedClosed) {
+        if (!value || (this.assistant.forcedClosed && this.props.composerStore.canBeToggled)) {
             return;
         }
         this.props.composerStore.insertAutoCompleteValue(value);
@@ -55682,9 +55703,15 @@ class SpreadsheetPivot {
         return domain.reduce((current, acc) => this.filterDataEntriesFromDomainNode(current, acc), dataEntries);
     }
     filterDataEntriesFromDomainNode(dataEntries, domain) {
-        const { field, value } = domain;
+        const { field, value, type } = domain;
         const { nameWithGranularity } = this.getDimension(field);
-        return dataEntries.filter((entry) => entry[nameWithGranularity]?.value === value);
+        return dataEntries.filter((entry) => {
+            const cellValue = entry[nameWithGranularity]?.value;
+            if (type === "char") {
+                return String(cellValue) === String(value);
+            }
+            return cellValue === value;
+        });
     }
     getDimension(nameWithGranularity) {
         return this.definition.getDimension(nameWithGranularity);
@@ -67553,6 +67580,23 @@ class HeaderSizeUIPlugin extends CoreViewPlugin {
     static getters = ["getRowSize", "getHeaderSize", "getMaxAnchorOffset"];
     tallestCellInRow = {};
     ctx = document.createElement("canvas").getContext("2d");
+    beforeHandle(cmd) {
+        switch (cmd.type) {
+            // Ensure rows are updated before "UPDATE_CELL" is dispatched from cell plugin.
+            // "UPDATE_CELL" uses the Sheet core plugin to access row data.
+            // If "ADD_COLUMNS_ROWS" has not been processed yet by header_sizes_ui,
+            // size updates may apply to incorrect (pre-insert) rows.
+            case "ADD_COLUMNS_ROWS":
+                if (cmd.dimension === "COL") {
+                    return;
+                }
+                const addIndex = getAddHeaderStartIndex(cmd.position, cmd.base);
+                const newCells = Array(cmd.quantity).fill(undefined);
+                const newTallestCells = insertItemsAtIndex(this.tallestCellInRow[cmd.sheetId], newCells, addIndex);
+                this.history.update("tallestCellInRow", cmd.sheetId, newTallestCells);
+                break;
+        }
+    }
     handle(cmd) {
         switch (cmd.type) {
             case "START":
@@ -67582,16 +67626,6 @@ class HeaderSizeUIPlugin extends CoreViewPlugin {
                 this.history.update("tallestCellInRow", cmd.sheetId, tallestCells);
                 break;
             }
-            case "ADD_COLUMNS_ROWS": {
-                if (cmd.dimension === "COL") {
-                    return;
-                }
-                const addIndex = getAddHeaderStartIndex(cmd.position, cmd.base);
-                const newCells = Array(cmd.quantity).fill(undefined);
-                const newTallestCells = insertItemsAtIndex(this.tallestCellInRow[cmd.sheetId], newCells, addIndex);
-                this.history.update("tallestCellInRow", cmd.sheetId, newTallestCells);
-                break;
-            }
             case "RESIZE_COLUMNS_ROWS":
                 {
                     const sheetId = cmd.sheetId;
@@ -74133,6 +74167,14 @@ class GridSelectionPlugin extends UIPlugin {
         const isBasedBefore = cmd.base < start;
         const deltaCol = isBasedBefore && isCol ? thickness : 0;
         const deltaRow = isBasedBefore && !isCol ? thickness : 0;
+        const toRemove = isBasedBefore ? cmd.elements.map((el) => el + thickness) : cmd.elements;
+        const originalSize = Object.fromEntries(toRemove.map((element) => {
+            const size = isCol
+                ? this.getters.getColSize(cmd.sheetId, element)
+                : this.getters.getUserRowSize(cmd.sheetId, element);
+            const isDefaultCol = isCol && size === DEFAULT_CELL_WIDTH;
+            return [element, isDefaultCol ? undefined : size];
+        }));
         const target = [
             {
                 left: isCol ? start + deltaCol : 0,
@@ -74163,13 +74205,12 @@ class GridSelectionPlugin extends UIPlugin {
         const col = selection.left;
         const row = selection.top;
         this.setSelectionMixin({ zone: selection, cell: { col, row } }, [selection]);
-        const toRemove = isBasedBefore ? cmd.elements.map((el) => el + thickness) : cmd.elements;
         let currentIndex = isBasedBefore ? cmd.base : cmd.base + 1;
         const resizingGroups = {};
         for (const element of toRemove) {
-            const size = this.getters.getHeaderSize(cmd.sheetId, cmd.dimension, element);
+            const size = originalSize[element];
             const currentSize = this.getters.getHeaderSize(cmd.sheetId, cmd.dimension, currentIndex);
-            if (size !== currentSize) {
+            if (size && size !== currentSize) {
                 resizingGroups[size] ??= [];
                 resizingGroups[size].push(currentIndex);
                 currentIndex += 1;
@@ -75595,6 +75636,7 @@ const coreViewsPluginRegistry = new Registry()
 
 autoCompleteProviders.add("dataValidation", {
     displayAllOnInitialContent: true,
+    canBeToggled: false,
     getProposals(tokenAtCursor, content) {
         if (isFormula(content)) {
             return [];
@@ -77160,14 +77202,12 @@ class BottomBarSheet extends owl.Component {
         this.editionState = "initializing";
     }
     stopEdition() {
-        const input = this.sheetNameRef.el;
-        if (!this.state.isEditing || !input)
+        if (!this.state.isEditing || !this.sheetNameRef.el)
             return;
         this.state.isEditing = false;
         this.editionState = "initializing";
-        input.blur();
+        this.sheetNameRef.el.blur();
         const inputValue = this.getInputContent() || "";
-        input.innerText = inputValue;
         interactiveRenameSheet(this.env, this.props.sheetId, inputValue, () => this.startEdition());
     }
     cancelEdition() {
@@ -84606,6 +84646,6 @@ exports.tokenColors = tokenColors;
 exports.tokenize = tokenize;
 
 
-__info__.version = "18.4.2";
-__info__.date = "2025-07-11T11:11:12.642Z";
-__info__.hash = "29b6458";
+__info__.version = "18.4.3";
+__info__.date = "2025-07-28T13:39:06.036Z";
+__info__.hash = "4b596d7";

package/dist/o-spreadsheet.d.ts

@@ -5689,6 +5689,7 @@ declare class HeaderSizeUIPlugin extends CoreViewPlugin<HeaderSizeState> impleme
     static getters: readonly ["getRowSize", "getHeaderSize", "getMaxAnchorOffset"];
     readonly tallestCellInRow: Immutable<Record<UID, Array<CellWithSize | undefined>>>;
     private ctx;
+    beforeHandle(cmd: Command): void;
     handle(cmd: Command): void;
     getRowSize(sheetId: UID, row: HeaderIndex): Pixel;
     getMaxAnchorOffset(sheetId: UID, height: Pixel, width: Pixel): AnchorOffset;
@@ -8551,6 +8552,7 @@ declare abstract class AbstractComposerStore extends SpreadsheetStore {
     get autoCompleteProposals(): AutoCompleteProposal[];
     get autoCompleteSelectedIndex(): number | undefined;
     get isAutoCompleteDisplayed(): boolean;
+    get canBeToggled(): boolean;
     cycleReferences(): void;
     toggleEditionMode(): void;
     hoverToken(tokenIndex: number | undefined): void;
@@ -8857,6 +8859,7 @@ interface AutoCompleteProvider {
     proposals: AutoCompleteProposal[];
     selectProposal(text: string): void;
     autoSelectFirstProposal: boolean;
+    canBeToggled?: boolean;
 }
 interface ComposerStoreInterface {
     currentEditedCell?: CellPosition;
@@ -8876,6 +8879,7 @@ interface ComposerStoreInterface {
 interface AutoCompleteProviderDefinition {
     sequence?: number;
     autoSelectFirstProposal?: boolean;
+    canBeToggled?: boolean;
     displayAllOnInitialContent?: boolean;
     maxDisplayedProposals?: number;
     getProposals(this: {

package/dist/o-spreadsheet.esm.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 18.4.2
- * @date 2025-07-11T11:11:12.642Z
- * @hash 29b6458
+ * @version 18.4.3
+ * @date 2025-07-28T13:39:06.036Z
+ * @hash 4b596d7
  */
 
 import { useEnv, useSubEnv, onWillUnmount, useComponent, status, Component, useRef, onMounted, useEffect, App, blockDom, useState, onPatched, useExternalListener, onWillUpdateProps, onWillStart, onWillPatch, xml, useChildSubEnv, markRaw, toRaw } from '@odoo/owl';
@@ -19033,13 +19033,19 @@ const COLUMN = {
         if (isEvaluationError(cellReference?.value)) {
             return cellReference;
         }
-        const column = cellReference === undefined
-            ? this.__originCellPosition?.col
-            : toZone(cellReference.value).left;
-        if (column === undefined) {
-            return new EvaluationError(_t("In this context, the function [[FUNCTION_NAME]] needs to have a cell or range in parameter."));
+        if (cellReference === undefined) {
+            if (this.__originCellPosition?.col === undefined) {
+                return new EvaluationError(_t("In this context, the function [[FUNCTION_NAME]] needs to have a cell or range in parameter."));
+            }
+            return this.__originCellPosition.col + 1;
+        }
+        const zone = this.getters.getRangeFromSheetXC(this.getters.getActiveSheetId(), cellReference.value).zone;
+        if (zone.left === zone.right) {
+            return zone.left + 1;
         }
-        return column + 1;
+        return generateMatrix(zone.right - zone.left + 1, 1, (col, row) => ({
+            value: zone.left + col + 1,
+        }));
     },
     isExported: true,
 };
@@ -19270,13 +19276,19 @@ const ROW = {
         if (isEvaluationError(cellReference?.value)) {
             return cellReference;
         }
-        const row = cellReference === undefined
-            ? this.__originCellPosition?.row
-            : toZone(cellReference.value).top;
-        if (row === undefined) {
-            return new EvaluationError(_t("In this context, the function [[FUNCTION_NAME]] needs to have a cell or range in parameter."));
+        if (cellReference === undefined) {
+            if (this.__originCellPosition?.row === undefined) {
+                return new EvaluationError(_t("In this context, the function [[FUNCTION_NAME]] needs to have a cell or range in parameter."));
+            }
+            return this.__originCellPosition.row + 1;
+        }
+        const zone = this.getters.getRangeFromSheetXC(this.getters.getActiveSheetId(), cellReference.value).zone;
+        if (zone.top === zone.bottom) {
+            return zone.top + 1;
         }
-        return row + 1;
+        return generateMatrix(1, zone.bottom - zone.top + 1, (col, row) => ({
+            value: zone.top + row + 1,
+        }));
     },
     isExported: true,
 };
@@ -32606,6 +32618,9 @@ class AbstractComposerStore extends SpreadsheetStore {
     get isAutoCompleteDisplayed() {
         return !!this.autoComplete.provider;
     }
+    get canBeToggled() {
+        return this.autoComplete.provider?.canBeToggled ?? true;
+    }
     cycleReferences() {
         const locale = this.getters.getLocale();
         const updated = cycleFixedReference(this.composerSelection, this._currentContent, locale);
@@ -33135,6 +33150,7 @@ class AbstractComposerStore extends SpreadsheetStore {
                     proposals,
                     selectProposal: provider.selectProposal,
                     autoSelectFirstProposal: provider.autoSelectFirstProposal ?? false,
+                    canBeToggled: provider.canBeToggled,
                 };
             }
             if (exactMatch && this._currentContent !== this.initialContent) {
@@ -33157,6 +33173,7 @@ class AbstractComposerStore extends SpreadsheetStore {
                     proposals,
                     selectProposal: provider.selectProposal,
                     autoSelectFirstProposal: provider.autoSelectFirstProposal ?? false,
+                    canBeToggled: provider.canBeToggled,
                 };
             }
         }
@@ -33727,9 +33744,13 @@ class Composer extends Component {
         }
     }
     closeAssistant() {
+        if (!this.props.composerStore.canBeToggled)
+            return;
         this.assistant.forcedClosed = true;
     }
     openAssistant() {
+        if (!this.props.composerStore.canBeToggled)
+            return;
         this.assistant.forcedClosed = false;
     }
     onWheel(event) {
@@ -33919,7 +33940,7 @@ class Composer extends Component {
         return [...new Set(argsToFocus)];
     }
     autoComplete(value) {
-        if (!value || this.assistant.forcedClosed) {
+        if (!value || (this.assistant.forcedClosed && this.props.composerStore.canBeToggled)) {
             return;
         }
         this.props.composerStore.insertAutoCompleteValue(value);
@@ -55680,9 +55701,15 @@ class SpreadsheetPivot {
         return domain.reduce((current, acc) => this.filterDataEntriesFromDomainNode(current, acc), dataEntries);
     }
     filterDataEntriesFromDomainNode(dataEntries, domain) {
-        const { field, value } = domain;
+        const { field, value, type } = domain;
         const { nameWithGranularity } = this.getDimension(field);
-        return dataEntries.filter((entry) => entry[nameWithGranularity]?.value === value);
+        return dataEntries.filter((entry) => {
+            const cellValue = entry[nameWithGranularity]?.value;
+            if (type === "char") {
+                return String(cellValue) === String(value);
+            }
+            return cellValue === value;
+        });
     }
     getDimension(nameWithGranularity) {
         return this.definition.getDimension(nameWithGranularity);
@@ -67551,6 +67578,23 @@ class HeaderSizeUIPlugin extends CoreViewPlugin {
     static getters = ["getRowSize", "getHeaderSize", "getMaxAnchorOffset"];
     tallestCellInRow = {};
     ctx = document.createElement("canvas").getContext("2d");
+    beforeHandle(cmd) {
+        switch (cmd.type) {
+            // Ensure rows are updated before "UPDATE_CELL" is dispatched from cell plugin.
+            // "UPDATE_CELL" uses the Sheet core plugin to access row data.
+            // If "ADD_COLUMNS_ROWS" has not been processed yet by header_sizes_ui,
+            // size updates may apply to incorrect (pre-insert) rows.
+            case "ADD_COLUMNS_ROWS":
+                if (cmd.dimension === "COL") {
+                    return;
+                }
+                const addIndex = getAddHeaderStartIndex(cmd.position, cmd.base);
+                const newCells = Array(cmd.quantity).fill(undefined);
+                const newTallestCells = insertItemsAtIndex(this.tallestCellInRow[cmd.sheetId], newCells, addIndex);
+                this.history.update("tallestCellInRow", cmd.sheetId, newTallestCells);
+                break;
+        }
+    }
     handle(cmd) {
         switch (cmd.type) {
             case "START":
@@ -67580,16 +67624,6 @@ class HeaderSizeUIPlugin extends CoreViewPlugin {
                 this.history.update("tallestCellInRow", cmd.sheetId, tallestCells);
                 break;
             }
-            case "ADD_COLUMNS_ROWS": {
-                if (cmd.dimension === "COL") {
-                    return;
-                }
-                const addIndex = getAddHeaderStartIndex(cmd.position, cmd.base);
-                const newCells = Array(cmd.quantity).fill(undefined);
-                const newTallestCells = insertItemsAtIndex(this.tallestCellInRow[cmd.sheetId], newCells, addIndex);
-                this.history.update("tallestCellInRow", cmd.sheetId, newTallestCells);
-                break;
-            }
             case "RESIZE_COLUMNS_ROWS":
                 {
                     const sheetId = cmd.sheetId;
@@ -74131,6 +74165,14 @@ class GridSelectionPlugin extends UIPlugin {
         const isBasedBefore = cmd.base < start;
         const deltaCol = isBasedBefore && isCol ? thickness : 0;
         const deltaRow = isBasedBefore && !isCol ? thickness : 0;
+        const toRemove = isBasedBefore ? cmd.elements.map((el) => el + thickness) : cmd.elements;
+        const originalSize = Object.fromEntries(toRemove.map((element) => {
+            const size = isCol
+                ? this.getters.getColSize(cmd.sheetId, element)
+                : this.getters.getUserRowSize(cmd.sheetId, element);
+            const isDefaultCol = isCol && size === DEFAULT_CELL_WIDTH;
+            return [element, isDefaultCol ? undefined : size];
+        }));
         const target = [
             {
                 left: isCol ? start + deltaCol : 0,
@@ -74161,13 +74203,12 @@ class GridSelectionPlugin extends UIPlugin {
         const col = selection.left;
         const row = selection.top;
         this.setSelectionMixin({ zone: selection, cell: { col, row } }, [selection]);
-        const toRemove = isBasedBefore ? cmd.elements.map((el) => el + thickness) : cmd.elements;
         let currentIndex = isBasedBefore ? cmd.base : cmd.base + 1;
         const resizingGroups = {};
         for (const element of toRemove) {
-            const size = this.getters.getHeaderSize(cmd.sheetId, cmd.dimension, element);
+            const size = originalSize[element];
             const currentSize = this.getters.getHeaderSize(cmd.sheetId, cmd.dimension, currentIndex);
-            if (size !== currentSize) {
+            if (size && size !== currentSize) {
                 resizingGroups[size] ??= [];
                 resizingGroups[size].push(currentIndex);
                 currentIndex += 1;
@@ -75593,6 +75634,7 @@ const coreViewsPluginRegistry = new Registry()
 
 autoCompleteProviders.add("dataValidation", {
     displayAllOnInitialContent: true,
+    canBeToggled: false,
     getProposals(tokenAtCursor, content) {
         if (isFormula(content)) {
             return [];
@@ -77158,14 +77200,12 @@ class BottomBarSheet extends Component {
         this.editionState = "initializing";
     }
     stopEdition() {
-        const input = this.sheetNameRef.el;
-        if (!this.state.isEditing || !input)
+        if (!this.state.isEditing || !this.sheetNameRef.el)
             return;
         this.state.isEditing = false;
         this.editionState = "initializing";
-        input.blur();
+        this.sheetNameRef.el.blur();
         const inputValue = this.getInputContent() || "";
-        input.innerText = inputValue;
         interactiveRenameSheet(this.env, this.props.sheetId, inputValue, () => this.startEdition());
     }
     cancelEdition() {
@@ -84556,6 +84596,6 @@ const chartHelpers = { ...CHART_HELPERS, ...CHART_RUNTIME_HELPERS };
 export { AbstractCellClipboardHandler, AbstractChart, AbstractFigureClipboardHandler, CellErrorType, ClientDisconnectedError, CommandResult, CorePlugin, CoreViewPlugin, DispatchResult, EvaluationError, LocalTransportService, Model, PivotRuntimeDefinition, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, SpreadsheetPivotTable, UIPlugin, __info__, addFunction, addRenderingLayer, astToFormula, chartHelpers, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateChartEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, stores, tokenColors, tokenize };
 
 
-__info__.version = "18.4.2";
-__info__.date = "2025-07-11T11:11:12.642Z";
-__info__.hash = "29b6458";
+__info__.version = "18.4.3";
+__info__.date = "2025-07-28T13:39:06.036Z";
+__info__.hash = "4b596d7";