@odoo/o-spreadsheet 18.3.7 → 18.3.9

package/dist/o-spreadsheet.iife.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 18.3.7
- * @date 2025-06-06T09:31:27.123Z
- * @hash 05333f1
+ * @version 18.3.9
+ * @date 2025-06-19T18:24:02.754Z
+ * @hash a820230
  */
 
 (function (exports, owl) {
@@ -5881,7 +5881,9 @@
   }
 
   function evaluateLiteral(literalCell, localeFormat) {
-      const value = isTextFormat(localeFormat.format) ? literalCell.content : literalCell.parsedValue;
+      const value = isTextFormat(localeFormat.format) && literalCell.parsedValue !== null
+          ? literalCell.content
+          : literalCell.parsedValue;
       const functionResult = { value, format: localeFormat.format };
       return createEvaluatedCell(functionResult, localeFormat.locale);
   }
@@ -5930,6 +5932,9 @@
       if (isEvaluationError(value)) {
           return errorCell(value, message);
       }
+      if (value === null) {
+          return emptyCell(format);
+      }
       if (isTextFormat(format)) {
           // TO DO:
           // with the next line, the value of the cell is transformed depending on the format.
@@ -5937,9 +5942,6 @@
           // to interpret the value as a number.
           return textCell(toString(value), format, formattedValue);
       }
-      if (value === null) {
-          return emptyCell(format);
-      }
       if (typeof value === "number") {
           if (isDateTimeFormat(format || "")) {
               return dateTimeCell(value, format, formattedValue);
@@ -20950,6 +20952,7 @@ stores.inject(MyMetaStore, storeInstance);
           if (isTrendLineAxis(dataset.xAxisID) || dataset.hidden) {
               continue;
           }
+          const yAxisScale = chart.scales[dataset.yAxisID];
           for (let i = 0; i < dataset._parsed.length; i++) {
               const parsedValue = dataset._parsed[i];
               const value = Number(chart.config.type === "radar" ? parsedValue.r : parsedValue.y);
@@ -20960,10 +20963,18 @@ stores.inject(MyMetaStore, storeInstance);
               const xPosition = point.x;
               let yPosition = 0;
               if (chart.config.type === "line" || chart.config.type === "radar") {
-                  yPosition = point.y - 10;
+                  yPosition = value < 0 ? point.y + 10 : point.y - 10;
               }
               else {
-                  yPosition = value < 0 ? point.y - point.height / 2 : point.y + point.height / 2;
+                  const yZeroLine = yAxisScale.getPixelForValue(0);
+                  const distanceFromAxisOrigin = Math.abs(yZeroLine - point.y);
+                  const textHeight = 12; // ChartJS default text height
+                  if (distanceFromAxisOrigin < textHeight) {
+                      yPosition = value < 0 ? yZeroLine + textHeight / 2 : yZeroLine - textHeight / 2;
+                  }
+                  else {
+                      yPosition = value < 0 ? point.y - point.height / 2 : point.y + point.height / 2;
+                  }
               }
               yPosition = Math.min(yPosition, yMax);
               yPosition = Math.max(yPosition, yMin);
@@ -20973,7 +20984,7 @@ stores.inject(MyMetaStore, storeInstance);
               }
               for (const otherPosition of textsPositions[xPosition] || []) {
                   if (Math.abs(otherPosition - yPosition) < 13) {
-                      yPosition = otherPosition - 13;
+                      yPosition = value < 0 ? otherPosition + 13 : otherPosition - 13;
                   }
               }
               textsPositions[xPosition].push(yPosition);
@@ -20992,6 +21003,8 @@ stores.inject(MyMetaStore, storeInstance);
           if (isTrendLineAxis(dataset.xAxisID)) {
               return; // ignore trend lines
           }
+          const xAxisScale = chart.scales[dataset.xAxisID];
+          const xZeroLine = xAxisScale.getPixelForValue(0);
           for (let i = 0; i < dataset._parsed.length; i++) {
               const value = Number(dataset._parsed[i].x);
               if (isNaN(value)) {
@@ -21000,17 +21013,27 @@ stores.inject(MyMetaStore, storeInstance);
               const displayValue = options.callback(value, dataset, i);
               const point = dataset.data[i];
               const yPosition = point.y;
-              let xPosition = value < 0 ? point.x + point.width / 2 : point.x - point.width / 2;
-              xPosition = Math.min(xPosition, xMax);
-              xPosition = Math.max(xPosition, xMin);
+              const textWidth = computeTextWidth(ctx, displayValue, { fontSize: 12 }, "px");
+              const distanceFromAxisOrigin = Math.abs(point.x - xZeroLine);
+              const PADDING = 3;
+              let xPosition;
+              if (distanceFromAxisOrigin < textWidth) {
+                  xPosition =
+                      value < 0 ? xZeroLine - textWidth / 2 - PADDING : xZeroLine + textWidth / 2 + PADDING;
+              }
+              else {
+                  xPosition = value < 0 ? point.x + point.width / 2 : point.x - point.width / 2;
+                  xPosition = Math.min(xPosition, xMax);
+                  xPosition = Math.max(xPosition, xMin);
+              }
               // Avoid overlapping texts with same Y
               if (!textsPositions[yPosition]) {
                   textsPositions[yPosition] = [];
               }
-              const textWidth = computeTextWidth(ctx, displayValue, { fontSize: 12 }, "px");
               for (const otherPosition of textsPositions[yPosition]) {
                   if (Math.abs(otherPosition - xPosition) < textWidth) {
-                      xPosition = otherPosition + textWidth + 3;
+                      xPosition =
+                          value < 0 ? otherPosition - textWidth - PADDING : otherPosition + textWidth + PADDING;
                   }
               }
               textsPositions[yPosition].push(xPosition);
@@ -21032,10 +21055,22 @@ stores.inject(MyMetaStore, storeInstance);
               const midAngle = (startAngle + endAngle) / 2;
               const midRadius = (innerRadius + outerRadius) / 2;
               const x = bar.x + midRadius * Math.cos(midAngle);
-              const y = bar.y + midRadius * Math.sin(midAngle) + 7;
+              const y = bar.y + midRadius * Math.sin(midAngle);
+              const displayValue = options.callback(value, dataset, i);
+              const textHeight = 12; // ChartJS default
+              const textWidth = computeTextWidth(ctx, displayValue, { fontSize: textHeight }, "px");
+              const radius = outerRadius - innerRadius;
+              // Check if the text fits in the slice. Not perfect, but good enough heuristic.
+              if (textWidth >= radius || radius < textHeight) {
+                  continue;
+              }
+              const sliceAngle = endAngle - startAngle;
+              const midWidth = 2 * midRadius * Math.tan(sliceAngle / 2);
+              if (sliceAngle < Math.PI / 2 && (textWidth >= midWidth || midWidth < textHeight)) {
+                  continue;
+              }
               ctx.fillStyle = chartFontColor(options.background);
               ctx.strokeStyle = options.background || "#ffffff";
-              const displayValue = options.callback(value, dataset, i);
               drawTextWithBackground(displayValue, x, y, ctx);
           }
       }
@@ -26385,7 +26420,9 @@ stores.inject(MyMetaStore, storeInstance);
           background: definition.background,
           callback: (value, dataset) => {
               value = Math.abs(Number(value));
-              return formatChartDatasetValue(axisFormats, locale)(value, dataset.xAxisID || "x");
+              return value === 0
+                  ? ""
+                  : formatChartDatasetValue(axisFormats, locale)(value, dataset.xAxisID || "x");
           },
       };
   }
@@ -33171,7 +33208,7 @@ stores.inject(MyMetaStore, storeInstance);
        */
       handleMissingValue(parentElement, missingElementName, optionalArgs) {
           if (optionalArgs?.required) {
-              if (optionalArgs?.default) {
+              if (optionalArgs?.default !== undefined) {
                   this.warningManager.addParsingWarning(`Missing required ${missingElementName} in element <${parentElement.tagName}> of ${this.currentFile}, replacing it by the default value ${optionalArgs.default}`);
               }
               else {
@@ -36124,19 +36161,26 @@ stores.inject(MyMetaStore, storeInstance);
               .filter(({ row }) => !this.env.model.getters.isRowHidden(sheetId, row))
               .map(({ col, row }) => this.env.model.getters.getEvaluatedCell({ sheetId, col, row }).formattedValue);
           const filterValues = this.env.model.getters.getFilterHiddenValues({ sheetId, ...position });
-          const strValues = [...cellValues, ...filterValues];
-          const normalizedFilteredValues = filterValues.map(toLowerCase);
-          // Set with lowercase values to avoid duplicates
-          const normalizedValues = [...new Set(strValues.map(toLowerCase))];
-          const sortedValues = normalizedValues.sort((val1, val2) => val1.localeCompare(val2, undefined, { numeric: true, sensitivity: "base" }));
-          return sortedValues.map((normalizedValue) => {
-              const checked = normalizedFilteredValues.findIndex((filteredValue) => filteredValue === normalizedValue) ===
-                  -1;
-              return {
-                  checked,
-                  string: strValues.find((val) => toLowerCase(val) === normalizedValue) || "",
-              };
-          });
+          const normalizedFilteredValues = new Set(filterValues.map(toLowerCase));
+          const set = new Set();
+          const values = [];
+          const addValue = (value) => {
+              const normalizedValue = toLowerCase(value);
+              if (!set.has(normalizedValue)) {
+                  values.push({
+                      string: value || "",
+                      checked: !normalizedFilteredValues.has(normalizedValue),
+                      normalizedValue,
+                  });
+                  set.add(normalizedValue);
+              }
+          };
+          cellValues.forEach(addValue);
+          filterValues.forEach(addValue);
+          return values.sort((val1, val2) => val1.normalizedValue.localeCompare(val2.normalizedValue, undefined, {
+              numeric: true,
+              sensitivity: "base",
+          }));
       }
       checkValue(value) {
           this.state.selectedValue = value.string;
@@ -37111,6 +37155,10 @@ stores.inject(MyMetaStore, storeInstance);
       });
   };
   const CAN_REMOVE_COLUMNS_ROWS = (dimension, env) => {
+      if ((dimension === "COL" && env.model.getters.getActiveRows().size > 0) ||
+          (dimension === "ROW" && env.model.getters.getActiveCols().size > 0)) {
+          return false;
+      }
       const sheetId = env.model.getters.getActiveSheetId();
       const selectedElements = env.model.getters.getElementsFromSelection(dimension);
       const includesAllVisibleHeaders = env.model.getters.checkElementsIncludeAllVisibleHeaders(sheetId, dimension, selectedElements);
@@ -40008,11 +40056,11 @@ stores.inject(MyMetaStore, storeInstance);
        * transformation function given
        */
       addTransformation(executed, toTransforms, fn) {
-          for (let toTransform of toTransforms) {
-              if (!this.content[toTransform]) {
-                  this.content[toTransform] = new Map();
-              }
-              this.content[toTransform].set(executed, fn);
+          if (!this.content[executed]) {
+              this.content[executed] = new Map();
+          }
+          for (const toTransform of toTransforms) {
+              this.content[executed].set(toTransform, fn);
           }
           return this;
       }
@@ -40021,7 +40069,7 @@ stores.inject(MyMetaStore, storeInstance);
        * that the executed command happened.
        */
       getTransformation(toTransform, executed) {
-          return this.content[toTransform] && this.content[toTransform].get(executed);
+          return this.content[executed] && this.content[executed].get(toTransform);
       }
   }
   const otRegistry = new OTRegistry();
@@ -43311,6 +43359,12 @@ stores.inject(MyMetaStore, storeInstance);
           owl.useEffect(() => {
               this.processTokenAtCursor();
           }, () => [this.props.composerStore.editionMode !== "inactive"]);
+          owl.useEffect(() => {
+              this.contentHelper.scrollSelectionIntoView();
+          }, () => [
+              this.props.composerStore.composerSelection.start,
+              this.props.composerStore.composerSelection.end,
+          ]);
       }
       // ---------------------------------------------------------------------------
       // Handlers
@@ -43533,6 +43587,7 @@ stores.inject(MyMetaStore, storeInstance);
               // not main button, probably a context menu
               return;
           }
+          this.debouncedHover.stopDebounce();
           this.contentHelper.removeSelection();
       }
       onMouseup() {
@@ -43611,7 +43666,6 @@ stores.inject(MyMetaStore, storeInstance);
                   const { start, end } = this.props.composerStore.composerSelection;
                   this.contentHelper.selectRange(start, end);
               }
-              this.contentHelper.scrollSelectionIntoView();
           }
           this.shouldProcessInputEvents = true;
       }
@@ -61477,7 +61531,9 @@ stores.inject(MyMetaStore, storeInstance);
                   const ranges = cmd.ranges.map((rangeData) => this.getters.getRangeFromRangeData(rangeData));
                   const union = this.getters.getRangesUnion(ranges);
                   const mergesInTarget = this.getters.getMergesInZone(cmd.sheetId, union.zone);
-                  this.dispatch("REMOVE_MERGE", { sheetId: cmd.sheetId, target: mergesInTarget });
+                  if (mergesInTarget.length) {
+                      this.dispatch("REMOVE_MERGE", { sheetId: cmd.sheetId, target: mergesInTarget });
+                  }
                   const id = this.consumeNextId();
                   const config = cmd.config || DEFAULT_TABLE_CONFIG;
                   const newTable = cmd.tableType === "dynamic"
@@ -61576,14 +61632,16 @@ stores.inject(MyMetaStore, storeInstance);
           const zoneToCheckIfEmpty = direction === "down"
               ? { ...zone, bottom: zone.bottom + 1, top: zone.bottom + 1 }
               : { ...zone, right: zone.right + 1, left: zone.right + 1 };
-          for (const position of positions(zoneToCheckIfEmpty)) {
-              const cellPosition = { sheetId, ...position };
-              // Since this plugin is loaded before CellPlugin, the getters still give us the old cell content
-              const cellContent = this.getters.getCell(cellPosition)?.content;
-              if (cellContent ||
-                  this.getters.isInMerge(cellPosition) ||
-                  this.getTablesOverlappingZones(sheetId, [positionToZone(position)]).length) {
-                  return "none";
+          for (let row = zoneToCheckIfEmpty.top; row <= zoneToCheckIfEmpty.bottom; row++) {
+              for (let col = zoneToCheckIfEmpty.left; col <= zoneToCheckIfEmpty.right; col++) {
+                  const cellPosition = { sheetId, col, row };
+                  // Since this plugin is loaded before CellPlugin, the getters still give us the old cell content
+                  const cellContent = this.getters.getCell(cellPosition)?.content;
+                  if (cellContent ||
+                      this.getters.isInMerge(cellPosition) ||
+                      this.getTablesOverlappingZones(sheetId, [positionToZone(cellPosition)]).length) {
+                      return "none";
+                  }
               }
           }
           return direction;
@@ -67752,10 +67810,20 @@ stores.inject(MyMetaStore, storeInstance);
    */
   function transformAll(toTransform, executed) {
       let transformedCommands = [...toTransform];
+      const possibleTransformations = new Set(otRegistry.getKeys());
       for (const executedCommand of executed) {
-          transformedCommands = transformedCommands
-              .map((cmd) => transform(cmd, executedCommand))
-              .filter(isDefined);
+          // If the executed command is not in the registry, we skip it
+          // because we know there won't be any transformation impacting the
+          // commands to transform.
+          if (possibleTransformations.has(executedCommand.type)) {
+              transformedCommands = transformedCommands.reduce((acc, cmd) => {
+                  const transformed = transform(cmd, executedCommand);
+                  if (transformed) {
+                      acc.push(transformed);
+                  }
+                  return acc;
+              }, []);
+          }
       }
       return transformedCommands;
   }
@@ -69457,7 +69525,7 @@ stores.inject(MyMetaStore, storeInstance);
                   }
                   const position = this.getters.getCellPosition(cell.id);
                   const colSize = this.getters.getColSize(sheetId, position.col);
-                  if (cell.isFormula) {
+                  if (cell.isFormula || this.getters.getArrayFormulaSpreadingOn(position)) {
                       const content = this.getters.getEvaluatedCell(position).formattedValue;
                       const evaluatedSize = getCellContentHeight(this.ctx, content, cell?.style, colSize);
                       if (evaluatedSize > evaluatedRowSize && evaluatedSize > DEFAULT_CELL_HEIGHT) {
@@ -71209,9 +71277,10 @@ stores.inject(MyMetaStore, storeInstance);
               const filteredZone = filter.filteredRange?.zone;
               if (!filteredValues || !filteredZone)
                   continue;
+              const filteredValuesSet = new Set(filteredValues);
               for (let row = filteredZone.top; row <= filteredZone.bottom; row++) {
                   const value = this.getCellValueAsString(sheetId, filter.col, row);
-                  if (filteredValues.includes(value)) {
+                  if (filteredValuesSet.has(value)) {
                       hiddenRows.add(row);
                   }
               }
@@ -80641,9 +80710,9 @@ stores.inject(MyMetaStore, storeInstance);
   exports.tokenize = tokenize;
 
 
-  __info__.version = "18.3.7";
-  __info__.date = "2025-06-06T09:31:27.123Z";
-  __info__.hash = "05333f1";
+  __info__.version = "18.3.9";
+  __info__.date = "2025-06-19T18:24:02.754Z";
+  __info__.hash = "a820230";
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);