@odoo/o-spreadsheet 18.2.0-alpha.3 → 18.2.0-alpha.5

package/dist/o-spreadsheet.iife.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 18.2.0-alpha.3
- * @date 2025-01-27T10:07:28.716Z
- * @hash 63a13e5
+ * @version 18.2.0-alpha.5
+ * @date 2025-01-31T07:59:30.667Z
+ * @hash efce841
  */
 
 (function (exports, owl) {
@@ -3360,11 +3360,11 @@
    * number from the point of view of the isNumber function.
    */
   function parseNumber(str, locale) {
+      // remove invaluable characters
+      str = str.replace(getInvaluableSymbolsRegexp(locale), "");
       if (locale.decimalSeparator !== ".") {
           str = str.replace(locale.decimalSeparator, ".");
       }
-      // remove invaluable characters
-      str = str.replace(getInvaluableSymbolsRegexp(locale), "");
       let n = Number(str);
       if (isNaN(n) && str.includes("%")) {
           n = Number(str.split("%")[0]);
@@ -32537,36 +32537,58 @@ stores.inject(MyMetaStore, storeInstance);
       static maxSize = { maxHeight: ERROR_TOOLTIP_MAX_HEIGHT };
       static template = "o-spreadsheet-ErrorToolTip";
       static props = {
-          errors: Array,
+          cellPosition: Object,
           onClosed: { type: Function, optional: true },
       };
+      get dataValidationErrorMessage() {
+          return this.env.model.getters.getInvalidDataValidationMessage(this.props.cellPosition);
+      }
+      get evaluationError() {
+          const cell = this.env.model.getters.getEvaluatedCell(this.props.cellPosition);
+          if (cell.message) {
+              return cell;
+          }
+          return undefined;
+      }
+      get errorOriginPositionString() {
+          const evaluationError = this.evaluationError;
+          const position = evaluationError?.errorOriginPosition;
+          if (!position || deepEquals(position, this.props.cellPosition)) {
+              return "";
+          }
+          const sheetId = position.sheetId;
+          return this.env.model.getters.getRangeString(this.env.model.getters.getRangeFromZone(sheetId, positionToZone(position)), this.env.model.getters.getActiveSheetId());
+      }
+      selectCell() {
+          const position = this.evaluationError?.errorOriginPosition;
+          if (!position) {
+              return;
+          }
+          const activeSheetId = this.env.model.getters.getActiveSheetId();
+          if (position.sheetId !== activeSheetId) {
+              this.env.model.dispatch("ACTIVATE_SHEET", {
+                  sheetIdFrom: activeSheetId,
+                  sheetIdTo: position.sheetId,
+              });
+          }
+          this.env.model.selection.selectCell(position.col, position.row);
+      }
   }
   const ErrorToolTipPopoverBuilder = {
       onHover: (position, getters) => {
           const cell = getters.getEvaluatedCell(position);
-          const errors = [];
-          if (cell.type === CellValueType.error && !!cell.message) {
-              errors.push({
-                  title: _t("Error"),
-                  message: cell.message,
-              });
-          }
-          const validationErrorMessage = getters.getInvalidDataValidationMessage(position);
-          if (validationErrorMessage) {
-              errors.push({
-                  title: _t("Invalid"),
-                  message: validationErrorMessage,
-              });
-          }
-          if (!errors.length) {
-              return { isOpen: false };
+          if ((cell.type === CellValueType.error && !!cell.message) ||
+              getters.getInvalidDataValidationMessage(position)) {
+              return {
+                  isOpen: true,
+                  props: {
+                      cellPosition: position,
+                  },
+                  Component: ErrorToolTip,
+                  cellCorner: "TopRight",
+              };
           }
-          return {
-              isOpen: true,
-              props: { errors: errors },
-              Component: ErrorToolTip,
-              cellCorner: "TopRight",
-          };
+          return { isOpen: false };
       },
   };
 
@@ -33130,6 +33152,100 @@ stores.inject(MyMetaStore, storeInstance);
   function getOpenedMenus() {
       return Array.from(document.querySelectorAll(".o-spreadsheet .o-menu"));
   }
+  function getCurrentSelection(el) {
+      let { startElement, endElement, startSelectionOffset, endSelectionOffset } = getStartAndEndSelection(el);
+      let startSizeBefore = findSelectionIndex(el, startElement, startSelectionOffset);
+      let endSizeBefore = findSelectionIndex(el, endElement, endSelectionOffset);
+      return {
+          start: startSizeBefore,
+          end: endSizeBefore,
+      };
+  }
+  function getStartAndEndSelection(el) {
+      const selection = document.getSelection();
+      return {
+          startElement: selection.anchorNode || el,
+          startSelectionOffset: selection.anchorOffset,
+          endElement: selection.focusNode || el,
+          endSelectionOffset: selection.focusOffset,
+      };
+  }
+  /**
+   * Computes the text 'index' inside this.el based on the currently selected node and its offset.
+   * The selected node is either a Text node or an Element node.
+   *
+   * case 1 -Text node:
+   * the offset is the number of characters from the start of the node. We have to add this offset to the
+   * content length of all previous nodes.
+   *
+   * case 2 - Element node:
+   * the offset is the number of child nodes before the selected node. We have to add the content length of
+   * all the nodes prior to the selected node as well as the content of the child node before the offset.
+   *
+   * See the MDN documentation for more details.
+   * https://developer.mozilla.org/en-US/docs/Web/API/Range/startOffset
+   * https://developer.mozilla.org/en-US/docs/Web/API/Range/endOffset
+   *
+   */
+  function findSelectionIndex(el, nodeToFind, nodeOffset) {
+      let usedCharacters = 0;
+      let it = iterateChildren(el);
+      let current = it.next();
+      let isFirstParagraph = true;
+      while (!current.done && current.value !== nodeToFind) {
+          if (!current.value.hasChildNodes()) {
+              if (current.value.textContent) {
+                  usedCharacters += current.value.textContent.length;
+              }
+          }
+          // One new paragraph = one new line character, except for the first paragraph
+          if (current.value.nodeName === "P" ||
+              (current.value.nodeName === "DIV" && current.value !== el) // On paste, the HTML may contain <div> instead of <p>
+          ) {
+              if (isFirstParagraph) {
+                  isFirstParagraph = false;
+              }
+              else {
+                  usedCharacters++;
+              }
+          }
+          current = it.next();
+      }
+      if (current.value !== nodeToFind) {
+          /** This situation can happen if the code is called while the selection is not currently on the element.
+           * In this case, we return 0 because we don't know the size of the text before the selection.
+           *
+           * A known occurrence is triggered since the introduction of commit d4663158 (PR #2038).
+           */
+          return 0;
+      }
+      else {
+          if (!current.value.hasChildNodes()) {
+              usedCharacters += nodeOffset;
+          }
+          else {
+              const children = [...current.value.childNodes].slice(0, nodeOffset);
+              usedCharacters += children.reduce((acc, child, index) => {
+                  if (child.textContent !== null) {
+                      // need to account for paragraph nodes that implicitly add a new line
+                      // except for the last paragraph
+                      let chars = child.textContent.length;
+                      if (child.nodeName === "P" && index !== children.length - 1) {
+                          chars++;
+                      }
+                      return acc + chars;
+                  }
+                  else {
+                      return acc;
+                  }
+              }, 0);
+          }
+      }
+      if (nodeToFind.nodeName === "P" && !isFirstParagraph && nodeToFind.textContent === "") {
+          usedCharacters++;
+      }
+      return usedCharacters;
+  }
   const letterRegex = /^[a-zA-Z]$/;
   /**
    * Transform a keyboard event into a shortcut string that represent this event. The letters keys will be uppercased.
@@ -40095,14 +40211,21 @@ stores.inject(MyMetaStore, storeInstance);
   class MainChartPanelStore extends SpreadsheetStore {
       mutators = ["activatePanel", "changeChartType"];
       panel = "configuration";
-      creationContext = {};
+      creationContexts = {};
       activatePanel(panel) {
           this.panel = panel;
       }
       changeChartType(figureId, newDisplayType) {
-          this.creationContext = {
-              ...this.creationContext,
-              ...this.getters.getContextCreationChart(figureId),
+          const currentCreationContext = this.getters.getContextCreationChart(figureId);
+          const savedCreationContext = this.creationContexts[figureId] || {};
+          let newRanges = currentCreationContext?.range;
+          if (newRanges?.every((range, i) => deepEquals(range, savedCreationContext.range?.[i]))) {
+              newRanges = Object.assign([], savedCreationContext.range, currentCreationContext?.range);
+          }
+          this.creationContexts[figureId] = {
+              ...savedCreationContext,
+              ...currentCreationContext,
+              range: newRanges,
           };
           const sheetId = this.getters.getFigureSheetId(figureId);
           if (!sheetId) {
@@ -40118,12 +40241,8 @@ stores.inject(MyMetaStore, storeInstance);
       getChartDefinitionFromContextCreation(figureId, newDisplayType) {
           const newChartInfo = chartSubtypeRegistry.get(newDisplayType);
           const ChartClass = chartRegistry.get(newChartInfo.chartType);
-          const contextCreation = {
-              ...this.creationContext,
-              ...this.getters.getContextCreationChart(figureId),
-          };
           return {
-              ...ChartClass.getChartDefinitionFromContextCreation(contextCreation),
+              ...ChartClass.getChartDefinitionFromContextCreation(this.creationContexts[figureId]),
               ...newChartInfo.subtypeDefinition,
           };
       }
@@ -40334,6 +40453,10 @@ stores.inject(MyMetaStore, storeInstance);
           if (currentStart === start && currentEnd === end) {
               return;
           }
+          if (selection.rangeCount === 0) {
+              const range = document.createRange();
+              selection.addRange(range);
+          }
           const currentRange = selection.getRangeAt(0);
           let range;
           if (this.el.contains(currentRange.startContainer)) {
@@ -40496,7 +40619,7 @@ stores.inject(MyMetaStore, storeInstance);
           if (!focusedNode || !this.el.contains(focusedNode))
               return;
           const element = focusedNode instanceof HTMLElement ? focusedNode : focusedNode.parentElement;
-          element?.scrollIntoView({ block: "nearest" });
+          element?.scrollIntoView?.({ block: "nearest" });
       }
       /**
        * remove the current selection of the user
@@ -40516,100 +40639,7 @@ stores.inject(MyMetaStore, storeInstance);
        * finds the indexes of the current selection.
        * */
       getCurrentSelection() {
-          let { startElement, endElement, startSelectionOffset, endSelectionOffset } = this.getStartAndEndSelection();
-          let startSizeBefore = this.findSelectionIndex(startElement, startSelectionOffset);
-          let endSizeBefore = this.findSelectionIndex(endElement, endSelectionOffset);
-          return {
-              start: startSizeBefore,
-              end: endSizeBefore,
-          };
-      }
-      /**
-       * Computes the text 'index' inside this.el based on the currently selected node and its offset.
-       * The selected node is either a Text node or an Element node.
-       *
-       * case 1 -Text node:
-       * the offset is the number of characters from the start of the node. We have to add this offset to the
-       * content length of all previous nodes.
-       *
-       * case 2 - Element node:
-       * the offset is the number of child nodes before the selected node. We have to add the content length of
-       * all the bnodes prior to the selected node as well as the content of the child node before the offset.
-       *
-       * See the MDN documentation for more details.
-       * https://developer.mozilla.org/en-US/docs/Web/API/Range/startOffset
-       * https://developer.mozilla.org/en-US/docs/Web/API/Range/endOffset
-       *
-       */
-      findSelectionIndex(nodeToFind, nodeOffset) {
-          let usedCharacters = 0;
-          let it = iterateChildren(this.el);
-          let current = it.next();
-          let isFirstParagraph = true;
-          while (!current.done && current.value !== nodeToFind) {
-              if (!current.value.hasChildNodes()) {
-                  if (current.value.textContent) {
-                      usedCharacters += current.value.textContent.length;
-                  }
-              }
-              // One new paragraph = one new line character, except for the first paragraph
-              if (current.value.nodeName === "P" ||
-                  (current.value.nodeName === "DIV" && current.value !== this.el) // On paste, the HTML may contain <div> instead of <p>
-              ) {
-                  if (isFirstParagraph) {
-                      isFirstParagraph = false;
-                  }
-                  else {
-                      usedCharacters++;
-                  }
-              }
-              current = it.next();
-          }
-          if (current.value !== nodeToFind) {
-              /** This situation can happen if the code is called while the selection is not currently on the ContentEditableHelper.
-               * In this case, we return 0 because we don't know the size of the text before the selection.
-               *
-               * A known occurence is triggered since the introduction of commit d4663158 (PR #2038).
-               *
-               * FIXME: find a way to test eventhough the selection API is not available in jsDOM.
-               */
-              return 0;
-          }
-          else {
-              if (!current.value.hasChildNodes()) {
-                  usedCharacters += nodeOffset;
-              }
-              else {
-                  const children = [...current.value.childNodes].slice(0, nodeOffset);
-                  usedCharacters += children.reduce((acc, child, index) => {
-                      if (child.textContent !== null) {
-                          // need to account for paragraph nodes that implicitely add a new line
-                          // except for the last paragraph
-                          let chars = child.textContent.length;
-                          if (child.nodeName === "P" && index !== children.length - 1) {
-                              chars++;
-                          }
-                          return acc + chars;
-                      }
-                      else {
-                          return acc;
-                      }
-                  }, 0);
-              }
-          }
-          if (nodeToFind.nodeName === "P" && !isFirstParagraph && nodeToFind.textContent === "") {
-              usedCharacters++;
-          }
-          return usedCharacters;
-      }
-      getStartAndEndSelection() {
-          const selection = document.getSelection();
-          return {
-              startElement: selection.anchorNode || this.el,
-              startSelectionOffset: selection.anchorOffset,
-              endElement: selection.focusNode || this.el,
-              endSelectionOffset: selection.focusOffset,
-          };
+          return getCurrentSelection(this.el);
       }
       getText() {
           let text = "";
@@ -40873,6 +40903,12 @@ stores.inject(MyMetaStore, storeInstance);
               }
               this.contentHelper.updateEl(el);
           });
+          this.env.model.selection.observe(this, {
+              handleEvent: () => this.autoCompleteState.hide(),
+          });
+          owl.onWillUnmount(() => {
+              this.env.model.selection.detachObserver(this);
+          });
           owl.useEffect(() => {
               this.processContent();
               if (document.activeElement === this.contentHelper.el &&
@@ -49212,7 +49248,7 @@ stores.inject(MyMetaStore, storeInstance);
               axisStartEndPositions.push({ x: axis.position, y: figure.y + figure.height });
               break;
       }
-      return axisStartEndPositions.some(getters.isPositionVisible);
+      return axisStartEndPositions.some(getters.isPixelPositionVisible);
   }
   /**
    * Get a snap line for the given figure, if the figure can snap to any other figure
@@ -51239,8 +51275,8 @@ stores.inject(MyMetaStore, storeInstance);
                   previousColIndex = col;
               }
               else {
-                  nextColIndex = this.findNextEmptyCol(col, right, row);
-                  previousColIndex = this.findPreviousEmptyCol(col, left, row);
+                  nextColIndex = box.border?.right ? zone.right : this.findNextEmptyCol(col, right, row);
+                  previousColIndex = box.border?.left ? zone.left : this.findPreviousEmptyCol(col, left, row);
                   box.isOverflow = true;
               }
               switch (align) {
@@ -52713,7 +52749,7 @@ stores.inject(MyMetaStore, storeInstance);
                       // map and slice preserve empty values and do not set `undefined` instead
                       const bordersCopy = borders
                           .slice()
-                          .map((col) => col?.slice().map((border) => ({ ...border })));
+                          .map((col) => col?.slice().map((border) => deepCopy(border)));
                       this.history.update("borders", cmd.sheetIdTo, bordersCopy);
                   }
                   break;
@@ -52743,32 +52779,12 @@ stores.inject(MyMetaStore, storeInstance);
                   const elements = [...cmd.elements].sort((a, b) => b - a);
                   for (const group of groupConsecutive(elements)) {
                       if (cmd.dimension === "COL") {
-                          if (group[0] >= this.getters.getNumberCols(cmd.sheetId)) {
-                              for (let row = 0; row < this.getters.getNumberRows(cmd.sheetId); row++) {
-                                  this.history.update("borders", cmd.sheetId, group[0] + 1, row, "vertical", undefined);
-                              }
-                          }
-                          if (group[group.length - 1] === 0) {
-                              for (let row = 0; row < this.getters.getNumberRows(cmd.sheetId); row++) {
-                                  this.history.update("borders", cmd.sheetId, 0, row, "vertical", undefined);
-                              }
-                          }
-                          const zone = this.getters.getColsZone(cmd.sheetId, group[group.length - 1] + 1, group[0]);
+                          const zone = this.getters.getColsZone(cmd.sheetId, group[group.length - 1], group[0]);
                           this.clearInsideBorders(cmd.sheetId, [zone]);
                           this.shiftBordersHorizontally(cmd.sheetId, group[0] + 1, -group.length);
                       }
                       else {
-                          if (group[0] >= this.getters.getNumberRows(cmd.sheetId)) {
-                              for (let col = 0; col < this.getters.getNumberCols(cmd.sheetId); col++) {
-                                  this.history.update("borders", cmd.sheetId, col, group[0] + 1, "horizontal", undefined);
-                              }
-                          }
-                          if (group[group.length - 1] === 0) {
-                              for (let col = 0; col < this.getters.getNumberCols(cmd.sheetId); col++) {
-                                  this.history.update("borders", cmd.sheetId, col, 0, "horizontal", undefined);
-                              }
-                          }
-                          const zone = this.getters.getRowsZone(cmd.sheetId, group[group.length - 1] + 1, group[0]);
+                          const zone = this.getters.getRowsZone(cmd.sheetId, group[group.length - 1], group[0]);
                           this.clearInsideBorders(cmd.sheetId, [zone]);
                           this.shiftBordersVertically(cmd.sheetId, group[0] + 1, -group.length);
                       }
@@ -52793,16 +52809,12 @@ stores.inject(MyMetaStore, storeInstance);
           let colLeftOfInsertion;
           let colRightOfInsertion;
           if (cmd.position === "before") {
-              this.shiftBordersHorizontally(cmd.sheetId, cmd.base, cmd.quantity, {
-                  moveFirstLeftBorder: true,
-              });
+              this.shiftBordersHorizontally(cmd.sheetId, cmd.base, cmd.quantity);
               colLeftOfInsertion = cmd.base - 1;
               colRightOfInsertion = cmd.base + cmd.quantity;
           }
           else {
-              this.shiftBordersHorizontally(cmd.sheetId, cmd.base + 1, cmd.quantity, {
-                  moveFirstLeftBorder: false,
-              });
+              this.shiftBordersHorizontally(cmd.sheetId, cmd.base + 1, cmd.quantity);
               colLeftOfInsertion = cmd.base;
               colRightOfInsertion = cmd.base + cmd.quantity + 1;
           }
@@ -52817,16 +52829,12 @@ stores.inject(MyMetaStore, storeInstance);
           let rowAboveInsertion;
           let rowBelowInsertion;
           if (cmd.position === "before") {
-              this.shiftBordersVertically(cmd.sheetId, cmd.base, cmd.quantity, {
-                  moveFirstTopBorder: true,
-              });
+              this.shiftBordersVertically(cmd.sheetId, cmd.base, cmd.quantity);
               rowAboveInsertion = cmd.base - 1;
               rowBelowInsertion = cmd.base + cmd.quantity;
           }
           else {
-              this.shiftBordersVertically(cmd.sheetId, cmd.base + 1, cmd.quantity, {
-                  moveFirstTopBorder: false,
-              });
+              this.shiftBordersVertically(cmd.sheetId, cmd.base + 1, cmd.quantity);
               rowAboveInsertion = cmd.base;
               rowBelowInsertion = cmd.base + cmd.quantity + 1;
           }
@@ -52836,16 +52844,8 @@ stores.inject(MyMetaStore, storeInstance);
       // Getters
       // ---------------------------------------------------------------------------
       getCellBorder({ sheetId, col, row }) {
-          const border = {
-              top: this.borders[sheetId]?.[col]?.[row]?.horizontal,
-              bottom: this.borders[sheetId]?.[col]?.[row + 1]?.horizontal,
-              left: this.borders[sheetId]?.[col]?.[row]?.vertical,
-              right: this.borders[sheetId]?.[col + 1]?.[row]?.vertical,
-          };
-          if (!border.bottom && !border.left && !border.right && !border.top) {
-              return null;
-          }
-          return border;
+          const border = this.borders[sheetId]?.[col]?.[row];
+          return border?.top || border?.bottom || border?.left || border?.right ? deepCopy(border) : null;
       }
       getBordersColors(sheetId) {
           const colors = [];
@@ -52853,11 +52853,13 @@ stores.inject(MyMetaStore, storeInstance);
           if (sheetBorders) {
               for (const borders of sheetBorders.filter(isDefined)) {
                   for (const cellBorder of borders) {
-                      if (cellBorder?.horizontal) {
-                          colors.push(cellBorder.horizontal.color);
-                      }
-                      if (cellBorder?.vertical) {
-                          colors.push(cellBorder.vertical.color);
+                      if (cellBorder) {
+                          for (const direction of ["top", "bottom", "left", "right"]) {
+                              const color = cellBorder[direction]?.color;
+                              if (color) {
+                                  colors.push(color);
+                              }
+                          }
                       }
                   }
               }
@@ -52910,7 +52912,7 @@ stores.inject(MyMetaStore, storeInstance);
       getCommonSides(border1, border2) {
           const commonBorder = {};
           for (let side of ["top", "bottom", "left", "right"]) {
-              if (border1[side] && border1[side] === border2[side]) {
+              if (border1[side] && deepEquals(border1[side], border2[side])) {
                   commonBorder[side] = border1[side];
               }
           }
@@ -52955,23 +52957,15 @@ stores.inject(MyMetaStore, storeInstance);
        * @param start starting column (included)
        * @param delta how much borders will be moved (negative if moved to the left)
        */
-      shiftBordersHorizontally(sheetId, start, delta, { moveFirstLeftBorder } = {}) {
+      shiftBordersHorizontally(sheetId, start, delta) {
           const borders = this.borders[sheetId];
           if (!borders)
               return;
-          if (delta < 0) {
-              this.moveBordersOfColumn(sheetId, start, delta, "vertical", {
-                  destructive: false,
-              });
-          }
           this.getColumnsWithBorders(sheetId)
               .filter((col) => col >= start)
               .sort((a, b) => (delta < 0 ? a - b : b - a)) // start by the end when moving up
               .forEach((col) => {
-              if ((col === start && moveFirstLeftBorder) || col !== start) {
-                  this.moveBordersOfColumn(sheetId, col, delta, "vertical");
-              }
-              this.moveBordersOfColumn(sheetId, col, delta, "horizontal");
+              this.moveBordersOfColumn(sheetId, col, delta);
           });
       }
       /**
@@ -52980,12 +52974,12 @@ stores.inject(MyMetaStore, storeInstance);
        * @param start starting row (included)
        * @param delta how much borders will be moved (negative if moved to the above)
        */
-      shiftBordersVertically(sheetId, start, delta, { moveFirstTopBorder } = {}) {
+      shiftBordersVertically(sheetId, start, delta) {
           const borders = this.borders[sheetId];
           if (!borders)
               return;
           if (delta < 0) {
-              this.moveBordersOfRow(sheetId, start, delta, "horizontal", {
+              this.moveBordersOfRow(sheetId, start, delta, {
                   destructive: false,
               });
           }
@@ -52993,10 +52987,7 @@ stores.inject(MyMetaStore, storeInstance);
               .filter((row) => row >= start)
               .sort((a, b) => (delta < 0 ? a - b : b - a)) // start by the end when moving up
               .forEach((row) => {
-              if ((row === start && moveFirstTopBorder) || row !== start) {
-                  this.moveBordersOfRow(sheetId, row, delta, "horizontal");
-              }
-              this.moveBordersOfRow(sheetId, row, delta, "vertical");
+              this.moveBordersOfRow(sheetId, row, delta);
           });
       }
       /**
@@ -53010,15 +53001,15 @@ stores.inject(MyMetaStore, storeInstance);
        * argument `destructive` is given false, the target border is preserved if
        * the moved border is empty
        */
-      moveBordersOfRow(sheetId, row, delta, borderDirection, { destructive } = { destructive: true }) {
+      moveBordersOfRow(sheetId, row, delta, { destructive } = { destructive: true }) {
           const borders = this.borders[sheetId];
           if (!borders)
               return;
           this.getColumnsWithBorders(sheetId).forEach((col) => {
-              const targetBorder = borders[col]?.[row + delta]?.[borderDirection];
-              const movedBorder = borders[col]?.[row]?.[borderDirection];
-              this.history.update("borders", sheetId, col, row + delta, borderDirection, destructive ? movedBorder : movedBorder || targetBorder);
-              this.history.update("borders", sheetId, col, row, borderDirection, undefined);
+              const targetBorder = borders[col]?.[row + delta];
+              const movedBorder = borders[col]?.[row];
+              this.history.update("borders", sheetId, col, row + delta, destructive ? movedBorder : movedBorder || targetBorder);
+              this.history.update("borders", sheetId, col, row, undefined);
           });
       }
       /**
@@ -53032,15 +53023,17 @@ stores.inject(MyMetaStore, storeInstance);
        * argument `destructive` is given false, the target border is preserved if
        * the moved border is empty
        */
-      moveBordersOfColumn(sheetId, col, delta, borderDirection, { destructive } = { destructive: true }) {
+      moveBordersOfColumn(sheetId, col, delta, { destructive } = { destructive: true }) {
           const borders = this.borders[sheetId];
           if (!borders)
               return;
           this.getRowsRange(sheetId).forEach((row) => {
-              const targetBorder = borders[col + delta]?.[row]?.[borderDirection];
-              const movedBorder = borders[col]?.[row]?.[borderDirection];
-              this.history.update("borders", sheetId, col + delta, row, borderDirection, destructive ? movedBorder : movedBorder || targetBorder);
-              this.history.update("borders", sheetId, col, row, borderDirection, undefined);
+              const targetBorder = borders[col + delta]?.[row];
+              const movedBorder = borders[col]?.[row];
+              this.history.update("borders", sheetId, col + delta, row, destructive ? movedBorder : movedBorder || targetBorder);
+              if (destructive) {
+                  this.history.update("borders", sheetId, col, row, undefined);
+              }
           });
       }
       /**
@@ -53048,33 +53041,69 @@ stores.inject(MyMetaStore, storeInstance);
        * It overrides the current border if override === true.
        */
       setBorder(sheetId, col, row, border, override = true) {
-          if (override || !this.borders?.[sheetId]?.[col]?.[row]?.vertical) {
-              this.history.update("borders", sheetId, col, row, "vertical", border?.left);
+          const maxCol = this.getters.getNumberCols(sheetId) - 1;
+          const maxRow = this.getters.getNumberRows(sheetId) - 1;
+          if (override || !this.borders[sheetId]?.[col]?.[row]?.left) {
+              this.history.update("borders", sheetId, col, row, "left", border?.left);
+              if (border?.left &&
+                  col > 0 &&
+                  !deepEquals(this.getCellBorder({ sheetId, col: col - 1, row })?.right, border?.left)) {
+                  this.history.update("borders", sheetId, col - 1, row, "right", undefined);
+              }
           }
-          if (override || !this.borders?.[sheetId]?.[col]?.[row]?.horizontal) {
-              this.history.update("borders", sheetId, col, row, "horizontal", border?.top);
+          if (override || !this.borders[sheetId]?.[col]?.[row]?.top) {
+              this.history.update("borders", sheetId, col, row, "top", border?.top);
+              if (border?.top &&
+                  row > 0 &&
+                  !deepEquals(this.getCellBorder({ sheetId, col, row: row - 1 })?.bottom, border?.top)) {
+                  this.history.update("borders", sheetId, col, row - 1, "bottom", undefined);
+              }
           }
-          if (override || !this.borders?.[sheetId]?.[col + 1]?.[row]?.vertical) {
-              this.history.update("borders", sheetId, col + 1, row, "vertical", border?.right);
+          if (override || !this.borders[sheetId]?.[col]?.[row]?.right) {
+              this.history.update("borders", sheetId, col, row, "right", border?.right);
+              if (border?.right &&
+                  col < maxCol &&
+                  !deepEquals(this.getCellBorder({ sheetId, col: col + 1, row })?.left, border?.right)) {
+                  this.history.update("borders", sheetId, col + 1, row, "left", undefined);
+              }
           }
-          if (override || !this.borders?.[sheetId]?.[col]?.[row + 1]?.horizontal) {
-              this.history.update("borders", sheetId, col, row + 1, "horizontal", border?.bottom);
+          if (override || !this.borders[sheetId]?.[col]?.[row]?.bottom) {
+              this.history.update("borders", sheetId, col, row, "bottom", border?.bottom);
+              if (border?.bottom &&
+                  row < maxRow &&
+                  !deepEquals(this.getCellBorder({ sheetId, col, row: row + 1 })?.top, border?.bottom)) {
+                  this.history.update("borders", sheetId, col, row + 1, "top", undefined);
+              }
           }
       }
       /**
        * Remove the borders of a zone
        */
-      clearBorders(sheetId, zones) {
+      clearBorders(sheetId, zones, eraseBoundaries = false) {
+          const maxCol = this.getters.getNumberCols(sheetId) - 1;
+          const maxRow = this.getters.getNumberRows(sheetId) - 1;
           for (let zone of recomputeZones(zones)) {
               for (let row = zone.top; row <= zone.bottom; row++) {
-                  this.history.update("borders", sheetId, zone.right + 1, row, "vertical", undefined);
+                  if (eraseBoundaries) {
+                      if (zone.left > 0) {
+                          this.history.update("borders", sheetId, zone.left - 1, row, "right", undefined);
+                      }
+                      if (zone.right < maxCol) {
+                          this.history.update("borders", sheetId, zone.right + 1, row, "left", undefined);
+                      }
+                  }
                   for (let col = zone.left; col <= zone.right; col++) {
                       this.history.update("borders", sheetId, col, row, undefined);
+                      if (eraseBoundaries) {
+                          if (zone.top > 0) {
+                              this.history.update("borders", sheetId, col, zone.top - 1, "bottom", undefined);
+                          }
+                          if (zone.bottom < maxRow) {
+                              this.history.update("borders", sheetId, col, zone.bottom + 1, "top", undefined);
+                          }
+                      }
                   }
               }
-              for (let col = zone.left; col <= zone.right; col++) {
-                  this.history.update("borders", sheetId, col, zone.bottom + 1, "horizontal", undefined);
-              }
           }
       }
       /**
@@ -53104,41 +53133,63 @@ stores.inject(MyMetaStore, storeInstance);
        */
       setBorders(sheetId, zones, position, border) {
           if (position === "clear") {
-              return this.clearBorders(sheetId, zones);
+              return this.clearBorders(sheetId, zones, true);
           }
           for (let zone of recomputeZones(zones)) {
-              if (position === "h" || position === "hv" || position === "all") {
-                  for (let row = zone.top + 1; row <= zone.bottom; row++) {
+              if (position === "all") {
+                  for (let row = zone.top; row <= zone.bottom; row++) {
                       for (let col = zone.left; col <= zone.right; col++) {
-                          this.addBorder(sheetId, col, row, { top: border });
+                          this.addBorder(sheetId, col, row, {
+                              top: border,
+                              right: border,
+                              bottom: border,
+                              left: border,
+                          });
+                      }
+                  }
+              }
+              if (position === "h" || position === "hv") {
+                  if (zone.top === zone.bottom) {
+                      continue;
+                  }
+                  for (let col = zone.left; col <= zone.right; col++) {
+                      this.addBorder(sheetId, col, zone.top, { bottom: border });
+                      for (let row = zone.top + 1; row < zone.bottom; row++) {
+                          this.addBorder(sheetId, col, row, { top: border, bottom: border });
                       }
+                      this.addBorder(sheetId, col, zone.bottom, { top: border });
                   }
               }
-              if (position === "v" || position === "hv" || position === "all") {
+              if (position === "v" || position === "hv") {
+                  if (zone.left === zone.right) {
+                      continue;
+                  }
                   for (let row = zone.top; row <= zone.bottom; row++) {
-                      for (let col = zone.left + 1; col <= zone.right; col++) {
-                          this.addBorder(sheetId, col, row, { left: border });
+                      this.addBorder(sheetId, zone.left, row, { right: border });
+                      for (let col = zone.left + 1; col < zone.right; col++) {
+                          this.addBorder(sheetId, col, row, { left: border, right: border });
                       }
+                      this.addBorder(sheetId, zone.right, row, { left: border });
                   }
               }
-              if (position === "left" || position === "all" || position === "external") {
+              if (position === "left" || position === "external") {
                   for (let row = zone.top; row <= zone.bottom; row++) {
                       this.addBorder(sheetId, zone.left, row, { left: border });
                   }
               }
-              if (position === "right" || position === "all" || position === "external") {
+              if (position === "right" || position === "external") {
                   for (let row = zone.top; row <= zone.bottom; row++) {
-                      this.addBorder(sheetId, zone.right + 1, row, { left: border });
+                      this.addBorder(sheetId, zone.right, row, { right: border });
                   }
               }
-              if (position === "top" || position === "all" || position === "external") {
+              if (position === "top" || position === "external") {
                   for (let col = zone.left; col <= zone.right; col++) {
                       this.addBorder(sheetId, col, zone.top, { top: border });
                   }
               }
-              if (position === "bottom" || position === "all" || position === "external") {
+              if (position === "bottom" || position === "external") {
                   for (let col = zone.left; col <= zone.right; col++) {
-                      this.addBorder(sheetId, col, zone.bottom + 1, { top: border });
+                      this.addBorder(sheetId, col, zone.bottom, { bottom: border });
                   }
               }
           }
@@ -54684,10 +54735,20 @@ stores.inject(MyMetaStore, storeInstance);
           for (const sheet of data.sheets) {
               sheet.dataValidationRules = [];
               for (const rule of this.rules[sheet.id]) {
-                  sheet.dataValidationRules.push({
-                      ...rule,
+                  const excelRule = {
+                      ...deepCopy(rule),
                       ranges: rule.ranges.map((range) => this.getters.getRangeString(range, sheet.id, { useBoundedReference: true })),
-                  });
+                  };
+                  if (rule.criterion.type === "isValueInRange") {
+                      excelRule.criterion.values = rule.criterion.values.map((value) => {
+                          const range = this.getters.getRangeFromSheetXC(sheet.id, value);
+                          return this.getters.getRangeString(range, sheet.id, {
+                              useBoundedReference: true,
+                              useFixedReference: true,
+                          });
+                      });
+                  }
+                  sheet.dataValidationRules.push(excelRule);
               }
           }
       }
@@ -56108,9 +56169,10 @@ stores.inject(MyMetaStore, storeInstance);
        * @param range the range (received from getRangeFromXC or getRangeFromZone)
        * @param forSheetId the id of the sheet where the range string is supposed to be used.
        * @param options
-       * @param options.useBoundedReference if true, the range will be returned with fixed row and column
+       * @param options.useBoundedReference if true, the range will be returned with bounded row and column
+       * @param options.useFixedReference if true, the range will be returned with fixed row and column
        */
-      getRangeString(range, forSheetId, options = { useBoundedReference: false }) {
+      getRangeString(range, forSheetId, options = { useBoundedReference: false, useFixedReference: false }) {
           if (!range) {
               return CellErrorType.InvalidReference;
           }
@@ -56213,10 +56275,10 @@ stores.inject(MyMetaStore, storeInstance);
       /**
        * Get a Xc string that represent a part of a range
        */
-      getRangePartString(range, part, options = { useBoundedReference: false }) {
-          const colFixed = range.parts && range.parts[part]?.colFixed ? "$" : "";
+      getRangePartString(range, part, options = { useBoundedReference: false, useFixedReference: false }) {
+          const colFixed = range.parts[part]?.colFixed || options.useFixedReference ? "$" : "";
           const col = part === 0 ? numberToLetters(range.zone.left) : numberToLetters(range.zone.right);
-          const rowFixed = range.parts && range.parts[part]?.rowFixed ? "$" : "";
+          const rowFixed = range.parts[part]?.rowFixed || options.useFixedReference ? "$" : "";
           const row = part === 0 ? String(range.zone.top + 1) : String(range.zone.bottom + 1);
           let str = "";
           if (range.isFullCol && !options.useBoundedReference) {
@@ -59872,7 +59934,11 @@ stores.inject(MyMetaStore, storeInstance);
       computeFormulaCell(formulaPosition, cellData) {
           const formulaReturn = updateEvalContextAndExecute(cellData.compiledFormula, this.compilationParams, formulaPosition.sheetId, this.buildSafeGetSymbolValue(), formulaPosition);
           if (!isMatrix(formulaReturn)) {
-              return createEvaluatedCell(nullValueToZeroValue(formulaReturn), this.getters.getLocale(), cellData);
+              const evaluatedCell = createEvaluatedCell(nullValueToZeroValue(formulaReturn), this.getters.getLocale(), cellData);
+              if (evaluatedCell.type === CellValueType.error) {
+                  evaluatedCell.errorOriginPosition = formulaReturn.errorOriginPosition ?? formulaPosition;
+              }
+              return evaluatedCell;
           }
           this.assertSheetHasEnoughSpaceToSpreadFormulaResult(formulaPosition, formulaReturn);
           const nbColumns = formulaReturn.length;
@@ -59945,6 +60011,9 @@ stores.inject(MyMetaStore, storeInstance);
               const position = { sheetId, col: i + col, row: j + row };
               const cell = this.getters.getCell(position);
               const evaluatedCell = createEvaluatedCell(nullValueToZeroValue(matrixResult[i][j]), this.getters.getLocale(), cell);
+              if (evaluatedCell.type === CellValueType.error) {
+                  evaluatedCell.errorOriginPosition = matrixResult[i][j].errorOriginPosition ?? position;
+              }
               this.evaluatedCells.set(position, evaluatedCell);
           };
           return spreadValues;
@@ -61503,7 +61572,7 @@ stores.inject(MyMetaStore, storeInstance);
                       const symbolIndex = rowDomain.findIndex((row) => row.field === symbolName);
                       return this.getPivotHeaderValueAndFormat(rowDomain.slice(0, symbolIndex + 1));
                   }
-                  return this._getPivotCellValueAndFormat(symbolName, domain);
+                  return this.getPivotCellValueAndFormat(symbolName, domain);
               };
               const result = this.getters.evaluateCompiledFormula(measure.computedBy.sheetId, formula, getSymbolValue);
               if (isMatrix(result)) {
@@ -63402,6 +63471,7 @@ stores.inject(MyMetaStore, storeInstance);
       waitingUndoRedoAck = false;
       isReplayingInitialRevisions = false;
       processedRevisions = new Set();
+      lastRevisionMessage = undefined;
       uuidGenerator = new UuidGenerator();
       lastLocalOperation;
       /**
@@ -63502,7 +63572,10 @@ stores.inject(MyMetaStore, storeInstance);
        * Notify the server that the user client left the collaborative session
        */
       async leave(data) {
-          if (data && Object.keys(this.clients).length === 1 && this.processedRevisions.size) {
+          if (data &&
+              Object.keys(this.clients).length === 1 &&
+              this.lastRevisionMessage &&
+              this.lastRevisionMessage?.type !== "SNAPSHOT_CREATED") {
               await this.snapshot(data());
           }
           delete this.clients[this.clientId];
@@ -63723,6 +63796,7 @@ stores.inject(MyMetaStore, storeInstance);
                   this.pendingMessages = this.pendingMessages.filter((msg) => msg.nextRevisionId !== message.nextRevisionId);
                   this.serverRevisionId = message.nextRevisionId;
                   this.processedRevisions.add(message.nextRevisionId);
+                  this.lastRevisionMessage = message;
                   this.sendPendingMessage();
                   break;
           }
@@ -64684,14 +64758,12 @@ stores.inject(MyMetaStore, storeInstance);
                   }
                   break;
               case "AUTORESIZE_ROWS":
-                  for (let row of cmd.rows) {
-                      this.dispatch("RESIZE_COLUMNS_ROWS", {
-                          elements: [row],
-                          dimension: "ROW",
-                          size: null,
-                          sheetId: cmd.sheetId,
-                      });
-                  }
+                  this.dispatch("RESIZE_COLUMNS_ROWS", {
+                      elements: cmd.rows,
+                      dimension: "ROW",
+                      size: null,
+                      sheetId: cmd.sheetId,
+                  });
                   break;
           }
       }
@@ -67442,7 +67514,7 @@ stores.inject(MyMetaStore, storeInstance);
           "getSheetViewVisibleCols",
           "getSheetViewVisibleRows",
           "getFrozenSheetViewRatio",
-          "isPositionVisible",
+          "isPixelPositionVisible",
           "getColDimensionsInViewport",
           "getRowDimensionsInViewport",
           "getAllActiveViewportsZones",
@@ -68066,7 +68138,7 @@ stores.inject(MyMetaStore, storeInstance);
           }
           return result;
       }
-      isPositionVisible(position) {
+      isPixelPositionVisible(position) {
           const { scrollX, scrollY } = this.getters.getActiveSheetScrollInfo();
           const { x: mainViewportX, y: mainViewportY } = this.getters.getMainViewportCoordinates();
           const { width, height } = this.getters.getSheetViewDimension();
@@ -70461,12 +70533,8 @@ stores.inject(MyMetaStore, storeInstance);
   .o-spreadsheet {
     position: relative;
     display: grid;
-    color: ${TEXT_BODY};
     font-size: 14px;
 
-    input {
-      background-color: white;
-    }
     .text-muted {
       color: ${TEXT_BODY_MUTED} !important;
     }
@@ -71713,6 +71781,9 @@ stores.inject(MyMetaStore, storeInstance);
       observe(owner, callbacks) {
           this.observers.set(owner, { owner, callbacks });
       }
+      detachObserver(owner) {
+          this.observers.delete(owner);
+      }
       /**
        * Capture the stream for yourself
        */
@@ -71805,6 +71876,9 @@ stores.inject(MyMetaStore, storeInstance);
       observe(owner, callbacks) {
           this.stream.observe(owner, callbacks);
       }
+      detachObserver(owner) {
+          this.stream.detachObserver(owner);
+      }
       release(owner) {
           if (this.stream.isListening(owner)) {
               this.stream.release(owner);
@@ -75254,9 +75328,9 @@ stores.inject(MyMetaStore, storeInstance);
   exports.tokenize = tokenize;
 
 
-  __info__.version = "18.2.0-alpha.3";
-  __info__.date = "2025-01-27T10:07:28.716Z";
-  __info__.hash = "63a13e5";
+  __info__.version = "18.2.0-alpha.5";
+  __info__.date = "2025-01-31T07:59:30.667Z";
+  __info__.hash = "efce841";
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);